| f428ca9b | 08-Mar-2023 |
Will Schurman <[email protected]> |
[exupdates][ios] Decrease access control on classes and remove unnecessary objc attributes (#21597)
# Why
Now that most things are in swift, we no longer need
`objc`/`objcMembers` on a lot of ou
[exupdates][ios] Decrease access control on classes and remove unnecessary objc attributes (#21597)
# Why
Now that most things are in swift, we no longer need
`objc`/`objcMembers` on a lot of our classes (only the bare minimum of
what is accessed externally).
We also don't need public on a lot of things since they are internal.
This change is slightly riskier since there may be people importing
classes from this.
We also can declare a lot of classes final. This is somewhat risky as
well since there may be a subset of the people mentioned above who are
extending these.
Really, what we should do is sit down and figure out what the external
interface for this is.
# How
Go through all classes and remove unnecessary things.
# Test Plan
Build Expo Go.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|