| #
17709897 |
| 10-Mar-2023 |
Will Schurman <[email protected]> |
[exupdates][ios] Run swiftlint --fix (#21664)
# Why
To appease the swiftlint gods.
# Test Plan
Build.
# Checklist
<!--
Please check the appropriate items below if they apply to your
[exupdates][ios] Run swiftlint --fix (#21664)
# Why
To appease the swiftlint gods.
# Test Plan
Build.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
f428ca9b |
| 08-Mar-2023 |
Will Schurman <[email protected]> |
[exupdates][ios] Decrease access control on classes and remove unnecessary objc attributes (#21597)
# Why
Now that most things are in swift, we no longer need
`objc`/`objcMembers` on a lot of ou
[exupdates][ios] Decrease access control on classes and remove unnecessary objc attributes (#21597)
# Why
Now that most things are in swift, we no longer need
`objc`/`objcMembers` on a lot of our classes (only the bare minimum of
what is accessed externally).
We also don't need public on a lot of things since they are internal.
This change is slightly riskier since there may be people importing
classes from this.
We also can declare a lot of classes final. This is somewhat risky as
well since there may be a subset of the people mentioned above who are
extending these.
Really, what we should do is sit down and figure out what the external
interface for this is.
# How
Go through all classes and remove unnecessary things.
# Test Plan
Build Expo Go.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
d2ecfbc4 |
| 27-Oct-2022 |
Will Schurman <[email protected]> |
[expo-updates] Add code signing logging (#19589)
|
| #
9bd3e43c |
| 01-Sep-2022 |
Douglas Lowder <[email protected]> |
[expo-updates] Add log lines for the error scenarios we want to track (#18810)
|
| #
7d5f3528 |
| 15-Aug-2022 |
Douglas Lowder <[email protected]> |
Persistent logging for expo-updates (#18513)
iOS:
- PersistentFileLog (class to write logs to a flat file)
- New PersistentLogHandler in LogHandler.swift
- OptionSet in Logger to use the new hand
Persistent logging for expo-updates (#18513)
iOS:
- PersistentFileLog (class to write logs to a flat file)
- New PersistentLogHandler in LogHandler.swift
- OptionSet in Logger to use the new handler (and support for future additions)
- Modify UpdatesLogger and UpdatesLogReader to use the above in place of OSLogReader
- Modify EXUpdatesModule to implement clearing the log file
- Unit tests for the above
- Modify EXUpdatesAppController to automatically purge old log entries on start
Android:
- New Logger and associated classes in expo-modules-core, same structure as iOS
- PersistentFileLog (class to write logs to a flat file)
- Options class LoggerOptions to use the new handler (and support for future additions)
- Modify UpdatesLogger and UpdatesLogReader to use the above in place of Android OS logging
- Modify UpdatesModule to implement clearing the log file
- Unit tests for the above
- Modify UpdatesController to automatically purge old log entries on start
show more ...
|
| #
6e2900b2 |
| 21-Jul-2022 |
Douglas Lowder <[email protected]> |
[expo-updates][iOS] Logging and log reading (#18284)
|