[android][store-review] Migrate expo-store-review to the new native m… (#19898)Why Migrating modules to use the new modules API. How Followed examples from other expo libraries that have compl
[android][store-review] Migrate expo-store-review to the new native m… (#19898)Why Migrating modules to use the new modules API. How Followed examples from other expo libraries that have completed the migration Test Plan Running in the test app. I couldn't test one part as it requires a play store URL and the app has to have been published to an internal test track. Maybe I'm missing something that someone can help me with. I also wasn't sure of the correct way to make changes to the modules build.gradle.
show more ...
[expo-store-review][Android] Update rejection message when review flow fails (#16365)
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core`
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core` # How - Change package using AS refactor tools - Fix some places where AS wasn't able to do automatically - Fix compatibility with new auto-linking - Ensure that classes which are used during installation steps are still available in the old place # Test Plan - expo-go (tested using unversioned and 41) - bare-expo
[android] lint spotless ktlint and fix CI step (#13662)
[android] Add kotlin spotless ktlint linter (#12545)
[expo-store-review] Fix Android crash in failure path (#10265)The failure path in StoreReviewModule.kt calls `promise.reject(null)` which leads to the following crash: ``` Attempt to invoke vir
[expo-store-review] Fix Android crash in failure path (#10265)The failure path in StoreReviewModule.kt calls `promise.reject(null)` which leads to the following crash: ``` Attempt to invoke virtual method 'java.lang.String java.lang.Throwable.getMessage()' on a null object reference ``` Full stack trace at: https://sentry.io/share/issue/74f1816267964b74959ea614f36f2d7c/ I've been seeing a couple of these crashes per day in production. This is in a bare app using Expo SDK 38 with the expo-store-review module cherry-picked up to v2.2.0 to get the recently-added Android implementation. I believe there's some issue with calling the (overloaded) single-argument form of `Promise.reject()` from Kotlin code with a `null` argument. This patch just switches to the two-argument form where you pass an error code and message. (see packages/@unimodules/core/android/src/main/java/org/unimodules/core/Promise.java)
[android][store-review] Implement native In-App Review for Android (#9607)