| #
d044143f |
| 04-Mar-2021 |
Charlie Cruzan <[email protected]> |
[notifications][ios] Scope notification identifiers (#12055)
* create method to override request IDs
* scope notification request IDs in Expo Go
* add method to Presentation header file
* r
[notifications][ios] Scope notification identifiers (#12055)
* create method to override request IDs
* scope notification request IDs in Expo Go
* add method to Presentation header file
* rename scoping methods to be more general (not just category IDs are scoped)
* only scope emitterModule, handlerModule, and presentationModule in Expo Go
show more ...
|
| #
d7188e77 |
| 30-Mar-2020 |
Stanisław Chmiela <[email protected]> |
[expo-notifications] Deprecate `presentNotificationAsync` (#7497)
# Why
On iOS, calling `presentNotificationAsync` internally does `addNotificationRequest:` with a `nil` trigger, which makes the
[expo-notifications] Deprecate `presentNotificationAsync` (#7497)
# Why
On iOS, calling `presentNotificationAsync` internally does `addNotificationRequest:` with a `nil` trigger, which makes the notification request go all around and eg. trigger `willPresentNotification:`, etc.
Thanks to a flexible architecture we can support presenting the notification, but it feels like allowing the developers not to set a notification handler which is highly encouraged (instead of relying on library defaults). I have talked with Bartek and Tomasz and we've decided that deprecating `presentNotificationAsync` while presenting a smooth path one can take to migrate to the new API may be the best option for now.
# How
- added `NotificationPresentationModule` as `NotificationCenterDelegate`s listener
- `PresentationModule` holds a counted set of notification identifiers, if an identifier of the to-be-presented notification is in that set, the notification will be presented with all the presentation options
- deprecated `presentNotificationAsync` by showing a warning message once per application run (when `__DEV__` is `true`). The warning message contains a link redirecting to https://github.com/expo/fyi/pull/2
# Test Plan
`presentNotificationAsync` presents the notification even if there is no `setNotificationHandler` set.
show more ...
|
| #
56128cf9 |
| 18-Feb-2020 |
Stanisław Chmiela <[email protected]> |
[expo-notifications] Presenting notifications (#6932)
# Why
Another feature for `expo-notifications`.
# How
On top of `@sjchmiela/expo-notifications-building-notifications`:
- added _prese
[expo-notifications] Presenting notifications (#6932)
# Why
Another feature for `expo-notifications`.
# How
On top of `@sjchmiela/expo-notifications-building-notifications`:
- added _presenter_ modules, which basically just pass in an object-y request to builders
# Test Plan
Added the most adorable tests I've ever seen:


show more ...
|