| #
d8bd928c |
| 19-Oct-2022 |
Łukasz Kosmaty <[email protected]> |
[modules][Android] Fix exceptions handling in async functions (#19611)
# Why
Fixes test-suites:
```
- Calendar
- First run only: getEventsAsync() resolves to an array with an event of the
[modules][Android] Fix exceptions handling in async functions (#19611)
# Why
Fixes test-suites:
```
- Calendar
- First run only: getEventsAsync() resolves to an array with an event of the correct shape (expected 0 to be 1)
- Subsequent runs: deleteEventAsync(), deletes an event -expected false to be true
```
This is a follow-up to https://github.com/expo/expo/pull/19605.
# How
- Made sure that promises reject with a coded error instead of the plain js object.
- If something was thrown in the CPP code, the promise will also be rejected.
# Test Plan
- test-suite ✅
- manually test some corner case behavior ✅
show more ...
|
| #
b7d1787d |
| 12-Aug-2022 |
Łukasz Kosmaty <[email protected]> |
[sweet API] Cache PropNameID and js objects (#18579)
# Why
Adds a cache for prop name IDs and js objects like `Promise` or `CodedError`.
# How
- Added a cache registry
- Added missing tr
[sweet API] Cache PropNameID and js objects (#18579)
# Why
Adds a cache for prop name IDs and js objects like `Promise` or `CodedError`.
# How
- Added a cache registry
- Added missing try catch in the async function
# Test Plan
- unit tests ✅
show more ...
|