[ems] Tidy up README and bash directory checks

- Remove stray `=` from readme
- Remove unnecessary `$(pwd)` from bash scripts
- Fix up order of eslint args (options, then dir path at the end). Teste

[ems] Tidy up README and bash directory checks

- Remove stray `=` from readme
- Remove unnecessary `$(pwd)` from bash scripts
- Fix up order of eslint args (options, then dir path at the end). Tested by running `yarn lint` in expo-facebook.
- Made podspec glob look for <pkg>/*.podspec and <pkg>/ios/**/*.podspec instead of searching everywhere in the package (specifically we don't want to descend into node_modules). Tested by running `yarn expo-module readme` in both expo-facebook and expo-image to test both cases.

show more ...

[EMS] Create dev tooling for config plugins (#11574)

* plugin for stripe

* add plugin clean, build, and lint scripts

* Update index.ts

* remove template

* update naming

* Update READM

[EMS] Create dev tooling for config plugins (#11574)

* plugin for stripe

* add plugin clean, build, and lint scripts

* Update index.ts

* remove template

* update naming

* Update README.md

* Update CHANGELOG.md

* added plugin support to et

* Update app.json

* added testing options

* Update checkPackageAsync.ts

* added payments to NCL

* updated stripe plugin to support iap

* Update PaymentsScreen.tsx

* Update PaymentsScreen.tsx

* Update PaymentsScreen.tsx

* Updated docs

* Apply suggestions from code review

Co-authored-by: James Ide <[email protected]>
Co-authored-by: Brent Vatne <[email protected]>

* updated types

* Update jest-preset-plugin.js

* downgrade node

* Apply suggestions from code review

Co-authored-by: James Ide <[email protected]>

* update syntax

* ignore plugin builds

* unignore

* Update packages/expo-module-scripts/README.md

Co-authored-by: James Ide <[email protected]>

Co-authored-by: James Ide <[email protected]>
Co-authored-by: Brent Vatne <[email protected]>

show more ...

Fix/suppress all lint warnings in Home and enforce lint in CI (#9874)

Why

We have several lint warnings in Home that then get mentioned in PRs that don't even touch those files or introduce the w

Fix/suppress all lint warnings in Home and enforce lint in CI (#9874)

Why

We have several lint warnings in Home that then get mentioned in PRs that don't even touch those files or introduce the warnings. To improve CI signal and to keep the project warning-free I also enforced `--max-warnings=0` in CI.

How

This PR is split into four commits:

1. Update the ESLint dependencies (minor updates) and adjust the linter configuration so that we replace `no-unused-expressions` with `@babel/no-unused-expressions`, which fixes false positives when using the optional chaining operator (c.f. https://github.com/babel/eslint-plugin-babel/issues/185).
2. ESLint 7+ makes it so that newer versions of the ESLint TypeScript plugin can say it takes care of `ts` and `tsx` files so that we don't need to pass in `--ext` anymore. Remove the `--ext` option from the expo-module-scripts lint script.
3. Run `yarn lint --fix` in Home and fix up remaining warnings or suppress them for now.
4. Make CI fail if new warnings are added back to Home with `yarn lint --max-warnings=0`.

Test Plan

Ran `yarn lint` under `home`. The CI run for this PR will make sure that Home CI passes.

show more ...

[lint] Fix the extensions the linter looks for to include JSX and TSX

There were extra periods by mistake. Remove them and run the linter over the whole repo, fixing up files.

[lint] Lint the `expo` package with `expo-module lint`

Fixes lint errors and warnings in the `expo` package. We use `expo-module lint`, which is designed for this repo. It assumes that TS/JS source

[lint] Lint the `expo` package with `expo-module lint`

Fixes lint errors and warnings in the `expo` package. We use `expo-module lint`, which is designed for this repo. It assumes that TS/JS source is under `src` and will lint that directory. The base ESLint config uses `universe/native` but adds in the Node environment for tests, since they run in Jest.

show more ...

[lint] Add `expo-module lint` with an ESLint template

Added the command `expo-module lint` along with `expo-module eslint`. `lint` calls `eslint` with JSand TS file extensions, which `eslint` does n

[lint] Add `expo-module lint` with an ESLint template

Added the command `expo-module lint` along with `expo-module eslint`. `lint` calls `eslint` with JSand TS file extensions, which `eslint` does not look for by default.

The eslintrc template uses the `universe/native` configuration but it can be reconfigured to anything.

Tested by linting `expo-module-scripts` itself and fixing a few Prettier suggestions.

show more ...

[build] Add "expo-module-scripts" package for common scripts

All Expo module packages and the Expo SDK package need common scripts, like running TypeScript, unit tests, compiling the TS before publi

[build] Add "expo-module-scripts" package for common scripts

All Expo module packages and the Expo SDK package need common scripts, like running TypeScript, unit tests, compiling the TS before publishing, and so on. This introduces a package called "expo-module-scripts" that defines a script called `expo-module` with many commands like `test` and `build`. This helps us use consistent commands with consistent dependency versions (e.g. the same version of TypeScript, Jest, etc...) across all modules so that the Expo SDK is unified.

There are commands for common tasks like `build`, `test`, and `clean`. There are also commands for npm lifecycles like `prepare` and `prepublishOnly`. And there are pass-through commands for common development dependencies like `tsc` and `jest`.

The module is invokable through the `expo-module` program: `expo-module test` for instance. In a module's package.json, define a script named "expo-module" that just runs "expo-module" -- this lets us run `yarn expo-module test|build|clean|...`. Also define lifecycle scripts: `"prepare": "expo-module prepare"` for example. And lastly, define tasks for some common commands for convenience: `"test": "expo-module test"`.

The commands like building and testing run in watch mode since they are meant to be run by humans.

Test plan: used this in the Expo SDK module and verified that CI passes.

show more ...