Update expo image loader to remove Fresco and update Glide (#22542)Co-authored-by: Łukasz Kosmaty <[email protected]> # Why <!-- Please describe the motivation for this PR, and link to
Update expo image loader to remove Fresco and update Glide (#22542)Co-authored-by: Łukasz Kosmaty <[email protected]> # Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Attempting to update dependencies that necessitate the use of jetifier. The expo-image-loader uses both Fresco and Glide, which both accomplish the same thing. # How <!-- How did you build this feature or fix this bug and why? --> * Updated `com.github.bumptech.glide:glide` from `4.9.0` to `4.15.1` and added a variable in `ext` to customize the glide version in the future. * Removed `com.facebook.fresco:fresco` from the project * Replaced `loadImageForDisplayFromURL` method body with Glide implementation * Replaced deprecated `SimpleTarget` with `CustomTarget` * Removed `NonNull` and `Nullable` annotations from Kotlin code, as they are lint violations (nullity is enforced by language - specifically by contract with `ImageLoaderInterface`) # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> There are no unit tests associated with this project, so I tested the changed method `loadImageForDisplayFromURL` on my own project. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [X] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [X] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
show more ...
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core`
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core` # How - Change package using AS refactor tools - Fix some places where AS wasn't able to do automatically - Fix compatibility with new auto-linking - Ensure that classes which are used during installation steps are still available in the old place # Test Plan - expo-go (tested using unversioned and 41) - bare-expo
[android] lint spotless ktlint and fix CI step (#13662)
[image-loader] Migrate interface to expo-modules-core (#13022)
[android] Add kotlin spotless ktlint linter (#12545)
[QA][image-loader][android] Fix loading image from assets with Glide. (#7417)Fix loading image from assets with Glide.
[expo] Remove Glide from UIManagerModuleWrapper (#6400)* Remove glide from UIManagerModuleWrapper Move loadImageForUrl to EXImageLoader Fix android build Add new module to ExperiencePackag
[expo] Remove Glide from UIManagerModuleWrapper (#6400)* Remove glide from UIManagerModuleWrapper Move loadImageForUrl to EXImageLoader Fix android build Add new module to ExperiencePackagePicker Add requested changes Update react-native-unimodules Change UMBridgeModule to RCTBridgeModule * [expo] Update react-native-unimodules