| #
cc2b5a7f |
| 28-Apr-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[menu][iOS] Migrate to new modules API (#22263)
# Why
In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all related modules to the new API
Related to
[menu][iOS] Migrate to new modules API (#22263)
# Why
In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all related modules to the new API
Related to ENG-7955
# How
Migrate ExpoDevMenu classes to use the new modules API
# Test Plan
Run dev client through bare expo
<table>
<tr>
<td>
<img
src="https://user-images.githubusercontent.com/11707729/234351876-9402cba1-686a-4575-b2e7-6319e9c50439.png"
/>
</td>
<td>
<img
src="https://user-images.githubusercontent.com/11707729/234351912-f60b5e59-f9b5-4358-9402-ac5e91794bb7.png"
/>
</td>
</tr>
</table>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
169f3220 |
| 03-Mar-2023 |
Łukasz Kosmaty <[email protected]> |
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animati
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animation when the menu action was pressed
- Added a way for users to close or hide the menu from js
- Added small padding on Android to improve user experience
- Extensions can now decide if executing them should trigger collapse animation. It's set to true by default.
# Test Plan
- bare-expo ✅
- https://snack.expo.dev/@honeycomb-wallwisher/forlorn-soda ✅
show more ...
|
| #
9902297d |
| 20-Feb-2023 |
jay shah <[email protected]> |
[ios][dev-menu] fix reload crash when dev-menu turned off (#21279)
# Why
When Expo-dev-menu is turned off from AppDelegate.m using:
```
ExpoDevMenuReactDelegateHandler.enableAutoSetup = NO
[ios][dev-menu] fix reload crash when dev-menu turned off (#21279)
# Why
When Expo-dev-menu is turned off from AppDelegate.m using:
```
ExpoDevMenuReactDelegateHandler.enableAutoSetup = NO;
```
The application crashes when we try to use bare react-native reload.
# How
I noticed that Expo-dev-menu does not need to be setup if an app has explcitly requested for its disabling.
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
-->
1. Disable auto setup of expo-dev-menu by adding: `ExpoDevMenuReactDelegateHandler.enableAutoSetup = NO;` in your AppDelegate.m
2. Launch bare-expo app.
3. Try to reload via "r" or via Shake gesture -> "Reload".
4. You will see a crash.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
show more ...
|
| #
bc789176 |
| 03-Aug-2022 |
andy <[email protected]> |
[dev-client] cleanup unused native code (#18405)
|
| #
83ade7ef |
| 25-May-2022 |
andy <[email protected]> |
[dev-menu] add js api to register callbacks (#17528)
Co-authored-by: Eric Samelson <[email protected]>
|
| #
e0e6d484 |
| 17-Feb-2022 |
andy <[email protected]> |
[dev-launcher][dev-menu] move queryDevSessions into react app (#16276)
|
| #
765b47da |
| 30-Dec-2021 |
Tomasz Sapeta <[email protected]> |
[ios] Fix lint issues in Swift files (#15640)
|
| #
ad48d1ab |
| 16-Dec-2021 |
Eric Samelson <[email protected]> |
[expo-dev-menu][expo-dev-menu-interface] add deviceId parameter to dev sessions query (#15539)
|
| #
3cb6cb1a |
| 07-May-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec t
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec to suppress all warnings coming from them
> Note
The remaining warnings come from RN code - we can't do anything about them.
# Test Plan
- bare-expo ✅
- new project created using `npx crna`
show more ...
|
| #
d79129dc |
| 24-Mar-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-client] Share session & new UI (#12235)
# Why
Closes ENG-613.
Contains:
- https://github.com/expo/expo/pull/12236
- https://github.com/expo/expo/pull/12240
- https://github.com/expo
[expo-dev-client] Share session & new UI (#12235)
# Why
Closes ENG-613.
Contains:
- https://github.com/expo/expo/pull/12236
- https://github.com/expo/expo/pull/12240
- https://github.com/expo/expo/pull/12245
# How
- Exporting the expo API client
- Restored session state when the app is initialized (not when dev menu is launched)
- Created simple requests to our API
- Rewritten dev-launcher UI and consume dev session.
- Hided dev menu debug options when the user is in the launcher.
# Test Plan
- bare-expo
- Android ✅
- iOS ✅
show more ...
|
| #
aacdc29a |
| 09-Mar-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu] Add auth & profile screen (#11915)
# Why
Adds auth & profile screen to dev-menu
# How
- Reimplemented web browser functionalities in dev-menu (mostly copied the code from `e
[expo-dev-menu] Add auth & profile screen (#11915)
# Why
Adds auth & profile screen to dev-menu
# How
- Reimplemented web browser functionalities in dev-menu (mostly copied the code from `expo-web-browser`)
- Implemented UI - similar to one in the home app
- Created simple local storage to store a session.
- Added the GraphQL client
# Test Plan
- bare-expo ✅ - https://exponent-internal.slack.com/archives/C3XK84RRR/p1612967628256400
show more ...
|
| #
18cf86c2 |
| 31-Jul-2020 |
Tomasz Sapeta <[email protected]> |
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I can't say more about yet ♂️
# How
- Extracted the DevMenu root component from `home` into a separate React Native app with separate JS bundle.
- Refactored existing native iOS code and converted it to Swift (wherever possible).
- Added support for bare workflow and as a demo integrated it with bare-expo app (see https://github.com/expo/expo/commit/5d966176addcc3c781e32951072e8b85d4bcf964 for installation guide)
- Added a concept of dev menu extensions, make some redesigns, improve animations and behavior of the bottom sheet and made it work well with react-navigation screens
# Test Plan
Just merge and break everything.
show more ...
|