| #
e80a5256 |
| 30-Sep-2022 |
Kudo Chien <[email protected]> |
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine i
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine is inspectable (hermes /v8), show *Open JS debugger*. otherwise, show the *Remote JS debugger*
- change the menu label from *Local dev tools* to *Remote JS debugger* that would make more clear what it is.
- [android] change the isJSInsectorAvailable detection from sending http request to dev-server to check engine type. that aligns with expo go implementation and shows the dev menu faster (without waiting for dev-server http response).
- [ios] integrate dev-server's endpoint to open the js inspector. note that i still use the classic dev-menu-item extensions to register the command. that would align with android implementations.
- align `JsInspector -> JSInspector`
- also, support js inspector for v8
# Test Plan
- ✅ ios bare-expo hermes + Open JS debugger
- ✅ ios bare-expo jsc + Remote JS debugger
- ✅ android bare-expo hermes (have to downgrade react-native because the vendored reanimated lead to a crash) + Open JS debugger
- ✅ android bare-expo jsc + Remote JS debugger
Co-authored-by: Eric Samelson <[email protected]>
show more ...
|
| #
765b47da |
| 30-Dec-2021 |
Tomasz Sapeta <[email protected]> |
[ios] Fix lint issues in Swift files (#15640)
|
| #
85f8c286 |
| 07-Oct-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Update reload key command (#14590)
# Why
Closes ENG-1971
A follow-up to the https://github.com/expo/expo/pull/14202
# How
Changed the reload key command from `CMD + r` to j
[dev-menu][ios] Update reload key command (#14590)
# Why
Closes ENG-1971
A follow-up to the https://github.com/expo/expo/pull/14202
# How
Changed the reload key command from `CMD + r` to just `r`.
# Test Plan
- bare-expo ✅
show more ...
|
| #
1fefb1e7 |
| 30-Jun-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][dev-launcher] Make items order consistently across platforms (#13449)
|
| #
9d173f07 |
| 01-Jun-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Add websocket support (#12979)
# Why
Closes ENG-1144.
# How
Added web socket control support for dev-menu on iOS (very similar to the https://github.com/expo/expo/pull/12151
[dev-menu][ios] Add websocket support (#12979)
# Why
Closes ENG-1144.
# How
Added web socket control support for dev-menu on iOS (very similar to the https://github.com/expo/expo/pull/12151).
# Test Plan
- bare-expo ✅
show more ...
|
| #
dab4d59b |
| 10-May-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu] Remove test screens (#12850)
# Why
Close ENG-944.
# Test Plan
- bare-expo ✅
|
| #
3cb6cb1a |
| 07-May-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec t
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec to suppress all warnings coming from them
> Note
The remaining warnings come from RN code - we can't do anything about them.
# Test Plan
- bare-expo ✅
- new project created using `npx crna`
show more ...
|
| #
a9965bcf |
| 26-Apr-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Temporarily disable the reload action if LogBox is opened (#12705)
# Why
Temporarily disable the reload action if LogBox is opened. Otherwise, reloading, in that case, will causes
[dev-menu][ios] Temporarily disable the reload action if LogBox is opened (#12705)
# Why
Temporarily disable the reload action if LogBox is opened. Otherwise, reloading, in that case, will causes crashes.
Connected with https://exponent-internal.slack.com/archives/C011V63429H/p1619107418099200.
# Test Plan
- bare-expo ✅
show more ...
|
| #
221227d5 |
| 20-Apr-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu] Fetch eas updates data (#12452)
# Why
Closes ENG-347.
# How
- fixed `RNScreens module cannot be null` by downgrading the `react-native-screens` version (it was bumped in the
[expo-dev-menu] Fetch eas updates data (#12452)
# Why
Closes ENG-347.
# How
- fixed `RNScreens module cannot be null` by downgrading the `react-native-screens` version (it was bumped in the repo some time ago but the newest version doesn't work well with dev-menu).
- created a new concept of pulling async data into dev-menu - `DataSource`
- extended action functionality to handle the case where the js side passes arguments into native code (needed by list component).
- exposed functions with fetches updates data from our GraphQL API
- parsed GraphQL response and wrapped it into data objects
# Test Plan
- bare-expo ✅
show more ...
|
| #
d79129dc |
| 24-Mar-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-client] Share session & new UI (#12235)
# Why
Closes ENG-613.
Contains:
- https://github.com/expo/expo/pull/12236
- https://github.com/expo/expo/pull/12240
- https://github.com/expo
[expo-dev-client] Share session & new UI (#12235)
# Why
Closes ENG-613.
Contains:
- https://github.com/expo/expo/pull/12236
- https://github.com/expo/expo/pull/12240
- https://github.com/expo/expo/pull/12245
# How
- Exporting the expo API client
- Restored session state when the app is initialized (not when dev menu is launched)
- Created simple requests to our API
- Rewritten dev-launcher UI and consume dev session.
- Hided dev menu debug options when the user is in the launcher.
# Test Plan
- bare-expo
- Android ✅
- iOS ✅
show more ...
|
| #
26eb6799 |
| 08-Feb-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu] Add support for screens, links and selection list widget (#11384)
# Why
This is a preparation for adding the screen extension to the `dev-menu`
# How
Basicly just splitting
[expo-dev-menu] Add support for screens, links and selection list widget (#11384)
# Why
This is a preparation for adding the screen extension to the `dev-menu`
# How
Basicly just splitting the `DevMenuItemsList.tsx` into multiple components
# Test Plan
- bare-expo ✅
show more ...
|
| #
a664189c |
| 07-Dec-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-launcher][ios] Fix `expo-splash-screen` integration (#11250)
# Why
Fixes the dev-launcher getting stuck on the splash screen.
# How
The dev-launcher's bridge doesn't contain unimo
[expo-dev-launcher][ios] Fix `expo-splash-screen` integration (#11250)
# Why
Fixes the dev-launcher getting stuck on the splash screen.
# How
The dev-launcher's bridge doesn't contain unimodules. So the module shows but never hides a splash screen.
For now, we just remove the splash screen view when the launcher is loaded.
# Test Plan
- using this template -> https://github.com/lukmccall/with-dev-launcher
show more ...
|
| #
b9209815 |
| 10-Nov-2020 |
Łukasz Kosmaty <[email protected]> |
[dev-client] Fix issue with remote debugger, performance manager (#10925)
# Why
Fixes:
- If I enable perf monitor in an experience -> go back to launcher screen -> perf monitor is still visible
[dev-client] Fix issue with remote debugger, performance manager (#10925)
# Why
Fixes:
- If I enable perf monitor in an experience -> go back to launcher screen -> perf monitor is still visible
- js remote debugging option
- Go to empty URL-> stuck on “Loading” screen, unless you know to shake & reload which isn’t obvious.
# How
- parse the URL which was provided, before opening the app.
- disable `RCTDevSettings` and `RCTDevMenu` for `dev-client` and `dev-menu`.
- clean up previously opened app in the launcher.
- make sure that the remote debugging is turn on on the main thread.
# Test Plan
- bare-expo
- with launcher ✅
- without launcher ✅
show more ...
|
| #
16391f5d |
| 21-Aug-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu][ios] Extract interface (#9878)
# Why
Follow up to the https://github.com/expo/expo/pull/9854.
# Test Plan
- run `bare-expo` ✅
|
| #
a8c3dee7 |
| 31-Jul-2020 |
Tomasz Sapeta <[email protected]> |
[dev-menu] Ignore any changes in dev menu packager host file
|
| #
18cf86c2 |
| 31-Jul-2020 |
Tomasz Sapeta <[email protected]> |
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I can't say more about yet ♂️
# How
- Extracted the DevMenu root component from `home` into a separate React Native app with separate JS bundle.
- Refactored existing native iOS code and converted it to Swift (wherever possible).
- Added support for bare workflow and as a demo integrated it with bare-expo app (see https://github.com/expo/expo/commit/5d966176addcc3c781e32951072e8b85d4bcf964 for installation guide)
- Added a concept of dev menu extensions, make some redesigns, improve animations and behavior of the bottom sheet and made it work well with react-navigation screens
# Test Plan
Just merge and break everything.
show more ...
|