| #
169f3220 |
| 03-Mar-2023 |
Łukasz Kosmaty <[email protected]> |
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animati
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animation when the menu action was pressed
- Added a way for users to close or hide the menu from js
- Added small padding on Android to improve user experience
- Extensions can now decide if executing them should trigger collapse animation. It's set to true by default.
# Test Plan
- bare-expo ✅
- https://snack.expo.dev/@honeycomb-wallwisher/forlorn-soda ✅
show more ...
|
| #
2b5628a6 |
| 10-Aug-2022 |
andy <[email protected]> |
[dev-client] support landscape orientation (#18509)
|
| #
83ade7ef |
| 25-May-2022 |
andy <[email protected]> |
[dev-menu] add js api to register callbacks (#17528)
Co-authored-by: Eric Samelson <[email protected]>
|
| #
a93c953b |
| 17-Mar-2022 |
andy <[email protected]> |
[dev-launcher] remove dev menu from extra modules (#16562)
|
| #
c22baa2c |
| 16-Mar-2022 |
andy <[email protected]> |
[dev-menu] restore onboarding screen and autolaunch on initial install (#16602)
|
| #
e4ecb209 |
| 18-Feb-2022 |
andy <[email protected]> |
[dev-menu] update dev-settings to be passed as initial props (#16275)
|
| #
f9baf8a1 |
| 18-Feb-2022 |
andy <[email protected]> |
[dev-menu] update initial props on android and ios (#16271)
|
| #
86220016 |
| 04-Feb-2022 |
andy <[email protected]> |
[dev-menu] refactor dev menu on iOS to simplify dev-launcher relationship (#16067)
|
| #
765b47da |
| 30-Dec-2021 |
Tomasz Sapeta <[email protected]> |
[ios] Fix lint issues in Swift files (#15640)
|
| #
3cb6cb1a |
| 07-May-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec t
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec to suppress all warnings coming from them
> Note
The remaining warnings come from RN code - we can't do anything about them.
# Test Plan
- bare-expo ✅
- new project created using `npx crna`
show more ...
|
| #
aacdc29a |
| 09-Mar-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu] Add auth & profile screen (#11915)
# Why
Adds auth & profile screen to dev-menu
# How
- Reimplemented web browser functionalities in dev-menu (mostly copied the code from `e
[expo-dev-menu] Add auth & profile screen (#11915)
# Why
Adds auth & profile screen to dev-menu
# How
- Reimplemented web browser functionalities in dev-menu (mostly copied the code from `expo-web-browser`)
- Implemented UI - similar to one in the home app
- Created simple local storage to store a session.
- Added the GraphQL client
# Test Plan
- bare-expo ✅ - https://exponent-internal.slack.com/archives/C3XK84RRR/p1612967628256400
show more ...
|
| #
26eb6799 |
| 08-Feb-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu] Add support for screens, links and selection list widget (#11384)
# Why
This is a preparation for adding the screen extension to the `dev-menu`
# How
Basicly just splitting
[expo-dev-menu] Add support for screens, links and selection list widget (#11384)
# Why
This is a preparation for adding the screen extension to the `dev-menu`
# How
Basicly just splitting the `DevMenuItemsList.tsx` into multiple components
# Test Plan
- bare-expo ✅
show more ...
|
| #
fec8b153 |
| 19-Jan-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Fix loading indicator (#11662)
# Why
Fix loading indicator on iOS (no progress, only splash screen displayed while building js) - mentioned in https://www.notion.so/expo/1-14-20-D
[dev-menu][ios] Fix loading indicator (#11662)
# Why
Fix loading indicator on iOS (no progress, only splash screen displayed while building js) - mentioned in https://www.notion.so/expo/1-14-20-Dev-Client-Sync-0fa32f76ba9345c99f6ca57918528b1c.
# How
- `RCTDevLoadingView` -> `DevLoadingView
- Made `appInstance` lazy. It'll be initialized after the app is loaded (not at the same time) to not interfere with loading the main app (which causes a lot of problems with the progress indicator).
# Test Plan
- bare-expo ✅
show more ...
|
| #
6720ae54 |
| 28-Dec-2020 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Fix menu not hiding when auto launch is selected (#11461)
# Why
Fixes menu not hiding when auto-launch is selected.
# How
Sometimes the menu doesn't hide when you have the
[dev-menu][ios] Fix menu not hiding when auto launch is selected (#11461)
# Why
Fixes menu not hiding when auto-launch is selected.
# How
Sometimes the menu doesn't hide when you have the auto-launch option selected. Why? It's because of the race condition. The RN doesn't send the `RCTContentDidAppearNotification` event to the splash screen instead it sends it to the dev-menu bridge. Also closing the `dev-menu` doesn't help. So I've delayed menu opening.
> **Note:** The menu is listing to every `RCTContentDidAppearNotification` event. However, this should be relatively safe here.
# Test Plan
- tested with https://github.com/tcdavis/dev-client-ios-menu-201223 ✅
show more ...
|
| #
98d556a3 |
| 04-Sep-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu][ios] Prevent registering multiple root views (#10050)
# Why
`RCTRootView` assumes it is created on a loading bridge. In our fork, the bridge has usually already loaded. So we manu
[expo-dev-menu][ios] Prevent registering multiple root views (#10050)
# Why
`RCTRootView` assumes it is created on a loading bridge. In our fork, the bridge has usually already loaded. So we manually create `RCTRootView` when we want to display the application. However, it doesn't work with the original RN.
# How
Made `bundleFinishedLoading` an empty function to not start the application here:
https://github.com/facebook/react-native/blob/f0e80ae2292ebf7ce32666900007845724844fb5/React/Base/RCTRootView.m#L101-L103
# Test Plan
- bare-expo ✅
- using a vanilla app - https://github.com/tcdavis/dev-menu-test ✅
show more ...
|
| #
18cf86c2 |
| 31-Jul-2020 |
Tomasz Sapeta <[email protected]> |
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I
[dev-menu] Extract DevMenu to expo-dev-menu package (#9473)
# Why
We would like Expo DevMenu to work also in bare workflow and it's one step forward into our long-term super-duper feature that I can't say more about yet ♂️
# How
- Extracted the DevMenu root component from `home` into a separate React Native app with separate JS bundle.
- Refactored existing native iOS code and converted it to Swift (wherever possible).
- Added support for bare workflow and as a demo integrated it with bare-expo app (see https://github.com/expo/expo/commit/5d966176addcc3c781e32951072e8b85d4bcf964 for installation guide)
- Added a concept of dev menu extensions, make some redesigns, improve animations and behavior of the bottom sheet and made it work well with react-navigation screens
# Test Plan
Just merge and break everything.
show more ...
|