| #
aedb79bc |
| 02-Sep-2021 |
Ville Immonen <[email protected]> |
Fix React Native key commands getting disabled after dev menu is shown (#14266)
|
| #
3cb6cb1a |
| 07-May-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec t
[dev-client][ios] Fix XCode warnings (#12798)
# Why
Closes GRO-112.
Removes other warnings reported by XCode.
# How
- Fixed or suppressed warnings
- Added vendored modules as a subspec to suppress all warnings coming from them
> Note
The remaining warnings come from RN code - we can't do anything about them.
# Test Plan
- bare-expo ✅
- new project created using `npx crna`
show more ...
|
| #
0318ad3e |
| 07-Sep-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu][ios] Prevent registering multiple root views when running bundler (#10084)
# Why
Follow up to the https://github.com/expo/expo/pull/10050.
# How
The https://github.com/expo/
[expo-dev-menu][ios] Prevent registering multiple root views when running bundler (#10084)
# Why
Follow up to the https://github.com/expo/expo/pull/10050.
# How
The https://github.com/expo/expo/pull/10050 fixed issue when multiple root views registered with the same tag in vanilla RN apps. However, this bug still occurs in the `bare-expo` projet when `expo-dev-menu` is served by the bundler.
When the main app loading, the user can try to open the dev-menu. Unfortunately, this will lead to multiple root views error. Why? Answer is pretty simple. RN won't reset the id tag before creating the new view. So we can do it manually.
# Test Plan
- bare-expo ✅
show more ...
|
| #
98d556a3 |
| 04-Sep-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-dev-menu][ios] Prevent registering multiple root views (#10050)
# Why
`RCTRootView` assumes it is created on a loading bridge. In our fork, the bridge has usually already loaded. So we manu
[expo-dev-menu][ios] Prevent registering multiple root views (#10050)
# Why
`RCTRootView` assumes it is created on a loading bridge. In our fork, the bridge has usually already loaded. So we manually create `RCTRootView` when we want to display the application. However, it doesn't work with the original RN.
# How
Made `bundleFinishedLoading` an empty function to not start the application here:
https://github.com/facebook/react-native/blob/f0e80ae2292ebf7ce32666900007845724844fb5/React/Base/RCTRootView.m#L101-L103
# Test Plan
- bare-expo ✅
- using a vanilla app - https://github.com/tcdavis/dev-menu-test ✅
show more ...
|