| #
e3d19369 |
| 20-Jun-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[dev-launcher][dev-menu][ios] Add support for Fabric (#22184)
# Why
Closes ENG-7955
This PR adds dev-launcher support for the new architecture.
# How
- Updates `expo-dev-launcher` an
[dev-launcher][dev-menu][ios] Add support for Fabric (#22184)
# Why
Closes ENG-7955
This PR adds dev-launcher support for the new architecture.
# How
- Updates `expo-dev-launcher` and `expo-dev-menu` podspecs to support
`NEW_ARCH_ENABLED` flags
- Add `EXDevLauncherBridgeDelegate` class that inherits from
`RCTAppDelegate` and is responsible for creating the root view and
bridge
- Replace `DevMenuRCTCxxBridgeDelegate`with `DevMenuRCTAppDelegate`
- Fix `EXDevLauncherBridgeDelegate` not able to relaunch DevLauncher
- Add `ExpoDevLauncherBridgeDelegateHandler` to handle opening apps from
`ExpoDevLauncherReactDelegateHandler`
- Update `openDevMenuFromReactNative` to ensure the DevMenu is closed
before opening the react-native dev menu
# Test Plan
Run `fabric-tester` and `bare-expo` on iOS
<table>
<tr><th>fabric-tester</th><th>bare-expo</th></tr>
<tr>
<td>
<video
src="https://github.com/expo/expo/assets/11707729/1176f862-4459-4a39-8c11-16f73b2dfe46"/>
</td>
<td>
<video
src="https://github.com/expo/expo/assets/11707729/5f603af5-d970-4144-ade6-0943b829d225"
/>
</td>
</tr>
</table>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Kudo Chien <[email protected]>
show more ...
|
| #
e80a5256 |
| 30-Sep-2022 |
Kudo Chien <[email protected]> |
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine i
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine is inspectable (hermes /v8), show *Open JS debugger*. otherwise, show the *Remote JS debugger*
- change the menu label from *Local dev tools* to *Remote JS debugger* that would make more clear what it is.
- [android] change the isJSInsectorAvailable detection from sending http request to dev-server to check engine type. that aligns with expo go implementation and shows the dev menu faster (without waiting for dev-server http response).
- [ios] integrate dev-server's endpoint to open the js inspector. note that i still use the classic dev-menu-item extensions to register the command. that would align with android implementations.
- align `JsInspector -> JSInspector`
- also, support js inspector for v8
# Test Plan
- ✅ ios bare-expo hermes + Open JS debugger
- ✅ ios bare-expo jsc + Remote JS debugger
- ✅ android bare-expo hermes (have to downgrade react-native because the vendored reanimated lead to a crash) + Open JS debugger
- ✅ android bare-expo jsc + Remote JS debugger
Co-authored-by: Eric Samelson <[email protected]>
show more ...
|
| #
a8a1f53e |
| 29-Apr-2022 |
Łukasz Kosmaty <[email protected]> |
[dev-client][iOS] Fix remote debugging crashes the application (#17248)
# Why
Closes ENG-4755.
# How
It turns out that we have to override the `RTCDevSettings` module, otherwise, some place
[dev-client][iOS] Fix remote debugging crashes the application (#17248)
# Why
Closes ENG-4755.
# How
It turns out that we have to override the `RTCDevSettings` module, otherwise, some places in the CPP codebase will think that we turn on the remote debugging for the menu/launcher bridges.
Also, I have to force props to update when `isDebuggingRemotely`was changed.
# Test Plan
- bare-expo on both platforms ✅
show more ...
|
| #
812d0911 |
| 13-Apr-2022 |
Tomasz Sapeta <[email protected]> |
[ios] Add missing React imports to expo-dev-menu (#17030)
|
| #
765b47da |
| 30-Dec-2021 |
Tomasz Sapeta <[email protected]> |
[ios] Fix lint issues in Swift files (#15640)
|
| #
9d173f07 |
| 01-Jun-2021 |
Łukasz Kosmaty <[email protected]> |
[dev-menu][ios] Add websocket support (#12979)
# Why
Closes ENG-1144.
# How
Added web socket control support for dev-menu on iOS (very similar to the https://github.com/expo/expo/pull/12151
[dev-menu][ios] Add websocket support (#12979)
# Why
Closes ENG-1144.
# How
Added web socket control support for dev-menu on iOS (very similar to the https://github.com/expo/expo/pull/12151).
# Test Plan
- bare-expo ✅
show more ...
|