[core][dev-menu] fix react-native 0.73 compatibility [2/3] (#24019)

# Why

fix react-native 0.73 compatibility. this pr focus on react-native 0.73 breaking changes.

# How

- [core] fix compat

[core][dev-menu] fix react-native 0.73 compatibility [2/3] (#24019)

# Why

fix react-native 0.73 compatibility. this pr focus on react-native 0.73 breaking changes.

# How

- [core] fix compatibility of `NativeMethodCallInvoker` renaming: https://github.com/facebook/react-native/commit/b70f186b53
- [dev-menu] fix compatibility of `RCTAppDelegate` changes.
- [core] fix ios runtime crash from [upstream change](https://github.com/facebook/react-native/blob/540c41be9/packages/react-native/React/Views/RCTComponentData.m#L506-L507)
- [core] fix android build error because BOOST_VERSION is removed from `gradle.properties`

# Test Plan

ci passed in #23961 (https://github.com/expo/expo/pull/23961/checks)

show more ...

[dev-client][updates] fix ios use_frameworks build errors (#23218)

# Why

fix ios use_frameworks with expo-dev-client and expo-updates
fixes #23190
close ENG-9158

# How

- [dev-launcher][d

[dev-client][updates] fix ios use_frameworks build errors (#23218)

# Why

fix ios use_frameworks with expo-dev-client and expo-updates
fixes #23190
close ENG-9158

# How

- [dev-launcher][dev-menu] remove bridging headers. bridging headers are only supported in app projects as far as i know.
- [dev-launcher][dev-menu] remove double quoted imports
- [manifests][updates-interface] remove the swift generated header copying to PODS_ROOT. if we did that, xcode will have ambiguous imports that import from non-module header.

# Test Plan

- ci passed
- versioned expo go
- bare-expo
- sdk49 project + use_frameworks! static

show more ...

Upgrade react-native 0.72.0-rc.5 (#22588)

# Why

upgrade react-native 0.72 for sdk 49
close ENG-8011

# How

- bump package versions
- `react-native 0.71.3 -> 0.72.0-rc.5`
- `metro-reac

Upgrade react-native 0.72.0-rc.5 (#22588)

# Why

upgrade react-native 0.72 for sdk 49
close ENG-8011

# How

- bump package versions
- `react-native 0.71.3 -> 0.72.0-rc.5`
- `metro-react-native-babel-preset 0.73.9 -> 0.76.5`
- [bare-expo][templates][fabric-tester] migrate template base on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.5)
- [expo-template-tabs] remove the metro version overrides for expo-router.
- [core][dev-laucher][dev-menu][media-library][screen-orientation][splash-screen][updates-interface][updates] add the `install_modules_dependencies` to support new architecture + use_frameworks!
- [core][autolinking] fix some new architecture error on ios
- [react-native-lab] update our fork to 0.72.0-rc.5 based
- [go][tools] fix **react-native-lab/react-native/packages/react-native** path move because of react-native's repo monorepo changes
- [go][android] fix gradle 8 errors
- [go][ios] add `RCT_REMOTE_PROFILE=0` to fix the `RCT_ENABLE_INSPECTOR needs to be set to fulfill RCT_REMOTE_PROFILE` build error
- [ncl] remove `ProgressViewIOS` / `ProgressBarAndroid` since they are deprecated/removed in 0.72
- [dev-menu][dev-launcher] rebuild bundles

# Note

- react-native-web is not bumped because of the [issue](https://github.com/necolas/react-native-web/issues/2523), so it's still react-native-web@~0.18.10.
- currently disable ci typecheck for @expo/cli because of upstream metro typescript support. i'll have another pr to fix those errors.
- updates e2e ci on android is broken at [here](https://github.com/expo/expo/blob/fada3d764957779fbfc3d7b723d185db1d933d95/packages/expo-updates/e2e/fixtures/Updates.e2e.ts#L518). i doubt if that's related to the react scheduler change. i'd disabled the failed test case.
- the react-native upstream [migrated away the `@types/jest`](https://github.com/facebook/react-native/pull/36068). i was afraid that will be a breaking change to the existing jest test code since it requires the explicit `@jest/globals` import. i didn't do this in this upgrade.

# Test Plan

- ✅ fabric-tester (without expo-dev-client)
- ✅ ci passed. there are some errors which are known:
- updates e2e on android: as mentioned above
- ios expo go on eas build: versioned expo go are broken on eas build m1 worker. this is also happening on main.
- android client: no space left on the ubuntu worker. this is also happening on main.
- ✅ bare-expo
- ✅ unversioned expo go + ncl

---------

Co-authored-by: Tomasz Sapeta <[email protected]>

show more ...

[menu][ios] Rewrite safe area view using new API (#22174)

# Why

In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all non-fabric compatible libraries to

[menu][ios] Rewrite safe area view using new API (#22174)

# Why

In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all non-fabric compatible libraries to the new
API

Related to ENG-7955

# How

Rewrite safe area view using new API

# Test Plan

Run dev client through bare expo




# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

show more ...

[dev-menu] Fix hermes inspector not inspecting app target (#21978)

# Why

probably a regression from #21268. now the hermes inspector will inspect the dev menu bundle again.
close ENG-7928

# H

[dev-menu] Fix hermes inspector not inspecting app target (#21978)

# Why

probably a regression from #21268. now the hermes inspector will inspect the dev menu bundle again.
close ENG-7928

# How

- add `DevMenuRCTCxxBridgeDelegate` to call `setEnableDebugger(false)`

# Test Plan

- ci passed
- check hermes inspector loads app target rather than dev-menu bundle
- build passed on use_frameworks! mode

show more ...

[client] Remove vendored gesture handler (#21502)

# Why

Removes vendored gesture handler.
Another step to support Fabric by the dev-client.

> Note: To support fabric in the dev-client, we nee

[client] Remove vendored gesture handler (#21502)

# Why

Removes vendored gesture handler.
Another step to support Fabric by the dev-client.

> Note: To support fabric in the dev-client, we need to rewrite the safe area context, but that won't be difficult, because that module is pretty straightforward and we can use our API to support both renderers.

# How

- Removed vendored code.
- Mocked functions required by react-navigation.
- Disabled gesture in the stack navigator.

The swipe gesture won't longer close a screen, but I think it's something that we can sacrifice. Also, most of our screens are rendered inside the bottom tab navigator.

# Test Plan

- bare-expo on both platforms ✅
- ensures that the stack navigator works correctly ✅

show more ...

[menu] Reimplement the bottom sheet using native languages (#21268)

# Why

Closes ENG-7280.
Reimplemented the bottom sheet using native languages and removed reanimated from vendored modules.
B

[menu] Reimplement the bottom sheet using native languages (#21268)

# Why

Closes ENG-7280.
Reimplemented the bottom sheet using native languages and removed reanimated from vendored modules.
By doing that we improve the build speed.

# How

- On Android, I've used the material design bottom sheet. We may want to copy the implementation from the original repo to ours to avoid extra dependency.
- On iOS, I've copied the implementation from https://github.com/applidium/OverlayContainer. I managed to test a couple of different libraries and that one works the best with RN.

# Test Plan

- bare-expo on both platforms ✅

show more ...

[menu][iOS] Fixed `'jsc/JSCRuntime.h' file not found` when using JSC (#21246)

# Why

Fixes https://github.com/expo/expo/issues/21233.
Closes ENG-7582.

# How

The path to the common dir of th

[menu][iOS] Fixed `'jsc/JSCRuntime.h' file not found` when using JSC (#21246)

# Why

Fixes https://github.com/expo/expo/issues/21233.
Closes ENG-7582.

# How

The path to the common dir of the RN was not set correctly.

# Test Plan

- bare-expo ✅
- https://github.com/brentvatne/jsc-dev-client-48 ✅

show more ...

Fix expo-dev-menu not compiling in iOS native unit tests (#21137)

[1/3] upgrade react-native 0.71 (#20799)

# Why

upgrade react-native 0.71 for sdk 48
close ENG-7192

# How

- update package versions
- `react: 18.1.0 -> 18.2.0`
- `react-native 0.70.5

[1/3] upgrade react-native 0.71 (#20799)

# Why

upgrade react-native 0.71 for sdk 48
close ENG-7192

# How

- update package versions
- `react: 18.1.0 -> 18.2.0`
- `react-native 0.70.5 -> 0.71.0`
- `react-dom: 18.1.0 -> 18.2.0`
- `react-test-renderer: 18.1.0 -> 18.2.0`
- `react-native-web: 0.18.9 -> 0.18.10`
- `babel-plugin-react-native-web: 0.18.9 -> 0.18.10`
- `metro-react-native-babel-preset: 0.72.3 -> 0.73.5`
- upgrade three project templates based on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.70.6&to=0.71.0)
- bare-expo
- expo-template-bare-minimum
- fabric-tester (this is based on `npx expo prebuild --clean --no-install --template /path/to/expo-template-bare-minimum.tgz`) so it includes some inconsistent changes
- [@expo/config-plugins]: support 0.71 template transform. the `namespace` in build.gradle and the files in `release` build variants
- [fbjni] upgrade 0.3.0 to align 0.71 (also ndk version)
- [expo-updates] move the `EX_UPDATES_NATIVE_DEBUG` `bundleInDebug` setup to templates. unfortunately, because RNGP setups the task dependencies pretty early. the original setup in expo-updates build.gradle is too late. note that the change doesn't reference any files from templates to expo-updates package. somehow it's not tightly coupled.
- [native-tests / expo-modules-test-core / expo-modules-autolinking] fix ios unit test build error because jsc now in a dedicated podspec. in theory, the ios native unit test could now run on hermes as well.
- for other details, please check commit histories one by one.

# Test Plan

- bare-expo ios / android
- fabric ios / android
- ci passed (except ios)
- test-suite ios is broken for unknown reasons. it breaks only on github actions and hermes. for nightlies testing, i also [changed it to jsc](https://github.com/expo/expo/blob/1e029c89c4247802cc4880e27e116a6b4c71c502/tools/src/commands/SetupReactNativeNightly.ts#L287-L293) to make ci green. i'll try to follow up and investigate the root cause.

show more ...

fix(expo-dev-menu): reanimated podspec issue (#20332)

# Why

To prevent `pod install` error, see [here](20331) for more details. But I do wonder if these are needed at all, and if we can just remo

fix(expo-dev-menu): reanimated podspec issue (#20332)

# Why

To prevent `pod install` error, see [here](20331) for more details. But I do wonder if these are needed at all, and if we can just remove them?
# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

- Install with a fresh app, hermes enabled and with [email protected]
- Ensure there are no errors when running `pod install`

show more ...

[apps][packages] Fix ci issues (#20073)

# Why

fix a couple ci issues

# How

- [expo] [test failure](https://github.com/expo/expo/actions/runs/3475926136/jobs/5811154106) where constants nati

[apps][packages] Fix ci issues (#20073)

# Why

fix a couple ci issues

# How

- [expo] [test failure](https://github.com/expo/expo/actions/runs/3475926136/jobs/5811154106) where constants native module is optional before.
- [image-picker] fix upon 742d1946a36c884ab6cd6035bd2d596bf97f15fd to make the logic more clear
- [android] fix HapticsPackage not found in HomeActivity. for home we use unversioned module, the HapticsPackage is registered through autolinking generated package list.
- [android] fix versioned module in ExponentPackagePicker
- [bare-expo][dev-menu] ~fix ios gesture is blocked by dev-menu~ update: the issue was coming my dirty `dev-menu-packager-host`. since the metro server is unreachable, the dev-menu root view will be blank and block the whole app. after resetting `dev-menu-packager-host`, it works for me. the pr still leaves the `enableAutoSetup` from objc code for future use.

# Test Plan

ci passed

show more ...

Fix react-native nightly test (#19805)

# Why

Fix broken react-native nightly test

# How

- meta ships nightly build binaries on maven central now, we could just use the binaries than buildin

Fix react-native nightly test (#19805)

# Why

Fix broken react-native nightly test

# How

- meta ships nightly build binaries on maven central now, we could just use the binaries than building from source. the ci job time reduces dramatically. previously it takes almost four hours, now it takes 51m for android and 60m for ios.
- use env `REACT_NATIVE_OVERRIDE_VERSION` to override the version rather than hardcoded 9999.9999.9999 in packages.
- expo-modules-core / expo-av / expo-gl - support to download snapshot react-native from maven central
- fix some breaking changes from react-native nightly
- expo-dev-launcher: `RCTAsyncLocalStorage` is removed
- expo-modules-core: remove deprecated `<hermes/hermes.h>` import
- expo-modules-core: `RCTAppSetupDefaultRootView` has new parameter
- expo: `com.facebook.react.uimanager.UIImplementationProvider` is removed
- bare-expo `reactNativeNightly` gradle property is unused now, just rename to `buildReactNativeFromSource` if someone want to use.
- [tools] update SetupReactNativeNightly

# Test Plan

- test suite nightly ci passed
- original test suite ci passed to make sure compatibility with sdk 47

show more ...

[core][dev-client] Support react-native nightly builds (#19369)

# Why

follow up with https://github.com/facebook/react-native/pull/34838#issuecomment-1264675931 to support nightly build

# How

[core][dev-client] Support react-native nightly builds (#19369)

# Why

follow up with https://github.com/facebook/react-native/pull/34838#issuecomment-1264675931 to support nightly build

# How

override react-native version as `9999.9999.9999` when it's `0.0.0-` prefixed

# Test Plan

1. adding a react-native nightly version and remove all 3rd party libraries from bare-expo
2. do some manual changes
- _packages/expo/android/src/main/java/expo/modules/ReactNativeHostWrapperBase.kt_ to remove deprecated `getUIImplementationProvider`
3. test ios / android build

show more ...

[expo-dev-menu] Make internal runtime undebuggable (#19269)

# Why

Takes advantage of https://github.com/facebook/react-native/pull/34489.
It'll improve our integration with Hermes inspector - us

[expo-dev-menu] Make internal runtime undebuggable (#19269)

# Why

Takes advantage of https://github.com/facebook/react-native/pull/34489.
It'll improve our integration with Hermes inspector - users don't have to reload their app anymore to see correct sources.

# How

Set `enable debugger` on internal runtimes.

# Test Plan

I couldn't test it properly because our basic template crashes with RN `0.70`.

show more ...

[ios] Bump deployment target to 13.0 (#18873)

[client][iOS] Prebuild `react-native-gesture-handler` (#18680)

# Why

Prebuilding the `react-native-gesture-handler`
Part of ENG-5410.

# How

Similar to https://github.com/expo/expo/pull/186

[client][iOS] Prebuild `react-native-gesture-handler` (#18680)

# Why

Prebuilding the `react-native-gesture-handler`
Part of ENG-5410.

# How

Similar to https://github.com/expo/expo/pull/18679.

# Test Plan

- run `et vendor -c "[dev-menu] gesture-handler" --only-prebuild` ✅
- build bare-expo ✅

show more ...

[client][iOS] Prebuild `react-native-safe-area-context` (#18679)

# Why

Prebuild the `react-native-safe-area-context` on iOS.
Part of ENG-5410.

# How

- Used a pre-building script.
- Create

[client][iOS] Prebuild `react-native-safe-area-context` (#18679)

# Why

Prebuild the `react-native-safe-area-context` on iOS.
Part of ENG-5410.

# How

- Used a pre-building script.
- Created a custom podspec uses to build vendored code.
- Adjusted vendored script.

# Test Plan

- run `et vendor -c "[dev-menu] safe-area-context"` ✅
- build bare-expo ✅

show more ...

[ios][tools][ci] Redesign iOS unit tests (#17634)

# Why

iOS Unit Test CI job had several issues:
- Fastlane is being run for each package separately, so it's restarting the simulator each time.

[ios][tools][ci] Redesign iOS unit tests (#17634)

# Why

iOS Unit Test CI job had several issues:
- Fastlane is being run for each package separately, so it's restarting the simulator each time. This makes the job slower and moreover, test results are scattered across all fastlane logs.
- Some tests are being run on bare-expo, others on the client project.
- Packages to be tested need to be defined manually in podfile
- Some dev-client tests aren't being run at all (bug in expotools)

# How

Basically, running tests once from a single xcscheme is faster and clearer than doing it separately for each package.

- Applied some autolinking + fastlane changes from #16993 and https://github.com/expo/expo/commit/0e0c1e3db71535002e56453ff6004b06e2836c8e - now we have `use_expo_modules_tests!` for autolinking only test packages.
- Created (`expo init -t bare`) a new `apps/native-tests` app which has no JS code, but only native iOS project with a single test-only scheme (`NativeTests.xcscheme`)
> It might be possible to integrate it as a separate test target in bare-expo instead of creating a new app
- Created a custom fastlane action `generate_test_scheme`, which takes that NativeTests scheme as a template and automatically finds test targets (named `PodspecName-Unit-Tests`, generated by CocoaPods during `pod install`) and generates a `NativeTests_generated` scheme aggregating all these targets. Package filtering is also supported.
- Created a new ios lane `:unit_tests` which uses that action to generate the scheme and then run tests, adopted the `et ios-native-unit-tests` command to use this lane.
- Fixed expotools not recognizing the `expo-dev-launcher` podspec, because it was in the package root instead of the `ios/` subdir.
- Got rid of `React-hermes` test spec dependencies. They're not needed anymore. JS engine for `apps/native-tests` is set to JSC.
- Added `FASTLANE_SKIP_UPDATE_CHECK=1` to the CI env to prevent fastlane from spamming.

One drawback of this approach is that we now have to maintain another app, another podfile etc ��

show more ...

[dev-launcher] add inter font to dev-launcher (#16840)

[dev-menu] Fix compilation flags warning (#16888)

# Why

I noticed this warning while working on dev-client, figured it would be a simple fix :)

`▸ Running script 'Copy generated compatibility

[dev-menu] Fix compilation flags warning (#16888)

# Why

I noticed this warning while working on dev-client, figured it would be a simple fix :)

`▸ Running script 'Copy generated compatibility header'
conditional compilation flags do not have values in Swift; they are either present or absent (rather than 'EX_DEV_MENU_ENABLED=1')`

# How

Don't pass a value to EX_DEV_MENU_ENABLED in swift flags.

# Test Plan

Build bare-expo on ios after this fix and check that the warning is gone and dev menu still works.

show more ...

[dev-menu] update dev menu dev settings (#16476)

[expo-dev-menu] add expo-modules auto setup on iOS (#16496)

[dev-menu] remove old js dev menu (#16083)

Upgrade to react-native 0.66 (#15914)

# Why

follow up https://github.com/expo/expo/pull/15817#discussion_r781366360
after we use the react-native from npm, the react-native version we used in ex

Upgrade to react-native 0.66 (#15914)

# Why

follow up https://github.com/expo/expo/pull/15817#discussion_r781366360
after we use the react-native from npm, the react-native version we used in expo-go is decoupled with other stuffs. that makes us upgrade react-native easier.

# How

1. update versions in package.json
2. sync changes from [react-native-upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.64.2&to=0.66.4)
3. `RCTComponentData` changed its designated initializer in react-native 0.65. to make it compatible with older version, i introduced the `EXComponentDataCompatibleWrapper` class to support different versions.
4. [react-native-lab] to fix expo-go build error, we should patch react-native to use the codegen library from its repo but not from node_modules: https://github.com/expo/react-native/pull/29.

# Test Plan

- CI passed
- bare-expo build & launch test
- unversioned expo-go build & launch test

show more ...