| #
c516e737 |
| 19-May-2023 |
Łukasz Kosmaty <[email protected]> |
[menu][Android] Start using new modules API (#21582)
# Why
Rewrite some menu modules to use the new API.
# Test Plan
- bare-expo ✅
|
| #
cc2b5a7f |
| 28-Apr-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[menu][iOS] Migrate to new modules API (#22263)
# Why
In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all related modules to the new API
Related to
[menu][iOS] Migrate to new modules API (#22263)
# Why
In order to add support for Fabric to expo-dev-client and related
libraries we must migrate all related modules to the new API
Related to ENG-7955
# How
Migrate ExpoDevMenu classes to use the new modules API
# Test Plan
Run dev client through bare expo
<table>
<tr>
<td>
<img
src="https://user-images.githubusercontent.com/11707729/234351876-9402cba1-686a-4575-b2e7-6319e9c50439.png"
/>
</td>
<td>
<img
src="https://user-images.githubusercontent.com/11707729/234351912-f60b5e59-f9b5-4358-9402-ac5e91794bb7.png"
/>
</td>
</tr>
</table>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
169f3220 |
| 03-Mar-2023 |
Łukasz Kosmaty <[email protected]> |
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animati
[menu] Improve bottom sheet behaviour (#21486)
# Why
Improves the behavior of the native bottom sheet.
Closes https://github.com/expo/expo/issues/21356.
# How
- Started a collapse animation when the menu action was pressed
- Added a way for users to close or hide the menu from js
- Added small padding on Android to improve user experience
- Extensions can now decide if executing them should trigger collapse animation. It's set to true by default.
# Test Plan
- bare-expo ✅
- https://snack.expo.dev/@honeycomb-wallwisher/forlorn-soda ✅
show more ...
|
| #
e80a5256 |
| 30-Sep-2022 |
Kudo Chien <[email protected]> |
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine i
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine is inspectable (hermes /v8), show *Open JS debugger*. otherwise, show the *Remote JS debugger*
- change the menu label from *Local dev tools* to *Remote JS debugger* that would make more clear what it is.
- [android] change the isJSInsectorAvailable detection from sending http request to dev-server to check engine type. that aligns with expo go implementation and shows the dev menu faster (without waiting for dev-server http response).
- [ios] integrate dev-server's endpoint to open the js inspector. note that i still use the classic dev-menu-item extensions to register the command. that would align with android implementations.
- align `JsInspector -> JSInspector`
- also, support js inspector for v8
# Test Plan
- ✅ ios bare-expo hermes + Open JS debugger
- ✅ ios bare-expo jsc + Remote JS debugger
- ✅ android bare-expo hermes (have to downgrade react-native because the vendored reanimated lead to a crash) + Open JS debugger
- ✅ android bare-expo jsc + Remote JS debugger
Co-authored-by: Eric Samelson <[email protected]>
show more ...
|
| #
5df56e41 |
| 07-Jun-2022 |
Łukasz Kosmaty <[email protected]> |
[dev-menu] Restore `open RN dev menu` and `js inspector` options (#17762)
# Why
Closes ENG-4902
Closes ENG-4961
Restores two missing buttons:
- open React Native dev menu
- open js inspecto
[dev-menu] Restore `open RN dev menu` and `js inspector` options (#17762)
# Why
Closes ENG-4902
Closes ENG-4961
Restores two missing buttons:
- open React Native dev menu
- open js inspector
# Test Plan
Run the simple application in dev-client and check if the new options were present:
- iOS ✅
- Android ✅
show more ...
|
| #
62ae52fc |
| 02-Jun-2022 |
Łukasz Kosmaty <[email protected]> |
[dev-menu] Show information about needed app reload before debugging while using Hermes (#17701)
# Why
Adds warning about needed app reloads before starting debugging while using Hermes.
# How
[dev-menu] Show information about needed app reload before debugging while using Hermes (#17701)
# Why
Adds warning about needed app reloads before starting debugging while using Hermes.
# How
- Passes a js engine in the app info
- Adds a warning
- Fixes bottom sheet view doesn't work if the content is bigger than the container
show more ...
|
| #
83ade7ef |
| 25-May-2022 |
andy <[email protected]> |
[dev-menu] add js api to register callbacks (#17528)
Co-authored-by: Eric Samelson <[email protected]>
|
| #
5e3c9f9b |
| 26-Apr-2022 |
Łukasz Kosmaty <[email protected]> |
[dev-menu] Fix error on summoning dev menu first time (#17215)
|
| #
052376e8 |
| 24-Mar-2022 |
andy <[email protected]> |
[dev-menu][dev-launcher] update dev-menu extensions API (#16558)
|
| #
c22baa2c |
| 16-Mar-2022 |
andy <[email protected]> |
[dev-menu] restore onboarding screen and autolaunch on initial install (#16602)
|
| #
e3928631 |
| 11-Mar-2022 |
andy <[email protected]> |
[dev-menu] update dev menu dev settings (#16476)
|
| #
e4ecb209 |
| 18-Feb-2022 |
andy <[email protected]> |
[dev-menu] update dev-settings to be passed as initial props (#16275)
|
| #
f9baf8a1 |
| 18-Feb-2022 |
andy <[email protected]> |
[dev-menu] update initial props on android and ios (#16271)
|
| #
86220016 |
| 04-Feb-2022 |
andy <[email protected]> |
[dev-menu] refactor dev menu on iOS to simplify dev-launcher relationship (#16067)
|
| #
5ea1353d |
| 24-Jan-2022 |
andy <[email protected]> |
[dev-menu] add ios functions for dev menu (#15917)
|
| #
124a41c3 |
| 18-Jan-2022 |
andy <[email protected]> |
[dev-menu] update dev menu to match redesign (#15906)
|