| e80a5256 | 30-Sep-2022 |
Kudo Chien <[email protected]> |
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine i
[dev-menu] Integrate hermes inspector like expo go (#19301)
# Why
align the hermes inspector implementation as expo go #19175.
close ENG-6295
# How
- from the dev-menu, if the js engine is inspectable (hermes /v8), show *Open JS debugger*. otherwise, show the *Remote JS debugger*
- change the menu label from *Local dev tools* to *Remote JS debugger* that would make more clear what it is.
- [android] change the isJSInsectorAvailable detection from sending http request to dev-server to check engine type. that aligns with expo go implementation and shows the dev menu faster (without waiting for dev-server http response).
- [ios] integrate dev-server's endpoint to open the js inspector. note that i still use the classic dev-menu-item extensions to register the command. that would align with android implementations.
- align `JsInspector -> JSInspector`
- also, support js inspector for v8
# Test Plan
- ✅ ios bare-expo hermes + Open JS debugger
- ✅ ios bare-expo jsc + Remote JS debugger
- ✅ android bare-expo hermes (have to downgrade react-native because the vendored reanimated lead to a crash) + Open JS debugger
- ✅ android bare-expo jsc + Remote JS debugger
Co-authored-by: Eric Samelson <[email protected]>
show more ...
|