| #
127d18d5 |
| 09-Sep-2022 |
Łukasz Kosmaty <[email protected]> |
[camera][Android] Combine `CameraModule` with `CameraViewManager` (#19049)
# Why
A follow-up to the https://github.com/expo/expo/pull/18946.
Combines the `CameraModule` with the `CameraViewMan
[camera][Android] Combine `CameraModule` with `CameraViewManager` (#19049)
# Why
A follow-up to the https://github.com/expo/expo/pull/18946.
Combines the `CameraModule` with the `CameraViewManager` on Android. Makes sure that we use the same set of module names on both platforms.
Fixes:
```
Cannot read property 'back' of undefined
```
# How
- Copied content of the `CameraModule` into the `CameraViewManager`.
- Adjusted the js layer.
# Test Plan
- NCL ✅
show more ...
|
| #
6f8f7a64 |
| 02-Sep-2022 |
Kudo Chien <[email protected]> |
[camera] Fix native module exports (#18946)
# Why
on ios expo go, there is a js error where to [access null property](https://github.com/expo/expo/blob/41b1a02f64d01176c459a265ced165e452b10141/pa
[camera] Fix native module exports (#18946)
# Why
on ios expo go, there is a js error where to [access null property](https://github.com/expo/expo/blob/41b1a02f64d01176c459a265ced165e452b10141/packages/expo-camera/src/utils/props.ts#L20) and the native module is actually undefined. this is a regression from #18703 and #18864. on ios, the original camera view manager name is `ExponentCameraManager` and now being `ExponentCamera`.
# How
i checked there're no usage of `ExponentCameraManager`. we use `ExponentCamera` both on ios and android. i just replace remove the old name and use the new name.
# Test Plan
- ios bare-expo
- ios expo go with local home
show more ...
|