[android] Remove unnecessary version checks (#24203)# Why This PR is related to #24201, it removes unnecessary version checks # How Remove version check logic for SDK's < 23 # Test Pla
[android] Remove unnecessary version checks (#24203)# Why This PR is related to #24201, it removes unnecessary version checks # How Remove version check logic for SDK's < 23 # Test Plan Tested in Bare Expo in Android 13 simulator
show more ...
[packages] fix react-native 0.73 compatibility [1/3] (#24018)# Why fix react-native 0.73 compatibility. these are for AGP 8 support - https://github.com/react-native-community/discussions-and-pr
[packages] fix react-native 0.73 compatibility [1/3] (#24018)# Why fix react-native 0.73 compatibility. these are for AGP 8 support - https://github.com/react-native-community/discussions-and-proposals/issues/671#issuecomment-1677632448 # How - [packages][bare-expo] set jvm version only if AGP < 8 - [av][dev-launcher] fix AGP 8 non transitive R issue - [dev-client][dev-launcher][dev-menu][core][notifications] fix AGP 8 non default buildConfig issue # Test Plan ci passed in #23961 (https://github.com/expo/expo/pull/23961/checks)
[av][Android] Migrate `AVModule` to new API (#23902)# Why `Migrate AVModule to new API` Needs https://github.com/expo/expo/pull/23942 to work. # Test Plan - bare-expo and NCL ✅
[AV][Android] Remove empty `createViewManagers` function from the package (#23857)# Why Clean up the package file.
[av][ncl][go] fix audio and video qa issues (#21055)# Why fix audio and video issues from sdk48 android unversioned qa # How - [ncl] play position back-and-forth is actually from slider's
[av][ncl][go] fix audio and video qa issues (#21055)# Why fix audio and video issues from sdk48 android unversioned qa # How - [ncl] play position back-and-forth is actually from slider's [`onSlidingComplete` issue](https://github.com/callstack/react-native-slider/issues/487). this pr update the vendored slider to the latest version with a fix. - [ncl] `setVolumeAsync` unhandled promise rejection: access `sound` when it's before starting (undefined). - [av] also find a regression for SimpleExoPlayer jsi audio sampler which should access the player from main thread. # Test Plan - ci passed - android unversioned expo go + ncl audio / video
[modules][av][Android] Fix libraries using ViewDefinitionBuilder.kt crashes in release with proguard enabled (#20197)# Why Fixes https://github.com/expo/expo/issues/20122. # How We're miss
[modules][av][Android] Fix libraries using ViewDefinitionBuilder.kt crashes in release with proguard enabled (#20197)# Why Fixes https://github.com/expo/expo/issues/20122. # How We're missing a couple of proguard rules to prevent view callbacks and contractors from being optimized by the R8. I've added rules that prevent two possible contractors in ExpoView: - public <init>(android.content.Context); - public <init>(android.content.Context, expo.modules.kotlin.AppContext); and properties with types connected to view callbacks: - expo.modules.kotlin.viewevent.ViewEventCallback - expo.modules.kotlin.viewevent.ViewEventDelegate # Test Plan - bare-expo with NCL built in the release mode ✅
[av][Android] Fix `Video` is crashing when the `resolveView` cannot find the underlaying view (#19617)# Why Fixes: ``` FATAL EXCEPTION: main 10-14 10:12:30.129 3694 3694 E AndroidRuntime: P
[av][Android] Fix `Video` is crashing when the `resolveView` cannot find the underlaying view (#19617)# Why Fixes: ``` FATAL EXCEPTION: main 10-14 10:12:30.129 3694 3694 E AndroidRuntime: Process: host.exp.exponent, PID: 3694 10-14 10:12:30.129 3694 3694 E AndroidRuntime: com.facebook.react.uimanager.IllegalViewOperationException: Trying to resolve view with tag 2723 which doesn't exist ``` # How In SDK-46, in the case where the view wasn't available, we rejected the promise. That behavior is expected by the js code. # Test Plan - test-suite ✅ > Note: not all tests pass on each try. However, testing them one by one, I managed to run through all of them with success.
[core] Rename `callback` to `EventDispatcher` (#19521)# Why This's a follow-up to https://github.com/expo/expo/pull/19537. # How Renamed `callback` to `EventDispatcher` # Test Plan -
[core] Rename `callback` to `EventDispatcher` (#19521)# Why This's a follow-up to https://github.com/expo/expo/pull/19537. # How Renamed `callback` to `EventDispatcher` # Test Plan - NCL ✅
[av][android] upgrade exoplayer to 2.18.1 (#19332)# Why close ENG-6246 # How - upgrade exoplayer to 2.18.1 - migrate breaking changes - kotlinize _packages/expo-av/android/src/main/java/
[av][android] upgrade exoplayer to 2.18.1 (#19332)# Why close ENG-6246 # How - upgrade exoplayer to 2.18.1 - migrate breaking changes - kotlinize _packages/expo-av/android/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java_ - remove _android/expoview/src/main/java/versioned/host/exp/exponent/modules/universal/av/CustomHeadersOkHttpDataSourceFactory.kt_ which is exactly the same to the CustomHeadersOkHttpDataSourceFactory inside expo-av package. # Test Plan - android unversioned expo go + NCL Video
[av] Fix video native module error on android (#19331)# Why regression from #18961 which break native module call on android. #18961 changed the native module name from `ExpoVideoManager` to `Ex
[av] Fix video native module error on android (#19331)# Why regression from #18961 which break native module call on android. #18961 changed the native module name from `ExpoVideoManager` to `ExpoVideoView`. however on android we still use `ExpoVideoManager` as the native module name. # How - migrate the `ViewManager` as sweet api and merge into the `ExpoVideoView` module. - add `tryRunWithVideoView` overloading method for kotlin promise. # Test Plan - android unversioned expo go + NCL video (change resize mode and full screen)
[av] Migrate VideoView to new style View on Android (#18891)# Why follow up https://github.com/expo/expo/pull/18820#issuecomment-1227472507 to migrate video view # How migrate the new styl
[av] Migrate VideoView to new style View on Android (#18891)# Why follow up https://github.com/expo/expo/pull/18820#issuecomment-1227472507 to migrate video view # How migrate the new style View dsl # Test Plan - fabric tester
[android][av][core] Fix a couple issues for expo go (#18823)# Why fix a couple issues for expo go. # How - a launch crash because Permission module not found. this is a regression for #184
[android][av][core] Fix a couple issues for expo go (#18823)# Why fix a couple issues for expo go. # How - a launch crash because Permission module not found. this is a regression for #18472 in `ModuleRegistryAdapter::getNativeModulesFromModuleRegistry()` where custom moduleRegistry is not be used. - VideoViewModule is not registered. a regression from #18798 - Video play/fullscreen does not work. because the [context](https://github.com/expo/expo/pull/18798/files#diff-92ed6ed63af93be93cb457680bd3640d56ce064cf6e6a51fa134f44148556521R506) in expo go is not ReactContext but ScopedContext. since VideoManager and AVManager is still written in legacy module, i still have to use UIManager to get the correct ReactContext. # Test Plan - unversioned android expo go + NCL video - fabric-tester VideoExample
[av] Sweetify VideoViewManager on Android (#18798)# Why #18633 for android where to support fabric for expo-av # How - rewrite `VideoViewWrapper.java` to kotlin because the wrapped view de
[av] Sweetify VideoViewManager on Android (#18798)# Why #18633 for android where to support fabric for expo-av # How - rewrite `VideoViewWrapper.java` to kotlin because the wrapped view delegated callbacks only support kotlin. - rewrite VideoViewManager as sweet api. # Test Plan - ✅ NCL - ✅ Video test suite - fabric-tester is not fully working. adding event supports in #18814
[android][expo-av] Add volume panning for MediaPlayer (#15530) Signed-off-by: DominickVale <[email protected]>
[av][android] Fix crashes due to accessing player from the wrong thread (#17840)
[av][android] Fix crashes caused by accessing `ExoPlayer` from the wrong thread (#17280)
[expo-av][android] Fix crash when debugging remotely (#17212)# Why Android app crashed when debugging remotely, there was a missing null check for JSI runtime in expo-av. # How Added a nul
[expo-av][android] Fix crash when debugging remotely (#17212)# Why Android app crashed when debugging remotely, there was a missing null check for JSI runtime in expo-av. # How Added a null check, the same way it is done in `expo-gl`. Backported changes to versioned SDK 45. # Test Plan Reproduced failure with native debug breakpoints. Applied fix. Built Android again and ensured it is no longer crashing.
[android][av] Fix cast exceptions on ReactContext in Expo Go (#16853)
[av] Implement JSI Audio on Android (#16075)* Marc's Gradle/CMake/C++ changes * Java code changes * Add Android to supported platforms on NCL * Reformat C++ code * Rebase, fixes, sugges
[av] Implement JSI Audio on Android (#16075)* Marc's Gradle/CMake/C++ changes * Java code changes * Add Android to supported platforms on NCL * Reformat C++ code * Rebase, fixes, suggestions * Requested Gradle CMake changes * Fix spotless
[av][android] Fix crashes caused by accessing player on wrong thread (#16611)
[av][Android] Bump `com.google.android.exoplayer:exoplayer` from `2.9.2` to `2.13.3` (#16123)
[expo-av] Enable selection of audio recording input (#15806)
[av] Fix JNI detected error in application: java_object == null (#14569)# Why Closes ENG-2013. # How The event emitter from the Video component wasn't stoped correctly. It was emitting eve
[av] Fix JNI detected error in application: java_object == null (#14569)# Why Closes ENG-2013. # How The event emitter from the Video component wasn't stoped correctly. It was emitting events even after the component was unmounted. That leads to crashes in the reanimated event handler. The cpp code tries to access unavailable context. # Test Plan - run test-suite in Expo Go - run Video tests - refresh application
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core`
[expo-modules] Move code from `unimodules` into `expo-modules-core` (#13703)# Why Migrated `unimodules-core`, `unimodules-react-native-adapter`, `unimodules-app-loader` into `expo-modules-core` # How - Change package using AS refactor tools - Fix some places where AS wasn't able to do automatically - Fix compatibility with new auto-linking - Ensure that classes which are used during installation steps are still available in the old place # Test Plan - expo-go (tested using unversioned and 41) - bare-expo
[expo-av] Fixed an issue with Audio Interruption Mode not correctly being set on Android (#13236)
123