| 129ec188 | 03-Jul-2023 |
Kudo Chien <[email protected]> |
[go] Fix hermes inspector crash from vscode-expo (#23271)
# Why
when vscode-expo sending the `Runtime.callFunctionOn` event, it will crash ios expo go.
close ENG-9172
# How
compared this o
[go] Fix hermes inspector crash from vscode-expo (#23271)
# Why
when vscode-expo sending the `Runtime.callFunctionOn` event, it will crash ios expo go.
close ENG-9172
# How
compared this on top of expo-go and expo-dev-client, both reaching the line `throw std::runtime_error("unknown object id " + objId);`. only expo-go will crash the app because the exception is not caught. this happens on the new expo-go, even the older sdks (that's why this pr includes to backporting changes).
as the comment said, i still not figure out why the `std::runtime_error` is not caught by the `std::exception`. but the trick works
# Test Plan
ios expo go + sdk49 + vscode-expo debugging
show more ...
|