| #
51e273e0 |
| 14-Sep-2023 |
Tomasz Sapeta <[email protected]> |
[file-system][iOS] Migrate to Expo Modules API (#23943)
|
| #
42e5df8f |
| 02-Mar-2023 |
Kudo Chien <[email protected]> |
[ios] fix build errors (#21481)
# Why
fix expo go ios and bare-expo build errors
# How
there are two errors:
1. bare-expo `EXDevLauncherController.h:8:1: use of '@import' when C++ module
[ios] fix build errors (#21481)
# Why
fix expo go ios and bare-expo build errors
# How
there are two errors:
1. bare-expo `EXDevLauncherController.h:8:1: use of '@import' when C++ modules are disabled, consider using -fmodules and -fcxx-modules`. the import is from bare-expo's AppDelegate.mm. the solution migrates `@import EXManifest; -> +#import <EXManifests/EXManifests-Swift.h>`
2. ios expo go: https://github.com/expo/expo/actions/runs/4305432041/jobs/7507869126
```
/Users/runner/work/expo/expo/ios/Pods/Headers/Public/EXConstants/EXConstantsService.h:14:43: error: declaration of 'EXInternalModule' must be imported from module 'EXFileSystem.EXFilePermissionModule' before it is required
@interface EXConstantsService : NSObject <EXInternalModule, EXConstantsInterface>
```
the pr tries to add some rearrange some imports
# Test Plan
ci passed
show more ...
|
| #
efd75dec |
| 16-Aug-2021 |
Tomasz Sapeta <[email protected]> |
[ios] Migrate all remaining native code
|
| #
e61ddc0c |
| 11-Aug-2020 |
Stanisław Chmiela <[email protected]> |
[ios] Extract filesystem directories generation to app manager (#9676)
# Why
When TurboModules are enabled we'll need to have access to `documentDirectory` from within instance scope of `EXVersio
[ios] Extract filesystem directories generation to app manager (#9676)
# Why
When TurboModules are enabled we'll need to have access to `documentDirectory` from within instance scope of `EXVersionManager` to be able to create `RCTAsyncLocalStorage` on demand. Right now we're fetching the directory from an instance of `EXFileSystem`. Moving it higher up makes sense not only for this purpose, but also it fits well logically — the manager knows where the app should store files, not the module.
# How
Moved the generation of `documentDirectory` and `cachesDirectory` from `EXScopedFileSystemModule` to `EXReactAppManager`. Added the directories to `NSDictionary *params` passed to `EXVersionManager` (and then to `EXScopedModuleRegistryAdapter`). Moved the initialization logic from scoped module to adapter (whether the module should be created with custom directories or with default directories depends now on whether the directory paths have been provided, which still depends on the same `appOwnership == "expo"` condition.
# Test Plan
Expo Client ran. I've also verified with native debugging that Home gets the scoped directories.
show more ...
|
| #
8e23f9f5 |
| 20-Aug-2019 |
Szymon20000 <[email protected]> |
[ios][android] Drop SDK 31 and 32 (#5381)
# Why
resolves: https://github.com/expo/expo/issues/5146
# How
Using `et rm-sdk` expotools command.
# Test Plan
Run NCL.
|
| #
631604b1 |
| 30-May-2019 |
Tomasz Sapeta <[email protected]> |
[ios] Make iOS ExpoKit work without unimodules that need to be scoped (#4336)
# Why
I was unable to build a newly ejected app with ExpoKit for SDK33 without explicitly installing unimodules that
[ios] Make iOS ExpoKit work without unimodules that need to be scoped (#4336)
# Why
I was unable to build a newly ejected app with ExpoKit for SDK33 without explicitly installing unimodules that are being extended and overriden by scoped modules.
# How
Added `#if __has_include` macros to check whether the unimodule is installed before we initialize and register scoped modules.
# Test Plan
Expo Client builds, ExpoKit app without some unimodules work as expected.
show more ...
|
| #
c9802eba |
| 29-Apr-2019 |
Stanisław Chmiela <[email protected]> |
[unimodules] Remove experience references (#3993)
# Why
Properly closes https://github.com/expo/expo/pull/3875, fixes https://github.com/expo/expo/issues/3517, fixes https://github.com/expo/expo/
[unimodules] Remove experience references (#3993)
# Why
Properly closes https://github.com/expo/expo/pull/3875, fixes https://github.com/expo/expo/issues/3517, fixes https://github.com/expo/expo/issues/3864.
# How
Removed all `experience` references from universal modules, adding scoped implementations to ExpoKit.
# Test Plan
- [x] NCL works
- [x] bare template works
show more ...
|
| #
712e5c6c |
| 06-Mar-2019 |
Szymon20000 <[email protected]> |
[expo-file-system] Unscope paths in standalone/ejected scenarios (#3569)
|