| #
421487fa |
| 07-Apr-2022 |
Tomasz Sapeta <[email protected]> |
[ios] Fix build error on Xcode 13.2 (#16955)
|
| #
e4312942 |
| 28-Nov-2021 |
Kudo Chien <[email protected]> |
[autolinking] Patch react podspec for swift integration (#15299)
# Why
there are tons of mixing swift and objc issues in expo-modules-core. e.g.
- `include of non-modular header inside framework
[autolinking] Patch react podspec for swift integration (#15299)
# Why
there are tons of mixing swift and objc issues in expo-modules-core. e.g.
- `include of non-modular header inside framework module` when prebuild expo-modules-core
- sometimes swift functions cannot be loaded if there are react types.
the root cause is that clang doesn't generate submodules correctly. although clang can transform `#import <React/RCTBridge.h>` to `@import React.RCTBridge;`, clang cannot do it right as React.RCTBridge submodule doesn't exist. as swift only know modules, this will cause lots of problems when we use react types in swift.
# How
- patch `React-Core.podspec` with custom modulemap for clang to generate submodules correctly. (details in code comment)
- replace original CocoaPods `PodTarget` monkey patch with `Sandbox`. this new approach can patch podspec on the fly.
# Test Plan
- CI passed
- to further check what's the difference for the change, you can enable `BUILD_LIBRARY_FOR_DISTRIBUTION` for expo-modules-core pod project and check the swiftinterface for ExpoModulesCore.
e.g. `/Users/kudo/Library/Developer/Xcode/DerivedData/BareExpo-brnnteedtepltiasryrqyexlvweu/Build/Products/Debug-iphonesimulator/ExpoModulesCore/ExpoModulesCore.swiftmodule/x86_64-apple-ios-simulator.swiftinterface`
```swift
@_inheritsConvenienceInitializers @objc final public class ViewModuleWrapper : ExpoModulesCore.RCTViewManager {
```
before: it's `ExpoModulesCore.RCTViewManager`
```swift
@_inheritsConvenienceInitializers @objc final public class ViewModuleWrapper : React.RCTViewManager {
```
after: it's `React.RCTViewManager`
show more ...
|
| #
c2f6f870 |
| 18-Aug-2020 |
Stanisław Chmiela <[email protected]> |
[ios] Enable TurboModules (#9687)
# Why
We need to enable TurboModules to be able to include Reanimated v2.
> A known issue with this PR is that the community AsyncStorage seizes to work — it
[ios] Enable TurboModules (#9687)
# Why
We need to enable TurboModules to be able to include Reanimated v2.
> A known issue with this PR is that the community AsyncStorage seizes to work — it expects only native module, isn't compatible with TurboModule AsyncStorage and we do not import the AsyncStorage community module properly.
>
> **Actually**, https://github.com/react-native-community/async-storage/pull/418 should be enough.
# How
Apart from the more or less usual TurboModules setup (imports, headers, flags, C++ dialect) I had to move native modules that we override in Expo from `extraModulesForBridge:` to `getModuleInstanceFromClass:`.
I don't like that we have to use `RCTLogFunction` in `EXVersionManager` now (otherwise the code wouldn't compile), but I guess that if the type ever changes somebody will notice and backport the change to versioned SDKs.
# Test Plan
Expo Client compiled, home ran.
show more ...
|
| #
6a392fca |
| 27-Jun-2019 |
Stanisław Chmiela <[email protected]> |
[ios] Fix all warnings (#4738)
# Why
Fixes https://github.com/expo/expo/issues/4429.
# How
- added `Bolts` to `Podfile` to be able to suppress warnings from this specific pod,
- added sett
[ios] Fix all warnings (#4738)
# Why
Fixes https://github.com/expo/expo/issues/4429.
# How
- added `Bolts` to `Podfile` to be able to suppress warnings from this specific pod,
- added setting deployment target for all development pods
- went through every warning and fixed
# Test Plan
The project compiles, Camera works, ImagePicker works ok.
show more ...
|
| #
62dd6356 |
| 13-Apr-2018 |
Alicja Warchał <[email protected]> |
Permissions per experience (#2161)
* [android] Permissions module - ask for permissions per experience
* [android] Do not check/request permissions on the native side; customize the perm dialog
*
Permissions per experience (#2161)
* [android] Permissions module - ask for permissions per experience
* [android] Do not check/request permissions on the native side; customize the perm dialog
* [expo-sdk] Check permissions before invoking native method
* Revert "[expo-sdk] Check permissions before invoking native method"
This reverts commit f20c90d7622ec00d206a7e116f70f5c63714e1e0.
* [android] DO check permissions on the native side but do not request
* [ios] Scoped permissions - wip
* [ios] Proper perm in dialog; save user defaults correctly
* [ios] Check permissions when required
* [ios] Review updates
* [ios] Multiple kernel services fixes
* [android] Permissions per experience for Android < M
* [android] Change shape of permissions in metadata; further refactor for older Android APIs
* [android] Apply changes to previous SDKs
* [ios] Apply changes to previous SDKs
fbshipit-source-id: 328961f
show more ...
|
| #
cde16245 |
| 29-Dec-2017 |
Ben Roth <[email protected]> |
Split Core and Optional ExpoKit sources
fbshipit-source-id: 65abb7c
|