| #
0a9cf62f |
| 29-Jan-2023 |
Cedric van Putten <[email protected]> |
Upgrade `@react-native-community/[email protected]` ➡️ `@react-native-community/[email protected]` (#20926)
# Why
Fixes ENG-7318
# How
Ran `et update-vendored-module --module
@react-
Upgrade `@react-native-community/[email protected]` ➡️ `@react-native-community/[email protected]` (#20926)
# Why
Fixes ENG-7318
# How
Ran `et update-vendored-module --module
@react-native-community/datetimepicker --target expo-go --commit
5d174d097d2821911b73b5e308520f9e028b8348`
<details><summary>See log output</summary>
```bash
�� Cloning @react-native-community/datetimepicker#5d174d097d2821911b73b5e308520f9e028b8348 from https://github.com/react-native-community/react-native-datetimepicker.git
‼️ Using legacy vendoring for platform ios
NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.
Cleaning up iOS files at Exponent/Versioned/Core/Api/Components/DateTimePicker ...
Copying iOS files ...
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.m
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.m
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.h
> ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.m
Updating pbxproj configuration ...
Saving updated pbxproj structure to the file Exponent.xcodeproj/project.pbxproj ...
Successfully updated iOS files, but please make sure Xcode project files are setup correctly in Exponent/Versioned/Core/Api/Components/DateTimePicker
‼️ Using legacy vendoring for platform android
NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.
Cleaning up Android files at expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker ...
Copying Android files ...
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/Common.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/KeepDateInRangeListener.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/MinuteIntervalSnappableTimePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/ReflectionHelper.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNConstants.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDate.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogFragment.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogModule.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDisplay.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDateTimePickerPackage.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableDatePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableTimePickerDialog.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogFragment.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogModule.java
> android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDisplay.java
✍️ Updating bundled native modules
✍️ Updating workspace dependencies
�� Successfully updated @react-native-community/datetimepicker
```
</details>
# Test Plan
## Android
After changing:
- Add 1global.setImmediate = function(){};` -> to fix reanimated issue
- Change `@shopify/flash-list` (vendored SDK 46 and 47 code)
`androidx.annotation:annotation:+` to
`androidx.annotation:annotation:1.2.0`
I managed to test the date time picker on Android. Dropped a few test
features that weren't used, or are removed.
- The "open and hide dialog after 3 seconds" -> had no logic connected,
was mostly confusing
- Dropped `clock` and `calendar` (which is `default` now) enums.
- Updated `neutralButtonLabel` -> `neutralButton`
## iOS
> **Warning**
> Testing on iOS is currently blocked by building issues.
<details><summary>Build errors</summary>
</details>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|