| #
7c3ed0c0 |
| 14-Dec-2022 |
Douglas Lowder <[email protected]> |
[Expo Go][iOS] No remote home app loads in release builds (#20416)
# Why
Per ENG-7047, we need to disable remote loading of home app, and
checking for home app updates, for release builds.
Upda
[Expo Go][iOS] No remote home app loads in release builds (#20416)
# Why
Per ENG-7047, we need to disable remote loading of home app, and
checking for home app updates, for release builds.
Updates and loading from the packager will still work in debug builds.
# How
Add `#ifdef DEBUG` in several places in
`Exponent/Kernel/AppLoader/EXAppLoader.m`
# Test Plan
- CI should pass
- Test Expo Go builds locally and verify that updates are not loaded,
and that nothing else is broken
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
57bba33f |
| 21-Aug-2020 |
Eric Samelson <[email protected]> |
[android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 wi
[android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms
show more ...
|
| #
9ef743bc |
| 28-Jul-2020 |
Bartłomiej Bukowski <[email protected]> |
[LoadingView][managed] Extract loading bar from LoadingView (#9324)
LoadingProgressView was integrated into LoadingView that has to be mostly rewritten, because of expo-splash-screen integration. As
[LoadingView][managed] Extract loading bar from LoadingView (#9324)
LoadingProgressView was integrated into LoadingView that has to be mostly rewritten, because of expo-splash-screen integration. As expo-splash-screen has no knowledge about any loading progress and this very same loading progress has to be presented above all application content I decided to go with the approach that is proposed in ReactNative repo for their version of loading progress bar (that means using separate UIWindow on iOS and PopupWindow on Android).
show more ...
|