| #
529650a2 |
| 06-Sep-2023 |
Kudo Chien <[email protected]> |
[go] fix ios expo go crash from exceptions (#24305)
# Why
potentially to fix the strange ios crash after login
# How
- the root cause is that we didn't implement correct `RCTExceptionsManag
[go] fix ios expo go crash from exceptions (#24305)
# Why
potentially to fix the strange ios crash after login
# How
- the root cause is that we didn't implement correct `RCTExceptionsManagerDelegate` protocol from react-native upgrade. that would probably cause the error stacktrace:
```
Last Exception Backtrace:
0 CoreFoundation 0x1c938ce38 __exceptionPreprocess + 164 (NSException.m:202)
1 libobjc.A.dylib 0x1c25238d8 objc_exception_throw + 60 (objc-exception.mm:356)
2 CoreFoundation 0x1c950181c -[NSObject(NSObject) doesNotRecognizeSelector:] + 136 (NSObject.m:140)
3 CoreFoundation 0x1c93a2ce8 ___forwarding___ + 976 (NSForwarding.m:3620)
4 CoreFoundation 0x1c940b320 _CF_forwarding_prep_0 + 96 (:-1)
5 Expo Go 0x105588678 -[RCTExceptionsManager reportSoft:stack:exceptionId:extraDataAsJSON:] + 244 (RCTExceptionsManager.mm:50)
6 Expo Go 0x105589010 -[RCTExceptionsManager reportException:] + 1320 (RCTExceptionsManager.mm:156)
7 CoreFoundation 0x1c93f76b4 __invoking___ + 148 (:-1)
8 CoreFoundation 0x1c93a3b1c -[NSInvocation invoke] + 428 (NSForwarding.m:3377)
9 CoreFoundation 0x1c93a3534 -[NSInvocation invokeWithTarget:] + 64 (NSForwarding.m:3474)
10 Expo Go 0x105542a60 -[RCTModuleMethod invokeWithBridge:module:arguments:] + 388 (RCTModuleMethod.mm:584)
11 Expo Go 0x105544ac0 facebook::react::invokeInner(RCTBridge*, RCTModuleData*, unsigned int, folly::dynamic const&, int, (anonymous namespace)::SchedulingContext) + 456 (RCTNativeModule.mm:197)
12 Expo Go 0x105544710 facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int)::$_0::operator()() const + 68 (RCTNativeModule.mm:114)
13 Expo Go 0x105544710 invocation function for block in facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int) + 112 (RCTNativeModule.mm:105)
14 libdispatch.dylib 0x1d09a3460 _dispatch_call_block_and_release + 32 (init.c:1518)
15 libdispatch.dylib 0x1d09a4f88 _dispatch_client_callout + 20 (object.m:560)
16 libdispatch.dylib 0x1d09ac640 _dispatch_lane_serial_drain + 672 (inline_internal.h:2632)
17 libdispatch.dylib 0x1d09ad18c _dispatch_lane_invoke + 384 (queue.c:3940)
18 libdispatch.dylib 0x1d09b7e10 _dispatch_workloop_worker_thread + 652 (queue.c:6876)
19 libsystem_pthread.dylib 0x217604df8 _pthread_wqthread + 288 (pthread.c:2618)
20 libsystem_pthread.dylib 0x217604b98 start_wqthread + 8 (:-1)
```
- add `-Werror=protocol` to have compiler error if we don't implement correct protocol in the future.
# Test Plan
expo go release build + local build production home with some `console.error()`
show more ...
|
| #
167fd314 |
| 30-Jun-2021 |
Will Schurman <[email protected]> |
[ios] Use stable manifest ID where applicable (#13280)
|
| #
96c67d7e |
| 20-Aug-2020 |
Evan Bacon <[email protected]> |
[ios] Prevent native error modal from being shown on top of Logbox toasts in the client. (#9847)
* Prevent native errors from being shown on top of logbox in the client
* Update react-native
|
| #
b8e86ac0 |
| 06-May-2020 |
Tomasz Sapeta <[email protected]> |
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)
# Why
Part of #8047 - not closing yet because I'm gonna make separate PR for Android.
# How
I removed:
- Fabric and Crashlytics from
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)
# Why
Part of #8047 - not closing yet because I'm gonna make separate PR for Android.
# How
I removed:
- Fabric and Crashlytics from `Podfile` and run `pod install`.
- code calling Fabric & Crashlytics libraries.
- `et ios-run-fabric` command and its `run-fabric.sh` build phase in general.
- modifying `Info.plist` while generating dynamic macros, it was used only to apply fabric's api key.
- `et ios-cleanup-dynamic-macros` command - no longer needed if we don't modify `Info.plist`.
- Fabric's key from `Info.plist`.
## Side notes
Previously, once Crashlytics detects a crash, we set a flag in user defaults and then if that flag is set we invalidated cached kernel's bundle. After these changes, kernel's bundle won't be invalidated. I chatted with James and he agrees that we actually don't need this anymore.
# Test Plan
Xcode project builds and works as expected.
show more ...
|
| #
71a1d7ed |
| 10-May-2019 |
Stanisław Chmiela <[email protected]> |
[react-native] Upgrade to 0.59.8 (#4170)
# Why
Pull in latest changes from `react-native`.
# How
- created `sdk-33-candidate` branch by checking out `sdk-33`, running `git pull upstream 0.59-s
[react-native] Upgrade to 0.59.8 (#4170)
# Why
Pull in latest changes from `react-native`.
# How
- created `sdk-33-candidate` branch by checking out `sdk-33`, running `git pull upstream 0.59-stable --rebase` and creating this new branch
- changed all `react-native` versions in all `package.json`s in the monorepo to `0.59.8` so it matches `react-native-lab/react-native/package.json#version`
- installed pods after regenerating files
- ran `yarn` in `home` and then `et publish-dev-expo-home`
- ran `gulp android-update-rn` in `tools` to update `android/React{Android,Common}`
- fixed nullability specifier (the only non-automatic change in this PR) [`9743ed46`](https://github.com/expo/expo/pull/4170/commits/9743ed46ad52a88013c81571f8d1afe7e9c5378b)
# Test plan
Home looks and works ok on iOS and Android, NCL.ReactNativeCore screen too.
show more ...
|
| #
e7ac6e4f |
| 08-Mar-2018 |
Ben Roth <[email protected]> |
Restore ErrorRecovery and clean up visible/invisible app interface
fbshipit-source-id: 917ce6f
|
| #
5d8188f5 |
| 06-Mar-2018 |
Ben Roth <[email protected]> |
Clean up after kernel refactor
fbshipit-source-id: eb6ce29
|