| b8e86ac0 | 06-May-2020 |
Tomasz Sapeta <[email protected]> |
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)
# Why
Part of #8047 - not closing yet because I'm gonna make separate PR for Android.
# How
I removed:
- Fabric and Crashlytics from
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)
# Why
Part of #8047 - not closing yet because I'm gonna make separate PR for Android.
# How
I removed:
- Fabric and Crashlytics from `Podfile` and run `pod install`.
- code calling Fabric & Crashlytics libraries.
- `et ios-run-fabric` command and its `run-fabric.sh` build phase in general.
- modifying `Info.plist` while generating dynamic macros, it was used only to apply fabric's api key.
- `et ios-cleanup-dynamic-macros` command - no longer needed if we don't modify `Info.plist`.
- Fabric's key from `Info.plist`.
## Side notes
Previously, once Crashlytics detects a crash, we set a flag in user defaults and then if that flag is set we invalidated cached kernel's bundle. After these changes, kernel's bundle won't be invalidated. I chatted with James and he agrees that we actually don't need this anymore.
# Test Plan
Xcode project builds and works as expected.
show more ...
|