Deprecate source-login-scripts.sh (#18330)# Why the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other tha
Deprecate source-login-scripts.sh (#18330)# Why the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other than zsh and bash. this pr find a new way to deal with xcode building issues that it cannot find the correct nodejs path. close ENG-4864 close ENG-5242 # How react-native introduces `.xcode.env` and `.xcode.env.local` for developers to override the `$NODE_BINARY`: https://github.com/facebook/react-native/pull/33546 to make sure building success from expo-constants, expo-updates, and also the app target when generating bundles. i would like to reuse the `.xcode.env` and `.xcode.env.local` from react-native. this pr further generates `.xcode.env.local` automatically for the app during `pod install`. we can ensure that `pod install` is executed from shell and nodejs is available. so we will generate `export NODE_BINARY="$(command -v node)"` in the `.xcode.env.local`. for xcode, the path will be `$PODS_ROOT/../.xcode.env.local`, every xcode subprojects can source the file to get correct `$NODE_BINARY`. # Test Plan - building bare-expo from xcode (opening xcode by macos finder) - building bare-expo by `yarn ios` - updates e2e ci passed - building expo-go (prerequisite: #18344) Co-authored-by: James Ide <[email protected]>
show more ...
Revert "[segmented-control] upgrade segmented control to v2.4.0"This reverts commit dc3e7e2341b1cb660f1b54b18354df116f44158d.
[segmented-control] upgrade segmented control to v2.4.0
[ci] Update workflows to macOS 11 (#13497)
[ios] Split Expo Go to unversioned and versioned flavors (#11999)
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)# Why Part of #8047 - not closing yet because I'm gonna make separate PR for Android. # How I removed: - Fabric and Crashlytics from
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)# Why Part of #8047 - not closing yet because I'm gonna make separate PR for Android. # How I removed: - Fabric and Crashlytics from `Podfile` and run `pod install`. - code calling Fabric & Crashlytics libraries. - `et ios-run-fabric` command and its `run-fabric.sh` build phase in general. - modifying `Info.plist` while generating dynamic macros, it was used only to apply fabric's api key. - `et ios-cleanup-dynamic-macros` command - no longer needed if we don't modify `Info.plist`. - Fabric's key from `Info.plist`. ## Side notes Previously, once Crashlytics detects a crash, we set a flag in user defaults and then if that flag is set we invalidated cached kernel's bundle. After these changes, kernel's bundle won't be invalidated. I chatted with James and he agrees that we actually don't need this anymore. # Test Plan Xcode project builds and works as expected.
[ios] Add -x to Build Phase scripts
[ios] configure XCode Project to conditionally build with GoogleService-Info.plist (#5909)* [ios] remove plist, add conditional copy build script * [ios] remove plist from file explorer * [io
[ios] configure XCode Project to conditionally build with GoogleService-Info.plist (#5909)* [ios] remove plist, add conditional copy build script * [ios] remove plist from file explorer * [ios] add flag for public use * move script from xcodeproj to separate dir * chmod 755 * remove unrelated pbxproj diffs
[tools][expotools][android][ios][ci] Move generating dynamic macros to expotools (#4591)# Why Step of #4428 # How Moved generating dynamic macros to expotools. Also did some other cleanup
[tools][expotools][android][ios][ci] Move generating dynamic macros to expotools (#4591)# Why Step of #4428 # How Moved generating dynamic macros to expotools. Also did some other cleanups, like moving iOS build phase scripts to separate files - they will be easier to review in the future and it's easier to modify them when they are as a separate files other than inside pbxproj file. It adds three new expotools commands: - `et ios-generate-dynamic-macros` - `et ios-cleanup-dynamic-macros` -> not sure if we still need this, it just removes Info.plist backup - `et android-generate-dynamic-macros` # Test Plan - [x] `et ios-generate-dynamic-macros` successfully generated client's Podfile and ExpoKit.podspec - [x] Android's client builds fine - [x] iOS client builds fine