| #
5a02d672 |
| 06-Sep-2023 |
Will Schurman <[email protected]> |
[home] Fix tsc for expo-constants changes (#24312)
# Why
Types for classic manifests were removed in 50. This puts home in a
weird state where it could still get classic updates but not have the
[home] Fix tsc for expo-constants changes (#24312)
# Why
Types for classic manifests were removed in 50. This puts home in a
weird state where it could still get classic updates but not have the
types for them.
# How
The fix that I applied here was just to design for EAS Update. In places
that used to have special UI for classic updates, we now just show a
generic UI. This is the lowest attention cost and is the fastest way
forward (rather than reverting all the type changes and supporting
classic manifest types for longer in the home app).
# Test Plan
`yarn tsc`
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
283086b4 |
| 17-Aug-2023 |
Will Schurman <[email protected]> |
[expo-go] Add expo.fyi link to home unverified badge (#23984)
|
| #
a05208d3 |
| 26-Jun-2023 |
Will Schurman <[email protected]> |
[home] Better type dev menu, fix bugs, add verified indicator (#23059)
|
| #
c941c9cf |
| 21-Jun-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[go] Improve onboarding messaging (#23001)
# Why
Follow up PR of https://github.com/expo/expo/pull/22712
# How
Update `home` DevMenu onboarding to look just like the new dev-client
onboard
[go] Improve onboarding messaging (#23001)
# Why
Follow up PR of https://github.com/expo/expo/pull/22712
# How
Update `home` DevMenu onboarding to look just like the new dev-client
onboarding
# Test Plan
Run Expo Go unversioned on Android and iOS
<table>
<thead>
<tr>
<th></th>
<th>Android</th>
<th>iOS</th>
</tr>
</thead>
<tbody>
<tr>
<th>Simulator</th>
<td><img width="417" alt="image"
src="https://github.com/expo/expo/assets/11707729/6b9e0179-2051-4997-9320-aeb79f229182"></td>
<td><img width="417" alt="image"
src="https://github.com/expo/expo/assets/11707729/3a97f47e-9680-477b-90b2-8f5f9ba363d3"></td>
</tr>
<tr>
<th>Real Device</th>
<td><img width="417" alt="image"
src="https://github.com/expo/expo/assets/11707729/ec9c9cdb-24fa-473c-996e-dccd812b68ed"></td>
<td><img width="417" alt="image"
src="https://github.com/expo/expo/assets/11707729/7f12e156-cf3d-4b10-a6bd-242ef78b7fb2"></td>
</tr>
</tbody>
</table>
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Brent Vatne <[email protected]>
show more ...
|
| #
254495a6 |
| 21-Dec-2022 |
James Ide <[email protected]> |
[home] Simplify menu language (#20481)
|
| #
c24fd5ad |
| 12-Jul-2022 |
Juwan Wheatley <[email protected]> |
[home] optional chain manifest.extra accesses to prevent dev menu crashes (#18195)
|
| #
6d9de7e8 |
| 12-Jul-2022 |
Juwan Wheatley <[email protected]> |
[home] fix dev menu sdk version display (#18191)
|
| #
347d6d6e |
| 04-May-2022 |
Juwan Wheatley <[email protected]> |
[home] update Expo Go dev menu design (#17315)
* [home] update Expo Go dev menu design
* publish dev home
|
| #
94dbd83c |
| 07-Apr-2022 |
Juwan Wheatley <[email protected]> |
[home] don't show projects section when logged out and change dev servers placeholder to be a sign in/up prompt (#16933)
|
| #
bf984b90 |
| 28-Mar-2022 |
Juwan Wheatley <[email protected]> |
[home] Get name from EAS Update Manifests to show in 'recently opened' section and dev menu (#16779)
|
| #
5f73f127 |
| 21-Jan-2021 |
Bartłomiej Bukowski <[email protected]> |
[Android][fix] Remove JSONBundleConverter usage for passing manifest from Android to JS (#11678)
# Why
`Expo Go` is unable to load any project on Android now.
Recent change in app manifest shape
[Android][fix] Remove JSONBundleConverter usage for passing manifest from Android to JS (#11678)
# Why
`Expo Go` is unable to load any project on Android now.
Recent change in app manifest shape is responsible for that, namely, new `config plugin system` (for `ncl` project this file: https://github.com/expo/expo/blob/master/apps/native-component-list/app.config.js is adding some array with strings/objects alternately).
That is causing https://github.com/expo/expo/blob/fec8b1534e8d27584a685c01a3a12ff432b3fbbd/android/expoview/src/main/java/host/exp/exponent/utils/JSONBundleConverter.java#L72-L81 to throw an error.
# How
There's no way to convert `JSONArray` with different entries to `Bundle` data type as the latter does not allow arrays/lists containing different data types, only homogenous entries are allowed.
I've removed this conversion altogether and replaced all `<someBundle>.putBundle("manifest", JSONBundleConverter.JSONToBundle(manifest))` with `<someBundle>.putString("manifest" manifest.toString())`.
I've tried to find any place in the code that would read the `"manifest"` fields from the bundle, but failed to do so cc @lukmccall, as there are changes in the `DevMenu` module.
From now on, `manifest` field in `initialProps` is replaced by `manifestString` that has to be deserialised upon access. Fortunately this field is not used anywhere in our codebase.
# Test Plan
- [x] I've succeeded in launching `ncl` and `test-suite` again on Android and observed no regressions.
- [x] I've checked that DevMenu shows all the things in the header properly.
- [x] I've checked both Android & iOS behaviours.
show more ...
|
| #
3bfa4905 |
| 16-Jun-2020 |
James Ide <[email protected]> |
[home] Fix up many lint warnings
Ran yarn test and yarn lint (still a few warnings) to verify most have been fixed.
|
| #
24a0cefb |
| 30-Jan-2020 |
Tomasz Sapeta <[email protected]> |
[ios][home] Redesign DevMenu on iOS (#6793)
# Why
Part of #6521
# How
- Refactored JS code responsible for rendering DevMenu and converted it to TypeScript.
- Redesigned DevMenu to be a b
[ios][home] Redesign DevMenu on iOS (#6793)
# Why
Part of #6521
# How
- Refactored JS code responsible for rendering DevMenu and converted it to TypeScript.
- Redesigned DevMenu to be a bottom sheet instead of a modal to improve user experience.
- Upgraded `react-navigation-stack` to `^2.0.15`.
- In/out DevMenu animations are now controlled by JavaScript side (less native code).
- Moved Kernel's module methods related to DevMenu to separate `DevMenuModule` file (I think it makes the code using it clearer).
- `Nux` wasn't clear to me what it is and what it does, so I suggest renaming it to `Onboarding`.
- Prepared some stuff to be used on Android as well (Android support will come in a separate PR).
- Removed legacy menu gesture from both native code and from home user settings.
- Published dev home with those changes.
# Test Plan
- [x] Test on experience in debug mode
- [x] Test on experience in production mode
- [x] Test on snacks
- [x] Test on older SDKs
- [x] Test on simulators
- [x] Test that onboarding shows up once you open the experience for the first time or you didn't accept it yet (clicked `Got it` button).
# Demo
Expanding/collapsing demo on the left, onboarding screen on the right.
 
show more ...
|