| #
2fd75d6d |
| 25-Jul-2022 |
Kudo Chien <[email protected]> |
Deprecate source-login-scripts.sh (#18330)
# Why
the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other tha
Deprecate source-login-scripts.sh (#18330)
# Why
the `source-login-scripts.sh` introduced a lot of pain where the community reported much build errors from it. it doesn't support shells other than zsh and bash. this pr find a new way to deal with xcode building issues that it cannot find the correct nodejs path.
close ENG-4864
close ENG-5242
# How
react-native introduces `.xcode.env` and `.xcode.env.local` for developers to override the `$NODE_BINARY`: https://github.com/facebook/react-native/pull/33546
to make sure building success from expo-constants, expo-updates, and also the app target when generating bundles. i would like to reuse the `.xcode.env` and `.xcode.env.local` from react-native. this pr further generates `.xcode.env.local` automatically for the app during `pod install`. we can ensure that `pod install` is executed from shell and nodejs is available. so we will generate `export NODE_BINARY="$(command -v node)"` in the `.xcode.env.local`. for xcode, the path will be `$PODS_ROOT/../.xcode.env.local`, every xcode subprojects can source the file to get correct `$NODE_BINARY`.
# Test Plan
- building bare-expo from xcode (opening xcode by macos finder)
- building bare-expo by `yarn ios`
- updates e2e ci passed
- building expo-go (prerequisite: #18344)
Co-authored-by: James Ide <[email protected]>
show more ...
|
| #
93a12a7d |
| 07-Jun-2019 |
Tomasz Sapeta <[email protected]> |
[expotools] throw nix out of expotools �� (#4469)
# Why
Preparing the ground to #4428
As far as I know there is no need to utilize nix packages in expotools, however this was always a pain for
[expotools] throw nix out of expotools �� (#4469)
# Why
Preparing the ground to #4428
As far as I know there is no need to utilize nix packages in expotools, however this was always a pain for us since this takes so much time before we can run any command. To be honest I usually run expotools directly from `tools/expotools/bin/expotools.js` to omit nix.
# How
- Removed nix from expotools stub - can we open a champagne already? ��
- Added a wrapper around expotools that ensures build and node_modules folders are up to date
- Made asorted improvements in the output of expotools commands
Screenshot:
<img width="1178" alt="Screenshot 2019-06-07 at 00 22 13" src="https://user-images.githubusercontent.com/1714764/59070333-abda0f00-88ba-11e9-9d9d-a5fdbbec0315.png">
# Test Plan
Tried some different commands with different flags to cover all use cases.
show more ...
|