| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
89c23745 |
| 26-Apr-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[file-system] Remove deprecated UploadProgressData totalByteSent field (#22277)
# Why
Closes ENG-7226
Follow up PR updating docs -> #22278
# How
This PR removes the deprecated `totalByte
[file-system] Remove deprecated UploadProgressData totalByteSent field (#22277)
# Why
Closes ENG-7226
Follow up PR updating docs -> #22278
# How
This PR removes the deprecated `totalByteSent` field from
UploadProgressData
# Test Plan
Run NCL
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
show more ...
|
| #
675e8040 |
| 09-Feb-2023 |
Brent Vatne <[email protected]> |
Revert "[file-system][ios] Add utf-8 uri support (#21098)"
This reverts commit 5d068ab1ef35b574b386e420808221beffd6ef70.
|
| #
5d068ab1 |
| 08-Feb-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[file-system][ios] Add utf-8 uri support (#21098)
# Why
Closes https://github.com/expo/expo/issues/10476
# How
This PR updates all iOS local uri instances (NSURL) to parse them using
perce
[file-system][ios] Add utf-8 uri support (#21098)
# Why
Closes https://github.com/expo/expo/issues/10476
# How
This PR updates all iOS local uri instances (NSURL) to parse them using
percent-encoded characters when necessary, that way we're able to
support paths like `fs.documentDirectory + "中文"`. This also updates
# Test Plan
Added a new `Create UTF-8 uri` button to NCL so we can test this
show more ...
|
| #
4ee48f97 |
| 12-Jan-2023 |
Gabriel Donadel Dall'Agnol <[email protected]> |
[file-system] Fix UploadProgressData field name typo (#20804)
# Why
`UploadProgressData` `totalByteSent` key should be `totalBytesSent` to
be consistent with other FIleSystem properties like
`t
[file-system] Fix UploadProgressData field name typo (#20804)
# Why
`UploadProgressData` `totalByteSent` key should be `totalBytesSent` to
be consistent with other FIleSystem properties like
`totalBytesExpectedToSend`, `totalBytesWritten` and
`totalBytesExpectedToWrite`.
Closes ENG-6559
Follow up PR updating docs -> https://github.com/expo/expo/pull/20810
# How
This updates all native references of `totalByteSent` to
`totalBytesSent` and adds a getter `totalByteSent` property to
`UploadProgressData` events so users get a deprecation warning when
accessing `totalByteSent`
# Test Plan
Added a new `Download & Upload file` button to NCL so we can properly
test this
https://user-images.githubusercontent.com/11707729/212067976-a4bdd509-8937-4f27-9516-cee35ed94dca.mov
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|
| #
6b7802ba |
| 22-Nov-2022 |
Bartosz Kaszubowski <[email protected]> |
[file-system][docs] migrate package to autogenerated docs, APISection tweaks (#20103)
|
| #
35f78160 |
| 01-Sep-2021 |
Bartosz Kaszubowski <[email protected]> |
[eslint-config] remove `arrowParens` overwrite, reformat files (#14232)
|
| #
52eeb172 |
| 18-Aug-2021 |
Łukasz Kosmaty <[email protected]> |
[file-system][js] Make network task cancelable (#13318)
# Why
Added ability to cancel network tasks and a progress listener for file upload.
# How
- Created a `NetworkTask` class that is a
[file-system][js] Make network task cancelable (#13318)
# Why
Added ability to cancel network tasks and a progress listener for file upload.
# How
- Created a `NetworkTask` class that is a basic class for download and upload tasks.
- Added an upload progress listener.
# TODO
- [x] iOS - https://github.com/expo/expo/pull/13320
- [x] Android - https://github.com/expo/expo/pull/13319
show more ...
|
| #
5d59e2b8 |
| 20-Mar-2021 |
Brent Vatne <[email protected]> |
[ncl] A bunch of improvements while testing
|
| #
400de723 |
| 06-Mar-2021 |
Łukasz Kosmaty <[email protected]> |
[expo-file-system] Fix compatibility with Android R (#12032)
# Why
Followup of https://github.com/expo/expo/pull/11647.
# How
- Handled SAF files in the `expo-file-system`.
- Added a way
[expo-file-system] Fix compatibility with Android R (#12032)
# Why
Followup of https://github.com/expo/expo/pull/11647.
# How
- Handled SAF files in the `expo-file-system`.
- Added a way to ask for external storage write permissions.
> **Note**: Those changes were needed to ensure a smooth transition to a scoped storage on Android.
# Test Plan
- NCL ✅
show more ...
|
| #
711270f5 |
| 30-Sep-2020 |
Stanisław Chmiela <[email protected]> |
[ncl] Fix lint warnings (#10443)
# Why
Let's make NCL a top-notch application, always tidy etc.
# How
- configured ESLint for NCL
- fixed all warnings automatically
- changed manually all
[ncl] Fix lint warnings (#10443)
# Why
Let's make NCL a top-notch application, always tidy etc.
# How
- configured ESLint for NCL
- fixed all warnings automatically
- changed manually all `React.Component<object, …` that ESLint "automatically fixed" to `<{}` as per https://github.com/expo/expo/pull/10229#discussion_r490961694
# Test Plan
`yarn lint` no longer warns about warnings.
show more ...
|
| #
acefa979 |
| 29-Jun-2020 |
Evan Bacon <[email protected]> |
[ncl][chore] use community async storage (#9018)
* Install community async-storage
* Install pods in bare-expo
* Migrate NCL to community async storage
|
| #
284d38c7 |
| 23-Jun-2020 |
Evan Bacon <[email protected]> |
Fix progress image style (#8922)
|
| #
40c85575 |
| 22-Jun-2020 |
samehgirgis <[email protected]> |
Replace ProgressBarAndroid and ProgressViewIOS with expo-progress (#8890)
Co-authored-by: Evan Bacon <[email protected]>
|
| #
e331da1d |
| 18-Jun-2020 |
Evan Bacon <[email protected]> |
[chore] Fix lint and typescript errors in NCL (#8861)
* Fix lint errors
* Revice web unimplemented views
* Delete useDimensions.ts
* Remove unused screen object properties
* Convert to f
[chore] Fix lint and typescript errors in NCL (#8861)
* Fix lint errors
* Revice web unimplemented views
* Delete useDimensions.ts
* Remove unused screen object properties
* Convert to functional components
* Fix TypeScript errors
* Fix subscription bug
show more ...
|
| #
edaf9ec0 |
| 03-Jun-2020 |
Łukasz Kosmaty <[email protected]> |
[expo-file-system][ios] Fix missing completion handler call (#8599)
* [expo-file-system] Fix missing completion handler call
* [expo-file-system] Small NCL refactor
* [expo-file-system] Apply
[expo-file-system][ios] Fix missing completion handler call (#8599)
* [expo-file-system] Fix missing completion handler call
* [expo-file-system] Small NCL refactor
* [expo-file-system] Apply requested changes
* [expo-file-system] Run pod install in bare-expo
* [expo-file-system] Update changelog.md
* [expo-file-system] Apply requested changes & Update README
* [expo-file-system] Ensure that completionHandler will be called only once
show more ...
|
| #
031bd34f |
| 10-Dec-2019 |
Stanisław Chmiela <[email protected]> |
[expo-file-system][android] Fix free storage value (#6465)
# Why
Fix https://github.com/expo/expo/issues/6409.
# How
Reported value was precisely `2^53 - 1` for two users, which was suspici
[expo-file-system][android] Fix free storage value (#6465)
# Why
Fix https://github.com/expo/expo/issues/6409.
# How
Reported value was precisely `2^53 - 1` for two users, which was suspicious. A quick code inspection resulted in finding this small bug.
# Test Plan
The new button on the `FileSystem` screen reported `4360 MB available`, which seems more reasonable for a smartphone.
show more ...
|
| #
a47a1472 |
| 14-May-2019 |
Ville Immonen <[email protected]> |
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)
* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod
* [ncl][test-suite] Add new imported packages to de
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)
* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod
* [ncl][test-suite] Add new imported packages to dependencies
show more ...
|
| #
69185572 |
| 23-Apr-2019 |
Bartłomiej Bukowski <[email protected]> |
@bbarthec/migrate native component list to typescript (#3975)
* [ncl] Migrate to TypeScript
* [ncl] fix runtime on mobile devices
* [ncl] Apply review suggestions
|