[contacts][android] Fix `addContactAsync` failing when e-mail id is provided (#23877)# Why ENG-9682, fixes https://github.com/expo/expo/issues/23828 `addContactAsync` would fail when adding
[contacts][android] Fix `addContactAsync` failing when e-mail id is provided (#23877)# Why ENG-9682, fixes https://github.com/expo/expo/issues/23828 `addContactAsync` would fail when adding a contact with an e-mail of phone with a specified id. # How The ids shouldn't be provided by the user, they are generated by the OS on creation of the contact (on both iOS and Android). Fixed this by ignoring the id when adding a contact on the JS side. Updated the docs # Test Plan Tested on Android 13 Pixel 6 and iOS 16 iPhone 11 --------- Co-authored-by: Expo Bot <[email protected]>
show more ...
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)Why --- Prettier 3 is out. Add support for it with this linter config. **Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)Why --- Prettier 3 is out. Add support for it with this linter config. **Note for reviewer:** the first commit is the one with the actual changes. The rest of this PR are changes to get the linter passing (mostly autofix). How --- Update eslint-config-prettier and eslint-plugin-prettier. To address deprecation warnings, also update typescript-eslint/parser and typescript-eslint/eslint-plugin. Because of an update to typescript-eslint/parser, we need to suppress deprecation warnings (documented in a comment). Regenerated test snapshots. Due to the upgraded dependencies, typecasts and optional chaining are now auto-fixable by lint. This converts warnings into autofixes. Test Plan --- `yarn test` in the linter config. Run `expotools check --all --fix-lint --no-build --no-test --no-uniformity-check` to try this config on the whole repo. --------- Co-authored-by: Expo Bot <[email protected]>
[ncl] refactor deprecated code, remove no longer valid ignores (#20555)
[contacts][docs] convert to autogenerated docs, remove legacy exports (#20269)
[image-picker] Rework the image picker results (#19570)
[ncl] fix few warning and ignores (#16116)
[ncl] refactor components, improve typing (#14535)
[eslint-config] remove `arrowParens` overwrite, reformat files (#14232)
[apps] Replace `@unimodules/*` imports with `expo-modules-core` (#14079)
[expo-contacts] resolve presentFormAsync when form closes (#13699)* [expo-contacts][ios] resolve presentFormAsync after modal disappears * [expo-contacts][android] resolve presentFormAsync after
[expo-contacts] resolve presentFormAsync when form closes (#13699)* [expo-contacts][ios] resolve presentFormAsync after modal disappears * [expo-contacts][android] resolve presentFormAsync after activity exits * [ncl] add button to open native contact form * [expo-contacts] update CHANGELOG * address PR feedback
[ncl] lazy load components and improve startup (#12503)* lazy load screens * fix up test suite * load less icons * lint fix * Update AppNavigator.js * fix tsc * Create debugging.w
[ncl] lazy load components and improve startup (#12503)* lazy load screens * fix up test suite * load less icons * lint fix * Update AppNavigator.js * fix tsc * Create debugging.web.ts * updated pods
[ncl] A bunch of improvements while testing
Update ContactsAvatar.tsx
[expo-permissions] Add rename `CAMERA_ROLL` to `MEDIA_LIBRARY` & add write only permission (#10643)# Why Since iOS 14, we can add write-only permission to the media library. Moreover, we want to
[expo-permissions] Add rename `CAMERA_ROLL` to `MEDIA_LIBRARY` & add write only permission (#10643)# Why Since iOS 14, we can add write-only permission to the media library. Moreover, we want to remove `CAMERA_ROLL` to `MEDIA_LIBRARY`. # How - `CAMERA_ROLL` -> `MEDIA_LIBRARY` - added `WRITE_ONLY_MEDIA_LIBRARY`: - [x] media-library - [x] permissions - [x] image-picker - updated documentation # Test Plan - NCL ✅
[ci] Add Native Component List TS + ESLint checks (#10233)# Why NCL is the main app we use to test new SDK releases. We should make sure it always works and it works well. TS and ESLint checks a
[ci] Add Native Component List TS + ESLint checks (#10233)# Why NCL is the main app we use to test new SDK releases. We should make sure it always works and it works well. TS and ESLint checks are part of this task. # How Fixed TS and ESLint errors in other PRs. Removed `--watch` from `tsc` `package.json` script. Added CI job to test if NCL ts-compiles and has no ESLint problems. # Test Plan CI should pass once we merge all the fixes.
[ncl] Fix lint warnings (#10443)# Why Let's make NCL a top-notch application, always tidy etc. # How - configured ESLint for NCL - fixed all warnings automatically - changed manually all
[ncl] Fix lint warnings (#10443)# Why Let's make NCL a top-notch application, always tidy etc. # How - configured ESLint for NCL - fixed all warnings automatically - changed manually all `React.Component<object, …` that ESLint "automatically fixed" to `<{}` as per https://github.com/expo/expo/pull/10229#discussion_r490961694 # Test Plan `yarn lint` no longer warns about warnings.
[ncl] Fix contact image display (#10184)# Why QA process. # How Debugged natively and verified that the image is serialized into the contact object. Looked into NCL to see why doesn't it s
[ncl] Fix contact image display (#10184)# Why QA process. # How Debugged natively and verified that the image is serialized into the contact object. Looked into NCL to see why doesn't it show, noticed `as any` and that the types don't match. Fixed. # Test Plan I haven't tested this change (yet?)
[contacts] add isAvailableAsync method (#9640)* Added isAvailableAsync to expo-contacts * Update CHANGELOG.md * Updated docs and implementation
Migrate to react-navigation v5 (#8857)* Migrate apps/ to use react-navigation v5 * Update GeofencingScreen.tsx * Update GeofencingScreen.tsx * Updated useFocusEffect * Update MediaLibra
Migrate to react-navigation v5 (#8857)* Migrate apps/ to use react-navigation v5 * Update GeofencingScreen.tsx * Update GeofencingScreen.tsx * Updated useFocusEffect * Update MediaLibraryScreen.tsx * Update GeofencingScreen.tsx * Updated onFocus methods * Update BackgroundLocationMapScreen.tsx * Fix tab loading * Update ExpoComponents.ts * Updated Media Library * fix bare-expo routing in e2e * Update TaskManagerScreen.tsx * Improve linking configuration * Update MainNavigator.tsx * Updated prop signature * Update MainNavigator.tsx Co-authored-by: Brent Vatne <[email protected]>
[chore][ncl] Update contacts screen (#8859)* Migrate contacts screen to FC * Update ContactsScreen
[expo] Deprecate importing Linking from `expo` package and remove unused dependency (#8659)
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod * [ncl][test-suite] Add new imported packages to de
[ncl][test-suite] Change imports to SDK 33 syntax with the codemod (#4219)* [ncl][test-suite] Change imports to SDK 33 syntax with the codemod * [ncl][test-suite] Add new imported packages to dependencies
@bbarthec/migrate native component list to typescript (#3975)* [ncl] Migrate to TypeScript * [ncl] fix runtime on mobile devices * [ncl] Apply review suggestions