| #
52238d45 |
| 10-Oct-2022 |
Łukasz Kosmaty <[email protected]> |
[iOS][Android] Upgrade react-navigation to v6 (#19452)
# Why
Closes ENG-4149.
Closes ENG-4150.
Closes ENG-4160.
The react-navigation v5 doesn't work with the react-native 0.70. So, I've migr
[iOS][Android] Upgrade react-navigation to v6 (#19452)
# Why
Closes ENG-4149.
Closes ENG-4150.
Closes ENG-4160.
The react-navigation v5 doesn't work with the react-native 0.70. So, I've migrated NCL and Home to use v6.
# How
- Bumped versions of related packages.
- Went through the migration guide.
- Disable react-native-screens integration on Android in Home.
> Note:
I'm aware of [proposed fix](https://github.com/expo/expo/pull/16333) which fixes integration between screens and navigation on Android. However, I'm not sure if that change is safe. That's why, for now, `react-native-screens` were disabled.
# Test Plan
- expo-go - home ✅
- expo-go - NCL ✅
- bare-expo - NCL ✅
show more ...
|
| #
dc2b55f3 |
| 14-Apr-2021 |
Evan Bacon <[email protected]> |
[ncl] lazy load components and improve startup (#12503)
* lazy load screens
* fix up test suite
* load less icons
* lint fix
* Update AppNavigator.js
* fix tsc
* Create debugging.w
[ncl] lazy load components and improve startup (#12503)
* lazy load screens
* fix up test suite
* load less icons
* lint fix
* Update AppNavigator.js
* fix tsc
* Create debugging.web.ts
* updated pods
show more ...
|
| #
cd784c72 |
| 24-Sep-2020 |
Stanisław Chmiela <[email protected]> |
[ncl] Fix most of the TS errors adding types (#10229)
# Why
NCL is full of errors.
# How
Went through all of them and fixed them as it made sense in my opinion.
# Test Plan
TS no long
[ncl] Fix most of the TS errors adding types (#10229)
# Why
NCL is full of errors.
# How
Went through all of them and fixed them as it made sense in my opinion.
# Test Plan
TS no longer complains that much.
show more ...
|