| #
8a424beb |
| 11-Aug-2023 |
James Ide <[email protected]> |
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with th
[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)
Why
---
Prettier 3 is out. Add support for it with this linter config.
**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).
How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).
Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.
Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|
| #
f500022e |
| 08-Oct-2021 |
Bartosz Kaszubowski <[email protected]> |
[ncl] refactor components, improve typing (#14535)
|
| #
fb8cd7cf |
| 01-Oct-2021 |
Will Schurman <[email protected]> |
[native-component-list] Inform user about required API key for google geocoding (#14595) (#14601)
|
| #
711270f5 |
| 30-Sep-2020 |
Stanisław Chmiela <[email protected]> |
[ncl] Fix lint warnings (#10443)
# Why
Let's make NCL a top-notch application, always tidy etc.
# How
- configured ESLint for NCL
- fixed all warnings automatically
- changed manually all
[ncl] Fix lint warnings (#10443)
# Why
Let's make NCL a top-notch application, always tidy etc.
# How
- configured ESLint for NCL
- fixed all warnings automatically
- changed manually all `React.Component<object, …` that ESLint "automatically fixed" to `<{}` as per https://github.com/expo/expo/pull/10229#discussion_r490961694
# Test Plan
`yarn lint` no longer warns about warnings.
show more ...
|
| #
cd784c72 |
| 24-Sep-2020 |
Stanisław Chmiela <[email protected]> |
[ncl] Fix most of the TS errors adding types (#10229)
# Why
NCL is full of errors.
# How
Went through all of them and fixed them as it made sense in my opinion.
# Test Plan
TS no long
[ncl] Fix most of the TS errors adding types (#10229)
# Why
NCL is full of errors.
# How
Went through all of them and fixed them as it made sense in my opinion.
# Test Plan
TS no longer complains that much.
show more ...
|
| #
f91c6bb8 |
| 29-Jul-2020 |
Tomasz Sapeta <[email protected]> |
[location] Improve and refactor Geocoding API (#9444)
# Why
Messy code.
# How
- `geocodeAsync` and `reverseGeocodeAsync` now always use native implementations by default and don't fall back
[location] Improve and refactor Geocoding API (#9444)
# Why
Messy code.
# How
- `geocodeAsync` and `reverseGeocodeAsync` now always use native implementations by default and don't fall back to Google Maps API (it's been causing some mess and inconsistent results on Android).
- Since we still need Google Maps API implementation (for Web) I added such possibility to use it on other platforms as well with the new `useGoogleMaps` option.
- Added `district`, `subregion` and `timezone` fields to geocoded address object.
- Fixed `LocationGeocodedAddress` type to reflect the possibility of receiving `null` values.
- Added more TSDoc comments.
- Refactored `GeocodingScreen` in NCL.
# Test Plan
Tested NCL examples in the new Geocoding screen on iOS and Android ✅
Went through test-suite tests ✅
show more ...
|