| #
229dec0d |
| 22-Sep-2023 |
Łukasz Kosmaty <[email protected]> |
[notifications][Android] Convert all exported modules to new API (#24499)
# Why
Converts all exported modules to new API in `expo-notifications`.
# Test Plan
- bare-expo ✅
- expo go ✅
|
| #
5ff37293 |
| 01-Feb-2023 |
Kudo Chien <[email protected]> |
[android][tools] fix android versioning (#20889)
# Why
fix android versioning after react-native 0.71 upgrade
# How
mostly fixing transforms
# Test Plan
1. `et add-sdk -p android -s 4
[android][tools] fix android versioning (#20889)
# Why
fix android versioning after react-native 0.71 upgrade
# How
mostly fixing transforms
# Test Plan
1. `et add-sdk -p android -s 48.0.0`
2. `cd android ; ./gradlew :app:assembleVersionedDebug`
3. versioned android expo go + sdk 48 ncl smoke test
show more ...
|
| #
90fb2833 |
| 23-Jan-2023 |
Łukasz Kosmaty <[email protected]> |
[go][Android] Add support for new granular permissions on Android 13 (#20922)
# Why
Adds support for new granular permissions on Android 13 to the scoped permission code.
This is a follow-up to
[go][Android] Add support for new granular permissions on Android 13 (#20922)
# Why
Adds support for new granular permissions on Android 13 to the scoped permission code.
This is a follow-up to 656a42b55a003bdd5da9ea5cb5c07188d8264a5e and 8d01b0f3e9cb5d9f26fa914626738f5b2a0f8f80.
# Test Plan
- NCL ✅
show more ...
|
| #
834d6aa0 |
| 20-Oct-2022 |
Łukasz Kosmaty <[email protected]> |
[cellular] Add missing permissions requester (#19633)
# Why
Fixes:
```
- expo-cellular
- `generationName` is “unknown”
```
# How
It turns out that the `Manifest.permission.READ_PHON
[cellular] Add missing permissions requester (#19633)
# Why
Fixes:
```
- expo-cellular
- `generationName` is “unknown”
```
# How
It turns out that the `Manifest.permission.READ_PHONE_STATE` is danger permission (always has been). So users have to be asked to grant that permission in the runtime to obtain information like network generation.
I've added the missing permission getter and requester. Those methods only do something on Android. On other platforms, we can just return the granted response.
# Test Plan
- expo go with NCL ✅
show more ...
|
| #
cfbf2952 |
| 21-Sep-2022 |
Kudo Chien <[email protected]> |
[android][ios] Integrate JS inspector on Expo Go (#19175)
# Why
close ENG-4165
# How
- if the underlying js runtime is inspectable, show the dev menu as "Open JS Debugger" and open inspecto
[android][ios] Integrate JS inspector on Expo Go (#19175)
# Why
close ENG-4165
# How
- if the underlying js runtime is inspectable, show the dev menu as "Open JS Debugger" and open inspector provided by expo cli.
- on android, there's a workaround for checking js runtime isInspectable. because react-native doesn't expose the information from jsi runtime to java side, we could only check the underlying js executor name if it's hermes or not.
# Test Plan
- ✅ unversioned android/ios expo go + NCL (remote debugging)
- ✅ unversioned android/ios expo go + NCL jsEngine hermes (js inspector)
- ✅ unversioned android/ios expo go + NCL jsEngine hermes + tunnel (js inspector)
Co-authored-by: Łukasz Kosmaty <[email protected]>
show more ...
|
| #
e70ee015 |
| 23-Dec-2021 |
Bartłomiej Klocek <[email protected]> |
[android] Fix missing scoped permission (#15658)
|
| #
ef941d8a |
| 08-Oct-2020 |
Cedric van Putten <[email protected]> |
[permissions] Add missing background location to scoped requester (#10549)
|
| #
4672828f |
| 24-Sep-2020 |
Stanisław Chmiela <[email protected]> |
[android] Remove code responsible for InfoActivity (#10334)
# Why
Follow up to https://github.com/expo/expo/pull/10333. Removes `InfoActivity` we replaced with sophisticated dev menu.
# How
[android] Remove code responsible for InfoActivity (#10334)
# Why
Follow up to https://github.com/expo/expo/pull/10333. Removes `InfoActivity` we replaced with sophisticated dev menu.
# How
Removed `InfoActivity`, its layout, assets (`dev_menu` icon) and the code that showed the activity.
# Test Plan
I have confirmed Android Expo client compiled and tapping on the app name in the persistent notification does not open the `InfoActivity`.
show more ...
|
| #
f7fec16f |
| 28-Jun-2020 |
Filiph Sandström <[email protected]> |
Fix grammatical mistake (#7741)
|
| #
c596d6cd |
| 21-Feb-2020 |
Tomasz Sapeta <[email protected]> |
[android][home] Add DevMenu on Android (#6829)
# Why
Fixes #6521
# How
- Created unversioned `DevMenuManager` class which mostly just delegates calls to versioned `DevMenuModule` module
[android][home] Add DevMenu on Android (#6829)
# Why
Fixes #6521
# How
- Created unversioned `DevMenuManager` class which mostly just delegates calls to versioned `DevMenuModule` modules specific for SDK version. These modules are responsible for providing initial props, dev menu options and actions to run when these options are selected. The manager creates a new `ReactRootView` that bases on kernel's (home's) React instance manager and starts `HomeMenu` app which is registered as a second entry point in `home` and then, manager adds this root view to the currently used activity (it must implement `ExperienceActivity`). As I needed to know which experience activity is the current one, I've added `sCurrentActivity` static member to that class and just track it using activity's lifecycle methods.
- Backported `DevMenuModule` to all SDK versions included in the client. Including some changes between them - for example hot and fast reloading.
- Added support for back button and Android's menu press (which can be simulated by `adb shell input keyevent 82`).
- Removed some unused code related to `Nux` and replaced it with new onboarding screen (see #6793).
- Created new `ShakeDetector` which works more like on iOS. The one provided by React Native is annoying in most cases as it actually requires two shakes.
- Updated `ReactAndroidCodeTransformer` to turn off showing React Native dev menu in non-standalone apps.
- **To do after merging:** Rebuild versioned expoviews.
# Test Plan
- [x] Test on experience in debug mode
- [x] Test on experience in production mode
- [x] Test on snacks
- [x] Test on older SDKs
- [x] Test on simulators
- [x] Test that onboarding shows up once you open the experience for the first time or you didn't accept it yet (clicked `Got it` button).
- [x] Test that using dev menu still works once we kill home's activity.
show more ...
|
| #
a7100618 |
| 13-Nov-2019 |
Stanisław Chmiela <[email protected]> |
[expo] Remove unused dev menu (#6249)
# Why
To clean up some technical debt.
# How
Removed `addDevMenu` functionality from Home and then all the leftovers from native side.
# Test Plan
[expo] Remove unused dev menu (#6249)
# Why
To clean up some technical debt.
# How
Removed `addDevMenu` functionality from Home and then all the leftovers from native side.
# Test Plan
CI should build the apps.
show more ...
|
| #
284d4840 |
| 08-Nov-2019 |
Łukasz Kosmaty <[email protected]> |
[Permission] Rework (#5061)
* [Permissions] Extract base class for requester
* [Permissions] Refactor
* [Permissions] Make podspecs for each requester
* [Permissions] Add missing self ensur
[Permission] Rework (#5061)
* [Permissions] Extract base class for requester
* [Permissions] Refactor
* [Permissions] Make podspecs for each requester
* [Permissions] Add missing self ensurement to requesters
* [Permissions] Android fix
* [Permissions] Rewrite module to kotlin
* [Permissions] Move scoped ask to activity
* [Permissions] Remove permissions manager
* [Permissions] Remove PermissionsServiceBinding
* [Permissions] Make requesters
* [Permissions] Improve code styling
* [Permissions] Make SystemBrightnessRequester (#5147)
* Make SystemBrightnessRequester
* Make type enum
Co-Authored-By: Bartłomiej Bukowski <[email protected]>
* [Permissions] Rewrite android native api (#5186)
* Move logic form module to service
* Remove static var from PermissionsService
* Make getPermission not throwable
* Store asked permissions
* [Permissions] Make requester registrable (#5187)
* Clean iOS
* Fix scoped permissions status (never undetermined)
* Requesters belong to EXPermission
* Remove permissions delegate
* Make requester registrable
* [Permissions] Small fixes
* [Permissions] Add app ownership check and fix code style
* [Permissions] Rework native api (#5418)
* [Permissions] Move requesters to modules on iOS
* [Permissions] Add bool granted
* [Permissions] Add to native modules, permissions related methods
* [Permissions] Repair CI
* [Permissions] Fix typo
* [Permissions] Reduce boilerplate code
* [Permissions] Fix error description
* [Permissions] Export constants for permissions status
* [Permissions] Rename methods wrapper
* [Permissions] Remove scoped permissions from standalone apps
* [Permissions] Fix lateinit and scoped permissions
Location module in OnHostResume calls getPermissions method before Activity Provider is available.
* [Permissions] Add `never ask again` support
* [Permissions] Scoping only dangerous permission
* [Permissions] Rename `neverAskAgain` to `canAskAgain`
* [Permissions] Run pod install
* [Permissions] Update docs
* [Permissions] Fix CI
* [Permissions] Fix typo and imports after rebase
* [Permissions] Small improvements in Android
* [Permissions] Make test-suits pass
* [Permissions] Add requested changes
* [Permissions] Move ts types to unimodule
* [Permissions] Add missing requester
* [Permissions] Small fixes
* [Permissions] Fix after rebase
* [Permissions] Update docs
* [Permissions] Publish dev home
* [Permissions] Add kotlin dependency to build.gradle
* [Permissions] Fix permissions in ContactsModule
* [Permissions] Set manifest in HomeActivity class
* [Permissions] Regenerate pods projects
show more ...
|
| #
8a3b1a14 |
| 01-Feb-2019 |
Eric Samelson <[email protected]> |
[android] added missing string values to expo-av module
|
| #
fa21c06b |
| 14-Dec-2018 |
Eric Samelson <[email protected]> |
[android] remove READ_SMS permission (#2982)
# Why
https://support.google.com/googleplay/android-developer/answer/9047303
Google is restricting the use of the `READ_SMS` permission only to app
[android] remove READ_SMS permission (#2982)
# Why
https://support.google.com/googleplay/android-developer/answer/9047303
Google is restricting the use of the `READ_SMS` permission only to apps that can be the default handler of SMS messages. The current state of our SMS module means that no Expo apps can fit into this use case. We need to remove this permission from the Play Store APK by no later than January 9, 2019.
The `READ_SMS` permission is used only to determine the status of the SMS message after it's been sent -- the permission is not needed to open the system SMS modal. So we can just remove this part of the method and have `sendSMSAsync` always resolve with `{ result: 'unknown' }` and keep the the rest of the functionality. (This is in line with the `MailComposer` module, but we should resolve that to a value of `unknown` as well.)
# How
Removed all logic relating to `READ_SMS` and the `Permissions.SMS` value from the unversioned code, and NCL and test-suite. Made `sendSMSAsync` method always resolve with `{ result: 'unknown' }` on Android.
I decided to leave the older SDKs alone -- I think the current behavior is fine (SMS permissions are always denied, and `sendSMSAsync` rejects due to this). People can upgrade to SDK 32 if they want to use this module -- they'll need to anyway as Google will not allow their app on the Play Store if they use an SDK that requires `READ_SMS` permission.
companion docs PR: https://github.com/expo/universe/pull/3340
# Test Plan
Tested that `sendSMSAsync` always resolves with the correct value, and calling `Permissions.askAsync('SMS')` errors as expected, both in unversioned code.
Verified that calling either of these functions in an older SDK version does not cause the client to crash.
Was not able to test NCL changes -- I kept getting the "The Expo SDK requires Expo to run" error
show more ...
|
| #
cbcf8286 |
| 17-Jul-2018 |
Bartłomiej Bukowski <[email protected]> |
Fix Android permissions for Android.VersionCode < M (#2834)
* [android][unimodules] Fix Android permissions for Android.VersionCode < M
* [android] Fix review comment
* [android][expo-permissions]
Fix Android permissions for Android.VersionCode < M (#2834)
* [android][unimodules] Fix Android permissions for Android.VersionCode < M
* [android] Fix review comment
* [android][expo-permissions] Extract status/granted/expires/denied strings as private static final Strings
fbshipit-source-id: 5dac19e
show more ...
|
| #
c9d1eb92 |
| 30-May-2018 |
Eric Samelson <[email protected]> |
target Android Oreo + add support for notification channels (#2536)
fbshipit-source-id: b1a2dd8
|
| #
8945e295 |
| 23-May-2018 |
Eric Samelson <[email protected]> |
native info/error screens (#2510)
fbshipit-source-id: b1def03
|
| #
62dd6356 |
| 13-Apr-2018 |
Alicja Warchał <[email protected]> |
Permissions per experience (#2161)
* [android] Permissions module - ask for permissions per experience
* [android] Do not check/request permissions on the native side; customize the perm dialog
*
Permissions per experience (#2161)
* [android] Permissions module - ask for permissions per experience
* [android] Do not check/request permissions on the native side; customize the perm dialog
* [expo-sdk] Check permissions before invoking native method
* Revert "[expo-sdk] Check permissions before invoking native method"
This reverts commit f20c90d7622ec00d206a7e116f70f5c63714e1e0.
* [android] DO check permissions on the native side but do not request
* [ios] Scoped permissions - wip
* [ios] Proper perm in dialog; save user defaults correctly
* [ios] Check permissions when required
* [ios] Review updates
* [ios] Multiple kernel services fixes
* [android] Permissions per experience for Android < M
* [android] Change shape of permissions in metadata; further refactor for older Android APIs
* [android] Apply changes to previous SDKs
* [ios] Apply changes to previous SDKs
fbshipit-source-id: 328961f
show more ...
|
| #
4e857c60 |
| 12-Jan-2018 |
Stanisław Chmiela <[email protected]> |
Fullscreen video player for Android (#1583)
fbshipit-source-id: bdf250e
|
| #
e25682c1 |
| 15-Sep-2017 |
Jeffrey Da <[email protected]> |
Add native Payments module without local maven
fbshipit-source-id: 079d44c
|
| #
6aecae58 |
| 04-Mar-2017 |
Jesse Ruder <[email protected]> |
ExponentView -> ExpoView
fbshipit-source-id: 46cffc7
|