| #
05bcf8e7 |
| 21-Sep-2023 |
Wojciech Dróżdż <[email protected]> |
[go] Improve the incompatible SDK version error screen (#24310)
# Why
We want to improve the incompatible SDK error screen in Expo Go, because
we will be supporting only two SDK versions, so mor
[go] Improve the incompatible SDK version error screen (#24310)
# Why
We want to improve the incompatible SDK error screen in Expo Go, because
we will be supporting only two SDK versions, so more people will see it.
# How
- The header is now descriptive instead of generic "Something went
wrong"
- Updated the message to provide more information
- The message now contains a link to a docs page
- On iOS it was created with attributed string and replacing the UILabel
with UITextView
- On Android we embed html hyperlink into the message and then render
the text as HTML
- Added update instructions into the docs page. Also added instructions
on how to install an older version of Expo Go.
# Test Plan
Tested in Go on iOS 16 and Android SDK 33, 34
<img width="190" alt="image"
src="https://github.com/expo/expo/assets/31368152/c79ec613-8f19-4aef-91d0-99c682124f31">
<img width="190" alt="image"
src="https://github.com/expo/expo/assets/31368152/292d8fcd-5532-4ac9-828a-6d870c396040">
<img width="190" alt="image"
src="https://github.com/expo/expo/assets/31368152/d94eff4e-0113-4cea-a5ee-64a9284fb254">
<img width="190" alt="image"
src="https://github.com/expo/expo/assets/31368152/6c819e52-2cc5-4e6f-9614-0bb22427e61c">
---------
Co-authored-by: Brent Vatne <[email protected]>
show more ...
|
| #
d211fd84 |
| 20-Sep-2023 |
Wojciech Dróżdż <[email protected]> |
[android] Remove unnecessary version checks (#24203)
# Why
This PR is related to #24201, it removes unnecessary version checks
# How
Remove version check logic for SDK's < 23
# Test Pla
[android] Remove unnecessary version checks (#24203)
# Why
This PR is related to #24201, it removes unnecessary version checks
# How
Remove version check logic for SDK's < 23
# Test Plan
Tested in Bare Expo in Android 13 simulator
show more ...
|
| #
19a0af8d |
| 15-Sep-2023 |
Will Schurman <[email protected]> |
[go] Load embedded bundle and manifest in release builds (#24412)
|
| #
5f54863a |
| 08-Sep-2023 |
Will Schurman <[email protected]> |
[tools] Switch expo home publishing to EAS update (#24216)
|
| #
894c0196 |
| 26-Jul-2023 |
Łukasz Kosmaty <[email protected]> |
[go][Android] Create a `ModuleProvider` for home app (#23708)
# Why
Creates a dedicated `ModuleProvider` for the home app.
# How
We're currently initializing all modules written in the new
[go][Android] Create a `ModuleProvider` for home app (#23708)
# Why
Creates a dedicated `ModuleProvider` for the home app.
# How
We're currently initializing all modules written in the new API when creating a home bridge. It's unnecessary, so I've made a dedicated `ModuleProvider` for the main app.
Also, this change will allow us to add the Expo Go specific module to the home app.
# Test Plan
- expo go ✅
show more ...
|
| #
570504b8 |
| 23-Feb-2023 |
Kudo Chien <[email protected]> |
[go][android] fix textinput crash in home (#21368)
# Why
fix textinput crash on expo go home
close ENG-7643
# How
in the ReactRootView, the context is actually `MainApplication`, which is
[go][android] fix textinput crash in home (#21368)
# Why
fix textinput crash on expo go home
close ENG-7643
# How
in the ReactRootView, the context is actually `MainApplication`, which is not quite correct. We should pass Activity to views instead.
# Test Plan
using Android 13 emulator to click textinput in expo go home
show more ...
|
| #
ff9f745f |
| 31-Jan-2023 |
Kudo Chien <[email protected]> |
[home] use hermes engine (#21011)
# Why
close ENG-7162
# How
- [android] support hermes in loading home app
- [home] use hermes engine
# Test Plan
- unversioned android/ios expo go +
[home] use hermes engine (#21011)
# Why
close ENG-7162
# How
- [android] support hermes in loading home app
- [home] use hermes engine
# Test Plan
- unversioned android/ios expo go + local home + `console.log(globalThis.HermesInternal)`
show more ...
|
| #
04819bfd |
| 19-Oct-2022 |
Łukasz Kosmaty <[email protected]> |
[iOS][Android] Update reanimated to `2.11.0` (#19602)
# Why
Closes ENG-6530.
# How
- Adjusted the vendored process to use the new version of the script on Android.
- Run `et update-vendor
[iOS][Android] Update reanimated to `2.11.0` (#19602)
# Why
Closes ENG-6530.
# How
- Adjusted the vendored process to use the new version of the script on Android.
- Run `et update-vendored-module -m react-native-reanimated`
- Made sure that the integration between the reanimated and the gesture-handler still works
# Test Plan
- bare-expo with NCL ✅
show more ...
|
| #
3ba32fe9 |
| 13-Jul-2022 |
Kudo Chien <[email protected]> |
[android] Fix build errors after #18168 removed packages (#18219)
# Why
fix android expo go build errors from #18168 removed some packages
# How
- removed integration code
- port `BundleJS
[android] Fix build errors after #18168 removed packages (#18219)
# Why
fix android expo go build errors from #18168 removed some packages
# How
- removed integration code
- port `BundleJSONConverter` from internal facebook sdk to our code
- add necessary 3rd party sdks to versioned sdk dependencies. that is to make sure sdk 44/45 still works
# Test Plan
- unversioned android expo go + NCL
- versioned android expo go + NCL
show more ...
|
| #
40772498 |
| 27-Jun-2022 |
Kudo Chien <[email protected]> |
[android] Fix random crash from retrieving the finishing NotificationForwarderActivity (#17982)
# Why
regression from #17974 because the call flow is NotificationForwarderActivity -> start activi
[android] Fix random crash from retrieving the finishing NotificationForwarderActivity (#17982)
# Why
regression from #17974 because the call flow is NotificationForwarderActivity -> start activity -> finish(). there's chance to retrieve the finishing task in kernel and causes NPE or unmarshalling exception.
# How
add try-catch to match the existingTask
# Test Plan
click the scheduled notification in expo go
show more ...
|
| #
b90b2e78 |
| 13-Jun-2022 |
Kudo Chien <[email protected]> |
[notifications] Fix opening wrong activity for expo go (#17751)
# Why
fix #17686 for expo go to open wrong activity
# How
from #17686 the PendingIntent for foreground activity missed some i
[notifications] Fix opening wrong activity for expo go (#17751)
# Why
fix #17686 for expo go to open wrong activity
# How
from #17686 the PendingIntent for foreground activity missed some intent extra. we should also call `NotificationsService.setNotificationResponseToIntent` like the original implementation:
https://github.com/expo/expo/blob/6097718a9a1b69c672a3845336c42fb86da13c61/packages/expo-notifications/android/src/main/java/expo/modules/notifications/service/delegates/ExpoHandlingDelegate.kt#L123
# Test Plan
unversioned expo go + NCL "schedule notification for 10 seconds from now", pressing home key to background the app and click the notification after 10 seconds.
show more ...
|
| #
031e1c70 |
| 25-Oct-2021 |
Will Schurman <[email protected]> |
[expo-updates][android] Make onBundleCompleted non-nullable (#14838)
|
| #
50661f5c |
| 30-Aug-2021 |
Will Schurman <[email protected]> |
[expo-manifests] Rename RawManifest -> Manifest (#14194)
|
| #
706a476d |
| 26-Aug-2021 |
Will Schurman <[email protected]> |
[expo-updates] Factor out raw manifests into their own package (#14183)
|
| #
094c4ddd |
| 19-Aug-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize DI (#14039)
|
| #
cd4bd26b |
| 19-Aug-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize notification utils (#14020)
|
| #
88711250 |
| 19-Aug-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize storage (#14018)
|
| #
7113164b |
| 09-Aug-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize ReactNativeActivity and ExperienceActivity (#13870)
|
| #
4d53947f |
| 04-Aug-2021 |
Will Schurman <[email protected]> |
[android] Fix erroneous manifest JSON direct access (#13906)
|
| #
d44a6d96 |
| 03-Aug-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize ExpoApplication (#13836)
|
| #
aa3c92ea |
| 27-Jul-2021 |
Will Schurman <[email protected]> |
[android] Kotlinize kernel (#13685)
|