| #
b02264fb |
| 17-Jun-2022 |
Kudo Chien <[email protected]> |
[notifications] Fix issues from push notifications (#17871)
# Why
another fix for android 12 notification trampoline issue
# How
1. text input notification category is a broken regression f
[notifications] Fix issues from push notifications (#17871)
# Why
another fix for android 12 notification trampoline issue
# How
1. text input notification category is a broken regression from #17686 where to get the text input placeholder from `RemoteInput` has NPE. we can get the placeholder from `NotificationAction.placeholder` now.
2. update FCM version for https://github.com/expo/expo/pull/17686#issuecomment-1154700811. originally there was [some blocker from updating to cloud messaging 22.0 because from other firebase sdk versions](https://github.com/expo/expo/pull/15010#issuecomment-1079194697). thank to @bbarthec upgrade firebase sdks in sdk 45, we can now update cloud messaging successfully. checked to [the changelog](https://firebase.google.com/support/release-notes/android#messaging_v22-0-0), there're no other breaking changes. it should be safe to upgrade to the version.
3. there're still some `FirebaseInstanceId` in expo go, migrate these code as #15010
# Test Plan
bare-expo + NCL Notifications `send me a push notification` test case
show more ...
|