| #
3218138c |
| 28-Jun-2023 |
Kudo Chien <[email protected]> |
[go] fix network inspector stability on android (#23158)
# Why
fix some stability issues for network inspector on android expo go
close ENG-9111
# How
- disable network inspector when devS
[go] fix network inspector stability on android (#23158)
# Why
fix some stability issues for network inspector on android expo go
close ENG-9111
# How
- disable network inspector when devSupportEnabled=false. this case happens when loading bundles without dev support, e.g. published updates.
- original network inspector is broken on versioned expo go. because we add the okhttp interceptors from unversioned classes, but on **ReactNativeActivity** we use the versioned classes to set the delegate.
# Test Plan
use versioned release expo go to test
- [x] sdk 49 project with network inspector
- [x] sdk 49 published project with network requests -> should not crash
- [x] sdk 48 project with network requests -> should not crash
show more ...
|
| #
60ad5af1 |
| 21-Jun-2023 |
Kudo Chien <[email protected]> |
[go] add network inspector support (#22741)
# Why
add network inspector support for expo go
close ENG-8010
# How
integrate the ExpoRequestCdpInterceptor from expo-modules-core. unlike expo
[go] add network inspector support (#22741)
# Why
add network inspector support for expo go
close ENG-8010
# How
integrate the ExpoRequestCdpInterceptor from expo-modules-core. unlike expo-dev-launcher to use hacky solution, we want to enable the network inspector on release mode, so the implementation follows formal way.
- on ios, we leverage the `RCTSetCustomNSURLSessionConfigurationProvider` from react-native to create dedicated `URLSessionConfiguration`.
- on android, we already have a dedicated okhttp client from expo go. this pr just adds the interceptors.
- found image requests are not intercepted, it is because we don't use okhttp for fresco image pipeline. this pr tries to use the okhttp for fresco as react-native.
- android expo go has multiple react instances. however, the network inspector currently only support single inspector target to metro-inspector-proxy. as the result, we only limit the current foreground activity to send network inspector events.
# Test Plan
ncl + expo go to test the network inspector
show more ...
|