| #
3d20bbfa |
| 11-Jan-2023 |
Aman Mittal <[email protected]> |
[docs] Add steps to update API reference docs (#20768)
Co-authored-by: Bartosz Kaszubowski <[email protected]>
|
| #
edee0724 |
| 23-Dec-2022 |
Aman Mittal <[email protected]> |
[contributing]: Update docs port number to 3002 (#20589)
|
| #
dd7c660d |
| 05-Oct-2022 |
Igor Ordecha <[email protected]> |
[github] Contributing: Fix Konsole executable name (#19402)
|
| #
32cf793d |
| 09-Aug-2022 |
Brent Vatne <[email protected]> |
[contributing] Update guide for clarity
|
| #
4a51ff9a |
| 13-Jul-2022 |
Bartłomiej Klocek <[email protected]> |
[contributing] Update Java version (#18216)
|
| #
b81ec416 |
| 08-Feb-2022 |
Kim Brandwijk <[email protected]> |
[docs] rename master to main in contributing guidelines (#16217)
|
| #
42588157 |
| 26-Jan-2022 |
Brent Vatne <[email protected]> |
[markdown] Update various markdown files to new main branch
|
| #
9dbe3379 |
| 24-Nov-2021 |
Dominick Vale <[email protected]> |
[bare-expo] Fix start-metro script on Linux (#15087)
# Why
Running `yarn android` as per documentation on a linux distribution (Manjaro/Arch) fails to successfully run the `start-metro.sh` script
[bare-expo] Fix start-metro script on Linux (#15087)
# Why
Running `yarn android` as per documentation on a linux distribution (Manjaro/Arch) fails to successfully run the `start-metro.sh` script with the error `open: command not found`. Upon investigation and research i found that indeed there is no such thing as `open` on linux. The closest thing to it it's `xdg-open`, but executing the `commandFile` with that utility would most probably open it with the default text editor instead of actually executing it.
# How
My humble solution is to check if the OS type is not MacOS and spawn a new default terminal (set by the non-standard `TERMINAL` env variable since i don't currently know any better way to get the default terminal application on linux) window with nohup and redirecting all the output to /dev/null so that it doesn't create the `nohup.out` file...
# Test Plan
On linux, following the CONTRIBUTION.md docs the `start-metro.sh` script should fail with the error `open: command not found`. I did NOT test this on windows/WSL yet but i'm fairly sure the error would be the same.
# Checklist
- [x] Documentation is up to date to reflect these changes (CONTRIBUTION.md)
- [x] Check for os in apps/bare-expo/scripts/start-metro.sh and fix on linux
### Personal notes
My first open source PR :)
show more ...
|
| #
de43828e |
| 13-Nov-2021 |
Vojtech Novak <[email protected]> |
[contributing] specify yarn edit script location (#12678)
Co-authored-by: Bartosz Kaszubowski <[email protected]>
|
| #
dcc395e1 |
| 06-Jul-2021 |
Marc Rousavy <[email protected]> |
[docs] Mention Node version of 14 or above (#13491)
|
| #
2cfc8c5a |
| 18-Jun-2021 |
Jakub <[email protected]> |
[setup] Update Android setup scripts & docs (#13108)
|
| #
1cd978b1 |
| 01-Jun-2021 |
Tomasz Sapeta <[email protected]> |
[guides] Add a guide about updating changelogs (#13075)
|
| #
d01a0a7b |
| 31-May-2021 |
Brent Vatne <[email protected]> |
[contributing] Use WSL from Windows
|
| #
492d6b85 |
| 18-May-2021 |
Kudo Chien <[email protected]> |
[bare-expo] Add detox testing for android (#12893)
# Why
Originally, detox testing is not enabled on Android.
Though we had `expotools android-native-unit-tests --type instrumented`, unfortunate
[bare-expo] Add detox testing for android (#12893)
# Why
Originally, detox testing is not enabled on Android.
Though we had `expotools android-native-unit-tests --type instrumented`, unfortunately, the test cases right now only test on modules themselves but not bare-expo.
With this PR, we could be more confident from bare-expo or test-suites regressions.
# How
Fix debox build on Andriod.
# Test Plan
Make these works
`yarn android:detox:test:debug`
`yarn android:detox:test:release`
show more ...
|
| #
2494ec4a |
| 13-May-2021 |
Jakub <[email protected]> |
[docs] Fix misplaced code block & update clone steps (#12922)
|
| #
5929583e |
| 19-Mar-2021 |
Eric Samelson <[email protected]> |
add note about ruby 2.7 to contributing guide
|
| #
f096bf5c |
| 10-Jun-2020 |
Evan Bacon <[email protected]> |
Update CONTRIBUTING.md
|
| #
0f6857e1 |
| 26-May-2020 |
Jarvis Luong <[email protected]> |
[docs] mention direnv in contributing guideline (#7842)
* [docs] mention direnv in contributing guideline
* Update CONTRIBUTING.md
Co-authored-by: Charlie Cruzan <[email protected]
[docs] mention direnv in contributing guideline (#7842)
* [docs] mention direnv in contributing guideline
* Update CONTRIBUTING.md
Co-authored-by: Charlie Cruzan <[email protected]>
Co-authored-by: Charlie Cruzan <[email protected]>
show more ...
|
| #
62073571 |
| 12-May-2020 |
Thorben Primke <[email protected]> |
[contributing] Adds Step To Unit Testing About Mocking (#8240)
# Why
I was working on a [PR](https://github.com/expo/expo/pull/8199/) for a package that did not have unit tests yet. It took me a
[contributing] Adds Step To Unit Testing About Mocking (#8240)
# Why
I was working on a [PR](https://github.com/expo/expo/pull/8199/) for a package that did not have unit tests yet. It took me a few min to figure out where to add the mocks for the native functions.
To help others, this adds a note to the contributing instructions.
# How
Updated the contributing document.
# Test Plan
None.
show more ...
|
| #
ef80677c |
| 07-Apr-2020 |
Nick Novitski <[email protected]> |
Remove nix
|
| #
eae5f0b1 |
| 10-Mar-2020 |
Tomasz Sapeta <[email protected]> |
[changelog] Add changelog to every module (#7324)
# Why
Prerequisite for #6178
# How
- Added empty changelogs to every maintained Expo module (excluding Flutter plugins).
- Copied existing
[changelog] Add changelog to every module (#7324)
# Why
Prerequisite for #6178
# How
- Added empty changelogs to every maintained Expo module (excluding Flutter plugins).
- Copied existing entries from the main changelog to appropriate modules' changelogs
# Test Plan
Nothing to test ♂
show more ...
|
| #
ce547c3e |
| 06-Mar-2020 |
Brent Vatne <[email protected]> |
[contributing] Add Nix setup instructions
|
| #
d4ca1135 |
| 03-Feb-2020 |
guanw <[email protected]> |
Update CONTRIBUTING.md (#6941)
seems the anchor has to include the extra chars
|
| #
1ef3e21e |
| 10-Jan-2020 |
Hays Stanford <[email protected]> |
[docs] removed duplicate "is" in CONTRIBUTING.md (#6728)
|
| #
e12a7039 |
| 08-Jan-2020 |
Brent Vatne <[email protected]> |
[contributing] Update instructions to attempt to be more clear (#6702)
|