| #
6da15324 |
| 27-Aug-2021 |
Bartosz Kaszubowski <[email protected]> |
[eslint-config] bump dependencies and minimum required lint tools versions (#13858)
Co-authored-by: James Ide <[email protected]>
|
| #
93b7c965 |
| 28-Aug-2020 |
Stanisław Chmiela <[email protected]> |
[expotools] Move ios-shell-app task to expotools (#9965)
# Why
Migrating tools to `expotools` ��
# How
Added a new command file to `expotools` — `IosShellApp`. Copied the code from `tools-
[expotools] Move ios-shell-app task to expotools (#9965)
# Why
Migrating tools to `expotools` ��
# How
Added a new command file to `expotools` — `IosShellApp`. Copied the code from `tools-public` responsible for creating iOS shell apps. To create the options set I had to dive deep into `xdl` and infer args from there.
# Test Plan
I can't test it properly before SDK39 drops — right now kernel expects `expo-updates` to be present in the standalone app and `xdl` thinks the app we're building is still on SDK38 (`exponent-view-template/…/Supporting/EXSDKVersions.plist` renders `38.0.0` as _latest_).
At least the build steps run, see [build](https://github.com/expo/expo/runs/1040914498).
show more ...
|
| #
13f2b711 |
| 21-Aug-2020 |
James Ide <[email protected]> |
Fix/suppress all lint warnings in Home and enforce lint in CI (#9874)
Why
We have several lint warnings in Home that then get mentioned in PRs that don't even touch those files or introduce the w
Fix/suppress all lint warnings in Home and enforce lint in CI (#9874)
Why
We have several lint warnings in Home that then get mentioned in PRs that don't even touch those files or introduce the warnings. To improve CI signal and to keep the project warning-free I also enforced `--max-warnings=0` in CI.
How
This PR is split into four commits:
1. Update the ESLint dependencies (minor updates) and adjust the linter configuration so that we replace `no-unused-expressions` with `@babel/no-unused-expressions`, which fixes false positives when using the optional chaining operator (c.f. https://github.com/babel/eslint-plugin-babel/issues/185).
2. ESLint 7+ makes it so that newer versions of the ESLint TypeScript plugin can say it takes care of `ts` and `tsx` files so that we don't need to pass in `--ext` anymore. Remove the `--ext` option from the expo-module-scripts lint script.
3. Run `yarn lint --fix` in Home and fix up remaining warnings or suppress them for now.
4. Make CI fail if new warnings are added back to Home with `yarn lint --max-warnings=0`.
Test Plan
Ran `yarn lint` under `home`. The CI run for this PR will make sure that Home CI passes.
show more ...
|
| #
ed08e5dc |
| 09-Mar-2020 |
Tomasz Sapeta <[email protected]> |
[eslint] Enable ESLint and Prettier in tools folder
|
| #
7b8f6e6a |
| 28-Aug-2018 |
Exponent GitHub Bot <[email protected]> |
Set up linter + prettier configuration for the Expo repo
Adds a newer version of eslint-config-universe with base linter configurations. Each workspace does not yet have its own, more precise config
Set up linter + prettier configuration for the Expo repo
Adds a newer version of eslint-config-universe with base linter configurations. Each workspace does not yet have its own, more precise configuration right now.
The ESLint config contains root: true so that it doesn't inherit from ESLint configs higher up in the file system. There is also a prettierrc file that both prettier and eslint-config-universe will read i.e. our config is consistent.
Closes #3075
fbshipit-source-id: 0c6d05f
show more ...
|