| 85e21b77 | 14-Oct-2021 |
Bruce Richardson <[email protected]> |
telemetry: fix socket path conflicts for in-memory mode
When running using in-memory mode, multiple processes can use the same
runtime dir, leading to conflicts with the telemetry sockets in that
di
telemetry: fix socket path conflicts for in-memory mode
When running using in-memory mode, multiple processes can use the same
runtime dir, leading to conflicts with the telemetry sockets in that
directory. We can resolve this by appending a suffix to each socket
beyond the first, with the suffix being an increasing counter value.
Each process uses the first unused socket counter value.
Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
Reported-by: David Marchand <[email protected]>
Signed-off-by: Bruce Richardson <[email protected]>
Acked-by: Ciara Power <[email protected]>
Acked-by: Kevin Traynor <[email protected]>
Tested-by: Conor Walsh <[email protected]>
show more ...
|
| 04896027 | 05-May-2021 |
Ciara Power <[email protected]> |
telemetry: fix race on callbacks list
The list_commands() function accessed the callbacks list,
but did not take the lock. This may have caused inconsistencies if
callbacks were being registered at
telemetry: fix race on callbacks list
The list_commands() function accessed the callbacks list,
but did not take the lock. This may have caused inconsistencies if
callbacks were being registered at the same time.
This is now fixed to lock before iterating the list,
and unlock afterwards.
Fixes: f38748736eb2 ("telemetry: add default callback commands")
Cc: [email protected]
Reported-by: David Marchand <[email protected]>
Signed-off-by: Ciara Power <[email protected]>
Acked-by: Bruce Richardson <[email protected]>
show more ...
|
| 027c931b | 21-Apr-2021 |
Thomas Monjalon <[email protected]> |
telemetry: fix build on FreeBSD < 12.2
The function pthread_setname_np() was originally not available on
FreeBSD. It has been added in FreeBSD 12.2:
https://svnweb.freebsd.org/base?view=revision&rev
telemetry: fix build on FreeBSD < 12.2
The function pthread_setname_np() was originally not available on
FreeBSD. It has been added in FreeBSD 12.2:
https://svnweb.freebsd.org/base?view=revision&revision=362264
The EAL implementation of rte_thread_setname() is duplicated
in the telemetry library, which does not depend on EAL,
so the compilation is safe in all systems.
Fixes: 5da7736f8c53 ("telemetry: set socket listener thread name")
Signed-off-by: Thomas Monjalon <[email protected]>
show more ...
|