remove unnecessary null checksFunctions like free, rte_free, and rte_mempool_freealready handle NULL pointer so the checks here are not necessary.Remove redundant NULL pointer checks before free
remove unnecessary null checksFunctions like free, rte_free, and rte_mempool_freealready handle NULL pointer so the checks here are not necessary.Remove redundant NULL pointer checks before free functionsfound by nullfree.cocciSigned-off-by: Stephen Hemminger <[email protected]>
show more ...
version: 21.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 22.0.The map files are updated to the new ABI major number (22).The ABI exceptions are dropped and C
version: 21.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 22.0.The map files are updated to the new ABI major number (22).The ABI exceptions are dropped and CI ABI checks are disabled becausecompatibility is not preserved.Signed-off-by: Thomas Monjalon <[email protected]>Acked-by: Ferruh Yigit <[email protected]>Acked-by: David Marchand <[email protected]>
log: register with standardized namesLet's try to enforce the convention where most drivers use a pmd. logtypewith their class reflected in it, and libraries use a lib. logtype.Introduce two new
log: register with standardized namesLet's try to enforce the convention where most drivers use a pmd. logtypewith their class reflected in it, and libraries use a lib. logtype.Introduce two new macros:- RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is used in a component. It is associated to the default name provided by the build system,- RTE_LOG_REGISTER_SUFFIX can be used when multiple logtypes are used, and then the passed name is appended to the default name,RTE_LOG_REGISTER is left untouched for existing external usersand for components that do not comply with the convention.There is a new Meson variable log_prefix to adapt the default namefor baseband (pmd.bb.), bus (no pmd.) and mempool (no pmd.) classes.Note: achieved with below commands + reverted change on net/bonding +edits on crypto/virtio, compress/mlx5, regex/mlx5$ git grep -l RTE_LOG_REGISTER drivers/ | while read file; do pattern=${file##drivers/}; class=${pattern%%/*}; pattern=${pattern#$class/}; drv=${pattern%%/*}; case "$class" in baseband) pattern=pmd.bb.$drv;; bus) pattern=bus.$drv;; mempool) pattern=mempool.$drv;; *) pattern=pmd.$class.$drv;; esac sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; done$ git grep -l RTE_LOG_REGISTER lib/ | while read file; do pattern=${file##lib/}; pattern=lib.${pattern%%/*}; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file; sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file; doneSigned-off-by: David Marchand <[email protected]>Signed-off-by: Thomas Monjalon <[email protected]>Acked-by: Bruce Richardson <[email protected]>
drivers: change indentation in build filesSwitch from using tabs to 4 spaces for meson.build indentation.Signed-off-by: Bruce Richardson <[email protected]>
build: align wording of non-support reasonsReasons for building not supported generally start with lowercasebecause printed as the second part of a line.Other changes: - "linux" should be "Linu
build: align wording of non-support reasonsReasons for building not supported generally start with lowercasebecause printed as the second part of a line.Other changes: - "linux" should be "Linux" with a capital letter. - ARCH_X86_64 may be simply x86_64. - aarch64 is preferred over arm64.Signed-off-by: Thomas Monjalon <[email protected]>Acked-by: David Marchand <[email protected]>
net/vdev_netvsc: fix device probing error flowIf a device probe fails, the alarm is canceled and will no longer workfor previously probed devices.Fix this by checking if alarm is necessary at th
net/vdev_netvsc: fix device probing error flowIf a device probe fails, the alarm is canceled and will no longer workfor previously probed devices.Fix this by checking if alarm is necessary at the end of each deviceprobe. Reset the alarm if there are vdev_netvsc_ctx created.Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")Cc: [email protected]Signed-off-by: Long Li <[email protected]>Acked-by: Matan Azrad <[email protected]>
build: remove library name from version map file nameSince each version map file is contained in the subdirectory of the libraryit refers to, there is no need to include the library name in the fi
build: remove library name from version map file nameSince each version map file is contained in the subdirectory of the libraryit refers to, there is no need to include the library name in the filename.This makes things simpler in case of library renaming.Signed-off-by: Bruce Richardson <[email protected]>Acked-by: Luca Boccassi <[email protected]>Acked-by: Andrew Rybchenko <[email protected]>Acked-by: Rosen Xu <[email protected]>
build: remove makefilesA decision was made [1] to no longer support Make in DPDK, this patchremoves all Makefiles that do not make use of pkg-config, along withthe mk directory previously used by
build: remove makefilesA decision was made [1] to no longer support Make in DPDK, this patchremoves all Makefiles that do not make use of pkg-config, along withthe mk directory previously used by make.[1] https://mails.dpdk.org/archives/dev/2020-April/162839.htmlSigned-off-by: Ciara Power <[email protected]>Reviewed-by: Ruifeng Wang <[email protected]>Signed-off-by: Thomas Monjalon <[email protected]>
version: 20.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 21.0.The ABI major is back to normal, having only one number (21 vs 20.0).The map files are updated
version: 20.11-rc0Start a new release cycle with empty release notes.The ABI version becomes 21.0.The ABI major is back to normal, having only one number (21 vs 20.0).The map files are updated to the new ABI major number (21).The ABI exceptions are dropped.Travis ABI check is disabled because compatibility is not preserved.Signed-off-by: Thomas Monjalon <[email protected]>Acked-by: Ray Kinsella <[email protected]>
log: introduce logtype register macroIntroduce the RTE_LOG_REGISTER macro to avoid the code duplicationin the logtype registration process.It is a wrapper macro for declaring the logtype, regist
log: introduce logtype register macroIntroduce the RTE_LOG_REGISTER macro to avoid the code duplicationin the logtype registration process.It is a wrapper macro for declaring the logtype, registering it andsetting its level in the constructor context.Signed-off-by: Jerin Jacob <[email protected]>Acked-by: Adam Dybkowski <[email protected]>Acked-by: Sachin Saxena <[email protected]>Acked-by: Akhil Goyal <[email protected]>
build: disable experimental API check internallyRemove setting ALLOW_EXPERIMENTAL_API individually for each Makefile andmeson.build. Instead, enable ALLOW_EXPERIMENTAL_API flag across app, liband
build: disable experimental API check internallyRemove setting ALLOW_EXPERIMENTAL_API individually for each Makefile andmeson.build. Instead, enable ALLOW_EXPERIMENTAL_API flag across app, liband drivers.This changes reduces the clutter across the project while stillmaintaining the functionality of ALLOW_EXPERIMENTAL_API i.e. warningexternal applications about experimental API usage.Signed-off-by: Pavan Nikhilesh <[email protected]>Acked-by: Hemant Agrawal <[email protected]>Signed-off-by: David Marchand <[email protected]>
build: remove redundant config includeThe header file rte_config.h is always included by make or meson.If required in an exported API header file, it must be includedin the public header file for
build: remove redundant config includeThe header file rte_config.h is always included by make or meson.If required in an exported API header file, it must be includedin the public header file for external applications.In the internal files, explicit include of rte_config.h is useless,and can be removed.Signed-off-by: Thomas Monjalon <[email protected]>Acked-by: Matan Azrad <[email protected]>Acked-by: David Marchand <[email protected]>Acked-by: Neil Horman <[email protected]>
build: align symbols with global ABI versionMerge all versions in linker version script files to DPDK_20.0.This commit was generated by running the following command::~/DPDK$ buildtools/update-
build: align symbols with global ABI versionMerge all versions in linker version script files to DPDK_20.0.This commit was generated by running the following command::~/DPDK$ buildtools/update-abi.sh 20.0Signed-off-by: Pawel Modrak <[email protected]>Signed-off-by: Anatoly Burakov <[email protected]>Acked-by: Bruce Richardson <[email protected]>Acked-by: Thomas Monjalon <[email protected]>
build: remove individual library versionsSince the library versioning for both stable and experimental ABI's isnow managed globally, the LIBABIVER and version variables no longerserve any useful
build: remove individual library versionsSince the library versioning for both stable and experimental ABI's isnow managed globally, the LIBABIVER and version variables no longerserve any useful purpose, and can be removed.The replacement in Makefiles was done using the following regex: ^(#.*\n)?LIBABIVER\s*:=\s*\d+\n(\s*\n)?(LIBABIVER := numbers, optionally preceded by a comment and optionallysucceeded by an empty line)The replacement for meson files was done using the following regex: ^(#.*\n)?version\s*=\s*\d+\n(\s*\n)?(version = numbers, optionally preceded by a comment and optionallysucceeded by an empty line)[David]: those variables are manually removed for the files:- drivers/common/qat/Makefile- lib/librte_eal/meson.build[David]: the LIBABIVER is restored for the external ethtool examplelibrary.Signed-off-by: Anatoly Burakov <[email protected]>Signed-off-by: David Marchand <[email protected]>Acked-by: Thomas Monjalon <[email protected]>
drivers: remove duplicated compiler flagsNow that -Wextra, and other warning flags are standard in the build, removeany duplication in driver build specifications.Signed-off-by: Bruce Richardson
drivers: remove duplicated compiler flagsNow that -Wextra, and other warning flags are standard in the build, removeany duplication in driver build specifications.Signed-off-by: Bruce Richardson <[email protected]>Acked-by: Luca Boccassi <[email protected]>
net/vdev_netvsc: use new ethernet address parserUse rte_ether_unformat_addr rather than sscanf.Signed-off-by: Stephen Hemminger <[email protected]>Acked-by: Matan Azrad <matan@mellanox.
net/vdev_netvsc: use new ethernet address parserUse rte_ether_unformat_addr rather than sscanf.Signed-off-by: Stephen Hemminger <[email protected]>Acked-by: Matan Azrad <[email protected]>
drivers: add reasons for components being disabledFor each driver where we optionally disable it, add in the reason why it'sbeing disabled, so the user knows how to fix it.Signed-off-by: Bruce R
drivers: add reasons for components being disabledFor each driver where we optionally disable it, add in the reason why it'sbeing disabled, so the user knows how to fix it.Signed-off-by: Bruce Richardson <[email protected]>Acked-by: Luca Boccassi <[email protected]>
eal: fix positive error codes from probe/removeAccording to API, 'rte_dev_probe()' and 'rte_dev_remove()' mustreturn 0 or negative error code. Bus code returns positive valuesif device wasn't rec
eal: fix positive error codes from probe/removeAccording to API, 'rte_dev_probe()' and 'rte_dev_remove()' mustreturn 0 or negative error code. Bus code returns positive valuesif device wasn't recognized by any driver, so the result of'bus->plug/unplug()' must be converted. 'local_dev_probe()' and'local_dev_remove()' also has their internal API, so the conversionshould be done there.Positive on remove means that device not found by driver.Positive on probe means that there are no suitable buses/drivers,i.e. device is not supported.Users of these API fixed to provide a good example by respectingDPDK API. This also will allow to catch such issues in the future.Fixes: a3ee360f4440 ("eal: add hotplug add/remove device")Fixes: 244d5130719c ("eal: enable hotplug on multi-process")Cc: [email protected]Signed-off-by: Ilya Maximets <[email protected]>Reviewed-by: David Marchand <[email protected]>
fix off-by-one errors in snprintfsnprintf guarantees to always correctly place a null terminatorin the buffer string. So manually placing a null terminatorin a buffer right after a call to snprin
fix off-by-one errors in snprintfsnprintf guarantees to always correctly place a null terminatorin the buffer string. So manually placing a null terminatorin a buffer right after a call to snprintf is redundant code.Additionally, there is no need to use 'sizeof(buffer) - 1' in snprintf as thismeans we are not using the last character in the buffer. 'sizeof(buffer)' isenough.Cc: [email protected]Signed-off-by: Michael Santana <[email protected]>Acked-by: Bruce Richardson <[email protected]>Acked-by: Anatoly Burakov <[email protected]>
net: add rte prefix to ether functionsAdd 'rte_' prefix to functions:- rename is_same_ether_addr() as rte_is_same_ether_addr().- rename is_zero_ether_addr() as rte_is_zero_ether_addr().- rename
net: add rte prefix to ether functionsAdd 'rte_' prefix to functions:- rename is_same_ether_addr() as rte_is_same_ether_addr().- rename is_zero_ether_addr() as rte_is_zero_ether_addr().- rename is_unicast_ether_addr() as rte_is_unicast_ether_addr().- rename is_multicast_ether_addr() as rte_is_multicast_ether_addr().- rename is_broadcast_ether_addr() as rte_is_broadcast_ether_addr().- rename is_universal_ether_addr() as rte_is_universal_ether_addr().- rename is_local_admin_ether_addr() as rte_is_local_admin_ether_addr().- rename is_valid_assigned_ether_addr() as rte_is_valid_assigned_ether_addr().- rename eth_random_addr() as rte_eth_random_addr().- rename ether_addr_copy() as rte_ether_addr_copy().- rename ether_format_addr() as rte_ether_format_addr().Signed-off-by: Olivier Matz <[email protected]>Reviewed-by: Stephen Hemminger <[email protected]>Reviewed-by: Maxime Coquelin <[email protected]>Reviewed-by: Ferruh Yigit <[email protected]>
net: add rte prefix to ether structuresAdd 'rte_' prefix to structures:- rename struct ether_addr as struct rte_ether_addr.- rename struct ether_hdr as struct rte_ether_hdr.- rename struct vlan_
net: add rte prefix to ether structuresAdd 'rte_' prefix to structures:- rename struct ether_addr as struct rte_ether_addr.- rename struct ether_hdr as struct rte_ether_hdr.- rename struct vlan_hdr as struct rte_vlan_hdr.- rename struct vxlan_hdr as struct rte_vxlan_hdr.- rename struct vxlan_gpe_hdr as struct rte_vxlan_gpe_hdr.Do not update the command line library to avoid adding a dependency tolibrte_net.Signed-off-by: Olivier Matz <[email protected]>Reviewed-by: Stephen Hemminger <[email protected]>Reviewed-by: Maxime Coquelin <[email protected]>Reviewed-by: Ferruh Yigit <[email protected]>
build: increase readability via shortcut variablesDefine variables for "is_linux", "is_freebsd" and "is_windows"to make the code shorter for comparisons and more readable.Signed-off-by: Bruce Ri
build: increase readability via shortcut variablesDefine variables for "is_linux", "is_freebsd" and "is_windows"to make the code shorter for comparisons and more readable.Signed-off-by: Bruce Richardson <[email protected]>Reviewed-by: David Marchand <[email protected]>Acked-by: Luca Boccassi <[email protected]>
net/vdev_netvsc: fix device castThe return value from bus->find_device is a rte_devicewhich is not safe to cast to a rte_vdev_device structure.It doesn't really matter since only being checked fo
net/vdev_netvsc: fix device castThe return value from bus->find_device is a rte_devicewhich is not safe to cast to a rte_vdev_device structure.It doesn't really matter since only being checked for NULLbut static checkers might find a bug here.Fixes: 56252de779a6 ("net/vdev_netvsc: add automatic probing")Cc: [email protected]Signed-off-by: Stephen Hemminger <[email protected]>Acked-by: Matan Azrad <[email protected]>
net/vdev_netvsc: get rid of unnecessary debug log messageIf vdev_netvsc is run with debug logging enabled, then thelog output will fill with: net_vdev_netvsc: interface lo is non-ethernet device
net/vdev_netvsc: get rid of unnecessary debug log messageIf vdev_netvsc is run with debug logging enabled, then thelog output will fill with: net_vdev_netvsc: interface lo is non-ethernet deviceRemove the message since it is not useful.Signed-off-by: Stephen Hemminger <[email protected]>Acked-by: Matan Azrad <[email protected]>
net/vdev_netvsc: disable in FreeBSD build with mesonDisabled vdev_netvsc build in FreeBSD because it is not supported.Added changes to enable vdev_netvsc build if it is Linux OS anddisable in Fre
net/vdev_netvsc: disable in FreeBSD build with mesonDisabled vdev_netvsc build in FreeBSD because it is not supported.Added changes to enable vdev_netvsc build if it is Linux OS anddisable in FreeBSD.Fixes: 9fc43dbfd66e ("net/vdev_netvsc: add in meson build")Signed-off-by: Agalya Babu RadhaKrishnan <[email protected]>Acked-by: Stephen Hemminger <[email protected]>
12