| 5becae16 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: cleanup pre-processor tags
The codes has been exposed correctly, so remove pre-processor tags.
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <wei.zhao1@int
net/ixgbe/base: cleanup pre-processor tags
The codes has been exposed correctly, so remove pre-processor tags.
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 13de2444 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: remove default advertising for x550 2.5G/5G
We are seeing interoperability issues with switches when 2.5G and 5G
in x550 are advertised by default, so default to off.
Signed-off-by:
net/ixgbe/base: remove default advertising for x550 2.5G/5G
We are seeing interoperability issues with switches when 2.5G and 5G
in x550 are advertised by default, so default to off.
Signed-off-by: Todd Fujinaka <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| ab6ac48d | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: improve log about autoneg being disabled
On ESXi OS, when user disables auto negotiation, the following log
appears: "(unsupported) Flow control autoneg is disabled".
It is true that
net/ixgbe/base: improve log about autoneg being disabled
On ESXi OS, when user disables auto negotiation, the following log
appears: "(unsupported) Flow control autoneg is disabled".
It is true that auto negotiation is disabled but it is
not necessarily true that it is not supported.
Signed-off-by: Jakub Chylkowski <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 40543be5 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: initialize data field in struct buffer
While sending request using ixgbe_hic_unlocked() the data field in
buffer struct is not used. It is set when the struct is overwritten by
FW to
net/ixgbe/base: initialize data field in struct buffer
While sending request using ixgbe_hic_unlocked() the data field in
buffer struct is not used. It is set when the struct is overwritten by
FW to deliver the response. To not pass random data to FW the whole
structure should be zeroed before use.
Signed-off-by: Krzysztof Galazka <[email protected]>
Signed-off-by: Piotr Pietruszewski <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 658dfd34 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: remove log message FC autoneg
The function ixgbe_device_supports_autoneg_fc is checking whether
a particular device and medium configuration is supporting
Flow Control Autonegotiatio
net/ixgbe/base: remove log message FC autoneg
The function ixgbe_device_supports_autoneg_fc is checking whether
a particular device and medium configuration is supporting
Flow Control Autonegotiation. In case of non-support, the message
is always logged which is confusing.
The fix is removing unnecessary log entry.
Signed-off-by: Zalfresso-Jundzillo <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 390445ec | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: move increments after evaluations
The retry variable was being incremented before it was evaluated by the
subsequent conditional against the maximum retries to figure out which
messa
net/ixgbe/base: move increments after evaluations
The retry variable was being incremented before it was evaluated by the
subsequent conditional against the maximum retries to figure out which
message to print. So we'll move the increment op to the end.
Signed-off-by: Jeb Cramer <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 40023f73 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: remove whitespace in function comments
Remove unnecessary extra whitespace on all function comments, replacing
' * ' with ' * '.
This was done automatically via sed using the follo
net/ixgbe/base: remove whitespace in function comments
Remove unnecessary extra whitespace on all function comments, replacing
' * ' with ' * '.
This was done automatically via sed using the following transformation:
sed 's/^ \* / * /'
Signed-off-by: Jacob Keller <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| fc75eee3 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: cleanup spelling mistakes in comments
Several functions in the driver code have a weird function comment
formatting which uses two spaces instead of only one space for the main
funct
net/ixgbe/base: cleanup spelling mistakes in comments
Several functions in the driver code have a weird function comment
formatting which uses two spaces instead of only one space for the main
function body.
This formatting will be mechanically fixed by sed in a future patch, but
doing so leads to some spelling warnings on that patch. Cleanup the
spelling mistakes that will be detected first. This way, it is easier to
verify the mechanical transformation done by sed in the following patch.
Signed-off-by: Jacob Keller <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| 2d04b9e8 | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: fix infinite recursion on PCIe link down
In some corner cases the functions ixgbe_clear_rar_generic and
ixgbe_clear_vmdq_generic may call one another leading to infinite
recursion.
net/ixgbe/base: fix infinite recursion on PCIe link down
In some corner cases the functions ixgbe_clear_rar_generic and
ixgbe_clear_vmdq_generic may call one another leading to infinite
recursion.
When ixgbe_clear_vmdq_generic is called with IXGBE_CLEAR_VMDQ_ALL
flag, it's going to clear MPSAR registers, and proceed to call
ixgbe_clear_rar_generic, which in turn will clear the RAR registers,
and recursively call back ixgbe_clear_vmdq_generic. Normally, the
latter would detect that MPSAR registers have already been cleared
and terminate the recursion.
However, when PCIe link is down, and before the driver has had the
opportunity to shut itself down, all register reads return 0xFFFFFFFF,
and all register writes fail silently. In such case, because
ixgbe_clear_vmdq_generic blindly assumes that clearing MPSAR registers
succeeded, it's going to always call ixgbe_clear_rar_generic, which
in turn will always call back ixgbe_clear_vmdq_generic, creating
infinite recursion.
This patch re-reads MPSAR register values after they had been cleared.
In case of PCIe link failure, the values read will be non-zero, which
will terminate the recursion. On the other hand, under normal
circumstances the value read from MPSAR registers is going to be equal
to the value previously written, so this patch is expected not to cause
any regressions.
Fixes: af75078fece3 ("first public release")
Cc: [email protected]
Signed-off-by: Robert Konklewski <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|
| fb03b51d | 09-Jul-2020 |
Guinan Sun <[email protected]> |
net/ixgbe/base: fix x550em 10G NIC link status
With the NVM image for x550em XFI will not report
the auto-negotiation feature correctly. The auto-negotiation
should be "No" for supports and advertis
net/ixgbe/base: fix x550em 10G NIC link status
With the NVM image for x550em XFI will not report
the auto-negotiation feature correctly. The auto-negotiation
should be "No" for supports and advertised items.
At the same time update speed makes it support 1G and 10G.
Fixes: 833df43399e7 ("net/ixgbe/base: add SGMII link for X550")
Cc: [email protected]
Signed-off-by: Piotr Skajewski <[email protected]>
Signed-off-by: Guinan Sun <[email protected]>
Reviewed-by: Wei Zhao <[email protected]>
show more ...
|