| #
981a0257 |
| 11-May-2022 |
Stanislaw Kardach <[email protected]> |
test/ring: remove excessive inlining
Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the compiled code to grow extensively when compiled with no optimization (-O0 or -Og). This
test/ring: remove excessive inlining
Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the compiled code to grow extensively when compiled with no optimization (-O0 or -Og). This is default in the meson's debug configuration. This can collide with compiler bugs and cause issues during linking of unit tests where the api_type or esize are non-const variables causing inlining cascade. In perf tests this is not the case in perf-tests as esize and api_type are const values.
One such case was discovered when porting DPDK to RISC-V. GCC 11.2 (and no fix still in 12.1) is generating a short relative jump instruction (J <offset>) for goto and for loops. When loop body grows extensively in ring test, the target offset goes beyond supported offfset of +/- 1MB from PC. This is an obvious bug in the GCC as RISC-V has a two-instruction construct to jump to any absolute address (AUIPC+JALR).
However there is no reason to force inlining as the test code works perfectly fine without it.
GCC has a bug report for a similar case (with conditionals): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93062
Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
Signed-off-by: Stanislaw Kardach <[email protected]> Acked-by: Bruce Richardson <[email protected]> Reviewed-by: Honnappa Nagarahalli <[email protected]> Acked-by: Konstantin Ananyev <[email protected]>
show more ...
|
|
Revision tags: v22.03, v22.03-rc4, v22.03-rc3, v22.03-rc2, v22.03-rc1, v21.11, v21.11-rc4, v21.11-rc3, v21.11-rc2, v21.11-rc1, v21.08, v21.08-rc4, v21.08-rc3, v21.08-rc2, v21.08-rc1, v21.05, v21.05-rc4, v21.05-rc3, v21.05-rc2, v21.05-rc1, v21.02, v21.02-rc4, v21.02-rc3, v21.02-rc2, v21.02-rc1, v20.11, v20.11-rc5, v20.11-rc4, v20.11-rc3, v20.11-rc2 |
|
| #
83342a13 |
| 25-Oct-2020 |
Honnappa Nagarahalli <[email protected]> |
test/ring: add functional tests for zero copy API
Add functional tests for zero copy APIs. Test enqueue/dequeue functions are created using the zero copy APIs to fit into the existing testing method
test/ring: add functional tests for zero copy API
Add functional tests for zero copy APIs. Test enqueue/dequeue functions are created using the zero copy APIs to fit into the existing testing method.
Signed-off-by: Honnappa Nagarahalli <[email protected]> Reviewed-by: Dharmik Thakkar <[email protected]> Acked-by: Konstantin Ananyev <[email protected]>
show more ...
|
| #
31354c76 |
| 25-Oct-2020 |
Honnappa Nagarahalli <[email protected]> |
test/ring: remove unnecessary braces
Remove unnecessary braces to improve readability.
Signed-off-by: Honnappa Nagarahalli <[email protected]> Acked-by: Konstantin Ananyev <konstantin.an
test/ring: remove unnecessary braces
Remove unnecessary braces to improve readability.
Signed-off-by: Honnappa Nagarahalli <[email protected]> Acked-by: Konstantin Ananyev <[email protected]>
show more ...
|
|
Revision tags: v20.11-rc1 |
|
| #
6450023c |
| 20-Sep-2020 |
Feifei Wang <[email protected]> |
test/ring: fix object reference for single element enqueue
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a
test/ring: fix object reference for single element enqueue
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers.
Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: [email protected]
Signed-off-by: Feifei Wang <[email protected]> Reviewed-by: Ruifeng Wang <[email protected]> Reviewed-by: Phil Yang <[email protected]> Reviewed-by: Honnappa Nagarahalli <[email protected]> Acked-by: Konstantin Ananyev <[email protected]>
show more ...
|
|
Revision tags: v20.08, v20.08-rc4, v20.08-rc3, v20.08-rc2, v20.08-rc1, v20.05, v20.05-rc4, v20.05-rc3, v20.05-rc2, v20.05-rc1, v20.02, v20.02-rc4, v20.02-rc3, v20.02-rc2, v20.02-rc1 |
|
| #
a9fe1523 |
| 18-Jan-2020 |
Honnappa Nagarahalli <[email protected]> |
test/ring: add custom element size functional tests
Add basic infrastructure to test rte_ring_xxx_elem APIs. Adjust the existing test cases to test for various ring element sizes.
Signed-off-by: Ho
test/ring: add custom element size functional tests
Add basic infrastructure to test rte_ring_xxx_elem APIs. Adjust the existing test cases to test for various ring element sizes.
Signed-off-by: Honnappa Nagarahalli <[email protected]> Reviewed-by: Gavin Hu <[email protected]> Acked-by: Olivier Matz <[email protected]>
show more ...
|