remove unnecessary null checks

Functions like free, rte_free, and rte_mempool_free
already handle NULL pointer so the checks here are not necessary.

Remove redundant NULL pointer checks before free

remove unnecessary null checks

Functions like free, rte_free, and rte_mempool_free
already handle NULL pointer so the checks here are not necessary.

Remove redundant NULL pointer checks before free functions
found by nullfree.cocci

Signed-off-by: Stephen Hemminger <[email protected]>

show more ...

test: skip unsupported tests on Windows

Skip tests which are not yet supported for Windows:
- The libraries that tests depend on are not enabled on Windows yet
- The tests can compile but with issue

test: skip unsupported tests on Windows

Skip tests which are not yet supported for Windows:
- The libraries that tests depend on are not enabled on Windows yet
- The tests can compile but with issue still under investigation
* test_func_reentrancy:
Windows EAL has no protection against repeated calls.
* test_lcores:
Execution enters an infinite loops, requires investigation.
* test_rcu_qsbr_perf:
Execution hangs on Windows, requires investigation.

Signed-off-by: Jie Zhou <[email protected]>
Signed-off-by: Dmitry Kozlyuk <[email protected]>
Acked-by: Tyler Retzlaff <[email protected]>

show more ...

test/crypto: fix output buffer length

Input buffer length is getting appended with
padding length when the test case is encrypted
digest, but output buffer length is appended
with padding length for

test/crypto: fix output buffer length

Input buffer length is getting appended with
padding length when the test case is encrypted
digest, but output buffer length is appended
with padding length for all the cases.

This patch fixes the output buffer length
by appending the padding length only when the
test case is of encrypted digest type.

Fixes: 6356c28642a6 ("test/crypto: add cases for block cipher encrypted digest")
Cc: [email protected]

Signed-off-by: Gagandeep Singh <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: fix minsize build

Error occurs when configuring meson with --buildtype=minsize
with GCC 11.1.0:

app/test/test_cryptodev_blockcipher.c:1133:45: error:
‘blk_tcs’ may be used uninitialize

test/crypto: fix minsize build

Error occurs when configuring meson with --buildtype=minsize
with GCC 11.1.0:

app/test/test_cryptodev_blockcipher.c:1133:45: error:
‘blk_tcs’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
| const struct blockcipher_test_case *blk_tcs;
| ^~~~~~~

Signed-off-by: Thomas Monjalon <[email protected]>
Reviewed-by: Ruifeng Wang <[email protected]>

show more ...

test/crypto: remove illegal PMD header include

rte_cryptodev_pmd.h is an interface between
driver and library and it is mentioned in the
file that application cannot use it directly.
Hence, removing

test/crypto: remove illegal PMD header include

rte_cryptodev_pmd.h is an interface between
driver and library and it is mentioned in the
file that application cannot use it directly.
Hence, removing the include.

Signed-off-by: Akhil Goyal <[email protected]>
Acked-by: Matan Azrad <[email protected]>
Acked-by: Hemant Agrawal <[email protected]>

show more ...

test/crypto: add AES-XTS vectors

The AES-XTS algorithm supports using a wrapped key.
In AES-XTS the data-unit defines the data block size to be
encrypted\decrypted.

Add AES-XTS vectors with a wrapp

test/crypto: add AES-XTS vectors

The AES-XTS algorithm supports using a wrapped key.
In AES-XTS the data-unit defines the data block size to be
encrypted\decrypted.

Add AES-XTS vectors with a wrapped key.
Add a variable stating whether the key is wrapped or not.
Add the AES-XTS data-unit.

Signed-off-by: Shiri Kuzin <[email protected]>
Acked-by: Matan Azrad <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: build block-cipher suite dynamically

In the existing implementation, the blockcipher test cases are being run
and reported as one test case per type, even though multiple test cases
are

test/crypto: build block-cipher suite dynamically

In the existing implementation, the blockcipher test cases are being run
and reported as one test case per type, even though multiple test cases
are hidden in each. For example, "test_AES_chain_all" runs 46 test cases.
Each blockcipher type should have a testsuite instead.

The blockcipher testsuite is dynamically built, depending on the
blockcipher type chosen. The testcase struct is modified to allow
running a testcase with data, which is used for data required when
running each blockcipher testcase.

The blockcipher testsuites are added dynamically to parent testsuites
as sub-testsuites where needed.

Signed-off-by: Ciara Power <[email protected]>
Acked-by: Declan Doherty <[email protected]>
Acked-by: Hemant Agrawal <[email protected]>
Acked-by: Akhil Goyal <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>

show more ...

test/crypto: fix return value of a skipped test

The blockcipher testcase return value TEST_SUCCESS was incorrect for
one conditional check, it should have been TEST_SKIPPED similar to the
other cond

test/crypto: fix return value of a skipped test

The blockcipher testcase return value TEST_SUCCESS was incorrect for
one conditional check, it should have been TEST_SKIPPED similar to the
other condition checks in this function when the testcase is skipped.

Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
Cc: [email protected]

Signed-off-by: Ciara Power <[email protected]>
Acked-by: Akhil Goyal <[email protected]>
Acked-by: Declan Doherty <[email protected]>
Acked-by: Hemant Agrawal <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>

show more ...

test/crypto: add cases for block cipher encrypted digest

Add test cases for block cipher DIGEST_ENCRYPTED mode.

Signed-off-by: Tejasree Kondoj <[email protected]>
Acked-by: Akhil Goyal <gakhil@

test/crypto: add cases for block cipher encrypted digest

Add test cases for block cipher DIGEST_ENCRYPTED mode.

Signed-off-by: Tejasree Kondoj <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: fix typo in block cipher output

The print statement had a typo, "sesionless" should have been
"sessionless". This is now fixed.

Fixes: afcfa2fd0431 ("test/crypto: check session-less su

test/crypto: fix typo in block cipher output

The print statement had a typo, "sesionless" should have been
"sessionless". This is now fixed.

Fixes: afcfa2fd0431 ("test/crypto: check session-less support")
Cc: [email protected]

Signed-off-by: Ciara Power <[email protected]>

show more ...

test/crypto: add cases for raw datapath API

This patch adds the cryptodev raw API test support to unit test.
In addition a new test-case for QAT PMD for the test type is
enabled.

Signed-off-by: Fan

test/crypto: add cases for raw datapath API

This patch adds the cryptodev raw API test support to unit test.
In addition a new test-case for QAT PMD for the test type is
enabled.

Signed-off-by: Fan Zhang <[email protected]>
Acked-by: Adam Dybkowski <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: skip unsupported cases

blockcipher cases are either returning TEST_SUCCESS
or TEST_FAILED as status, but the test may not be
supported by the PMD which is also a success case
for the PM

test/crypto: skip unsupported cases

blockcipher cases are either returning TEST_SUCCESS
or TEST_FAILED as status, but the test may not be
supported by the PMD which is also a success case
for the PMD. Hence checking for status == TEST_FAILED
for setting the overall status as failed.

Signed-off-by: Akhil Goyal <[email protected]>
Reviewed-by: Bruce Richardson <[email protected]>
Acked-by: Ankur Dwivedi <[email protected]>

show more ...

test/crypto: handle unsupported error on session init

The session init routine rte_cryptodev_sym_session_init(),
could return -ENOTSUP when the requested algo combination
is not supported by the PMD

test/crypto: handle unsupported error on session init

The session init routine rte_cryptodev_sym_session_init(),
could return -ENOTSUP when the requested algo combination
is not supported by the PMD. This should be treated as
unsupported features. For other return values like -EINVAL
or -ENOMEM the test can be treated as failure.

Signed-off-by: Ankur Dwivedi <[email protected]>
Acked-by: Anoob Joseph <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: set null cipher IV length to zero

For null cipher the iv length should be set to zero.

Signed-off-by: Ankur Dwivedi <[email protected]>
Acked-by: Anoob Joseph <[email protected]>
A

test/crypto: set null cipher IV length to zero

For null cipher the iv length should be set to zero.

Signed-off-by: Ankur Dwivedi <[email protected]>
Acked-by: Anoob Joseph <[email protected]>
Acked-by: Fiona Trahe <[email protected]>

show more ...

test/crypto: do not check for PMD

Remove PMD bitmask, which selects the PMD to be tested
for each test case. Instead, all PMDs are eligible
to run all tests, and capability checking discards
the PMD

test/crypto: do not check for PMD

Remove PMD bitmask, which selects the PMD to be tested
for each test case. Instead, all PMDs are eligible
to run all tests, and capability checking discards
the PMDs which do not support each test case.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam Dybkowski <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>
Acked-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: check out-of-place support

Before running any out-of-place test cases,
check if device supports this mode.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam

test/crypto: check out-of-place support

Before running any out-of-place test cases,
check if device supports this mode.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam Dybkowski <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>
Acked-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: check session-less support

Before running any sessionless test cases,
check if device supports this mode.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam D

test/crypto: check session-less support

Before running any sessionless test cases,
check if device supports this mode.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam Dybkowski <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>
Acked-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: add capability check

Check if test case is supported by the crypto device,
including algorithm and some of its parameter, such as key length,
IV length, etc, using the capabilities API.

test/crypto: add capability check

Check if test case is supported by the crypto device,
including algorithm and some of its parameter, such as key length,
IV length, etc, using the capabilities API.
If it is not supported, test case is skipped.

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Adam Dybkowski <[email protected]>
Tested-by: Ruifeng Wang <[email protected]>
Acked-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: fix flag check

An incorrect flag check was done, using "&&" instead of "&".

Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")
Cc: [email protected]

Signed-off-by: Pabl

test/crypto: fix flag check

An incorrect flag check was done, using "&&" instead of "&".

Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")
Cc: [email protected]

Signed-off-by: Pablo de Lara <[email protected]>
Acked-by: Fiona Trahe <[email protected]>

show more ...

test/crypto: refactor unit tests into one combined array

This patch refactors most of unit tests to be contained in one
combined array, and run depending on the PMD capabilities instead of
providing

test/crypto: refactor unit tests into one combined array

This patch refactors most of unit tests to be contained in one
combined array, and run depending on the PMD capabilities instead of
providing multiple array with tests for individual PMDs.
Only a subset of unit tests was merged into one array - it combines
all tests originally meant to be run on these PMDs:
null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc.

Signed-off-by: Adam Dybkowski <[email protected]>
Acked-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>
Tested-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: add OCTEON TX2

This patch adds the OCTEON TX2 crypto validation tests.

Signed-off-by: Ankur Dwivedi <[email protected]>
Signed-off-by: Anoob Joseph <[email protected]>
Signed-off-b

test/crypto: add OCTEON TX2

This patch adds the OCTEON TX2 crypto validation tests.

Signed-off-by: Ankur Dwivedi <[email protected]>
Signed-off-by: Anoob Joseph <[email protected]>
Signed-off-by: Tejasree Kondoj <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: add cases for Nitrox

Add aes chain test cases for Nitrox in-pace and
out-of-place operations.

Signed-off-by: Nagadheeraj Rottela <[email protected]>
Acked-by: Akhil Goyal <akhil

test/crypto: add cases for Nitrox

Add aes chain test cases for Nitrox in-pace and
out-of-place operations.

Signed-off-by: Nagadheeraj Rottela <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: add NULL algo to loop test mechanism

Added NULL algo tests into loop test mechanism used
by block cipher tests as easier to extend there.
Included chain, cipher-only and auth-only use-c

test/crypto: add NULL algo to loop test mechanism

Added NULL algo tests into loop test mechanism used
by block cipher tests as easier to extend there.
Included chain, cipher-only and auth-only use-cases.
Extended to cover out-of-place use-cases and use-cases
where data length is not an 8-byte multiple.

Signed-off-by: Fiona Trahe <[email protected]>
Acked-by: Akhil Goyal <[email protected]>

show more ...

test/crypto: check out of place for AESNI-MB

This patch updates the unit test to enable AESNI-MB PMD
out-of-place tests. A special test type that swap both
the source and destination buffer is added

test/crypto: check out of place for AESNI-MB

This patch updates the unit test to enable AESNI-MB PMD
out-of-place tests. A special test type that swap both
the source and destination buffer is added for a more
comprehensive test set to take place.

Signed-off-by: Fan Zhang <[email protected]>
Acked-by: Fiona Trahe <[email protected]>

show more ...

test: move to app directory

Since all other apps have been moved to the "app" folder, the autotest app
remains alone in the test folder. Rather than having an entire top-level
folder for this, we ca

test: move to app directory

Since all other apps have been moved to the "app" folder, the autotest app
remains alone in the test folder. Rather than having an entire top-level
folder for this, we can move it back to where it all started in early
versions of DPDK - the "app/" folder.

This move has a couple of advantages:
* This reduces clutter at the top level of the project, due to one less
folder.
* It eliminates the separate build task necessary for building the
autotests using make "make test-build" which means that developers are
less likely to miss something in their own compilation tests
* It re-aligns the final location of the test binary in the app folder when
building with make with it's location in the source tree.

For meson builds, the autotest app is different from the other apps in that
it needs a series of different test cases defined for it for use by "meson
test". Therefore, it does not get built as part of the main loop in the
app folder, but gets built separately at the end.

Signed-off-by: Bruce Richardson <[email protected]>

show more ...