xref: /sqlite-3.40.0/src/resolve.c (revision 60ce5d31)
1 /*
2 ** 2008 August 18
3 **
4 ** The author disclaims copyright to this source code.  In place of
5 ** a legal notice, here is a blessing:
6 **
7 **    May you do good and not evil.
8 **    May you find forgiveness for yourself and forgive others.
9 **    May you share freely, never taking more than you give.
10 **
11 *************************************************************************
12 **
13 ** This file contains routines used for walking the parser tree and
14 ** resolve all identifiers by associating them with a particular
15 ** table and column.
16 */
17 #include "sqliteInt.h"
18 
19 /*
20 ** Walk the expression tree pExpr and increase the aggregate function
21 ** depth (the Expr.op2 field) by N on every TK_AGG_FUNCTION node.
22 ** This needs to occur when copying a TK_AGG_FUNCTION node from an
23 ** outer query into an inner subquery.
24 **
25 ** incrAggFunctionDepth(pExpr,n) is the main routine.  incrAggDepth(..)
26 ** is a helper function - a callback for the tree walker.
27 */
28 static int incrAggDepth(Walker *pWalker, Expr *pExpr){
29   if( pExpr->op==TK_AGG_FUNCTION ) pExpr->op2 += pWalker->u.n;
30   return WRC_Continue;
31 }
32 static void incrAggFunctionDepth(Expr *pExpr, int N){
33   if( N>0 ){
34     Walker w;
35     memset(&w, 0, sizeof(w));
36     w.xExprCallback = incrAggDepth;
37     w.u.n = N;
38     sqlite3WalkExpr(&w, pExpr);
39   }
40 }
41 
42 /*
43 ** Turn the pExpr expression into an alias for the iCol-th column of the
44 ** result set in pEList.
45 **
46 ** If the reference is followed by a COLLATE operator, then make sure
47 ** the COLLATE operator is preserved.  For example:
48 **
49 **     SELECT a+b, c+d FROM t1 ORDER BY 1 COLLATE nocase;
50 **
51 ** Should be transformed into:
52 **
53 **     SELECT a+b, c+d FROM t1 ORDER BY (a+b) COLLATE nocase;
54 **
55 ** The nSubquery parameter specifies how many levels of subquery the
56 ** alias is removed from the original expression.  The usual value is
57 ** zero but it might be more if the alias is contained within a subquery
58 ** of the original expression.  The Expr.op2 field of TK_AGG_FUNCTION
59 ** structures must be increased by the nSubquery amount.
60 */
61 static void resolveAlias(
62   Parse *pParse,         /* Parsing context */
63   ExprList *pEList,      /* A result set */
64   int iCol,              /* A column in the result set.  0..pEList->nExpr-1 */
65   Expr *pExpr,           /* Transform this into an alias to the result set */
66   const char *zType,     /* "GROUP" or "ORDER" or "" */
67   int nSubquery          /* Number of subqueries that the label is moving */
68 ){
69   Expr *pOrig;           /* The iCol-th column of the result set */
70   Expr *pDup;            /* Copy of pOrig */
71   sqlite3 *db;           /* The database connection */
72 
73   assert( iCol>=0 && iCol<pEList->nExpr );
74   pOrig = pEList->a[iCol].pExpr;
75   assert( pOrig!=0 );
76   db = pParse->db;
77   pDup = sqlite3ExprDup(db, pOrig, 0);
78   if( pDup!=0 ){
79     if( zType[0]!='G' ) incrAggFunctionDepth(pDup, nSubquery);
80     if( pExpr->op==TK_COLLATE ){
81       pDup = sqlite3ExprAddCollateString(pParse, pDup, pExpr->u.zToken);
82     }
83     ExprSetProperty(pDup, EP_Alias);
84 
85     /* Before calling sqlite3ExprDelete(), set the EP_Static flag. This
86     ** prevents ExprDelete() from deleting the Expr structure itself,
87     ** allowing it to be repopulated by the memcpy() on the following line.
88     ** The pExpr->u.zToken might point into memory that will be freed by the
89     ** sqlite3DbFree(db, pDup) on the last line of this block, so be sure to
90     ** make a copy of the token before doing the sqlite3DbFree().
91     */
92     ExprSetProperty(pExpr, EP_Static);
93     sqlite3ExprDelete(db, pExpr);
94     memcpy(pExpr, pDup, sizeof(*pExpr));
95     if( !ExprHasProperty(pExpr, EP_IntValue) && pExpr->u.zToken!=0 ){
96       assert( (pExpr->flags & (EP_Reduced|EP_TokenOnly))==0 );
97       pExpr->u.zToken = sqlite3DbStrDup(db, pExpr->u.zToken);
98       pExpr->flags |= EP_MemToken;
99     }
100     sqlite3DbFree(db, pDup);
101   }
102   ExprSetProperty(pExpr, EP_Alias);
103 }
104 
105 
106 /*
107 ** Return TRUE if the name zCol occurs anywhere in the USING clause.
108 **
109 ** Return FALSE if the USING clause is NULL or if it does not contain
110 ** zCol.
111 */
112 static int nameInUsingClause(IdList *pUsing, const char *zCol){
113   if( pUsing ){
114     int k;
115     for(k=0; k<pUsing->nId; k++){
116       if( sqlite3StrICmp(pUsing->a[k].zName, zCol)==0 ) return 1;
117     }
118   }
119   return 0;
120 }
121 
122 /*
123 ** Subqueries stores the original database, table and column names for their
124 ** result sets in ExprList.a[].zSpan, in the form "DATABASE.TABLE.COLUMN".
125 ** Check to see if the zSpan given to this routine matches the zDb, zTab,
126 ** and zCol.  If any of zDb, zTab, and zCol are NULL then those fields will
127 ** match anything.
128 */
129 int sqlite3MatchSpanName(
130   const char *zSpan,
131   const char *zCol,
132   const char *zTab,
133   const char *zDb
134 ){
135   int n;
136   for(n=0; ALWAYS(zSpan[n]) && zSpan[n]!='.'; n++){}
137   if( zDb && (sqlite3StrNICmp(zSpan, zDb, n)!=0 || zDb[n]!=0) ){
138     return 0;
139   }
140   zSpan += n+1;
141   for(n=0; ALWAYS(zSpan[n]) && zSpan[n]!='.'; n++){}
142   if( zTab && (sqlite3StrNICmp(zSpan, zTab, n)!=0 || zTab[n]!=0) ){
143     return 0;
144   }
145   zSpan += n+1;
146   if( zCol && sqlite3StrICmp(zSpan, zCol)!=0 ){
147     return 0;
148   }
149   return 1;
150 }
151 
152 /*
153 ** Given the name of a column of the form X.Y.Z or Y.Z or just Z, look up
154 ** that name in the set of source tables in pSrcList and make the pExpr
155 ** expression node refer back to that source column.  The following changes
156 ** are made to pExpr:
157 **
158 **    pExpr->iDb           Set the index in db->aDb[] of the database X
159 **                         (even if X is implied).
160 **    pExpr->iTable        Set to the cursor number for the table obtained
161 **                         from pSrcList.
162 **    pExpr->y.pTab        Points to the Table structure of X.Y (even if
163 **                         X and/or Y are implied.)
164 **    pExpr->iColumn       Set to the column number within the table.
165 **    pExpr->op            Set to TK_COLUMN.
166 **    pExpr->pLeft         Any expression this points to is deleted
167 **    pExpr->pRight        Any expression this points to is deleted.
168 **
169 ** The zDb variable is the name of the database (the "X").  This value may be
170 ** NULL meaning that name is of the form Y.Z or Z.  Any available database
171 ** can be used.  The zTable variable is the name of the table (the "Y").  This
172 ** value can be NULL if zDb is also NULL.  If zTable is NULL it
173 ** means that the form of the name is Z and that columns from any table
174 ** can be used.
175 **
176 ** If the name cannot be resolved unambiguously, leave an error message
177 ** in pParse and return WRC_Abort.  Return WRC_Prune on success.
178 */
179 static int lookupName(
180   Parse *pParse,       /* The parsing context */
181   const char *zDb,     /* Name of the database containing table, or NULL */
182   const char *zTab,    /* Name of table containing column, or NULL */
183   const char *zCol,    /* Name of the column. */
184   NameContext *pNC,    /* The name context used to resolve the name */
185   Expr *pExpr          /* Make this EXPR node point to the selected column */
186 ){
187   int i, j;                         /* Loop counters */
188   int cnt = 0;                      /* Number of matching column names */
189   int cntTab = 0;                   /* Number of matching table names */
190   int nSubquery = 0;                /* How many levels of subquery */
191   sqlite3 *db = pParse->db;         /* The database connection */
192   struct SrcList_item *pItem;       /* Use for looping over pSrcList items */
193   struct SrcList_item *pMatch = 0;  /* The matching pSrcList item */
194   NameContext *pTopNC = pNC;        /* First namecontext in the list */
195   Schema *pSchema = 0;              /* Schema of the expression */
196   int eNewExprOp = TK_COLUMN;       /* New value for pExpr->op on success */
197   Table *pTab = 0;                  /* Table hold the row */
198   Column *pCol;                     /* A column of pTab */
199 
200   assert( pNC );     /* the name context cannot be NULL. */
201   assert( zCol );    /* The Z in X.Y.Z cannot be NULL */
202   assert( !ExprHasProperty(pExpr, EP_TokenOnly|EP_Reduced) );
203 
204   /* Initialize the node to no-match */
205   pExpr->iTable = -1;
206   ExprSetVVAProperty(pExpr, EP_NoReduce);
207 
208   /* Translate the schema name in zDb into a pointer to the corresponding
209   ** schema.  If not found, pSchema will remain NULL and nothing will match
210   ** resulting in an appropriate error message toward the end of this routine
211   */
212   if( zDb ){
213     testcase( pNC->ncFlags & NC_PartIdx );
214     testcase( pNC->ncFlags & NC_IsCheck );
215     if( (pNC->ncFlags & (NC_PartIdx|NC_IsCheck))!=0 ){
216       /* Silently ignore database qualifiers inside CHECK constraints and
217       ** partial indices.  Do not raise errors because that might break
218       ** legacy and because it does not hurt anything to just ignore the
219       ** database name. */
220       zDb = 0;
221     }else{
222       for(i=0; i<db->nDb; i++){
223         assert( db->aDb[i].zDbSName );
224         if( sqlite3StrICmp(db->aDb[i].zDbSName,zDb)==0 ){
225           pSchema = db->aDb[i].pSchema;
226           break;
227         }
228       }
229     }
230   }
231 
232   /* Start at the inner-most context and move outward until a match is found */
233   assert( pNC && cnt==0 );
234   do{
235     ExprList *pEList;
236     SrcList *pSrcList = pNC->pSrcList;
237 
238     if( pSrcList ){
239       for(i=0, pItem=pSrcList->a; i<pSrcList->nSrc; i++, pItem++){
240         pTab = pItem->pTab;
241         assert( pTab!=0 && pTab->zName!=0 );
242         assert( pTab->nCol>0 );
243         if( pItem->pSelect && (pItem->pSelect->selFlags & SF_NestedFrom)!=0 ){
244           int hit = 0;
245           pEList = pItem->pSelect->pEList;
246           for(j=0; j<pEList->nExpr; j++){
247             if( sqlite3MatchSpanName(pEList->a[j].zSpan, zCol, zTab, zDb) ){
248               cnt++;
249               cntTab = 2;
250               pMatch = pItem;
251               pExpr->iColumn = j;
252               hit = 1;
253             }
254           }
255           if( hit || zTab==0 ) continue;
256         }
257         if( zDb && pTab->pSchema!=pSchema ){
258           continue;
259         }
260         if( zTab ){
261           const char *zTabName = pItem->zAlias ? pItem->zAlias : pTab->zName;
262           assert( zTabName!=0 );
263           if( sqlite3StrICmp(zTabName, zTab)!=0 ){
264             continue;
265           }
266           if( IN_RENAME_OBJECT && pItem->zAlias ){
267             sqlite3RenameTokenRemap(pParse, 0, (void*)&pExpr->y.pTab);
268           }
269         }
270         if( 0==(cntTab++) ){
271           pMatch = pItem;
272         }
273         for(j=0, pCol=pTab->aCol; j<pTab->nCol; j++, pCol++){
274           if( sqlite3StrICmp(pCol->zName, zCol)==0 ){
275             /* If there has been exactly one prior match and this match
276             ** is for the right-hand table of a NATURAL JOIN or is in a
277             ** USING clause, then skip this match.
278             */
279             if( cnt==1 ){
280               if( pItem->fg.jointype & JT_NATURAL ) continue;
281               if( nameInUsingClause(pItem->pUsing, zCol) ) continue;
282             }
283             cnt++;
284             pMatch = pItem;
285             /* Substitute the rowid (column -1) for the INTEGER PRIMARY KEY */
286             pExpr->iColumn = j==pTab->iPKey ? -1 : (i16)j;
287             break;
288           }
289         }
290       }
291       if( pMatch ){
292         pExpr->iTable = pMatch->iCursor;
293         pExpr->y.pTab = pMatch->pTab;
294         /* RIGHT JOIN not (yet) supported */
295         assert( (pMatch->fg.jointype & JT_RIGHT)==0 );
296         if( (pMatch->fg.jointype & JT_LEFT)!=0 ){
297           ExprSetProperty(pExpr, EP_CanBeNull);
298         }
299         pSchema = pExpr->y.pTab->pSchema;
300       }
301     } /* if( pSrcList ) */
302 
303 #if !defined(SQLITE_OMIT_TRIGGER) || !defined(SQLITE_OMIT_UPSERT)
304     /* If we have not already resolved the name, then maybe
305     ** it is a new.* or old.* trigger argument reference.  Or
306     ** maybe it is an excluded.* from an upsert.
307     */
308     if( zDb==0 && zTab!=0 && cntTab==0 ){
309       pTab = 0;
310 #ifndef SQLITE_OMIT_TRIGGER
311       if( pParse->pTriggerTab!=0 ){
312         int op = pParse->eTriggerOp;
313         assert( op==TK_DELETE || op==TK_UPDATE || op==TK_INSERT );
314         if( op!=TK_DELETE && sqlite3StrICmp("new",zTab) == 0 ){
315           pExpr->iTable = 1;
316           pTab = pParse->pTriggerTab;
317         }else if( op!=TK_INSERT && sqlite3StrICmp("old",zTab)==0 ){
318           pExpr->iTable = 0;
319           pTab = pParse->pTriggerTab;
320         }
321       }
322 #endif /* SQLITE_OMIT_TRIGGER */
323 #ifndef SQLITE_OMIT_UPSERT
324       if( (pNC->ncFlags & NC_UUpsert)!=0 ){
325         Upsert *pUpsert = pNC->uNC.pUpsert;
326         if( pUpsert && sqlite3StrICmp("excluded",zTab)==0 ){
327           pTab = pUpsert->pUpsertSrc->a[0].pTab;
328           pExpr->iTable = 2;
329         }
330       }
331 #endif /* SQLITE_OMIT_UPSERT */
332 
333       if( pTab ){
334         int iCol;
335         pSchema = pTab->pSchema;
336         cntTab++;
337         for(iCol=0, pCol=pTab->aCol; iCol<pTab->nCol; iCol++, pCol++){
338           if( sqlite3StrICmp(pCol->zName, zCol)==0 ){
339             if( iCol==pTab->iPKey ){
340               iCol = -1;
341             }
342             break;
343           }
344         }
345         if( iCol>=pTab->nCol && sqlite3IsRowid(zCol) && VisibleRowid(pTab) ){
346           /* IMP: R-51414-32910 */
347           iCol = -1;
348         }
349         if( iCol<pTab->nCol ){
350           cnt++;
351 #ifndef SQLITE_OMIT_UPSERT
352           if( pExpr->iTable==2 ){
353             testcase( iCol==(-1) );
354             if( IN_RENAME_OBJECT ){
355               pExpr->iColumn = iCol;
356               pExpr->y.pTab = pTab;
357               eNewExprOp = TK_COLUMN;
358             }else{
359               pExpr->iTable = pNC->uNC.pUpsert->regData + iCol;
360               eNewExprOp = TK_REGISTER;
361               ExprSetProperty(pExpr, EP_Alias);
362             }
363           }else
364 #endif /* SQLITE_OMIT_UPSERT */
365           {
366 #ifndef SQLITE_OMIT_TRIGGER
367             if( iCol<0 ){
368               pExpr->affinity = SQLITE_AFF_INTEGER;
369             }else if( pExpr->iTable==0 ){
370               testcase( iCol==31 );
371               testcase( iCol==32 );
372               pParse->oldmask |= (iCol>=32 ? 0xffffffff : (((u32)1)<<iCol));
373             }else{
374               testcase( iCol==31 );
375               testcase( iCol==32 );
376               pParse->newmask |= (iCol>=32 ? 0xffffffff : (((u32)1)<<iCol));
377             }
378             pExpr->y.pTab = pTab;
379             pExpr->iColumn = (i16)iCol;
380             eNewExprOp = TK_TRIGGER;
381 #endif /* SQLITE_OMIT_TRIGGER */
382           }
383         }
384       }
385     }
386 #endif /* !defined(SQLITE_OMIT_TRIGGER) || !defined(SQLITE_OMIT_UPSERT) */
387 
388     /*
389     ** Perhaps the name is a reference to the ROWID
390     */
391     if( cnt==0
392      && cntTab==1
393      && pMatch
394      && (pNC->ncFlags & NC_IdxExpr)==0
395      && sqlite3IsRowid(zCol)
396      && VisibleRowid(pMatch->pTab)
397     ){
398       cnt = 1;
399       pExpr->iColumn = -1;
400       pExpr->affinity = SQLITE_AFF_INTEGER;
401     }
402 
403     /*
404     ** If the input is of the form Z (not Y.Z or X.Y.Z) then the name Z
405     ** might refer to an result-set alias.  This happens, for example, when
406     ** we are resolving names in the WHERE clause of the following command:
407     **
408     **     SELECT a+b AS x FROM table WHERE x<10;
409     **
410     ** In cases like this, replace pExpr with a copy of the expression that
411     ** forms the result set entry ("a+b" in the example) and return immediately.
412     ** Note that the expression in the result set should have already been
413     ** resolved by the time the WHERE clause is resolved.
414     **
415     ** The ability to use an output result-set column in the WHERE, GROUP BY,
416     ** or HAVING clauses, or as part of a larger expression in the ORDER BY
417     ** clause is not standard SQL.  This is a (goofy) SQLite extension, that
418     ** is supported for backwards compatibility only. Hence, we issue a warning
419     ** on sqlite3_log() whenever the capability is used.
420     */
421     if( (pNC->ncFlags & NC_UEList)!=0
422      && cnt==0
423      && zTab==0
424     ){
425       pEList = pNC->uNC.pEList;
426       assert( pEList!=0 );
427       for(j=0; j<pEList->nExpr; j++){
428         char *zAs = pEList->a[j].zName;
429         if( zAs!=0 && sqlite3StrICmp(zAs, zCol)==0 ){
430           Expr *pOrig;
431           assert( pExpr->pLeft==0 && pExpr->pRight==0 );
432           assert( pExpr->x.pList==0 );
433           assert( pExpr->x.pSelect==0 );
434           pOrig = pEList->a[j].pExpr;
435           if( (pNC->ncFlags&NC_AllowAgg)==0 && ExprHasProperty(pOrig, EP_Agg) ){
436             sqlite3ErrorMsg(pParse, "misuse of aliased aggregate %s", zAs);
437             return WRC_Abort;
438           }
439           if( sqlite3ExprVectorSize(pOrig)!=1 ){
440             sqlite3ErrorMsg(pParse, "row value misused");
441             return WRC_Abort;
442           }
443           resolveAlias(pParse, pEList, j, pExpr, "", nSubquery);
444           cnt = 1;
445           pMatch = 0;
446           assert( zTab==0 && zDb==0 );
447           if( IN_RENAME_OBJECT ){
448             sqlite3RenameTokenRemap(pParse, 0, (void*)pExpr);
449           }
450           goto lookupname_end;
451         }
452       }
453     }
454 
455     /* Advance to the next name context.  The loop will exit when either
456     ** we have a match (cnt>0) or when we run out of name contexts.
457     */
458     if( cnt ) break;
459     pNC = pNC->pNext;
460     nSubquery++;
461   }while( pNC );
462 
463 
464   /*
465   ** If X and Y are NULL (in other words if only the column name Z is
466   ** supplied) and the value of Z is enclosed in double-quotes, then
467   ** Z is a string literal if it doesn't match any column names.  In that
468   ** case, we need to return right away and not make any changes to
469   ** pExpr.
470   **
471   ** Because no reference was made to outer contexts, the pNC->nRef
472   ** fields are not changed in any context.
473   */
474   if( cnt==0 && zTab==0 ){
475     assert( pExpr->op==TK_ID );
476     if( ExprHasProperty(pExpr,EP_DblQuoted) ){
477       pExpr->op = TK_STRING;
478       pExpr->y.pTab = 0;
479       return WRC_Prune;
480     }
481     if( sqlite3ExprIdToTrueFalse(pExpr) ){
482       return WRC_Prune;
483     }
484   }
485 
486   /*
487   ** cnt==0 means there was not match.  cnt>1 means there were two or
488   ** more matches.  Either way, we have an error.
489   */
490   if( cnt!=1 ){
491     const char *zErr;
492     zErr = cnt==0 ? "no such column" : "ambiguous column name";
493     if( zDb ){
494       sqlite3ErrorMsg(pParse, "%s: %s.%s.%s", zErr, zDb, zTab, zCol);
495     }else if( zTab ){
496       sqlite3ErrorMsg(pParse, "%s: %s.%s", zErr, zTab, zCol);
497     }else{
498       sqlite3ErrorMsg(pParse, "%s: %s", zErr, zCol);
499     }
500     pParse->checkSchema = 1;
501     pTopNC->nErr++;
502   }
503 
504   /* If a column from a table in pSrcList is referenced, then record
505   ** this fact in the pSrcList.a[].colUsed bitmask.  Column 0 causes
506   ** bit 0 to be set.  Column 1 sets bit 1.  And so forth.  If the
507   ** column number is greater than the number of bits in the bitmask
508   ** then set the high-order bit of the bitmask.
509   */
510   if( pExpr->iColumn>=0 && pMatch!=0 ){
511     int n = pExpr->iColumn;
512     testcase( n==BMS-1 );
513     if( n>=BMS ){
514       n = BMS-1;
515     }
516     assert( pMatch->iCursor==pExpr->iTable );
517     pMatch->colUsed |= ((Bitmask)1)<<n;
518   }
519 
520   /* Clean up and return
521   */
522   sqlite3ExprDelete(db, pExpr->pLeft);
523   pExpr->pLeft = 0;
524   sqlite3ExprDelete(db, pExpr->pRight);
525   pExpr->pRight = 0;
526   pExpr->op = eNewExprOp;
527   ExprSetProperty(pExpr, EP_Leaf);
528 lookupname_end:
529   if( cnt==1 ){
530     assert( pNC!=0 );
531     if( !ExprHasProperty(pExpr, EP_Alias) ){
532       sqlite3AuthRead(pParse, pExpr, pSchema, pNC->pSrcList);
533     }
534     /* Increment the nRef value on all name contexts from TopNC up to
535     ** the point where the name matched. */
536     for(;;){
537       assert( pTopNC!=0 );
538       pTopNC->nRef++;
539       if( pTopNC==pNC ) break;
540       pTopNC = pTopNC->pNext;
541     }
542     return WRC_Prune;
543   } else {
544     return WRC_Abort;
545   }
546 }
547 
548 /*
549 ** Allocate and return a pointer to an expression to load the column iCol
550 ** from datasource iSrc in SrcList pSrc.
551 */
552 Expr *sqlite3CreateColumnExpr(sqlite3 *db, SrcList *pSrc, int iSrc, int iCol){
553   Expr *p = sqlite3ExprAlloc(db, TK_COLUMN, 0, 0);
554   if( p ){
555     struct SrcList_item *pItem = &pSrc->a[iSrc];
556     p->y.pTab = pItem->pTab;
557     p->iTable = pItem->iCursor;
558     if( p->y.pTab->iPKey==iCol ){
559       p->iColumn = -1;
560     }else{
561       p->iColumn = (ynVar)iCol;
562       testcase( iCol==BMS );
563       testcase( iCol==BMS-1 );
564       pItem->colUsed |= ((Bitmask)1)<<(iCol>=BMS ? BMS-1 : iCol);
565     }
566   }
567   return p;
568 }
569 
570 /*
571 ** Report an error that an expression is not valid for some set of
572 ** pNC->ncFlags values determined by validMask.
573 */
574 static void notValid(
575   Parse *pParse,       /* Leave error message here */
576   NameContext *pNC,    /* The name context */
577   const char *zMsg,    /* Type of error */
578   int validMask        /* Set of contexts for which prohibited */
579 ){
580   assert( (validMask&~(NC_IsCheck|NC_PartIdx|NC_IdxExpr))==0 );
581   if( (pNC->ncFlags & validMask)!=0 ){
582     const char *zIn = "partial index WHERE clauses";
583     if( pNC->ncFlags & NC_IdxExpr )      zIn = "index expressions";
584 #ifndef SQLITE_OMIT_CHECK
585     else if( pNC->ncFlags & NC_IsCheck ) zIn = "CHECK constraints";
586 #endif
587     sqlite3ErrorMsg(pParse, "%s prohibited in %s", zMsg, zIn);
588   }
589 }
590 
591 /*
592 ** Expression p should encode a floating point value between 1.0 and 0.0.
593 ** Return 1024 times this value.  Or return -1 if p is not a floating point
594 ** value between 1.0 and 0.0.
595 */
596 static int exprProbability(Expr *p){
597   double r = -1.0;
598   if( p->op!=TK_FLOAT ) return -1;
599   sqlite3AtoF(p->u.zToken, &r, sqlite3Strlen30(p->u.zToken), SQLITE_UTF8);
600   assert( r>=0.0 );
601   if( r>1.0 ) return -1;
602   return (int)(r*134217728.0);
603 }
604 
605 /*
606 ** This routine is callback for sqlite3WalkExpr().
607 **
608 ** Resolve symbolic names into TK_COLUMN operators for the current
609 ** node in the expression tree.  Return 0 to continue the search down
610 ** the tree or 2 to abort the tree walk.
611 **
612 ** This routine also does error checking and name resolution for
613 ** function names.  The operator for aggregate functions is changed
614 ** to TK_AGG_FUNCTION.
615 */
616 static int resolveExprStep(Walker *pWalker, Expr *pExpr){
617   NameContext *pNC;
618   Parse *pParse;
619 
620   pNC = pWalker->u.pNC;
621   assert( pNC!=0 );
622   pParse = pNC->pParse;
623   assert( pParse==pWalker->pParse );
624 
625 #ifndef NDEBUG
626   if( pNC->pSrcList && pNC->pSrcList->nAlloc>0 ){
627     SrcList *pSrcList = pNC->pSrcList;
628     int i;
629     for(i=0; i<pNC->pSrcList->nSrc; i++){
630       assert( pSrcList->a[i].iCursor>=0 && pSrcList->a[i].iCursor<pParse->nTab);
631     }
632   }
633 #endif
634   switch( pExpr->op ){
635 
636 #if defined(SQLITE_ENABLE_UPDATE_DELETE_LIMIT) && !defined(SQLITE_OMIT_SUBQUERY)
637     /* The special operator TK_ROW means use the rowid for the first
638     ** column in the FROM clause.  This is used by the LIMIT and ORDER BY
639     ** clause processing on UPDATE and DELETE statements.
640     */
641     case TK_ROW: {
642       SrcList *pSrcList = pNC->pSrcList;
643       struct SrcList_item *pItem;
644       assert( pSrcList && pSrcList->nSrc==1 );
645       pItem = pSrcList->a;
646       assert( HasRowid(pItem->pTab) && pItem->pTab->pSelect==0 );
647       pExpr->op = TK_COLUMN;
648       pExpr->y.pTab = pItem->pTab;
649       pExpr->iTable = pItem->iCursor;
650       pExpr->iColumn = -1;
651       pExpr->affinity = SQLITE_AFF_INTEGER;
652       break;
653     }
654 #endif /* defined(SQLITE_ENABLE_UPDATE_DELETE_LIMIT)
655           && !defined(SQLITE_OMIT_SUBQUERY) */
656 
657     /* A column name:                    ID
658     ** Or table name and column name:    ID.ID
659     ** Or a database, table and column:  ID.ID.ID
660     **
661     ** The TK_ID and TK_OUT cases are combined so that there will only
662     ** be one call to lookupName().  Then the compiler will in-line
663     ** lookupName() for a size reduction and performance increase.
664     */
665     case TK_ID:
666     case TK_DOT: {
667       const char *zColumn;
668       const char *zTable;
669       const char *zDb;
670       Expr *pRight;
671 
672       if( pExpr->op==TK_ID ){
673         zDb = 0;
674         zTable = 0;
675         zColumn = pExpr->u.zToken;
676       }else{
677         Expr *pLeft = pExpr->pLeft;
678         notValid(pParse, pNC, "the \".\" operator", NC_IdxExpr);
679         pRight = pExpr->pRight;
680         if( pRight->op==TK_ID ){
681           zDb = 0;
682         }else{
683           assert( pRight->op==TK_DOT );
684           zDb = pLeft->u.zToken;
685           pLeft = pRight->pLeft;
686           pRight = pRight->pRight;
687         }
688         zTable = pLeft->u.zToken;
689         zColumn = pRight->u.zToken;
690         if( IN_RENAME_OBJECT ){
691           sqlite3RenameTokenRemap(pParse, (void*)pExpr, (void*)pRight);
692           sqlite3RenameTokenRemap(pParse, (void*)&pExpr->y.pTab, (void*)pLeft);
693         }
694       }
695       return lookupName(pParse, zDb, zTable, zColumn, pNC, pExpr);
696     }
697 
698     /* Resolve function names
699     */
700     case TK_FUNCTION: {
701       ExprList *pList = pExpr->x.pList;    /* The argument list */
702       int n = pList ? pList->nExpr : 0;    /* Number of arguments */
703       int no_such_func = 0;       /* True if no such function exists */
704       int wrong_num_args = 0;     /* True if wrong number of arguments */
705       int is_agg = 0;             /* True if is an aggregate function */
706       int nId;                    /* Number of characters in function name */
707       const char *zId;            /* The function name. */
708       FuncDef *pDef;              /* Information about the function */
709       u8 enc = ENC(pParse->db);   /* The database encoding */
710 
711       assert( !ExprHasProperty(pExpr, EP_xIsSelect) );
712       zId = pExpr->u.zToken;
713       nId = sqlite3Strlen30(zId);
714       pDef = sqlite3FindFunction(pParse->db, zId, n, enc, 0);
715       if( pDef==0 ){
716         pDef = sqlite3FindFunction(pParse->db, zId, -2, enc, 0);
717         if( pDef==0 ){
718           no_such_func = 1;
719         }else{
720           wrong_num_args = 1;
721         }
722       }else{
723         is_agg = pDef->xFinalize!=0;
724         if( pDef->funcFlags & SQLITE_FUNC_UNLIKELY ){
725           ExprSetProperty(pExpr, EP_Unlikely|EP_Skip);
726           if( n==2 ){
727             pExpr->iTable = exprProbability(pList->a[1].pExpr);
728             if( pExpr->iTable<0 ){
729               sqlite3ErrorMsg(pParse,
730                 "second argument to likelihood() must be a "
731                 "constant between 0.0 and 1.0");
732               pNC->nErr++;
733             }
734           }else{
735             /* EVIDENCE-OF: R-61304-29449 The unlikely(X) function is
736             ** equivalent to likelihood(X, 0.0625).
737             ** EVIDENCE-OF: R-01283-11636 The unlikely(X) function is
738             ** short-hand for likelihood(X,0.0625).
739             ** EVIDENCE-OF: R-36850-34127 The likely(X) function is short-hand
740             ** for likelihood(X,0.9375).
741             ** EVIDENCE-OF: R-53436-40973 The likely(X) function is equivalent
742             ** to likelihood(X,0.9375). */
743             /* TUNING: unlikely() probability is 0.0625.  likely() is 0.9375 */
744             pExpr->iTable = pDef->zName[0]=='u' ? 8388608 : 125829120;
745           }
746         }
747 #ifndef SQLITE_OMIT_AUTHORIZATION
748         {
749           int auth = sqlite3AuthCheck(pParse, SQLITE_FUNCTION, 0,pDef->zName,0);
750           if( auth!=SQLITE_OK ){
751             if( auth==SQLITE_DENY ){
752               sqlite3ErrorMsg(pParse, "not authorized to use function: %s",
753                                       pDef->zName);
754               pNC->nErr++;
755             }
756             pExpr->op = TK_NULL;
757             return WRC_Prune;
758           }
759         }
760 #endif
761         if( pDef->funcFlags & (SQLITE_FUNC_CONSTANT|SQLITE_FUNC_SLOCHNG) ){
762           /* For the purposes of the EP_ConstFunc flag, date and time
763           ** functions and other functions that change slowly are considered
764           ** constant because they are constant for the duration of one query */
765           ExprSetProperty(pExpr,EP_ConstFunc);
766         }
767         if( (pDef->funcFlags & SQLITE_FUNC_CONSTANT)==0 ){
768           /* Date/time functions that use 'now', and other functions like
769           ** sqlite_version() that might change over time cannot be used
770           ** in an index. */
771           notValid(pParse, pNC, "non-deterministic functions",
772                    NC_IdxExpr|NC_PartIdx);
773         }
774         if( (pDef->funcFlags & SQLITE_FUNC_INTERNAL)!=0
775          && pParse->nested==0
776          && sqlite3Config.bInternalFunctions==0
777         ){
778           /* Internal-use-only functions are disallowed unless the
779           ** SQL is being compiled using sqlite3NestedParse() */
780           no_such_func = 1;
781           pDef = 0;
782         }
783       }
784 
785       if( 0==IN_RENAME_OBJECT ){
786 #ifndef SQLITE_OMIT_WINDOWFUNC
787         assert( is_agg==0 || (pDef->funcFlags & SQLITE_FUNC_MINMAX)
788           || (pDef->xValue==0 && pDef->xInverse==0)
789           || (pDef->xValue && pDef->xInverse && pDef->xSFunc && pDef->xFinalize)
790         );
791         if( pDef && pDef->xValue==0 && ExprHasProperty(pExpr, EP_WinFunc) ){
792           sqlite3ErrorMsg(pParse,
793               "%.*s() may not be used as a window function", nId, zId
794           );
795           pNC->nErr++;
796         }else if(
797               (is_agg && (pNC->ncFlags & NC_AllowAgg)==0)
798            || (is_agg && (pDef->funcFlags&SQLITE_FUNC_WINDOW) && !pExpr->y.pWin)
799            || (is_agg && pExpr->y.pWin && (pNC->ncFlags & NC_AllowWin)==0)
800         ){
801           const char *zType;
802           if( (pDef->funcFlags & SQLITE_FUNC_WINDOW) || pExpr->y.pWin ){
803             zType = "window";
804           }else{
805             zType = "aggregate";
806           }
807           sqlite3ErrorMsg(pParse, "misuse of %s function %.*s()",zType,nId,zId);
808           pNC->nErr++;
809           is_agg = 0;
810         }
811 #else
812         if( (is_agg && (pNC->ncFlags & NC_AllowAgg)==0) ){
813           sqlite3ErrorMsg(pParse,"misuse of aggregate function %.*s()",nId,zId);
814           pNC->nErr++;
815           is_agg = 0;
816         }
817 #endif
818         else if( no_such_func && pParse->db->init.busy==0
819 #ifdef SQLITE_ENABLE_UNKNOWN_SQL_FUNCTION
820                   && pParse->explain==0
821 #endif
822         ){
823           sqlite3ErrorMsg(pParse, "no such function: %.*s", nId, zId);
824           pNC->nErr++;
825         }else if( wrong_num_args ){
826           sqlite3ErrorMsg(pParse,"wrong number of arguments to function %.*s()",
827                nId, zId);
828           pNC->nErr++;
829         }
830         if( is_agg ){
831 #ifndef SQLITE_OMIT_WINDOWFUNC
832           pNC->ncFlags &= ~(pExpr->y.pWin ? NC_AllowWin : NC_AllowAgg);
833 #else
834           pNC->ncFlags &= ~NC_AllowAgg;
835 #endif
836         }
837       }
838       sqlite3WalkExprList(pWalker, pList);
839       if( is_agg ){
840 #ifndef SQLITE_OMIT_WINDOWFUNC
841         if( pExpr->y.pWin ){
842           Select *pSel = pNC->pWinSelect;
843           sqlite3WalkExprList(pWalker, pExpr->y.pWin->pPartition);
844           sqlite3WalkExprList(pWalker, pExpr->y.pWin->pOrderBy);
845           sqlite3WalkExpr(pWalker, pExpr->y.pWin->pFilter);
846           sqlite3WindowUpdate(pParse, pSel->pWinDefn, pExpr->y.pWin, pDef);
847           if( 0==pSel->pWin
848            || 0==sqlite3WindowCompare(pParse, pSel->pWin, pExpr->y.pWin)
849           ){
850             pExpr->y.pWin->pNextWin = pSel->pWin;
851             pSel->pWin = pExpr->y.pWin;
852           }
853           pNC->ncFlags |= NC_AllowWin;
854         }else
855 #endif /* SQLITE_OMIT_WINDOWFUNC */
856         {
857           NameContext *pNC2 = pNC;
858           pExpr->op = TK_AGG_FUNCTION;
859           pExpr->op2 = 0;
860           while( pNC2 && !sqlite3FunctionUsesThisSrc(pExpr, pNC2->pSrcList) ){
861             pExpr->op2++;
862             pNC2 = pNC2->pNext;
863           }
864           assert( pDef!=0 );
865           if( pNC2 ){
866             assert( SQLITE_FUNC_MINMAX==NC_MinMaxAgg );
867             testcase( (pDef->funcFlags & SQLITE_FUNC_MINMAX)!=0 );
868             pNC2->ncFlags |= NC_HasAgg | (pDef->funcFlags & SQLITE_FUNC_MINMAX);
869 
870           }
871           pNC->ncFlags |= NC_AllowAgg;
872         }
873       }
874       /* FIX ME:  Compute pExpr->affinity based on the expected return
875       ** type of the function
876       */
877       return WRC_Prune;
878     }
879 #ifndef SQLITE_OMIT_SUBQUERY
880     case TK_SELECT:
881     case TK_EXISTS:  testcase( pExpr->op==TK_EXISTS );
882 #endif
883     case TK_IN: {
884       testcase( pExpr->op==TK_IN );
885       if( ExprHasProperty(pExpr, EP_xIsSelect) ){
886         int nRef = pNC->nRef;
887         notValid(pParse, pNC, "subqueries", NC_IsCheck|NC_PartIdx|NC_IdxExpr);
888         sqlite3WalkSelect(pWalker, pExpr->x.pSelect);
889         assert( pNC->nRef>=nRef );
890         if( nRef!=pNC->nRef ){
891           ExprSetProperty(pExpr, EP_VarSelect);
892           pNC->ncFlags |= NC_VarSelect;
893         }
894       }
895       break;
896     }
897     case TK_VARIABLE: {
898       notValid(pParse, pNC, "parameters", NC_IsCheck|NC_PartIdx|NC_IdxExpr);
899       break;
900     }
901     case TK_IS:
902     case TK_ISNOT: {
903       Expr *pRight;
904       assert( !ExprHasProperty(pExpr, EP_Reduced) );
905       /* Handle special cases of "x IS TRUE", "x IS FALSE", "x IS NOT TRUE",
906       ** and "x IS NOT FALSE". */
907       if( (pRight = pExpr->pRight)->op==TK_ID ){
908         int rc = resolveExprStep(pWalker, pRight);
909         if( rc==WRC_Abort ) return WRC_Abort;
910         if( pRight->op==TK_TRUEFALSE ){
911           pExpr->op2 = pExpr->op;
912           pExpr->op = TK_TRUTH;
913           return WRC_Continue;
914         }
915       }
916       /* Fall thru */
917     }
918     case TK_BETWEEN:
919     case TK_EQ:
920     case TK_NE:
921     case TK_LT:
922     case TK_LE:
923     case TK_GT:
924     case TK_GE: {
925       int nLeft, nRight;
926       if( pParse->db->mallocFailed ) break;
927       assert( pExpr->pLeft!=0 );
928       nLeft = sqlite3ExprVectorSize(pExpr->pLeft);
929       if( pExpr->op==TK_BETWEEN ){
930         nRight = sqlite3ExprVectorSize(pExpr->x.pList->a[0].pExpr);
931         if( nRight==nLeft ){
932           nRight = sqlite3ExprVectorSize(pExpr->x.pList->a[1].pExpr);
933         }
934       }else{
935         assert( pExpr->pRight!=0 );
936         nRight = sqlite3ExprVectorSize(pExpr->pRight);
937       }
938       if( nLeft!=nRight ){
939         testcase( pExpr->op==TK_EQ );
940         testcase( pExpr->op==TK_NE );
941         testcase( pExpr->op==TK_LT );
942         testcase( pExpr->op==TK_LE );
943         testcase( pExpr->op==TK_GT );
944         testcase( pExpr->op==TK_GE );
945         testcase( pExpr->op==TK_IS );
946         testcase( pExpr->op==TK_ISNOT );
947         testcase( pExpr->op==TK_BETWEEN );
948         sqlite3ErrorMsg(pParse, "row value misused");
949       }
950       break;
951     }
952   }
953   return (pParse->nErr || pParse->db->mallocFailed) ? WRC_Abort : WRC_Continue;
954 }
955 
956 /*
957 ** pEList is a list of expressions which are really the result set of the
958 ** a SELECT statement.  pE is a term in an ORDER BY or GROUP BY clause.
959 ** This routine checks to see if pE is a simple identifier which corresponds
960 ** to the AS-name of one of the terms of the expression list.  If it is,
961 ** this routine return an integer between 1 and N where N is the number of
962 ** elements in pEList, corresponding to the matching entry.  If there is
963 ** no match, or if pE is not a simple identifier, then this routine
964 ** return 0.
965 **
966 ** pEList has been resolved.  pE has not.
967 */
968 static int resolveAsName(
969   Parse *pParse,     /* Parsing context for error messages */
970   ExprList *pEList,  /* List of expressions to scan */
971   Expr *pE           /* Expression we are trying to match */
972 ){
973   int i;             /* Loop counter */
974 
975   UNUSED_PARAMETER(pParse);
976 
977   if( pE->op==TK_ID ){
978     char *zCol = pE->u.zToken;
979     for(i=0; i<pEList->nExpr; i++){
980       char *zAs = pEList->a[i].zName;
981       if( zAs!=0 && sqlite3StrICmp(zAs, zCol)==0 ){
982         return i+1;
983       }
984     }
985   }
986   return 0;
987 }
988 
989 /*
990 ** pE is a pointer to an expression which is a single term in the
991 ** ORDER BY of a compound SELECT.  The expression has not been
992 ** name resolved.
993 **
994 ** At the point this routine is called, we already know that the
995 ** ORDER BY term is not an integer index into the result set.  That
996 ** case is handled by the calling routine.
997 **
998 ** Attempt to match pE against result set columns in the left-most
999 ** SELECT statement.  Return the index i of the matching column,
1000 ** as an indication to the caller that it should sort by the i-th column.
1001 ** The left-most column is 1.  In other words, the value returned is the
1002 ** same integer value that would be used in the SQL statement to indicate
1003 ** the column.
1004 **
1005 ** If there is no match, return 0.  Return -1 if an error occurs.
1006 */
1007 static int resolveOrderByTermToExprList(
1008   Parse *pParse,     /* Parsing context for error messages */
1009   Select *pSelect,   /* The SELECT statement with the ORDER BY clause */
1010   Expr *pE           /* The specific ORDER BY term */
1011 ){
1012   int i;             /* Loop counter */
1013   ExprList *pEList;  /* The columns of the result set */
1014   NameContext nc;    /* Name context for resolving pE */
1015   sqlite3 *db;       /* Database connection */
1016   int rc;            /* Return code from subprocedures */
1017   u8 savedSuppErr;   /* Saved value of db->suppressErr */
1018 
1019   assert( sqlite3ExprIsInteger(pE, &i)==0 );
1020   pEList = pSelect->pEList;
1021 
1022   /* Resolve all names in the ORDER BY term expression
1023   */
1024   memset(&nc, 0, sizeof(nc));
1025   nc.pParse = pParse;
1026   nc.pSrcList = pSelect->pSrc;
1027   nc.uNC.pEList = pEList;
1028   nc.ncFlags = NC_AllowAgg|NC_UEList;
1029   nc.nErr = 0;
1030   db = pParse->db;
1031   savedSuppErr = db->suppressErr;
1032   db->suppressErr = 1;
1033   rc = sqlite3ResolveExprNames(&nc, pE);
1034   db->suppressErr = savedSuppErr;
1035   if( rc ) return 0;
1036 
1037   /* Try to match the ORDER BY expression against an expression
1038   ** in the result set.  Return an 1-based index of the matching
1039   ** result-set entry.
1040   */
1041   for(i=0; i<pEList->nExpr; i++){
1042     if( sqlite3ExprCompare(0, pEList->a[i].pExpr, pE, -1)<2 ){
1043       return i+1;
1044     }
1045   }
1046 
1047   /* If no match, return 0. */
1048   return 0;
1049 }
1050 
1051 /*
1052 ** Generate an ORDER BY or GROUP BY term out-of-range error.
1053 */
1054 static void resolveOutOfRangeError(
1055   Parse *pParse,         /* The error context into which to write the error */
1056   const char *zType,     /* "ORDER" or "GROUP" */
1057   int i,                 /* The index (1-based) of the term out of range */
1058   int mx                 /* Largest permissible value of i */
1059 ){
1060   sqlite3ErrorMsg(pParse,
1061     "%r %s BY term out of range - should be "
1062     "between 1 and %d", i, zType, mx);
1063 }
1064 
1065 /*
1066 ** Analyze the ORDER BY clause in a compound SELECT statement.   Modify
1067 ** each term of the ORDER BY clause is a constant integer between 1
1068 ** and N where N is the number of columns in the compound SELECT.
1069 **
1070 ** ORDER BY terms that are already an integer between 1 and N are
1071 ** unmodified.  ORDER BY terms that are integers outside the range of
1072 ** 1 through N generate an error.  ORDER BY terms that are expressions
1073 ** are matched against result set expressions of compound SELECT
1074 ** beginning with the left-most SELECT and working toward the right.
1075 ** At the first match, the ORDER BY expression is transformed into
1076 ** the integer column number.
1077 **
1078 ** Return the number of errors seen.
1079 */
1080 static int resolveCompoundOrderBy(
1081   Parse *pParse,        /* Parsing context.  Leave error messages here */
1082   Select *pSelect       /* The SELECT statement containing the ORDER BY */
1083 ){
1084   int i;
1085   ExprList *pOrderBy;
1086   ExprList *pEList;
1087   sqlite3 *db;
1088   int moreToDo = 1;
1089 
1090   pOrderBy = pSelect->pOrderBy;
1091   if( pOrderBy==0 ) return 0;
1092   db = pParse->db;
1093   if( pOrderBy->nExpr>db->aLimit[SQLITE_LIMIT_COLUMN] ){
1094     sqlite3ErrorMsg(pParse, "too many terms in ORDER BY clause");
1095     return 1;
1096   }
1097   for(i=0; i<pOrderBy->nExpr; i++){
1098     pOrderBy->a[i].done = 0;
1099   }
1100   pSelect->pNext = 0;
1101   while( pSelect->pPrior ){
1102     pSelect->pPrior->pNext = pSelect;
1103     pSelect = pSelect->pPrior;
1104   }
1105   while( pSelect && moreToDo ){
1106     struct ExprList_item *pItem;
1107     moreToDo = 0;
1108     pEList = pSelect->pEList;
1109     assert( pEList!=0 );
1110     for(i=0, pItem=pOrderBy->a; i<pOrderBy->nExpr; i++, pItem++){
1111       int iCol = -1;
1112       Expr *pE, *pDup;
1113       if( pItem->done ) continue;
1114       pE = sqlite3ExprSkipCollate(pItem->pExpr);
1115       if( sqlite3ExprIsInteger(pE, &iCol) ){
1116         if( iCol<=0 || iCol>pEList->nExpr ){
1117           resolveOutOfRangeError(pParse, "ORDER", i+1, pEList->nExpr);
1118           return 1;
1119         }
1120       }else{
1121         iCol = resolveAsName(pParse, pEList, pE);
1122         if( iCol==0 ){
1123           pDup = sqlite3ExprDup(db, pE, 0);
1124           if( !db->mallocFailed ){
1125             assert(pDup);
1126             iCol = resolveOrderByTermToExprList(pParse, pSelect, pDup);
1127           }
1128           sqlite3ExprDelete(db, pDup);
1129         }
1130       }
1131       if( iCol>0 ){
1132         /* Convert the ORDER BY term into an integer column number iCol,
1133         ** taking care to preserve the COLLATE clause if it exists */
1134         Expr *pNew = sqlite3Expr(db, TK_INTEGER, 0);
1135         if( pNew==0 ) return 1;
1136         pNew->flags |= EP_IntValue;
1137         pNew->u.iValue = iCol;
1138         if( pItem->pExpr==pE ){
1139           pItem->pExpr = pNew;
1140         }else{
1141           Expr *pParent = pItem->pExpr;
1142           assert( pParent->op==TK_COLLATE );
1143           while( pParent->pLeft->op==TK_COLLATE ) pParent = pParent->pLeft;
1144           assert( pParent->pLeft==pE );
1145           pParent->pLeft = pNew;
1146         }
1147         sqlite3ExprDelete(db, pE);
1148         pItem->u.x.iOrderByCol = (u16)iCol;
1149         pItem->done = 1;
1150       }else{
1151         moreToDo = 1;
1152       }
1153     }
1154     pSelect = pSelect->pNext;
1155   }
1156   for(i=0; i<pOrderBy->nExpr; i++){
1157     if( pOrderBy->a[i].done==0 ){
1158       sqlite3ErrorMsg(pParse, "%r ORDER BY term does not match any "
1159             "column in the result set", i+1);
1160       return 1;
1161     }
1162   }
1163   return 0;
1164 }
1165 
1166 /*
1167 ** Check every term in the ORDER BY or GROUP BY clause pOrderBy of
1168 ** the SELECT statement pSelect.  If any term is reference to a
1169 ** result set expression (as determined by the ExprList.a.u.x.iOrderByCol
1170 ** field) then convert that term into a copy of the corresponding result set
1171 ** column.
1172 **
1173 ** If any errors are detected, add an error message to pParse and
1174 ** return non-zero.  Return zero if no errors are seen.
1175 */
1176 int sqlite3ResolveOrderGroupBy(
1177   Parse *pParse,        /* Parsing context.  Leave error messages here */
1178   Select *pSelect,      /* The SELECT statement containing the clause */
1179   ExprList *pOrderBy,   /* The ORDER BY or GROUP BY clause to be processed */
1180   const char *zType     /* "ORDER" or "GROUP" */
1181 ){
1182   int i;
1183   sqlite3 *db = pParse->db;
1184   ExprList *pEList;
1185   struct ExprList_item *pItem;
1186 
1187   if( pOrderBy==0 || pParse->db->mallocFailed ) return 0;
1188   if( pOrderBy->nExpr>db->aLimit[SQLITE_LIMIT_COLUMN] ){
1189     sqlite3ErrorMsg(pParse, "too many terms in %s BY clause", zType);
1190     return 1;
1191   }
1192   pEList = pSelect->pEList;
1193   assert( pEList!=0 );  /* sqlite3SelectNew() guarantees this */
1194   for(i=0, pItem=pOrderBy->a; i<pOrderBy->nExpr; i++, pItem++){
1195     if( pItem->u.x.iOrderByCol ){
1196       if( pItem->u.x.iOrderByCol>pEList->nExpr ){
1197         resolveOutOfRangeError(pParse, zType, i+1, pEList->nExpr);
1198         return 1;
1199       }
1200       resolveAlias(pParse, pEList, pItem->u.x.iOrderByCol-1, pItem->pExpr,
1201                    zType,0);
1202     }
1203   }
1204   return 0;
1205 }
1206 
1207 /*
1208 ** pOrderBy is an ORDER BY or GROUP BY clause in SELECT statement pSelect.
1209 ** The Name context of the SELECT statement is pNC.  zType is either
1210 ** "ORDER" or "GROUP" depending on which type of clause pOrderBy is.
1211 **
1212 ** This routine resolves each term of the clause into an expression.
1213 ** If the order-by term is an integer I between 1 and N (where N is the
1214 ** number of columns in the result set of the SELECT) then the expression
1215 ** in the resolution is a copy of the I-th result-set expression.  If
1216 ** the order-by term is an identifier that corresponds to the AS-name of
1217 ** a result-set expression, then the term resolves to a copy of the
1218 ** result-set expression.  Otherwise, the expression is resolved in
1219 ** the usual way - using sqlite3ResolveExprNames().
1220 **
1221 ** This routine returns the number of errors.  If errors occur, then
1222 ** an appropriate error message might be left in pParse.  (OOM errors
1223 ** excepted.)
1224 */
1225 static int resolveOrderGroupBy(
1226   NameContext *pNC,     /* The name context of the SELECT statement */
1227   Select *pSelect,      /* The SELECT statement holding pOrderBy */
1228   ExprList *pOrderBy,   /* An ORDER BY or GROUP BY clause to resolve */
1229   const char *zType     /* Either "ORDER" or "GROUP", as appropriate */
1230 ){
1231   int i, j;                      /* Loop counters */
1232   int iCol;                      /* Column number */
1233   struct ExprList_item *pItem;   /* A term of the ORDER BY clause */
1234   Parse *pParse;                 /* Parsing context */
1235   int nResult;                   /* Number of terms in the result set */
1236 
1237   if( pOrderBy==0 ) return 0;
1238   nResult = pSelect->pEList->nExpr;
1239   pParse = pNC->pParse;
1240   for(i=0, pItem=pOrderBy->a; i<pOrderBy->nExpr; i++, pItem++){
1241     Expr *pE = pItem->pExpr;
1242     Expr *pE2 = sqlite3ExprSkipCollate(pE);
1243     if( zType[0]!='G' ){
1244       iCol = resolveAsName(pParse, pSelect->pEList, pE2);
1245       if( iCol>0 ){
1246         /* If an AS-name match is found, mark this ORDER BY column as being
1247         ** a copy of the iCol-th result-set column.  The subsequent call to
1248         ** sqlite3ResolveOrderGroupBy() will convert the expression to a
1249         ** copy of the iCol-th result-set expression. */
1250         pItem->u.x.iOrderByCol = (u16)iCol;
1251         continue;
1252       }
1253     }
1254     if( sqlite3ExprIsInteger(pE2, &iCol) ){
1255       /* The ORDER BY term is an integer constant.  Again, set the column
1256       ** number so that sqlite3ResolveOrderGroupBy() will convert the
1257       ** order-by term to a copy of the result-set expression */
1258       if( iCol<1 || iCol>0xffff ){
1259         resolveOutOfRangeError(pParse, zType, i+1, nResult);
1260         return 1;
1261       }
1262       pItem->u.x.iOrderByCol = (u16)iCol;
1263       continue;
1264     }
1265 
1266     /* Otherwise, treat the ORDER BY term as an ordinary expression */
1267     pItem->u.x.iOrderByCol = 0;
1268     if( sqlite3ResolveExprNames(pNC, pE) ){
1269       return 1;
1270     }
1271     for(j=0; j<pSelect->pEList->nExpr; j++){
1272       if( sqlite3ExprCompare(0, pE, pSelect->pEList->a[j].pExpr, -1)==0 ){
1273 #ifndef SQLITE_OMIT_WINDOWFUNC
1274         if( ExprHasProperty(pE, EP_WinFunc) ){
1275           /* Since this window function is being changed into a reference
1276           ** to the same window function the result set, remove the instance
1277           ** of this window function from the Select.pWin list. */
1278           Window **pp;
1279           for(pp=&pSelect->pWin; *pp; pp=&(*pp)->pNextWin){
1280             if( *pp==pE->y.pWin ){
1281               *pp = (*pp)->pNextWin;
1282             }
1283           }
1284         }
1285 #endif
1286         pItem->u.x.iOrderByCol = j+1;
1287       }
1288     }
1289   }
1290   return sqlite3ResolveOrderGroupBy(pParse, pSelect, pOrderBy, zType);
1291 }
1292 
1293 /*
1294 ** Resolve names in the SELECT statement p and all of its descendants.
1295 */
1296 static int resolveSelectStep(Walker *pWalker, Select *p){
1297   NameContext *pOuterNC;  /* Context that contains this SELECT */
1298   NameContext sNC;        /* Name context of this SELECT */
1299   int isCompound;         /* True if p is a compound select */
1300   int nCompound;          /* Number of compound terms processed so far */
1301   Parse *pParse;          /* Parsing context */
1302   int i;                  /* Loop counter */
1303   ExprList *pGroupBy;     /* The GROUP BY clause */
1304   Select *pLeftmost;      /* Left-most of SELECT of a compound */
1305   sqlite3 *db;            /* Database connection */
1306 
1307 
1308   assert( p!=0 );
1309   if( p->selFlags & SF_Resolved ){
1310     return WRC_Prune;
1311   }
1312   pOuterNC = pWalker->u.pNC;
1313   pParse = pWalker->pParse;
1314   db = pParse->db;
1315 
1316   /* Normally sqlite3SelectExpand() will be called first and will have
1317   ** already expanded this SELECT.  However, if this is a subquery within
1318   ** an expression, sqlite3ResolveExprNames() will be called without a
1319   ** prior call to sqlite3SelectExpand().  When that happens, let
1320   ** sqlite3SelectPrep() do all of the processing for this SELECT.
1321   ** sqlite3SelectPrep() will invoke both sqlite3SelectExpand() and
1322   ** this routine in the correct order.
1323   */
1324   if( (p->selFlags & SF_Expanded)==0 ){
1325     sqlite3SelectPrep(pParse, p, pOuterNC);
1326     return (pParse->nErr || db->mallocFailed) ? WRC_Abort : WRC_Prune;
1327   }
1328 
1329   isCompound = p->pPrior!=0;
1330   nCompound = 0;
1331   pLeftmost = p;
1332   while( p ){
1333     assert( (p->selFlags & SF_Expanded)!=0 );
1334     assert( (p->selFlags & SF_Resolved)==0 );
1335     p->selFlags |= SF_Resolved;
1336 
1337     /* Resolve the expressions in the LIMIT and OFFSET clauses. These
1338     ** are not allowed to refer to any names, so pass an empty NameContext.
1339     */
1340     memset(&sNC, 0, sizeof(sNC));
1341     sNC.pParse = pParse;
1342     sNC.pWinSelect = p;
1343     if( sqlite3ResolveExprNames(&sNC, p->pLimit) ){
1344       return WRC_Abort;
1345     }
1346 
1347     /* If the SF_Converted flags is set, then this Select object was
1348     ** was created by the convertCompoundSelectToSubquery() function.
1349     ** In this case the ORDER BY clause (p->pOrderBy) should be resolved
1350     ** as if it were part of the sub-query, not the parent. This block
1351     ** moves the pOrderBy down to the sub-query. It will be moved back
1352     ** after the names have been resolved.  */
1353     if( p->selFlags & SF_Converted ){
1354       Select *pSub = p->pSrc->a[0].pSelect;
1355       assert( p->pSrc->nSrc==1 && p->pOrderBy );
1356       assert( pSub->pPrior && pSub->pOrderBy==0 );
1357       pSub->pOrderBy = p->pOrderBy;
1358       p->pOrderBy = 0;
1359     }
1360 
1361     /* Recursively resolve names in all subqueries
1362     */
1363     for(i=0; i<p->pSrc->nSrc; i++){
1364       struct SrcList_item *pItem = &p->pSrc->a[i];
1365       if( pItem->pSelect ){
1366         NameContext *pNC;         /* Used to iterate name contexts */
1367         int nRef = 0;             /* Refcount for pOuterNC and outer contexts */
1368         const char *zSavedContext = pParse->zAuthContext;
1369 
1370         /* Count the total number of references to pOuterNC and all of its
1371         ** parent contexts. After resolving references to expressions in
1372         ** pItem->pSelect, check if this value has changed. If so, then
1373         ** SELECT statement pItem->pSelect must be correlated. Set the
1374         ** pItem->fg.isCorrelated flag if this is the case. */
1375         for(pNC=pOuterNC; pNC; pNC=pNC->pNext) nRef += pNC->nRef;
1376 
1377         if( pItem->zName ) pParse->zAuthContext = pItem->zName;
1378         sqlite3ResolveSelectNames(pParse, pItem->pSelect, pOuterNC);
1379         pParse->zAuthContext = zSavedContext;
1380         if( pParse->nErr || db->mallocFailed ) return WRC_Abort;
1381 
1382         for(pNC=pOuterNC; pNC; pNC=pNC->pNext) nRef -= pNC->nRef;
1383         assert( pItem->fg.isCorrelated==0 && nRef<=0 );
1384         pItem->fg.isCorrelated = (nRef!=0);
1385       }
1386     }
1387 
1388     /* Set up the local name-context to pass to sqlite3ResolveExprNames() to
1389     ** resolve the result-set expression list.
1390     */
1391     sNC.ncFlags = NC_AllowAgg|NC_AllowWin;
1392     sNC.pSrcList = p->pSrc;
1393     sNC.pNext = pOuterNC;
1394 
1395     /* Resolve names in the result set. */
1396     if( sqlite3ResolveExprListNames(&sNC, p->pEList) ) return WRC_Abort;
1397     sNC.ncFlags &= ~NC_AllowWin;
1398 
1399     /* If there are no aggregate functions in the result-set, and no GROUP BY
1400     ** expression, do not allow aggregates in any of the other expressions.
1401     */
1402     assert( (p->selFlags & SF_Aggregate)==0 );
1403     pGroupBy = p->pGroupBy;
1404     if( pGroupBy || (sNC.ncFlags & NC_HasAgg)!=0 ){
1405       assert( NC_MinMaxAgg==SF_MinMaxAgg );
1406       p->selFlags |= SF_Aggregate | (sNC.ncFlags&NC_MinMaxAgg);
1407     }else{
1408       sNC.ncFlags &= ~NC_AllowAgg;
1409     }
1410 
1411     /* If a HAVING clause is present, then there must be a GROUP BY clause.
1412     */
1413     if( p->pHaving && !pGroupBy ){
1414       sqlite3ErrorMsg(pParse, "a GROUP BY clause is required before HAVING");
1415       return WRC_Abort;
1416     }
1417 
1418     /* Add the output column list to the name-context before parsing the
1419     ** other expressions in the SELECT statement. This is so that
1420     ** expressions in the WHERE clause (etc.) can refer to expressions by
1421     ** aliases in the result set.
1422     **
1423     ** Minor point: If this is the case, then the expression will be
1424     ** re-evaluated for each reference to it.
1425     */
1426     assert( (sNC.ncFlags & (NC_UAggInfo|NC_UUpsert))==0 );
1427     sNC.uNC.pEList = p->pEList;
1428     sNC.ncFlags |= NC_UEList;
1429     if( sqlite3ResolveExprNames(&sNC, p->pHaving) ) return WRC_Abort;
1430     if( sqlite3ResolveExprNames(&sNC, p->pWhere) ) return WRC_Abort;
1431 
1432     /* Resolve names in table-valued-function arguments */
1433     for(i=0; i<p->pSrc->nSrc; i++){
1434       struct SrcList_item *pItem = &p->pSrc->a[i];
1435       if( pItem->fg.isTabFunc
1436        && sqlite3ResolveExprListNames(&sNC, pItem->u1.pFuncArg)
1437       ){
1438         return WRC_Abort;
1439       }
1440     }
1441 
1442     /* The ORDER BY and GROUP BY clauses may not refer to terms in
1443     ** outer queries
1444     */
1445     sNC.pNext = 0;
1446     sNC.ncFlags |= NC_AllowAgg|NC_AllowWin;
1447 
1448     /* If this is a converted compound query, move the ORDER BY clause from
1449     ** the sub-query back to the parent query. At this point each term
1450     ** within the ORDER BY clause has been transformed to an integer value.
1451     ** These integers will be replaced by copies of the corresponding result
1452     ** set expressions by the call to resolveOrderGroupBy() below.  */
1453     if( p->selFlags & SF_Converted ){
1454       Select *pSub = p->pSrc->a[0].pSelect;
1455       p->pOrderBy = pSub->pOrderBy;
1456       pSub->pOrderBy = 0;
1457     }
1458 
1459     /* Process the ORDER BY clause for singleton SELECT statements.
1460     ** The ORDER BY clause for compounds SELECT statements is handled
1461     ** below, after all of the result-sets for all of the elements of
1462     ** the compound have been resolved.
1463     **
1464     ** If there is an ORDER BY clause on a term of a compound-select other
1465     ** than the right-most term, then that is a syntax error.  But the error
1466     ** is not detected until much later, and so we need to go ahead and
1467     ** resolve those symbols on the incorrect ORDER BY for consistency.
1468     */
1469     if( isCompound<=nCompound  /* Defer right-most ORDER BY of a compound */
1470      && resolveOrderGroupBy(&sNC, p, p->pOrderBy, "ORDER")
1471     ){
1472       return WRC_Abort;
1473     }
1474     if( db->mallocFailed ){
1475       return WRC_Abort;
1476     }
1477     sNC.ncFlags &= ~NC_AllowWin;
1478 
1479     /* Resolve the GROUP BY clause.  At the same time, make sure
1480     ** the GROUP BY clause does not contain aggregate functions.
1481     */
1482     if( pGroupBy ){
1483       struct ExprList_item *pItem;
1484 
1485       if( resolveOrderGroupBy(&sNC, p, pGroupBy, "GROUP") || db->mallocFailed ){
1486         return WRC_Abort;
1487       }
1488       for(i=0, pItem=pGroupBy->a; i<pGroupBy->nExpr; i++, pItem++){
1489         if( ExprHasProperty(pItem->pExpr, EP_Agg) ){
1490           sqlite3ErrorMsg(pParse, "aggregate functions are not allowed in "
1491               "the GROUP BY clause");
1492           return WRC_Abort;
1493         }
1494       }
1495     }
1496 
1497     /* If this is part of a compound SELECT, check that it has the right
1498     ** number of expressions in the select list. */
1499     if( p->pNext && p->pEList->nExpr!=p->pNext->pEList->nExpr ){
1500       sqlite3SelectWrongNumTermsError(pParse, p->pNext);
1501       return WRC_Abort;
1502     }
1503 
1504     /* Advance to the next term of the compound
1505     */
1506     p = p->pPrior;
1507     nCompound++;
1508   }
1509 
1510   /* Resolve the ORDER BY on a compound SELECT after all terms of
1511   ** the compound have been resolved.
1512   */
1513   if( isCompound && resolveCompoundOrderBy(pParse, pLeftmost) ){
1514     return WRC_Abort;
1515   }
1516 
1517   return WRC_Prune;
1518 }
1519 
1520 /*
1521 ** This routine walks an expression tree and resolves references to
1522 ** table columns and result-set columns.  At the same time, do error
1523 ** checking on function usage and set a flag if any aggregate functions
1524 ** are seen.
1525 **
1526 ** To resolve table columns references we look for nodes (or subtrees) of the
1527 ** form X.Y.Z or Y.Z or just Z where
1528 **
1529 **      X:   The name of a database.  Ex:  "main" or "temp" or
1530 **           the symbolic name assigned to an ATTACH-ed database.
1531 **
1532 **      Y:   The name of a table in a FROM clause.  Or in a trigger
1533 **           one of the special names "old" or "new".
1534 **
1535 **      Z:   The name of a column in table Y.
1536 **
1537 ** The node at the root of the subtree is modified as follows:
1538 **
1539 **    Expr.op        Changed to TK_COLUMN
1540 **    Expr.pTab      Points to the Table object for X.Y
1541 **    Expr.iColumn   The column index in X.Y.  -1 for the rowid.
1542 **    Expr.iTable    The VDBE cursor number for X.Y
1543 **
1544 **
1545 ** To resolve result-set references, look for expression nodes of the
1546 ** form Z (with no X and Y prefix) where the Z matches the right-hand
1547 ** size of an AS clause in the result-set of a SELECT.  The Z expression
1548 ** is replaced by a copy of the left-hand side of the result-set expression.
1549 ** Table-name and function resolution occurs on the substituted expression
1550 ** tree.  For example, in:
1551 **
1552 **      SELECT a+b AS x, c+d AS y FROM t1 ORDER BY x;
1553 **
1554 ** The "x" term of the order by is replaced by "a+b" to render:
1555 **
1556 **      SELECT a+b AS x, c+d AS y FROM t1 ORDER BY a+b;
1557 **
1558 ** Function calls are checked to make sure that the function is
1559 ** defined and that the correct number of arguments are specified.
1560 ** If the function is an aggregate function, then the NC_HasAgg flag is
1561 ** set and the opcode is changed from TK_FUNCTION to TK_AGG_FUNCTION.
1562 ** If an expression contains aggregate functions then the EP_Agg
1563 ** property on the expression is set.
1564 **
1565 ** An error message is left in pParse if anything is amiss.  The number
1566 ** if errors is returned.
1567 */
1568 int sqlite3ResolveExprNames(
1569   NameContext *pNC,       /* Namespace to resolve expressions in. */
1570   Expr *pExpr             /* The expression to be analyzed. */
1571 ){
1572   u16 savedHasAgg;
1573   Walker w;
1574 
1575   if( pExpr==0 ) return SQLITE_OK;
1576   savedHasAgg = pNC->ncFlags & (NC_HasAgg|NC_MinMaxAgg);
1577   pNC->ncFlags &= ~(NC_HasAgg|NC_MinMaxAgg);
1578   w.pParse = pNC->pParse;
1579   w.xExprCallback = resolveExprStep;
1580   w.xSelectCallback = resolveSelectStep;
1581   w.xSelectCallback2 = 0;
1582   w.u.pNC = pNC;
1583 #if SQLITE_MAX_EXPR_DEPTH>0
1584   w.pParse->nHeight += pExpr->nHeight;
1585   if( sqlite3ExprCheckHeight(w.pParse, w.pParse->nHeight) ){
1586     return SQLITE_ERROR;
1587   }
1588 #endif
1589   sqlite3WalkExpr(&w, pExpr);
1590 #if SQLITE_MAX_EXPR_DEPTH>0
1591   w.pParse->nHeight -= pExpr->nHeight;
1592 #endif
1593   if( pNC->ncFlags & NC_HasAgg ){
1594     ExprSetProperty(pExpr, EP_Agg);
1595   }
1596   pNC->ncFlags |= savedHasAgg;
1597   return pNC->nErr>0 || w.pParse->nErr>0;
1598 }
1599 
1600 /*
1601 ** Resolve all names for all expression in an expression list.  This is
1602 ** just like sqlite3ResolveExprNames() except that it works for an expression
1603 ** list rather than a single expression.
1604 */
1605 int sqlite3ResolveExprListNames(
1606   NameContext *pNC,       /* Namespace to resolve expressions in. */
1607   ExprList *pList         /* The expression list to be analyzed. */
1608 ){
1609   int i;
1610   if( pList ){
1611     for(i=0; i<pList->nExpr; i++){
1612       if( sqlite3ResolveExprNames(pNC, pList->a[i].pExpr) ) return WRC_Abort;
1613     }
1614   }
1615   return WRC_Continue;
1616 }
1617 
1618 /*
1619 ** Resolve all names in all expressions of a SELECT and in all
1620 ** decendents of the SELECT, including compounds off of p->pPrior,
1621 ** subqueries in expressions, and subqueries used as FROM clause
1622 ** terms.
1623 **
1624 ** See sqlite3ResolveExprNames() for a description of the kinds of
1625 ** transformations that occur.
1626 **
1627 ** All SELECT statements should have been expanded using
1628 ** sqlite3SelectExpand() prior to invoking this routine.
1629 */
1630 void sqlite3ResolveSelectNames(
1631   Parse *pParse,         /* The parser context */
1632   Select *p,             /* The SELECT statement being coded. */
1633   NameContext *pOuterNC  /* Name context for parent SELECT statement */
1634 ){
1635   Walker w;
1636 
1637   assert( p!=0 );
1638   w.xExprCallback = resolveExprStep;
1639   w.xSelectCallback = resolveSelectStep;
1640   w.xSelectCallback2 = 0;
1641   w.pParse = pParse;
1642   w.u.pNC = pOuterNC;
1643   sqlite3WalkSelect(&w, p);
1644 }
1645 
1646 /*
1647 ** Resolve names in expressions that can only reference a single table:
1648 **
1649 **    *   CHECK constraints
1650 **    *   WHERE clauses on partial indices
1651 **
1652 ** The Expr.iTable value for Expr.op==TK_COLUMN nodes of the expression
1653 ** is set to -1 and the Expr.iColumn value is set to the column number.
1654 **
1655 ** Any errors cause an error message to be set in pParse.
1656 */
1657 void sqlite3ResolveSelfReference(
1658   Parse *pParse,      /* Parsing context */
1659   Table *pTab,        /* The table being referenced */
1660   int type,           /* NC_IsCheck or NC_PartIdx or NC_IdxExpr */
1661   Expr *pExpr,        /* Expression to resolve.  May be NULL. */
1662   ExprList *pList     /* Expression list to resolve.  May be NULL. */
1663 ){
1664   SrcList sSrc;                   /* Fake SrcList for pParse->pNewTable */
1665   NameContext sNC;                /* Name context for pParse->pNewTable */
1666 
1667   assert( type==NC_IsCheck || type==NC_PartIdx || type==NC_IdxExpr );
1668   memset(&sNC, 0, sizeof(sNC));
1669   memset(&sSrc, 0, sizeof(sSrc));
1670   sSrc.nSrc = 1;
1671   sSrc.a[0].zName = pTab->zName;
1672   sSrc.a[0].pTab = pTab;
1673   sSrc.a[0].iCursor = -1;
1674   sNC.pParse = pParse;
1675   sNC.pSrcList = &sSrc;
1676   sNC.ncFlags = type;
1677   if( sqlite3ResolveExprNames(&sNC, pExpr) ) return;
1678   if( pList ) sqlite3ResolveExprListNames(&sNC, pList);
1679 }
1680