1e60b36cfSFlorian Hahn //===-- VPlanTransforms.cpp - Utility VPlan to VPlan transforms -----------===//
2e60b36cfSFlorian Hahn //
3e60b36cfSFlorian Hahn // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4e60b36cfSFlorian Hahn // See https://llvm.org/LICENSE.txt for license information.
5e60b36cfSFlorian Hahn // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6e60b36cfSFlorian Hahn //
7e60b36cfSFlorian Hahn //===----------------------------------------------------------------------===//
8e60b36cfSFlorian Hahn ///
9e60b36cfSFlorian Hahn /// \file
10e60b36cfSFlorian Hahn /// This file implements a set of utility VPlan to VPlan transformations.
11e60b36cfSFlorian Hahn ///
12e60b36cfSFlorian Hahn //===----------------------------------------------------------------------===//
13e60b36cfSFlorian Hahn 
14e60b36cfSFlorian Hahn #include "VPlanTransforms.h"
15e60b36cfSFlorian Hahn #include "llvm/ADT/PostOrderIterator.h"
16e60b36cfSFlorian Hahn 
17e60b36cfSFlorian Hahn using namespace llvm;
18e60b36cfSFlorian Hahn 
19e60b36cfSFlorian Hahn void VPlanTransforms::VPInstructionsToVPRecipes(
20e60b36cfSFlorian Hahn     Loop *OrigLoop, VPlanPtr &Plan,
21*978883d2SFlorian Hahn     function_ref<const InductionDescriptor *(PHINode *)>
22*978883d2SFlorian Hahn         GetIntOrFpInductionDescriptor,
230de8aeaeSMauri Mustonen     SmallPtrSetImpl<Instruction *> &DeadInstructions, ScalarEvolution &SE) {
24e60b36cfSFlorian Hahn 
25e60b36cfSFlorian Hahn   auto *TopRegion = cast<VPRegionBlock>(Plan->getEntry());
26e60b36cfSFlorian Hahn   ReversePostOrderTraversal<VPBlockBase *> RPOT(TopRegion->getEntry());
27e60b36cfSFlorian Hahn 
28e60b36cfSFlorian Hahn   for (VPBlockBase *Base : RPOT) {
29e60b36cfSFlorian Hahn     // Do not widen instructions in pre-header and exit blocks.
30e60b36cfSFlorian Hahn     if (Base->getNumPredecessors() == 0 || Base->getNumSuccessors() == 0)
31e60b36cfSFlorian Hahn       continue;
32e60b36cfSFlorian Hahn 
33e60b36cfSFlorian Hahn     VPBasicBlock *VPBB = Base->getEntryBasicBlock();
34e60b36cfSFlorian Hahn     // Introduce each ingredient into VPlan.
3524c8eaecSKazu Hirata     for (VPRecipeBase &Ingredient : llvm::make_early_inc_range(*VPBB)) {
3624c8eaecSKazu Hirata       VPValue *VPV = Ingredient.getVPSingleValue();
3715a74b64SFlorian Hahn       Instruction *Inst = cast<Instruction>(VPV->getUnderlyingValue());
38e60b36cfSFlorian Hahn       if (DeadInstructions.count(Inst)) {
3976afbf60SFlorian Hahn         VPValue DummyValue;
4015a74b64SFlorian Hahn         VPV->replaceAllUsesWith(&DummyValue);
4124c8eaecSKazu Hirata         Ingredient.eraseFromParent();
42e60b36cfSFlorian Hahn         continue;
43e60b36cfSFlorian Hahn       }
44e60b36cfSFlorian Hahn 
45e60b36cfSFlorian Hahn       VPRecipeBase *NewRecipe = nullptr;
4624c8eaecSKazu Hirata       if (auto *VPPhi = dyn_cast<VPWidenPHIRecipe>(&Ingredient)) {
4715a74b64SFlorian Hahn         auto *Phi = cast<PHINode>(VPPhi->getUnderlyingValue());
48*978883d2SFlorian Hahn         if (const auto *II = GetIntOrFpInductionDescriptor(Phi)) {
49*978883d2SFlorian Hahn           VPValue *Start = Plan->getOrAddVPValue(II->getStartValue());
50*978883d2SFlorian Hahn           NewRecipe = new VPWidenIntOrFpInductionRecipe(Phi, Start, *II);
5115a74b64SFlorian Hahn         } else {
5215a74b64SFlorian Hahn           Plan->addVPValue(Phi, VPPhi);
5315a74b64SFlorian Hahn           continue;
5415a74b64SFlorian Hahn         }
5515a74b64SFlorian Hahn       } else {
5624c8eaecSKazu Hirata         assert(isa<VPInstruction>(&Ingredient) &&
5715a74b64SFlorian Hahn                "only VPInstructions expected here");
5815a74b64SFlorian Hahn         assert(!isa<PHINode>(Inst) && "phis should be handled above");
5915a74b64SFlorian Hahn         // Create VPWidenMemoryInstructionRecipe for loads and stores.
6015a74b64SFlorian Hahn         if (LoadInst *Load = dyn_cast<LoadInst>(Inst)) {
6115a74b64SFlorian Hahn           NewRecipe = new VPWidenMemoryInstructionRecipe(
6215a74b64SFlorian Hahn               *Load, Plan->getOrAddVPValue(getLoadStorePointerOperand(Inst)),
631156bd4fSGil Rapaport               nullptr /*Mask*/, false /*Consecutive*/, false /*Reverse*/);
6415a74b64SFlorian Hahn         } else if (StoreInst *Store = dyn_cast<StoreInst>(Inst)) {
6515a74b64SFlorian Hahn           NewRecipe = new VPWidenMemoryInstructionRecipe(
6615a74b64SFlorian Hahn               *Store, Plan->getOrAddVPValue(getLoadStorePointerOperand(Inst)),
671156bd4fSGil Rapaport               Plan->getOrAddVPValue(Store->getValueOperand()), nullptr /*Mask*/,
681156bd4fSGil Rapaport               false /*Consecutive*/, false /*Reverse*/);
69e60b36cfSFlorian Hahn         } else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Inst)) {
70c0cdba72SFlorian Hahn           NewRecipe = new VPWidenGEPRecipe(
71c0cdba72SFlorian Hahn               GEP, Plan->mapToVPValues(GEP->operands()), OrigLoop);
72494b5ba3SMauri Mustonen         } else if (CallInst *CI = dyn_cast<CallInst>(Inst)) {
73f631173dSKazu Hirata           NewRecipe =
74f631173dSKazu Hirata               new VPWidenCallRecipe(*CI, Plan->mapToVPValues(CI->args()));
750de8aeaeSMauri Mustonen         } else if (SelectInst *SI = dyn_cast<SelectInst>(Inst)) {
760de8aeaeSMauri Mustonen           bool InvariantCond =
770de8aeaeSMauri Mustonen               SE.isLoopInvariant(SE.getSCEV(SI->getOperand(0)), OrigLoop);
780de8aeaeSMauri Mustonen           NewRecipe = new VPWidenSelectRecipe(
790de8aeaeSMauri Mustonen               *SI, Plan->mapToVPValues(SI->operands()), InvariantCond);
8015a74b64SFlorian Hahn         } else {
81e8937985SFlorian Hahn           NewRecipe =
82e8937985SFlorian Hahn               new VPWidenRecipe(*Inst, Plan->mapToVPValues(Inst->operands()));
8315a74b64SFlorian Hahn         }
8415a74b64SFlorian Hahn       }
85e60b36cfSFlorian Hahn 
8624c8eaecSKazu Hirata       NewRecipe->insertBefore(&Ingredient);
8776afbf60SFlorian Hahn       if (NewRecipe->getNumDefinedValues() == 1)
88a0e1313cSFlorian Hahn         VPV->replaceAllUsesWith(NewRecipe->getVPSingleValue());
8976afbf60SFlorian Hahn       else
9076afbf60SFlorian Hahn         assert(NewRecipe->getNumDefinedValues() == 0 &&
9176afbf60SFlorian Hahn                "Only recpies with zero or one defined values expected");
9224c8eaecSKazu Hirata       Ingredient.eraseFromParent();
9354a14c26SFlorian Hahn       Plan->removeVPValueFor(Inst);
9454a14c26SFlorian Hahn       for (auto *Def : NewRecipe->definedValues()) {
9554a14c26SFlorian Hahn         Plan->addVPValue(Inst, Def);
9654a14c26SFlorian Hahn       }
97e60b36cfSFlorian Hahn     }
98e60b36cfSFlorian Hahn   }
99e60b36cfSFlorian Hahn }
10065d3dd7cSFlorian Hahn 
10165d3dd7cSFlorian Hahn bool VPlanTransforms::sinkScalarOperands(VPlan &Plan) {
10265d3dd7cSFlorian Hahn   auto Iter = depth_first(
10365d3dd7cSFlorian Hahn       VPBlockRecursiveTraversalWrapper<VPBlockBase *>(Plan.getEntry()));
10465d3dd7cSFlorian Hahn   bool Changed = false;
10565d3dd7cSFlorian Hahn   // First, collect the operands of all predicated replicate recipes as seeds
10665d3dd7cSFlorian Hahn   // for sinking.
1077359450eSFlorian Hahn   SetVector<std::pair<VPBasicBlock *, VPValue *>> WorkList;
10865d3dd7cSFlorian Hahn   for (VPBasicBlock *VPBB : VPBlockUtils::blocksOnly<VPBasicBlock>(Iter)) {
10965d3dd7cSFlorian Hahn     for (auto &Recipe : *VPBB) {
11065d3dd7cSFlorian Hahn       auto *RepR = dyn_cast<VPReplicateRecipe>(&Recipe);
11165d3dd7cSFlorian Hahn       if (!RepR || !RepR->isPredicated())
11265d3dd7cSFlorian Hahn         continue;
1137359450eSFlorian Hahn       for (VPValue *Op : RepR->operands())
1147359450eSFlorian Hahn         WorkList.insert(std::make_pair(RepR->getParent(), Op));
11565d3dd7cSFlorian Hahn     }
11665d3dd7cSFlorian Hahn   }
11765d3dd7cSFlorian Hahn 
11865d3dd7cSFlorian Hahn   // Try to sink each replicate recipe in the worklist.
11965d3dd7cSFlorian Hahn   while (!WorkList.empty()) {
1207359450eSFlorian Hahn     VPBasicBlock *SinkTo;
1217359450eSFlorian Hahn     VPValue *C;
1227359450eSFlorian Hahn     std::tie(SinkTo, C) = WorkList.pop_back_val();
12365d3dd7cSFlorian Hahn     auto *SinkCandidate = dyn_cast_or_null<VPReplicateRecipe>(C->Def);
1247359450eSFlorian Hahn     if (!SinkCandidate || SinkCandidate->isUniform() ||
1257359450eSFlorian Hahn         SinkCandidate->getParent() == SinkTo ||
12665d3dd7cSFlorian Hahn         SinkCandidate->mayHaveSideEffects() ||
12765d3dd7cSFlorian Hahn         SinkCandidate->mayReadOrWriteMemory())
12865d3dd7cSFlorian Hahn       continue;
12965d3dd7cSFlorian Hahn 
130e90d55e1SFlorian Hahn     bool NeedsDuplicating = false;
131e90d55e1SFlorian Hahn     // All recipe users of the sink candidate must be in the same block SinkTo
132e90d55e1SFlorian Hahn     // or all users outside of SinkTo must be uniform-after-vectorization (
133e90d55e1SFlorian Hahn     // i.e., only first lane is used) . In the latter case, we need to duplicate
134e90d55e1SFlorian Hahn     // SinkCandidate. At the moment, we identify such UAV's by looking for the
135e90d55e1SFlorian Hahn     // address operands of widened memory recipes.
136e90d55e1SFlorian Hahn     auto CanSinkWithUser = [SinkTo, &NeedsDuplicating,
137e90d55e1SFlorian Hahn                             SinkCandidate](VPUser *U) {
13865d3dd7cSFlorian Hahn       auto *UI = dyn_cast<VPRecipeBase>(U);
139e90d55e1SFlorian Hahn       if (!UI)
140e90d55e1SFlorian Hahn         return false;
141e90d55e1SFlorian Hahn       if (UI->getParent() == SinkTo)
142e90d55e1SFlorian Hahn         return true;
143e90d55e1SFlorian Hahn       auto *WidenI = dyn_cast<VPWidenMemoryInstructionRecipe>(UI);
144e90d55e1SFlorian Hahn       if (WidenI && WidenI->getAddr() == SinkCandidate) {
145e90d55e1SFlorian Hahn         NeedsDuplicating = true;
146e90d55e1SFlorian Hahn         return true;
147e90d55e1SFlorian Hahn       }
148e90d55e1SFlorian Hahn       return false;
149e90d55e1SFlorian Hahn     };
150e90d55e1SFlorian Hahn     if (!all_of(SinkCandidate->users(), CanSinkWithUser))
15165d3dd7cSFlorian Hahn       continue;
15265d3dd7cSFlorian Hahn 
153e90d55e1SFlorian Hahn     if (NeedsDuplicating) {
154e90d55e1SFlorian Hahn       Instruction *I = cast<Instruction>(SinkCandidate->getUnderlyingValue());
155e90d55e1SFlorian Hahn       auto *Clone =
156e90d55e1SFlorian Hahn           new VPReplicateRecipe(I, SinkCandidate->operands(), true, false);
157e90d55e1SFlorian Hahn       // TODO: add ".cloned" suffix to name of Clone's VPValue.
158e90d55e1SFlorian Hahn 
159e90d55e1SFlorian Hahn       Clone->insertBefore(SinkCandidate);
160e90d55e1SFlorian Hahn       SmallVector<VPUser *, 4> Users(SinkCandidate->user_begin(),
161e90d55e1SFlorian Hahn                                      SinkCandidate->user_end());
162e90d55e1SFlorian Hahn       for (auto *U : Users) {
163e90d55e1SFlorian Hahn         auto *UI = cast<VPRecipeBase>(U);
164e90d55e1SFlorian Hahn         if (UI->getParent() == SinkTo)
165e90d55e1SFlorian Hahn           continue;
166e90d55e1SFlorian Hahn 
167e90d55e1SFlorian Hahn         for (unsigned Idx = 0; Idx != UI->getNumOperands(); Idx++) {
168e90d55e1SFlorian Hahn           if (UI->getOperand(Idx) != SinkCandidate)
169e90d55e1SFlorian Hahn             continue;
170e90d55e1SFlorian Hahn           UI->setOperand(Idx, Clone);
171e90d55e1SFlorian Hahn         }
172e90d55e1SFlorian Hahn       }
173e90d55e1SFlorian Hahn     }
17465d3dd7cSFlorian Hahn     SinkCandidate->moveBefore(*SinkTo, SinkTo->getFirstNonPhi());
1757359450eSFlorian Hahn     for (VPValue *Op : SinkCandidate->operands())
1767359450eSFlorian Hahn       WorkList.insert(std::make_pair(SinkTo, Op));
17765d3dd7cSFlorian Hahn     Changed = true;
17865d3dd7cSFlorian Hahn   }
17965d3dd7cSFlorian Hahn   return Changed;
18065d3dd7cSFlorian Hahn }
18180aa7e14SFlorian Hahn 
18280aa7e14SFlorian Hahn /// If \p R is a region with a VPBranchOnMaskRecipe in the entry block, return
18380aa7e14SFlorian Hahn /// the mask.
18480aa7e14SFlorian Hahn VPValue *getPredicatedMask(VPRegionBlock *R) {
18580aa7e14SFlorian Hahn   auto *EntryBB = dyn_cast<VPBasicBlock>(R->getEntry());
18680aa7e14SFlorian Hahn   if (!EntryBB || EntryBB->size() != 1 ||
18780aa7e14SFlorian Hahn       !isa<VPBranchOnMaskRecipe>(EntryBB->begin()))
18880aa7e14SFlorian Hahn     return nullptr;
18980aa7e14SFlorian Hahn 
19080aa7e14SFlorian Hahn   return cast<VPBranchOnMaskRecipe>(&*EntryBB->begin())->getOperand(0);
19180aa7e14SFlorian Hahn }
19280aa7e14SFlorian Hahn 
19380aa7e14SFlorian Hahn /// If \p R is a triangle region, return the 'then' block of the triangle.
19480aa7e14SFlorian Hahn static VPBasicBlock *getPredicatedThenBlock(VPRegionBlock *R) {
19580aa7e14SFlorian Hahn   auto *EntryBB = cast<VPBasicBlock>(R->getEntry());
19680aa7e14SFlorian Hahn   if (EntryBB->getNumSuccessors() != 2)
19780aa7e14SFlorian Hahn     return nullptr;
19880aa7e14SFlorian Hahn 
19980aa7e14SFlorian Hahn   auto *Succ0 = dyn_cast<VPBasicBlock>(EntryBB->getSuccessors()[0]);
20080aa7e14SFlorian Hahn   auto *Succ1 = dyn_cast<VPBasicBlock>(EntryBB->getSuccessors()[1]);
20180aa7e14SFlorian Hahn   if (!Succ0 || !Succ1)
20280aa7e14SFlorian Hahn     return nullptr;
20380aa7e14SFlorian Hahn 
20480aa7e14SFlorian Hahn   if (Succ0->getNumSuccessors() + Succ1->getNumSuccessors() != 1)
20580aa7e14SFlorian Hahn     return nullptr;
20680aa7e14SFlorian Hahn   if (Succ0->getSingleSuccessor() == Succ1)
20780aa7e14SFlorian Hahn     return Succ0;
20880aa7e14SFlorian Hahn   if (Succ1->getSingleSuccessor() == Succ0)
20980aa7e14SFlorian Hahn     return Succ1;
21080aa7e14SFlorian Hahn   return nullptr;
21180aa7e14SFlorian Hahn }
21280aa7e14SFlorian Hahn 
21380aa7e14SFlorian Hahn bool VPlanTransforms::mergeReplicateRegions(VPlan &Plan) {
21480aa7e14SFlorian Hahn   SetVector<VPRegionBlock *> DeletedRegions;
21580aa7e14SFlorian Hahn   bool Changed = false;
21680aa7e14SFlorian Hahn 
21780aa7e14SFlorian Hahn   // Collect region blocks to process up-front, to avoid iterator invalidation
21880aa7e14SFlorian Hahn   // issues while merging regions.
21980aa7e14SFlorian Hahn   SmallVector<VPRegionBlock *, 8> CandidateRegions(
22080aa7e14SFlorian Hahn       VPBlockUtils::blocksOnly<VPRegionBlock>(depth_first(
22180aa7e14SFlorian Hahn           VPBlockRecursiveTraversalWrapper<VPBlockBase *>(Plan.getEntry()))));
22280aa7e14SFlorian Hahn 
22380aa7e14SFlorian Hahn   // Check if Base is a predicated triangle, followed by an empty block,
22480aa7e14SFlorian Hahn   // followed by another predicate triangle. If that's the case, move the
22580aa7e14SFlorian Hahn   // recipes from the first to the second triangle.
22680aa7e14SFlorian Hahn   for (VPRegionBlock *Region1 : CandidateRegions) {
22780aa7e14SFlorian Hahn     if (DeletedRegions.contains(Region1))
22880aa7e14SFlorian Hahn       continue;
22980aa7e14SFlorian Hahn     auto *MiddleBasicBlock =
23080aa7e14SFlorian Hahn         dyn_cast_or_null<VPBasicBlock>(Region1->getSingleSuccessor());
23180aa7e14SFlorian Hahn     if (!MiddleBasicBlock || !MiddleBasicBlock->empty())
23280aa7e14SFlorian Hahn       continue;
23380aa7e14SFlorian Hahn 
23480aa7e14SFlorian Hahn     auto *Region2 =
23580aa7e14SFlorian Hahn         dyn_cast_or_null<VPRegionBlock>(MiddleBasicBlock->getSingleSuccessor());
23680aa7e14SFlorian Hahn     if (!Region2)
23780aa7e14SFlorian Hahn       continue;
23880aa7e14SFlorian Hahn 
23980aa7e14SFlorian Hahn     VPValue *Mask1 = getPredicatedMask(Region1);
24080aa7e14SFlorian Hahn     VPValue *Mask2 = getPredicatedMask(Region2);
24180aa7e14SFlorian Hahn     if (!Mask1 || Mask1 != Mask2)
24280aa7e14SFlorian Hahn       continue;
24380aa7e14SFlorian Hahn     VPBasicBlock *Then1 = getPredicatedThenBlock(Region1);
24480aa7e14SFlorian Hahn     VPBasicBlock *Then2 = getPredicatedThenBlock(Region2);
24580aa7e14SFlorian Hahn     if (!Then1 || !Then2)
24680aa7e14SFlorian Hahn       continue;
24780aa7e14SFlorian Hahn 
24880aa7e14SFlorian Hahn     assert(Mask1 && Mask2 && "both region must have conditions");
24980aa7e14SFlorian Hahn 
25080aa7e14SFlorian Hahn     // Note: No fusion-preventing memory dependencies are expected in either
25180aa7e14SFlorian Hahn     // region. Such dependencies should be rejected during earlier dependence
25280aa7e14SFlorian Hahn     // checks, which guarantee accesses can be re-ordered for vectorization.
25380aa7e14SFlorian Hahn     //
25480aa7e14SFlorian Hahn     // Move recipes to the successor region.
25580aa7e14SFlorian Hahn     for (VPRecipeBase &ToMove : make_early_inc_range(reverse(*Then1)))
25680aa7e14SFlorian Hahn       ToMove.moveBefore(*Then2, Then2->getFirstNonPhi());
25780aa7e14SFlorian Hahn 
25880aa7e14SFlorian Hahn     auto *Merge1 = cast<VPBasicBlock>(Then1->getSingleSuccessor());
25980aa7e14SFlorian Hahn     auto *Merge2 = cast<VPBasicBlock>(Then2->getSingleSuccessor());
26080aa7e14SFlorian Hahn 
26180aa7e14SFlorian Hahn     // Move VPPredInstPHIRecipes from the merge block to the successor region's
26280aa7e14SFlorian Hahn     // merge block. Update all users inside the successor region to use the
26380aa7e14SFlorian Hahn     // original values.
26480aa7e14SFlorian Hahn     for (VPRecipeBase &Phi1ToMove : make_early_inc_range(reverse(*Merge1))) {
26580aa7e14SFlorian Hahn       VPValue *PredInst1 =
26680aa7e14SFlorian Hahn           cast<VPPredInstPHIRecipe>(&Phi1ToMove)->getOperand(0);
267368af755SFlorian Hahn       VPValue *Phi1ToMoveV = Phi1ToMove.getVPSingleValue();
268368af755SFlorian Hahn       SmallVector<VPUser *> Users(Phi1ToMoveV->user_begin(),
269368af755SFlorian Hahn                                   Phi1ToMoveV->user_end());
270368af755SFlorian Hahn       for (VPUser *U : Users) {
27180aa7e14SFlorian Hahn         auto *UI = dyn_cast<VPRecipeBase>(U);
27280aa7e14SFlorian Hahn         if (!UI || UI->getParent() != Then2)
27380aa7e14SFlorian Hahn           continue;
27480aa7e14SFlorian Hahn         for (unsigned I = 0, E = U->getNumOperands(); I != E; ++I) {
275368af755SFlorian Hahn           if (Phi1ToMoveV != U->getOperand(I))
27680aa7e14SFlorian Hahn             continue;
27780aa7e14SFlorian Hahn           U->setOperand(I, PredInst1);
27880aa7e14SFlorian Hahn         }
27980aa7e14SFlorian Hahn       }
28080aa7e14SFlorian Hahn 
28180aa7e14SFlorian Hahn       Phi1ToMove.moveBefore(*Merge2, Merge2->begin());
28280aa7e14SFlorian Hahn     }
28380aa7e14SFlorian Hahn 
28480aa7e14SFlorian Hahn     // Finally, remove the first region.
28580aa7e14SFlorian Hahn     for (VPBlockBase *Pred : make_early_inc_range(Region1->getPredecessors())) {
28680aa7e14SFlorian Hahn       VPBlockUtils::disconnectBlocks(Pred, Region1);
28780aa7e14SFlorian Hahn       VPBlockUtils::connectBlocks(Pred, MiddleBasicBlock);
28880aa7e14SFlorian Hahn     }
28980aa7e14SFlorian Hahn     VPBlockUtils::disconnectBlocks(Region1, MiddleBasicBlock);
29080aa7e14SFlorian Hahn     DeletedRegions.insert(Region1);
29180aa7e14SFlorian Hahn   }
29280aa7e14SFlorian Hahn 
29380aa7e14SFlorian Hahn   for (VPRegionBlock *ToDelete : DeletedRegions)
29480aa7e14SFlorian Hahn     delete ToDelete;
29580aa7e14SFlorian Hahn   return Changed;
29680aa7e14SFlorian Hahn }
297