1 //===- InstCombineSelect.cpp ----------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitSelect function. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APInt.h" 15 #include "llvm/ADT/Optional.h" 16 #include "llvm/ADT/STLExtras.h" 17 #include "llvm/ADT/SmallVector.h" 18 #include "llvm/Analysis/AssumptionCache.h" 19 #include "llvm/Analysis/CmpInstAnalysis.h" 20 #include "llvm/Analysis/InstructionSimplify.h" 21 #include "llvm/Analysis/OverflowInstAnalysis.h" 22 #include "llvm/Analysis/ValueTracking.h" 23 #include "llvm/IR/BasicBlock.h" 24 #include "llvm/IR/Constant.h" 25 #include "llvm/IR/Constants.h" 26 #include "llvm/IR/DerivedTypes.h" 27 #include "llvm/IR/IRBuilder.h" 28 #include "llvm/IR/InstrTypes.h" 29 #include "llvm/IR/Instruction.h" 30 #include "llvm/IR/Instructions.h" 31 #include "llvm/IR/IntrinsicInst.h" 32 #include "llvm/IR/Intrinsics.h" 33 #include "llvm/IR/Operator.h" 34 #include "llvm/IR/PatternMatch.h" 35 #include "llvm/IR/Type.h" 36 #include "llvm/IR/User.h" 37 #include "llvm/IR/Value.h" 38 #include "llvm/Support/Casting.h" 39 #include "llvm/Support/ErrorHandling.h" 40 #include "llvm/Support/KnownBits.h" 41 #include "llvm/Transforms/InstCombine/InstCombiner.h" 42 #include <cassert> 43 #include <utility> 44 45 #define DEBUG_TYPE "instcombine" 46 #include "llvm/Transforms/Utils/InstructionWorklist.h" 47 48 using namespace llvm; 49 using namespace PatternMatch; 50 51 52 static Value *createMinMax(InstCombiner::BuilderTy &Builder, 53 SelectPatternFlavor SPF, Value *A, Value *B) { 54 CmpInst::Predicate Pred = getMinMaxPred(SPF); 55 assert(CmpInst::isIntPredicate(Pred) && "Expected integer predicate"); 56 return Builder.CreateSelect(Builder.CreateICmp(Pred, A, B), A, B); 57 } 58 59 /// Replace a select operand based on an equality comparison with the identity 60 /// constant of a binop. 61 static Instruction *foldSelectBinOpIdentity(SelectInst &Sel, 62 const TargetLibraryInfo &TLI, 63 InstCombinerImpl &IC) { 64 // The select condition must be an equality compare with a constant operand. 65 Value *X; 66 Constant *C; 67 CmpInst::Predicate Pred; 68 if (!match(Sel.getCondition(), m_Cmp(Pred, m_Value(X), m_Constant(C)))) 69 return nullptr; 70 71 bool IsEq; 72 if (ICmpInst::isEquality(Pred)) 73 IsEq = Pred == ICmpInst::ICMP_EQ; 74 else if (Pred == FCmpInst::FCMP_OEQ) 75 IsEq = true; 76 else if (Pred == FCmpInst::FCMP_UNE) 77 IsEq = false; 78 else 79 return nullptr; 80 81 // A select operand must be a binop. 82 BinaryOperator *BO; 83 if (!match(Sel.getOperand(IsEq ? 1 : 2), m_BinOp(BO))) 84 return nullptr; 85 86 // The compare constant must be the identity constant for that binop. 87 // If this a floating-point compare with 0.0, any zero constant will do. 88 Type *Ty = BO->getType(); 89 Constant *IdC = ConstantExpr::getBinOpIdentity(BO->getOpcode(), Ty, true); 90 if (IdC != C) { 91 if (!IdC || !CmpInst::isFPPredicate(Pred)) 92 return nullptr; 93 if (!match(IdC, m_AnyZeroFP()) || !match(C, m_AnyZeroFP())) 94 return nullptr; 95 } 96 97 // Last, match the compare variable operand with a binop operand. 98 Value *Y; 99 if (!BO->isCommutative() && !match(BO, m_BinOp(m_Value(Y), m_Specific(X)))) 100 return nullptr; 101 if (!match(BO, m_c_BinOp(m_Value(Y), m_Specific(X)))) 102 return nullptr; 103 104 // +0.0 compares equal to -0.0, and so it does not behave as required for this 105 // transform. Bail out if we can not exclude that possibility. 106 if (isa<FPMathOperator>(BO)) 107 if (!BO->hasNoSignedZeros() && !CannotBeNegativeZero(Y, &TLI)) 108 return nullptr; 109 110 // BO = binop Y, X 111 // S = { select (cmp eq X, C), BO, ? } or { select (cmp ne X, C), ?, BO } 112 // => 113 // S = { select (cmp eq X, C), Y, ? } or { select (cmp ne X, C), ?, Y } 114 return IC.replaceOperand(Sel, IsEq ? 1 : 2, Y); 115 } 116 117 /// This folds: 118 /// select (icmp eq (and X, C1)), TC, FC 119 /// iff C1 is a power 2 and the difference between TC and FC is a power-of-2. 120 /// To something like: 121 /// (shr (and (X, C1)), (log2(C1) - log2(TC-FC))) + FC 122 /// Or: 123 /// (shl (and (X, C1)), (log2(TC-FC) - log2(C1))) + FC 124 /// With some variations depending if FC is larger than TC, or the shift 125 /// isn't needed, or the bit widths don't match. 126 static Value *foldSelectICmpAnd(SelectInst &Sel, ICmpInst *Cmp, 127 InstCombiner::BuilderTy &Builder) { 128 const APInt *SelTC, *SelFC; 129 if (!match(Sel.getTrueValue(), m_APInt(SelTC)) || 130 !match(Sel.getFalseValue(), m_APInt(SelFC))) 131 return nullptr; 132 133 // If this is a vector select, we need a vector compare. 134 Type *SelType = Sel.getType(); 135 if (SelType->isVectorTy() != Cmp->getType()->isVectorTy()) 136 return nullptr; 137 138 Value *V; 139 APInt AndMask; 140 bool CreateAnd = false; 141 ICmpInst::Predicate Pred = Cmp->getPredicate(); 142 if (ICmpInst::isEquality(Pred)) { 143 if (!match(Cmp->getOperand(1), m_Zero())) 144 return nullptr; 145 146 V = Cmp->getOperand(0); 147 const APInt *AndRHS; 148 if (!match(V, m_And(m_Value(), m_Power2(AndRHS)))) 149 return nullptr; 150 151 AndMask = *AndRHS; 152 } else if (decomposeBitTestICmp(Cmp->getOperand(0), Cmp->getOperand(1), 153 Pred, V, AndMask)) { 154 assert(ICmpInst::isEquality(Pred) && "Not equality test?"); 155 if (!AndMask.isPowerOf2()) 156 return nullptr; 157 158 CreateAnd = true; 159 } else { 160 return nullptr; 161 } 162 163 // In general, when both constants are non-zero, we would need an offset to 164 // replace the select. This would require more instructions than we started 165 // with. But there's one special-case that we handle here because it can 166 // simplify/reduce the instructions. 167 APInt TC = *SelTC; 168 APInt FC = *SelFC; 169 if (!TC.isZero() && !FC.isZero()) { 170 // If the select constants differ by exactly one bit and that's the same 171 // bit that is masked and checked by the select condition, the select can 172 // be replaced by bitwise logic to set/clear one bit of the constant result. 173 if (TC.getBitWidth() != AndMask.getBitWidth() || (TC ^ FC) != AndMask) 174 return nullptr; 175 if (CreateAnd) { 176 // If we have to create an 'and', then we must kill the cmp to not 177 // increase the instruction count. 178 if (!Cmp->hasOneUse()) 179 return nullptr; 180 V = Builder.CreateAnd(V, ConstantInt::get(SelType, AndMask)); 181 } 182 bool ExtraBitInTC = TC.ugt(FC); 183 if (Pred == ICmpInst::ICMP_EQ) { 184 // If the masked bit in V is clear, clear or set the bit in the result: 185 // (V & AndMaskC) == 0 ? TC : FC --> (V & AndMaskC) ^ TC 186 // (V & AndMaskC) == 0 ? TC : FC --> (V & AndMaskC) | TC 187 Constant *C = ConstantInt::get(SelType, TC); 188 return ExtraBitInTC ? Builder.CreateXor(V, C) : Builder.CreateOr(V, C); 189 } 190 if (Pred == ICmpInst::ICMP_NE) { 191 // If the masked bit in V is set, set or clear the bit in the result: 192 // (V & AndMaskC) != 0 ? TC : FC --> (V & AndMaskC) | FC 193 // (V & AndMaskC) != 0 ? TC : FC --> (V & AndMaskC) ^ FC 194 Constant *C = ConstantInt::get(SelType, FC); 195 return ExtraBitInTC ? Builder.CreateOr(V, C) : Builder.CreateXor(V, C); 196 } 197 llvm_unreachable("Only expecting equality predicates"); 198 } 199 200 // Make sure one of the select arms is a power-of-2. 201 if (!TC.isPowerOf2() && !FC.isPowerOf2()) 202 return nullptr; 203 204 // Determine which shift is needed to transform result of the 'and' into the 205 // desired result. 206 const APInt &ValC = !TC.isZero() ? TC : FC; 207 unsigned ValZeros = ValC.logBase2(); 208 unsigned AndZeros = AndMask.logBase2(); 209 210 // Insert the 'and' instruction on the input to the truncate. 211 if (CreateAnd) 212 V = Builder.CreateAnd(V, ConstantInt::get(V->getType(), AndMask)); 213 214 // If types don't match, we can still convert the select by introducing a zext 215 // or a trunc of the 'and'. 216 if (ValZeros > AndZeros) { 217 V = Builder.CreateZExtOrTrunc(V, SelType); 218 V = Builder.CreateShl(V, ValZeros - AndZeros); 219 } else if (ValZeros < AndZeros) { 220 V = Builder.CreateLShr(V, AndZeros - ValZeros); 221 V = Builder.CreateZExtOrTrunc(V, SelType); 222 } else { 223 V = Builder.CreateZExtOrTrunc(V, SelType); 224 } 225 226 // Okay, now we know that everything is set up, we just don't know whether we 227 // have a icmp_ne or icmp_eq and whether the true or false val is the zero. 228 bool ShouldNotVal = !TC.isZero(); 229 ShouldNotVal ^= Pred == ICmpInst::ICMP_NE; 230 if (ShouldNotVal) 231 V = Builder.CreateXor(V, ValC); 232 233 return V; 234 } 235 236 /// We want to turn code that looks like this: 237 /// %C = or %A, %B 238 /// %D = select %cond, %C, %A 239 /// into: 240 /// %C = select %cond, %B, 0 241 /// %D = or %A, %C 242 /// 243 /// Assuming that the specified instruction is an operand to the select, return 244 /// a bitmask indicating which operands of this instruction are foldable if they 245 /// equal the other incoming value of the select. 246 static unsigned getSelectFoldableOperands(BinaryOperator *I) { 247 switch (I->getOpcode()) { 248 case Instruction::Add: 249 case Instruction::Mul: 250 case Instruction::And: 251 case Instruction::Or: 252 case Instruction::Xor: 253 return 3; // Can fold through either operand. 254 case Instruction::Sub: // Can only fold on the amount subtracted. 255 case Instruction::Shl: // Can only fold on the shift amount. 256 case Instruction::LShr: 257 case Instruction::AShr: 258 return 1; 259 default: 260 return 0; // Cannot fold 261 } 262 } 263 264 /// We have (select c, TI, FI), and we know that TI and FI have the same opcode. 265 Instruction *InstCombinerImpl::foldSelectOpOp(SelectInst &SI, Instruction *TI, 266 Instruction *FI) { 267 // Don't break up min/max patterns. The hasOneUse checks below prevent that 268 // for most cases, but vector min/max with bitcasts can be transformed. If the 269 // one-use restrictions are eased for other patterns, we still don't want to 270 // obfuscate min/max. 271 if ((match(&SI, m_SMin(m_Value(), m_Value())) || 272 match(&SI, m_SMax(m_Value(), m_Value())) || 273 match(&SI, m_UMin(m_Value(), m_Value())) || 274 match(&SI, m_UMax(m_Value(), m_Value())))) 275 return nullptr; 276 277 // If this is a cast from the same type, merge. 278 Value *Cond = SI.getCondition(); 279 Type *CondTy = Cond->getType(); 280 if (TI->getNumOperands() == 1 && TI->isCast()) { 281 Type *FIOpndTy = FI->getOperand(0)->getType(); 282 if (TI->getOperand(0)->getType() != FIOpndTy) 283 return nullptr; 284 285 // The select condition may be a vector. We may only change the operand 286 // type if the vector width remains the same (and matches the condition). 287 if (auto *CondVTy = dyn_cast<VectorType>(CondTy)) { 288 if (!FIOpndTy->isVectorTy() || 289 CondVTy->getElementCount() != 290 cast<VectorType>(FIOpndTy)->getElementCount()) 291 return nullptr; 292 293 // TODO: If the backend knew how to deal with casts better, we could 294 // remove this limitation. For now, there's too much potential to create 295 // worse codegen by promoting the select ahead of size-altering casts 296 // (PR28160). 297 // 298 // Note that ValueTracking's matchSelectPattern() looks through casts 299 // without checking 'hasOneUse' when it matches min/max patterns, so this 300 // transform may end up happening anyway. 301 if (TI->getOpcode() != Instruction::BitCast && 302 (!TI->hasOneUse() || !FI->hasOneUse())) 303 return nullptr; 304 } else if (!TI->hasOneUse() || !FI->hasOneUse()) { 305 // TODO: The one-use restrictions for a scalar select could be eased if 306 // the fold of a select in visitLoadInst() was enhanced to match a pattern 307 // that includes a cast. 308 return nullptr; 309 } 310 311 // Fold this by inserting a select from the input values. 312 Value *NewSI = 313 Builder.CreateSelect(Cond, TI->getOperand(0), FI->getOperand(0), 314 SI.getName() + ".v", &SI); 315 return CastInst::Create(Instruction::CastOps(TI->getOpcode()), NewSI, 316 TI->getType()); 317 } 318 319 // Cond ? -X : -Y --> -(Cond ? X : Y) 320 Value *X, *Y; 321 if (match(TI, m_FNeg(m_Value(X))) && match(FI, m_FNeg(m_Value(Y))) && 322 (TI->hasOneUse() || FI->hasOneUse())) { 323 // Intersect FMF from the fneg instructions and union those with the select. 324 FastMathFlags FMF = TI->getFastMathFlags(); 325 FMF &= FI->getFastMathFlags(); 326 FMF |= SI.getFastMathFlags(); 327 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); 328 if (auto *NewSelI = dyn_cast<Instruction>(NewSel)) 329 NewSelI->setFastMathFlags(FMF); 330 Instruction *NewFNeg = UnaryOperator::CreateFNeg(NewSel); 331 NewFNeg->setFastMathFlags(FMF); 332 return NewFNeg; 333 } 334 335 // Min/max intrinsic with a common operand can have the common operand pulled 336 // after the select. This is the same transform as below for binops, but 337 // specialized for intrinsic matching and without the restrictive uses clause. 338 auto *TII = dyn_cast<IntrinsicInst>(TI); 339 auto *FII = dyn_cast<IntrinsicInst>(FI); 340 if (TII && FII && TII->getIntrinsicID() == FII->getIntrinsicID() && 341 (TII->hasOneUse() || FII->hasOneUse())) { 342 Value *T0, *T1, *F0, *F1; 343 if (match(TII, m_MaxOrMin(m_Value(T0), m_Value(T1))) && 344 match(FII, m_MaxOrMin(m_Value(F0), m_Value(F1)))) { 345 if (T0 == F0) { 346 Value *NewSel = Builder.CreateSelect(Cond, T1, F1, "minmaxop", &SI); 347 return CallInst::Create(TII->getCalledFunction(), {NewSel, T0}); 348 } 349 if (T0 == F1) { 350 Value *NewSel = Builder.CreateSelect(Cond, T1, F0, "minmaxop", &SI); 351 return CallInst::Create(TII->getCalledFunction(), {NewSel, T0}); 352 } 353 if (T1 == F0) { 354 Value *NewSel = Builder.CreateSelect(Cond, T0, F1, "minmaxop", &SI); 355 return CallInst::Create(TII->getCalledFunction(), {NewSel, T1}); 356 } 357 if (T1 == F1) { 358 Value *NewSel = Builder.CreateSelect(Cond, T0, F0, "minmaxop", &SI); 359 return CallInst::Create(TII->getCalledFunction(), {NewSel, T1}); 360 } 361 } 362 } 363 364 // Only handle binary operators (including two-operand getelementptr) with 365 // one-use here. As with the cast case above, it may be possible to relax the 366 // one-use constraint, but that needs be examined carefully since it may not 367 // reduce the total number of instructions. 368 if (TI->getNumOperands() != 2 || FI->getNumOperands() != 2 || 369 (!isa<BinaryOperator>(TI) && !isa<GetElementPtrInst>(TI)) || 370 !TI->hasOneUse() || !FI->hasOneUse()) 371 return nullptr; 372 373 // Figure out if the operations have any operands in common. 374 Value *MatchOp, *OtherOpT, *OtherOpF; 375 bool MatchIsOpZero; 376 if (TI->getOperand(0) == FI->getOperand(0)) { 377 MatchOp = TI->getOperand(0); 378 OtherOpT = TI->getOperand(1); 379 OtherOpF = FI->getOperand(1); 380 MatchIsOpZero = true; 381 } else if (TI->getOperand(1) == FI->getOperand(1)) { 382 MatchOp = TI->getOperand(1); 383 OtherOpT = TI->getOperand(0); 384 OtherOpF = FI->getOperand(0); 385 MatchIsOpZero = false; 386 } else if (!TI->isCommutative()) { 387 return nullptr; 388 } else if (TI->getOperand(0) == FI->getOperand(1)) { 389 MatchOp = TI->getOperand(0); 390 OtherOpT = TI->getOperand(1); 391 OtherOpF = FI->getOperand(0); 392 MatchIsOpZero = true; 393 } else if (TI->getOperand(1) == FI->getOperand(0)) { 394 MatchOp = TI->getOperand(1); 395 OtherOpT = TI->getOperand(0); 396 OtherOpF = FI->getOperand(1); 397 MatchIsOpZero = true; 398 } else { 399 return nullptr; 400 } 401 402 // If the select condition is a vector, the operands of the original select's 403 // operands also must be vectors. This may not be the case for getelementptr 404 // for example. 405 if (CondTy->isVectorTy() && (!OtherOpT->getType()->isVectorTy() || 406 !OtherOpF->getType()->isVectorTy())) 407 return nullptr; 408 409 // If we reach here, they do have operations in common. 410 Value *NewSI = Builder.CreateSelect(Cond, OtherOpT, OtherOpF, 411 SI.getName() + ".v", &SI); 412 Value *Op0 = MatchIsOpZero ? MatchOp : NewSI; 413 Value *Op1 = MatchIsOpZero ? NewSI : MatchOp; 414 if (auto *BO = dyn_cast<BinaryOperator>(TI)) { 415 BinaryOperator *NewBO = BinaryOperator::Create(BO->getOpcode(), Op0, Op1); 416 NewBO->copyIRFlags(TI); 417 NewBO->andIRFlags(FI); 418 return NewBO; 419 } 420 if (auto *TGEP = dyn_cast<GetElementPtrInst>(TI)) { 421 auto *FGEP = cast<GetElementPtrInst>(FI); 422 Type *ElementType = TGEP->getResultElementType(); 423 return TGEP->isInBounds() && FGEP->isInBounds() 424 ? GetElementPtrInst::CreateInBounds(ElementType, Op0, {Op1}) 425 : GetElementPtrInst::Create(ElementType, Op0, {Op1}); 426 } 427 llvm_unreachable("Expected BinaryOperator or GEP"); 428 return nullptr; 429 } 430 431 static bool isSelect01(const APInt &C1I, const APInt &C2I) { 432 if (!C1I.isZero() && !C2I.isZero()) // One side must be zero. 433 return false; 434 return C1I.isOne() || C1I.isAllOnes() || C2I.isOne() || C2I.isAllOnes(); 435 } 436 437 /// Try to fold the select into one of the operands to allow further 438 /// optimization. 439 Instruction *InstCombinerImpl::foldSelectIntoOp(SelectInst &SI, Value *TrueVal, 440 Value *FalseVal) { 441 // See the comment above GetSelectFoldableOperands for a description of the 442 // transformation we are doing here. 443 if (auto *TVI = dyn_cast<BinaryOperator>(TrueVal)) { 444 if (TVI->hasOneUse() && !isa<Constant>(FalseVal)) { 445 if (unsigned SFO = getSelectFoldableOperands(TVI)) { 446 unsigned OpToFold = 0; 447 if ((SFO & 1) && FalseVal == TVI->getOperand(0)) { 448 OpToFold = 1; 449 } else if ((SFO & 2) && FalseVal == TVI->getOperand(1)) { 450 OpToFold = 2; 451 } 452 453 if (OpToFold) { 454 Constant *C = ConstantExpr::getBinOpIdentity(TVI->getOpcode(), 455 TVI->getType(), true); 456 Value *OOp = TVI->getOperand(2-OpToFold); 457 // Avoid creating select between 2 constants unless it's selecting 458 // between 0, 1 and -1. 459 const APInt *OOpC; 460 bool OOpIsAPInt = match(OOp, m_APInt(OOpC)); 461 if (!isa<Constant>(OOp) || 462 (OOpIsAPInt && isSelect01(C->getUniqueInteger(), *OOpC))) { 463 Value *NewSel = Builder.CreateSelect(SI.getCondition(), OOp, C); 464 NewSel->takeName(TVI); 465 BinaryOperator *BO = BinaryOperator::Create(TVI->getOpcode(), 466 FalseVal, NewSel); 467 BO->copyIRFlags(TVI); 468 return BO; 469 } 470 } 471 } 472 } 473 } 474 475 if (auto *FVI = dyn_cast<BinaryOperator>(FalseVal)) { 476 if (FVI->hasOneUse() && !isa<Constant>(TrueVal)) { 477 if (unsigned SFO = getSelectFoldableOperands(FVI)) { 478 unsigned OpToFold = 0; 479 if ((SFO & 1) && TrueVal == FVI->getOperand(0)) { 480 OpToFold = 1; 481 } else if ((SFO & 2) && TrueVal == FVI->getOperand(1)) { 482 OpToFold = 2; 483 } 484 485 if (OpToFold) { 486 Constant *C = ConstantExpr::getBinOpIdentity(FVI->getOpcode(), 487 FVI->getType(), true); 488 Value *OOp = FVI->getOperand(2-OpToFold); 489 // Avoid creating select between 2 constants unless it's selecting 490 // between 0, 1 and -1. 491 const APInt *OOpC; 492 bool OOpIsAPInt = match(OOp, m_APInt(OOpC)); 493 if (!isa<Constant>(OOp) || 494 (OOpIsAPInt && isSelect01(C->getUniqueInteger(), *OOpC))) { 495 Value *NewSel = Builder.CreateSelect(SI.getCondition(), C, OOp); 496 NewSel->takeName(FVI); 497 BinaryOperator *BO = BinaryOperator::Create(FVI->getOpcode(), 498 TrueVal, NewSel); 499 BO->copyIRFlags(FVI); 500 return BO; 501 } 502 } 503 } 504 } 505 } 506 507 return nullptr; 508 } 509 510 /// We want to turn: 511 /// (select (icmp eq (and X, Y), 0), (and (lshr X, Z), 1), 1) 512 /// into: 513 /// zext (icmp ne i32 (and X, (or Y, (shl 1, Z))), 0) 514 /// Note: 515 /// Z may be 0 if lshr is missing. 516 /// Worst-case scenario is that we will replace 5 instructions with 5 different 517 /// instructions, but we got rid of select. 518 static Instruction *foldSelectICmpAndAnd(Type *SelType, const ICmpInst *Cmp, 519 Value *TVal, Value *FVal, 520 InstCombiner::BuilderTy &Builder) { 521 if (!(Cmp->hasOneUse() && Cmp->getOperand(0)->hasOneUse() && 522 Cmp->getPredicate() == ICmpInst::ICMP_EQ && 523 match(Cmp->getOperand(1), m_Zero()) && match(FVal, m_One()))) 524 return nullptr; 525 526 // The TrueVal has general form of: and %B, 1 527 Value *B; 528 if (!match(TVal, m_OneUse(m_And(m_Value(B), m_One())))) 529 return nullptr; 530 531 // Where %B may be optionally shifted: lshr %X, %Z. 532 Value *X, *Z; 533 const bool HasShift = match(B, m_OneUse(m_LShr(m_Value(X), m_Value(Z)))); 534 if (!HasShift) 535 X = B; 536 537 Value *Y; 538 if (!match(Cmp->getOperand(0), m_c_And(m_Specific(X), m_Value(Y)))) 539 return nullptr; 540 541 // ((X & Y) == 0) ? ((X >> Z) & 1) : 1 --> (X & (Y | (1 << Z))) != 0 542 // ((X & Y) == 0) ? (X & 1) : 1 --> (X & (Y | 1)) != 0 543 Constant *One = ConstantInt::get(SelType, 1); 544 Value *MaskB = HasShift ? Builder.CreateShl(One, Z) : One; 545 Value *FullMask = Builder.CreateOr(Y, MaskB); 546 Value *MaskedX = Builder.CreateAnd(X, FullMask); 547 Value *ICmpNeZero = Builder.CreateIsNotNull(MaskedX); 548 return new ZExtInst(ICmpNeZero, SelType); 549 } 550 551 /// We want to turn: 552 /// (select (icmp sgt x, C), lshr (X, Y), ashr (X, Y)); iff C s>= -1 553 /// (select (icmp slt x, C), ashr (X, Y), lshr (X, Y)); iff C s>= 0 554 /// into: 555 /// ashr (X, Y) 556 static Value *foldSelectICmpLshrAshr(const ICmpInst *IC, Value *TrueVal, 557 Value *FalseVal, 558 InstCombiner::BuilderTy &Builder) { 559 ICmpInst::Predicate Pred = IC->getPredicate(); 560 Value *CmpLHS = IC->getOperand(0); 561 Value *CmpRHS = IC->getOperand(1); 562 if (!CmpRHS->getType()->isIntOrIntVectorTy()) 563 return nullptr; 564 565 Value *X, *Y; 566 unsigned Bitwidth = CmpRHS->getType()->getScalarSizeInBits(); 567 if ((Pred != ICmpInst::ICMP_SGT || 568 !match(CmpRHS, 569 m_SpecificInt_ICMP(ICmpInst::ICMP_SGE, APInt(Bitwidth, -1)))) && 570 (Pred != ICmpInst::ICMP_SLT || 571 !match(CmpRHS, 572 m_SpecificInt_ICMP(ICmpInst::ICMP_SGE, APInt(Bitwidth, 0))))) 573 return nullptr; 574 575 // Canonicalize so that ashr is in FalseVal. 576 if (Pred == ICmpInst::ICMP_SLT) 577 std::swap(TrueVal, FalseVal); 578 579 if (match(TrueVal, m_LShr(m_Value(X), m_Value(Y))) && 580 match(FalseVal, m_AShr(m_Specific(X), m_Specific(Y))) && 581 match(CmpLHS, m_Specific(X))) { 582 const auto *Ashr = cast<Instruction>(FalseVal); 583 // if lshr is not exact and ashr is, this new ashr must not be exact. 584 bool IsExact = Ashr->isExact() && cast<Instruction>(TrueVal)->isExact(); 585 return Builder.CreateAShr(X, Y, IC->getName(), IsExact); 586 } 587 588 return nullptr; 589 } 590 591 /// We want to turn: 592 /// (select (icmp eq (and X, C1), 0), Y, (or Y, C2)) 593 /// into: 594 /// (or (shl (and X, C1), C3), Y) 595 /// iff: 596 /// C1 and C2 are both powers of 2 597 /// where: 598 /// C3 = Log(C2) - Log(C1) 599 /// 600 /// This transform handles cases where: 601 /// 1. The icmp predicate is inverted 602 /// 2. The select operands are reversed 603 /// 3. The magnitude of C2 and C1 are flipped 604 static Value *foldSelectICmpAndOr(const ICmpInst *IC, Value *TrueVal, 605 Value *FalseVal, 606 InstCombiner::BuilderTy &Builder) { 607 // Only handle integer compares. Also, if this is a vector select, we need a 608 // vector compare. 609 if (!TrueVal->getType()->isIntOrIntVectorTy() || 610 TrueVal->getType()->isVectorTy() != IC->getType()->isVectorTy()) 611 return nullptr; 612 613 Value *CmpLHS = IC->getOperand(0); 614 Value *CmpRHS = IC->getOperand(1); 615 616 Value *V; 617 unsigned C1Log; 618 bool IsEqualZero; 619 bool NeedAnd = false; 620 if (IC->isEquality()) { 621 if (!match(CmpRHS, m_Zero())) 622 return nullptr; 623 624 const APInt *C1; 625 if (!match(CmpLHS, m_And(m_Value(), m_Power2(C1)))) 626 return nullptr; 627 628 V = CmpLHS; 629 C1Log = C1->logBase2(); 630 IsEqualZero = IC->getPredicate() == ICmpInst::ICMP_EQ; 631 } else if (IC->getPredicate() == ICmpInst::ICMP_SLT || 632 IC->getPredicate() == ICmpInst::ICMP_SGT) { 633 // We also need to recognize (icmp slt (trunc (X)), 0) and 634 // (icmp sgt (trunc (X)), -1). 635 IsEqualZero = IC->getPredicate() == ICmpInst::ICMP_SGT; 636 if ((IsEqualZero && !match(CmpRHS, m_AllOnes())) || 637 (!IsEqualZero && !match(CmpRHS, m_Zero()))) 638 return nullptr; 639 640 if (!match(CmpLHS, m_OneUse(m_Trunc(m_Value(V))))) 641 return nullptr; 642 643 C1Log = CmpLHS->getType()->getScalarSizeInBits() - 1; 644 NeedAnd = true; 645 } else { 646 return nullptr; 647 } 648 649 const APInt *C2; 650 bool OrOnTrueVal = false; 651 bool OrOnFalseVal = match(FalseVal, m_Or(m_Specific(TrueVal), m_Power2(C2))); 652 if (!OrOnFalseVal) 653 OrOnTrueVal = match(TrueVal, m_Or(m_Specific(FalseVal), m_Power2(C2))); 654 655 if (!OrOnFalseVal && !OrOnTrueVal) 656 return nullptr; 657 658 Value *Y = OrOnFalseVal ? TrueVal : FalseVal; 659 660 unsigned C2Log = C2->logBase2(); 661 662 bool NeedXor = (!IsEqualZero && OrOnFalseVal) || (IsEqualZero && OrOnTrueVal); 663 bool NeedShift = C1Log != C2Log; 664 bool NeedZExtTrunc = Y->getType()->getScalarSizeInBits() != 665 V->getType()->getScalarSizeInBits(); 666 667 // Make sure we don't create more instructions than we save. 668 Value *Or = OrOnFalseVal ? FalseVal : TrueVal; 669 if ((NeedShift + NeedXor + NeedZExtTrunc) > 670 (IC->hasOneUse() + Or->hasOneUse())) 671 return nullptr; 672 673 if (NeedAnd) { 674 // Insert the AND instruction on the input to the truncate. 675 APInt C1 = APInt::getOneBitSet(V->getType()->getScalarSizeInBits(), C1Log); 676 V = Builder.CreateAnd(V, ConstantInt::get(V->getType(), C1)); 677 } 678 679 if (C2Log > C1Log) { 680 V = Builder.CreateZExtOrTrunc(V, Y->getType()); 681 V = Builder.CreateShl(V, C2Log - C1Log); 682 } else if (C1Log > C2Log) { 683 V = Builder.CreateLShr(V, C1Log - C2Log); 684 V = Builder.CreateZExtOrTrunc(V, Y->getType()); 685 } else 686 V = Builder.CreateZExtOrTrunc(V, Y->getType()); 687 688 if (NeedXor) 689 V = Builder.CreateXor(V, *C2); 690 691 return Builder.CreateOr(V, Y); 692 } 693 694 /// Canonicalize a set or clear of a masked set of constant bits to 695 /// select-of-constants form. 696 static Instruction *foldSetClearBits(SelectInst &Sel, 697 InstCombiner::BuilderTy &Builder) { 698 Value *Cond = Sel.getCondition(); 699 Value *T = Sel.getTrueValue(); 700 Value *F = Sel.getFalseValue(); 701 Type *Ty = Sel.getType(); 702 Value *X; 703 const APInt *NotC, *C; 704 705 // Cond ? (X & ~C) : (X | C) --> (X & ~C) | (Cond ? 0 : C) 706 if (match(T, m_And(m_Value(X), m_APInt(NotC))) && 707 match(F, m_OneUse(m_Or(m_Specific(X), m_APInt(C)))) && *NotC == ~(*C)) { 708 Constant *Zero = ConstantInt::getNullValue(Ty); 709 Constant *OrC = ConstantInt::get(Ty, *C); 710 Value *NewSel = Builder.CreateSelect(Cond, Zero, OrC, "masksel", &Sel); 711 return BinaryOperator::CreateOr(T, NewSel); 712 } 713 714 // Cond ? (X | C) : (X & ~C) --> (X & ~C) | (Cond ? C : 0) 715 if (match(F, m_And(m_Value(X), m_APInt(NotC))) && 716 match(T, m_OneUse(m_Or(m_Specific(X), m_APInt(C)))) && *NotC == ~(*C)) { 717 Constant *Zero = ConstantInt::getNullValue(Ty); 718 Constant *OrC = ConstantInt::get(Ty, *C); 719 Value *NewSel = Builder.CreateSelect(Cond, OrC, Zero, "masksel", &Sel); 720 return BinaryOperator::CreateOr(F, NewSel); 721 } 722 723 return nullptr; 724 } 725 726 // select (x == 0), 0, x * y --> freeze(y) * x 727 // select (y == 0), 0, x * y --> freeze(x) * y 728 // select (x == 0), undef, x * y --> freeze(y) * x 729 // select (x == undef), 0, x * y --> freeze(y) * x 730 // Usage of mul instead of 0 will make the result more poisonous, 731 // so the operand that was not checked in the condition should be frozen. 732 // The latter folding is applied only when a constant compared with x is 733 // is a vector consisting of 0 and undefs. If a constant compared with x 734 // is a scalar undefined value or undefined vector then an expression 735 // should be already folded into a constant. 736 static Instruction *foldSelectZeroOrMul(SelectInst &SI, InstCombinerImpl &IC) { 737 auto *CondVal = SI.getCondition(); 738 auto *TrueVal = SI.getTrueValue(); 739 auto *FalseVal = SI.getFalseValue(); 740 Value *X, *Y; 741 ICmpInst::Predicate Predicate; 742 743 // Assuming that constant compared with zero is not undef (but it may be 744 // a vector with some undef elements). Otherwise (when a constant is undef) 745 // the select expression should be already simplified. 746 if (!match(CondVal, m_ICmp(Predicate, m_Value(X), m_Zero())) || 747 !ICmpInst::isEquality(Predicate)) 748 return nullptr; 749 750 if (Predicate == ICmpInst::ICMP_NE) 751 std::swap(TrueVal, FalseVal); 752 753 // Check that TrueVal is a constant instead of matching it with m_Zero() 754 // to handle the case when it is a scalar undef value or a vector containing 755 // non-zero elements that are masked by undef elements in the compare 756 // constant. 757 auto *TrueValC = dyn_cast<Constant>(TrueVal); 758 if (TrueValC == nullptr || 759 !match(FalseVal, m_c_Mul(m_Specific(X), m_Value(Y))) || 760 !isa<Instruction>(FalseVal)) 761 return nullptr; 762 763 auto *ZeroC = cast<Constant>(cast<Instruction>(CondVal)->getOperand(1)); 764 auto *MergedC = Constant::mergeUndefsWith(TrueValC, ZeroC); 765 // If X is compared with 0 then TrueVal could be either zero or undef. 766 // m_Zero match vectors containing some undef elements, but for scalars 767 // m_Undef should be used explicitly. 768 if (!match(MergedC, m_Zero()) && !match(MergedC, m_Undef())) 769 return nullptr; 770 771 auto *FalseValI = cast<Instruction>(FalseVal); 772 auto *FrY = IC.InsertNewInstBefore(new FreezeInst(Y, Y->getName() + ".fr"), 773 *FalseValI); 774 IC.replaceOperand(*FalseValI, FalseValI->getOperand(0) == Y ? 0 : 1, FrY); 775 return IC.replaceInstUsesWith(SI, FalseValI); 776 } 777 778 /// Transform patterns such as (a > b) ? a - b : 0 into usub.sat(a, b). 779 /// There are 8 commuted/swapped variants of this pattern. 780 /// TODO: Also support a - UMIN(a,b) patterns. 781 static Value *canonicalizeSaturatedSubtract(const ICmpInst *ICI, 782 const Value *TrueVal, 783 const Value *FalseVal, 784 InstCombiner::BuilderTy &Builder) { 785 ICmpInst::Predicate Pred = ICI->getPredicate(); 786 if (!ICmpInst::isUnsigned(Pred)) 787 return nullptr; 788 789 // (b > a) ? 0 : a - b -> (b <= a) ? a - b : 0 790 if (match(TrueVal, m_Zero())) { 791 Pred = ICmpInst::getInversePredicate(Pred); 792 std::swap(TrueVal, FalseVal); 793 } 794 if (!match(FalseVal, m_Zero())) 795 return nullptr; 796 797 Value *A = ICI->getOperand(0); 798 Value *B = ICI->getOperand(1); 799 if (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_ULT) { 800 // (b < a) ? a - b : 0 -> (a > b) ? a - b : 0 801 std::swap(A, B); 802 Pred = ICmpInst::getSwappedPredicate(Pred); 803 } 804 805 assert((Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_UGT) && 806 "Unexpected isUnsigned predicate!"); 807 808 // Ensure the sub is of the form: 809 // (a > b) ? a - b : 0 -> usub.sat(a, b) 810 // (a > b) ? b - a : 0 -> -usub.sat(a, b) 811 // Checking for both a-b and a+(-b) as a constant. 812 bool IsNegative = false; 813 const APInt *C; 814 if (match(TrueVal, m_Sub(m_Specific(B), m_Specific(A))) || 815 (match(A, m_APInt(C)) && 816 match(TrueVal, m_Add(m_Specific(B), m_SpecificInt(-*C))))) 817 IsNegative = true; 818 else if (!match(TrueVal, m_Sub(m_Specific(A), m_Specific(B))) && 819 !(match(B, m_APInt(C)) && 820 match(TrueVal, m_Add(m_Specific(A), m_SpecificInt(-*C))))) 821 return nullptr; 822 823 // If we are adding a negate and the sub and icmp are used anywhere else, we 824 // would end up with more instructions. 825 if (IsNegative && !TrueVal->hasOneUse() && !ICI->hasOneUse()) 826 return nullptr; 827 828 // (a > b) ? a - b : 0 -> usub.sat(a, b) 829 // (a > b) ? b - a : 0 -> -usub.sat(a, b) 830 Value *Result = Builder.CreateBinaryIntrinsic(Intrinsic::usub_sat, A, B); 831 if (IsNegative) 832 Result = Builder.CreateNeg(Result); 833 return Result; 834 } 835 836 static Value *canonicalizeSaturatedAdd(ICmpInst *Cmp, Value *TVal, Value *FVal, 837 InstCombiner::BuilderTy &Builder) { 838 if (!Cmp->hasOneUse()) 839 return nullptr; 840 841 // Match unsigned saturated add with constant. 842 Value *Cmp0 = Cmp->getOperand(0); 843 Value *Cmp1 = Cmp->getOperand(1); 844 ICmpInst::Predicate Pred = Cmp->getPredicate(); 845 Value *X; 846 const APInt *C, *CmpC; 847 if (Pred == ICmpInst::ICMP_ULT && 848 match(TVal, m_Add(m_Value(X), m_APInt(C))) && X == Cmp0 && 849 match(FVal, m_AllOnes()) && match(Cmp1, m_APInt(CmpC)) && *CmpC == ~*C) { 850 // (X u< ~C) ? (X + C) : -1 --> uadd.sat(X, C) 851 return Builder.CreateBinaryIntrinsic( 852 Intrinsic::uadd_sat, X, ConstantInt::get(X->getType(), *C)); 853 } 854 855 // Match unsigned saturated add of 2 variables with an unnecessary 'not'. 856 // There are 8 commuted variants. 857 // Canonicalize -1 (saturated result) to true value of the select. 858 if (match(FVal, m_AllOnes())) { 859 std::swap(TVal, FVal); 860 Pred = CmpInst::getInversePredicate(Pred); 861 } 862 if (!match(TVal, m_AllOnes())) 863 return nullptr; 864 865 // Canonicalize predicate to less-than or less-or-equal-than. 866 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) { 867 std::swap(Cmp0, Cmp1); 868 Pred = CmpInst::getSwappedPredicate(Pred); 869 } 870 if (Pred != ICmpInst::ICMP_ULT && Pred != ICmpInst::ICMP_ULE) 871 return nullptr; 872 873 // Match unsigned saturated add of 2 variables with an unnecessary 'not'. 874 // Strictness of the comparison is irrelevant. 875 Value *Y; 876 if (match(Cmp0, m_Not(m_Value(X))) && 877 match(FVal, m_c_Add(m_Specific(X), m_Value(Y))) && Y == Cmp1) { 878 // (~X u< Y) ? -1 : (X + Y) --> uadd.sat(X, Y) 879 // (~X u< Y) ? -1 : (Y + X) --> uadd.sat(X, Y) 880 return Builder.CreateBinaryIntrinsic(Intrinsic::uadd_sat, X, Y); 881 } 882 // The 'not' op may be included in the sum but not the compare. 883 // Strictness of the comparison is irrelevant. 884 X = Cmp0; 885 Y = Cmp1; 886 if (match(FVal, m_c_Add(m_Not(m_Specific(X)), m_Specific(Y)))) { 887 // (X u< Y) ? -1 : (~X + Y) --> uadd.sat(~X, Y) 888 // (X u< Y) ? -1 : (Y + ~X) --> uadd.sat(Y, ~X) 889 BinaryOperator *BO = cast<BinaryOperator>(FVal); 890 return Builder.CreateBinaryIntrinsic( 891 Intrinsic::uadd_sat, BO->getOperand(0), BO->getOperand(1)); 892 } 893 // The overflow may be detected via the add wrapping round. 894 // This is only valid for strict comparison! 895 if (Pred == ICmpInst::ICMP_ULT && 896 match(Cmp0, m_c_Add(m_Specific(Cmp1), m_Value(Y))) && 897 match(FVal, m_c_Add(m_Specific(Cmp1), m_Specific(Y)))) { 898 // ((X + Y) u< X) ? -1 : (X + Y) --> uadd.sat(X, Y) 899 // ((X + Y) u< Y) ? -1 : (X + Y) --> uadd.sat(X, Y) 900 return Builder.CreateBinaryIntrinsic(Intrinsic::uadd_sat, Cmp1, Y); 901 } 902 903 return nullptr; 904 } 905 906 /// Fold the following code sequence: 907 /// \code 908 /// int a = ctlz(x & -x); 909 // x ? 31 - a : a; 910 /// \code 911 /// 912 /// into: 913 /// cttz(x) 914 static Instruction *foldSelectCtlzToCttz(ICmpInst *ICI, Value *TrueVal, 915 Value *FalseVal, 916 InstCombiner::BuilderTy &Builder) { 917 unsigned BitWidth = TrueVal->getType()->getScalarSizeInBits(); 918 if (!ICI->isEquality() || !match(ICI->getOperand(1), m_Zero())) 919 return nullptr; 920 921 if (ICI->getPredicate() == ICmpInst::ICMP_NE) 922 std::swap(TrueVal, FalseVal); 923 924 if (!match(FalseVal, 925 m_Xor(m_Deferred(TrueVal), m_SpecificInt(BitWidth - 1)))) 926 return nullptr; 927 928 if (!match(TrueVal, m_Intrinsic<Intrinsic::ctlz>())) 929 return nullptr; 930 931 Value *X = ICI->getOperand(0); 932 auto *II = cast<IntrinsicInst>(TrueVal); 933 if (!match(II->getOperand(0), m_c_And(m_Specific(X), m_Neg(m_Specific(X))))) 934 return nullptr; 935 936 Function *F = Intrinsic::getDeclaration(II->getModule(), Intrinsic::cttz, 937 II->getType()); 938 return CallInst::Create(F, {X, II->getArgOperand(1)}); 939 } 940 941 /// Attempt to fold a cttz/ctlz followed by a icmp plus select into a single 942 /// call to cttz/ctlz with flag 'is_zero_undef' cleared. 943 /// 944 /// For example, we can fold the following code sequence: 945 /// \code 946 /// %0 = tail call i32 @llvm.cttz.i32(i32 %x, i1 true) 947 /// %1 = icmp ne i32 %x, 0 948 /// %2 = select i1 %1, i32 %0, i32 32 949 /// \code 950 /// 951 /// into: 952 /// %0 = tail call i32 @llvm.cttz.i32(i32 %x, i1 false) 953 static Value *foldSelectCttzCtlz(ICmpInst *ICI, Value *TrueVal, Value *FalseVal, 954 InstCombiner::BuilderTy &Builder) { 955 ICmpInst::Predicate Pred = ICI->getPredicate(); 956 Value *CmpLHS = ICI->getOperand(0); 957 Value *CmpRHS = ICI->getOperand(1); 958 959 // Check if the condition value compares a value for equality against zero. 960 if (!ICI->isEquality() || !match(CmpRHS, m_Zero())) 961 return nullptr; 962 963 Value *SelectArg = FalseVal; 964 Value *ValueOnZero = TrueVal; 965 if (Pred == ICmpInst::ICMP_NE) 966 std::swap(SelectArg, ValueOnZero); 967 968 // Skip zero extend/truncate. 969 Value *Count = nullptr; 970 if (!match(SelectArg, m_ZExt(m_Value(Count))) && 971 !match(SelectArg, m_Trunc(m_Value(Count)))) 972 Count = SelectArg; 973 974 // Check that 'Count' is a call to intrinsic cttz/ctlz. Also check that the 975 // input to the cttz/ctlz is used as LHS for the compare instruction. 976 if (!match(Count, m_Intrinsic<Intrinsic::cttz>(m_Specific(CmpLHS))) && 977 !match(Count, m_Intrinsic<Intrinsic::ctlz>(m_Specific(CmpLHS)))) 978 return nullptr; 979 980 IntrinsicInst *II = cast<IntrinsicInst>(Count); 981 982 // Check if the value propagated on zero is a constant number equal to the 983 // sizeof in bits of 'Count'. 984 unsigned SizeOfInBits = Count->getType()->getScalarSizeInBits(); 985 if (match(ValueOnZero, m_SpecificInt(SizeOfInBits))) { 986 // Explicitly clear the 'undef_on_zero' flag. It's always valid to go from 987 // true to false on this flag, so we can replace it for all users. 988 II->setArgOperand(1, ConstantInt::getFalse(II->getContext())); 989 return SelectArg; 990 } 991 992 // The ValueOnZero is not the bitwidth. But if the cttz/ctlz (and optional 993 // zext/trunc) have one use (ending at the select), the cttz/ctlz result will 994 // not be used if the input is zero. Relax to 'undef_on_zero' for that case. 995 if (II->hasOneUse() && SelectArg->hasOneUse() && 996 !match(II->getArgOperand(1), m_One())) 997 II->setArgOperand(1, ConstantInt::getTrue(II->getContext())); 998 999 return nullptr; 1000 } 1001 1002 /// Return true if we find and adjust an icmp+select pattern where the compare 1003 /// is with a constant that can be incremented or decremented to match the 1004 /// minimum or maximum idiom. 1005 static bool adjustMinMax(SelectInst &Sel, ICmpInst &Cmp) { 1006 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1007 Value *CmpLHS = Cmp.getOperand(0); 1008 Value *CmpRHS = Cmp.getOperand(1); 1009 Value *TrueVal = Sel.getTrueValue(); 1010 Value *FalseVal = Sel.getFalseValue(); 1011 1012 // We may move or edit the compare, so make sure the select is the only user. 1013 const APInt *CmpC; 1014 if (!Cmp.hasOneUse() || !match(CmpRHS, m_APInt(CmpC))) 1015 return false; 1016 1017 // These transforms only work for selects of integers or vector selects of 1018 // integer vectors. 1019 Type *SelTy = Sel.getType(); 1020 auto *SelEltTy = dyn_cast<IntegerType>(SelTy->getScalarType()); 1021 if (!SelEltTy || SelTy->isVectorTy() != Cmp.getType()->isVectorTy()) 1022 return false; 1023 1024 Constant *AdjustedRHS; 1025 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_SGT) 1026 AdjustedRHS = ConstantInt::get(CmpRHS->getType(), *CmpC + 1); 1027 else if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_SLT) 1028 AdjustedRHS = ConstantInt::get(CmpRHS->getType(), *CmpC - 1); 1029 else 1030 return false; 1031 1032 // X > C ? X : C+1 --> X < C+1 ? C+1 : X 1033 // X < C ? X : C-1 --> X > C-1 ? C-1 : X 1034 if ((CmpLHS == TrueVal && AdjustedRHS == FalseVal) || 1035 (CmpLHS == FalseVal && AdjustedRHS == TrueVal)) { 1036 ; // Nothing to do here. Values match without any sign/zero extension. 1037 } 1038 // Types do not match. Instead of calculating this with mixed types, promote 1039 // all to the larger type. This enables scalar evolution to analyze this 1040 // expression. 1041 else if (CmpRHS->getType()->getScalarSizeInBits() < SelEltTy->getBitWidth()) { 1042 Constant *SextRHS = ConstantExpr::getSExt(AdjustedRHS, SelTy); 1043 1044 // X = sext x; x >s c ? X : C+1 --> X = sext x; X <s C+1 ? C+1 : X 1045 // X = sext x; x <s c ? X : C-1 --> X = sext x; X >s C-1 ? C-1 : X 1046 // X = sext x; x >u c ? X : C+1 --> X = sext x; X <u C+1 ? C+1 : X 1047 // X = sext x; x <u c ? X : C-1 --> X = sext x; X >u C-1 ? C-1 : X 1048 if (match(TrueVal, m_SExt(m_Specific(CmpLHS))) && SextRHS == FalseVal) { 1049 CmpLHS = TrueVal; 1050 AdjustedRHS = SextRHS; 1051 } else if (match(FalseVal, m_SExt(m_Specific(CmpLHS))) && 1052 SextRHS == TrueVal) { 1053 CmpLHS = FalseVal; 1054 AdjustedRHS = SextRHS; 1055 } else if (Cmp.isUnsigned()) { 1056 Constant *ZextRHS = ConstantExpr::getZExt(AdjustedRHS, SelTy); 1057 // X = zext x; x >u c ? X : C+1 --> X = zext x; X <u C+1 ? C+1 : X 1058 // X = zext x; x <u c ? X : C-1 --> X = zext x; X >u C-1 ? C-1 : X 1059 // zext + signed compare cannot be changed: 1060 // 0xff <s 0x00, but 0x00ff >s 0x0000 1061 if (match(TrueVal, m_ZExt(m_Specific(CmpLHS))) && ZextRHS == FalseVal) { 1062 CmpLHS = TrueVal; 1063 AdjustedRHS = ZextRHS; 1064 } else if (match(FalseVal, m_ZExt(m_Specific(CmpLHS))) && 1065 ZextRHS == TrueVal) { 1066 CmpLHS = FalseVal; 1067 AdjustedRHS = ZextRHS; 1068 } else { 1069 return false; 1070 } 1071 } else { 1072 return false; 1073 } 1074 } else { 1075 return false; 1076 } 1077 1078 Pred = ICmpInst::getSwappedPredicate(Pred); 1079 CmpRHS = AdjustedRHS; 1080 std::swap(FalseVal, TrueVal); 1081 Cmp.setPredicate(Pred); 1082 Cmp.setOperand(0, CmpLHS); 1083 Cmp.setOperand(1, CmpRHS); 1084 Sel.setOperand(1, TrueVal); 1085 Sel.setOperand(2, FalseVal); 1086 Sel.swapProfMetadata(); 1087 1088 // Move the compare instruction right before the select instruction. Otherwise 1089 // the sext/zext value may be defined after the compare instruction uses it. 1090 Cmp.moveBefore(&Sel); 1091 1092 return true; 1093 } 1094 1095 /// If this is an integer min/max (icmp + select) with a constant operand, 1096 /// create the canonical icmp for the min/max operation and canonicalize the 1097 /// constant to the 'false' operand of the select: 1098 /// select (icmp Pred X, C1), C2, X --> select (icmp Pred' X, C2), X, C2 1099 /// Note: if C1 != C2, this will change the icmp constant to the existing 1100 /// constant operand of the select. 1101 static Instruction *canonicalizeMinMaxWithConstant(SelectInst &Sel, 1102 ICmpInst &Cmp, 1103 InstCombinerImpl &IC) { 1104 if (!Cmp.hasOneUse() || !isa<Constant>(Cmp.getOperand(1))) 1105 return nullptr; 1106 1107 // Canonicalize the compare predicate based on whether we have min or max. 1108 Value *LHS, *RHS; 1109 SelectPatternResult SPR = matchSelectPattern(&Sel, LHS, RHS); 1110 if (!SelectPatternResult::isMinOrMax(SPR.Flavor)) 1111 return nullptr; 1112 1113 // Is this already canonical? 1114 ICmpInst::Predicate CanonicalPred = getMinMaxPred(SPR.Flavor); 1115 if (Cmp.getOperand(0) == LHS && Cmp.getOperand(1) == RHS && 1116 Cmp.getPredicate() == CanonicalPred) 1117 return nullptr; 1118 1119 // Bail out on unsimplified X-0 operand (due to some worklist management bug), 1120 // as this may cause an infinite combine loop. Let the sub be folded first. 1121 if (match(LHS, m_Sub(m_Value(), m_Zero())) || 1122 match(RHS, m_Sub(m_Value(), m_Zero()))) 1123 return nullptr; 1124 1125 // Create the canonical compare and plug it into the select. 1126 IC.replaceOperand(Sel, 0, IC.Builder.CreateICmp(CanonicalPred, LHS, RHS)); 1127 1128 // If the select operands did not change, we're done. 1129 if (Sel.getTrueValue() == LHS && Sel.getFalseValue() == RHS) 1130 return &Sel; 1131 1132 // If we are swapping the select operands, swap the metadata too. 1133 assert(Sel.getTrueValue() == RHS && Sel.getFalseValue() == LHS && 1134 "Unexpected results from matchSelectPattern"); 1135 Sel.swapValues(); 1136 Sel.swapProfMetadata(); 1137 return &Sel; 1138 } 1139 1140 static Instruction *canonicalizeAbsNabs(SelectInst &Sel, ICmpInst &Cmp, 1141 InstCombinerImpl &IC) { 1142 if (!Cmp.hasOneUse() || !isa<Constant>(Cmp.getOperand(1))) 1143 return nullptr; 1144 1145 Value *LHS, *RHS; 1146 SelectPatternFlavor SPF = matchSelectPattern(&Sel, LHS, RHS).Flavor; 1147 if (SPF != SelectPatternFlavor::SPF_ABS && 1148 SPF != SelectPatternFlavor::SPF_NABS) 1149 return nullptr; 1150 1151 // Note that NSW flag can only be propagated for normal, non-negated abs! 1152 bool IntMinIsPoison = SPF == SelectPatternFlavor::SPF_ABS && 1153 match(RHS, m_NSWNeg(m_Specific(LHS))); 1154 Constant *IntMinIsPoisonC = 1155 ConstantInt::get(Type::getInt1Ty(Sel.getContext()), IntMinIsPoison); 1156 Instruction *Abs = 1157 IC.Builder.CreateBinaryIntrinsic(Intrinsic::abs, LHS, IntMinIsPoisonC); 1158 1159 if (SPF == SelectPatternFlavor::SPF_NABS) 1160 return BinaryOperator::CreateNeg(Abs); // Always without NSW flag! 1161 1162 return IC.replaceInstUsesWith(Sel, Abs); 1163 } 1164 1165 /// If we have a select with an equality comparison, then we know the value in 1166 /// one of the arms of the select. See if substituting this value into an arm 1167 /// and simplifying the result yields the same value as the other arm. 1168 /// 1169 /// To make this transform safe, we must drop poison-generating flags 1170 /// (nsw, etc) if we simplified to a binop because the select may be guarding 1171 /// that poison from propagating. If the existing binop already had no 1172 /// poison-generating flags, then this transform can be done by instsimplify. 1173 /// 1174 /// Consider: 1175 /// %cmp = icmp eq i32 %x, 2147483647 1176 /// %add = add nsw i32 %x, 1 1177 /// %sel = select i1 %cmp, i32 -2147483648, i32 %add 1178 /// 1179 /// We can't replace %sel with %add unless we strip away the flags. 1180 /// TODO: Wrapping flags could be preserved in some cases with better analysis. 1181 Instruction *InstCombinerImpl::foldSelectValueEquivalence(SelectInst &Sel, 1182 ICmpInst &Cmp) { 1183 // Value equivalence substitution requires an all-or-nothing replacement. 1184 // It does not make sense for a vector compare where each lane is chosen 1185 // independently. 1186 if (!Cmp.isEquality() || Cmp.getType()->isVectorTy()) 1187 return nullptr; 1188 1189 // Canonicalize the pattern to ICMP_EQ by swapping the select operands. 1190 Value *TrueVal = Sel.getTrueValue(), *FalseVal = Sel.getFalseValue(); 1191 bool Swapped = false; 1192 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) { 1193 std::swap(TrueVal, FalseVal); 1194 Swapped = true; 1195 } 1196 1197 // In X == Y ? f(X) : Z, try to evaluate f(Y) and replace the operand. 1198 // Make sure Y cannot be undef though, as we might pick different values for 1199 // undef in the icmp and in f(Y). Additionally, take care to avoid replacing 1200 // X == Y ? X : Z with X == Y ? Y : Z, as that would lead to an infinite 1201 // replacement cycle. 1202 Value *CmpLHS = Cmp.getOperand(0), *CmpRHS = Cmp.getOperand(1); 1203 if (TrueVal != CmpLHS && 1204 isGuaranteedNotToBeUndefOrPoison(CmpRHS, SQ.AC, &Sel, &DT)) { 1205 if (Value *V = simplifyWithOpReplaced(TrueVal, CmpLHS, CmpRHS, SQ, 1206 /* AllowRefinement */ true)) 1207 return replaceOperand(Sel, Swapped ? 2 : 1, V); 1208 1209 // Even if TrueVal does not simplify, we can directly replace a use of 1210 // CmpLHS with CmpRHS, as long as the instruction is not used anywhere 1211 // else and is safe to speculatively execute (we may end up executing it 1212 // with different operands, which should not cause side-effects or trigger 1213 // undefined behavior). Only do this if CmpRHS is a constant, as 1214 // profitability is not clear for other cases. 1215 // FIXME: The replacement could be performed recursively. 1216 if (match(CmpRHS, m_ImmConstant()) && !match(CmpLHS, m_ImmConstant())) 1217 if (auto *I = dyn_cast<Instruction>(TrueVal)) 1218 if (I->hasOneUse() && isSafeToSpeculativelyExecute(I)) 1219 for (Use &U : I->operands()) 1220 if (U == CmpLHS) { 1221 replaceUse(U, CmpRHS); 1222 return &Sel; 1223 } 1224 } 1225 if (TrueVal != CmpRHS && 1226 isGuaranteedNotToBeUndefOrPoison(CmpLHS, SQ.AC, &Sel, &DT)) 1227 if (Value *V = simplifyWithOpReplaced(TrueVal, CmpRHS, CmpLHS, SQ, 1228 /* AllowRefinement */ true)) 1229 return replaceOperand(Sel, Swapped ? 2 : 1, V); 1230 1231 auto *FalseInst = dyn_cast<Instruction>(FalseVal); 1232 if (!FalseInst) 1233 return nullptr; 1234 1235 // InstSimplify already performed this fold if it was possible subject to 1236 // current poison-generating flags. Try the transform again with 1237 // poison-generating flags temporarily dropped. 1238 bool WasNUW = false, WasNSW = false, WasExact = false, WasInBounds = false; 1239 if (auto *OBO = dyn_cast<OverflowingBinaryOperator>(FalseVal)) { 1240 WasNUW = OBO->hasNoUnsignedWrap(); 1241 WasNSW = OBO->hasNoSignedWrap(); 1242 FalseInst->setHasNoUnsignedWrap(false); 1243 FalseInst->setHasNoSignedWrap(false); 1244 } 1245 if (auto *PEO = dyn_cast<PossiblyExactOperator>(FalseVal)) { 1246 WasExact = PEO->isExact(); 1247 FalseInst->setIsExact(false); 1248 } 1249 if (auto *GEP = dyn_cast<GetElementPtrInst>(FalseVal)) { 1250 WasInBounds = GEP->isInBounds(); 1251 GEP->setIsInBounds(false); 1252 } 1253 1254 // Try each equivalence substitution possibility. 1255 // We have an 'EQ' comparison, so the select's false value will propagate. 1256 // Example: 1257 // (X == 42) ? 43 : (X + 1) --> (X == 42) ? (X + 1) : (X + 1) --> X + 1 1258 if (simplifyWithOpReplaced(FalseVal, CmpLHS, CmpRHS, SQ, 1259 /* AllowRefinement */ false) == TrueVal || 1260 simplifyWithOpReplaced(FalseVal, CmpRHS, CmpLHS, SQ, 1261 /* AllowRefinement */ false) == TrueVal) { 1262 return replaceInstUsesWith(Sel, FalseVal); 1263 } 1264 1265 // Restore poison-generating flags if the transform did not apply. 1266 if (WasNUW) 1267 FalseInst->setHasNoUnsignedWrap(); 1268 if (WasNSW) 1269 FalseInst->setHasNoSignedWrap(); 1270 if (WasExact) 1271 FalseInst->setIsExact(); 1272 if (WasInBounds) 1273 cast<GetElementPtrInst>(FalseInst)->setIsInBounds(); 1274 1275 return nullptr; 1276 } 1277 1278 // See if this is a pattern like: 1279 // %old_cmp1 = icmp slt i32 %x, C2 1280 // %old_replacement = select i1 %old_cmp1, i32 %target_low, i32 %target_high 1281 // %old_x_offseted = add i32 %x, C1 1282 // %old_cmp0 = icmp ult i32 %old_x_offseted, C0 1283 // %r = select i1 %old_cmp0, i32 %x, i32 %old_replacement 1284 // This can be rewritten as more canonical pattern: 1285 // %new_cmp1 = icmp slt i32 %x, -C1 1286 // %new_cmp2 = icmp sge i32 %x, C0-C1 1287 // %new_clamped_low = select i1 %new_cmp1, i32 %target_low, i32 %x 1288 // %r = select i1 %new_cmp2, i32 %target_high, i32 %new_clamped_low 1289 // Iff -C1 s<= C2 s<= C0-C1 1290 // Also ULT predicate can also be UGT iff C0 != -1 (+invert result) 1291 // SLT predicate can also be SGT iff C2 != INT_MAX (+invert res.) 1292 static Instruction *canonicalizeClampLike(SelectInst &Sel0, ICmpInst &Cmp0, 1293 InstCombiner::BuilderTy &Builder) { 1294 Value *X = Sel0.getTrueValue(); 1295 Value *Sel1 = Sel0.getFalseValue(); 1296 1297 // First match the condition of the outermost select. 1298 // Said condition must be one-use. 1299 if (!Cmp0.hasOneUse()) 1300 return nullptr; 1301 Value *Cmp00 = Cmp0.getOperand(0); 1302 Constant *C0; 1303 if (!match(Cmp0.getOperand(1), 1304 m_CombineAnd(m_AnyIntegralConstant(), m_Constant(C0)))) 1305 return nullptr; 1306 // Canonicalize Cmp0 into the form we expect. 1307 // FIXME: we shouldn't care about lanes that are 'undef' in the end? 1308 switch (Cmp0.getPredicate()) { 1309 case ICmpInst::Predicate::ICMP_ULT: 1310 break; // Great! 1311 case ICmpInst::Predicate::ICMP_ULE: 1312 // We'd have to increment C0 by one, and for that it must not have all-ones 1313 // element, but then it would have been canonicalized to 'ult' before 1314 // we get here. So we can't do anything useful with 'ule'. 1315 return nullptr; 1316 case ICmpInst::Predicate::ICMP_UGT: 1317 // We want to canonicalize it to 'ult', so we'll need to increment C0, 1318 // which again means it must not have any all-ones elements. 1319 if (!match(C0, 1320 m_SpecificInt_ICMP( 1321 ICmpInst::Predicate::ICMP_NE, 1322 APInt::getAllOnes(C0->getType()->getScalarSizeInBits())))) 1323 return nullptr; // Can't do, have all-ones element[s]. 1324 C0 = InstCombiner::AddOne(C0); 1325 std::swap(X, Sel1); 1326 break; 1327 case ICmpInst::Predicate::ICMP_UGE: 1328 // The only way we'd get this predicate if this `icmp` has extra uses, 1329 // but then we won't be able to do this fold. 1330 return nullptr; 1331 default: 1332 return nullptr; // Unknown predicate. 1333 } 1334 1335 // Now that we've canonicalized the ICmp, we know the X we expect; 1336 // the select in other hand should be one-use. 1337 if (!Sel1->hasOneUse()) 1338 return nullptr; 1339 1340 // We now can finish matching the condition of the outermost select: 1341 // it should either be the X itself, or an addition of some constant to X. 1342 Constant *C1; 1343 if (Cmp00 == X) 1344 C1 = ConstantInt::getNullValue(Sel0.getType()); 1345 else if (!match(Cmp00, 1346 m_Add(m_Specific(X), 1347 m_CombineAnd(m_AnyIntegralConstant(), m_Constant(C1))))) 1348 return nullptr; 1349 1350 Value *Cmp1; 1351 ICmpInst::Predicate Pred1; 1352 Constant *C2; 1353 Value *ReplacementLow, *ReplacementHigh; 1354 if (!match(Sel1, m_Select(m_Value(Cmp1), m_Value(ReplacementLow), 1355 m_Value(ReplacementHigh))) || 1356 !match(Cmp1, 1357 m_ICmp(Pred1, m_Specific(X), 1358 m_CombineAnd(m_AnyIntegralConstant(), m_Constant(C2))))) 1359 return nullptr; 1360 1361 if (!Cmp1->hasOneUse() && (Cmp00 == X || !Cmp00->hasOneUse())) 1362 return nullptr; // Not enough one-use instructions for the fold. 1363 // FIXME: this restriction could be relaxed if Cmp1 can be reused as one of 1364 // two comparisons we'll need to build. 1365 1366 // Canonicalize Cmp1 into the form we expect. 1367 // FIXME: we shouldn't care about lanes that are 'undef' in the end? 1368 switch (Pred1) { 1369 case ICmpInst::Predicate::ICMP_SLT: 1370 break; 1371 case ICmpInst::Predicate::ICMP_SLE: 1372 // We'd have to increment C2 by one, and for that it must not have signed 1373 // max element, but then it would have been canonicalized to 'slt' before 1374 // we get here. So we can't do anything useful with 'sle'. 1375 return nullptr; 1376 case ICmpInst::Predicate::ICMP_SGT: 1377 // We want to canonicalize it to 'slt', so we'll need to increment C2, 1378 // which again means it must not have any signed max elements. 1379 if (!match(C2, 1380 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_NE, 1381 APInt::getSignedMaxValue( 1382 C2->getType()->getScalarSizeInBits())))) 1383 return nullptr; // Can't do, have signed max element[s]. 1384 C2 = InstCombiner::AddOne(C2); 1385 LLVM_FALLTHROUGH; 1386 case ICmpInst::Predicate::ICMP_SGE: 1387 // Also non-canonical, but here we don't need to change C2, 1388 // so we don't have any restrictions on C2, so we can just handle it. 1389 std::swap(ReplacementLow, ReplacementHigh); 1390 break; 1391 default: 1392 return nullptr; // Unknown predicate. 1393 } 1394 1395 // The thresholds of this clamp-like pattern. 1396 auto *ThresholdLowIncl = ConstantExpr::getNeg(C1); 1397 auto *ThresholdHighExcl = ConstantExpr::getSub(C0, C1); 1398 1399 // The fold has a precondition 1: C2 s>= ThresholdLow 1400 auto *Precond1 = ConstantExpr::getICmp(ICmpInst::Predicate::ICMP_SGE, C2, 1401 ThresholdLowIncl); 1402 if (!match(Precond1, m_One())) 1403 return nullptr; 1404 // The fold has a precondition 2: C2 s<= ThresholdHigh 1405 auto *Precond2 = ConstantExpr::getICmp(ICmpInst::Predicate::ICMP_SLE, C2, 1406 ThresholdHighExcl); 1407 if (!match(Precond2, m_One())) 1408 return nullptr; 1409 1410 // All good, finally emit the new pattern. 1411 Value *ShouldReplaceLow = Builder.CreateICmpSLT(X, ThresholdLowIncl); 1412 Value *ShouldReplaceHigh = Builder.CreateICmpSGE(X, ThresholdHighExcl); 1413 Value *MaybeReplacedLow = 1414 Builder.CreateSelect(ShouldReplaceLow, ReplacementLow, X); 1415 Instruction *MaybeReplacedHigh = 1416 SelectInst::Create(ShouldReplaceHigh, ReplacementHigh, MaybeReplacedLow); 1417 1418 return MaybeReplacedHigh; 1419 } 1420 1421 // If we have 1422 // %cmp = icmp [canonical predicate] i32 %x, C0 1423 // %r = select i1 %cmp, i32 %y, i32 C1 1424 // Where C0 != C1 and %x may be different from %y, see if the constant that we 1425 // will have if we flip the strictness of the predicate (i.e. without changing 1426 // the result) is identical to the C1 in select. If it matches we can change 1427 // original comparison to one with swapped predicate, reuse the constant, 1428 // and swap the hands of select. 1429 static Instruction * 1430 tryToReuseConstantFromSelectInComparison(SelectInst &Sel, ICmpInst &Cmp, 1431 InstCombinerImpl &IC) { 1432 ICmpInst::Predicate Pred; 1433 Value *X; 1434 Constant *C0; 1435 if (!match(&Cmp, m_OneUse(m_ICmp( 1436 Pred, m_Value(X), 1437 m_CombineAnd(m_AnyIntegralConstant(), m_Constant(C0)))))) 1438 return nullptr; 1439 1440 // If comparison predicate is non-relational, we won't be able to do anything. 1441 if (ICmpInst::isEquality(Pred)) 1442 return nullptr; 1443 1444 // If comparison predicate is non-canonical, then we certainly won't be able 1445 // to make it canonical; canonicalizeCmpWithConstant() already tried. 1446 if (!InstCombiner::isCanonicalPredicate(Pred)) 1447 return nullptr; 1448 1449 // If the [input] type of comparison and select type are different, lets abort 1450 // for now. We could try to compare constants with trunc/[zs]ext though. 1451 if (C0->getType() != Sel.getType()) 1452 return nullptr; 1453 1454 // FIXME: are there any magic icmp predicate+constant pairs we must not touch? 1455 1456 Value *SelVal0, *SelVal1; // We do not care which one is from where. 1457 match(&Sel, m_Select(m_Value(), m_Value(SelVal0), m_Value(SelVal1))); 1458 // At least one of these values we are selecting between must be a constant 1459 // else we'll never succeed. 1460 if (!match(SelVal0, m_AnyIntegralConstant()) && 1461 !match(SelVal1, m_AnyIntegralConstant())) 1462 return nullptr; 1463 1464 // Does this constant C match any of the `select` values? 1465 auto MatchesSelectValue = [SelVal0, SelVal1](Constant *C) { 1466 return C->isElementWiseEqual(SelVal0) || C->isElementWiseEqual(SelVal1); 1467 }; 1468 1469 // If C0 *already* matches true/false value of select, we are done. 1470 if (MatchesSelectValue(C0)) 1471 return nullptr; 1472 1473 // Check the constant we'd have with flipped-strictness predicate. 1474 auto FlippedStrictness = 1475 InstCombiner::getFlippedStrictnessPredicateAndConstant(Pred, C0); 1476 if (!FlippedStrictness) 1477 return nullptr; 1478 1479 // If said constant doesn't match either, then there is no hope, 1480 if (!MatchesSelectValue(FlippedStrictness->second)) 1481 return nullptr; 1482 1483 // It matched! Lets insert the new comparison just before select. 1484 InstCombiner::BuilderTy::InsertPointGuard Guard(IC.Builder); 1485 IC.Builder.SetInsertPoint(&Sel); 1486 1487 Pred = ICmpInst::getSwappedPredicate(Pred); // Yes, swapped. 1488 Value *NewCmp = IC.Builder.CreateICmp(Pred, X, FlippedStrictness->second, 1489 Cmp.getName() + ".inv"); 1490 IC.replaceOperand(Sel, 0, NewCmp); 1491 Sel.swapValues(); 1492 Sel.swapProfMetadata(); 1493 1494 return &Sel; 1495 } 1496 1497 /// Visit a SelectInst that has an ICmpInst as its first operand. 1498 Instruction *InstCombinerImpl::foldSelectInstWithICmp(SelectInst &SI, 1499 ICmpInst *ICI) { 1500 if (Instruction *NewSel = foldSelectValueEquivalence(SI, *ICI)) 1501 return NewSel; 1502 1503 if (Instruction *NewSel = canonicalizeMinMaxWithConstant(SI, *ICI, *this)) 1504 return NewSel; 1505 1506 if (Instruction *NewAbs = canonicalizeAbsNabs(SI, *ICI, *this)) 1507 return NewAbs; 1508 1509 if (Instruction *NewAbs = canonicalizeClampLike(SI, *ICI, Builder)) 1510 return NewAbs; 1511 1512 if (Instruction *NewSel = 1513 tryToReuseConstantFromSelectInComparison(SI, *ICI, *this)) 1514 return NewSel; 1515 1516 bool Changed = adjustMinMax(SI, *ICI); 1517 1518 if (Value *V = foldSelectICmpAnd(SI, ICI, Builder)) 1519 return replaceInstUsesWith(SI, V); 1520 1521 // NOTE: if we wanted to, this is where to detect integer MIN/MAX 1522 Value *TrueVal = SI.getTrueValue(); 1523 Value *FalseVal = SI.getFalseValue(); 1524 ICmpInst::Predicate Pred = ICI->getPredicate(); 1525 Value *CmpLHS = ICI->getOperand(0); 1526 Value *CmpRHS = ICI->getOperand(1); 1527 if (CmpRHS != CmpLHS && isa<Constant>(CmpRHS)) { 1528 if (CmpLHS == TrueVal && Pred == ICmpInst::ICMP_EQ) { 1529 // Transform (X == C) ? X : Y -> (X == C) ? C : Y 1530 SI.setOperand(1, CmpRHS); 1531 Changed = true; 1532 } else if (CmpLHS == FalseVal && Pred == ICmpInst::ICMP_NE) { 1533 // Transform (X != C) ? Y : X -> (X != C) ? Y : C 1534 SI.setOperand(2, CmpRHS); 1535 Changed = true; 1536 } 1537 } 1538 1539 // FIXME: This code is nearly duplicated in InstSimplify. Using/refactoring 1540 // decomposeBitTestICmp() might help. 1541 { 1542 unsigned BitWidth = 1543 DL.getTypeSizeInBits(TrueVal->getType()->getScalarType()); 1544 APInt MinSignedValue = APInt::getSignedMinValue(BitWidth); 1545 Value *X; 1546 const APInt *Y, *C; 1547 bool TrueWhenUnset; 1548 bool IsBitTest = false; 1549 if (ICmpInst::isEquality(Pred) && 1550 match(CmpLHS, m_And(m_Value(X), m_Power2(Y))) && 1551 match(CmpRHS, m_Zero())) { 1552 IsBitTest = true; 1553 TrueWhenUnset = Pred == ICmpInst::ICMP_EQ; 1554 } else if (Pred == ICmpInst::ICMP_SLT && match(CmpRHS, m_Zero())) { 1555 X = CmpLHS; 1556 Y = &MinSignedValue; 1557 IsBitTest = true; 1558 TrueWhenUnset = false; 1559 } else if (Pred == ICmpInst::ICMP_SGT && match(CmpRHS, m_AllOnes())) { 1560 X = CmpLHS; 1561 Y = &MinSignedValue; 1562 IsBitTest = true; 1563 TrueWhenUnset = true; 1564 } 1565 if (IsBitTest) { 1566 Value *V = nullptr; 1567 // (X & Y) == 0 ? X : X ^ Y --> X & ~Y 1568 if (TrueWhenUnset && TrueVal == X && 1569 match(FalseVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 1570 V = Builder.CreateAnd(X, ~(*Y)); 1571 // (X & Y) != 0 ? X ^ Y : X --> X & ~Y 1572 else if (!TrueWhenUnset && FalseVal == X && 1573 match(TrueVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 1574 V = Builder.CreateAnd(X, ~(*Y)); 1575 // (X & Y) == 0 ? X ^ Y : X --> X | Y 1576 else if (TrueWhenUnset && FalseVal == X && 1577 match(TrueVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 1578 V = Builder.CreateOr(X, *Y); 1579 // (X & Y) != 0 ? X : X ^ Y --> X | Y 1580 else if (!TrueWhenUnset && TrueVal == X && 1581 match(FalseVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 1582 V = Builder.CreateOr(X, *Y); 1583 1584 if (V) 1585 return replaceInstUsesWith(SI, V); 1586 } 1587 } 1588 1589 if (Instruction *V = 1590 foldSelectICmpAndAnd(SI.getType(), ICI, TrueVal, FalseVal, Builder)) 1591 return V; 1592 1593 if (Instruction *V = foldSelectCtlzToCttz(ICI, TrueVal, FalseVal, Builder)) 1594 return V; 1595 1596 if (Value *V = foldSelectICmpAndOr(ICI, TrueVal, FalseVal, Builder)) 1597 return replaceInstUsesWith(SI, V); 1598 1599 if (Value *V = foldSelectICmpLshrAshr(ICI, TrueVal, FalseVal, Builder)) 1600 return replaceInstUsesWith(SI, V); 1601 1602 if (Value *V = foldSelectCttzCtlz(ICI, TrueVal, FalseVal, Builder)) 1603 return replaceInstUsesWith(SI, V); 1604 1605 if (Value *V = canonicalizeSaturatedSubtract(ICI, TrueVal, FalseVal, Builder)) 1606 return replaceInstUsesWith(SI, V); 1607 1608 if (Value *V = canonicalizeSaturatedAdd(ICI, TrueVal, FalseVal, Builder)) 1609 return replaceInstUsesWith(SI, V); 1610 1611 return Changed ? &SI : nullptr; 1612 } 1613 1614 /// SI is a select whose condition is a PHI node (but the two may be in 1615 /// different blocks). See if the true/false values (V) are live in all of the 1616 /// predecessor blocks of the PHI. For example, cases like this can't be mapped: 1617 /// 1618 /// X = phi [ C1, BB1], [C2, BB2] 1619 /// Y = add 1620 /// Z = select X, Y, 0 1621 /// 1622 /// because Y is not live in BB1/BB2. 1623 static bool canSelectOperandBeMappingIntoPredBlock(const Value *V, 1624 const SelectInst &SI) { 1625 // If the value is a non-instruction value like a constant or argument, it 1626 // can always be mapped. 1627 const Instruction *I = dyn_cast<Instruction>(V); 1628 if (!I) return true; 1629 1630 // If V is a PHI node defined in the same block as the condition PHI, we can 1631 // map the arguments. 1632 const PHINode *CondPHI = cast<PHINode>(SI.getCondition()); 1633 1634 if (const PHINode *VP = dyn_cast<PHINode>(I)) 1635 if (VP->getParent() == CondPHI->getParent()) 1636 return true; 1637 1638 // Otherwise, if the PHI and select are defined in the same block and if V is 1639 // defined in a different block, then we can transform it. 1640 if (SI.getParent() == CondPHI->getParent() && 1641 I->getParent() != CondPHI->getParent()) 1642 return true; 1643 1644 // Otherwise we have a 'hard' case and we can't tell without doing more 1645 // detailed dominator based analysis, punt. 1646 return false; 1647 } 1648 1649 /// We have an SPF (e.g. a min or max) of an SPF of the form: 1650 /// SPF2(SPF1(A, B), C) 1651 Instruction *InstCombinerImpl::foldSPFofSPF(Instruction *Inner, 1652 SelectPatternFlavor SPF1, Value *A, 1653 Value *B, Instruction &Outer, 1654 SelectPatternFlavor SPF2, 1655 Value *C) { 1656 if (Outer.getType() != Inner->getType()) 1657 return nullptr; 1658 1659 if (C == A || C == B) { 1660 // MAX(MAX(A, B), B) -> MAX(A, B) 1661 // MIN(MIN(a, b), a) -> MIN(a, b) 1662 // TODO: This could be done in instsimplify. 1663 if (SPF1 == SPF2 && SelectPatternResult::isMinOrMax(SPF1)) 1664 return replaceInstUsesWith(Outer, Inner); 1665 1666 // MAX(MIN(a, b), a) -> a 1667 // MIN(MAX(a, b), a) -> a 1668 // TODO: This could be done in instsimplify. 1669 if ((SPF1 == SPF_SMIN && SPF2 == SPF_SMAX) || 1670 (SPF1 == SPF_SMAX && SPF2 == SPF_SMIN) || 1671 (SPF1 == SPF_UMIN && SPF2 == SPF_UMAX) || 1672 (SPF1 == SPF_UMAX && SPF2 == SPF_UMIN)) 1673 return replaceInstUsesWith(Outer, C); 1674 } 1675 1676 if (SPF1 == SPF2) { 1677 const APInt *CB, *CC; 1678 if (match(B, m_APInt(CB)) && match(C, m_APInt(CC))) { 1679 // MIN(MIN(A, 23), 97) -> MIN(A, 23) 1680 // MAX(MAX(A, 97), 23) -> MAX(A, 97) 1681 // TODO: This could be done in instsimplify. 1682 if ((SPF1 == SPF_UMIN && CB->ule(*CC)) || 1683 (SPF1 == SPF_SMIN && CB->sle(*CC)) || 1684 (SPF1 == SPF_UMAX && CB->uge(*CC)) || 1685 (SPF1 == SPF_SMAX && CB->sge(*CC))) 1686 return replaceInstUsesWith(Outer, Inner); 1687 1688 // MIN(MIN(A, 97), 23) -> MIN(A, 23) 1689 // MAX(MAX(A, 23), 97) -> MAX(A, 97) 1690 if ((SPF1 == SPF_UMIN && CB->ugt(*CC)) || 1691 (SPF1 == SPF_SMIN && CB->sgt(*CC)) || 1692 (SPF1 == SPF_UMAX && CB->ult(*CC)) || 1693 (SPF1 == SPF_SMAX && CB->slt(*CC))) { 1694 Outer.replaceUsesOfWith(Inner, A); 1695 return &Outer; 1696 } 1697 } 1698 } 1699 1700 // max(max(A, B), min(A, B)) --> max(A, B) 1701 // min(min(A, B), max(A, B)) --> min(A, B) 1702 // TODO: This could be done in instsimplify. 1703 if (SPF1 == SPF2 && 1704 ((SPF1 == SPF_UMIN && match(C, m_c_UMax(m_Specific(A), m_Specific(B)))) || 1705 (SPF1 == SPF_SMIN && match(C, m_c_SMax(m_Specific(A), m_Specific(B)))) || 1706 (SPF1 == SPF_UMAX && match(C, m_c_UMin(m_Specific(A), m_Specific(B)))) || 1707 (SPF1 == SPF_SMAX && match(C, m_c_SMin(m_Specific(A), m_Specific(B)))))) 1708 return replaceInstUsesWith(Outer, Inner); 1709 1710 // ABS(ABS(X)) -> ABS(X) 1711 // NABS(NABS(X)) -> NABS(X) 1712 // TODO: This could be done in instsimplify. 1713 if (SPF1 == SPF2 && (SPF1 == SPF_ABS || SPF1 == SPF_NABS)) { 1714 return replaceInstUsesWith(Outer, Inner); 1715 } 1716 1717 // ABS(NABS(X)) -> ABS(X) 1718 // NABS(ABS(X)) -> NABS(X) 1719 if ((SPF1 == SPF_ABS && SPF2 == SPF_NABS) || 1720 (SPF1 == SPF_NABS && SPF2 == SPF_ABS)) { 1721 SelectInst *SI = cast<SelectInst>(Inner); 1722 Value *NewSI = 1723 Builder.CreateSelect(SI->getCondition(), SI->getFalseValue(), 1724 SI->getTrueValue(), SI->getName(), SI); 1725 return replaceInstUsesWith(Outer, NewSI); 1726 } 1727 1728 auto IsFreeOrProfitableToInvert = 1729 [&](Value *V, Value *&NotV, bool &ElidesXor) { 1730 if (match(V, m_Not(m_Value(NotV)))) { 1731 // If V has at most 2 uses then we can get rid of the xor operation 1732 // entirely. 1733 ElidesXor |= !V->hasNUsesOrMore(3); 1734 return true; 1735 } 1736 1737 if (isFreeToInvert(V, !V->hasNUsesOrMore(3))) { 1738 NotV = nullptr; 1739 return true; 1740 } 1741 1742 return false; 1743 }; 1744 1745 Value *NotA, *NotB, *NotC; 1746 bool ElidesXor = false; 1747 1748 // MIN(MIN(~A, ~B), ~C) == ~MAX(MAX(A, B), C) 1749 // MIN(MAX(~A, ~B), ~C) == ~MAX(MIN(A, B), C) 1750 // MAX(MIN(~A, ~B), ~C) == ~MIN(MAX(A, B), C) 1751 // MAX(MAX(~A, ~B), ~C) == ~MIN(MIN(A, B), C) 1752 // 1753 // This transform is performance neutral if we can elide at least one xor from 1754 // the set of three operands, since we'll be tacking on an xor at the very 1755 // end. 1756 if (SelectPatternResult::isMinOrMax(SPF1) && 1757 SelectPatternResult::isMinOrMax(SPF2) && 1758 IsFreeOrProfitableToInvert(A, NotA, ElidesXor) && 1759 IsFreeOrProfitableToInvert(B, NotB, ElidesXor) && 1760 IsFreeOrProfitableToInvert(C, NotC, ElidesXor) && ElidesXor) { 1761 if (!NotA) 1762 NotA = Builder.CreateNot(A); 1763 if (!NotB) 1764 NotB = Builder.CreateNot(B); 1765 if (!NotC) 1766 NotC = Builder.CreateNot(C); 1767 1768 Value *NewInner = createMinMax(Builder, getInverseMinMaxFlavor(SPF1), NotA, 1769 NotB); 1770 Value *NewOuter = Builder.CreateNot( 1771 createMinMax(Builder, getInverseMinMaxFlavor(SPF2), NewInner, NotC)); 1772 return replaceInstUsesWith(Outer, NewOuter); 1773 } 1774 1775 return nullptr; 1776 } 1777 1778 /// Turn select C, (X + Y), (X - Y) --> (X + (select C, Y, (-Y))). 1779 /// This is even legal for FP. 1780 static Instruction *foldAddSubSelect(SelectInst &SI, 1781 InstCombiner::BuilderTy &Builder) { 1782 Value *CondVal = SI.getCondition(); 1783 Value *TrueVal = SI.getTrueValue(); 1784 Value *FalseVal = SI.getFalseValue(); 1785 auto *TI = dyn_cast<Instruction>(TrueVal); 1786 auto *FI = dyn_cast<Instruction>(FalseVal); 1787 if (!TI || !FI || !TI->hasOneUse() || !FI->hasOneUse()) 1788 return nullptr; 1789 1790 Instruction *AddOp = nullptr, *SubOp = nullptr; 1791 if ((TI->getOpcode() == Instruction::Sub && 1792 FI->getOpcode() == Instruction::Add) || 1793 (TI->getOpcode() == Instruction::FSub && 1794 FI->getOpcode() == Instruction::FAdd)) { 1795 AddOp = FI; 1796 SubOp = TI; 1797 } else if ((FI->getOpcode() == Instruction::Sub && 1798 TI->getOpcode() == Instruction::Add) || 1799 (FI->getOpcode() == Instruction::FSub && 1800 TI->getOpcode() == Instruction::FAdd)) { 1801 AddOp = TI; 1802 SubOp = FI; 1803 } 1804 1805 if (AddOp) { 1806 Value *OtherAddOp = nullptr; 1807 if (SubOp->getOperand(0) == AddOp->getOperand(0)) { 1808 OtherAddOp = AddOp->getOperand(1); 1809 } else if (SubOp->getOperand(0) == AddOp->getOperand(1)) { 1810 OtherAddOp = AddOp->getOperand(0); 1811 } 1812 1813 if (OtherAddOp) { 1814 // So at this point we know we have (Y -> OtherAddOp): 1815 // select C, (add X, Y), (sub X, Z) 1816 Value *NegVal; // Compute -Z 1817 if (SI.getType()->isFPOrFPVectorTy()) { 1818 NegVal = Builder.CreateFNeg(SubOp->getOperand(1)); 1819 if (Instruction *NegInst = dyn_cast<Instruction>(NegVal)) { 1820 FastMathFlags Flags = AddOp->getFastMathFlags(); 1821 Flags &= SubOp->getFastMathFlags(); 1822 NegInst->setFastMathFlags(Flags); 1823 } 1824 } else { 1825 NegVal = Builder.CreateNeg(SubOp->getOperand(1)); 1826 } 1827 1828 Value *NewTrueOp = OtherAddOp; 1829 Value *NewFalseOp = NegVal; 1830 if (AddOp != TI) 1831 std::swap(NewTrueOp, NewFalseOp); 1832 Value *NewSel = Builder.CreateSelect(CondVal, NewTrueOp, NewFalseOp, 1833 SI.getName() + ".p", &SI); 1834 1835 if (SI.getType()->isFPOrFPVectorTy()) { 1836 Instruction *RI = 1837 BinaryOperator::CreateFAdd(SubOp->getOperand(0), NewSel); 1838 1839 FastMathFlags Flags = AddOp->getFastMathFlags(); 1840 Flags &= SubOp->getFastMathFlags(); 1841 RI->setFastMathFlags(Flags); 1842 return RI; 1843 } else 1844 return BinaryOperator::CreateAdd(SubOp->getOperand(0), NewSel); 1845 } 1846 } 1847 return nullptr; 1848 } 1849 1850 /// Turn X + Y overflows ? -1 : X + Y -> uadd_sat X, Y 1851 /// And X - Y overflows ? 0 : X - Y -> usub_sat X, Y 1852 /// Along with a number of patterns similar to: 1853 /// X + Y overflows ? (X < 0 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1854 /// X - Y overflows ? (X > 0 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1855 static Instruction * 1856 foldOverflowingAddSubSelect(SelectInst &SI, InstCombiner::BuilderTy &Builder) { 1857 Value *CondVal = SI.getCondition(); 1858 Value *TrueVal = SI.getTrueValue(); 1859 Value *FalseVal = SI.getFalseValue(); 1860 1861 WithOverflowInst *II; 1862 if (!match(CondVal, m_ExtractValue<1>(m_WithOverflowInst(II))) || 1863 !match(FalseVal, m_ExtractValue<0>(m_Specific(II)))) 1864 return nullptr; 1865 1866 Value *X = II->getLHS(); 1867 Value *Y = II->getRHS(); 1868 1869 auto IsSignedSaturateLimit = [&](Value *Limit, bool IsAdd) { 1870 Type *Ty = Limit->getType(); 1871 1872 ICmpInst::Predicate Pred; 1873 Value *TrueVal, *FalseVal, *Op; 1874 const APInt *C; 1875 if (!match(Limit, m_Select(m_ICmp(Pred, m_Value(Op), m_APInt(C)), 1876 m_Value(TrueVal), m_Value(FalseVal)))) 1877 return false; 1878 1879 auto IsZeroOrOne = [](const APInt &C) { return C.isZero() || C.isOne(); }; 1880 auto IsMinMax = [&](Value *Min, Value *Max) { 1881 APInt MinVal = APInt::getSignedMinValue(Ty->getScalarSizeInBits()); 1882 APInt MaxVal = APInt::getSignedMaxValue(Ty->getScalarSizeInBits()); 1883 return match(Min, m_SpecificInt(MinVal)) && 1884 match(Max, m_SpecificInt(MaxVal)); 1885 }; 1886 1887 if (Op != X && Op != Y) 1888 return false; 1889 1890 if (IsAdd) { 1891 // X + Y overflows ? (X <s 0 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1892 // X + Y overflows ? (X <s 1 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1893 // X + Y overflows ? (Y <s 0 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1894 // X + Y overflows ? (Y <s 1 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1895 if (Pred == ICmpInst::ICMP_SLT && IsZeroOrOne(*C) && 1896 IsMinMax(TrueVal, FalseVal)) 1897 return true; 1898 // X + Y overflows ? (X >s 0 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1899 // X + Y overflows ? (X >s -1 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1900 // X + Y overflows ? (Y >s 0 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1901 // X + Y overflows ? (Y >s -1 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1902 if (Pred == ICmpInst::ICMP_SGT && IsZeroOrOne(*C + 1) && 1903 IsMinMax(FalseVal, TrueVal)) 1904 return true; 1905 } else { 1906 // X - Y overflows ? (X <s 0 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1907 // X - Y overflows ? (X <s -1 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1908 if (Op == X && Pred == ICmpInst::ICMP_SLT && IsZeroOrOne(*C + 1) && 1909 IsMinMax(TrueVal, FalseVal)) 1910 return true; 1911 // X - Y overflows ? (X >s -1 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1912 // X - Y overflows ? (X >s -2 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1913 if (Op == X && Pred == ICmpInst::ICMP_SGT && IsZeroOrOne(*C + 2) && 1914 IsMinMax(FalseVal, TrueVal)) 1915 return true; 1916 // X - Y overflows ? (Y <s 0 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1917 // X - Y overflows ? (Y <s 1 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1918 if (Op == Y && Pred == ICmpInst::ICMP_SLT && IsZeroOrOne(*C) && 1919 IsMinMax(FalseVal, TrueVal)) 1920 return true; 1921 // X - Y overflows ? (Y >s 0 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1922 // X - Y overflows ? (Y >s -1 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1923 if (Op == Y && Pred == ICmpInst::ICMP_SGT && IsZeroOrOne(*C + 1) && 1924 IsMinMax(TrueVal, FalseVal)) 1925 return true; 1926 } 1927 1928 return false; 1929 }; 1930 1931 Intrinsic::ID NewIntrinsicID; 1932 if (II->getIntrinsicID() == Intrinsic::uadd_with_overflow && 1933 match(TrueVal, m_AllOnes())) 1934 // X + Y overflows ? -1 : X + Y -> uadd_sat X, Y 1935 NewIntrinsicID = Intrinsic::uadd_sat; 1936 else if (II->getIntrinsicID() == Intrinsic::usub_with_overflow && 1937 match(TrueVal, m_Zero())) 1938 // X - Y overflows ? 0 : X - Y -> usub_sat X, Y 1939 NewIntrinsicID = Intrinsic::usub_sat; 1940 else if (II->getIntrinsicID() == Intrinsic::sadd_with_overflow && 1941 IsSignedSaturateLimit(TrueVal, /*IsAdd=*/true)) 1942 // X + Y overflows ? (X <s 0 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1943 // X + Y overflows ? (X <s 1 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1944 // X + Y overflows ? (X >s 0 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1945 // X + Y overflows ? (X >s -1 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1946 // X + Y overflows ? (Y <s 0 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1947 // X + Y overflows ? (Y <s 1 ? INTMIN : INTMAX) : X + Y --> sadd_sat X, Y 1948 // X + Y overflows ? (Y >s 0 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1949 // X + Y overflows ? (Y >s -1 ? INTMAX : INTMIN) : X + Y --> sadd_sat X, Y 1950 NewIntrinsicID = Intrinsic::sadd_sat; 1951 else if (II->getIntrinsicID() == Intrinsic::ssub_with_overflow && 1952 IsSignedSaturateLimit(TrueVal, /*IsAdd=*/false)) 1953 // X - Y overflows ? (X <s 0 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1954 // X - Y overflows ? (X <s -1 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1955 // X - Y overflows ? (X >s -1 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1956 // X - Y overflows ? (X >s -2 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1957 // X - Y overflows ? (Y <s 0 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1958 // X - Y overflows ? (Y <s 1 ? INTMAX : INTMIN) : X - Y --> ssub_sat X, Y 1959 // X - Y overflows ? (Y >s 0 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1960 // X - Y overflows ? (Y >s -1 ? INTMIN : INTMAX) : X - Y --> ssub_sat X, Y 1961 NewIntrinsicID = Intrinsic::ssub_sat; 1962 else 1963 return nullptr; 1964 1965 Function *F = 1966 Intrinsic::getDeclaration(SI.getModule(), NewIntrinsicID, SI.getType()); 1967 return CallInst::Create(F, {X, Y}); 1968 } 1969 1970 Instruction *InstCombinerImpl::foldSelectExtConst(SelectInst &Sel) { 1971 Constant *C; 1972 if (!match(Sel.getTrueValue(), m_Constant(C)) && 1973 !match(Sel.getFalseValue(), m_Constant(C))) 1974 return nullptr; 1975 1976 Instruction *ExtInst; 1977 if (!match(Sel.getTrueValue(), m_Instruction(ExtInst)) && 1978 !match(Sel.getFalseValue(), m_Instruction(ExtInst))) 1979 return nullptr; 1980 1981 auto ExtOpcode = ExtInst->getOpcode(); 1982 if (ExtOpcode != Instruction::ZExt && ExtOpcode != Instruction::SExt) 1983 return nullptr; 1984 1985 // If we are extending from a boolean type or if we can create a select that 1986 // has the same size operands as its condition, try to narrow the select. 1987 Value *X = ExtInst->getOperand(0); 1988 Type *SmallType = X->getType(); 1989 Value *Cond = Sel.getCondition(); 1990 auto *Cmp = dyn_cast<CmpInst>(Cond); 1991 if (!SmallType->isIntOrIntVectorTy(1) && 1992 (!Cmp || Cmp->getOperand(0)->getType() != SmallType)) 1993 return nullptr; 1994 1995 // If the constant is the same after truncation to the smaller type and 1996 // extension to the original type, we can narrow the select. 1997 Type *SelType = Sel.getType(); 1998 Constant *TruncC = ConstantExpr::getTrunc(C, SmallType); 1999 Constant *ExtC = ConstantExpr::getCast(ExtOpcode, TruncC, SelType); 2000 if (ExtC == C && ExtInst->hasOneUse()) { 2001 Value *TruncCVal = cast<Value>(TruncC); 2002 if (ExtInst == Sel.getFalseValue()) 2003 std::swap(X, TruncCVal); 2004 2005 // select Cond, (ext X), C --> ext(select Cond, X, C') 2006 // select Cond, C, (ext X) --> ext(select Cond, C', X) 2007 Value *NewSel = Builder.CreateSelect(Cond, X, TruncCVal, "narrow", &Sel); 2008 return CastInst::Create(Instruction::CastOps(ExtOpcode), NewSel, SelType); 2009 } 2010 2011 // If one arm of the select is the extend of the condition, replace that arm 2012 // with the extension of the appropriate known bool value. 2013 if (Cond == X) { 2014 if (ExtInst == Sel.getTrueValue()) { 2015 // select X, (sext X), C --> select X, -1, C 2016 // select X, (zext X), C --> select X, 1, C 2017 Constant *One = ConstantInt::getTrue(SmallType); 2018 Constant *AllOnesOrOne = ConstantExpr::getCast(ExtOpcode, One, SelType); 2019 return SelectInst::Create(Cond, AllOnesOrOne, C, "", nullptr, &Sel); 2020 } else { 2021 // select X, C, (sext X) --> select X, C, 0 2022 // select X, C, (zext X) --> select X, C, 0 2023 Constant *Zero = ConstantInt::getNullValue(SelType); 2024 return SelectInst::Create(Cond, C, Zero, "", nullptr, &Sel); 2025 } 2026 } 2027 2028 return nullptr; 2029 } 2030 2031 /// Try to transform a vector select with a constant condition vector into a 2032 /// shuffle for easier combining with other shuffles and insert/extract. 2033 static Instruction *canonicalizeSelectToShuffle(SelectInst &SI) { 2034 Value *CondVal = SI.getCondition(); 2035 Constant *CondC; 2036 auto *CondValTy = dyn_cast<FixedVectorType>(CondVal->getType()); 2037 if (!CondValTy || !match(CondVal, m_Constant(CondC))) 2038 return nullptr; 2039 2040 unsigned NumElts = CondValTy->getNumElements(); 2041 SmallVector<int, 16> Mask; 2042 Mask.reserve(NumElts); 2043 for (unsigned i = 0; i != NumElts; ++i) { 2044 Constant *Elt = CondC->getAggregateElement(i); 2045 if (!Elt) 2046 return nullptr; 2047 2048 if (Elt->isOneValue()) { 2049 // If the select condition element is true, choose from the 1st vector. 2050 Mask.push_back(i); 2051 } else if (Elt->isNullValue()) { 2052 // If the select condition element is false, choose from the 2nd vector. 2053 Mask.push_back(i + NumElts); 2054 } else if (isa<UndefValue>(Elt)) { 2055 // Undef in a select condition (choose one of the operands) does not mean 2056 // the same thing as undef in a shuffle mask (any value is acceptable), so 2057 // give up. 2058 return nullptr; 2059 } else { 2060 // Bail out on a constant expression. 2061 return nullptr; 2062 } 2063 } 2064 2065 return new ShuffleVectorInst(SI.getTrueValue(), SI.getFalseValue(), Mask); 2066 } 2067 2068 /// If we have a select of vectors with a scalar condition, try to convert that 2069 /// to a vector select by splatting the condition. A splat may get folded with 2070 /// other operations in IR and having all operands of a select be vector types 2071 /// is likely better for vector codegen. 2072 static Instruction *canonicalizeScalarSelectOfVecs(SelectInst &Sel, 2073 InstCombinerImpl &IC) { 2074 auto *Ty = dyn_cast<VectorType>(Sel.getType()); 2075 if (!Ty) 2076 return nullptr; 2077 2078 // We can replace a single-use extract with constant index. 2079 Value *Cond = Sel.getCondition(); 2080 if (!match(Cond, m_OneUse(m_ExtractElt(m_Value(), m_ConstantInt())))) 2081 return nullptr; 2082 2083 // select (extelt V, Index), T, F --> select (splat V, Index), T, F 2084 // Splatting the extracted condition reduces code (we could directly create a 2085 // splat shuffle of the source vector to eliminate the intermediate step). 2086 return IC.replaceOperand( 2087 Sel, 0, IC.Builder.CreateVectorSplat(Ty->getElementCount(), Cond)); 2088 } 2089 2090 /// Reuse bitcasted operands between a compare and select: 2091 /// select (cmp (bitcast C), (bitcast D)), (bitcast' C), (bitcast' D) --> 2092 /// bitcast (select (cmp (bitcast C), (bitcast D)), (bitcast C), (bitcast D)) 2093 static Instruction *foldSelectCmpBitcasts(SelectInst &Sel, 2094 InstCombiner::BuilderTy &Builder) { 2095 Value *Cond = Sel.getCondition(); 2096 Value *TVal = Sel.getTrueValue(); 2097 Value *FVal = Sel.getFalseValue(); 2098 2099 CmpInst::Predicate Pred; 2100 Value *A, *B; 2101 if (!match(Cond, m_Cmp(Pred, m_Value(A), m_Value(B)))) 2102 return nullptr; 2103 2104 // The select condition is a compare instruction. If the select's true/false 2105 // values are already the same as the compare operands, there's nothing to do. 2106 if (TVal == A || TVal == B || FVal == A || FVal == B) 2107 return nullptr; 2108 2109 Value *C, *D; 2110 if (!match(A, m_BitCast(m_Value(C))) || !match(B, m_BitCast(m_Value(D)))) 2111 return nullptr; 2112 2113 // select (cmp (bitcast C), (bitcast D)), (bitcast TSrc), (bitcast FSrc) 2114 Value *TSrc, *FSrc; 2115 if (!match(TVal, m_BitCast(m_Value(TSrc))) || 2116 !match(FVal, m_BitCast(m_Value(FSrc)))) 2117 return nullptr; 2118 2119 // If the select true/false values are *different bitcasts* of the same source 2120 // operands, make the select operands the same as the compare operands and 2121 // cast the result. This is the canonical select form for min/max. 2122 Value *NewSel; 2123 if (TSrc == C && FSrc == D) { 2124 // select (cmp (bitcast C), (bitcast D)), (bitcast' C), (bitcast' D) --> 2125 // bitcast (select (cmp A, B), A, B) 2126 NewSel = Builder.CreateSelect(Cond, A, B, "", &Sel); 2127 } else if (TSrc == D && FSrc == C) { 2128 // select (cmp (bitcast C), (bitcast D)), (bitcast' D), (bitcast' C) --> 2129 // bitcast (select (cmp A, B), B, A) 2130 NewSel = Builder.CreateSelect(Cond, B, A, "", &Sel); 2131 } else { 2132 return nullptr; 2133 } 2134 return CastInst::CreateBitOrPointerCast(NewSel, Sel.getType()); 2135 } 2136 2137 /// Try to eliminate select instructions that test the returned flag of cmpxchg 2138 /// instructions. 2139 /// 2140 /// If a select instruction tests the returned flag of a cmpxchg instruction and 2141 /// selects between the returned value of the cmpxchg instruction its compare 2142 /// operand, the result of the select will always be equal to its false value. 2143 /// For example: 2144 /// 2145 /// %0 = cmpxchg i64* %ptr, i64 %compare, i64 %new_value seq_cst seq_cst 2146 /// %1 = extractvalue { i64, i1 } %0, 1 2147 /// %2 = extractvalue { i64, i1 } %0, 0 2148 /// %3 = select i1 %1, i64 %compare, i64 %2 2149 /// ret i64 %3 2150 /// 2151 /// The returned value of the cmpxchg instruction (%2) is the original value 2152 /// located at %ptr prior to any update. If the cmpxchg operation succeeds, %2 2153 /// must have been equal to %compare. Thus, the result of the select is always 2154 /// equal to %2, and the code can be simplified to: 2155 /// 2156 /// %0 = cmpxchg i64* %ptr, i64 %compare, i64 %new_value seq_cst seq_cst 2157 /// %1 = extractvalue { i64, i1 } %0, 0 2158 /// ret i64 %1 2159 /// 2160 static Value *foldSelectCmpXchg(SelectInst &SI) { 2161 // A helper that determines if V is an extractvalue instruction whose 2162 // aggregate operand is a cmpxchg instruction and whose single index is equal 2163 // to I. If such conditions are true, the helper returns the cmpxchg 2164 // instruction; otherwise, a nullptr is returned. 2165 auto isExtractFromCmpXchg = [](Value *V, unsigned I) -> AtomicCmpXchgInst * { 2166 auto *Extract = dyn_cast<ExtractValueInst>(V); 2167 if (!Extract) 2168 return nullptr; 2169 if (Extract->getIndices()[0] != I) 2170 return nullptr; 2171 return dyn_cast<AtomicCmpXchgInst>(Extract->getAggregateOperand()); 2172 }; 2173 2174 // If the select has a single user, and this user is a select instruction that 2175 // we can simplify, skip the cmpxchg simplification for now. 2176 if (SI.hasOneUse()) 2177 if (auto *Select = dyn_cast<SelectInst>(SI.user_back())) 2178 if (Select->getCondition() == SI.getCondition()) 2179 if (Select->getFalseValue() == SI.getTrueValue() || 2180 Select->getTrueValue() == SI.getFalseValue()) 2181 return nullptr; 2182 2183 // Ensure the select condition is the returned flag of a cmpxchg instruction. 2184 auto *CmpXchg = isExtractFromCmpXchg(SI.getCondition(), 1); 2185 if (!CmpXchg) 2186 return nullptr; 2187 2188 // Check the true value case: The true value of the select is the returned 2189 // value of the same cmpxchg used by the condition, and the false value is the 2190 // cmpxchg instruction's compare operand. 2191 if (auto *X = isExtractFromCmpXchg(SI.getTrueValue(), 0)) 2192 if (X == CmpXchg && X->getCompareOperand() == SI.getFalseValue()) 2193 return SI.getFalseValue(); 2194 2195 // Check the false value case: The false value of the select is the returned 2196 // value of the same cmpxchg used by the condition, and the true value is the 2197 // cmpxchg instruction's compare operand. 2198 if (auto *X = isExtractFromCmpXchg(SI.getFalseValue(), 0)) 2199 if (X == CmpXchg && X->getCompareOperand() == SI.getTrueValue()) 2200 return SI.getFalseValue(); 2201 2202 return nullptr; 2203 } 2204 2205 static Instruction *moveAddAfterMinMax(SelectPatternFlavor SPF, Value *X, 2206 Value *Y, 2207 InstCombiner::BuilderTy &Builder) { 2208 assert(SelectPatternResult::isMinOrMax(SPF) && "Expected min/max pattern"); 2209 bool IsUnsigned = SPF == SelectPatternFlavor::SPF_UMIN || 2210 SPF == SelectPatternFlavor::SPF_UMAX; 2211 // TODO: If InstSimplify could fold all cases where C2 <= C1, we could change 2212 // the constant value check to an assert. 2213 Value *A; 2214 const APInt *C1, *C2; 2215 if (IsUnsigned && match(X, m_NUWAdd(m_Value(A), m_APInt(C1))) && 2216 match(Y, m_APInt(C2)) && C2->uge(*C1) && X->hasNUses(2)) { 2217 // umin (add nuw A, C1), C2 --> add nuw (umin A, C2 - C1), C1 2218 // umax (add nuw A, C1), C2 --> add nuw (umax A, C2 - C1), C1 2219 Value *NewMinMax = createMinMax(Builder, SPF, A, 2220 ConstantInt::get(X->getType(), *C2 - *C1)); 2221 return BinaryOperator::CreateNUW(BinaryOperator::Add, NewMinMax, 2222 ConstantInt::get(X->getType(), *C1)); 2223 } 2224 2225 if (!IsUnsigned && match(X, m_NSWAdd(m_Value(A), m_APInt(C1))) && 2226 match(Y, m_APInt(C2)) && X->hasNUses(2)) { 2227 bool Overflow; 2228 APInt Diff = C2->ssub_ov(*C1, Overflow); 2229 if (!Overflow) { 2230 // smin (add nsw A, C1), C2 --> add nsw (smin A, C2 - C1), C1 2231 // smax (add nsw A, C1), C2 --> add nsw (smax A, C2 - C1), C1 2232 Value *NewMinMax = createMinMax(Builder, SPF, A, 2233 ConstantInt::get(X->getType(), Diff)); 2234 return BinaryOperator::CreateNSW(BinaryOperator::Add, NewMinMax, 2235 ConstantInt::get(X->getType(), *C1)); 2236 } 2237 } 2238 2239 return nullptr; 2240 } 2241 2242 /// Match a sadd_sat or ssub_sat which is using min/max to clamp the value. 2243 Instruction *InstCombinerImpl::matchSAddSubSat(Instruction &MinMax1) { 2244 Type *Ty = MinMax1.getType(); 2245 2246 // We are looking for a tree of: 2247 // max(INT_MIN, min(INT_MAX, add(sext(A), sext(B)))) 2248 // Where the min and max could be reversed 2249 Instruction *MinMax2; 2250 BinaryOperator *AddSub; 2251 const APInt *MinValue, *MaxValue; 2252 if (match(&MinMax1, m_SMin(m_Instruction(MinMax2), m_APInt(MaxValue)))) { 2253 if (!match(MinMax2, m_SMax(m_BinOp(AddSub), m_APInt(MinValue)))) 2254 return nullptr; 2255 } else if (match(&MinMax1, 2256 m_SMax(m_Instruction(MinMax2), m_APInt(MinValue)))) { 2257 if (!match(MinMax2, m_SMin(m_BinOp(AddSub), m_APInt(MaxValue)))) 2258 return nullptr; 2259 } else 2260 return nullptr; 2261 2262 // Check that the constants clamp a saturate, and that the new type would be 2263 // sensible to convert to. 2264 if (!(*MaxValue + 1).isPowerOf2() || -*MinValue != *MaxValue + 1) 2265 return nullptr; 2266 // In what bitwidth can this be treated as saturating arithmetics? 2267 unsigned NewBitWidth = (*MaxValue + 1).logBase2() + 1; 2268 // FIXME: This isn't quite right for vectors, but using the scalar type is a 2269 // good first approximation for what should be done there. 2270 if (!shouldChangeType(Ty->getScalarType()->getIntegerBitWidth(), NewBitWidth)) 2271 return nullptr; 2272 2273 // Also make sure that the number of uses is as expected. The 3 is for the 2274 // the two items of the compare and the select, or 2 from a min/max. 2275 unsigned ExpUses = isa<IntrinsicInst>(MinMax1) ? 2 : 3; 2276 if (MinMax2->hasNUsesOrMore(ExpUses) || AddSub->hasNUsesOrMore(ExpUses)) 2277 return nullptr; 2278 2279 // Create the new type (which can be a vector type) 2280 Type *NewTy = Ty->getWithNewBitWidth(NewBitWidth); 2281 // Match the two extends from the add/sub 2282 Value *A, *B; 2283 if(!match(AddSub, m_BinOp(m_SExt(m_Value(A)), m_SExt(m_Value(B))))) 2284 return nullptr; 2285 // And check the incoming values are of a type smaller than or equal to the 2286 // size of the saturation. Otherwise the higher bits can cause different 2287 // results. 2288 if (A->getType()->getScalarSizeInBits() > NewBitWidth || 2289 B->getType()->getScalarSizeInBits() > NewBitWidth) 2290 return nullptr; 2291 2292 Intrinsic::ID IntrinsicID; 2293 if (AddSub->getOpcode() == Instruction::Add) 2294 IntrinsicID = Intrinsic::sadd_sat; 2295 else if (AddSub->getOpcode() == Instruction::Sub) 2296 IntrinsicID = Intrinsic::ssub_sat; 2297 else 2298 return nullptr; 2299 2300 // Finally create and return the sat intrinsic, truncated to the new type 2301 Function *F = Intrinsic::getDeclaration(MinMax1.getModule(), IntrinsicID, NewTy); 2302 Value *AT = Builder.CreateSExt(A, NewTy); 2303 Value *BT = Builder.CreateSExt(B, NewTy); 2304 Value *Sat = Builder.CreateCall(F, {AT, BT}); 2305 return CastInst::Create(Instruction::SExt, Sat, Ty); 2306 } 2307 2308 /// Reduce a sequence of min/max with a common operand. 2309 static Instruction *factorizeMinMaxTree(SelectPatternFlavor SPF, Value *LHS, 2310 Value *RHS, 2311 InstCombiner::BuilderTy &Builder) { 2312 assert(SelectPatternResult::isMinOrMax(SPF) && "Expected a min/max"); 2313 // TODO: Allow FP min/max with nnan/nsz. 2314 if (!LHS->getType()->isIntOrIntVectorTy()) 2315 return nullptr; 2316 2317 // Match 3 of the same min/max ops. Example: umin(umin(), umin()). 2318 Value *A, *B, *C, *D; 2319 SelectPatternResult L = matchSelectPattern(LHS, A, B); 2320 SelectPatternResult R = matchSelectPattern(RHS, C, D); 2321 if (SPF != L.Flavor || L.Flavor != R.Flavor) 2322 return nullptr; 2323 2324 // Look for a common operand. The use checks are different than usual because 2325 // a min/max pattern typically has 2 uses of each op: 1 by the cmp and 1 by 2326 // the select. 2327 Value *MinMaxOp = nullptr; 2328 Value *ThirdOp = nullptr; 2329 if (!LHS->hasNUsesOrMore(3) && RHS->hasNUsesOrMore(3)) { 2330 // If the LHS is only used in this chain and the RHS is used outside of it, 2331 // reuse the RHS min/max because that will eliminate the LHS. 2332 if (D == A || C == A) { 2333 // min(min(a, b), min(c, a)) --> min(min(c, a), b) 2334 // min(min(a, b), min(a, d)) --> min(min(a, d), b) 2335 MinMaxOp = RHS; 2336 ThirdOp = B; 2337 } else if (D == B || C == B) { 2338 // min(min(a, b), min(c, b)) --> min(min(c, b), a) 2339 // min(min(a, b), min(b, d)) --> min(min(b, d), a) 2340 MinMaxOp = RHS; 2341 ThirdOp = A; 2342 } 2343 } else if (!RHS->hasNUsesOrMore(3)) { 2344 // Reuse the LHS. This will eliminate the RHS. 2345 if (D == A || D == B) { 2346 // min(min(a, b), min(c, a)) --> min(min(a, b), c) 2347 // min(min(a, b), min(c, b)) --> min(min(a, b), c) 2348 MinMaxOp = LHS; 2349 ThirdOp = C; 2350 } else if (C == A || C == B) { 2351 // min(min(a, b), min(b, d)) --> min(min(a, b), d) 2352 // min(min(a, b), min(c, b)) --> min(min(a, b), d) 2353 MinMaxOp = LHS; 2354 ThirdOp = D; 2355 } 2356 } 2357 if (!MinMaxOp || !ThirdOp) 2358 return nullptr; 2359 2360 CmpInst::Predicate P = getMinMaxPred(SPF); 2361 Value *CmpABC = Builder.CreateICmp(P, MinMaxOp, ThirdOp); 2362 return SelectInst::Create(CmpABC, MinMaxOp, ThirdOp); 2363 } 2364 2365 /// Try to reduce a funnel/rotate pattern that includes a compare and select 2366 /// into a funnel shift intrinsic. Example: 2367 /// rotl32(a, b) --> (b == 0 ? a : ((a >> (32 - b)) | (a << b))) 2368 /// --> call llvm.fshl.i32(a, a, b) 2369 /// fshl32(a, b, c) --> (c == 0 ? a : ((b >> (32 - c)) | (a << c))) 2370 /// --> call llvm.fshl.i32(a, b, c) 2371 /// fshr32(a, b, c) --> (c == 0 ? b : ((a >> (32 - c)) | (b << c))) 2372 /// --> call llvm.fshr.i32(a, b, c) 2373 static Instruction *foldSelectFunnelShift(SelectInst &Sel, 2374 InstCombiner::BuilderTy &Builder) { 2375 // This must be a power-of-2 type for a bitmasking transform to be valid. 2376 unsigned Width = Sel.getType()->getScalarSizeInBits(); 2377 if (!isPowerOf2_32(Width)) 2378 return nullptr; 2379 2380 BinaryOperator *Or0, *Or1; 2381 if (!match(Sel.getFalseValue(), m_OneUse(m_Or(m_BinOp(Or0), m_BinOp(Or1))))) 2382 return nullptr; 2383 2384 Value *SV0, *SV1, *SA0, *SA1; 2385 if (!match(Or0, m_OneUse(m_LogicalShift(m_Value(SV0), 2386 m_ZExtOrSelf(m_Value(SA0))))) || 2387 !match(Or1, m_OneUse(m_LogicalShift(m_Value(SV1), 2388 m_ZExtOrSelf(m_Value(SA1))))) || 2389 Or0->getOpcode() == Or1->getOpcode()) 2390 return nullptr; 2391 2392 // Canonicalize to or(shl(SV0, SA0), lshr(SV1, SA1)). 2393 if (Or0->getOpcode() == BinaryOperator::LShr) { 2394 std::swap(Or0, Or1); 2395 std::swap(SV0, SV1); 2396 std::swap(SA0, SA1); 2397 } 2398 assert(Or0->getOpcode() == BinaryOperator::Shl && 2399 Or1->getOpcode() == BinaryOperator::LShr && 2400 "Illegal or(shift,shift) pair"); 2401 2402 // Check the shift amounts to see if they are an opposite pair. 2403 Value *ShAmt; 2404 if (match(SA1, m_OneUse(m_Sub(m_SpecificInt(Width), m_Specific(SA0))))) 2405 ShAmt = SA0; 2406 else if (match(SA0, m_OneUse(m_Sub(m_SpecificInt(Width), m_Specific(SA1))))) 2407 ShAmt = SA1; 2408 else 2409 return nullptr; 2410 2411 // We should now have this pattern: 2412 // select ?, TVal, (or (shl SV0, SA0), (lshr SV1, SA1)) 2413 // The false value of the select must be a funnel-shift of the true value: 2414 // IsFShl -> TVal must be SV0 else TVal must be SV1. 2415 bool IsFshl = (ShAmt == SA0); 2416 Value *TVal = Sel.getTrueValue(); 2417 if ((IsFshl && TVal != SV0) || (!IsFshl && TVal != SV1)) 2418 return nullptr; 2419 2420 // Finally, see if the select is filtering out a shift-by-zero. 2421 Value *Cond = Sel.getCondition(); 2422 ICmpInst::Predicate Pred; 2423 if (!match(Cond, m_OneUse(m_ICmp(Pred, m_Specific(ShAmt), m_ZeroInt()))) || 2424 Pred != ICmpInst::ICMP_EQ) 2425 return nullptr; 2426 2427 // If this is not a rotate then the select was blocking poison from the 2428 // 'shift-by-zero' non-TVal, but a funnel shift won't - so freeze it. 2429 if (SV0 != SV1) { 2430 if (IsFshl && !llvm::isGuaranteedNotToBePoison(SV1)) 2431 SV1 = Builder.CreateFreeze(SV1); 2432 else if (!IsFshl && !llvm::isGuaranteedNotToBePoison(SV0)) 2433 SV0 = Builder.CreateFreeze(SV0); 2434 } 2435 2436 // This is a funnel/rotate that avoids shift-by-bitwidth UB in a suboptimal way. 2437 // Convert to funnel shift intrinsic. 2438 Intrinsic::ID IID = IsFshl ? Intrinsic::fshl : Intrinsic::fshr; 2439 Function *F = Intrinsic::getDeclaration(Sel.getModule(), IID, Sel.getType()); 2440 ShAmt = Builder.CreateZExt(ShAmt, Sel.getType()); 2441 return CallInst::Create(F, { SV0, SV1, ShAmt }); 2442 } 2443 2444 static Instruction *foldSelectToCopysign(SelectInst &Sel, 2445 InstCombiner::BuilderTy &Builder) { 2446 Value *Cond = Sel.getCondition(); 2447 Value *TVal = Sel.getTrueValue(); 2448 Value *FVal = Sel.getFalseValue(); 2449 Type *SelType = Sel.getType(); 2450 2451 // Match select ?, TC, FC where the constants are equal but negated. 2452 // TODO: Generalize to handle a negated variable operand? 2453 const APFloat *TC, *FC; 2454 if (!match(TVal, m_APFloat(TC)) || !match(FVal, m_APFloat(FC)) || 2455 !abs(*TC).bitwiseIsEqual(abs(*FC))) 2456 return nullptr; 2457 2458 assert(TC != FC && "Expected equal select arms to simplify"); 2459 2460 Value *X; 2461 const APInt *C; 2462 bool IsTrueIfSignSet; 2463 ICmpInst::Predicate Pred; 2464 if (!match(Cond, m_OneUse(m_ICmp(Pred, m_BitCast(m_Value(X)), m_APInt(C)))) || 2465 !InstCombiner::isSignBitCheck(Pred, *C, IsTrueIfSignSet) || 2466 X->getType() != SelType) 2467 return nullptr; 2468 2469 // If needed, negate the value that will be the sign argument of the copysign: 2470 // (bitcast X) < 0 ? -TC : TC --> copysign(TC, X) 2471 // (bitcast X) < 0 ? TC : -TC --> copysign(TC, -X) 2472 // (bitcast X) >= 0 ? -TC : TC --> copysign(TC, -X) 2473 // (bitcast X) >= 0 ? TC : -TC --> copysign(TC, X) 2474 if (IsTrueIfSignSet ^ TC->isNegative()) 2475 X = Builder.CreateFNegFMF(X, &Sel); 2476 2477 // Canonicalize the magnitude argument as the positive constant since we do 2478 // not care about its sign. 2479 Value *MagArg = TC->isNegative() ? FVal : TVal; 2480 Function *F = Intrinsic::getDeclaration(Sel.getModule(), Intrinsic::copysign, 2481 Sel.getType()); 2482 Instruction *CopySign = CallInst::Create(F, { MagArg, X }); 2483 CopySign->setFastMathFlags(Sel.getFastMathFlags()); 2484 return CopySign; 2485 } 2486 2487 Instruction *InstCombinerImpl::foldVectorSelect(SelectInst &Sel) { 2488 auto *VecTy = dyn_cast<FixedVectorType>(Sel.getType()); 2489 if (!VecTy) 2490 return nullptr; 2491 2492 unsigned NumElts = VecTy->getNumElements(); 2493 APInt UndefElts(NumElts, 0); 2494 APInt AllOnesEltMask(APInt::getAllOnes(NumElts)); 2495 if (Value *V = SimplifyDemandedVectorElts(&Sel, AllOnesEltMask, UndefElts)) { 2496 if (V != &Sel) 2497 return replaceInstUsesWith(Sel, V); 2498 return &Sel; 2499 } 2500 2501 // A select of a "select shuffle" with a common operand can be rearranged 2502 // to select followed by "select shuffle". Because of poison, this only works 2503 // in the case of a shuffle with no undefined mask elements. 2504 Value *Cond = Sel.getCondition(); 2505 Value *TVal = Sel.getTrueValue(); 2506 Value *FVal = Sel.getFalseValue(); 2507 Value *X, *Y; 2508 ArrayRef<int> Mask; 2509 if (match(TVal, m_OneUse(m_Shuffle(m_Value(X), m_Value(Y), m_Mask(Mask)))) && 2510 !is_contained(Mask, UndefMaskElem) && 2511 cast<ShuffleVectorInst>(TVal)->isSelect()) { 2512 if (X == FVal) { 2513 // select Cond, (shuf_sel X, Y), X --> shuf_sel X, (select Cond, Y, X) 2514 Value *NewSel = Builder.CreateSelect(Cond, Y, X, "sel", &Sel); 2515 return new ShuffleVectorInst(X, NewSel, Mask); 2516 } 2517 if (Y == FVal) { 2518 // select Cond, (shuf_sel X, Y), Y --> shuf_sel (select Cond, X, Y), Y 2519 Value *NewSel = Builder.CreateSelect(Cond, X, Y, "sel", &Sel); 2520 return new ShuffleVectorInst(NewSel, Y, Mask); 2521 } 2522 } 2523 if (match(FVal, m_OneUse(m_Shuffle(m_Value(X), m_Value(Y), m_Mask(Mask)))) && 2524 !is_contained(Mask, UndefMaskElem) && 2525 cast<ShuffleVectorInst>(FVal)->isSelect()) { 2526 if (X == TVal) { 2527 // select Cond, X, (shuf_sel X, Y) --> shuf_sel X, (select Cond, X, Y) 2528 Value *NewSel = Builder.CreateSelect(Cond, X, Y, "sel", &Sel); 2529 return new ShuffleVectorInst(X, NewSel, Mask); 2530 } 2531 if (Y == TVal) { 2532 // select Cond, Y, (shuf_sel X, Y) --> shuf_sel (select Cond, Y, X), Y 2533 Value *NewSel = Builder.CreateSelect(Cond, Y, X, "sel", &Sel); 2534 return new ShuffleVectorInst(NewSel, Y, Mask); 2535 } 2536 } 2537 2538 return nullptr; 2539 } 2540 2541 static Instruction *foldSelectToPhiImpl(SelectInst &Sel, BasicBlock *BB, 2542 const DominatorTree &DT, 2543 InstCombiner::BuilderTy &Builder) { 2544 // Find the block's immediate dominator that ends with a conditional branch 2545 // that matches select's condition (maybe inverted). 2546 auto *IDomNode = DT[BB]->getIDom(); 2547 if (!IDomNode) 2548 return nullptr; 2549 BasicBlock *IDom = IDomNode->getBlock(); 2550 2551 Value *Cond = Sel.getCondition(); 2552 Value *IfTrue, *IfFalse; 2553 BasicBlock *TrueSucc, *FalseSucc; 2554 if (match(IDom->getTerminator(), 2555 m_Br(m_Specific(Cond), m_BasicBlock(TrueSucc), 2556 m_BasicBlock(FalseSucc)))) { 2557 IfTrue = Sel.getTrueValue(); 2558 IfFalse = Sel.getFalseValue(); 2559 } else if (match(IDom->getTerminator(), 2560 m_Br(m_Not(m_Specific(Cond)), m_BasicBlock(TrueSucc), 2561 m_BasicBlock(FalseSucc)))) { 2562 IfTrue = Sel.getFalseValue(); 2563 IfFalse = Sel.getTrueValue(); 2564 } else 2565 return nullptr; 2566 2567 // Make sure the branches are actually different. 2568 if (TrueSucc == FalseSucc) 2569 return nullptr; 2570 2571 // We want to replace select %cond, %a, %b with a phi that takes value %a 2572 // for all incoming edges that are dominated by condition `%cond == true`, 2573 // and value %b for edges dominated by condition `%cond == false`. If %a 2574 // or %b are also phis from the same basic block, we can go further and take 2575 // their incoming values from the corresponding blocks. 2576 BasicBlockEdge TrueEdge(IDom, TrueSucc); 2577 BasicBlockEdge FalseEdge(IDom, FalseSucc); 2578 DenseMap<BasicBlock *, Value *> Inputs; 2579 for (auto *Pred : predecessors(BB)) { 2580 // Check implication. 2581 BasicBlockEdge Incoming(Pred, BB); 2582 if (DT.dominates(TrueEdge, Incoming)) 2583 Inputs[Pred] = IfTrue->DoPHITranslation(BB, Pred); 2584 else if (DT.dominates(FalseEdge, Incoming)) 2585 Inputs[Pred] = IfFalse->DoPHITranslation(BB, Pred); 2586 else 2587 return nullptr; 2588 // Check availability. 2589 if (auto *Insn = dyn_cast<Instruction>(Inputs[Pred])) 2590 if (!DT.dominates(Insn, Pred->getTerminator())) 2591 return nullptr; 2592 } 2593 2594 Builder.SetInsertPoint(&*BB->begin()); 2595 auto *PN = Builder.CreatePHI(Sel.getType(), Inputs.size()); 2596 for (auto *Pred : predecessors(BB)) 2597 PN->addIncoming(Inputs[Pred], Pred); 2598 PN->takeName(&Sel); 2599 return PN; 2600 } 2601 2602 static Instruction *foldSelectToPhi(SelectInst &Sel, const DominatorTree &DT, 2603 InstCombiner::BuilderTy &Builder) { 2604 // Try to replace this select with Phi in one of these blocks. 2605 SmallSetVector<BasicBlock *, 4> CandidateBlocks; 2606 CandidateBlocks.insert(Sel.getParent()); 2607 for (Value *V : Sel.operands()) 2608 if (auto *I = dyn_cast<Instruction>(V)) 2609 CandidateBlocks.insert(I->getParent()); 2610 2611 for (BasicBlock *BB : CandidateBlocks) 2612 if (auto *PN = foldSelectToPhiImpl(Sel, BB, DT, Builder)) 2613 return PN; 2614 return nullptr; 2615 } 2616 2617 static Value *foldSelectWithFrozenICmp(SelectInst &Sel, InstCombiner::BuilderTy &Builder) { 2618 FreezeInst *FI = dyn_cast<FreezeInst>(Sel.getCondition()); 2619 if (!FI) 2620 return nullptr; 2621 2622 Value *Cond = FI->getOperand(0); 2623 Value *TrueVal = Sel.getTrueValue(), *FalseVal = Sel.getFalseValue(); 2624 2625 // select (freeze(x == y)), x, y --> y 2626 // select (freeze(x != y)), x, y --> x 2627 // The freeze should be only used by this select. Otherwise, remaining uses of 2628 // the freeze can observe a contradictory value. 2629 // c = freeze(x == y) ; Let's assume that y = poison & x = 42; c is 0 or 1 2630 // a = select c, x, y ; 2631 // f(a, c) ; f(poison, 1) cannot happen, but if a is folded 2632 // ; to y, this can happen. 2633 CmpInst::Predicate Pred; 2634 if (FI->hasOneUse() && 2635 match(Cond, m_c_ICmp(Pred, m_Specific(TrueVal), m_Specific(FalseVal))) && 2636 (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE)) { 2637 return Pred == ICmpInst::ICMP_EQ ? FalseVal : TrueVal; 2638 } 2639 2640 return nullptr; 2641 } 2642 2643 Instruction *InstCombinerImpl::foldAndOrOfSelectUsingImpliedCond(Value *Op, 2644 SelectInst &SI, 2645 bool IsAnd) { 2646 Value *CondVal = SI.getCondition(); 2647 Value *A = SI.getTrueValue(); 2648 Value *B = SI.getFalseValue(); 2649 2650 assert(Op->getType()->isIntOrIntVectorTy(1) && 2651 "Op must be either i1 or vector of i1."); 2652 2653 Optional<bool> Res = isImpliedCondition(Op, CondVal, DL, IsAnd); 2654 if (!Res) 2655 return nullptr; 2656 2657 Value *Zero = Constant::getNullValue(A->getType()); 2658 Value *One = Constant::getAllOnesValue(A->getType()); 2659 2660 if (*Res == true) { 2661 if (IsAnd) 2662 // select op, (select cond, A, B), false => select op, A, false 2663 // and op, (select cond, A, B) => select op, A, false 2664 // if op = true implies condval = true. 2665 return SelectInst::Create(Op, A, Zero); 2666 else 2667 // select op, true, (select cond, A, B) => select op, true, A 2668 // or op, (select cond, A, B) => select op, true, A 2669 // if op = false implies condval = true. 2670 return SelectInst::Create(Op, One, A); 2671 } else { 2672 if (IsAnd) 2673 // select op, (select cond, A, B), false => select op, B, false 2674 // and op, (select cond, A, B) => select op, B, false 2675 // if op = true implies condval = false. 2676 return SelectInst::Create(Op, B, Zero); 2677 else 2678 // select op, true, (select cond, A, B) => select op, true, B 2679 // or op, (select cond, A, B) => select op, true, B 2680 // if op = false implies condval = false. 2681 return SelectInst::Create(Op, One, B); 2682 } 2683 } 2684 2685 Instruction *InstCombinerImpl::visitSelectInst(SelectInst &SI) { 2686 Value *CondVal = SI.getCondition(); 2687 Value *TrueVal = SI.getTrueValue(); 2688 Value *FalseVal = SI.getFalseValue(); 2689 Type *SelType = SI.getType(); 2690 2691 // FIXME: Remove this workaround when freeze related patches are done. 2692 // For select with undef operand which feeds into an equality comparison, 2693 // don't simplify it so loop unswitch can know the equality comparison 2694 // may have an undef operand. This is a workaround for PR31652 caused by 2695 // descrepancy about branch on undef between LoopUnswitch and GVN. 2696 if (match(TrueVal, m_Undef()) || match(FalseVal, m_Undef())) { 2697 if (llvm::any_of(SI.users(), [&](User *U) { 2698 ICmpInst *CI = dyn_cast<ICmpInst>(U); 2699 if (CI && CI->isEquality()) 2700 return true; 2701 return false; 2702 })) { 2703 return nullptr; 2704 } 2705 } 2706 2707 if (Value *V = SimplifySelectInst(CondVal, TrueVal, FalseVal, 2708 SQ.getWithInstruction(&SI))) 2709 return replaceInstUsesWith(SI, V); 2710 2711 if (Instruction *I = canonicalizeSelectToShuffle(SI)) 2712 return I; 2713 2714 if (Instruction *I = canonicalizeScalarSelectOfVecs(SI, *this)) 2715 return I; 2716 2717 CmpInst::Predicate Pred; 2718 2719 // Avoid potential infinite loops by checking for non-constant condition. 2720 // TODO: Can we assert instead by improving canonicalizeSelectToShuffle()? 2721 // Scalar select must have simplified? 2722 if (SelType->isIntOrIntVectorTy(1) && !isa<Constant>(CondVal) && 2723 TrueVal->getType() == CondVal->getType()) { 2724 // Folding select to and/or i1 isn't poison safe in general. impliesPoison 2725 // checks whether folding it does not convert a well-defined value into 2726 // poison. 2727 if (match(TrueVal, m_One()) && impliesPoison(FalseVal, CondVal)) { 2728 // Change: A = select B, true, C --> A = or B, C 2729 return BinaryOperator::CreateOr(CondVal, FalseVal); 2730 } 2731 if (match(FalseVal, m_Zero()) && impliesPoison(TrueVal, CondVal)) { 2732 // Change: A = select B, C, false --> A = and B, C 2733 return BinaryOperator::CreateAnd(CondVal, TrueVal); 2734 } 2735 2736 auto *One = ConstantInt::getTrue(SelType); 2737 auto *Zero = ConstantInt::getFalse(SelType); 2738 2739 // We match the "full" 0 or 1 constant here to avoid a potential infinite 2740 // loop with vectors that may have undefined/poison elements. 2741 // select a, false, b -> select !a, b, false 2742 if (match(TrueVal, m_Specific(Zero))) { 2743 Value *NotCond = Builder.CreateNot(CondVal, "not." + CondVal->getName()); 2744 return SelectInst::Create(NotCond, FalseVal, Zero); 2745 } 2746 // select a, b, true -> select !a, true, b 2747 if (match(FalseVal, m_Specific(One))) { 2748 Value *NotCond = Builder.CreateNot(CondVal, "not." + CondVal->getName()); 2749 return SelectInst::Create(NotCond, One, TrueVal); 2750 } 2751 2752 // select a, a, b -> select a, true, b 2753 if (CondVal == TrueVal) 2754 return replaceOperand(SI, 1, One); 2755 // select a, b, a -> select a, b, false 2756 if (CondVal == FalseVal) 2757 return replaceOperand(SI, 2, Zero); 2758 2759 // select a, !a, b -> select !a, b, false 2760 if (match(TrueVal, m_Not(m_Specific(CondVal)))) 2761 return SelectInst::Create(TrueVal, FalseVal, Zero); 2762 // select a, b, !a -> select !a, true, b 2763 if (match(FalseVal, m_Not(m_Specific(CondVal)))) 2764 return SelectInst::Create(FalseVal, One, TrueVal); 2765 2766 Value *A, *B; 2767 2768 // DeMorgan in select form: !a && !b --> !(a || b) 2769 // select !a, !b, false --> not (select a, true, b) 2770 if (match(&SI, m_LogicalAnd(m_Not(m_Value(A)), m_Not(m_Value(B)))) && 2771 (CondVal->hasOneUse() || TrueVal->hasOneUse()) && 2772 !match(A, m_ConstantExpr()) && !match(B, m_ConstantExpr())) 2773 return BinaryOperator::CreateNot(Builder.CreateSelect(A, One, B)); 2774 2775 // DeMorgan in select form: !a || !b --> !(a && b) 2776 // select !a, true, !b --> not (select a, b, false) 2777 if (match(&SI, m_LogicalOr(m_Not(m_Value(A)), m_Not(m_Value(B)))) && 2778 (CondVal->hasOneUse() || FalseVal->hasOneUse()) && 2779 !match(A, m_ConstantExpr()) && !match(B, m_ConstantExpr())) 2780 return BinaryOperator::CreateNot(Builder.CreateSelect(A, B, Zero)); 2781 2782 // select (select a, true, b), true, b -> select a, true, b 2783 if (match(CondVal, m_Select(m_Value(A), m_One(), m_Value(B))) && 2784 match(TrueVal, m_One()) && match(FalseVal, m_Specific(B))) 2785 return replaceOperand(SI, 0, A); 2786 // select (select a, b, false), b, false -> select a, b, false 2787 if (match(CondVal, m_Select(m_Value(A), m_Value(B), m_Zero())) && 2788 match(TrueVal, m_Specific(B)) && match(FalseVal, m_Zero())) 2789 return replaceOperand(SI, 0, A); 2790 2791 if (!SelType->isVectorTy()) { 2792 if (Value *S = simplifyWithOpReplaced(TrueVal, CondVal, One, SQ, 2793 /* AllowRefinement */ true)) 2794 return replaceOperand(SI, 1, S); 2795 if (Value *S = simplifyWithOpReplaced(FalseVal, CondVal, Zero, SQ, 2796 /* AllowRefinement */ true)) 2797 return replaceOperand(SI, 2, S); 2798 } 2799 2800 if (match(FalseVal, m_Zero()) || match(TrueVal, m_One())) { 2801 Use *Y = nullptr; 2802 bool IsAnd = match(FalseVal, m_Zero()) ? true : false; 2803 Value *Op1 = IsAnd ? TrueVal : FalseVal; 2804 if (isCheckForZeroAndMulWithOverflow(CondVal, Op1, IsAnd, Y)) { 2805 auto *FI = new FreezeInst(*Y, (*Y)->getName() + ".fr"); 2806 InsertNewInstBefore(FI, *cast<Instruction>(Y->getUser())); 2807 replaceUse(*Y, FI); 2808 return replaceInstUsesWith(SI, Op1); 2809 } 2810 2811 if (auto *Op1SI = dyn_cast<SelectInst>(Op1)) 2812 if (auto *I = foldAndOrOfSelectUsingImpliedCond(CondVal, *Op1SI, 2813 /* IsAnd */ IsAnd)) 2814 return I; 2815 2816 if (auto *ICmp0 = dyn_cast<ICmpInst>(CondVal)) { 2817 if (auto *ICmp1 = dyn_cast<ICmpInst>(Op1)) { 2818 if (auto *V = foldAndOrOfICmpsOfAndWithPow2(ICmp0, ICmp1, &SI, IsAnd, 2819 /* IsLogical */ true)) 2820 return replaceInstUsesWith(SI, V); 2821 2822 if (auto *V = foldEqOfParts(ICmp0, ICmp1, IsAnd)) 2823 return replaceInstUsesWith(SI, V); 2824 } 2825 } 2826 } 2827 2828 // select (select a, true, b), c, false -> select a, c, false 2829 // select c, (select a, true, b), false -> select c, a, false 2830 // if c implies that b is false. 2831 if (match(CondVal, m_Select(m_Value(A), m_One(), m_Value(B))) && 2832 match(FalseVal, m_Zero())) { 2833 Optional<bool> Res = isImpliedCondition(TrueVal, B, DL); 2834 if (Res && *Res == false) 2835 return replaceOperand(SI, 0, A); 2836 } 2837 if (match(TrueVal, m_Select(m_Value(A), m_One(), m_Value(B))) && 2838 match(FalseVal, m_Zero())) { 2839 Optional<bool> Res = isImpliedCondition(CondVal, B, DL); 2840 if (Res && *Res == false) 2841 return replaceOperand(SI, 1, A); 2842 } 2843 // select c, true, (select a, b, false) -> select c, true, a 2844 // select (select a, b, false), true, c -> select a, true, c 2845 // if c = false implies that b = true 2846 if (match(TrueVal, m_One()) && 2847 match(FalseVal, m_Select(m_Value(A), m_Value(B), m_Zero()))) { 2848 Optional<bool> Res = isImpliedCondition(CondVal, B, DL, false); 2849 if (Res && *Res == true) 2850 return replaceOperand(SI, 2, A); 2851 } 2852 if (match(CondVal, m_Select(m_Value(A), m_Value(B), m_Zero())) && 2853 match(TrueVal, m_One())) { 2854 Optional<bool> Res = isImpliedCondition(FalseVal, B, DL, false); 2855 if (Res && *Res == true) 2856 return replaceOperand(SI, 0, A); 2857 } 2858 2859 // sel (sel c, a, false), true, (sel !c, b, false) -> sel c, a, b 2860 // sel (sel !c, a, false), true, (sel c, b, false) -> sel c, b, a 2861 Value *C1, *C2; 2862 if (match(CondVal, m_Select(m_Value(C1), m_Value(A), m_Zero())) && 2863 match(TrueVal, m_One()) && 2864 match(FalseVal, m_Select(m_Value(C2), m_Value(B), m_Zero()))) { 2865 if (match(C2, m_Not(m_Specific(C1)))) // first case 2866 return SelectInst::Create(C1, A, B); 2867 else if (match(C1, m_Not(m_Specific(C2)))) // second case 2868 return SelectInst::Create(C2, B, A); 2869 } 2870 } 2871 2872 // Selecting between two integer or vector splat integer constants? 2873 // 2874 // Note that we don't handle a scalar select of vectors: 2875 // select i1 %c, <2 x i8> <1, 1>, <2 x i8> <0, 0> 2876 // because that may need 3 instructions to splat the condition value: 2877 // extend, insertelement, shufflevector. 2878 // 2879 // Do not handle i1 TrueVal and FalseVal otherwise would result in 2880 // zext/sext i1 to i1. 2881 if (SelType->isIntOrIntVectorTy() && !SelType->isIntOrIntVectorTy(1) && 2882 CondVal->getType()->isVectorTy() == SelType->isVectorTy()) { 2883 // select C, 1, 0 -> zext C to int 2884 if (match(TrueVal, m_One()) && match(FalseVal, m_Zero())) 2885 return new ZExtInst(CondVal, SelType); 2886 2887 // select C, -1, 0 -> sext C to int 2888 if (match(TrueVal, m_AllOnes()) && match(FalseVal, m_Zero())) 2889 return new SExtInst(CondVal, SelType); 2890 2891 // select C, 0, 1 -> zext !C to int 2892 if (match(TrueVal, m_Zero()) && match(FalseVal, m_One())) { 2893 Value *NotCond = Builder.CreateNot(CondVal, "not." + CondVal->getName()); 2894 return new ZExtInst(NotCond, SelType); 2895 } 2896 2897 // select C, 0, -1 -> sext !C to int 2898 if (match(TrueVal, m_Zero()) && match(FalseVal, m_AllOnes())) { 2899 Value *NotCond = Builder.CreateNot(CondVal, "not." + CondVal->getName()); 2900 return new SExtInst(NotCond, SelType); 2901 } 2902 } 2903 2904 if (auto *FCmp = dyn_cast<FCmpInst>(CondVal)) { 2905 Value *Cmp0 = FCmp->getOperand(0), *Cmp1 = FCmp->getOperand(1); 2906 // Are we selecting a value based on a comparison of the two values? 2907 if ((Cmp0 == TrueVal && Cmp1 == FalseVal) || 2908 (Cmp0 == FalseVal && Cmp1 == TrueVal)) { 2909 // Canonicalize to use ordered comparisons by swapping the select 2910 // operands. 2911 // 2912 // e.g. 2913 // (X ugt Y) ? X : Y -> (X ole Y) ? Y : X 2914 if (FCmp->hasOneUse() && FCmpInst::isUnordered(FCmp->getPredicate())) { 2915 FCmpInst::Predicate InvPred = FCmp->getInversePredicate(); 2916 IRBuilder<>::FastMathFlagGuard FMFG(Builder); 2917 // FIXME: The FMF should propagate from the select, not the fcmp. 2918 Builder.setFastMathFlags(FCmp->getFastMathFlags()); 2919 Value *NewCond = Builder.CreateFCmp(InvPred, Cmp0, Cmp1, 2920 FCmp->getName() + ".inv"); 2921 Value *NewSel = Builder.CreateSelect(NewCond, FalseVal, TrueVal); 2922 return replaceInstUsesWith(SI, NewSel); 2923 } 2924 2925 // NOTE: if we wanted to, this is where to detect MIN/MAX 2926 } 2927 } 2928 2929 // Canonicalize select with fcmp to fabs(). -0.0 makes this tricky. We need 2930 // fast-math-flags (nsz) or fsub with +0.0 (not fneg) for this to work. 2931 // (X <= +/-0.0) ? (0.0 - X) : X --> fabs(X) 2932 Instruction *FSub; 2933 if (match(CondVal, m_FCmp(Pred, m_Specific(FalseVal), m_AnyZeroFP())) && 2934 match(TrueVal, m_FSub(m_PosZeroFP(), m_Specific(FalseVal))) && 2935 match(TrueVal, m_Instruction(FSub)) && 2936 (Pred == FCmpInst::FCMP_OLE || Pred == FCmpInst::FCMP_ULE)) { 2937 Value *Fabs = Builder.CreateUnaryIntrinsic(Intrinsic::fabs, FalseVal, &SI); 2938 return replaceInstUsesWith(SI, Fabs); 2939 } 2940 // (X > +/-0.0) ? X : (0.0 - X) --> fabs(X) 2941 if (match(CondVal, m_FCmp(Pred, m_Specific(TrueVal), m_AnyZeroFP())) && 2942 match(FalseVal, m_FSub(m_PosZeroFP(), m_Specific(TrueVal))) && 2943 match(FalseVal, m_Instruction(FSub)) && 2944 (Pred == FCmpInst::FCMP_OGT || Pred == FCmpInst::FCMP_UGT)) { 2945 Value *Fabs = Builder.CreateUnaryIntrinsic(Intrinsic::fabs, TrueVal, &SI); 2946 return replaceInstUsesWith(SI, Fabs); 2947 } 2948 // With nnan and nsz: 2949 // (X < +/-0.0) ? -X : X --> fabs(X) 2950 // (X <= +/-0.0) ? -X : X --> fabs(X) 2951 Instruction *FNeg; 2952 if (match(CondVal, m_FCmp(Pred, m_Specific(FalseVal), m_AnyZeroFP())) && 2953 match(TrueVal, m_FNeg(m_Specific(FalseVal))) && 2954 match(TrueVal, m_Instruction(FNeg)) && SI.hasNoSignedZeros() && 2955 (Pred == FCmpInst::FCMP_OLT || Pred == FCmpInst::FCMP_OLE || 2956 Pred == FCmpInst::FCMP_ULT || Pred == FCmpInst::FCMP_ULE)) { 2957 Value *Fabs = Builder.CreateUnaryIntrinsic(Intrinsic::fabs, FalseVal, &SI); 2958 return replaceInstUsesWith(SI, Fabs); 2959 } 2960 // With nnan and nsz: 2961 // (X > +/-0.0) ? X : -X --> fabs(X) 2962 // (X >= +/-0.0) ? X : -X --> fabs(X) 2963 if (match(CondVal, m_FCmp(Pred, m_Specific(TrueVal), m_AnyZeroFP())) && 2964 match(FalseVal, m_FNeg(m_Specific(TrueVal))) && 2965 match(FalseVal, m_Instruction(FNeg)) && SI.hasNoSignedZeros() && 2966 (Pred == FCmpInst::FCMP_OGT || Pred == FCmpInst::FCMP_OGE || 2967 Pred == FCmpInst::FCMP_UGT || Pred == FCmpInst::FCMP_UGE)) { 2968 Value *Fabs = Builder.CreateUnaryIntrinsic(Intrinsic::fabs, TrueVal, &SI); 2969 return replaceInstUsesWith(SI, Fabs); 2970 } 2971 2972 // See if we are selecting two values based on a comparison of the two values. 2973 if (ICmpInst *ICI = dyn_cast<ICmpInst>(CondVal)) 2974 if (Instruction *Result = foldSelectInstWithICmp(SI, ICI)) 2975 return Result; 2976 2977 if (Instruction *Add = foldAddSubSelect(SI, Builder)) 2978 return Add; 2979 if (Instruction *Add = foldOverflowingAddSubSelect(SI, Builder)) 2980 return Add; 2981 if (Instruction *Or = foldSetClearBits(SI, Builder)) 2982 return Or; 2983 if (Instruction *Mul = foldSelectZeroOrMul(SI, *this)) 2984 return Mul; 2985 2986 // Turn (select C, (op X, Y), (op X, Z)) -> (op X, (select C, Y, Z)) 2987 auto *TI = dyn_cast<Instruction>(TrueVal); 2988 auto *FI = dyn_cast<Instruction>(FalseVal); 2989 if (TI && FI && TI->getOpcode() == FI->getOpcode()) 2990 if (Instruction *IV = foldSelectOpOp(SI, TI, FI)) 2991 return IV; 2992 2993 if (Instruction *I = foldSelectExtConst(SI)) 2994 return I; 2995 2996 // Fold (select C, (gep Ptr, Idx), Ptr) -> (gep Ptr, (select C, Idx, 0)) 2997 // Fold (select C, Ptr, (gep Ptr, Idx)) -> (gep Ptr, (select C, 0, Idx)) 2998 auto SelectGepWithBase = [&](GetElementPtrInst *Gep, Value *Base, 2999 bool Swap) -> GetElementPtrInst * { 3000 Value *Ptr = Gep->getPointerOperand(); 3001 if (Gep->getNumOperands() != 2 || Gep->getPointerOperand() != Base || 3002 !Gep->hasOneUse()) 3003 return nullptr; 3004 Value *Idx = Gep->getOperand(1); 3005 if (isa<VectorType>(CondVal->getType()) && !isa<VectorType>(Idx->getType())) 3006 return nullptr; 3007 Type *ElementType = Gep->getResultElementType(); 3008 Value *NewT = Idx; 3009 Value *NewF = Constant::getNullValue(Idx->getType()); 3010 if (Swap) 3011 std::swap(NewT, NewF); 3012 Value *NewSI = 3013 Builder.CreateSelect(CondVal, NewT, NewF, SI.getName() + ".idx", &SI); 3014 return GetElementPtrInst::Create(ElementType, Ptr, {NewSI}); 3015 }; 3016 if (auto *TrueGep = dyn_cast<GetElementPtrInst>(TrueVal)) 3017 if (auto *NewGep = SelectGepWithBase(TrueGep, FalseVal, false)) 3018 return NewGep; 3019 if (auto *FalseGep = dyn_cast<GetElementPtrInst>(FalseVal)) 3020 if (auto *NewGep = SelectGepWithBase(FalseGep, TrueVal, true)) 3021 return NewGep; 3022 3023 // See if we can fold the select into one of our operands. 3024 if (SelType->isIntOrIntVectorTy() || SelType->isFPOrFPVectorTy()) { 3025 if (Instruction *FoldI = foldSelectIntoOp(SI, TrueVal, FalseVal)) 3026 return FoldI; 3027 3028 Value *LHS, *RHS; 3029 Instruction::CastOps CastOp; 3030 SelectPatternResult SPR = matchSelectPattern(&SI, LHS, RHS, &CastOp); 3031 auto SPF = SPR.Flavor; 3032 if (SPF) { 3033 Value *LHS2, *RHS2; 3034 if (SelectPatternFlavor SPF2 = matchSelectPattern(LHS, LHS2, RHS2).Flavor) 3035 if (Instruction *R = foldSPFofSPF(cast<Instruction>(LHS), SPF2, LHS2, 3036 RHS2, SI, SPF, RHS)) 3037 return R; 3038 if (SelectPatternFlavor SPF2 = matchSelectPattern(RHS, LHS2, RHS2).Flavor) 3039 if (Instruction *R = foldSPFofSPF(cast<Instruction>(RHS), SPF2, LHS2, 3040 RHS2, SI, SPF, LHS)) 3041 return R; 3042 // TODO. 3043 // ABS(-X) -> ABS(X) 3044 } 3045 3046 if (SelectPatternResult::isMinOrMax(SPF)) { 3047 // Canonicalize so that 3048 // - type casts are outside select patterns. 3049 // - float clamp is transformed to min/max pattern 3050 3051 bool IsCastNeeded = LHS->getType() != SelType; 3052 Value *CmpLHS = cast<CmpInst>(CondVal)->getOperand(0); 3053 Value *CmpRHS = cast<CmpInst>(CondVal)->getOperand(1); 3054 if (IsCastNeeded || 3055 (LHS->getType()->isFPOrFPVectorTy() && 3056 ((CmpLHS != LHS && CmpLHS != RHS) || 3057 (CmpRHS != LHS && CmpRHS != RHS)))) { 3058 CmpInst::Predicate MinMaxPred = getMinMaxPred(SPF, SPR.Ordered); 3059 3060 Value *Cmp; 3061 if (CmpInst::isIntPredicate(MinMaxPred)) { 3062 Cmp = Builder.CreateICmp(MinMaxPred, LHS, RHS); 3063 } else { 3064 IRBuilder<>::FastMathFlagGuard FMFG(Builder); 3065 auto FMF = 3066 cast<FPMathOperator>(SI.getCondition())->getFastMathFlags(); 3067 Builder.setFastMathFlags(FMF); 3068 Cmp = Builder.CreateFCmp(MinMaxPred, LHS, RHS); 3069 } 3070 3071 Value *NewSI = Builder.CreateSelect(Cmp, LHS, RHS, SI.getName(), &SI); 3072 if (!IsCastNeeded) 3073 return replaceInstUsesWith(SI, NewSI); 3074 3075 Value *NewCast = Builder.CreateCast(CastOp, NewSI, SelType); 3076 return replaceInstUsesWith(SI, NewCast); 3077 } 3078 3079 // MAX(~a, ~b) -> ~MIN(a, b) 3080 // MAX(~a, C) -> ~MIN(a, ~C) 3081 // MIN(~a, ~b) -> ~MAX(a, b) 3082 // MIN(~a, C) -> ~MAX(a, ~C) 3083 auto moveNotAfterMinMax = [&](Value *X, Value *Y) -> Instruction * { 3084 Value *A; 3085 if (match(X, m_Not(m_Value(A))) && !X->hasNUsesOrMore(3) && 3086 !isFreeToInvert(A, A->hasOneUse()) && 3087 // Passing false to only consider m_Not and constants. 3088 isFreeToInvert(Y, false)) { 3089 Value *B = Builder.CreateNot(Y); 3090 Value *NewMinMax = createMinMax(Builder, getInverseMinMaxFlavor(SPF), 3091 A, B); 3092 // Copy the profile metadata. 3093 if (MDNode *MD = SI.getMetadata(LLVMContext::MD_prof)) { 3094 cast<SelectInst>(NewMinMax)->setMetadata(LLVMContext::MD_prof, MD); 3095 // Swap the metadata if the operands are swapped. 3096 if (X == SI.getFalseValue() && Y == SI.getTrueValue()) 3097 cast<SelectInst>(NewMinMax)->swapProfMetadata(); 3098 } 3099 3100 return BinaryOperator::CreateNot(NewMinMax); 3101 } 3102 3103 return nullptr; 3104 }; 3105 3106 if (Instruction *I = moveNotAfterMinMax(LHS, RHS)) 3107 return I; 3108 if (Instruction *I = moveNotAfterMinMax(RHS, LHS)) 3109 return I; 3110 3111 if (Instruction *I = moveAddAfterMinMax(SPF, LHS, RHS, Builder)) 3112 return I; 3113 3114 if (Instruction *I = factorizeMinMaxTree(SPF, LHS, RHS, Builder)) 3115 return I; 3116 if (Instruction *I = matchSAddSubSat(SI)) 3117 return I; 3118 } 3119 } 3120 3121 // Canonicalize select of FP values where NaN and -0.0 are not valid as 3122 // minnum/maxnum intrinsics. 3123 if (isa<FPMathOperator>(SI) && SI.hasNoNaNs() && SI.hasNoSignedZeros()) { 3124 Value *X, *Y; 3125 if (match(&SI, m_OrdFMax(m_Value(X), m_Value(Y)))) 3126 return replaceInstUsesWith( 3127 SI, Builder.CreateBinaryIntrinsic(Intrinsic::maxnum, X, Y, &SI)); 3128 3129 if (match(&SI, m_OrdFMin(m_Value(X), m_Value(Y)))) 3130 return replaceInstUsesWith( 3131 SI, Builder.CreateBinaryIntrinsic(Intrinsic::minnum, X, Y, &SI)); 3132 } 3133 3134 // See if we can fold the select into a phi node if the condition is a select. 3135 if (auto *PN = dyn_cast<PHINode>(SI.getCondition())) 3136 // The true/false values have to be live in the PHI predecessor's blocks. 3137 if (canSelectOperandBeMappingIntoPredBlock(TrueVal, SI) && 3138 canSelectOperandBeMappingIntoPredBlock(FalseVal, SI)) 3139 if (Instruction *NV = foldOpIntoPhi(SI, PN)) 3140 return NV; 3141 3142 if (SelectInst *TrueSI = dyn_cast<SelectInst>(TrueVal)) { 3143 if (TrueSI->getCondition()->getType() == CondVal->getType()) { 3144 // select(C, select(C, a, b), c) -> select(C, a, c) 3145 if (TrueSI->getCondition() == CondVal) { 3146 if (SI.getTrueValue() == TrueSI->getTrueValue()) 3147 return nullptr; 3148 return replaceOperand(SI, 1, TrueSI->getTrueValue()); 3149 } 3150 // select(C0, select(C1, a, b), b) -> select(C0&C1, a, b) 3151 // We choose this as normal form to enable folding on the And and 3152 // shortening paths for the values (this helps getUnderlyingObjects() for 3153 // example). 3154 if (TrueSI->getFalseValue() == FalseVal && TrueSI->hasOneUse()) { 3155 Value *And = Builder.CreateLogicalAnd(CondVal, TrueSI->getCondition()); 3156 replaceOperand(SI, 0, And); 3157 replaceOperand(SI, 1, TrueSI->getTrueValue()); 3158 return &SI; 3159 } 3160 } 3161 } 3162 if (SelectInst *FalseSI = dyn_cast<SelectInst>(FalseVal)) { 3163 if (FalseSI->getCondition()->getType() == CondVal->getType()) { 3164 // select(C, a, select(C, b, c)) -> select(C, a, c) 3165 if (FalseSI->getCondition() == CondVal) { 3166 if (SI.getFalseValue() == FalseSI->getFalseValue()) 3167 return nullptr; 3168 return replaceOperand(SI, 2, FalseSI->getFalseValue()); 3169 } 3170 // select(C0, a, select(C1, a, b)) -> select(C0|C1, a, b) 3171 if (FalseSI->getTrueValue() == TrueVal && FalseSI->hasOneUse()) { 3172 Value *Or = Builder.CreateLogicalOr(CondVal, FalseSI->getCondition()); 3173 replaceOperand(SI, 0, Or); 3174 replaceOperand(SI, 2, FalseSI->getFalseValue()); 3175 return &SI; 3176 } 3177 } 3178 } 3179 3180 auto canMergeSelectThroughBinop = [](BinaryOperator *BO) { 3181 // The select might be preventing a division by 0. 3182 switch (BO->getOpcode()) { 3183 default: 3184 return true; 3185 case Instruction::SRem: 3186 case Instruction::URem: 3187 case Instruction::SDiv: 3188 case Instruction::UDiv: 3189 return false; 3190 } 3191 }; 3192 3193 // Try to simplify a binop sandwiched between 2 selects with the same 3194 // condition. 3195 // select(C, binop(select(C, X, Y), W), Z) -> select(C, binop(X, W), Z) 3196 BinaryOperator *TrueBO; 3197 if (match(TrueVal, m_OneUse(m_BinOp(TrueBO))) && 3198 canMergeSelectThroughBinop(TrueBO)) { 3199 if (auto *TrueBOSI = dyn_cast<SelectInst>(TrueBO->getOperand(0))) { 3200 if (TrueBOSI->getCondition() == CondVal) { 3201 replaceOperand(*TrueBO, 0, TrueBOSI->getTrueValue()); 3202 Worklist.push(TrueBO); 3203 return &SI; 3204 } 3205 } 3206 if (auto *TrueBOSI = dyn_cast<SelectInst>(TrueBO->getOperand(1))) { 3207 if (TrueBOSI->getCondition() == CondVal) { 3208 replaceOperand(*TrueBO, 1, TrueBOSI->getTrueValue()); 3209 Worklist.push(TrueBO); 3210 return &SI; 3211 } 3212 } 3213 } 3214 3215 // select(C, Z, binop(select(C, X, Y), W)) -> select(C, Z, binop(Y, W)) 3216 BinaryOperator *FalseBO; 3217 if (match(FalseVal, m_OneUse(m_BinOp(FalseBO))) && 3218 canMergeSelectThroughBinop(FalseBO)) { 3219 if (auto *FalseBOSI = dyn_cast<SelectInst>(FalseBO->getOperand(0))) { 3220 if (FalseBOSI->getCondition() == CondVal) { 3221 replaceOperand(*FalseBO, 0, FalseBOSI->getFalseValue()); 3222 Worklist.push(FalseBO); 3223 return &SI; 3224 } 3225 } 3226 if (auto *FalseBOSI = dyn_cast<SelectInst>(FalseBO->getOperand(1))) { 3227 if (FalseBOSI->getCondition() == CondVal) { 3228 replaceOperand(*FalseBO, 1, FalseBOSI->getFalseValue()); 3229 Worklist.push(FalseBO); 3230 return &SI; 3231 } 3232 } 3233 } 3234 3235 Value *NotCond; 3236 if (match(CondVal, m_Not(m_Value(NotCond))) && 3237 !InstCombiner::shouldAvoidAbsorbingNotIntoSelect(SI)) { 3238 replaceOperand(SI, 0, NotCond); 3239 SI.swapValues(); 3240 SI.swapProfMetadata(); 3241 return &SI; 3242 } 3243 3244 if (Instruction *I = foldVectorSelect(SI)) 3245 return I; 3246 3247 // If we can compute the condition, there's no need for a select. 3248 // Like the above fold, we are attempting to reduce compile-time cost by 3249 // putting this fold here with limitations rather than in InstSimplify. 3250 // The motivation for this call into value tracking is to take advantage of 3251 // the assumption cache, so make sure that is populated. 3252 if (!CondVal->getType()->isVectorTy() && !AC.assumptions().empty()) { 3253 KnownBits Known(1); 3254 computeKnownBits(CondVal, Known, 0, &SI); 3255 if (Known.One.isOne()) 3256 return replaceInstUsesWith(SI, TrueVal); 3257 if (Known.Zero.isOne()) 3258 return replaceInstUsesWith(SI, FalseVal); 3259 } 3260 3261 if (Instruction *BitCastSel = foldSelectCmpBitcasts(SI, Builder)) 3262 return BitCastSel; 3263 3264 // Simplify selects that test the returned flag of cmpxchg instructions. 3265 if (Value *V = foldSelectCmpXchg(SI)) 3266 return replaceInstUsesWith(SI, V); 3267 3268 if (Instruction *Select = foldSelectBinOpIdentity(SI, TLI, *this)) 3269 return Select; 3270 3271 if (Instruction *Funnel = foldSelectFunnelShift(SI, Builder)) 3272 return Funnel; 3273 3274 if (Instruction *Copysign = foldSelectToCopysign(SI, Builder)) 3275 return Copysign; 3276 3277 if (Instruction *PN = foldSelectToPhi(SI, DT, Builder)) 3278 return replaceInstUsesWith(SI, PN); 3279 3280 if (Value *Fr = foldSelectWithFrozenICmp(SI, Builder)) 3281 return replaceInstUsesWith(SI, Fr); 3282 3283 // select(mask, mload(,,mask,0), 0) -> mload(,,mask,0) 3284 // Load inst is intentionally not checked for hasOneUse() 3285 if (match(FalseVal, m_Zero()) && 3286 match(TrueVal, m_MaskedLoad(m_Value(), m_Value(), m_Specific(CondVal), 3287 m_CombineOr(m_Undef(), m_Zero())))) { 3288 auto *MaskedLoad = cast<IntrinsicInst>(TrueVal); 3289 if (isa<UndefValue>(MaskedLoad->getArgOperand(3))) 3290 MaskedLoad->setArgOperand(3, FalseVal /* Zero */); 3291 return replaceInstUsesWith(SI, MaskedLoad); 3292 } 3293 3294 Value *Mask; 3295 if (match(TrueVal, m_Zero()) && 3296 match(FalseVal, m_MaskedLoad(m_Value(), m_Value(), m_Value(Mask), 3297 m_CombineOr(m_Undef(), m_Zero()))) && 3298 (CondVal->getType() == Mask->getType())) { 3299 // We can remove the select by ensuring the load zeros all lanes the 3300 // select would have. We determine this by proving there is no overlap 3301 // between the load and select masks. 3302 // (i.e (load_mask & select_mask) == 0 == no overlap) 3303 bool CanMergeSelectIntoLoad = false; 3304 if (Value *V = SimplifyAndInst(CondVal, Mask, SQ.getWithInstruction(&SI))) 3305 CanMergeSelectIntoLoad = match(V, m_Zero()); 3306 3307 if (CanMergeSelectIntoLoad) { 3308 auto *MaskedLoad = cast<IntrinsicInst>(FalseVal); 3309 if (isa<UndefValue>(MaskedLoad->getArgOperand(3))) 3310 MaskedLoad->setArgOperand(3, TrueVal /* Zero */); 3311 return replaceInstUsesWith(SI, MaskedLoad); 3312 } 3313 } 3314 3315 return nullptr; 3316 } 3317