1 //===- InstCombineSelect.cpp ----------------------------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements the visitSelect function. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "InstCombineInternal.h" 15 #include "llvm/Analysis/ConstantFolding.h" 16 #include "llvm/Analysis/InstructionSimplify.h" 17 #include "llvm/Analysis/ValueTracking.h" 18 #include "llvm/IR/MDBuilder.h" 19 #include "llvm/IR/PatternMatch.h" 20 using namespace llvm; 21 using namespace PatternMatch; 22 23 #define DEBUG_TYPE "instcombine" 24 25 static SelectPatternFlavor 26 getInverseMinMaxSelectPattern(SelectPatternFlavor SPF) { 27 switch (SPF) { 28 default: 29 llvm_unreachable("unhandled!"); 30 31 case SPF_SMIN: 32 return SPF_SMAX; 33 case SPF_UMIN: 34 return SPF_UMAX; 35 case SPF_SMAX: 36 return SPF_SMIN; 37 case SPF_UMAX: 38 return SPF_UMIN; 39 } 40 } 41 42 static CmpInst::Predicate getCmpPredicateForMinMax(SelectPatternFlavor SPF, 43 bool Ordered=false) { 44 switch (SPF) { 45 default: 46 llvm_unreachable("unhandled!"); 47 48 case SPF_SMIN: 49 return ICmpInst::ICMP_SLT; 50 case SPF_UMIN: 51 return ICmpInst::ICMP_ULT; 52 case SPF_SMAX: 53 return ICmpInst::ICMP_SGT; 54 case SPF_UMAX: 55 return ICmpInst::ICMP_UGT; 56 case SPF_FMINNUM: 57 return Ordered ? FCmpInst::FCMP_OLT : FCmpInst::FCMP_ULT; 58 case SPF_FMAXNUM: 59 return Ordered ? FCmpInst::FCMP_OGT : FCmpInst::FCMP_UGT; 60 } 61 } 62 63 static Value *generateMinMaxSelectPattern(InstCombiner::BuilderTy *Builder, 64 SelectPatternFlavor SPF, Value *A, 65 Value *B) { 66 CmpInst::Predicate Pred = getCmpPredicateForMinMax(SPF); 67 assert(CmpInst::isIntPredicate(Pred)); 68 return Builder->CreateSelect(Builder->CreateICmp(Pred, A, B), A, B); 69 } 70 71 /// We want to turn code that looks like this: 72 /// %C = or %A, %B 73 /// %D = select %cond, %C, %A 74 /// into: 75 /// %C = select %cond, %B, 0 76 /// %D = or %A, %C 77 /// 78 /// Assuming that the specified instruction is an operand to the select, return 79 /// a bitmask indicating which operands of this instruction are foldable if they 80 /// equal the other incoming value of the select. 81 /// 82 static unsigned getSelectFoldableOperands(Instruction *I) { 83 switch (I->getOpcode()) { 84 case Instruction::Add: 85 case Instruction::Mul: 86 case Instruction::And: 87 case Instruction::Or: 88 case Instruction::Xor: 89 return 3; // Can fold through either operand. 90 case Instruction::Sub: // Can only fold on the amount subtracted. 91 case Instruction::Shl: // Can only fold on the shift amount. 92 case Instruction::LShr: 93 case Instruction::AShr: 94 return 1; 95 default: 96 return 0; // Cannot fold 97 } 98 } 99 100 /// For the same transformation as the previous function, return the identity 101 /// constant that goes into the select. 102 static Constant *getSelectFoldableConstant(Instruction *I) { 103 switch (I->getOpcode()) { 104 default: llvm_unreachable("This cannot happen!"); 105 case Instruction::Add: 106 case Instruction::Sub: 107 case Instruction::Or: 108 case Instruction::Xor: 109 case Instruction::Shl: 110 case Instruction::LShr: 111 case Instruction::AShr: 112 return Constant::getNullValue(I->getType()); 113 case Instruction::And: 114 return Constant::getAllOnesValue(I->getType()); 115 case Instruction::Mul: 116 return ConstantInt::get(I->getType(), 1); 117 } 118 } 119 120 /// We have (select c, TI, FI), and we know that TI and FI have the same opcode. 121 Instruction *InstCombiner::foldSelectOpOp(SelectInst &SI, Instruction *TI, 122 Instruction *FI) { 123 // If this is a cast from the same type, merge. 124 if (TI->getNumOperands() == 1 && TI->isCast()) { 125 Type *FIOpndTy = FI->getOperand(0)->getType(); 126 if (TI->getOperand(0)->getType() != FIOpndTy) 127 return nullptr; 128 129 // The select condition may be a vector. We may only change the operand 130 // type if the vector width remains the same (and matches the condition). 131 Type *CondTy = SI.getCondition()->getType(); 132 if (CondTy->isVectorTy()) { 133 if (!FIOpndTy->isVectorTy()) 134 return nullptr; 135 if (CondTy->getVectorNumElements() != FIOpndTy->getVectorNumElements()) 136 return nullptr; 137 138 // TODO: If the backend knew how to deal with casts better, we could 139 // remove this limitation. For now, there's too much potential to create 140 // worse codegen by promoting the select ahead of size-altering casts 141 // (PR28160). 142 // 143 // Note that ValueTracking's matchSelectPattern() looks through casts 144 // without checking 'hasOneUse' when it matches min/max patterns, so this 145 // transform may end up happening anyway. 146 if (TI->getOpcode() != Instruction::BitCast && 147 (!TI->hasOneUse() || !FI->hasOneUse())) 148 return nullptr; 149 150 } else if (!TI->hasOneUse() || !FI->hasOneUse()) { 151 // TODO: The one-use restrictions for a scalar select could be eased if 152 // the fold of a select in visitLoadInst() was enhanced to match a pattern 153 // that includes a cast. 154 return nullptr; 155 } 156 157 // Fold this by inserting a select from the input values. 158 Value *NewSI = 159 Builder->CreateSelect(SI.getCondition(), TI->getOperand(0), 160 FI->getOperand(0), SI.getName() + ".v", &SI); 161 return CastInst::Create(Instruction::CastOps(TI->getOpcode()), NewSI, 162 TI->getType()); 163 } 164 165 // Only handle binary operators with one-use here. As with the cast case 166 // above, it may be possible to relax the one-use constraint, but that needs 167 // be examined carefully since it may not reduce the total number of 168 // instructions. 169 BinaryOperator *BO = dyn_cast<BinaryOperator>(TI); 170 if (!BO || !TI->hasOneUse() || !FI->hasOneUse()) 171 return nullptr; 172 173 // Figure out if the operations have any operands in common. 174 Value *MatchOp, *OtherOpT, *OtherOpF; 175 bool MatchIsOpZero; 176 if (TI->getOperand(0) == FI->getOperand(0)) { 177 MatchOp = TI->getOperand(0); 178 OtherOpT = TI->getOperand(1); 179 OtherOpF = FI->getOperand(1); 180 MatchIsOpZero = true; 181 } else if (TI->getOperand(1) == FI->getOperand(1)) { 182 MatchOp = TI->getOperand(1); 183 OtherOpT = TI->getOperand(0); 184 OtherOpF = FI->getOperand(0); 185 MatchIsOpZero = false; 186 } else if (!TI->isCommutative()) { 187 return nullptr; 188 } else if (TI->getOperand(0) == FI->getOperand(1)) { 189 MatchOp = TI->getOperand(0); 190 OtherOpT = TI->getOperand(1); 191 OtherOpF = FI->getOperand(0); 192 MatchIsOpZero = true; 193 } else if (TI->getOperand(1) == FI->getOperand(0)) { 194 MatchOp = TI->getOperand(1); 195 OtherOpT = TI->getOperand(0); 196 OtherOpF = FI->getOperand(1); 197 MatchIsOpZero = true; 198 } else { 199 return nullptr; 200 } 201 202 // If we reach here, they do have operations in common. 203 Value *NewSI = Builder->CreateSelect(SI.getCondition(), OtherOpT, OtherOpF, 204 SI.getName() + ".v", &SI); 205 Value *Op0 = MatchIsOpZero ? MatchOp : NewSI; 206 Value *Op1 = MatchIsOpZero ? NewSI : MatchOp; 207 return BinaryOperator::Create(BO->getOpcode(), Op0, Op1); 208 } 209 210 static bool isSelect01(Constant *C1, Constant *C2) { 211 ConstantInt *C1I = dyn_cast<ConstantInt>(C1); 212 if (!C1I) 213 return false; 214 ConstantInt *C2I = dyn_cast<ConstantInt>(C2); 215 if (!C2I) 216 return false; 217 if (!C1I->isZero() && !C2I->isZero()) // One side must be zero. 218 return false; 219 return C1I->isOne() || C1I->isAllOnesValue() || 220 C2I->isOne() || C2I->isAllOnesValue(); 221 } 222 223 /// Try to fold the select into one of the operands to allow further 224 /// optimization. 225 Instruction *InstCombiner::foldSelectIntoOp(SelectInst &SI, Value *TrueVal, 226 Value *FalseVal) { 227 // See the comment above GetSelectFoldableOperands for a description of the 228 // transformation we are doing here. 229 if (Instruction *TVI = dyn_cast<Instruction>(TrueVal)) { 230 if (TVI->hasOneUse() && TVI->getNumOperands() == 2 && 231 !isa<Constant>(FalseVal)) { 232 if (unsigned SFO = getSelectFoldableOperands(TVI)) { 233 unsigned OpToFold = 0; 234 if ((SFO & 1) && FalseVal == TVI->getOperand(0)) { 235 OpToFold = 1; 236 } else if ((SFO & 2) && FalseVal == TVI->getOperand(1)) { 237 OpToFold = 2; 238 } 239 240 if (OpToFold) { 241 Constant *C = getSelectFoldableConstant(TVI); 242 Value *OOp = TVI->getOperand(2-OpToFold); 243 // Avoid creating select between 2 constants unless it's selecting 244 // between 0, 1 and -1. 245 if (!isa<Constant>(OOp) || isSelect01(C, cast<Constant>(OOp))) { 246 Value *NewSel = Builder->CreateSelect(SI.getCondition(), OOp, C); 247 NewSel->takeName(TVI); 248 BinaryOperator *TVI_BO = cast<BinaryOperator>(TVI); 249 BinaryOperator *BO = BinaryOperator::Create(TVI_BO->getOpcode(), 250 FalseVal, NewSel); 251 BO->copyIRFlags(TVI_BO); 252 return BO; 253 } 254 } 255 } 256 } 257 } 258 259 if (Instruction *FVI = dyn_cast<Instruction>(FalseVal)) { 260 if (FVI->hasOneUse() && FVI->getNumOperands() == 2 && 261 !isa<Constant>(TrueVal)) { 262 if (unsigned SFO = getSelectFoldableOperands(FVI)) { 263 unsigned OpToFold = 0; 264 if ((SFO & 1) && TrueVal == FVI->getOperand(0)) { 265 OpToFold = 1; 266 } else if ((SFO & 2) && TrueVal == FVI->getOperand(1)) { 267 OpToFold = 2; 268 } 269 270 if (OpToFold) { 271 Constant *C = getSelectFoldableConstant(FVI); 272 Value *OOp = FVI->getOperand(2-OpToFold); 273 // Avoid creating select between 2 constants unless it's selecting 274 // between 0, 1 and -1. 275 if (!isa<Constant>(OOp) || isSelect01(C, cast<Constant>(OOp))) { 276 Value *NewSel = Builder->CreateSelect(SI.getCondition(), C, OOp); 277 NewSel->takeName(FVI); 278 BinaryOperator *FVI_BO = cast<BinaryOperator>(FVI); 279 BinaryOperator *BO = BinaryOperator::Create(FVI_BO->getOpcode(), 280 TrueVal, NewSel); 281 BO->copyIRFlags(FVI_BO); 282 return BO; 283 } 284 } 285 } 286 } 287 } 288 289 return nullptr; 290 } 291 292 /// We want to turn: 293 /// (select (icmp eq (and X, C1), 0), Y, (or Y, C2)) 294 /// into: 295 /// (or (shl (and X, C1), C3), y) 296 /// iff: 297 /// C1 and C2 are both powers of 2 298 /// where: 299 /// C3 = Log(C2) - Log(C1) 300 /// 301 /// This transform handles cases where: 302 /// 1. The icmp predicate is inverted 303 /// 2. The select operands are reversed 304 /// 3. The magnitude of C2 and C1 are flipped 305 static Value *foldSelectICmpAndOr(const SelectInst &SI, Value *TrueVal, 306 Value *FalseVal, 307 InstCombiner::BuilderTy *Builder) { 308 const ICmpInst *IC = dyn_cast<ICmpInst>(SI.getCondition()); 309 if (!IC || !IC->isEquality() || !SI.getType()->isIntegerTy()) 310 return nullptr; 311 312 Value *CmpLHS = IC->getOperand(0); 313 Value *CmpRHS = IC->getOperand(1); 314 315 if (!match(CmpRHS, m_Zero())) 316 return nullptr; 317 318 Value *X; 319 const APInt *C1; 320 if (!match(CmpLHS, m_And(m_Value(X), m_Power2(C1)))) 321 return nullptr; 322 323 const APInt *C2; 324 bool OrOnTrueVal = false; 325 bool OrOnFalseVal = match(FalseVal, m_Or(m_Specific(TrueVal), m_Power2(C2))); 326 if (!OrOnFalseVal) 327 OrOnTrueVal = match(TrueVal, m_Or(m_Specific(FalseVal), m_Power2(C2))); 328 329 if (!OrOnFalseVal && !OrOnTrueVal) 330 return nullptr; 331 332 Value *V = CmpLHS; 333 Value *Y = OrOnFalseVal ? TrueVal : FalseVal; 334 335 unsigned C1Log = C1->logBase2(); 336 unsigned C2Log = C2->logBase2(); 337 if (C2Log > C1Log) { 338 V = Builder->CreateZExtOrTrunc(V, Y->getType()); 339 V = Builder->CreateShl(V, C2Log - C1Log); 340 } else if (C1Log > C2Log) { 341 V = Builder->CreateLShr(V, C1Log - C2Log); 342 V = Builder->CreateZExtOrTrunc(V, Y->getType()); 343 } else 344 V = Builder->CreateZExtOrTrunc(V, Y->getType()); 345 346 ICmpInst::Predicate Pred = IC->getPredicate(); 347 if ((Pred == ICmpInst::ICMP_NE && OrOnFalseVal) || 348 (Pred == ICmpInst::ICMP_EQ && OrOnTrueVal)) 349 V = Builder->CreateXor(V, *C2); 350 351 return Builder->CreateOr(V, Y); 352 } 353 354 /// Attempt to fold a cttz/ctlz followed by a icmp plus select into a single 355 /// call to cttz/ctlz with flag 'is_zero_undef' cleared. 356 /// 357 /// For example, we can fold the following code sequence: 358 /// \code 359 /// %0 = tail call i32 @llvm.cttz.i32(i32 %x, i1 true) 360 /// %1 = icmp ne i32 %x, 0 361 /// %2 = select i1 %1, i32 %0, i32 32 362 /// \code 363 /// 364 /// into: 365 /// %0 = tail call i32 @llvm.cttz.i32(i32 %x, i1 false) 366 static Value *foldSelectCttzCtlz(ICmpInst *ICI, Value *TrueVal, Value *FalseVal, 367 InstCombiner::BuilderTy *Builder) { 368 ICmpInst::Predicate Pred = ICI->getPredicate(); 369 Value *CmpLHS = ICI->getOperand(0); 370 Value *CmpRHS = ICI->getOperand(1); 371 372 // Check if the condition value compares a value for equality against zero. 373 if (!ICI->isEquality() || !match(CmpRHS, m_Zero())) 374 return nullptr; 375 376 Value *Count = FalseVal; 377 Value *ValueOnZero = TrueVal; 378 if (Pred == ICmpInst::ICMP_NE) 379 std::swap(Count, ValueOnZero); 380 381 // Skip zero extend/truncate. 382 Value *V = nullptr; 383 if (match(Count, m_ZExt(m_Value(V))) || 384 match(Count, m_Trunc(m_Value(V)))) 385 Count = V; 386 387 // Check if the value propagated on zero is a constant number equal to the 388 // sizeof in bits of 'Count'. 389 unsigned SizeOfInBits = Count->getType()->getScalarSizeInBits(); 390 if (!match(ValueOnZero, m_SpecificInt(SizeOfInBits))) 391 return nullptr; 392 393 // Check that 'Count' is a call to intrinsic cttz/ctlz. Also check that the 394 // input to the cttz/ctlz is used as LHS for the compare instruction. 395 if (match(Count, m_Intrinsic<Intrinsic::cttz>(m_Specific(CmpLHS))) || 396 match(Count, m_Intrinsic<Intrinsic::ctlz>(m_Specific(CmpLHS)))) { 397 IntrinsicInst *II = cast<IntrinsicInst>(Count); 398 IRBuilder<> Builder(II); 399 // Explicitly clear the 'undef_on_zero' flag. 400 IntrinsicInst *NewI = cast<IntrinsicInst>(II->clone()); 401 Type *Ty = NewI->getArgOperand(1)->getType(); 402 NewI->setArgOperand(1, Constant::getNullValue(Ty)); 403 Builder.Insert(NewI); 404 return Builder.CreateZExtOrTrunc(NewI, ValueOnZero->getType()); 405 } 406 407 return nullptr; 408 } 409 410 /// Return true if we find and adjust an icmp+select pattern where the compare 411 /// is with a constant that can be incremented or decremented to match the 412 /// minimum or maximum idiom. 413 static bool adjustMinMax(SelectInst &Sel, ICmpInst &Cmp) { 414 ICmpInst::Predicate Pred = Cmp.getPredicate(); 415 Value *CmpLHS = Cmp.getOperand(0); 416 Value *CmpRHS = Cmp.getOperand(1); 417 Value *TrueVal = Sel.getTrueValue(); 418 Value *FalseVal = Sel.getFalseValue(); 419 420 // We may move or edit the compare, so make sure the select is the only user. 421 const APInt *CmpC; 422 if (!Cmp.hasOneUse() || !match(CmpRHS, m_APInt(CmpC))) 423 return false; 424 425 // These transforms only work for selects of integers or vector selects of 426 // integer vectors. 427 Type *SelTy = Sel.getType(); 428 auto *SelEltTy = dyn_cast<IntegerType>(SelTy->getScalarType()); 429 if (!SelEltTy || SelTy->isVectorTy() != Cmp.getType()->isVectorTy()) 430 return false; 431 432 Constant *AdjustedRHS; 433 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_SGT) 434 AdjustedRHS = ConstantInt::get(CmpRHS->getType(), *CmpC + 1); 435 else if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_SLT) 436 AdjustedRHS = ConstantInt::get(CmpRHS->getType(), *CmpC - 1); 437 else 438 return false; 439 440 // X > C ? X : C+1 --> X < C+1 ? C+1 : X 441 // X < C ? X : C-1 --> X > C-1 ? C-1 : X 442 if ((CmpLHS == TrueVal && AdjustedRHS == FalseVal) || 443 (CmpLHS == FalseVal && AdjustedRHS == TrueVal)) { 444 ; // Nothing to do here. Values match without any sign/zero extension. 445 } 446 // Types do not match. Instead of calculating this with mixed types, promote 447 // all to the larger type. This enables scalar evolution to analyze this 448 // expression. 449 else if (CmpRHS->getType()->getScalarSizeInBits() < SelEltTy->getBitWidth()) { 450 Constant *SextRHS = ConstantExpr::getSExt(AdjustedRHS, SelTy); 451 452 // X = sext x; x >s c ? X : C+1 --> X = sext x; X <s C+1 ? C+1 : X 453 // X = sext x; x <s c ? X : C-1 --> X = sext x; X >s C-1 ? C-1 : X 454 // X = sext x; x >u c ? X : C+1 --> X = sext x; X <u C+1 ? C+1 : X 455 // X = sext x; x <u c ? X : C-1 --> X = sext x; X >u C-1 ? C-1 : X 456 if (match(TrueVal, m_SExt(m_Specific(CmpLHS))) && SextRHS == FalseVal) { 457 CmpLHS = TrueVal; 458 AdjustedRHS = SextRHS; 459 } else if (match(FalseVal, m_SExt(m_Specific(CmpLHS))) && 460 SextRHS == TrueVal) { 461 CmpLHS = FalseVal; 462 AdjustedRHS = SextRHS; 463 } else if (Cmp.isUnsigned()) { 464 Constant *ZextRHS = ConstantExpr::getZExt(AdjustedRHS, SelTy); 465 // X = zext x; x >u c ? X : C+1 --> X = zext x; X <u C+1 ? C+1 : X 466 // X = zext x; x <u c ? X : C-1 --> X = zext x; X >u C-1 ? C-1 : X 467 // zext + signed compare cannot be changed: 468 // 0xff <s 0x00, but 0x00ff >s 0x0000 469 if (match(TrueVal, m_ZExt(m_Specific(CmpLHS))) && ZextRHS == FalseVal) { 470 CmpLHS = TrueVal; 471 AdjustedRHS = ZextRHS; 472 } else if (match(FalseVal, m_ZExt(m_Specific(CmpLHS))) && 473 ZextRHS == TrueVal) { 474 CmpLHS = FalseVal; 475 AdjustedRHS = ZextRHS; 476 } else { 477 return false; 478 } 479 } else { 480 return false; 481 } 482 } else { 483 return false; 484 } 485 486 Pred = ICmpInst::getSwappedPredicate(Pred); 487 CmpRHS = AdjustedRHS; 488 std::swap(FalseVal, TrueVal); 489 Cmp.setPredicate(Pred); 490 Cmp.setOperand(0, CmpLHS); 491 Cmp.setOperand(1, CmpRHS); 492 Sel.setOperand(1, TrueVal); 493 Sel.setOperand(2, FalseVal); 494 Sel.swapProfMetadata(); 495 496 // Move the compare instruction right before the select instruction. Otherwise 497 // the sext/zext value may be defined after the compare instruction uses it. 498 Cmp.moveBefore(&Sel); 499 500 return true; 501 } 502 503 /// If this is an integer min/max where the select's 'true' operand is a 504 /// constant, canonicalize that constant to the 'false' operand: 505 /// select (icmp Pred X, C), C, X --> select (icmp Pred' X, C), X, C 506 static Instruction * 507 canonicalizeMinMaxWithConstant(SelectInst &Sel, ICmpInst &Cmp, 508 InstCombiner::BuilderTy &Builder) { 509 // TODO: We should also canonicalize min/max when the select has a different 510 // constant value than the cmp constant, but we need to fix the backend first. 511 if (!Cmp.hasOneUse() || !isa<Constant>(Cmp.getOperand(1)) || 512 !isa<Constant>(Sel.getTrueValue()) || 513 isa<Constant>(Sel.getFalseValue()) || 514 Cmp.getOperand(1) != Sel.getTrueValue()) 515 return nullptr; 516 517 // Canonicalize the compare predicate based on whether we have min or max. 518 Value *LHS, *RHS; 519 ICmpInst::Predicate NewPred; 520 SelectPatternResult SPR = matchSelectPattern(&Sel, LHS, RHS); 521 switch (SPR.Flavor) { 522 case SPF_SMIN: NewPred = ICmpInst::ICMP_SLT; break; 523 case SPF_UMIN: NewPred = ICmpInst::ICMP_ULT; break; 524 case SPF_SMAX: NewPred = ICmpInst::ICMP_SGT; break; 525 case SPF_UMAX: NewPred = ICmpInst::ICMP_UGT; break; 526 default: return nullptr; 527 } 528 529 // Canonicalize the constant to the right side. 530 if (isa<Constant>(LHS)) 531 std::swap(LHS, RHS); 532 533 Value *NewCmp = Builder.CreateICmp(NewPred, LHS, RHS); 534 SelectInst *NewSel = SelectInst::Create(NewCmp, LHS, RHS); 535 NewSel->copyMetadata(Sel); 536 537 // We swapped the select operands, so swap the metadata too. 538 NewSel->swapProfMetadata(); 539 return NewSel; 540 } 541 542 /// Visit a SelectInst that has an ICmpInst as its first operand. 543 Instruction *InstCombiner::foldSelectInstWithICmp(SelectInst &SI, 544 ICmpInst *ICI) { 545 if (Instruction *NewSel = canonicalizeMinMaxWithConstant(SI, *ICI, *Builder)) 546 return NewSel; 547 548 bool Changed = adjustMinMax(SI, *ICI); 549 550 ICmpInst::Predicate Pred = ICI->getPredicate(); 551 Value *CmpLHS = ICI->getOperand(0); 552 Value *CmpRHS = ICI->getOperand(1); 553 Value *TrueVal = SI.getTrueValue(); 554 Value *FalseVal = SI.getFalseValue(); 555 556 // Transform (X >s -1) ? C1 : C2 --> ((X >>s 31) & (C2 - C1)) + C1 557 // and (X <s 0) ? C2 : C1 --> ((X >>s 31) & (C2 - C1)) + C1 558 // FIXME: Type and constness constraints could be lifted, but we have to 559 // watch code size carefully. We should consider xor instead of 560 // sub/add when we decide to do that. 561 if (IntegerType *Ty = dyn_cast<IntegerType>(CmpLHS->getType())) { 562 if (TrueVal->getType() == Ty) { 563 if (ConstantInt *Cmp = dyn_cast<ConstantInt>(CmpRHS)) { 564 ConstantInt *C1 = nullptr, *C2 = nullptr; 565 if (Pred == ICmpInst::ICMP_SGT && Cmp->isAllOnesValue()) { 566 C1 = dyn_cast<ConstantInt>(TrueVal); 567 C2 = dyn_cast<ConstantInt>(FalseVal); 568 } else if (Pred == ICmpInst::ICMP_SLT && Cmp->isNullValue()) { 569 C1 = dyn_cast<ConstantInt>(FalseVal); 570 C2 = dyn_cast<ConstantInt>(TrueVal); 571 } 572 if (C1 && C2) { 573 // This shift results in either -1 or 0. 574 Value *AShr = Builder->CreateAShr(CmpLHS, Ty->getBitWidth()-1); 575 576 // Check if we can express the operation with a single or. 577 if (C2->isAllOnesValue()) 578 return replaceInstUsesWith(SI, Builder->CreateOr(AShr, C1)); 579 580 Value *And = Builder->CreateAnd(AShr, C2->getValue()-C1->getValue()); 581 return replaceInstUsesWith(SI, Builder->CreateAdd(And, C1)); 582 } 583 } 584 } 585 } 586 587 // NOTE: if we wanted to, this is where to detect integer MIN/MAX 588 589 if (CmpRHS != CmpLHS && isa<Constant>(CmpRHS)) { 590 if (CmpLHS == TrueVal && Pred == ICmpInst::ICMP_EQ) { 591 // Transform (X == C) ? X : Y -> (X == C) ? C : Y 592 SI.setOperand(1, CmpRHS); 593 Changed = true; 594 } else if (CmpLHS == FalseVal && Pred == ICmpInst::ICMP_NE) { 595 // Transform (X != C) ? Y : X -> (X != C) ? Y : C 596 SI.setOperand(2, CmpRHS); 597 Changed = true; 598 } 599 } 600 601 // FIXME: This code is nearly duplicated in InstSimplify. Using/refactoring 602 // decomposeBitTestICmp() might help. 603 { 604 unsigned BitWidth = 605 DL.getTypeSizeInBits(TrueVal->getType()->getScalarType()); 606 APInt MinSignedValue = APInt::getSignBit(BitWidth); 607 Value *X; 608 const APInt *Y, *C; 609 bool TrueWhenUnset; 610 bool IsBitTest = false; 611 if (ICmpInst::isEquality(Pred) && 612 match(CmpLHS, m_And(m_Value(X), m_Power2(Y))) && 613 match(CmpRHS, m_Zero())) { 614 IsBitTest = true; 615 TrueWhenUnset = Pred == ICmpInst::ICMP_EQ; 616 } else if (Pred == ICmpInst::ICMP_SLT && match(CmpRHS, m_Zero())) { 617 X = CmpLHS; 618 Y = &MinSignedValue; 619 IsBitTest = true; 620 TrueWhenUnset = false; 621 } else if (Pred == ICmpInst::ICMP_SGT && match(CmpRHS, m_AllOnes())) { 622 X = CmpLHS; 623 Y = &MinSignedValue; 624 IsBitTest = true; 625 TrueWhenUnset = true; 626 } 627 if (IsBitTest) { 628 Value *V = nullptr; 629 // (X & Y) == 0 ? X : X ^ Y --> X & ~Y 630 if (TrueWhenUnset && TrueVal == X && 631 match(FalseVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 632 V = Builder->CreateAnd(X, ~(*Y)); 633 // (X & Y) != 0 ? X ^ Y : X --> X & ~Y 634 else if (!TrueWhenUnset && FalseVal == X && 635 match(TrueVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 636 V = Builder->CreateAnd(X, ~(*Y)); 637 // (X & Y) == 0 ? X ^ Y : X --> X | Y 638 else if (TrueWhenUnset && FalseVal == X && 639 match(TrueVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 640 V = Builder->CreateOr(X, *Y); 641 // (X & Y) != 0 ? X : X ^ Y --> X | Y 642 else if (!TrueWhenUnset && TrueVal == X && 643 match(FalseVal, m_Xor(m_Specific(X), m_APInt(C))) && *Y == *C) 644 V = Builder->CreateOr(X, *Y); 645 646 if (V) 647 return replaceInstUsesWith(SI, V); 648 } 649 } 650 651 if (Value *V = foldSelectICmpAndOr(SI, TrueVal, FalseVal, Builder)) 652 return replaceInstUsesWith(SI, V); 653 654 if (Value *V = foldSelectCttzCtlz(ICI, TrueVal, FalseVal, Builder)) 655 return replaceInstUsesWith(SI, V); 656 657 return Changed ? &SI : nullptr; 658 } 659 660 661 /// SI is a select whose condition is a PHI node (but the two may be in 662 /// different blocks). See if the true/false values (V) are live in all of the 663 /// predecessor blocks of the PHI. For example, cases like this can't be mapped: 664 /// 665 /// X = phi [ C1, BB1], [C2, BB2] 666 /// Y = add 667 /// Z = select X, Y, 0 668 /// 669 /// because Y is not live in BB1/BB2. 670 /// 671 static bool canSelectOperandBeMappingIntoPredBlock(const Value *V, 672 const SelectInst &SI) { 673 // If the value is a non-instruction value like a constant or argument, it 674 // can always be mapped. 675 const Instruction *I = dyn_cast<Instruction>(V); 676 if (!I) return true; 677 678 // If V is a PHI node defined in the same block as the condition PHI, we can 679 // map the arguments. 680 const PHINode *CondPHI = cast<PHINode>(SI.getCondition()); 681 682 if (const PHINode *VP = dyn_cast<PHINode>(I)) 683 if (VP->getParent() == CondPHI->getParent()) 684 return true; 685 686 // Otherwise, if the PHI and select are defined in the same block and if V is 687 // defined in a different block, then we can transform it. 688 if (SI.getParent() == CondPHI->getParent() && 689 I->getParent() != CondPHI->getParent()) 690 return true; 691 692 // Otherwise we have a 'hard' case and we can't tell without doing more 693 // detailed dominator based analysis, punt. 694 return false; 695 } 696 697 /// We have an SPF (e.g. a min or max) of an SPF of the form: 698 /// SPF2(SPF1(A, B), C) 699 Instruction *InstCombiner::foldSPFofSPF(Instruction *Inner, 700 SelectPatternFlavor SPF1, 701 Value *A, Value *B, 702 Instruction &Outer, 703 SelectPatternFlavor SPF2, Value *C) { 704 if (Outer.getType() != Inner->getType()) 705 return nullptr; 706 707 if (C == A || C == B) { 708 // MAX(MAX(A, B), B) -> MAX(A, B) 709 // MIN(MIN(a, b), a) -> MIN(a, b) 710 if (SPF1 == SPF2) 711 return replaceInstUsesWith(Outer, Inner); 712 713 // MAX(MIN(a, b), a) -> a 714 // MIN(MAX(a, b), a) -> a 715 if ((SPF1 == SPF_SMIN && SPF2 == SPF_SMAX) || 716 (SPF1 == SPF_SMAX && SPF2 == SPF_SMIN) || 717 (SPF1 == SPF_UMIN && SPF2 == SPF_UMAX) || 718 (SPF1 == SPF_UMAX && SPF2 == SPF_UMIN)) 719 return replaceInstUsesWith(Outer, C); 720 } 721 722 if (SPF1 == SPF2) { 723 const APInt *CB, *CC; 724 if (match(B, m_APInt(CB)) && match(C, m_APInt(CC))) { 725 // MIN(MIN(A, 23), 97) -> MIN(A, 23) 726 // MAX(MAX(A, 97), 23) -> MAX(A, 97) 727 if ((SPF1 == SPF_UMIN && CB->ule(*CC)) || 728 (SPF1 == SPF_SMIN && CB->sle(*CC)) || 729 (SPF1 == SPF_UMAX && CB->uge(*CC)) || 730 (SPF1 == SPF_SMAX && CB->sge(*CC))) 731 return replaceInstUsesWith(Outer, Inner); 732 733 // MIN(MIN(A, 97), 23) -> MIN(A, 23) 734 // MAX(MAX(A, 23), 97) -> MAX(A, 97) 735 if ((SPF1 == SPF_UMIN && CB->ugt(*CC)) || 736 (SPF1 == SPF_SMIN && CB->sgt(*CC)) || 737 (SPF1 == SPF_UMAX && CB->ult(*CC)) || 738 (SPF1 == SPF_SMAX && CB->slt(*CC))) { 739 Outer.replaceUsesOfWith(Inner, A); 740 return &Outer; 741 } 742 } 743 } 744 745 // ABS(ABS(X)) -> ABS(X) 746 // NABS(NABS(X)) -> NABS(X) 747 if (SPF1 == SPF2 && (SPF1 == SPF_ABS || SPF1 == SPF_NABS)) { 748 return replaceInstUsesWith(Outer, Inner); 749 } 750 751 // ABS(NABS(X)) -> ABS(X) 752 // NABS(ABS(X)) -> NABS(X) 753 if ((SPF1 == SPF_ABS && SPF2 == SPF_NABS) || 754 (SPF1 == SPF_NABS && SPF2 == SPF_ABS)) { 755 SelectInst *SI = cast<SelectInst>(Inner); 756 Value *NewSI = 757 Builder->CreateSelect(SI->getCondition(), SI->getFalseValue(), 758 SI->getTrueValue(), SI->getName(), SI); 759 return replaceInstUsesWith(Outer, NewSI); 760 } 761 762 auto IsFreeOrProfitableToInvert = 763 [&](Value *V, Value *&NotV, bool &ElidesXor) { 764 if (match(V, m_Not(m_Value(NotV)))) { 765 // If V has at most 2 uses then we can get rid of the xor operation 766 // entirely. 767 ElidesXor |= !V->hasNUsesOrMore(3); 768 return true; 769 } 770 771 if (IsFreeToInvert(V, !V->hasNUsesOrMore(3))) { 772 NotV = nullptr; 773 return true; 774 } 775 776 return false; 777 }; 778 779 Value *NotA, *NotB, *NotC; 780 bool ElidesXor = false; 781 782 // MIN(MIN(~A, ~B), ~C) == ~MAX(MAX(A, B), C) 783 // MIN(MAX(~A, ~B), ~C) == ~MAX(MIN(A, B), C) 784 // MAX(MIN(~A, ~B), ~C) == ~MIN(MAX(A, B), C) 785 // MAX(MAX(~A, ~B), ~C) == ~MIN(MIN(A, B), C) 786 // 787 // This transform is performance neutral if we can elide at least one xor from 788 // the set of three operands, since we'll be tacking on an xor at the very 789 // end. 790 if (IsFreeOrProfitableToInvert(A, NotA, ElidesXor) && 791 IsFreeOrProfitableToInvert(B, NotB, ElidesXor) && 792 IsFreeOrProfitableToInvert(C, NotC, ElidesXor) && ElidesXor) { 793 if (!NotA) 794 NotA = Builder->CreateNot(A); 795 if (!NotB) 796 NotB = Builder->CreateNot(B); 797 if (!NotC) 798 NotC = Builder->CreateNot(C); 799 800 Value *NewInner = generateMinMaxSelectPattern( 801 Builder, getInverseMinMaxSelectPattern(SPF1), NotA, NotB); 802 Value *NewOuter = Builder->CreateNot(generateMinMaxSelectPattern( 803 Builder, getInverseMinMaxSelectPattern(SPF2), NewInner, NotC)); 804 return replaceInstUsesWith(Outer, NewOuter); 805 } 806 807 return nullptr; 808 } 809 810 /// If one of the constants is zero (we know they can't both be) and we have an 811 /// icmp instruction with zero, and we have an 'and' with the non-constant value 812 /// and a power of two we can turn the select into a shift on the result of the 813 /// 'and'. 814 static Value *foldSelectICmpAnd(const SelectInst &SI, ConstantInt *TrueVal, 815 ConstantInt *FalseVal, 816 InstCombiner::BuilderTy *Builder) { 817 const ICmpInst *IC = dyn_cast<ICmpInst>(SI.getCondition()); 818 if (!IC || !IC->isEquality() || !SI.getType()->isIntegerTy()) 819 return nullptr; 820 821 if (!match(IC->getOperand(1), m_Zero())) 822 return nullptr; 823 824 ConstantInt *AndRHS; 825 Value *LHS = IC->getOperand(0); 826 if (!match(LHS, m_And(m_Value(), m_ConstantInt(AndRHS)))) 827 return nullptr; 828 829 // If both select arms are non-zero see if we have a select of the form 830 // 'x ? 2^n + C : C'. Then we can offset both arms by C, use the logic 831 // for 'x ? 2^n : 0' and fix the thing up at the end. 832 ConstantInt *Offset = nullptr; 833 if (!TrueVal->isZero() && !FalseVal->isZero()) { 834 if ((TrueVal->getValue() - FalseVal->getValue()).isPowerOf2()) 835 Offset = FalseVal; 836 else if ((FalseVal->getValue() - TrueVal->getValue()).isPowerOf2()) 837 Offset = TrueVal; 838 else 839 return nullptr; 840 841 // Adjust TrueVal and FalseVal to the offset. 842 TrueVal = ConstantInt::get(Builder->getContext(), 843 TrueVal->getValue() - Offset->getValue()); 844 FalseVal = ConstantInt::get(Builder->getContext(), 845 FalseVal->getValue() - Offset->getValue()); 846 } 847 848 // Make sure the mask in the 'and' and one of the select arms is a power of 2. 849 if (!AndRHS->getValue().isPowerOf2() || 850 (!TrueVal->getValue().isPowerOf2() && 851 !FalseVal->getValue().isPowerOf2())) 852 return nullptr; 853 854 // Determine which shift is needed to transform result of the 'and' into the 855 // desired result. 856 ConstantInt *ValC = !TrueVal->isZero() ? TrueVal : FalseVal; 857 unsigned ValZeros = ValC->getValue().logBase2(); 858 unsigned AndZeros = AndRHS->getValue().logBase2(); 859 860 // If types don't match we can still convert the select by introducing a zext 861 // or a trunc of the 'and'. The trunc case requires that all of the truncated 862 // bits are zero, we can figure that out by looking at the 'and' mask. 863 if (AndZeros >= ValC->getBitWidth()) 864 return nullptr; 865 866 Value *V = Builder->CreateZExtOrTrunc(LHS, SI.getType()); 867 if (ValZeros > AndZeros) 868 V = Builder->CreateShl(V, ValZeros - AndZeros); 869 else if (ValZeros < AndZeros) 870 V = Builder->CreateLShr(V, AndZeros - ValZeros); 871 872 // Okay, now we know that everything is set up, we just don't know whether we 873 // have a icmp_ne or icmp_eq and whether the true or false val is the zero. 874 bool ShouldNotVal = !TrueVal->isZero(); 875 ShouldNotVal ^= IC->getPredicate() == ICmpInst::ICMP_NE; 876 if (ShouldNotVal) 877 V = Builder->CreateXor(V, ValC); 878 879 // Apply an offset if needed. 880 if (Offset) 881 V = Builder->CreateAdd(V, Offset); 882 return V; 883 } 884 885 /// Turn select C, (X + Y), (X - Y) --> (X + (select C, Y, (-Y))). 886 /// This is even legal for FP. 887 static Instruction *foldAddSubSelect(SelectInst &SI, 888 InstCombiner::BuilderTy &Builder) { 889 Value *CondVal = SI.getCondition(); 890 Value *TrueVal = SI.getTrueValue(); 891 Value *FalseVal = SI.getFalseValue(); 892 auto *TI = dyn_cast<Instruction>(TrueVal); 893 auto *FI = dyn_cast<Instruction>(FalseVal); 894 if (!TI || !FI || !TI->hasOneUse() || !FI->hasOneUse()) 895 return nullptr; 896 897 Instruction *AddOp = nullptr, *SubOp = nullptr; 898 if ((TI->getOpcode() == Instruction::Sub && 899 FI->getOpcode() == Instruction::Add) || 900 (TI->getOpcode() == Instruction::FSub && 901 FI->getOpcode() == Instruction::FAdd)) { 902 AddOp = FI; 903 SubOp = TI; 904 } else if ((FI->getOpcode() == Instruction::Sub && 905 TI->getOpcode() == Instruction::Add) || 906 (FI->getOpcode() == Instruction::FSub && 907 TI->getOpcode() == Instruction::FAdd)) { 908 AddOp = TI; 909 SubOp = FI; 910 } 911 912 if (AddOp) { 913 Value *OtherAddOp = nullptr; 914 if (SubOp->getOperand(0) == AddOp->getOperand(0)) { 915 OtherAddOp = AddOp->getOperand(1); 916 } else if (SubOp->getOperand(0) == AddOp->getOperand(1)) { 917 OtherAddOp = AddOp->getOperand(0); 918 } 919 920 if (OtherAddOp) { 921 // So at this point we know we have (Y -> OtherAddOp): 922 // select C, (add X, Y), (sub X, Z) 923 Value *NegVal; // Compute -Z 924 if (SI.getType()->isFPOrFPVectorTy()) { 925 NegVal = Builder.CreateFNeg(SubOp->getOperand(1)); 926 if (Instruction *NegInst = dyn_cast<Instruction>(NegVal)) { 927 FastMathFlags Flags = AddOp->getFastMathFlags(); 928 Flags &= SubOp->getFastMathFlags(); 929 NegInst->setFastMathFlags(Flags); 930 } 931 } else { 932 NegVal = Builder.CreateNeg(SubOp->getOperand(1)); 933 } 934 935 Value *NewTrueOp = OtherAddOp; 936 Value *NewFalseOp = NegVal; 937 if (AddOp != TI) 938 std::swap(NewTrueOp, NewFalseOp); 939 Value *NewSel = Builder.CreateSelect(CondVal, NewTrueOp, NewFalseOp, 940 SI.getName() + ".p", &SI); 941 942 if (SI.getType()->isFPOrFPVectorTy()) { 943 Instruction *RI = 944 BinaryOperator::CreateFAdd(SubOp->getOperand(0), NewSel); 945 946 FastMathFlags Flags = AddOp->getFastMathFlags(); 947 Flags &= SubOp->getFastMathFlags(); 948 RI->setFastMathFlags(Flags); 949 return RI; 950 } else 951 return BinaryOperator::CreateAdd(SubOp->getOperand(0), NewSel); 952 } 953 } 954 return nullptr; 955 } 956 957 Instruction *InstCombiner::foldSelectExtConst(SelectInst &Sel) { 958 Instruction *ExtInst; 959 if (!match(Sel.getTrueValue(), m_Instruction(ExtInst)) && 960 !match(Sel.getFalseValue(), m_Instruction(ExtInst))) 961 return nullptr; 962 963 auto ExtOpcode = ExtInst->getOpcode(); 964 if (ExtOpcode != Instruction::ZExt && ExtOpcode != Instruction::SExt) 965 return nullptr; 966 967 // TODO: Handle larger types? That requires adjusting FoldOpIntoSelect too. 968 Value *X = ExtInst->getOperand(0); 969 Type *SmallType = X->getType(); 970 if (!SmallType->getScalarType()->isIntegerTy(1)) 971 return nullptr; 972 973 Constant *C; 974 if (!match(Sel.getTrueValue(), m_Constant(C)) && 975 !match(Sel.getFalseValue(), m_Constant(C))) 976 return nullptr; 977 978 // If the constant is the same after truncation to the smaller type and 979 // extension to the original type, we can narrow the select. 980 Value *Cond = Sel.getCondition(); 981 Type *SelType = Sel.getType(); 982 Constant *TruncC = ConstantExpr::getTrunc(C, SmallType); 983 Constant *ExtC = ConstantExpr::getCast(ExtOpcode, TruncC, SelType); 984 if (ExtC == C) { 985 Value *TruncCVal = cast<Value>(TruncC); 986 if (ExtInst == Sel.getFalseValue()) 987 std::swap(X, TruncCVal); 988 989 // select Cond, (ext X), C --> ext(select Cond, X, C') 990 // select Cond, C, (ext X) --> ext(select Cond, C', X) 991 Value *NewSel = Builder->CreateSelect(Cond, X, TruncCVal, "narrow", &Sel); 992 return CastInst::Create(Instruction::CastOps(ExtOpcode), NewSel, SelType); 993 } 994 995 // If one arm of the select is the extend of the condition, replace that arm 996 // with the extension of the appropriate known bool value. 997 if (Cond == X) { 998 SelectInst *NewSel; 999 if (ExtInst == Sel.getTrueValue()) { 1000 // select X, (sext X), C --> select X, -1, C 1001 // select X, (zext X), C --> select X, 1, C 1002 Constant *One = ConstantInt::getTrue(SmallType); 1003 Constant *AllOnesOrOne = ConstantExpr::getCast(ExtOpcode, One, SelType); 1004 NewSel = SelectInst::Create(Cond, AllOnesOrOne, C); 1005 } else { 1006 // select X, C, (sext X) --> select X, C, 0 1007 // select X, C, (zext X) --> select X, C, 0 1008 Constant *Zero = ConstantInt::getNullValue(SelType); 1009 NewSel = SelectInst::Create(Cond, C, Zero); 1010 } 1011 NewSel->copyMetadata(Sel); 1012 return NewSel; 1013 } 1014 1015 return nullptr; 1016 } 1017 1018 /// Try to transform a vector select with a constant condition vector into a 1019 /// shuffle for easier combining with other shuffles and insert/extract. 1020 static Instruction *canonicalizeSelectToShuffle(SelectInst &SI) { 1021 Value *CondVal = SI.getCondition(); 1022 Constant *CondC; 1023 if (!CondVal->getType()->isVectorTy() || !match(CondVal, m_Constant(CondC))) 1024 return nullptr; 1025 1026 unsigned NumElts = CondVal->getType()->getVectorNumElements(); 1027 SmallVector<Constant *, 16> Mask; 1028 Mask.reserve(NumElts); 1029 Type *Int32Ty = Type::getInt32Ty(CondVal->getContext()); 1030 for (unsigned i = 0; i != NumElts; ++i) { 1031 Constant *Elt = CondC->getAggregateElement(i); 1032 if (!Elt) 1033 return nullptr; 1034 1035 if (Elt->isOneValue()) { 1036 // If the select condition element is true, choose from the 1st vector. 1037 Mask.push_back(ConstantInt::get(Int32Ty, i)); 1038 } else if (Elt->isNullValue()) { 1039 // If the select condition element is false, choose from the 2nd vector. 1040 Mask.push_back(ConstantInt::get(Int32Ty, i + NumElts)); 1041 } else if (isa<UndefValue>(Elt)) { 1042 // If the select condition element is undef, the shuffle mask is undef. 1043 Mask.push_back(UndefValue::get(Int32Ty)); 1044 } else { 1045 // Bail out on a constant expression. 1046 return nullptr; 1047 } 1048 } 1049 1050 return new ShuffleVectorInst(SI.getTrueValue(), SI.getFalseValue(), 1051 ConstantVector::get(Mask)); 1052 } 1053 1054 /// Reuse bitcasted operands between a compare and select: 1055 /// select (cmp (bitcast C), (bitcast D)), (bitcast' C), (bitcast' D) --> 1056 /// bitcast (select (cmp (bitcast C), (bitcast D)), (bitcast C), (bitcast D)) 1057 static Instruction *foldSelectCmpBitcasts(SelectInst &Sel, 1058 InstCombiner::BuilderTy &Builder) { 1059 Value *Cond = Sel.getCondition(); 1060 Value *TVal = Sel.getTrueValue(); 1061 Value *FVal = Sel.getFalseValue(); 1062 1063 CmpInst::Predicate Pred; 1064 Value *A, *B; 1065 if (!match(Cond, m_Cmp(Pred, m_Value(A), m_Value(B)))) 1066 return nullptr; 1067 1068 // The select condition is a compare instruction. If the select's true/false 1069 // values are already the same as the compare operands, there's nothing to do. 1070 if (TVal == A || TVal == B || FVal == A || FVal == B) 1071 return nullptr; 1072 1073 Value *C, *D; 1074 if (!match(A, m_BitCast(m_Value(C))) || !match(B, m_BitCast(m_Value(D)))) 1075 return nullptr; 1076 1077 // select (cmp (bitcast C), (bitcast D)), (bitcast TSrc), (bitcast FSrc) 1078 Value *TSrc, *FSrc; 1079 if (!match(TVal, m_BitCast(m_Value(TSrc))) || 1080 !match(FVal, m_BitCast(m_Value(FSrc)))) 1081 return nullptr; 1082 1083 // If the select true/false values are *different bitcasts* of the same source 1084 // operands, make the select operands the same as the compare operands and 1085 // cast the result. This is the canonical select form for min/max. 1086 Value *NewSel; 1087 if (TSrc == C && FSrc == D) { 1088 // select (cmp (bitcast C), (bitcast D)), (bitcast' C), (bitcast' D) --> 1089 // bitcast (select (cmp A, B), A, B) 1090 NewSel = Builder.CreateSelect(Cond, A, B, "", &Sel); 1091 } else if (TSrc == D && FSrc == C) { 1092 // select (cmp (bitcast C), (bitcast D)), (bitcast' D), (bitcast' C) --> 1093 // bitcast (select (cmp A, B), B, A) 1094 NewSel = Builder.CreateSelect(Cond, B, A, "", &Sel); 1095 } else { 1096 return nullptr; 1097 } 1098 return CastInst::CreateBitOrPointerCast(NewSel, Sel.getType()); 1099 } 1100 1101 Instruction *InstCombiner::visitSelectInst(SelectInst &SI) { 1102 Value *CondVal = SI.getCondition(); 1103 Value *TrueVal = SI.getTrueValue(); 1104 Value *FalseVal = SI.getFalseValue(); 1105 Type *SelType = SI.getType(); 1106 1107 if (Value *V = 1108 SimplifySelectInst(CondVal, TrueVal, FalseVal, DL, &TLI, &DT, &AC)) 1109 return replaceInstUsesWith(SI, V); 1110 1111 if (Instruction *I = canonicalizeSelectToShuffle(SI)) 1112 return I; 1113 1114 if (SelType->getScalarType()->isIntegerTy(1) && 1115 TrueVal->getType() == CondVal->getType()) { 1116 if (match(TrueVal, m_One())) { 1117 // Change: A = select B, true, C --> A = or B, C 1118 return BinaryOperator::CreateOr(CondVal, FalseVal); 1119 } 1120 if (match(TrueVal, m_Zero())) { 1121 // Change: A = select B, false, C --> A = and !B, C 1122 Value *NotCond = Builder->CreateNot(CondVal, "not." + CondVal->getName()); 1123 return BinaryOperator::CreateAnd(NotCond, FalseVal); 1124 } 1125 if (match(FalseVal, m_Zero())) { 1126 // Change: A = select B, C, false --> A = and B, C 1127 return BinaryOperator::CreateAnd(CondVal, TrueVal); 1128 } 1129 if (match(FalseVal, m_One())) { 1130 // Change: A = select B, C, true --> A = or !B, C 1131 Value *NotCond = Builder->CreateNot(CondVal, "not." + CondVal->getName()); 1132 return BinaryOperator::CreateOr(NotCond, TrueVal); 1133 } 1134 1135 // select a, a, b -> a | b 1136 // select a, b, a -> a & b 1137 if (CondVal == TrueVal) 1138 return BinaryOperator::CreateOr(CondVal, FalseVal); 1139 if (CondVal == FalseVal) 1140 return BinaryOperator::CreateAnd(CondVal, TrueVal); 1141 1142 // select a, ~a, b -> (~a) & b 1143 // select a, b, ~a -> (~a) | b 1144 if (match(TrueVal, m_Not(m_Specific(CondVal)))) 1145 return BinaryOperator::CreateAnd(TrueVal, FalseVal); 1146 if (match(FalseVal, m_Not(m_Specific(CondVal)))) 1147 return BinaryOperator::CreateOr(TrueVal, FalseVal); 1148 } 1149 1150 // Selecting between two integer or vector splat integer constants? 1151 // 1152 // Note that we don't handle a scalar select of vectors: 1153 // select i1 %c, <2 x i8> <1, 1>, <2 x i8> <0, 0> 1154 // because that may need 3 instructions to splat the condition value: 1155 // extend, insertelement, shufflevector. 1156 if (CondVal->getType()->isVectorTy() == SelType->isVectorTy()) { 1157 // select C, 1, 0 -> zext C to int 1158 if (match(TrueVal, m_One()) && match(FalseVal, m_Zero())) 1159 return new ZExtInst(CondVal, SelType); 1160 1161 // select C, -1, 0 -> sext C to int 1162 if (match(TrueVal, m_AllOnes()) && match(FalseVal, m_Zero())) 1163 return new SExtInst(CondVal, SelType); 1164 1165 // select C, 0, 1 -> zext !C to int 1166 if (match(TrueVal, m_Zero()) && match(FalseVal, m_One())) { 1167 Value *NotCond = Builder->CreateNot(CondVal, "not." + CondVal->getName()); 1168 return new ZExtInst(NotCond, SelType); 1169 } 1170 1171 // select C, 0, -1 -> sext !C to int 1172 if (match(TrueVal, m_Zero()) && match(FalseVal, m_AllOnes())) { 1173 Value *NotCond = Builder->CreateNot(CondVal, "not." + CondVal->getName()); 1174 return new SExtInst(NotCond, SelType); 1175 } 1176 } 1177 1178 if (ConstantInt *TrueValC = dyn_cast<ConstantInt>(TrueVal)) 1179 if (ConstantInt *FalseValC = dyn_cast<ConstantInt>(FalseVal)) 1180 if (Value *V = foldSelectICmpAnd(SI, TrueValC, FalseValC, Builder)) 1181 return replaceInstUsesWith(SI, V); 1182 1183 // See if we are selecting two values based on a comparison of the two values. 1184 if (FCmpInst *FCI = dyn_cast<FCmpInst>(CondVal)) { 1185 if (FCI->getOperand(0) == TrueVal && FCI->getOperand(1) == FalseVal) { 1186 // Transform (X == Y) ? X : Y -> Y 1187 if (FCI->getPredicate() == FCmpInst::FCMP_OEQ) { 1188 // This is not safe in general for floating point: 1189 // consider X== -0, Y== +0. 1190 // It becomes safe if either operand is a nonzero constant. 1191 ConstantFP *CFPt, *CFPf; 1192 if (((CFPt = dyn_cast<ConstantFP>(TrueVal)) && 1193 !CFPt->getValueAPF().isZero()) || 1194 ((CFPf = dyn_cast<ConstantFP>(FalseVal)) && 1195 !CFPf->getValueAPF().isZero())) 1196 return replaceInstUsesWith(SI, FalseVal); 1197 } 1198 // Transform (X une Y) ? X : Y -> X 1199 if (FCI->getPredicate() == FCmpInst::FCMP_UNE) { 1200 // This is not safe in general for floating point: 1201 // consider X== -0, Y== +0. 1202 // It becomes safe if either operand is a nonzero constant. 1203 ConstantFP *CFPt, *CFPf; 1204 if (((CFPt = dyn_cast<ConstantFP>(TrueVal)) && 1205 !CFPt->getValueAPF().isZero()) || 1206 ((CFPf = dyn_cast<ConstantFP>(FalseVal)) && 1207 !CFPf->getValueAPF().isZero())) 1208 return replaceInstUsesWith(SI, TrueVal); 1209 } 1210 1211 // Canonicalize to use ordered comparisons by swapping the select 1212 // operands. 1213 // 1214 // e.g. 1215 // (X ugt Y) ? X : Y -> (X ole Y) ? Y : X 1216 if (FCI->hasOneUse() && FCmpInst::isUnordered(FCI->getPredicate())) { 1217 FCmpInst::Predicate InvPred = FCI->getInversePredicate(); 1218 IRBuilder<>::FastMathFlagGuard FMFG(*Builder); 1219 Builder->setFastMathFlags(FCI->getFastMathFlags()); 1220 Value *NewCond = Builder->CreateFCmp(InvPred, TrueVal, FalseVal, 1221 FCI->getName() + ".inv"); 1222 1223 return SelectInst::Create(NewCond, FalseVal, TrueVal, 1224 SI.getName() + ".p"); 1225 } 1226 1227 // NOTE: if we wanted to, this is where to detect MIN/MAX 1228 } else if (FCI->getOperand(0) == FalseVal && FCI->getOperand(1) == TrueVal){ 1229 // Transform (X == Y) ? Y : X -> X 1230 if (FCI->getPredicate() == FCmpInst::FCMP_OEQ) { 1231 // This is not safe in general for floating point: 1232 // consider X== -0, Y== +0. 1233 // It becomes safe if either operand is a nonzero constant. 1234 ConstantFP *CFPt, *CFPf; 1235 if (((CFPt = dyn_cast<ConstantFP>(TrueVal)) && 1236 !CFPt->getValueAPF().isZero()) || 1237 ((CFPf = dyn_cast<ConstantFP>(FalseVal)) && 1238 !CFPf->getValueAPF().isZero())) 1239 return replaceInstUsesWith(SI, FalseVal); 1240 } 1241 // Transform (X une Y) ? Y : X -> Y 1242 if (FCI->getPredicate() == FCmpInst::FCMP_UNE) { 1243 // This is not safe in general for floating point: 1244 // consider X== -0, Y== +0. 1245 // It becomes safe if either operand is a nonzero constant. 1246 ConstantFP *CFPt, *CFPf; 1247 if (((CFPt = dyn_cast<ConstantFP>(TrueVal)) && 1248 !CFPt->getValueAPF().isZero()) || 1249 ((CFPf = dyn_cast<ConstantFP>(FalseVal)) && 1250 !CFPf->getValueAPF().isZero())) 1251 return replaceInstUsesWith(SI, TrueVal); 1252 } 1253 1254 // Canonicalize to use ordered comparisons by swapping the select 1255 // operands. 1256 // 1257 // e.g. 1258 // (X ugt Y) ? X : Y -> (X ole Y) ? X : Y 1259 if (FCI->hasOneUse() && FCmpInst::isUnordered(FCI->getPredicate())) { 1260 FCmpInst::Predicate InvPred = FCI->getInversePredicate(); 1261 IRBuilder<>::FastMathFlagGuard FMFG(*Builder); 1262 Builder->setFastMathFlags(FCI->getFastMathFlags()); 1263 Value *NewCond = Builder->CreateFCmp(InvPred, FalseVal, TrueVal, 1264 FCI->getName() + ".inv"); 1265 1266 return SelectInst::Create(NewCond, FalseVal, TrueVal, 1267 SI.getName() + ".p"); 1268 } 1269 1270 // NOTE: if we wanted to, this is where to detect MIN/MAX 1271 } 1272 // NOTE: if we wanted to, this is where to detect ABS 1273 } 1274 1275 // See if we are selecting two values based on a comparison of the two values. 1276 if (ICmpInst *ICI = dyn_cast<ICmpInst>(CondVal)) 1277 if (Instruction *Result = foldSelectInstWithICmp(SI, ICI)) 1278 return Result; 1279 1280 if (Instruction *Add = foldAddSubSelect(SI, *Builder)) 1281 return Add; 1282 1283 // Turn (select C, (op X, Y), (op X, Z)) -> (op X, (select C, Y, Z)) 1284 auto *TI = dyn_cast<Instruction>(TrueVal); 1285 auto *FI = dyn_cast<Instruction>(FalseVal); 1286 if (TI && FI && TI->getOpcode() == FI->getOpcode()) 1287 if (Instruction *IV = foldSelectOpOp(SI, TI, FI)) 1288 return IV; 1289 1290 if (Instruction *I = foldSelectExtConst(SI)) 1291 return I; 1292 1293 // See if we can fold the select into one of our operands. 1294 if (SelType->isIntOrIntVectorTy() || SelType->isFPOrFPVectorTy()) { 1295 if (Instruction *FoldI = foldSelectIntoOp(SI, TrueVal, FalseVal)) 1296 return FoldI; 1297 1298 Value *LHS, *RHS, *LHS2, *RHS2; 1299 Instruction::CastOps CastOp; 1300 SelectPatternResult SPR = matchSelectPattern(&SI, LHS, RHS, &CastOp); 1301 auto SPF = SPR.Flavor; 1302 1303 if (SelectPatternResult::isMinOrMax(SPF)) { 1304 // Canonicalize so that type casts are outside select patterns. 1305 if (LHS->getType()->getPrimitiveSizeInBits() != 1306 SelType->getPrimitiveSizeInBits()) { 1307 CmpInst::Predicate Pred = getCmpPredicateForMinMax(SPF, SPR.Ordered); 1308 1309 Value *Cmp; 1310 if (CmpInst::isIntPredicate(Pred)) { 1311 Cmp = Builder->CreateICmp(Pred, LHS, RHS); 1312 } else { 1313 IRBuilder<>::FastMathFlagGuard FMFG(*Builder); 1314 auto FMF = cast<FPMathOperator>(SI.getCondition())->getFastMathFlags(); 1315 Builder->setFastMathFlags(FMF); 1316 Cmp = Builder->CreateFCmp(Pred, LHS, RHS); 1317 } 1318 1319 Value *NewSI = Builder->CreateCast( 1320 CastOp, Builder->CreateSelect(Cmp, LHS, RHS, SI.getName(), &SI), 1321 SelType); 1322 return replaceInstUsesWith(SI, NewSI); 1323 } 1324 } 1325 1326 if (SPF) { 1327 // MAX(MAX(a, b), a) -> MAX(a, b) 1328 // MIN(MIN(a, b), a) -> MIN(a, b) 1329 // MAX(MIN(a, b), a) -> a 1330 // MIN(MAX(a, b), a) -> a 1331 // ABS(ABS(a)) -> ABS(a) 1332 // NABS(NABS(a)) -> NABS(a) 1333 if (SelectPatternFlavor SPF2 = matchSelectPattern(LHS, LHS2, RHS2).Flavor) 1334 if (Instruction *R = foldSPFofSPF(cast<Instruction>(LHS),SPF2,LHS2,RHS2, 1335 SI, SPF, RHS)) 1336 return R; 1337 if (SelectPatternFlavor SPF2 = matchSelectPattern(RHS, LHS2, RHS2).Flavor) 1338 if (Instruction *R = foldSPFofSPF(cast<Instruction>(RHS),SPF2,LHS2,RHS2, 1339 SI, SPF, LHS)) 1340 return R; 1341 } 1342 1343 // MAX(~a, ~b) -> ~MIN(a, b) 1344 if ((SPF == SPF_SMAX || SPF == SPF_UMAX) && 1345 IsFreeToInvert(LHS, LHS->hasNUses(2)) && 1346 IsFreeToInvert(RHS, RHS->hasNUses(2))) { 1347 // For this transform to be profitable, we need to eliminate at least two 1348 // 'not' instructions if we're going to add one 'not' instruction. 1349 int NumberOfNots = 1350 (LHS->hasNUses(2) && match(LHS, m_Not(m_Value()))) + 1351 (RHS->hasNUses(2) && match(RHS, m_Not(m_Value()))) + 1352 (SI.hasOneUse() && match(*SI.user_begin(), m_Not(m_Value()))); 1353 1354 if (NumberOfNots >= 2) { 1355 Value *NewLHS = Builder->CreateNot(LHS); 1356 Value *NewRHS = Builder->CreateNot(RHS); 1357 Value *NewCmp = SPF == SPF_SMAX 1358 ? Builder->CreateICmpSLT(NewLHS, NewRHS) 1359 : Builder->CreateICmpULT(NewLHS, NewRHS); 1360 Value *NewSI = 1361 Builder->CreateNot(Builder->CreateSelect(NewCmp, NewLHS, NewRHS)); 1362 return replaceInstUsesWith(SI, NewSI); 1363 } 1364 } 1365 1366 // TODO. 1367 // ABS(-X) -> ABS(X) 1368 } 1369 1370 // See if we can fold the select into a phi node if the condition is a select. 1371 if (isa<PHINode>(SI.getCondition())) 1372 // The true/false values have to be live in the PHI predecessor's blocks. 1373 if (canSelectOperandBeMappingIntoPredBlock(TrueVal, SI) && 1374 canSelectOperandBeMappingIntoPredBlock(FalseVal, SI)) 1375 if (Instruction *NV = FoldOpIntoPhi(SI)) 1376 return NV; 1377 1378 if (SelectInst *TrueSI = dyn_cast<SelectInst>(TrueVal)) { 1379 if (TrueSI->getCondition()->getType() == CondVal->getType()) { 1380 // select(C, select(C, a, b), c) -> select(C, a, c) 1381 if (TrueSI->getCondition() == CondVal) { 1382 if (SI.getTrueValue() == TrueSI->getTrueValue()) 1383 return nullptr; 1384 SI.setOperand(1, TrueSI->getTrueValue()); 1385 return &SI; 1386 } 1387 // select(C0, select(C1, a, b), b) -> select(C0&C1, a, b) 1388 // We choose this as normal form to enable folding on the And and shortening 1389 // paths for the values (this helps GetUnderlyingObjects() for example). 1390 if (TrueSI->getFalseValue() == FalseVal && TrueSI->hasOneUse()) { 1391 Value *And = Builder->CreateAnd(CondVal, TrueSI->getCondition()); 1392 SI.setOperand(0, And); 1393 SI.setOperand(1, TrueSI->getTrueValue()); 1394 return &SI; 1395 } 1396 } 1397 } 1398 if (SelectInst *FalseSI = dyn_cast<SelectInst>(FalseVal)) { 1399 if (FalseSI->getCondition()->getType() == CondVal->getType()) { 1400 // select(C, a, select(C, b, c)) -> select(C, a, c) 1401 if (FalseSI->getCondition() == CondVal) { 1402 if (SI.getFalseValue() == FalseSI->getFalseValue()) 1403 return nullptr; 1404 SI.setOperand(2, FalseSI->getFalseValue()); 1405 return &SI; 1406 } 1407 // select(C0, a, select(C1, a, b)) -> select(C0|C1, a, b) 1408 if (FalseSI->getTrueValue() == TrueVal && FalseSI->hasOneUse()) { 1409 Value *Or = Builder->CreateOr(CondVal, FalseSI->getCondition()); 1410 SI.setOperand(0, Or); 1411 SI.setOperand(2, FalseSI->getFalseValue()); 1412 return &SI; 1413 } 1414 } 1415 } 1416 1417 if (BinaryOperator::isNot(CondVal)) { 1418 SI.setOperand(0, BinaryOperator::getNotArgument(CondVal)); 1419 SI.setOperand(1, FalseVal); 1420 SI.setOperand(2, TrueVal); 1421 return &SI; 1422 } 1423 1424 if (VectorType *VecTy = dyn_cast<VectorType>(SelType)) { 1425 unsigned VWidth = VecTy->getNumElements(); 1426 APInt UndefElts(VWidth, 0); 1427 APInt AllOnesEltMask(APInt::getAllOnesValue(VWidth)); 1428 if (Value *V = SimplifyDemandedVectorElts(&SI, AllOnesEltMask, UndefElts)) { 1429 if (V != &SI) 1430 return replaceInstUsesWith(SI, V); 1431 return &SI; 1432 } 1433 1434 if (isa<ConstantAggregateZero>(CondVal)) { 1435 return replaceInstUsesWith(SI, FalseVal); 1436 } 1437 } 1438 1439 // See if we can determine the result of this select based on a dominating 1440 // condition. 1441 BasicBlock *Parent = SI.getParent(); 1442 if (BasicBlock *Dom = Parent->getSinglePredecessor()) { 1443 auto *PBI = dyn_cast_or_null<BranchInst>(Dom->getTerminator()); 1444 if (PBI && PBI->isConditional() && 1445 PBI->getSuccessor(0) != PBI->getSuccessor(1) && 1446 (PBI->getSuccessor(0) == Parent || PBI->getSuccessor(1) == Parent)) { 1447 bool CondIsFalse = PBI->getSuccessor(1) == Parent; 1448 Optional<bool> Implication = isImpliedCondition( 1449 PBI->getCondition(), SI.getCondition(), DL, CondIsFalse); 1450 if (Implication) { 1451 Value *V = *Implication ? TrueVal : FalseVal; 1452 return replaceInstUsesWith(SI, V); 1453 } 1454 } 1455 } 1456 1457 if (Instruction *BitCastSel = foldSelectCmpBitcasts(SI, *Builder)) 1458 return BitCastSel; 1459 1460 return nullptr; 1461 } 1462