1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements the visitICmp and visitFCmp functions. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "InstCombineInternal.h" 15 #include "llvm/ADT/APSInt.h" 16 #include "llvm/ADT/SetVector.h" 17 #include "llvm/ADT/Statistic.h" 18 #include "llvm/Analysis/ConstantFolding.h" 19 #include "llvm/Analysis/InstructionSimplify.h" 20 #include "llvm/Analysis/MemoryBuiltins.h" 21 #include "llvm/Analysis/TargetLibraryInfo.h" 22 #include "llvm/Analysis/VectorUtils.h" 23 #include "llvm/IR/ConstantRange.h" 24 #include "llvm/IR/DataLayout.h" 25 #include "llvm/IR/GetElementPtrTypeIterator.h" 26 #include "llvm/IR/IntrinsicInst.h" 27 #include "llvm/IR/PatternMatch.h" 28 #include "llvm/Support/Debug.h" 29 #include "llvm/Support/KnownBits.h" 30 31 using namespace llvm; 32 using namespace PatternMatch; 33 34 #define DEBUG_TYPE "instcombine" 35 36 // How many times is a select replaced by one of its operands? 37 STATISTIC(NumSel, "Number of select opts"); 38 39 40 /// Compute Result = In1+In2, returning true if the result overflowed for this 41 /// type. 42 static bool addWithOverflow(APInt &Result, const APInt &In1, 43 const APInt &In2, bool IsSigned = false) { 44 bool Overflow; 45 if (IsSigned) 46 Result = In1.sadd_ov(In2, Overflow); 47 else 48 Result = In1.uadd_ov(In2, Overflow); 49 50 return Overflow; 51 } 52 53 /// Compute Result = In1-In2, returning true if the result overflowed for this 54 /// type. 55 static bool subWithOverflow(APInt &Result, const APInt &In1, 56 const APInt &In2, bool IsSigned = false) { 57 bool Overflow; 58 if (IsSigned) 59 Result = In1.ssub_ov(In2, Overflow); 60 else 61 Result = In1.usub_ov(In2, Overflow); 62 63 return Overflow; 64 } 65 66 /// Given an icmp instruction, return true if any use of this comparison is a 67 /// branch on sign bit comparison. 68 static bool hasBranchUse(ICmpInst &I) { 69 for (auto *U : I.users()) 70 if (isa<BranchInst>(U)) 71 return true; 72 return false; 73 } 74 75 /// Given an exploded icmp instruction, return true if the comparison only 76 /// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the 77 /// result of the comparison is true when the input value is signed. 78 static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS, 79 bool &TrueIfSigned) { 80 switch (Pred) { 81 case ICmpInst::ICMP_SLT: // True if LHS s< 0 82 TrueIfSigned = true; 83 return RHS.isNullValue(); 84 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1 85 TrueIfSigned = true; 86 return RHS.isAllOnesValue(); 87 case ICmpInst::ICMP_SGT: // True if LHS s> -1 88 TrueIfSigned = false; 89 return RHS.isAllOnesValue(); 90 case ICmpInst::ICMP_UGT: 91 // True if LHS u> RHS and RHS == high-bit-mask - 1 92 TrueIfSigned = true; 93 return RHS.isMaxSignedValue(); 94 case ICmpInst::ICMP_UGE: 95 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc) 96 TrueIfSigned = true; 97 return RHS.isSignMask(); 98 default: 99 return false; 100 } 101 } 102 103 /// Returns true if the exploded icmp can be expressed as a signed comparison 104 /// to zero and updates the predicate accordingly. 105 /// The signedness of the comparison is preserved. 106 /// TODO: Refactor with decomposeBitTestICmp()? 107 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 108 if (!ICmpInst::isSigned(Pred)) 109 return false; 110 111 if (C.isNullValue()) 112 return ICmpInst::isRelational(Pred); 113 114 if (C.isOneValue()) { 115 if (Pred == ICmpInst::ICMP_SLT) { 116 Pred = ICmpInst::ICMP_SLE; 117 return true; 118 } 119 } else if (C.isAllOnesValue()) { 120 if (Pred == ICmpInst::ICMP_SGT) { 121 Pred = ICmpInst::ICMP_SGE; 122 return true; 123 } 124 } 125 126 return false; 127 } 128 129 /// Given a signed integer type and a set of known zero and one bits, compute 130 /// the maximum and minimum values that could have the specified known zero and 131 /// known one bits, returning them in Min/Max. 132 /// TODO: Move to method on KnownBits struct? 133 static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known, 134 APInt &Min, APInt &Max) { 135 assert(Known.getBitWidth() == Min.getBitWidth() && 136 Known.getBitWidth() == Max.getBitWidth() && 137 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 138 APInt UnknownBits = ~(Known.Zero|Known.One); 139 140 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 141 // bit if it is unknown. 142 Min = Known.One; 143 Max = Known.One|UnknownBits; 144 145 if (UnknownBits.isNegative()) { // Sign bit is unknown 146 Min.setSignBit(); 147 Max.clearSignBit(); 148 } 149 } 150 151 /// Given an unsigned integer type and a set of known zero and one bits, compute 152 /// the maximum and minimum values that could have the specified known zero and 153 /// known one bits, returning them in Min/Max. 154 /// TODO: Move to method on KnownBits struct? 155 static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known, 156 APInt &Min, APInt &Max) { 157 assert(Known.getBitWidth() == Min.getBitWidth() && 158 Known.getBitWidth() == Max.getBitWidth() && 159 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 160 APInt UnknownBits = ~(Known.Zero|Known.One); 161 162 // The minimum value is when the unknown bits are all zeros. 163 Min = Known.One; 164 // The maximum value is when the unknown bits are all ones. 165 Max = Known.One|UnknownBits; 166 } 167 168 /// This is called when we see this pattern: 169 /// cmp pred (load (gep GV, ...)), cmpcst 170 /// where GV is a global variable with a constant initializer. Try to simplify 171 /// this into some simple computation that does not need the load. For example 172 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 173 /// 174 /// If AndCst is non-null, then the loaded value is masked with that constant 175 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 176 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 177 GlobalVariable *GV, 178 CmpInst &ICI, 179 ConstantInt *AndCst) { 180 Constant *Init = GV->getInitializer(); 181 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 182 return nullptr; 183 184 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 185 // Don't blow up on huge arrays. 186 if (ArrayElementCount > MaxArraySizeForCombine) 187 return nullptr; 188 189 // There are many forms of this optimization we can handle, for now, just do 190 // the simple index into a single-dimensional array. 191 // 192 // Require: GEP GV, 0, i {{, constant indices}} 193 if (GEP->getNumOperands() < 3 || 194 !isa<ConstantInt>(GEP->getOperand(1)) || 195 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 196 isa<Constant>(GEP->getOperand(2))) 197 return nullptr; 198 199 // Check that indices after the variable are constants and in-range for the 200 // type they index. Collect the indices. This is typically for arrays of 201 // structs. 202 SmallVector<unsigned, 4> LaterIndices; 203 204 Type *EltTy = Init->getType()->getArrayElementType(); 205 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 206 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 207 if (!Idx) return nullptr; // Variable index. 208 209 uint64_t IdxVal = Idx->getZExtValue(); 210 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 211 212 if (StructType *STy = dyn_cast<StructType>(EltTy)) 213 EltTy = STy->getElementType(IdxVal); 214 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 215 if (IdxVal >= ATy->getNumElements()) return nullptr; 216 EltTy = ATy->getElementType(); 217 } else { 218 return nullptr; // Unknown type. 219 } 220 221 LaterIndices.push_back(IdxVal); 222 } 223 224 enum { Overdefined = -3, Undefined = -2 }; 225 226 // Variables for our state machines. 227 228 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 229 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 230 // and 87 is the second (and last) index. FirstTrueElement is -2 when 231 // undefined, otherwise set to the first true element. SecondTrueElement is 232 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 233 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 234 235 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 236 // form "i != 47 & i != 87". Same state transitions as for true elements. 237 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 238 239 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 240 /// define a state machine that triggers for ranges of values that the index 241 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 242 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 243 /// index in the range (inclusive). We use -2 for undefined here because we 244 /// use relative comparisons and don't want 0-1 to match -1. 245 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 246 247 // MagicBitvector - This is a magic bitvector where we set a bit if the 248 // comparison is true for element 'i'. If there are 64 elements or less in 249 // the array, this will fully represent all the comparison results. 250 uint64_t MagicBitvector = 0; 251 252 // Scan the array and see if one of our patterns matches. 253 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 254 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 255 Constant *Elt = Init->getAggregateElement(i); 256 if (!Elt) return nullptr; 257 258 // If this is indexing an array of structures, get the structure element. 259 if (!LaterIndices.empty()) 260 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 261 262 // If the element is masked, handle it. 263 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 264 265 // Find out if the comparison would be true or false for the i'th element. 266 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 267 CompareRHS, DL, &TLI); 268 // If the result is undef for this element, ignore it. 269 if (isa<UndefValue>(C)) { 270 // Extend range state machines to cover this element in case there is an 271 // undef in the middle of the range. 272 if (TrueRangeEnd == (int)i-1) 273 TrueRangeEnd = i; 274 if (FalseRangeEnd == (int)i-1) 275 FalseRangeEnd = i; 276 continue; 277 } 278 279 // If we can't compute the result for any of the elements, we have to give 280 // up evaluating the entire conditional. 281 if (!isa<ConstantInt>(C)) return nullptr; 282 283 // Otherwise, we know if the comparison is true or false for this element, 284 // update our state machines. 285 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 286 287 // State machine for single/double/range index comparison. 288 if (IsTrueForElt) { 289 // Update the TrueElement state machine. 290 if (FirstTrueElement == Undefined) 291 FirstTrueElement = TrueRangeEnd = i; // First true element. 292 else { 293 // Update double-compare state machine. 294 if (SecondTrueElement == Undefined) 295 SecondTrueElement = i; 296 else 297 SecondTrueElement = Overdefined; 298 299 // Update range state machine. 300 if (TrueRangeEnd == (int)i-1) 301 TrueRangeEnd = i; 302 else 303 TrueRangeEnd = Overdefined; 304 } 305 } else { 306 // Update the FalseElement state machine. 307 if (FirstFalseElement == Undefined) 308 FirstFalseElement = FalseRangeEnd = i; // First false element. 309 else { 310 // Update double-compare state machine. 311 if (SecondFalseElement == Undefined) 312 SecondFalseElement = i; 313 else 314 SecondFalseElement = Overdefined; 315 316 // Update range state machine. 317 if (FalseRangeEnd == (int)i-1) 318 FalseRangeEnd = i; 319 else 320 FalseRangeEnd = Overdefined; 321 } 322 } 323 324 // If this element is in range, update our magic bitvector. 325 if (i < 64 && IsTrueForElt) 326 MagicBitvector |= 1ULL << i; 327 328 // If all of our states become overdefined, bail out early. Since the 329 // predicate is expensive, only check it every 8 elements. This is only 330 // really useful for really huge arrays. 331 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 332 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 333 FalseRangeEnd == Overdefined) 334 return nullptr; 335 } 336 337 // Now that we've scanned the entire array, emit our new comparison(s). We 338 // order the state machines in complexity of the generated code. 339 Value *Idx = GEP->getOperand(2); 340 341 // If the index is larger than the pointer size of the target, truncate the 342 // index down like the GEP would do implicitly. We don't have to do this for 343 // an inbounds GEP because the index can't be out of range. 344 if (!GEP->isInBounds()) { 345 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 346 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 347 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 348 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 349 } 350 351 // If the comparison is only true for one or two elements, emit direct 352 // comparisons. 353 if (SecondTrueElement != Overdefined) { 354 // None true -> false. 355 if (FirstTrueElement == Undefined) 356 return replaceInstUsesWith(ICI, Builder.getFalse()); 357 358 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 359 360 // True for one element -> 'i == 47'. 361 if (SecondTrueElement == Undefined) 362 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 363 364 // True for two elements -> 'i == 47 | i == 72'. 365 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 366 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 367 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 368 return BinaryOperator::CreateOr(C1, C2); 369 } 370 371 // If the comparison is only false for one or two elements, emit direct 372 // comparisons. 373 if (SecondFalseElement != Overdefined) { 374 // None false -> true. 375 if (FirstFalseElement == Undefined) 376 return replaceInstUsesWith(ICI, Builder.getTrue()); 377 378 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 379 380 // False for one element -> 'i != 47'. 381 if (SecondFalseElement == Undefined) 382 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 383 384 // False for two elements -> 'i != 47 & i != 72'. 385 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 386 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 387 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 388 return BinaryOperator::CreateAnd(C1, C2); 389 } 390 391 // If the comparison can be replaced with a range comparison for the elements 392 // where it is true, emit the range check. 393 if (TrueRangeEnd != Overdefined) { 394 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 395 396 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 397 if (FirstTrueElement) { 398 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 399 Idx = Builder.CreateAdd(Idx, Offs); 400 } 401 402 Value *End = ConstantInt::get(Idx->getType(), 403 TrueRangeEnd-FirstTrueElement+1); 404 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 405 } 406 407 // False range check. 408 if (FalseRangeEnd != Overdefined) { 409 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 410 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 411 if (FirstFalseElement) { 412 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 413 Idx = Builder.CreateAdd(Idx, Offs); 414 } 415 416 Value *End = ConstantInt::get(Idx->getType(), 417 FalseRangeEnd-FirstFalseElement); 418 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 419 } 420 421 // If a magic bitvector captures the entire comparison state 422 // of this load, replace it with computation that does: 423 // ((magic_cst >> i) & 1) != 0 424 { 425 Type *Ty = nullptr; 426 427 // Look for an appropriate type: 428 // - The type of Idx if the magic fits 429 // - The smallest fitting legal type if we have a DataLayout 430 // - Default to i32 431 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 432 Ty = Idx->getType(); 433 else 434 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 435 436 if (Ty) { 437 Value *V = Builder.CreateIntCast(Idx, Ty, false); 438 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 439 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 440 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 441 } 442 } 443 444 return nullptr; 445 } 446 447 /// Return a value that can be used to compare the *offset* implied by a GEP to 448 /// zero. For example, if we have &A[i], we want to return 'i' for 449 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 450 /// are involved. The above expression would also be legal to codegen as 451 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 452 /// This latter form is less amenable to optimization though, and we are allowed 453 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 454 /// 455 /// If we can't emit an optimized form for this expression, this returns null. 456 /// 457 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 458 const DataLayout &DL) { 459 gep_type_iterator GTI = gep_type_begin(GEP); 460 461 // Check to see if this gep only has a single variable index. If so, and if 462 // any constant indices are a multiple of its scale, then we can compute this 463 // in terms of the scale of the variable index. For example, if the GEP 464 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 465 // because the expression will cross zero at the same point. 466 unsigned i, e = GEP->getNumOperands(); 467 int64_t Offset = 0; 468 for (i = 1; i != e; ++i, ++GTI) { 469 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 470 // Compute the aggregate offset of constant indices. 471 if (CI->isZero()) continue; 472 473 // Handle a struct index, which adds its field offset to the pointer. 474 if (StructType *STy = GTI.getStructTypeOrNull()) { 475 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 476 } else { 477 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 478 Offset += Size*CI->getSExtValue(); 479 } 480 } else { 481 // Found our variable index. 482 break; 483 } 484 } 485 486 // If there are no variable indices, we must have a constant offset, just 487 // evaluate it the general way. 488 if (i == e) return nullptr; 489 490 Value *VariableIdx = GEP->getOperand(i); 491 // Determine the scale factor of the variable element. For example, this is 492 // 4 if the variable index is into an array of i32. 493 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 494 495 // Verify that there are no other variable indices. If so, emit the hard way. 496 for (++i, ++GTI; i != e; ++i, ++GTI) { 497 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 498 if (!CI) return nullptr; 499 500 // Compute the aggregate offset of constant indices. 501 if (CI->isZero()) continue; 502 503 // Handle a struct index, which adds its field offset to the pointer. 504 if (StructType *STy = GTI.getStructTypeOrNull()) { 505 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 506 } else { 507 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 508 Offset += Size*CI->getSExtValue(); 509 } 510 } 511 512 // Okay, we know we have a single variable index, which must be a 513 // pointer/array/vector index. If there is no offset, life is simple, return 514 // the index. 515 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 516 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 517 if (Offset == 0) { 518 // Cast to intptrty in case a truncation occurs. If an extension is needed, 519 // we don't need to bother extending: the extension won't affect where the 520 // computation crosses zero. 521 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 522 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 523 } 524 return VariableIdx; 525 } 526 527 // Otherwise, there is an index. The computation we will do will be modulo 528 // the pointer size, so get it. 529 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth); 530 531 Offset &= PtrSizeMask; 532 VariableScale &= PtrSizeMask; 533 534 // To do this transformation, any constant index must be a multiple of the 535 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 536 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 537 // multiple of the variable scale. 538 int64_t NewOffs = Offset / (int64_t)VariableScale; 539 if (Offset != NewOffs*(int64_t)VariableScale) 540 return nullptr; 541 542 // Okay, we can do this evaluation. Start by converting the index to intptr. 543 if (VariableIdx->getType() != IntPtrTy) 544 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 545 true /*Signed*/); 546 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 547 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 548 } 549 550 /// Returns true if we can rewrite Start as a GEP with pointer Base 551 /// and some integer offset. The nodes that need to be re-written 552 /// for this transformation will be added to Explored. 553 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 554 const DataLayout &DL, 555 SetVector<Value *> &Explored) { 556 SmallVector<Value *, 16> WorkList(1, Start); 557 Explored.insert(Base); 558 559 // The following traversal gives us an order which can be used 560 // when doing the final transformation. Since in the final 561 // transformation we create the PHI replacement instructions first, 562 // we don't have to get them in any particular order. 563 // 564 // However, for other instructions we will have to traverse the 565 // operands of an instruction first, which means that we have to 566 // do a post-order traversal. 567 while (!WorkList.empty()) { 568 SetVector<PHINode *> PHIs; 569 570 while (!WorkList.empty()) { 571 if (Explored.size() >= 100) 572 return false; 573 574 Value *V = WorkList.back(); 575 576 if (Explored.count(V) != 0) { 577 WorkList.pop_back(); 578 continue; 579 } 580 581 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 582 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 583 // We've found some value that we can't explore which is different from 584 // the base. Therefore we can't do this transformation. 585 return false; 586 587 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 588 auto *CI = dyn_cast<CastInst>(V); 589 if (!CI->isNoopCast(DL)) 590 return false; 591 592 if (Explored.count(CI->getOperand(0)) == 0) 593 WorkList.push_back(CI->getOperand(0)); 594 } 595 596 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 597 // We're limiting the GEP to having one index. This will preserve 598 // the original pointer type. We could handle more cases in the 599 // future. 600 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 601 GEP->getType() != Start->getType()) 602 return false; 603 604 if (Explored.count(GEP->getOperand(0)) == 0) 605 WorkList.push_back(GEP->getOperand(0)); 606 } 607 608 if (WorkList.back() == V) { 609 WorkList.pop_back(); 610 // We've finished visiting this node, mark it as such. 611 Explored.insert(V); 612 } 613 614 if (auto *PN = dyn_cast<PHINode>(V)) { 615 // We cannot transform PHIs on unsplittable basic blocks. 616 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 617 return false; 618 Explored.insert(PN); 619 PHIs.insert(PN); 620 } 621 } 622 623 // Explore the PHI nodes further. 624 for (auto *PN : PHIs) 625 for (Value *Op : PN->incoming_values()) 626 if (Explored.count(Op) == 0) 627 WorkList.push_back(Op); 628 } 629 630 // Make sure that we can do this. Since we can't insert GEPs in a basic 631 // block before a PHI node, we can't easily do this transformation if 632 // we have PHI node users of transformed instructions. 633 for (Value *Val : Explored) { 634 for (Value *Use : Val->uses()) { 635 636 auto *PHI = dyn_cast<PHINode>(Use); 637 auto *Inst = dyn_cast<Instruction>(Val); 638 639 if (Inst == Base || Inst == PHI || !Inst || !PHI || 640 Explored.count(PHI) == 0) 641 continue; 642 643 if (PHI->getParent() == Inst->getParent()) 644 return false; 645 } 646 } 647 return true; 648 } 649 650 // Sets the appropriate insert point on Builder where we can add 651 // a replacement Instruction for V (if that is possible). 652 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 653 bool Before = true) { 654 if (auto *PHI = dyn_cast<PHINode>(V)) { 655 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 656 return; 657 } 658 if (auto *I = dyn_cast<Instruction>(V)) { 659 if (!Before) 660 I = &*std::next(I->getIterator()); 661 Builder.SetInsertPoint(I); 662 return; 663 } 664 if (auto *A = dyn_cast<Argument>(V)) { 665 // Set the insertion point in the entry block. 666 BasicBlock &Entry = A->getParent()->getEntryBlock(); 667 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 668 return; 669 } 670 // Otherwise, this is a constant and we don't need to set a new 671 // insertion point. 672 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 673 } 674 675 /// Returns a re-written value of Start as an indexed GEP using Base as a 676 /// pointer. 677 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 678 const DataLayout &DL, 679 SetVector<Value *> &Explored) { 680 // Perform all the substitutions. This is a bit tricky because we can 681 // have cycles in our use-def chains. 682 // 1. Create the PHI nodes without any incoming values. 683 // 2. Create all the other values. 684 // 3. Add the edges for the PHI nodes. 685 // 4. Emit GEPs to get the original pointers. 686 // 5. Remove the original instructions. 687 Type *IndexType = IntegerType::get( 688 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType())); 689 690 DenseMap<Value *, Value *> NewInsts; 691 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 692 693 // Create the new PHI nodes, without adding any incoming values. 694 for (Value *Val : Explored) { 695 if (Val == Base) 696 continue; 697 // Create empty phi nodes. This avoids cyclic dependencies when creating 698 // the remaining instructions. 699 if (auto *PHI = dyn_cast<PHINode>(Val)) 700 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 701 PHI->getName() + ".idx", PHI); 702 } 703 IRBuilder<> Builder(Base->getContext()); 704 705 // Create all the other instructions. 706 for (Value *Val : Explored) { 707 708 if (NewInsts.find(Val) != NewInsts.end()) 709 continue; 710 711 if (auto *CI = dyn_cast<CastInst>(Val)) { 712 NewInsts[CI] = NewInsts[CI->getOperand(0)]; 713 continue; 714 } 715 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 716 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 717 : GEP->getOperand(1); 718 setInsertionPoint(Builder, GEP); 719 // Indices might need to be sign extended. GEPs will magically do 720 // this, but we need to do it ourselves here. 721 if (Index->getType()->getScalarSizeInBits() != 722 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 723 Index = Builder.CreateSExtOrTrunc( 724 Index, NewInsts[GEP->getOperand(0)]->getType(), 725 GEP->getOperand(0)->getName() + ".sext"); 726 } 727 728 auto *Op = NewInsts[GEP->getOperand(0)]; 729 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero()) 730 NewInsts[GEP] = Index; 731 else 732 NewInsts[GEP] = Builder.CreateNSWAdd( 733 Op, Index, GEP->getOperand(0)->getName() + ".add"); 734 continue; 735 } 736 if (isa<PHINode>(Val)) 737 continue; 738 739 llvm_unreachable("Unexpected instruction type"); 740 } 741 742 // Add the incoming values to the PHI nodes. 743 for (Value *Val : Explored) { 744 if (Val == Base) 745 continue; 746 // All the instructions have been created, we can now add edges to the 747 // phi nodes. 748 if (auto *PHI = dyn_cast<PHINode>(Val)) { 749 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 750 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 751 Value *NewIncoming = PHI->getIncomingValue(I); 752 753 if (NewInsts.find(NewIncoming) != NewInsts.end()) 754 NewIncoming = NewInsts[NewIncoming]; 755 756 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 757 } 758 } 759 } 760 761 for (Value *Val : Explored) { 762 if (Val == Base) 763 continue; 764 765 // Depending on the type, for external users we have to emit 766 // a GEP or a GEP + ptrtoint. 767 setInsertionPoint(Builder, Val, false); 768 769 // If required, create an inttoptr instruction for Base. 770 Value *NewBase = Base; 771 if (!Base->getType()->isPointerTy()) 772 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 773 Start->getName() + "to.ptr"); 774 775 Value *GEP = Builder.CreateInBoundsGEP( 776 Start->getType()->getPointerElementType(), NewBase, 777 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 778 779 if (!Val->getType()->isPointerTy()) { 780 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 781 Val->getName() + ".conv"); 782 GEP = Cast; 783 } 784 Val->replaceAllUsesWith(GEP); 785 } 786 787 return NewInsts[Start]; 788 } 789 790 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 791 /// the input Value as a constant indexed GEP. Returns a pair containing 792 /// the GEPs Pointer and Index. 793 static std::pair<Value *, Value *> 794 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 795 Type *IndexType = IntegerType::get(V->getContext(), 796 DL.getPointerTypeSizeInBits(V->getType())); 797 798 Constant *Index = ConstantInt::getNullValue(IndexType); 799 while (true) { 800 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 801 // We accept only inbouds GEPs here to exclude the possibility of 802 // overflow. 803 if (!GEP->isInBounds()) 804 break; 805 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 806 GEP->getType() == V->getType()) { 807 V = GEP->getOperand(0); 808 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 809 Index = ConstantExpr::getAdd( 810 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 811 continue; 812 } 813 break; 814 } 815 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 816 if (!CI->isNoopCast(DL)) 817 break; 818 V = CI->getOperand(0); 819 continue; 820 } 821 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 822 if (!CI->isNoopCast(DL)) 823 break; 824 V = CI->getOperand(0); 825 continue; 826 } 827 break; 828 } 829 return {V, Index}; 830 } 831 832 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 833 /// We can look through PHIs, GEPs and casts in order to determine a common base 834 /// between GEPLHS and RHS. 835 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 836 ICmpInst::Predicate Cond, 837 const DataLayout &DL) { 838 if (!GEPLHS->hasAllConstantIndices()) 839 return nullptr; 840 841 // Make sure the pointers have the same type. 842 if (GEPLHS->getType() != RHS->getType()) 843 return nullptr; 844 845 Value *PtrBase, *Index; 846 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 847 848 // The set of nodes that will take part in this transformation. 849 SetVector<Value *> Nodes; 850 851 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 852 return nullptr; 853 854 // We know we can re-write this as 855 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 856 // Since we've only looked through inbouds GEPs we know that we 857 // can't have overflow on either side. We can therefore re-write 858 // this as: 859 // OFFSET1 cmp OFFSET2 860 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 861 862 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 863 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 864 // offset. Since Index is the offset of LHS to the base pointer, we will now 865 // compare the offsets instead of comparing the pointers. 866 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 867 } 868 869 /// Fold comparisons between a GEP instruction and something else. At this point 870 /// we know that the GEP is on the LHS of the comparison. 871 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 872 ICmpInst::Predicate Cond, 873 Instruction &I) { 874 // Don't transform signed compares of GEPs into index compares. Even if the 875 // GEP is inbounds, the final add of the base pointer can have signed overflow 876 // and would change the result of the icmp. 877 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 878 // the maximum signed value for the pointer type. 879 if (ICmpInst::isSigned(Cond)) 880 return nullptr; 881 882 // Look through bitcasts and addrspacecasts. We do not however want to remove 883 // 0 GEPs. 884 if (!isa<GetElementPtrInst>(RHS)) 885 RHS = RHS->stripPointerCasts(); 886 887 Value *PtrBase = GEPLHS->getOperand(0); 888 if (PtrBase == RHS && GEPLHS->isInBounds()) { 889 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 890 // This transformation (ignoring the base and scales) is valid because we 891 // know pointers can't overflow since the gep is inbounds. See if we can 892 // output an optimized form. 893 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 894 895 // If not, synthesize the offset the hard way. 896 if (!Offset) 897 Offset = EmitGEPOffset(GEPLHS); 898 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 899 Constant::getNullValue(Offset->getType())); 900 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 901 // If the base pointers are different, but the indices are the same, just 902 // compare the base pointer. 903 if (PtrBase != GEPRHS->getOperand(0)) { 904 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 905 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 906 GEPRHS->getOperand(0)->getType(); 907 if (IndicesTheSame) 908 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 909 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 910 IndicesTheSame = false; 911 break; 912 } 913 914 // If all indices are the same, just compare the base pointers. 915 if (IndicesTheSame) 916 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 917 918 // If we're comparing GEPs with two base pointers that only differ in type 919 // and both GEPs have only constant indices or just one use, then fold 920 // the compare with the adjusted indices. 921 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 922 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 923 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 924 PtrBase->stripPointerCasts() == 925 GEPRHS->getOperand(0)->stripPointerCasts()) { 926 Value *LOffset = EmitGEPOffset(GEPLHS); 927 Value *ROffset = EmitGEPOffset(GEPRHS); 928 929 // If we looked through an addrspacecast between different sized address 930 // spaces, the LHS and RHS pointers are different sized 931 // integers. Truncate to the smaller one. 932 Type *LHSIndexTy = LOffset->getType(); 933 Type *RHSIndexTy = ROffset->getType(); 934 if (LHSIndexTy != RHSIndexTy) { 935 if (LHSIndexTy->getPrimitiveSizeInBits() < 936 RHSIndexTy->getPrimitiveSizeInBits()) { 937 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 938 } else 939 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 940 } 941 942 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 943 LOffset, ROffset); 944 return replaceInstUsesWith(I, Cmp); 945 } 946 947 // Otherwise, the base pointers are different and the indices are 948 // different. Try convert this to an indexed compare by looking through 949 // PHIs/casts. 950 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 951 } 952 953 // If one of the GEPs has all zero indices, recurse. 954 if (GEPLHS->hasAllZeroIndices()) 955 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 956 ICmpInst::getSwappedPredicate(Cond), I); 957 958 // If the other GEP has all zero indices, recurse. 959 if (GEPRHS->hasAllZeroIndices()) 960 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 961 962 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 963 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 964 // If the GEPs only differ by one index, compare it. 965 unsigned NumDifferences = 0; // Keep track of # differences. 966 unsigned DiffOperand = 0; // The operand that differs. 967 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 968 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 969 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() != 970 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) { 971 // Irreconcilable differences. 972 NumDifferences = 2; 973 break; 974 } else { 975 if (NumDifferences++) break; 976 DiffOperand = i; 977 } 978 } 979 980 if (NumDifferences == 0) // SAME GEP? 981 return replaceInstUsesWith(I, // No comparison is needed here. 982 Builder.getInt1(ICmpInst::isTrueWhenEqual(Cond))); 983 984 else if (NumDifferences == 1 && GEPsInBounds) { 985 Value *LHSV = GEPLHS->getOperand(DiffOperand); 986 Value *RHSV = GEPRHS->getOperand(DiffOperand); 987 // Make sure we do a signed comparison here. 988 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 989 } 990 } 991 992 // Only lower this if the icmp is the only user of the GEP or if we expect 993 // the result to fold to a constant! 994 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 995 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 996 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 997 Value *L = EmitGEPOffset(GEPLHS); 998 Value *R = EmitGEPOffset(GEPRHS); 999 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1000 } 1001 } 1002 1003 // Try convert this to an indexed compare by looking through PHIs/casts as a 1004 // last resort. 1005 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1006 } 1007 1008 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1009 const AllocaInst *Alloca, 1010 const Value *Other) { 1011 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1012 1013 // It would be tempting to fold away comparisons between allocas and any 1014 // pointer not based on that alloca (e.g. an argument). However, even 1015 // though such pointers cannot alias, they can still compare equal. 1016 // 1017 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1018 // doesn't escape we can argue that it's impossible to guess its value, and we 1019 // can therefore act as if any such guesses are wrong. 1020 // 1021 // The code below checks that the alloca doesn't escape, and that it's only 1022 // used in a comparison once (the current instruction). The 1023 // single-comparison-use condition ensures that we're trivially folding all 1024 // comparisons against the alloca consistently, and avoids the risk of 1025 // erroneously folding a comparison of the pointer with itself. 1026 1027 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1028 1029 SmallVector<const Use *, 32> Worklist; 1030 for (const Use &U : Alloca->uses()) { 1031 if (Worklist.size() >= MaxIter) 1032 return nullptr; 1033 Worklist.push_back(&U); 1034 } 1035 1036 unsigned NumCmps = 0; 1037 while (!Worklist.empty()) { 1038 assert(Worklist.size() <= MaxIter); 1039 const Use *U = Worklist.pop_back_val(); 1040 const Value *V = U->getUser(); 1041 --MaxIter; 1042 1043 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1044 isa<SelectInst>(V)) { 1045 // Track the uses. 1046 } else if (isa<LoadInst>(V)) { 1047 // Loading from the pointer doesn't escape it. 1048 continue; 1049 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1050 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1051 if (SI->getValueOperand() == U->get()) 1052 return nullptr; 1053 continue; 1054 } else if (isa<ICmpInst>(V)) { 1055 if (NumCmps++) 1056 return nullptr; // Found more than one cmp. 1057 continue; 1058 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1059 switch (Intrin->getIntrinsicID()) { 1060 // These intrinsics don't escape or compare the pointer. Memset is safe 1061 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1062 // we don't allow stores, so src cannot point to V. 1063 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1064 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1065 continue; 1066 default: 1067 return nullptr; 1068 } 1069 } else { 1070 return nullptr; 1071 } 1072 for (const Use &U : V->uses()) { 1073 if (Worklist.size() >= MaxIter) 1074 return nullptr; 1075 Worklist.push_back(&U); 1076 } 1077 } 1078 1079 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1080 return replaceInstUsesWith( 1081 ICI, 1082 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1083 } 1084 1085 /// Fold "icmp pred (X+CI), X". 1086 Instruction *InstCombiner::foldICmpAddOpConst(Value *X, ConstantInt *CI, 1087 ICmpInst::Predicate Pred) { 1088 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1089 // so the values can never be equal. Similarly for all other "or equals" 1090 // operators. 1091 1092 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1093 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1094 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1095 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1096 Value *R = 1097 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI); 1098 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1099 } 1100 1101 // (X+1) >u X --> X <u (0-1) --> X != 255 1102 // (X+2) >u X --> X <u (0-2) --> X <u 254 1103 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1104 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1105 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI)); 1106 1107 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits(); 1108 ConstantInt *SMax = ConstantInt::get(X->getContext(), 1109 APInt::getSignedMaxValue(BitWidth)); 1110 1111 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1112 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1113 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1114 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1115 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1116 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1117 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1118 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI)); 1119 1120 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1121 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1122 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1123 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1124 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1125 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1126 1127 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1128 Constant *C = Builder.getInt(CI->getValue() - 1); 1129 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C)); 1130 } 1131 1132 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1133 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1134 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1135 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1136 const APInt &AP1, 1137 const APInt &AP2) { 1138 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1139 1140 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1141 if (I.getPredicate() == I.ICMP_NE) 1142 Pred = CmpInst::getInversePredicate(Pred); 1143 return new ICmpInst(Pred, LHS, RHS); 1144 }; 1145 1146 // Don't bother doing any work for cases which InstSimplify handles. 1147 if (AP2.isNullValue()) 1148 return nullptr; 1149 1150 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1151 if (IsAShr) { 1152 if (AP2.isAllOnesValue()) 1153 return nullptr; 1154 if (AP2.isNegative() != AP1.isNegative()) 1155 return nullptr; 1156 if (AP2.sgt(AP1)) 1157 return nullptr; 1158 } 1159 1160 if (!AP1) 1161 // 'A' must be large enough to shift out the highest set bit. 1162 return getICmp(I.ICMP_UGT, A, 1163 ConstantInt::get(A->getType(), AP2.logBase2())); 1164 1165 if (AP1 == AP2) 1166 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1167 1168 int Shift; 1169 if (IsAShr && AP1.isNegative()) 1170 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1171 else 1172 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1173 1174 if (Shift > 0) { 1175 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1176 // There are multiple solutions if we are comparing against -1 and the LHS 1177 // of the ashr is not a power of two. 1178 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1179 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1180 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1181 } else if (AP1 == AP2.lshr(Shift)) { 1182 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1183 } 1184 } 1185 1186 // Shifting const2 will never be equal to const1. 1187 // FIXME: This should always be handled by InstSimplify? 1188 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1189 return replaceInstUsesWith(I, TorF); 1190 } 1191 1192 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1193 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1194 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1195 const APInt &AP1, 1196 const APInt &AP2) { 1197 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1198 1199 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1200 if (I.getPredicate() == I.ICMP_NE) 1201 Pred = CmpInst::getInversePredicate(Pred); 1202 return new ICmpInst(Pred, LHS, RHS); 1203 }; 1204 1205 // Don't bother doing any work for cases which InstSimplify handles. 1206 if (AP2.isNullValue()) 1207 return nullptr; 1208 1209 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1210 1211 if (!AP1 && AP2TrailingZeros != 0) 1212 return getICmp( 1213 I.ICMP_UGE, A, 1214 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1215 1216 if (AP1 == AP2) 1217 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1218 1219 // Get the distance between the lowest bits that are set. 1220 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1221 1222 if (Shift > 0 && AP2.shl(Shift) == AP1) 1223 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1224 1225 // Shifting const2 will never be equal to const1. 1226 // FIXME: This should always be handled by InstSimplify? 1227 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1228 return replaceInstUsesWith(I, TorF); 1229 } 1230 1231 /// The caller has matched a pattern of the form: 1232 /// I = icmp ugt (add (add A, B), CI2), CI1 1233 /// If this is of the form: 1234 /// sum = a + b 1235 /// if (sum+128 >u 255) 1236 /// Then replace it with llvm.sadd.with.overflow.i8. 1237 /// 1238 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1239 ConstantInt *CI2, ConstantInt *CI1, 1240 InstCombiner &IC) { 1241 // The transformation we're trying to do here is to transform this into an 1242 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1243 // with a narrower add, and discard the add-with-constant that is part of the 1244 // range check (if we can't eliminate it, this isn't profitable). 1245 1246 // In order to eliminate the add-with-constant, the compare can be its only 1247 // use. 1248 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1249 if (!AddWithCst->hasOneUse()) 1250 return nullptr; 1251 1252 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1253 if (!CI2->getValue().isPowerOf2()) 1254 return nullptr; 1255 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1256 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1257 return nullptr; 1258 1259 // The width of the new add formed is 1 more than the bias. 1260 ++NewWidth; 1261 1262 // Check to see that CI1 is an all-ones value with NewWidth bits. 1263 if (CI1->getBitWidth() == NewWidth || 1264 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1265 return nullptr; 1266 1267 // This is only really a signed overflow check if the inputs have been 1268 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1269 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1270 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1271 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1272 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1273 return nullptr; 1274 1275 // In order to replace the original add with a narrower 1276 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1277 // and truncates that discard the high bits of the add. Verify that this is 1278 // the case. 1279 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1280 for (User *U : OrigAdd->users()) { 1281 if (U == AddWithCst) 1282 continue; 1283 1284 // Only accept truncates for now. We would really like a nice recursive 1285 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1286 // chain to see which bits of a value are actually demanded. If the 1287 // original add had another add which was then immediately truncated, we 1288 // could still do the transformation. 1289 TruncInst *TI = dyn_cast<TruncInst>(U); 1290 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1291 return nullptr; 1292 } 1293 1294 // If the pattern matches, truncate the inputs to the narrower type and 1295 // use the sadd_with_overflow intrinsic to efficiently compute both the 1296 // result and the overflow bit. 1297 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1298 Value *F = Intrinsic::getDeclaration(I.getModule(), 1299 Intrinsic::sadd_with_overflow, NewType); 1300 1301 InstCombiner::BuilderTy &Builder = IC.Builder; 1302 1303 // Put the new code above the original add, in case there are any uses of the 1304 // add between the add and the compare. 1305 Builder.SetInsertPoint(OrigAdd); 1306 1307 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1308 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1309 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1310 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1311 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1312 1313 // The inner add was the result of the narrow add, zero extended to the 1314 // wider type. Replace it with the result computed by the intrinsic. 1315 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1316 1317 // The original icmp gets replaced with the overflow value. 1318 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1319 } 1320 1321 // Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1322 Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) { 1323 CmpInst::Predicate Pred = Cmp.getPredicate(); 1324 Value *X = Cmp.getOperand(0); 1325 1326 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) { 1327 Value *A, *B; 1328 SelectPatternResult SPR = matchSelectPattern(X, A, B); 1329 if (SPR.Flavor == SPF_SMIN) { 1330 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1331 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1332 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1333 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1334 } 1335 } 1336 return nullptr; 1337 } 1338 1339 // Fold icmp Pred X, C. 1340 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1341 CmpInst::Predicate Pred = Cmp.getPredicate(); 1342 Value *X = Cmp.getOperand(0); 1343 1344 const APInt *C; 1345 if (!match(Cmp.getOperand(1), m_APInt(C))) 1346 return nullptr; 1347 1348 Value *A = nullptr, *B = nullptr; 1349 1350 // Match the following pattern, which is a common idiom when writing 1351 // overflow-safe integer arithmetic functions. The source performs an addition 1352 // in wider type and explicitly checks for overflow using comparisons against 1353 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1354 // 1355 // TODO: This could probably be generalized to handle other overflow-safe 1356 // operations if we worked out the formulas to compute the appropriate magic 1357 // constants. 1358 // 1359 // sum = a + b 1360 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1361 { 1362 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1363 if (Pred == ICmpInst::ICMP_UGT && 1364 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1365 if (Instruction *Res = processUGT_ADDCST_ADD( 1366 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this)) 1367 return Res; 1368 } 1369 1370 // FIXME: Use m_APInt to allow folds for splat constants. 1371 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1)); 1372 if (!CI) 1373 return nullptr; 1374 1375 // Canonicalize icmp instructions based on dominating conditions. 1376 BasicBlock *Parent = Cmp.getParent(); 1377 BasicBlock *Dom = Parent->getSinglePredecessor(); 1378 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr; 1379 ICmpInst::Predicate Pred2; 1380 BasicBlock *TrueBB, *FalseBB; 1381 ConstantInt *CI2; 1382 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)), 1383 TrueBB, FalseBB)) && 1384 TrueBB != FalseBB) { 1385 ConstantRange CR = 1386 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue()); 1387 ConstantRange DominatingCR = 1388 (Parent == TrueBB) 1389 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue()) 1390 : ConstantRange::makeExactICmpRegion( 1391 CmpInst::getInversePredicate(Pred2), CI2->getValue()); 1392 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1393 ConstantRange Difference = DominatingCR.difference(CR); 1394 if (Intersection.isEmptySet()) 1395 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1396 if (Difference.isEmptySet()) 1397 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1398 1399 // If this is a normal comparison, it demands all bits. If it is a sign 1400 // bit comparison, it only demands the sign bit. 1401 bool UnusedBit; 1402 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit); 1403 1404 // Canonicalizing a sign bit comparison that gets used in a branch, 1405 // pessimizes codegen by generating branch on zero instruction instead 1406 // of a test and branch. So we avoid canonicalizing in such situations 1407 // because test and branch instruction has better branch displacement 1408 // than compare and branch instruction. 1409 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1410 return nullptr; 1411 1412 if (auto *AI = Intersection.getSingleElement()) 1413 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI)); 1414 if (auto *AD = Difference.getSingleElement()) 1415 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD)); 1416 } 1417 1418 return nullptr; 1419 } 1420 1421 /// Fold icmp (trunc X, Y), C. 1422 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1423 TruncInst *Trunc, 1424 const APInt &C) { 1425 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1426 Value *X = Trunc->getOperand(0); 1427 if (C.isOneValue() && C.getBitWidth() > 1) { 1428 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1429 Value *V = nullptr; 1430 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1431 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1432 ConstantInt::get(V->getType(), 1)); 1433 } 1434 1435 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1436 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1437 // of the high bits truncated out of x are known. 1438 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1439 SrcBits = X->getType()->getScalarSizeInBits(); 1440 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1441 1442 // If all the high bits are known, we can do this xform. 1443 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1444 // Pull in the high bits from known-ones set. 1445 APInt NewRHS = C.zext(SrcBits); 1446 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1447 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1448 } 1449 } 1450 1451 return nullptr; 1452 } 1453 1454 /// Fold icmp (xor X, Y), C. 1455 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1456 BinaryOperator *Xor, 1457 const APInt &C) { 1458 Value *X = Xor->getOperand(0); 1459 Value *Y = Xor->getOperand(1); 1460 const APInt *XorC; 1461 if (!match(Y, m_APInt(XorC))) 1462 return nullptr; 1463 1464 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1465 // fold the xor. 1466 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1467 bool TrueIfSigned = false; 1468 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1469 1470 // If the sign bit of the XorCst is not set, there is no change to 1471 // the operation, just stop using the Xor. 1472 if (!XorC->isNegative()) { 1473 Cmp.setOperand(0, X); 1474 Worklist.Add(Xor); 1475 return &Cmp; 1476 } 1477 1478 // Emit the opposite comparison. 1479 if (TrueIfSigned) 1480 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1481 ConstantInt::getAllOnesValue(X->getType())); 1482 else 1483 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1484 ConstantInt::getNullValue(X->getType())); 1485 } 1486 1487 if (Xor->hasOneUse()) { 1488 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1489 if (!Cmp.isEquality() && XorC->isSignMask()) { 1490 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1491 : Cmp.getSignedPredicate(); 1492 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1493 } 1494 1495 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1496 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1497 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1498 : Cmp.getSignedPredicate(); 1499 Pred = Cmp.getSwappedPredicate(Pred); 1500 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1501 } 1502 } 1503 1504 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C) 1505 // iff -C is a power of 2 1506 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~C && (C + 1).isPowerOf2()) 1507 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1508 1509 // (icmp ult (xor X, C), -C) -> (icmp uge X, C) 1510 // iff -C is a power of 2 1511 if (Pred == ICmpInst::ICMP_ULT && *XorC == -C && C.isPowerOf2()) 1512 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 1513 1514 return nullptr; 1515 } 1516 1517 /// Fold icmp (and (sh X, Y), C2), C1. 1518 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1519 const APInt &C1, const APInt &C2) { 1520 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1521 if (!Shift || !Shift->isShift()) 1522 return nullptr; 1523 1524 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1525 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1526 // code produced by the clang front-end, for bitfield access. 1527 // This seemingly simple opportunity to fold away a shift turns out to be 1528 // rather complicated. See PR17827 for details. 1529 unsigned ShiftOpcode = Shift->getOpcode(); 1530 bool IsShl = ShiftOpcode == Instruction::Shl; 1531 const APInt *C3; 1532 if (match(Shift->getOperand(1), m_APInt(C3))) { 1533 bool CanFold = false; 1534 if (ShiftOpcode == Instruction::Shl) { 1535 // For a left shift, we can fold if the comparison is not signed. We can 1536 // also fold a signed comparison if the mask value and comparison value 1537 // are not negative. These constraints may not be obvious, but we can 1538 // prove that they are correct using an SMT solver. 1539 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative())) 1540 CanFold = true; 1541 } else { 1542 bool IsAshr = ShiftOpcode == Instruction::AShr; 1543 // For a logical right shift, we can fold if the comparison is not signed. 1544 // We can also fold a signed comparison if the shifted mask value and the 1545 // shifted comparison value are not negative. These constraints may not be 1546 // obvious, but we can prove that they are correct using an SMT solver. 1547 // For an arithmetic shift right we can do the same, if we ensure 1548 // the And doesn't use any bits being shifted in. Normally these would 1549 // be turned into lshr by SimplifyDemandedBits, but not if there is an 1550 // additional user. 1551 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) { 1552 if (!Cmp.isSigned() || 1553 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative())) 1554 CanFold = true; 1555 } 1556 } 1557 1558 if (CanFold) { 1559 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3); 1560 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3); 1561 // Check to see if we are shifting out any of the bits being compared. 1562 if (SameAsC1 != C1) { 1563 // If we shifted bits out, the fold is not going to work out. As a 1564 // special case, check to see if this means that the result is always 1565 // true or false now. 1566 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1567 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1568 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1569 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1570 } else { 1571 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst)); 1572 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3); 1573 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst)); 1574 And->setOperand(0, Shift->getOperand(0)); 1575 Worklist.Add(Shift); // Shift is dead. 1576 return &Cmp; 1577 } 1578 } 1579 } 1580 1581 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1582 // preferable because it allows the C2 << Y expression to be hoisted out of a 1583 // loop if Y is invariant and X is not. 1584 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() && 1585 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1586 // Compute C2 << Y. 1587 Value *NewShift = 1588 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1589 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1590 1591 // Compute X & (C2 << Y). 1592 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1593 Cmp.setOperand(0, NewAnd); 1594 return &Cmp; 1595 } 1596 1597 return nullptr; 1598 } 1599 1600 /// Fold icmp (and X, C2), C1. 1601 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1602 BinaryOperator *And, 1603 const APInt &C1) { 1604 const APInt *C2; 1605 if (!match(And->getOperand(1), m_APInt(C2))) 1606 return nullptr; 1607 1608 if (!And->hasOneUse()) 1609 return nullptr; 1610 1611 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1612 // the input width without changing the value produced, eliminate the cast: 1613 // 1614 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1615 // 1616 // We can do this transformation if the constants do not have their sign bits 1617 // set or if it is an equality comparison. Extending a relational comparison 1618 // when we're checking the sign bit would not work. 1619 Value *W; 1620 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1621 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1622 // TODO: Is this a good transform for vectors? Wider types may reduce 1623 // throughput. Should this transform be limited (even for scalars) by using 1624 // shouldChangeType()? 1625 if (!Cmp.getType()->isVectorTy()) { 1626 Type *WideType = W->getType(); 1627 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1628 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1629 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1630 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1631 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1632 } 1633 } 1634 1635 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1636 return I; 1637 1638 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1639 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1640 // 1641 // iff pred isn't signed 1642 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() && 1643 match(And->getOperand(1), m_One())) { 1644 Constant *One = cast<Constant>(And->getOperand(1)); 1645 Value *Or = And->getOperand(0); 1646 Value *A, *B, *LShr; 1647 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1648 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1649 unsigned UsesRemoved = 0; 1650 if (And->hasOneUse()) 1651 ++UsesRemoved; 1652 if (Or->hasOneUse()) 1653 ++UsesRemoved; 1654 if (LShr->hasOneUse()) 1655 ++UsesRemoved; 1656 1657 // Compute A & ((1 << B) | 1) 1658 Value *NewOr = nullptr; 1659 if (auto *C = dyn_cast<Constant>(B)) { 1660 if (UsesRemoved >= 1) 1661 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1662 } else { 1663 if (UsesRemoved >= 3) 1664 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1665 /*HasNUW=*/true), 1666 One, Or->getName()); 1667 } 1668 if (NewOr) { 1669 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1670 Cmp.setOperand(0, NewAnd); 1671 return &Cmp; 1672 } 1673 } 1674 } 1675 1676 return nullptr; 1677 } 1678 1679 /// Fold icmp (and X, Y), C. 1680 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1681 BinaryOperator *And, 1682 const APInt &C) { 1683 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1684 return I; 1685 1686 // TODO: These all require that Y is constant too, so refactor with the above. 1687 1688 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1689 Value *X = And->getOperand(0); 1690 Value *Y = And->getOperand(1); 1691 if (auto *LI = dyn_cast<LoadInst>(X)) 1692 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1693 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1694 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1695 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1696 ConstantInt *C2 = cast<ConstantInt>(Y); 1697 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1698 return Res; 1699 } 1700 1701 if (!Cmp.isEquality()) 1702 return nullptr; 1703 1704 // X & -C == -C -> X > u ~C 1705 // X & -C != -C -> X <= u ~C 1706 // iff C is a power of 2 1707 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) { 1708 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1709 : CmpInst::ICMP_ULE; 1710 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1711 } 1712 1713 // (X & C2) == 0 -> (trunc X) >= 0 1714 // (X & C2) != 0 -> (trunc X) < 0 1715 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1716 const APInt *C2; 1717 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) { 1718 int32_t ExactLogBase2 = C2->exactLogBase2(); 1719 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1720 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1721 if (And->getType()->isVectorTy()) 1722 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements()); 1723 Value *Trunc = Builder.CreateTrunc(X, NTy); 1724 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1725 : CmpInst::ICMP_SLT; 1726 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1727 } 1728 } 1729 1730 return nullptr; 1731 } 1732 1733 /// Fold icmp (or X, Y), C. 1734 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1735 const APInt &C) { 1736 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1737 if (C.isOneValue()) { 1738 // icmp slt signum(V) 1 --> icmp slt V, 1 1739 Value *V = nullptr; 1740 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1741 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1742 ConstantInt::get(V->getType(), 1)); 1743 } 1744 1745 // X | C == C --> X <=u C 1746 // X | C != C --> X >u C 1747 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1748 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) && 1749 (C + 1).isPowerOf2()) { 1750 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1751 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1)); 1752 } 1753 1754 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse()) 1755 return nullptr; 1756 1757 Value *P, *Q; 1758 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1759 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1760 // -> and (icmp eq P, null), (icmp eq Q, null). 1761 Value *CmpP = 1762 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1763 Value *CmpQ = 1764 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1765 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1766 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1767 } 1768 1769 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1770 // a shorter form that has more potential to be folded even further. 1771 Value *X1, *X2, *X3, *X4; 1772 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1773 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1774 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1775 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1776 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1777 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1778 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1779 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1780 } 1781 1782 return nullptr; 1783 } 1784 1785 /// Fold icmp (mul X, Y), C. 1786 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1787 BinaryOperator *Mul, 1788 const APInt &C) { 1789 const APInt *MulC; 1790 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1791 return nullptr; 1792 1793 // If this is a test of the sign bit and the multiply is sign-preserving with 1794 // a constant operand, use the multiply LHS operand instead. 1795 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1796 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1797 if (MulC->isNegative()) 1798 Pred = ICmpInst::getSwappedPredicate(Pred); 1799 return new ICmpInst(Pred, Mul->getOperand(0), 1800 Constant::getNullValue(Mul->getType())); 1801 } 1802 1803 return nullptr; 1804 } 1805 1806 /// Fold icmp (shl 1, Y), C. 1807 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1808 const APInt &C) { 1809 Value *Y; 1810 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1811 return nullptr; 1812 1813 Type *ShiftType = Shl->getType(); 1814 unsigned TypeBits = C.getBitWidth(); 1815 bool CIsPowerOf2 = C.isPowerOf2(); 1816 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1817 if (Cmp.isUnsigned()) { 1818 // (1 << Y) pred C -> Y pred Log2(C) 1819 if (!CIsPowerOf2) { 1820 // (1 << Y) < 30 -> Y <= 4 1821 // (1 << Y) <= 30 -> Y <= 4 1822 // (1 << Y) >= 30 -> Y > 4 1823 // (1 << Y) > 30 -> Y > 4 1824 if (Pred == ICmpInst::ICMP_ULT) 1825 Pred = ICmpInst::ICMP_ULE; 1826 else if (Pred == ICmpInst::ICMP_UGE) 1827 Pred = ICmpInst::ICMP_UGT; 1828 } 1829 1830 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1831 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1832 unsigned CLog2 = C.logBase2(); 1833 if (CLog2 == TypeBits - 1) { 1834 if (Pred == ICmpInst::ICMP_UGE) 1835 Pred = ICmpInst::ICMP_EQ; 1836 else if (Pred == ICmpInst::ICMP_ULT) 1837 Pred = ICmpInst::ICMP_NE; 1838 } 1839 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1840 } else if (Cmp.isSigned()) { 1841 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1842 if (C.isAllOnesValue()) { 1843 // (1 << Y) <= -1 -> Y == 31 1844 if (Pred == ICmpInst::ICMP_SLE) 1845 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1846 1847 // (1 << Y) > -1 -> Y != 31 1848 if (Pred == ICmpInst::ICMP_SGT) 1849 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1850 } else if (!C) { 1851 // (1 << Y) < 0 -> Y == 31 1852 // (1 << Y) <= 0 -> Y == 31 1853 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1854 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1855 1856 // (1 << Y) >= 0 -> Y != 31 1857 // (1 << Y) > 0 -> Y != 31 1858 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 1859 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1860 } 1861 } else if (Cmp.isEquality() && CIsPowerOf2) { 1862 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 1863 } 1864 1865 return nullptr; 1866 } 1867 1868 /// Fold icmp (shl X, Y), C. 1869 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 1870 BinaryOperator *Shl, 1871 const APInt &C) { 1872 const APInt *ShiftVal; 1873 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 1874 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 1875 1876 const APInt *ShiftAmt; 1877 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 1878 return foldICmpShlOne(Cmp, Shl, C); 1879 1880 // Check that the shift amount is in range. If not, don't perform undefined 1881 // shifts. When the shift is visited, it will be simplified. 1882 unsigned TypeBits = C.getBitWidth(); 1883 if (ShiftAmt->uge(TypeBits)) 1884 return nullptr; 1885 1886 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1887 Value *X = Shl->getOperand(0); 1888 Type *ShType = Shl->getType(); 1889 1890 // NSW guarantees that we are only shifting out sign bits from the high bits, 1891 // so we can ASHR the compare constant without needing a mask and eliminate 1892 // the shift. 1893 if (Shl->hasNoSignedWrap()) { 1894 if (Pred == ICmpInst::ICMP_SGT) { 1895 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 1896 APInt ShiftedC = C.ashr(*ShiftAmt); 1897 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1898 } 1899 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) { 1900 // This is the same code as the SGT case, but assert the pre-condition 1901 // that is needed for this to work with equality predicates. 1902 assert(C.ashr(*ShiftAmt).shl(*ShiftAmt) == C && 1903 "Compare known true or false was not folded"); 1904 APInt ShiftedC = C.ashr(*ShiftAmt); 1905 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1906 } 1907 if (Pred == ICmpInst::ICMP_SLT) { 1908 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 1909 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 1910 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 1911 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 1912 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 1913 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 1914 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1915 } 1916 // If this is a signed comparison to 0 and the shift is sign preserving, 1917 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 1918 // do that if we're sure to not continue on in this function. 1919 if (isSignTest(Pred, C)) 1920 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 1921 } 1922 1923 // NUW guarantees that we are only shifting out zero bits from the high bits, 1924 // so we can LSHR the compare constant without needing a mask and eliminate 1925 // the shift. 1926 if (Shl->hasNoUnsignedWrap()) { 1927 if (Pred == ICmpInst::ICMP_UGT) { 1928 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 1929 APInt ShiftedC = C.lshr(*ShiftAmt); 1930 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1931 } 1932 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) { 1933 // This is the same code as the UGT case, but assert the pre-condition 1934 // that is needed for this to work with equality predicates. 1935 assert(C.lshr(*ShiftAmt).shl(*ShiftAmt) == C && 1936 "Compare known true or false was not folded"); 1937 APInt ShiftedC = C.lshr(*ShiftAmt); 1938 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1939 } 1940 if (Pred == ICmpInst::ICMP_ULT) { 1941 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 1942 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 1943 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 1944 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 1945 assert(C.ugt(0) && "ult 0 should have been eliminated"); 1946 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 1947 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1948 } 1949 } 1950 1951 if (Cmp.isEquality() && Shl->hasOneUse()) { 1952 // Strength-reduce the shift into an 'and'. 1953 Constant *Mask = ConstantInt::get( 1954 ShType, 1955 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 1956 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 1957 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 1958 return new ICmpInst(Pred, And, LShrC); 1959 } 1960 1961 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 1962 bool TrueIfSigned = false; 1963 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 1964 // (X << 31) <s 0 --> (X & 1) != 0 1965 Constant *Mask = ConstantInt::get( 1966 ShType, 1967 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 1968 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 1969 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 1970 And, Constant::getNullValue(ShType)); 1971 } 1972 1973 // Transform (icmp pred iM (shl iM %v, N), C) 1974 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 1975 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 1976 // This enables us to get rid of the shift in favor of a trunc that may be 1977 // free on the target. It has the additional benefit of comparing to a 1978 // smaller constant that may be more target-friendly. 1979 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 1980 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 1981 DL.isLegalInteger(TypeBits - Amt)) { 1982 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 1983 if (ShType->isVectorTy()) 1984 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements()); 1985 Constant *NewC = 1986 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 1987 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 1988 } 1989 1990 return nullptr; 1991 } 1992 1993 /// Fold icmp ({al}shr X, Y), C. 1994 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 1995 BinaryOperator *Shr, 1996 const APInt &C) { 1997 // An exact shr only shifts out zero bits, so: 1998 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 1999 Value *X = Shr->getOperand(0); 2000 CmpInst::Predicate Pred = Cmp.getPredicate(); 2001 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && 2002 C.isNullValue()) 2003 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2004 2005 const APInt *ShiftVal; 2006 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2007 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2008 2009 const APInt *ShiftAmt; 2010 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2011 return nullptr; 2012 2013 // Check that the shift amount is in range. If not, don't perform undefined 2014 // shifts. When the shift is visited it will be simplified. 2015 unsigned TypeBits = C.getBitWidth(); 2016 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2017 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2018 return nullptr; 2019 2020 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2021 bool IsExact = Shr->isExact(); 2022 Type *ShrTy = Shr->getType(); 2023 // TODO: If we could guarantee that InstSimplify would handle all of the 2024 // constant-value-based preconditions in the folds below, then we could assert 2025 // those conditions rather than checking them. This is difficult because of 2026 // undef/poison (PR34838). 2027 if (IsAShr) { 2028 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2029 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2030 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2031 APInt ShiftedC = C.shl(ShAmtVal); 2032 if (ShiftedC.ashr(ShAmtVal) == C) 2033 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2034 } 2035 if (Pred == CmpInst::ICMP_SGT) { 2036 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2037 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2038 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2039 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2040 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2041 } 2042 } else { 2043 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2044 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2045 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2046 APInt ShiftedC = C.shl(ShAmtVal); 2047 if (ShiftedC.lshr(ShAmtVal) == C) 2048 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2049 } 2050 if (Pred == CmpInst::ICMP_UGT) { 2051 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2052 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2053 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2054 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2055 } 2056 } 2057 2058 if (!Cmp.isEquality()) 2059 return nullptr; 2060 2061 // Handle equality comparisons of shift-by-constant. 2062 2063 // If the comparison constant changes with the shift, the comparison cannot 2064 // succeed (bits of the comparison constant cannot match the shifted value). 2065 // This should be known by InstSimplify and already be folded to true/false. 2066 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2067 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2068 "Expected icmp+shr simplify did not occur."); 2069 2070 // If the bits shifted out are known zero, compare the unshifted value: 2071 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2072 if (Shr->isExact()) 2073 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2074 2075 if (Shr->hasOneUse()) { 2076 // Canonicalize the shift into an 'and': 2077 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2078 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2079 Constant *Mask = ConstantInt::get(ShrTy, Val); 2080 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2081 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2082 } 2083 2084 return nullptr; 2085 } 2086 2087 /// Fold icmp (udiv X, Y), C. 2088 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2089 BinaryOperator *UDiv, 2090 const APInt &C) { 2091 const APInt *C2; 2092 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2093 return nullptr; 2094 2095 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2096 2097 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2098 Value *Y = UDiv->getOperand(1); 2099 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2100 assert(!C.isMaxValue() && 2101 "icmp ugt X, UINT_MAX should have been simplified already."); 2102 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2103 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2104 } 2105 2106 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2107 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2108 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2109 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2110 ConstantInt::get(Y->getType(), C2->udiv(C))); 2111 } 2112 2113 return nullptr; 2114 } 2115 2116 /// Fold icmp ({su}div X, Y), C. 2117 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2118 BinaryOperator *Div, 2119 const APInt &C) { 2120 // Fold: icmp pred ([us]div X, C2), C -> range test 2121 // Fold this div into the comparison, producing a range check. 2122 // Determine, based on the divide type, what the range is being 2123 // checked. If there is an overflow on the low or high side, remember 2124 // it, otherwise compute the range [low, hi) bounding the new value. 2125 // See: InsertRangeTest above for the kinds of replacements possible. 2126 const APInt *C2; 2127 if (!match(Div->getOperand(1), m_APInt(C2))) 2128 return nullptr; 2129 2130 // FIXME: If the operand types don't match the type of the divide 2131 // then don't attempt this transform. The code below doesn't have the 2132 // logic to deal with a signed divide and an unsigned compare (and 2133 // vice versa). This is because (x /s C2) <s C produces different 2134 // results than (x /s C2) <u C or (x /u C2) <s C or even 2135 // (x /u C2) <u C. Simply casting the operands and result won't 2136 // work. :( The if statement below tests that condition and bails 2137 // if it finds it. 2138 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2139 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2140 return nullptr; 2141 2142 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2143 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2144 // division-by-constant cases should be present, we can not assert that they 2145 // have happened before we reach this icmp instruction. 2146 if (C2->isNullValue() || C2->isOneValue() || 2147 (DivIsSigned && C2->isAllOnesValue())) 2148 return nullptr; 2149 2150 // Compute Prod = C * C2. We are essentially solving an equation of 2151 // form X / C2 = C. We solve for X by multiplying C2 and C. 2152 // By solving for X, we can turn this into a range check instead of computing 2153 // a divide. 2154 APInt Prod = C * *C2; 2155 2156 // Determine if the product overflows by seeing if the product is not equal to 2157 // the divide. Make sure we do the same kind of divide as in the LHS 2158 // instruction that we're folding. 2159 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2160 2161 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2162 2163 // If the division is known to be exact, then there is no remainder from the 2164 // divide, so the covered range size is unit, otherwise it is the divisor. 2165 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2166 2167 // Figure out the interval that is being checked. For example, a comparison 2168 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2169 // Compute this interval based on the constants involved and the signedness of 2170 // the compare/divide. This computes a half-open interval, keeping track of 2171 // whether either value in the interval overflows. After analysis each 2172 // overflow variable is set to 0 if it's corresponding bound variable is valid 2173 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2174 int LoOverflow = 0, HiOverflow = 0; 2175 APInt LoBound, HiBound; 2176 2177 if (!DivIsSigned) { // udiv 2178 // e.g. X/5 op 3 --> [15, 20) 2179 LoBound = Prod; 2180 HiOverflow = LoOverflow = ProdOV; 2181 if (!HiOverflow) { 2182 // If this is not an exact divide, then many values in the range collapse 2183 // to the same result value. 2184 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2185 } 2186 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2187 if (C.isNullValue()) { // (X / pos) op 0 2188 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2189 LoBound = -(RangeSize - 1); 2190 HiBound = RangeSize; 2191 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2192 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2193 HiOverflow = LoOverflow = ProdOV; 2194 if (!HiOverflow) 2195 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2196 } else { // (X / pos) op neg 2197 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2198 HiBound = Prod + 1; 2199 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2200 if (!LoOverflow) { 2201 APInt DivNeg = -RangeSize; 2202 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2203 } 2204 } 2205 } else if (C2->isNegative()) { // Divisor is < 0. 2206 if (Div->isExact()) 2207 RangeSize.negate(); 2208 if (C.isNullValue()) { // (X / neg) op 0 2209 // e.g. X/-5 op 0 --> [-4, 5) 2210 LoBound = RangeSize + 1; 2211 HiBound = -RangeSize; 2212 if (HiBound == *C2) { // -INTMIN = INTMIN 2213 HiOverflow = 1; // [INTMIN+1, overflow) 2214 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2215 } 2216 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2217 // e.g. X/-5 op 3 --> [-19, -14) 2218 HiBound = Prod + 1; 2219 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2220 if (!LoOverflow) 2221 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2222 } else { // (X / neg) op neg 2223 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2224 LoOverflow = HiOverflow = ProdOV; 2225 if (!HiOverflow) 2226 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2227 } 2228 2229 // Dividing by a negative swaps the condition. LT <-> GT 2230 Pred = ICmpInst::getSwappedPredicate(Pred); 2231 } 2232 2233 Value *X = Div->getOperand(0); 2234 switch (Pred) { 2235 default: llvm_unreachable("Unhandled icmp opcode!"); 2236 case ICmpInst::ICMP_EQ: 2237 if (LoOverflow && HiOverflow) 2238 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2239 if (HiOverflow) 2240 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2241 ICmpInst::ICMP_UGE, X, 2242 ConstantInt::get(Div->getType(), LoBound)); 2243 if (LoOverflow) 2244 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2245 ICmpInst::ICMP_ULT, X, 2246 ConstantInt::get(Div->getType(), HiBound)); 2247 return replaceInstUsesWith( 2248 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2249 case ICmpInst::ICMP_NE: 2250 if (LoOverflow && HiOverflow) 2251 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2252 if (HiOverflow) 2253 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2254 ICmpInst::ICMP_ULT, X, 2255 ConstantInt::get(Div->getType(), LoBound)); 2256 if (LoOverflow) 2257 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2258 ICmpInst::ICMP_UGE, X, 2259 ConstantInt::get(Div->getType(), HiBound)); 2260 return replaceInstUsesWith(Cmp, 2261 insertRangeTest(X, LoBound, HiBound, 2262 DivIsSigned, false)); 2263 case ICmpInst::ICMP_ULT: 2264 case ICmpInst::ICMP_SLT: 2265 if (LoOverflow == +1) // Low bound is greater than input range. 2266 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2267 if (LoOverflow == -1) // Low bound is less than input range. 2268 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2269 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2270 case ICmpInst::ICMP_UGT: 2271 case ICmpInst::ICMP_SGT: 2272 if (HiOverflow == +1) // High bound greater than input range. 2273 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2274 if (HiOverflow == -1) // High bound less than input range. 2275 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2276 if (Pred == ICmpInst::ICMP_UGT) 2277 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2278 ConstantInt::get(Div->getType(), HiBound)); 2279 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2280 ConstantInt::get(Div->getType(), HiBound)); 2281 } 2282 2283 return nullptr; 2284 } 2285 2286 /// Fold icmp (sub X, Y), C. 2287 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2288 BinaryOperator *Sub, 2289 const APInt &C) { 2290 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2291 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2292 2293 // The following transforms are only worth it if the only user of the subtract 2294 // is the icmp. 2295 if (!Sub->hasOneUse()) 2296 return nullptr; 2297 2298 if (Sub->hasNoSignedWrap()) { 2299 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2300 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue()) 2301 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2302 2303 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2304 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue()) 2305 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2306 2307 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2308 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue()) 2309 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2310 2311 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2312 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue()) 2313 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2314 } 2315 2316 const APInt *C2; 2317 if (!match(X, m_APInt(C2))) 2318 return nullptr; 2319 2320 // C2 - Y <u C -> (Y | (C - 1)) == C2 2321 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2322 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2323 (*C2 & (C - 1)) == (C - 1)) 2324 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2325 2326 // C2 - Y >u C -> (Y | C) != C2 2327 // iff C2 & C == C and C + 1 is a power of 2 2328 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2329 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2330 2331 return nullptr; 2332 } 2333 2334 /// Fold icmp (add X, Y), C. 2335 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2336 BinaryOperator *Add, 2337 const APInt &C) { 2338 Value *Y = Add->getOperand(1); 2339 const APInt *C2; 2340 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2341 return nullptr; 2342 2343 // Fold icmp pred (add X, C2), C. 2344 Value *X = Add->getOperand(0); 2345 Type *Ty = Add->getType(); 2346 CmpInst::Predicate Pred = Cmp.getPredicate(); 2347 2348 // If the add does not wrap, we can always adjust the compare by subtracting 2349 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are 2350 // canonicalized to SGT/SLT. 2351 if (Add->hasNoSignedWrap() && 2352 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) { 2353 bool Overflow; 2354 APInt NewC = C.ssub_ov(*C2, Overflow); 2355 // If there is overflow, the result must be true or false. 2356 // TODO: Can we assert there is no overflow because InstSimplify always 2357 // handles those cases? 2358 if (!Overflow) 2359 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2360 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2361 } 2362 2363 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2364 const APInt &Upper = CR.getUpper(); 2365 const APInt &Lower = CR.getLower(); 2366 if (Cmp.isSigned()) { 2367 if (Lower.isSignMask()) 2368 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2369 if (Upper.isSignMask()) 2370 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2371 } else { 2372 if (Lower.isMinValue()) 2373 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2374 if (Upper.isMinValue()) 2375 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2376 } 2377 2378 if (!Add->hasOneUse()) 2379 return nullptr; 2380 2381 // X+C <u C2 -> (X & -C2) == C 2382 // iff C & (C2-1) == 0 2383 // C2 is a power of 2 2384 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2385 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2386 ConstantExpr::getNeg(cast<Constant>(Y))); 2387 2388 // X+C >u C2 -> (X & ~C2) != C 2389 // iff C & C2 == 0 2390 // C2+1 is a power of 2 2391 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2392 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2393 ConstantExpr::getNeg(cast<Constant>(Y))); 2394 2395 return nullptr; 2396 } 2397 2398 bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2399 Value *&RHS, ConstantInt *&Less, 2400 ConstantInt *&Equal, 2401 ConstantInt *&Greater) { 2402 // TODO: Generalize this to work with other comparison idioms or ensure 2403 // they get canonicalized into this form. 2404 2405 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 2406 // Greater), where Equal, Less and Greater are placeholders for any three 2407 // constants. 2408 ICmpInst::Predicate PredA, PredB; 2409 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) && 2410 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) && 2411 PredA == ICmpInst::ICMP_EQ && 2412 match(SI->getFalseValue(), 2413 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)), 2414 m_ConstantInt(Less), m_ConstantInt(Greater))) && 2415 PredB == ICmpInst::ICMP_SLT) { 2416 return true; 2417 } 2418 return false; 2419 } 2420 2421 Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp, 2422 SelectInst *Select, 2423 ConstantInt *C) { 2424 2425 assert(C && "Cmp RHS should be a constant int!"); 2426 // If we're testing a constant value against the result of a three way 2427 // comparison, the result can be expressed directly in terms of the 2428 // original values being compared. Note: We could possibly be more 2429 // aggressive here and remove the hasOneUse test. The original select is 2430 // really likely to simplify or sink when we remove a test of the result. 2431 Value *OrigLHS, *OrigRHS; 2432 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2433 if (Cmp.hasOneUse() && 2434 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2435 C3GreaterThan)) { 2436 assert(C1LessThan && C2Equal && C3GreaterThan); 2437 2438 bool TrueWhenLessThan = 2439 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2440 ->isAllOnesValue(); 2441 bool TrueWhenEqual = 2442 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2443 ->isAllOnesValue(); 2444 bool TrueWhenGreaterThan = 2445 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2446 ->isAllOnesValue(); 2447 2448 // This generates the new instruction that will replace the original Cmp 2449 // Instruction. Instead of enumerating the various combinations when 2450 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2451 // false, we rely on chaining of ORs and future passes of InstCombine to 2452 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2453 2454 // When none of the three constants satisfy the predicate for the RHS (C), 2455 // the entire original Cmp can be simplified to a false. 2456 Value *Cond = Builder.getFalse(); 2457 if (TrueWhenLessThan) 2458 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS)); 2459 if (TrueWhenEqual) 2460 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS)); 2461 if (TrueWhenGreaterThan) 2462 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS)); 2463 2464 return replaceInstUsesWith(Cmp, Cond); 2465 } 2466 return nullptr; 2467 } 2468 2469 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2470 /// where X is some kind of instruction. 2471 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2472 const APInt *C; 2473 if (!match(Cmp.getOperand(1), m_APInt(C))) 2474 return nullptr; 2475 2476 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 2477 switch (BO->getOpcode()) { 2478 case Instruction::Xor: 2479 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 2480 return I; 2481 break; 2482 case Instruction::And: 2483 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 2484 return I; 2485 break; 2486 case Instruction::Or: 2487 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 2488 return I; 2489 break; 2490 case Instruction::Mul: 2491 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 2492 return I; 2493 break; 2494 case Instruction::Shl: 2495 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 2496 return I; 2497 break; 2498 case Instruction::LShr: 2499 case Instruction::AShr: 2500 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 2501 return I; 2502 break; 2503 case Instruction::UDiv: 2504 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 2505 return I; 2506 LLVM_FALLTHROUGH; 2507 case Instruction::SDiv: 2508 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 2509 return I; 2510 break; 2511 case Instruction::Sub: 2512 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 2513 return I; 2514 break; 2515 case Instruction::Add: 2516 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 2517 return I; 2518 break; 2519 default: 2520 break; 2521 } 2522 // TODO: These folds could be refactored to be part of the above calls. 2523 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 2524 return I; 2525 } 2526 2527 // Match against CmpInst LHS being instructions other than binary operators. 2528 2529 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 2530 // For now, we only support constant integers while folding the 2531 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 2532 // similar to the cases handled by binary ops above. 2533 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 2534 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 2535 return I; 2536 } 2537 2538 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 2539 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 2540 return I; 2541 } 2542 2543 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C)) 2544 return I; 2545 2546 return nullptr; 2547 } 2548 2549 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2550 /// icmp eq/ne BO, C. 2551 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2552 BinaryOperator *BO, 2553 const APInt &C) { 2554 // TODO: Some of these folds could work with arbitrary constants, but this 2555 // function is limited to scalar and vector splat constants. 2556 if (!Cmp.isEquality()) 2557 return nullptr; 2558 2559 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2560 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2561 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2562 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2563 2564 switch (BO->getOpcode()) { 2565 case Instruction::SRem: 2566 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2567 if (C.isNullValue() && BO->hasOneUse()) { 2568 const APInt *BOC; 2569 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2570 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 2571 return new ICmpInst(Pred, NewRem, 2572 Constant::getNullValue(BO->getType())); 2573 } 2574 } 2575 break; 2576 case Instruction::Add: { 2577 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2578 const APInt *BOC; 2579 if (match(BOp1, m_APInt(BOC))) { 2580 if (BO->hasOneUse()) { 2581 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1)); 2582 return new ICmpInst(Pred, BOp0, SubC); 2583 } 2584 } else if (C.isNullValue()) { 2585 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2586 // efficiently invertible, or if the add has just this one use. 2587 if (Value *NegVal = dyn_castNegVal(BOp1)) 2588 return new ICmpInst(Pred, BOp0, NegVal); 2589 if (Value *NegVal = dyn_castNegVal(BOp0)) 2590 return new ICmpInst(Pred, NegVal, BOp1); 2591 if (BO->hasOneUse()) { 2592 Value *Neg = Builder.CreateNeg(BOp1); 2593 Neg->takeName(BO); 2594 return new ICmpInst(Pred, BOp0, Neg); 2595 } 2596 } 2597 break; 2598 } 2599 case Instruction::Xor: 2600 if (BO->hasOneUse()) { 2601 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2602 // For the xor case, we can xor two constants together, eliminating 2603 // the explicit xor. 2604 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2605 } else if (C.isNullValue()) { 2606 // Replace ((xor A, B) != 0) with (A != B) 2607 return new ICmpInst(Pred, BOp0, BOp1); 2608 } 2609 } 2610 break; 2611 case Instruction::Sub: 2612 if (BO->hasOneUse()) { 2613 const APInt *BOC; 2614 if (match(BOp0, m_APInt(BOC))) { 2615 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2616 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS); 2617 return new ICmpInst(Pred, BOp1, SubC); 2618 } else if (C.isNullValue()) { 2619 // Replace ((sub A, B) != 0) with (A != B). 2620 return new ICmpInst(Pred, BOp0, BOp1); 2621 } 2622 } 2623 break; 2624 case Instruction::Or: { 2625 const APInt *BOC; 2626 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 2627 // Comparing if all bits outside of a constant mask are set? 2628 // Replace (X | C) == -1 with (X & ~C) == ~C. 2629 // This removes the -1 constant. 2630 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 2631 Value *And = Builder.CreateAnd(BOp0, NotBOC); 2632 return new ICmpInst(Pred, And, NotBOC); 2633 } 2634 break; 2635 } 2636 case Instruction::And: { 2637 const APInt *BOC; 2638 if (match(BOp1, m_APInt(BOC))) { 2639 // If we have ((X & C) == C), turn it into ((X & C) != 0). 2640 if (C == *BOC && C.isPowerOf2()) 2641 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 2642 BO, Constant::getNullValue(RHS->getType())); 2643 2644 // Don't perform the following transforms if the AND has multiple uses 2645 if (!BO->hasOneUse()) 2646 break; 2647 2648 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0 2649 if (BOC->isSignMask()) { 2650 Constant *Zero = Constant::getNullValue(BOp0->getType()); 2651 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 2652 return new ICmpInst(NewPred, BOp0, Zero); 2653 } 2654 2655 // ((X & ~7) == 0) --> X < 8 2656 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) { 2657 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1)); 2658 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 2659 return new ICmpInst(NewPred, BOp0, NegBOC); 2660 } 2661 } 2662 break; 2663 } 2664 case Instruction::Mul: 2665 if (C.isNullValue() && BO->hasNoSignedWrap()) { 2666 const APInt *BOC; 2667 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) { 2668 // The trivial case (mul X, 0) is handled by InstSimplify. 2669 // General case : (mul X, C) != 0 iff X != 0 2670 // (mul X, C) == 0 iff X == 0 2671 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 2672 } 2673 } 2674 break; 2675 case Instruction::UDiv: 2676 if (C.isNullValue()) { 2677 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 2678 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 2679 return new ICmpInst(NewPred, BOp1, BOp0); 2680 } 2681 break; 2682 default: 2683 break; 2684 } 2685 return nullptr; 2686 } 2687 2688 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 2689 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 2690 const APInt &C) { 2691 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)); 2692 if (!II || !Cmp.isEquality()) 2693 return nullptr; 2694 2695 // Handle icmp {eq|ne} <intrinsic>, Constant. 2696 Type *Ty = II->getType(); 2697 switch (II->getIntrinsicID()) { 2698 case Intrinsic::bswap: 2699 Worklist.Add(II); 2700 Cmp.setOperand(0, II->getArgOperand(0)); 2701 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap())); 2702 return &Cmp; 2703 2704 case Intrinsic::ctlz: 2705 case Intrinsic::cttz: 2706 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 2707 if (C == C.getBitWidth()) { 2708 Worklist.Add(II); 2709 Cmp.setOperand(0, II->getArgOperand(0)); 2710 Cmp.setOperand(1, ConstantInt::getNullValue(Ty)); 2711 return &Cmp; 2712 } 2713 break; 2714 2715 case Intrinsic::ctpop: { 2716 // popcount(A) == 0 -> A == 0 and likewise for != 2717 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 2718 bool IsZero = C.isNullValue(); 2719 if (IsZero || C == C.getBitWidth()) { 2720 Worklist.Add(II); 2721 Cmp.setOperand(0, II->getArgOperand(0)); 2722 auto *NewOp = 2723 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty); 2724 Cmp.setOperand(1, NewOp); 2725 return &Cmp; 2726 } 2727 break; 2728 } 2729 default: 2730 break; 2731 } 2732 2733 return nullptr; 2734 } 2735 2736 /// Handle icmp with constant (but not simple integer constant) RHS. 2737 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 2738 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2739 Constant *RHSC = dyn_cast<Constant>(Op1); 2740 Instruction *LHSI = dyn_cast<Instruction>(Op0); 2741 if (!RHSC || !LHSI) 2742 return nullptr; 2743 2744 switch (LHSI->getOpcode()) { 2745 case Instruction::GetElementPtr: 2746 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 2747 if (RHSC->isNullValue() && 2748 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 2749 return new ICmpInst( 2750 I.getPredicate(), LHSI->getOperand(0), 2751 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2752 break; 2753 case Instruction::PHI: 2754 // Only fold icmp into the PHI if the phi and icmp are in the same 2755 // block. If in the same block, we're encouraging jump threading. If 2756 // not, we are just pessimizing the code by making an i1 phi. 2757 if (LHSI->getParent() == I.getParent()) 2758 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 2759 return NV; 2760 break; 2761 case Instruction::Select: { 2762 // If either operand of the select is a constant, we can fold the 2763 // comparison into the select arms, which will cause one to be 2764 // constant folded and the select turned into a bitwise or. 2765 Value *Op1 = nullptr, *Op2 = nullptr; 2766 ConstantInt *CI = nullptr; 2767 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 2768 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2769 CI = dyn_cast<ConstantInt>(Op1); 2770 } 2771 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 2772 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2773 CI = dyn_cast<ConstantInt>(Op2); 2774 } 2775 2776 // We only want to perform this transformation if it will not lead to 2777 // additional code. This is true if either both sides of the select 2778 // fold to a constant (in which case the icmp is replaced with a select 2779 // which will usually simplify) or this is the only user of the 2780 // select (in which case we are trading a select+icmp for a simpler 2781 // select+icmp) or all uses of the select can be replaced based on 2782 // dominance information ("Global cases"). 2783 bool Transform = false; 2784 if (Op1 && Op2) 2785 Transform = true; 2786 else if (Op1 || Op2) { 2787 // Local case 2788 if (LHSI->hasOneUse()) 2789 Transform = true; 2790 // Global cases 2791 else if (CI && !CI->isZero()) 2792 // When Op1 is constant try replacing select with second operand. 2793 // Otherwise Op2 is constant and try replacing select with first 2794 // operand. 2795 Transform = 2796 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 2797 } 2798 if (Transform) { 2799 if (!Op1) 2800 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 2801 I.getName()); 2802 if (!Op2) 2803 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 2804 I.getName()); 2805 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 2806 } 2807 break; 2808 } 2809 case Instruction::IntToPtr: 2810 // icmp pred inttoptr(X), null -> icmp pred X, 0 2811 if (RHSC->isNullValue() && 2812 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 2813 return new ICmpInst( 2814 I.getPredicate(), LHSI->getOperand(0), 2815 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2816 break; 2817 2818 case Instruction::Load: 2819 // Try to optimize things like "A[i] > 4" to index computations. 2820 if (GetElementPtrInst *GEP = 2821 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 2822 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 2823 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 2824 !cast<LoadInst>(LHSI)->isVolatile()) 2825 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 2826 return Res; 2827 } 2828 break; 2829 } 2830 2831 return nullptr; 2832 } 2833 2834 /// Try to fold icmp (binop), X or icmp X, (binop). 2835 /// TODO: A large part of this logic is duplicated in InstSimplify's 2836 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 2837 /// duplication. 2838 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) { 2839 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2840 2841 // Special logic for binary operators. 2842 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 2843 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 2844 if (!BO0 && !BO1) 2845 return nullptr; 2846 2847 const CmpInst::Predicate Pred = I.getPredicate(); 2848 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 2849 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 2850 NoOp0WrapProblem = 2851 ICmpInst::isEquality(Pred) || 2852 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 2853 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 2854 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 2855 NoOp1WrapProblem = 2856 ICmpInst::isEquality(Pred) || 2857 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 2858 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 2859 2860 // Analyze the case when either Op0 or Op1 is an add instruction. 2861 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 2862 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 2863 if (BO0 && BO0->getOpcode() == Instruction::Add) { 2864 A = BO0->getOperand(0); 2865 B = BO0->getOperand(1); 2866 } 2867 if (BO1 && BO1->getOpcode() == Instruction::Add) { 2868 C = BO1->getOperand(0); 2869 D = BO1->getOperand(1); 2870 } 2871 2872 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow. 2873 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 2874 return new ICmpInst(Pred, A == Op1 ? B : A, 2875 Constant::getNullValue(Op1->getType())); 2876 2877 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow. 2878 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 2879 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 2880 C == Op0 ? D : C); 2881 2882 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow. 2883 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 2884 NoOp1WrapProblem && 2885 // Try not to increase register pressure. 2886 BO0->hasOneUse() && BO1->hasOneUse()) { 2887 // Determine Y and Z in the form icmp (X+Y), (X+Z). 2888 Value *Y, *Z; 2889 if (A == C) { 2890 // C + B == C + D -> B == D 2891 Y = B; 2892 Z = D; 2893 } else if (A == D) { 2894 // D + B == C + D -> B == C 2895 Y = B; 2896 Z = C; 2897 } else if (B == C) { 2898 // A + C == C + D -> A == D 2899 Y = A; 2900 Z = D; 2901 } else { 2902 assert(B == D); 2903 // A + D == C + D -> A == C 2904 Y = A; 2905 Z = C; 2906 } 2907 return new ICmpInst(Pred, Y, Z); 2908 } 2909 2910 // icmp slt (X + -1), Y -> icmp sle X, Y 2911 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 2912 match(B, m_AllOnes())) 2913 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 2914 2915 // icmp sge (X + -1), Y -> icmp sgt X, Y 2916 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 2917 match(B, m_AllOnes())) 2918 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 2919 2920 // icmp sle (X + 1), Y -> icmp slt X, Y 2921 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 2922 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 2923 2924 // icmp sgt (X + 1), Y -> icmp sge X, Y 2925 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 2926 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 2927 2928 // icmp sgt X, (Y + -1) -> icmp sge X, Y 2929 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 2930 match(D, m_AllOnes())) 2931 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 2932 2933 // icmp sle X, (Y + -1) -> icmp slt X, Y 2934 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 2935 match(D, m_AllOnes())) 2936 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 2937 2938 // icmp sge X, (Y + 1) -> icmp sgt X, Y 2939 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 2940 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 2941 2942 // icmp slt X, (Y + 1) -> icmp sle X, Y 2943 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 2944 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 2945 2946 // TODO: The subtraction-related identities shown below also hold, but 2947 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 2948 // wouldn't happen even if they were implemented. 2949 // 2950 // icmp ult (X - 1), Y -> icmp ule X, Y 2951 // icmp uge (X - 1), Y -> icmp ugt X, Y 2952 // icmp ugt X, (Y - 1) -> icmp uge X, Y 2953 // icmp ule X, (Y - 1) -> icmp ult X, Y 2954 2955 // icmp ule (X + 1), Y -> icmp ult X, Y 2956 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 2957 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 2958 2959 // icmp ugt (X + 1), Y -> icmp uge X, Y 2960 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 2961 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 2962 2963 // icmp uge X, (Y + 1) -> icmp ugt X, Y 2964 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 2965 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 2966 2967 // icmp ult X, (Y + 1) -> icmp ule X, Y 2968 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 2969 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 2970 2971 // if C1 has greater magnitude than C2: 2972 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y 2973 // s.t. C3 = C1 - C2 2974 // 2975 // if C2 has greater magnitude than C1: 2976 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3) 2977 // s.t. C3 = C2 - C1 2978 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 2979 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 2980 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 2981 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 2982 const APInt &AP1 = C1->getValue(); 2983 const APInt &AP2 = C2->getValue(); 2984 if (AP1.isNegative() == AP2.isNegative()) { 2985 APInt AP1Abs = C1->getValue().abs(); 2986 APInt AP2Abs = C2->getValue().abs(); 2987 if (AP1Abs.uge(AP2Abs)) { 2988 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 2989 Value *NewAdd = Builder.CreateNSWAdd(A, C3); 2990 return new ICmpInst(Pred, NewAdd, C); 2991 } else { 2992 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 2993 Value *NewAdd = Builder.CreateNSWAdd(C, C3); 2994 return new ICmpInst(Pred, A, NewAdd); 2995 } 2996 } 2997 } 2998 2999 // Analyze the case when either Op0 or Op1 is a sub instruction. 3000 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 3001 A = nullptr; 3002 B = nullptr; 3003 C = nullptr; 3004 D = nullptr; 3005 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 3006 A = BO0->getOperand(0); 3007 B = BO0->getOperand(1); 3008 } 3009 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 3010 C = BO1->getOperand(0); 3011 D = BO1->getOperand(1); 3012 } 3013 3014 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow. 3015 if (A == Op1 && NoOp0WrapProblem) 3016 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 3017 3018 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow. 3019 if (C == Op0 && NoOp1WrapProblem) 3020 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 3021 3022 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow. 3023 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem && 3024 // Try not to increase register pressure. 3025 BO0->hasOneUse() && BO1->hasOneUse()) 3026 return new ICmpInst(Pred, A, C); 3027 3028 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow. 3029 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem && 3030 // Try not to increase register pressure. 3031 BO0->hasOneUse() && BO1->hasOneUse()) 3032 return new ICmpInst(Pred, D, B); 3033 3034 // icmp (0-X) < cst --> x > -cst 3035 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 3036 Value *X; 3037 if (match(BO0, m_Neg(m_Value(X)))) 3038 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1)) 3039 if (!RHSC->isMinValue(/*isSigned=*/true)) 3040 return new ICmpInst(I.getSwappedPredicate(), X, 3041 ConstantExpr::getNeg(RHSC)); 3042 } 3043 3044 BinaryOperator *SRem = nullptr; 3045 // icmp (srem X, Y), Y 3046 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 3047 SRem = BO0; 3048 // icmp Y, (srem X, Y) 3049 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 3050 Op0 == BO1->getOperand(1)) 3051 SRem = BO1; 3052 if (SRem) { 3053 // We don't check hasOneUse to avoid increasing register pressure because 3054 // the value we use is the same value this instruction was already using. 3055 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 3056 default: 3057 break; 3058 case ICmpInst::ICMP_EQ: 3059 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3060 case ICmpInst::ICMP_NE: 3061 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3062 case ICmpInst::ICMP_SGT: 3063 case ICmpInst::ICMP_SGE: 3064 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 3065 Constant::getAllOnesValue(SRem->getType())); 3066 case ICmpInst::ICMP_SLT: 3067 case ICmpInst::ICMP_SLE: 3068 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 3069 Constant::getNullValue(SRem->getType())); 3070 } 3071 } 3072 3073 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 3074 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 3075 switch (BO0->getOpcode()) { 3076 default: 3077 break; 3078 case Instruction::Add: 3079 case Instruction::Sub: 3080 case Instruction::Xor: { 3081 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 3082 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3083 3084 const APInt *C; 3085 if (match(BO0->getOperand(1), m_APInt(C))) { 3086 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 3087 if (C->isSignMask()) { 3088 ICmpInst::Predicate NewPred = 3089 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3090 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3091 } 3092 3093 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 3094 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 3095 ICmpInst::Predicate NewPred = 3096 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3097 NewPred = I.getSwappedPredicate(NewPred); 3098 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3099 } 3100 } 3101 break; 3102 } 3103 case Instruction::Mul: { 3104 if (!I.isEquality()) 3105 break; 3106 3107 const APInt *C; 3108 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() && 3109 !C->isOneValue()) { 3110 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 3111 // Mask = -1 >> count-trailing-zeros(C). 3112 if (unsigned TZs = C->countTrailingZeros()) { 3113 Constant *Mask = ConstantInt::get( 3114 BO0->getType(), 3115 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 3116 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 3117 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 3118 return new ICmpInst(Pred, And1, And2); 3119 } 3120 // If there are no trailing zeros in the multiplier, just eliminate 3121 // the multiplies (no masking is needed): 3122 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y 3123 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3124 } 3125 break; 3126 } 3127 case Instruction::UDiv: 3128 case Instruction::LShr: 3129 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 3130 break; 3131 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3132 3133 case Instruction::SDiv: 3134 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 3135 break; 3136 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3137 3138 case Instruction::AShr: 3139 if (!BO0->isExact() || !BO1->isExact()) 3140 break; 3141 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3142 3143 case Instruction::Shl: { 3144 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 3145 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 3146 if (!NUW && !NSW) 3147 break; 3148 if (!NSW && I.isSigned()) 3149 break; 3150 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3151 } 3152 } 3153 } 3154 3155 if (BO0) { 3156 // Transform A & (L - 1) `ult` L --> L != 0 3157 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 3158 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 3159 3160 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 3161 auto *Zero = Constant::getNullValue(BO0->getType()); 3162 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 3163 } 3164 } 3165 3166 return nullptr; 3167 } 3168 3169 /// Fold icmp Pred min|max(X, Y), X. 3170 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 3171 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3172 Value *Op0 = Cmp.getOperand(0); 3173 Value *X = Cmp.getOperand(1); 3174 3175 // Canonicalize minimum or maximum operand to LHS of the icmp. 3176 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 3177 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 3178 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 3179 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 3180 std::swap(Op0, X); 3181 Pred = Cmp.getSwappedPredicate(); 3182 } 3183 3184 Value *Y; 3185 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 3186 // smin(X, Y) == X --> X s<= Y 3187 // smin(X, Y) s>= X --> X s<= Y 3188 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 3189 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 3190 3191 // smin(X, Y) != X --> X s> Y 3192 // smin(X, Y) s< X --> X s> Y 3193 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 3194 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 3195 3196 // These cases should be handled in InstSimplify: 3197 // smin(X, Y) s<= X --> true 3198 // smin(X, Y) s> X --> false 3199 return nullptr; 3200 } 3201 3202 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 3203 // smax(X, Y) == X --> X s>= Y 3204 // smax(X, Y) s<= X --> X s>= Y 3205 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 3206 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 3207 3208 // smax(X, Y) != X --> X s< Y 3209 // smax(X, Y) s> X --> X s< Y 3210 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 3211 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 3212 3213 // These cases should be handled in InstSimplify: 3214 // smax(X, Y) s>= X --> true 3215 // smax(X, Y) s< X --> false 3216 return nullptr; 3217 } 3218 3219 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 3220 // umin(X, Y) == X --> X u<= Y 3221 // umin(X, Y) u>= X --> X u<= Y 3222 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 3223 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 3224 3225 // umin(X, Y) != X --> X u> Y 3226 // umin(X, Y) u< X --> X u> Y 3227 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 3228 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 3229 3230 // These cases should be handled in InstSimplify: 3231 // umin(X, Y) u<= X --> true 3232 // umin(X, Y) u> X --> false 3233 return nullptr; 3234 } 3235 3236 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 3237 // umax(X, Y) == X --> X u>= Y 3238 // umax(X, Y) u<= X --> X u>= Y 3239 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 3240 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 3241 3242 // umax(X, Y) != X --> X u< Y 3243 // umax(X, Y) u> X --> X u< Y 3244 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 3245 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 3246 3247 // These cases should be handled in InstSimplify: 3248 // umax(X, Y) u>= X --> true 3249 // umax(X, Y) u< X --> false 3250 return nullptr; 3251 } 3252 3253 return nullptr; 3254 } 3255 3256 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 3257 if (!I.isEquality()) 3258 return nullptr; 3259 3260 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3261 const CmpInst::Predicate Pred = I.getPredicate(); 3262 Value *A, *B, *C, *D; 3263 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 3264 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 3265 Value *OtherVal = A == Op1 ? B : A; 3266 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 3267 } 3268 3269 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 3270 // A^c1 == C^c2 --> A == C^(c1^c2) 3271 ConstantInt *C1, *C2; 3272 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 3273 Op1->hasOneUse()) { 3274 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 3275 Value *Xor = Builder.CreateXor(C, NC); 3276 return new ICmpInst(Pred, A, Xor); 3277 } 3278 3279 // A^B == A^D -> B == D 3280 if (A == C) 3281 return new ICmpInst(Pred, B, D); 3282 if (A == D) 3283 return new ICmpInst(Pred, B, C); 3284 if (B == C) 3285 return new ICmpInst(Pred, A, D); 3286 if (B == D) 3287 return new ICmpInst(Pred, A, C); 3288 } 3289 } 3290 3291 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 3292 // A == (A^B) -> B == 0 3293 Value *OtherVal = A == Op0 ? B : A; 3294 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 3295 } 3296 3297 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 3298 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 3299 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 3300 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 3301 3302 if (A == C) { 3303 X = B; 3304 Y = D; 3305 Z = A; 3306 } else if (A == D) { 3307 X = B; 3308 Y = C; 3309 Z = A; 3310 } else if (B == C) { 3311 X = A; 3312 Y = D; 3313 Z = B; 3314 } else if (B == D) { 3315 X = A; 3316 Y = C; 3317 Z = B; 3318 } 3319 3320 if (X) { // Build (X^Y) & Z 3321 Op1 = Builder.CreateXor(X, Y); 3322 Op1 = Builder.CreateAnd(Op1, Z); 3323 I.setOperand(0, Op1); 3324 I.setOperand(1, Constant::getNullValue(Op1->getType())); 3325 return &I; 3326 } 3327 } 3328 3329 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 3330 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 3331 ConstantInt *Cst1; 3332 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 3333 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 3334 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 3335 match(Op1, m_ZExt(m_Value(A))))) { 3336 APInt Pow2 = Cst1->getValue() + 1; 3337 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 3338 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 3339 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 3340 } 3341 3342 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 3343 // For lshr and ashr pairs. 3344 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 3345 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 3346 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 3347 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 3348 unsigned TypeBits = Cst1->getBitWidth(); 3349 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3350 if (ShAmt < TypeBits && ShAmt != 0) { 3351 ICmpInst::Predicate NewPred = 3352 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 3353 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 3354 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 3355 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 3356 } 3357 } 3358 3359 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 3360 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 3361 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 3362 unsigned TypeBits = Cst1->getBitWidth(); 3363 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3364 if (ShAmt < TypeBits && ShAmt != 0) { 3365 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 3366 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 3367 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 3368 I.getName() + ".mask"); 3369 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 3370 } 3371 } 3372 3373 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 3374 // "icmp (and X, mask), cst" 3375 uint64_t ShAmt = 0; 3376 if (Op0->hasOneUse() && 3377 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 3378 match(Op1, m_ConstantInt(Cst1)) && 3379 // Only do this when A has multiple uses. This is most important to do 3380 // when it exposes other optimizations. 3381 !A->hasOneUse()) { 3382 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 3383 3384 if (ShAmt < ASize) { 3385 APInt MaskV = 3386 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 3387 MaskV <<= ShAmt; 3388 3389 APInt CmpV = Cst1->getValue().zext(ASize); 3390 CmpV <<= ShAmt; 3391 3392 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 3393 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 3394 } 3395 } 3396 3397 // If both operands are byte-swapped or bit-reversed, just compare the 3398 // original values. 3399 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant() 3400 // and handle more intrinsics. 3401 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) || 3402 (match(Op0, m_BitReverse(m_Value(A))) && 3403 match(Op1, m_BitReverse(m_Value(B))))) 3404 return new ICmpInst(Pred, A, B); 3405 3406 return nullptr; 3407 } 3408 3409 /// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so 3410 /// far. 3411 Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) { 3412 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0)); 3413 Value *LHSCIOp = LHSCI->getOperand(0); 3414 Type *SrcTy = LHSCIOp->getType(); 3415 Type *DestTy = LHSCI->getType(); 3416 Value *RHSCIOp; 3417 3418 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 3419 // integer type is the same size as the pointer type. 3420 if (LHSCI->getOpcode() == Instruction::PtrToInt && 3421 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) { 3422 Value *RHSOp = nullptr; 3423 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 3424 Value *RHSCIOp = RHSC->getOperand(0); 3425 if (RHSCIOp->getType()->getPointerAddressSpace() == 3426 LHSCIOp->getType()->getPointerAddressSpace()) { 3427 RHSOp = RHSC->getOperand(0); 3428 // If the pointer types don't match, insert a bitcast. 3429 if (LHSCIOp->getType() != RHSOp->getType()) 3430 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType()); 3431 } 3432 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 3433 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy); 3434 } 3435 3436 if (RHSOp) 3437 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp); 3438 } 3439 3440 // The code below only handles extension cast instructions, so far. 3441 // Enforce this. 3442 if (LHSCI->getOpcode() != Instruction::ZExt && 3443 LHSCI->getOpcode() != Instruction::SExt) 3444 return nullptr; 3445 3446 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt; 3447 bool isSignedCmp = ICmp.isSigned(); 3448 3449 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) { 3450 // Not an extension from the same type? 3451 RHSCIOp = CI->getOperand(0); 3452 if (RHSCIOp->getType() != LHSCIOp->getType()) 3453 return nullptr; 3454 3455 // If the signedness of the two casts doesn't agree (i.e. one is a sext 3456 // and the other is a zext), then we can't handle this. 3457 if (CI->getOpcode() != LHSCI->getOpcode()) 3458 return nullptr; 3459 3460 // Deal with equality cases early. 3461 if (ICmp.isEquality()) 3462 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3463 3464 // A signed comparison of sign extended values simplifies into a 3465 // signed comparison. 3466 if (isSignedCmp && isSignedExt) 3467 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3468 3469 // The other three cases all fold into an unsigned comparison. 3470 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp); 3471 } 3472 3473 // If we aren't dealing with a constant on the RHS, exit early. 3474 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 3475 if (!C) 3476 return nullptr; 3477 3478 // Compute the constant that would happen if we truncated to SrcTy then 3479 // re-extended to DestTy. 3480 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 3481 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy); 3482 3483 // If the re-extended constant didn't change... 3484 if (Res2 == C) { 3485 // Deal with equality cases early. 3486 if (ICmp.isEquality()) 3487 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3488 3489 // A signed comparison of sign extended values simplifies into a 3490 // signed comparison. 3491 if (isSignedExt && isSignedCmp) 3492 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3493 3494 // The other three cases all fold into an unsigned comparison. 3495 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1); 3496 } 3497 3498 // The re-extended constant changed, partly changed (in the case of a vector), 3499 // or could not be determined to be equal (in the case of a constant 3500 // expression), so the constant cannot be represented in the shorter type. 3501 // Consequently, we cannot emit a simple comparison. 3502 // All the cases that fold to true or false will have already been handled 3503 // by SimplifyICmpInst, so only deal with the tricky case. 3504 3505 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C)) 3506 return nullptr; 3507 3508 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases 3509 // should have been folded away previously and not enter in here. 3510 3511 // We're performing an unsigned comp with a sign extended value. 3512 // This is true if the input is >= 0. [aka >s -1] 3513 Constant *NegOne = Constant::getAllOnesValue(SrcTy); 3514 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName()); 3515 3516 // Finally, return the value computed. 3517 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 3518 return replaceInstUsesWith(ICmp, Result); 3519 3520 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 3521 return BinaryOperator::CreateNot(Result); 3522 } 3523 3524 bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS, 3525 Value *RHS, Instruction &OrigI, 3526 Value *&Result, Constant *&Overflow) { 3527 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 3528 std::swap(LHS, RHS); 3529 3530 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) { 3531 Result = OpResult; 3532 Overflow = OverflowVal; 3533 if (ReuseName) 3534 Result->takeName(&OrigI); 3535 return true; 3536 }; 3537 3538 // If the overflow check was an add followed by a compare, the insertion point 3539 // may be pointing to the compare. We want to insert the new instructions 3540 // before the add in case there are uses of the add between the add and the 3541 // compare. 3542 Builder.SetInsertPoint(&OrigI); 3543 3544 switch (OCF) { 3545 case OCF_INVALID: 3546 llvm_unreachable("bad overflow check kind!"); 3547 3548 case OCF_UNSIGNED_ADD: { 3549 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI); 3550 if (OR == OverflowResult::NeverOverflows) 3551 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(), 3552 true); 3553 3554 if (OR == OverflowResult::AlwaysOverflows) 3555 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true); 3556 3557 // Fall through uadd into sadd 3558 LLVM_FALLTHROUGH; 3559 } 3560 case OCF_SIGNED_ADD: { 3561 // X + 0 -> {X, false} 3562 if (match(RHS, m_Zero())) 3563 return SetResult(LHS, Builder.getFalse(), false); 3564 3565 // We can strength reduce this signed add into a regular add if we can prove 3566 // that it will never overflow. 3567 if (OCF == OCF_SIGNED_ADD) 3568 if (willNotOverflowSignedAdd(LHS, RHS, OrigI)) 3569 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(), 3570 true); 3571 break; 3572 } 3573 3574 case OCF_UNSIGNED_SUB: 3575 case OCF_SIGNED_SUB: { 3576 // X - 0 -> {X, false} 3577 if (match(RHS, m_Zero())) 3578 return SetResult(LHS, Builder.getFalse(), false); 3579 3580 if (OCF == OCF_SIGNED_SUB) { 3581 if (willNotOverflowSignedSub(LHS, RHS, OrigI)) 3582 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(), 3583 true); 3584 } else { 3585 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI)) 3586 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(), 3587 true); 3588 } 3589 break; 3590 } 3591 3592 case OCF_UNSIGNED_MUL: { 3593 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI); 3594 if (OR == OverflowResult::NeverOverflows) 3595 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(), 3596 true); 3597 if (OR == OverflowResult::AlwaysOverflows) 3598 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true); 3599 LLVM_FALLTHROUGH; 3600 } 3601 case OCF_SIGNED_MUL: 3602 // X * undef -> undef 3603 if (isa<UndefValue>(RHS)) 3604 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false); 3605 3606 // X * 0 -> {0, false} 3607 if (match(RHS, m_Zero())) 3608 return SetResult(RHS, Builder.getFalse(), false); 3609 3610 // X * 1 -> {X, false} 3611 if (match(RHS, m_One())) 3612 return SetResult(LHS, Builder.getFalse(), false); 3613 3614 if (OCF == OCF_SIGNED_MUL) 3615 if (willNotOverflowSignedMul(LHS, RHS, OrigI)) 3616 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(), 3617 true); 3618 break; 3619 } 3620 3621 return false; 3622 } 3623 3624 /// \brief Recognize and process idiom involving test for multiplication 3625 /// overflow. 3626 /// 3627 /// The caller has matched a pattern of the form: 3628 /// I = cmp u (mul(zext A, zext B), V 3629 /// The function checks if this is a test for overflow and if so replaces 3630 /// multiplication with call to 'mul.with.overflow' intrinsic. 3631 /// 3632 /// \param I Compare instruction. 3633 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 3634 /// the compare instruction. Must be of integer type. 3635 /// \param OtherVal The other argument of compare instruction. 3636 /// \returns Instruction which must replace the compare instruction, NULL if no 3637 /// replacement required. 3638 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 3639 Value *OtherVal, InstCombiner &IC) { 3640 // Don't bother doing this transformation for pointers, don't do it for 3641 // vectors. 3642 if (!isa<IntegerType>(MulVal->getType())) 3643 return nullptr; 3644 3645 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 3646 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 3647 auto *MulInstr = dyn_cast<Instruction>(MulVal); 3648 if (!MulInstr) 3649 return nullptr; 3650 assert(MulInstr->getOpcode() == Instruction::Mul); 3651 3652 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 3653 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 3654 assert(LHS->getOpcode() == Instruction::ZExt); 3655 assert(RHS->getOpcode() == Instruction::ZExt); 3656 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 3657 3658 // Calculate type and width of the result produced by mul.with.overflow. 3659 Type *TyA = A->getType(), *TyB = B->getType(); 3660 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 3661 WidthB = TyB->getPrimitiveSizeInBits(); 3662 unsigned MulWidth; 3663 Type *MulType; 3664 if (WidthB > WidthA) { 3665 MulWidth = WidthB; 3666 MulType = TyB; 3667 } else { 3668 MulWidth = WidthA; 3669 MulType = TyA; 3670 } 3671 3672 // In order to replace the original mul with a narrower mul.with.overflow, 3673 // all uses must ignore upper bits of the product. The number of used low 3674 // bits must be not greater than the width of mul.with.overflow. 3675 if (MulVal->hasNUsesOrMore(2)) 3676 for (User *U : MulVal->users()) { 3677 if (U == &I) 3678 continue; 3679 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3680 // Check if truncation ignores bits above MulWidth. 3681 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 3682 if (TruncWidth > MulWidth) 3683 return nullptr; 3684 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3685 // Check if AND ignores bits above MulWidth. 3686 if (BO->getOpcode() != Instruction::And) 3687 return nullptr; 3688 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 3689 const APInt &CVal = CI->getValue(); 3690 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 3691 return nullptr; 3692 } else { 3693 // In this case we could have the operand of the binary operation 3694 // being defined in another block, and performing the replacement 3695 // could break the dominance relation. 3696 return nullptr; 3697 } 3698 } else { 3699 // Other uses prohibit this transformation. 3700 return nullptr; 3701 } 3702 } 3703 3704 // Recognize patterns 3705 switch (I.getPredicate()) { 3706 case ICmpInst::ICMP_EQ: 3707 case ICmpInst::ICMP_NE: 3708 // Recognize pattern: 3709 // mulval = mul(zext A, zext B) 3710 // cmp eq/neq mulval, zext trunc mulval 3711 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 3712 if (Zext->hasOneUse()) { 3713 Value *ZextArg = Zext->getOperand(0); 3714 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 3715 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 3716 break; //Recognized 3717 } 3718 3719 // Recognize pattern: 3720 // mulval = mul(zext A, zext B) 3721 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 3722 ConstantInt *CI; 3723 Value *ValToMask; 3724 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 3725 if (ValToMask != MulVal) 3726 return nullptr; 3727 const APInt &CVal = CI->getValue() + 1; 3728 if (CVal.isPowerOf2()) { 3729 unsigned MaskWidth = CVal.logBase2(); 3730 if (MaskWidth == MulWidth) 3731 break; // Recognized 3732 } 3733 } 3734 return nullptr; 3735 3736 case ICmpInst::ICMP_UGT: 3737 // Recognize pattern: 3738 // mulval = mul(zext A, zext B) 3739 // cmp ugt mulval, max 3740 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3741 APInt MaxVal = APInt::getMaxValue(MulWidth); 3742 MaxVal = MaxVal.zext(CI->getBitWidth()); 3743 if (MaxVal.eq(CI->getValue())) 3744 break; // Recognized 3745 } 3746 return nullptr; 3747 3748 case ICmpInst::ICMP_UGE: 3749 // Recognize pattern: 3750 // mulval = mul(zext A, zext B) 3751 // cmp uge mulval, max+1 3752 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3753 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3754 if (MaxVal.eq(CI->getValue())) 3755 break; // Recognized 3756 } 3757 return nullptr; 3758 3759 case ICmpInst::ICMP_ULE: 3760 // Recognize pattern: 3761 // mulval = mul(zext A, zext B) 3762 // cmp ule mulval, max 3763 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3764 APInt MaxVal = APInt::getMaxValue(MulWidth); 3765 MaxVal = MaxVal.zext(CI->getBitWidth()); 3766 if (MaxVal.eq(CI->getValue())) 3767 break; // Recognized 3768 } 3769 return nullptr; 3770 3771 case ICmpInst::ICMP_ULT: 3772 // Recognize pattern: 3773 // mulval = mul(zext A, zext B) 3774 // cmp ule mulval, max + 1 3775 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3776 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3777 if (MaxVal.eq(CI->getValue())) 3778 break; // Recognized 3779 } 3780 return nullptr; 3781 3782 default: 3783 return nullptr; 3784 } 3785 3786 InstCombiner::BuilderTy &Builder = IC.Builder; 3787 Builder.SetInsertPoint(MulInstr); 3788 3789 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 3790 Value *MulA = A, *MulB = B; 3791 if (WidthA < MulWidth) 3792 MulA = Builder.CreateZExt(A, MulType); 3793 if (WidthB < MulWidth) 3794 MulB = Builder.CreateZExt(B, MulType); 3795 Value *F = Intrinsic::getDeclaration(I.getModule(), 3796 Intrinsic::umul_with_overflow, MulType); 3797 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 3798 IC.Worklist.Add(MulInstr); 3799 3800 // If there are uses of mul result other than the comparison, we know that 3801 // they are truncation or binary AND. Change them to use result of 3802 // mul.with.overflow and adjust properly mask/size. 3803 if (MulVal->hasNUsesOrMore(2)) { 3804 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 3805 for (User *U : MulVal->users()) { 3806 if (U == &I || U == OtherVal) 3807 continue; 3808 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3809 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 3810 IC.replaceInstUsesWith(*TI, Mul); 3811 else 3812 TI->setOperand(0, Mul); 3813 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3814 assert(BO->getOpcode() == Instruction::And); 3815 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 3816 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 3817 APInt ShortMask = CI->getValue().trunc(MulWidth); 3818 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 3819 Instruction *Zext = 3820 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType())); 3821 IC.Worklist.Add(Zext); 3822 IC.replaceInstUsesWith(*BO, Zext); 3823 } else { 3824 llvm_unreachable("Unexpected Binary operation"); 3825 } 3826 IC.Worklist.Add(cast<Instruction>(U)); 3827 } 3828 } 3829 if (isa<Instruction>(OtherVal)) 3830 IC.Worklist.Add(cast<Instruction>(OtherVal)); 3831 3832 // The original icmp gets replaced with the overflow value, maybe inverted 3833 // depending on predicate. 3834 bool Inverse = false; 3835 switch (I.getPredicate()) { 3836 case ICmpInst::ICMP_NE: 3837 break; 3838 case ICmpInst::ICMP_EQ: 3839 Inverse = true; 3840 break; 3841 case ICmpInst::ICMP_UGT: 3842 case ICmpInst::ICMP_UGE: 3843 if (I.getOperand(0) == MulVal) 3844 break; 3845 Inverse = true; 3846 break; 3847 case ICmpInst::ICMP_ULT: 3848 case ICmpInst::ICMP_ULE: 3849 if (I.getOperand(1) == MulVal) 3850 break; 3851 Inverse = true; 3852 break; 3853 default: 3854 llvm_unreachable("Unexpected predicate"); 3855 } 3856 if (Inverse) { 3857 Value *Res = Builder.CreateExtractValue(Call, 1); 3858 return BinaryOperator::CreateNot(Res); 3859 } 3860 3861 return ExtractValueInst::Create(Call, 1); 3862 } 3863 3864 /// When performing a comparison against a constant, it is possible that not all 3865 /// the bits in the LHS are demanded. This helper method computes the mask that 3866 /// IS demanded. 3867 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 3868 const APInt *RHS; 3869 if (!match(I.getOperand(1), m_APInt(RHS))) 3870 return APInt::getAllOnesValue(BitWidth); 3871 3872 // If this is a normal comparison, it demands all bits. If it is a sign bit 3873 // comparison, it only demands the sign bit. 3874 bool UnusedBit; 3875 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 3876 return APInt::getSignMask(BitWidth); 3877 3878 switch (I.getPredicate()) { 3879 // For a UGT comparison, we don't care about any bits that 3880 // correspond to the trailing ones of the comparand. The value of these 3881 // bits doesn't impact the outcome of the comparison, because any value 3882 // greater than the RHS must differ in a bit higher than these due to carry. 3883 case ICmpInst::ICMP_UGT: 3884 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 3885 3886 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 3887 // Any value less than the RHS must differ in a higher bit because of carries. 3888 case ICmpInst::ICMP_ULT: 3889 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 3890 3891 default: 3892 return APInt::getAllOnesValue(BitWidth); 3893 } 3894 } 3895 3896 /// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst 3897 /// should be swapped. 3898 /// The decision is based on how many times these two operands are reused 3899 /// as subtract operands and their positions in those instructions. 3900 /// The rational is that several architectures use the same instruction for 3901 /// both subtract and cmp, thus it is better if the order of those operands 3902 /// match. 3903 /// \return true if Op0 and Op1 should be swapped. 3904 static bool swapMayExposeCSEOpportunities(const Value * Op0, 3905 const Value * Op1) { 3906 // Filter out pointer value as those cannot appears directly in subtract. 3907 // FIXME: we may want to go through inttoptrs or bitcasts. 3908 if (Op0->getType()->isPointerTy()) 3909 return false; 3910 // Count every uses of both Op0 and Op1 in a subtract. 3911 // Each time Op0 is the first operand, count -1: swapping is bad, the 3912 // subtract has already the same layout as the compare. 3913 // Each time Op0 is the second operand, count +1: swapping is good, the 3914 // subtract has a different layout as the compare. 3915 // At the end, if the benefit is greater than 0, Op0 should come second to 3916 // expose more CSE opportunities. 3917 int GlobalSwapBenefits = 0; 3918 for (const User *U : Op0->users()) { 3919 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U); 3920 if (!BinOp || BinOp->getOpcode() != Instruction::Sub) 3921 continue; 3922 // If Op0 is the first argument, this is not beneficial to swap the 3923 // arguments. 3924 int LocalSwapBenefits = -1; 3925 unsigned Op1Idx = 1; 3926 if (BinOp->getOperand(Op1Idx) == Op0) { 3927 Op1Idx = 0; 3928 LocalSwapBenefits = 1; 3929 } 3930 if (BinOp->getOperand(Op1Idx) != Op1) 3931 continue; 3932 GlobalSwapBenefits += LocalSwapBenefits; 3933 } 3934 return GlobalSwapBenefits > 0; 3935 } 3936 3937 /// \brief Check that one use is in the same block as the definition and all 3938 /// other uses are in blocks dominated by a given block. 3939 /// 3940 /// \param DI Definition 3941 /// \param UI Use 3942 /// \param DB Block that must dominate all uses of \p DI outside 3943 /// the parent block 3944 /// \return true when \p UI is the only use of \p DI in the parent block 3945 /// and all other uses of \p DI are in blocks dominated by \p DB. 3946 /// 3947 bool InstCombiner::dominatesAllUses(const Instruction *DI, 3948 const Instruction *UI, 3949 const BasicBlock *DB) const { 3950 assert(DI && UI && "Instruction not defined\n"); 3951 // Ignore incomplete definitions. 3952 if (!DI->getParent()) 3953 return false; 3954 // DI and UI must be in the same block. 3955 if (DI->getParent() != UI->getParent()) 3956 return false; 3957 // Protect from self-referencing blocks. 3958 if (DI->getParent() == DB) 3959 return false; 3960 for (const User *U : DI->users()) { 3961 auto *Usr = cast<Instruction>(U); 3962 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 3963 return false; 3964 } 3965 return true; 3966 } 3967 3968 /// Return true when the instruction sequence within a block is select-cmp-br. 3969 static bool isChainSelectCmpBranch(const SelectInst *SI) { 3970 const BasicBlock *BB = SI->getParent(); 3971 if (!BB) 3972 return false; 3973 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 3974 if (!BI || BI->getNumSuccessors() != 2) 3975 return false; 3976 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 3977 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 3978 return false; 3979 return true; 3980 } 3981 3982 /// \brief True when a select result is replaced by one of its operands 3983 /// in select-icmp sequence. This will eventually result in the elimination 3984 /// of the select. 3985 /// 3986 /// \param SI Select instruction 3987 /// \param Icmp Compare instruction 3988 /// \param SIOpd Operand that replaces the select 3989 /// 3990 /// Notes: 3991 /// - The replacement is global and requires dominator information 3992 /// - The caller is responsible for the actual replacement 3993 /// 3994 /// Example: 3995 /// 3996 /// entry: 3997 /// %4 = select i1 %3, %C* %0, %C* null 3998 /// %5 = icmp eq %C* %4, null 3999 /// br i1 %5, label %9, label %7 4000 /// ... 4001 /// ; <label>:7 ; preds = %entry 4002 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 4003 /// ... 4004 /// 4005 /// can be transformed to 4006 /// 4007 /// %5 = icmp eq %C* %0, null 4008 /// %6 = select i1 %3, i1 %5, i1 true 4009 /// br i1 %6, label %9, label %7 4010 /// ... 4011 /// ; <label>:7 ; preds = %entry 4012 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 4013 /// 4014 /// Similar when the first operand of the select is a constant or/and 4015 /// the compare is for not equal rather than equal. 4016 /// 4017 /// NOTE: The function is only called when the select and compare constants 4018 /// are equal, the optimization can work only for EQ predicates. This is not a 4019 /// major restriction since a NE compare should be 'normalized' to an equal 4020 /// compare, which usually happens in the combiner and test case 4021 /// select-cmp-br.ll checks for it. 4022 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 4023 const ICmpInst *Icmp, 4024 const unsigned SIOpd) { 4025 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 4026 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 4027 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 4028 // The check for the single predecessor is not the best that can be 4029 // done. But it protects efficiently against cases like when SI's 4030 // home block has two successors, Succ and Succ1, and Succ1 predecessor 4031 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 4032 // replaced can be reached on either path. So the uniqueness check 4033 // guarantees that the path all uses of SI (outside SI's parent) are on 4034 // is disjoint from all other paths out of SI. But that information 4035 // is more expensive to compute, and the trade-off here is in favor 4036 // of compile-time. It should also be noticed that we check for a single 4037 // predecessor and not only uniqueness. This to handle the situation when 4038 // Succ and Succ1 points to the same basic block. 4039 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 4040 NumSel++; 4041 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 4042 return true; 4043 } 4044 } 4045 return false; 4046 } 4047 4048 /// Try to fold the comparison based on range information we can get by checking 4049 /// whether bits are known to be zero or one in the inputs. 4050 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 4051 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4052 Type *Ty = Op0->getType(); 4053 ICmpInst::Predicate Pred = I.getPredicate(); 4054 4055 // Get scalar or pointer size. 4056 unsigned BitWidth = Ty->isIntOrIntVectorTy() 4057 ? Ty->getScalarSizeInBits() 4058 : DL.getTypeSizeInBits(Ty->getScalarType()); 4059 4060 if (!BitWidth) 4061 return nullptr; 4062 4063 KnownBits Op0Known(BitWidth); 4064 KnownBits Op1Known(BitWidth); 4065 4066 if (SimplifyDemandedBits(&I, 0, 4067 getDemandedBitsLHSMask(I, BitWidth), 4068 Op0Known, 0)) 4069 return &I; 4070 4071 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth), 4072 Op1Known, 0)) 4073 return &I; 4074 4075 // Given the known and unknown bits, compute a range that the LHS could be 4076 // in. Compute the Min, Max and RHS values based on the known bits. For the 4077 // EQ and NE we use unsigned values. 4078 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 4079 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 4080 if (I.isSigned()) { 4081 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4082 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4083 } else { 4084 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4085 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4086 } 4087 4088 // If Min and Max are known to be the same, then SimplifyDemandedBits 4089 // figured out that the LHS is a constant. Constant fold this now, so that 4090 // code below can assume that Min != Max. 4091 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 4092 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1); 4093 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 4094 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min)); 4095 4096 // Based on the range information we know about the LHS, see if we can 4097 // simplify this comparison. For example, (x&4) < 8 is always true. 4098 switch (Pred) { 4099 default: 4100 llvm_unreachable("Unknown icmp opcode!"); 4101 case ICmpInst::ICMP_EQ: 4102 case ICmpInst::ICMP_NE: { 4103 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 4104 return Pred == CmpInst::ICMP_EQ 4105 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 4106 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4107 } 4108 4109 // If all bits are known zero except for one, then we know at most one bit 4110 // is set. If the comparison is against zero, then this is a check to see if 4111 // *that* bit is set. 4112 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 4113 if (Op1Known.isZero()) { 4114 // If the LHS is an AND with the same constant, look through it. 4115 Value *LHS = nullptr; 4116 const APInt *LHSC; 4117 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 4118 *LHSC != Op0KnownZeroInverted) 4119 LHS = Op0; 4120 4121 Value *X; 4122 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 4123 APInt ValToCheck = Op0KnownZeroInverted; 4124 Type *XTy = X->getType(); 4125 if (ValToCheck.isPowerOf2()) { 4126 // ((1 << X) & 8) == 0 -> X != 3 4127 // ((1 << X) & 8) != 0 -> X == 3 4128 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4129 auto NewPred = ICmpInst::getInversePredicate(Pred); 4130 return new ICmpInst(NewPred, X, CmpC); 4131 } else if ((++ValToCheck).isPowerOf2()) { 4132 // ((1 << X) & 7) == 0 -> X >= 3 4133 // ((1 << X) & 7) != 0 -> X < 3 4134 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4135 auto NewPred = 4136 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 4137 return new ICmpInst(NewPred, X, CmpC); 4138 } 4139 } 4140 4141 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 4142 const APInt *CI; 4143 if (Op0KnownZeroInverted.isOneValue() && 4144 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 4145 // ((8 >>u X) & 1) == 0 -> X != 3 4146 // ((8 >>u X) & 1) != 0 -> X == 3 4147 unsigned CmpVal = CI->countTrailingZeros(); 4148 auto NewPred = ICmpInst::getInversePredicate(Pred); 4149 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 4150 } 4151 } 4152 break; 4153 } 4154 case ICmpInst::ICMP_ULT: { 4155 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 4156 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4157 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 4158 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4159 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 4160 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4161 4162 const APInt *CmpC; 4163 if (match(Op1, m_APInt(CmpC))) { 4164 // A <u C -> A == C-1 if min(A)+1 == C 4165 if (*CmpC == Op0Min + 1) 4166 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4167 ConstantInt::get(Op1->getType(), *CmpC - 1)); 4168 // X <u C --> X == 0, if the number of zero bits in the bottom of X 4169 // exceeds the log2 of C. 4170 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 4171 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4172 Constant::getNullValue(Op1->getType())); 4173 } 4174 break; 4175 } 4176 case ICmpInst::ICMP_UGT: { 4177 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 4178 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4179 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 4180 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4181 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 4182 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4183 4184 const APInt *CmpC; 4185 if (match(Op1, m_APInt(CmpC))) { 4186 // A >u C -> A == C+1 if max(a)-1 == C 4187 if (*CmpC == Op0Max - 1) 4188 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4189 ConstantInt::get(Op1->getType(), *CmpC + 1)); 4190 // X >u C --> X != 0, if the number of zero bits in the bottom of X 4191 // exceeds the log2 of C. 4192 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 4193 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 4194 Constant::getNullValue(Op1->getType())); 4195 } 4196 break; 4197 } 4198 case ICmpInst::ICMP_SLT: { 4199 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 4200 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4201 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 4202 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4203 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 4204 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4205 const APInt *CmpC; 4206 if (match(Op1, m_APInt(CmpC))) { 4207 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 4208 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4209 ConstantInt::get(Op1->getType(), *CmpC - 1)); 4210 } 4211 break; 4212 } 4213 case ICmpInst::ICMP_SGT: { 4214 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 4215 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4216 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 4217 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4218 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 4219 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4220 const APInt *CmpC; 4221 if (match(Op1, m_APInt(CmpC))) { 4222 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 4223 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4224 ConstantInt::get(Op1->getType(), *CmpC + 1)); 4225 } 4226 break; 4227 } 4228 case ICmpInst::ICMP_SGE: 4229 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 4230 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 4231 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4232 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 4233 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4234 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 4235 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4236 break; 4237 case ICmpInst::ICMP_SLE: 4238 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 4239 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 4240 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4241 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 4242 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4243 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 4244 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4245 break; 4246 case ICmpInst::ICMP_UGE: 4247 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 4248 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 4249 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4250 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 4251 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4252 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 4253 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4254 break; 4255 case ICmpInst::ICMP_ULE: 4256 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 4257 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 4258 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4259 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 4260 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4261 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 4262 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4263 break; 4264 } 4265 4266 // Turn a signed comparison into an unsigned one if both operands are known to 4267 // have the same sign. 4268 if (I.isSigned() && 4269 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 4270 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 4271 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 4272 4273 return nullptr; 4274 } 4275 4276 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 4277 /// it into the appropriate icmp lt or icmp gt instruction. This transform 4278 /// allows them to be folded in visitICmpInst. 4279 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 4280 ICmpInst::Predicate Pred = I.getPredicate(); 4281 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE && 4282 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE) 4283 return nullptr; 4284 4285 Value *Op0 = I.getOperand(0); 4286 Value *Op1 = I.getOperand(1); 4287 auto *Op1C = dyn_cast<Constant>(Op1); 4288 if (!Op1C) 4289 return nullptr; 4290 4291 // Check if the constant operand can be safely incremented/decremented without 4292 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled 4293 // the edge cases for us, so we just assert on them. For vectors, we must 4294 // handle the edge cases. 4295 Type *Op1Type = Op1->getType(); 4296 bool IsSigned = I.isSigned(); 4297 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE); 4298 auto *CI = dyn_cast<ConstantInt>(Op1C); 4299 if (CI) { 4300 // A <= MAX -> TRUE ; A >= MIN -> TRUE 4301 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned)); 4302 } else if (Op1Type->isVectorTy()) { 4303 // TODO? If the edge cases for vectors were guaranteed to be handled as they 4304 // are for scalar, we could remove the min/max checks. However, to do that, 4305 // we would have to use insertelement/shufflevector to replace edge values. 4306 unsigned NumElts = Op1Type->getVectorNumElements(); 4307 for (unsigned i = 0; i != NumElts; ++i) { 4308 Constant *Elt = Op1C->getAggregateElement(i); 4309 if (!Elt) 4310 return nullptr; 4311 4312 if (isa<UndefValue>(Elt)) 4313 continue; 4314 4315 // Bail out if we can't determine if this constant is min/max or if we 4316 // know that this constant is min/max. 4317 auto *CI = dyn_cast<ConstantInt>(Elt); 4318 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned))) 4319 return nullptr; 4320 } 4321 } else { 4322 // ConstantExpr? 4323 return nullptr; 4324 } 4325 4326 // Increment or decrement the constant and set the new comparison predicate: 4327 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT 4328 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true); 4329 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT; 4330 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred; 4331 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne)); 4332 } 4333 4334 /// Integer compare with boolean values can always be turned into bitwise ops. 4335 static Instruction *canonicalizeICmpBool(ICmpInst &I, 4336 InstCombiner::BuilderTy &Builder) { 4337 Value *A = I.getOperand(0), *B = I.getOperand(1); 4338 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 4339 4340 // A boolean compared to true/false can be simplified to Op0/true/false in 4341 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 4342 // Cases not handled by InstSimplify are always 'not' of Op0. 4343 if (match(B, m_Zero())) { 4344 switch (I.getPredicate()) { 4345 case CmpInst::ICMP_EQ: // A == 0 -> !A 4346 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 4347 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 4348 return BinaryOperator::CreateNot(A); 4349 default: 4350 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 4351 } 4352 } else if (match(B, m_One())) { 4353 switch (I.getPredicate()) { 4354 case CmpInst::ICMP_NE: // A != 1 -> !A 4355 case CmpInst::ICMP_ULT: // A <u 1 -> !A 4356 case CmpInst::ICMP_SGT: // A >s -1 -> !A 4357 return BinaryOperator::CreateNot(A); 4358 default: 4359 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 4360 } 4361 } 4362 4363 switch (I.getPredicate()) { 4364 default: 4365 llvm_unreachable("Invalid icmp instruction!"); 4366 case ICmpInst::ICMP_EQ: 4367 // icmp eq i1 A, B -> ~(A ^ B) 4368 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 4369 4370 case ICmpInst::ICMP_NE: 4371 // icmp ne i1 A, B -> A ^ B 4372 return BinaryOperator::CreateXor(A, B); 4373 4374 case ICmpInst::ICMP_UGT: 4375 // icmp ugt -> icmp ult 4376 std::swap(A, B); 4377 LLVM_FALLTHROUGH; 4378 case ICmpInst::ICMP_ULT: 4379 // icmp ult i1 A, B -> ~A & B 4380 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 4381 4382 case ICmpInst::ICMP_SGT: 4383 // icmp sgt -> icmp slt 4384 std::swap(A, B); 4385 LLVM_FALLTHROUGH; 4386 case ICmpInst::ICMP_SLT: 4387 // icmp slt i1 A, B -> A & ~B 4388 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 4389 4390 case ICmpInst::ICMP_UGE: 4391 // icmp uge -> icmp ule 4392 std::swap(A, B); 4393 LLVM_FALLTHROUGH; 4394 case ICmpInst::ICMP_ULE: 4395 // icmp ule i1 A, B -> ~A | B 4396 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 4397 4398 case ICmpInst::ICMP_SGE: 4399 // icmp sge -> icmp sle 4400 std::swap(A, B); 4401 LLVM_FALLTHROUGH; 4402 case ICmpInst::ICMP_SLE: 4403 // icmp sle i1 A, B -> A | ~B 4404 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 4405 } 4406 } 4407 4408 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 4409 bool Changed = false; 4410 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4411 unsigned Op0Cplxity = getComplexity(Op0); 4412 unsigned Op1Cplxity = getComplexity(Op1); 4413 4414 /// Orders the operands of the compare so that they are listed from most 4415 /// complex to least complex. This puts constants before unary operators, 4416 /// before binary operators. 4417 if (Op0Cplxity < Op1Cplxity || 4418 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 4419 I.swapOperands(); 4420 std::swap(Op0, Op1); 4421 Changed = true; 4422 } 4423 4424 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, 4425 SQ.getWithInstruction(&I))) 4426 return replaceInstUsesWith(I, V); 4427 4428 // Comparing -val or val with non-zero is the same as just comparing val 4429 // ie, abs(val) != 0 -> val != 0 4430 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 4431 Value *Cond, *SelectTrue, *SelectFalse; 4432 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 4433 m_Value(SelectFalse)))) { 4434 if (Value *V = dyn_castNegVal(SelectTrue)) { 4435 if (V == SelectFalse) 4436 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4437 } 4438 else if (Value *V = dyn_castNegVal(SelectFalse)) { 4439 if (V == SelectTrue) 4440 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4441 } 4442 } 4443 } 4444 4445 if (Op0->getType()->isIntOrIntVectorTy(1)) 4446 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 4447 return Res; 4448 4449 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 4450 return NewICmp; 4451 4452 if (Instruction *Res = foldICmpWithConstant(I)) 4453 return Res; 4454 4455 if (Instruction *Res = foldICmpUsingKnownBits(I)) 4456 return Res; 4457 4458 // Test if the ICmpInst instruction is used exclusively by a select as 4459 // part of a minimum or maximum operation. If so, refrain from doing 4460 // any other folding. This helps out other analyses which understand 4461 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4462 // and CodeGen. And in this case, at least one of the comparison 4463 // operands has at least one user besides the compare (the select), 4464 // which would often largely negate the benefit of folding anyway. 4465 if (I.hasOneUse()) 4466 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4467 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4468 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4469 return nullptr; 4470 4471 // Do this after checking for min/max to prevent infinite looping. 4472 if (Instruction *Res = foldICmpWithZero(I)) 4473 return Res; 4474 4475 // FIXME: We only do this after checking for min/max to prevent infinite 4476 // looping caused by a reverse canonicalization of these patterns for min/max. 4477 // FIXME: The organization of folds is a mess. These would naturally go into 4478 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 4479 // down here after the min/max restriction. 4480 ICmpInst::Predicate Pred = I.getPredicate(); 4481 const APInt *C; 4482 if (match(Op1, m_APInt(C))) { 4483 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 4484 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 4485 Constant *Zero = Constant::getNullValue(Op0->getType()); 4486 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 4487 } 4488 4489 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 4490 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 4491 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 4492 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 4493 } 4494 } 4495 4496 if (Instruction *Res = foldICmpInstWithConstant(I)) 4497 return Res; 4498 4499 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 4500 return Res; 4501 4502 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 4503 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 4504 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 4505 return NI; 4506 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 4507 if (Instruction *NI = foldGEPICmp(GEP, Op0, 4508 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 4509 return NI; 4510 4511 // Try to optimize equality comparisons against alloca-based pointers. 4512 if (Op0->getType()->isPointerTy() && I.isEquality()) { 4513 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 4514 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 4515 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 4516 return New; 4517 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 4518 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 4519 return New; 4520 } 4521 4522 // Test to see if the operands of the icmp are casted versions of other 4523 // values. If the ptr->ptr cast can be stripped off both arguments, we do so 4524 // now. 4525 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) { 4526 if (Op0->getType()->isPointerTy() && 4527 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 4528 // We keep moving the cast from the left operand over to the right 4529 // operand, where it can often be eliminated completely. 4530 Op0 = CI->getOperand(0); 4531 4532 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 4533 // so eliminate it as well. 4534 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1)) 4535 Op1 = CI2->getOperand(0); 4536 4537 // If Op1 is a constant, we can fold the cast into the constant. 4538 if (Op0->getType() != Op1->getType()) { 4539 if (Constant *Op1C = dyn_cast<Constant>(Op1)) { 4540 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType()); 4541 } else { 4542 // Otherwise, cast the RHS right before the icmp 4543 Op1 = Builder.CreateBitCast(Op1, Op0->getType()); 4544 } 4545 } 4546 return new ICmpInst(I.getPredicate(), Op0, Op1); 4547 } 4548 } 4549 4550 if (isa<CastInst>(Op0)) { 4551 // Handle the special case of: icmp (cast bool to X), <cst> 4552 // This comes up when you have code like 4553 // int X = A < B; 4554 // if (X) ... 4555 // For generality, we handle any zero-extension of any operand comparison 4556 // with a constant or another cast from the same type. 4557 if (isa<Constant>(Op1) || isa<CastInst>(Op1)) 4558 if (Instruction *R = foldICmpWithCastAndCast(I)) 4559 return R; 4560 } 4561 4562 if (Instruction *Res = foldICmpBinOp(I)) 4563 return Res; 4564 4565 if (Instruction *Res = foldICmpWithMinMax(I)) 4566 return Res; 4567 4568 { 4569 Value *A, *B; 4570 // Transform (A & ~B) == 0 --> (A & B) != 0 4571 // and (A & ~B) != 0 --> (A & B) == 0 4572 // if A is a power of 2. 4573 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 4574 match(Op1, m_Zero()) && 4575 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 4576 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 4577 Op1); 4578 4579 // ~X < ~Y --> Y < X 4580 // ~X < C --> X > ~C 4581 if (match(Op0, m_Not(m_Value(A)))) { 4582 if (match(Op1, m_Not(m_Value(B)))) 4583 return new ICmpInst(I.getPredicate(), B, A); 4584 4585 const APInt *C; 4586 if (match(Op1, m_APInt(C))) 4587 return new ICmpInst(I.getSwappedPredicate(), A, 4588 ConstantInt::get(Op1->getType(), ~(*C))); 4589 } 4590 4591 Instruction *AddI = nullptr; 4592 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 4593 m_Instruction(AddI))) && 4594 isa<IntegerType>(A->getType())) { 4595 Value *Result; 4596 Constant *Overflow; 4597 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result, 4598 Overflow)) { 4599 replaceInstUsesWith(*AddI, Result); 4600 return replaceInstUsesWith(I, Overflow); 4601 } 4602 } 4603 4604 // (zext a) * (zext b) --> llvm.umul.with.overflow. 4605 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4606 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 4607 return R; 4608 } 4609 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4610 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 4611 return R; 4612 } 4613 } 4614 4615 if (Instruction *Res = foldICmpEquality(I)) 4616 return Res; 4617 4618 // The 'cmpxchg' instruction returns an aggregate containing the old value and 4619 // an i1 which indicates whether or not we successfully did the swap. 4620 // 4621 // Replace comparisons between the old value and the expected value with the 4622 // indicator that 'cmpxchg' returns. 4623 // 4624 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 4625 // spuriously fail. In those cases, the old value may equal the expected 4626 // value but it is possible for the swap to not occur. 4627 if (I.getPredicate() == ICmpInst::ICMP_EQ) 4628 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 4629 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 4630 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 4631 !ACXI->isWeak()) 4632 return ExtractValueInst::Create(ACXI, 1); 4633 4634 { 4635 Value *X; ConstantInt *Cst; 4636 // icmp X+Cst, X 4637 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X) 4638 return foldICmpAddOpConst(X, Cst, I.getPredicate()); 4639 4640 // icmp X, X+Cst 4641 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X) 4642 return foldICmpAddOpConst(X, Cst, I.getSwappedPredicate()); 4643 } 4644 return Changed ? &I : nullptr; 4645 } 4646 4647 /// Fold fcmp ([us]itofp x, cst) if possible. 4648 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 4649 Constant *RHSC) { 4650 if (!isa<ConstantFP>(RHSC)) return nullptr; 4651 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 4652 4653 // Get the width of the mantissa. We don't want to hack on conversions that 4654 // might lose information from the integer, e.g. "i64 -> float" 4655 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 4656 if (MantissaWidth == -1) return nullptr; // Unknown. 4657 4658 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 4659 4660 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 4661 4662 if (I.isEquality()) { 4663 FCmpInst::Predicate P = I.getPredicate(); 4664 bool IsExact = false; 4665 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 4666 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 4667 4668 // If the floating point constant isn't an integer value, we know if we will 4669 // ever compare equal / not equal to it. 4670 if (!IsExact) { 4671 // TODO: Can never be -0.0 and other non-representable values 4672 APFloat RHSRoundInt(RHS); 4673 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 4674 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) { 4675 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 4676 return replaceInstUsesWith(I, Builder.getFalse()); 4677 4678 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 4679 return replaceInstUsesWith(I, Builder.getTrue()); 4680 } 4681 } 4682 4683 // TODO: If the constant is exactly representable, is it always OK to do 4684 // equality compares as integer? 4685 } 4686 4687 // Check to see that the input is converted from an integer type that is small 4688 // enough that preserves all bits. TODO: check here for "known" sign bits. 4689 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 4690 unsigned InputSize = IntTy->getScalarSizeInBits(); 4691 4692 // Following test does NOT adjust InputSize downwards for signed inputs, 4693 // because the most negative value still requires all the mantissa bits 4694 // to distinguish it from one less than that value. 4695 if ((int)InputSize > MantissaWidth) { 4696 // Conversion would lose accuracy. Check if loss can impact comparison. 4697 int Exp = ilogb(RHS); 4698 if (Exp == APFloat::IEK_Inf) { 4699 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 4700 if (MaxExponent < (int)InputSize - !LHSUnsigned) 4701 // Conversion could create infinity. 4702 return nullptr; 4703 } else { 4704 // Note that if RHS is zero or NaN, then Exp is negative 4705 // and first condition is trivially false. 4706 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 4707 // Conversion could affect comparison. 4708 return nullptr; 4709 } 4710 } 4711 4712 // Otherwise, we can potentially simplify the comparison. We know that it 4713 // will always come through as an integer value and we know the constant is 4714 // not a NAN (it would have been previously simplified). 4715 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 4716 4717 ICmpInst::Predicate Pred; 4718 switch (I.getPredicate()) { 4719 default: llvm_unreachable("Unexpected predicate!"); 4720 case FCmpInst::FCMP_UEQ: 4721 case FCmpInst::FCMP_OEQ: 4722 Pred = ICmpInst::ICMP_EQ; 4723 break; 4724 case FCmpInst::FCMP_UGT: 4725 case FCmpInst::FCMP_OGT: 4726 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 4727 break; 4728 case FCmpInst::FCMP_UGE: 4729 case FCmpInst::FCMP_OGE: 4730 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 4731 break; 4732 case FCmpInst::FCMP_ULT: 4733 case FCmpInst::FCMP_OLT: 4734 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 4735 break; 4736 case FCmpInst::FCMP_ULE: 4737 case FCmpInst::FCMP_OLE: 4738 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 4739 break; 4740 case FCmpInst::FCMP_UNE: 4741 case FCmpInst::FCMP_ONE: 4742 Pred = ICmpInst::ICMP_NE; 4743 break; 4744 case FCmpInst::FCMP_ORD: 4745 return replaceInstUsesWith(I, Builder.getTrue()); 4746 case FCmpInst::FCMP_UNO: 4747 return replaceInstUsesWith(I, Builder.getFalse()); 4748 } 4749 4750 // Now we know that the APFloat is a normal number, zero or inf. 4751 4752 // See if the FP constant is too large for the integer. For example, 4753 // comparing an i8 to 300.0. 4754 unsigned IntWidth = IntTy->getScalarSizeInBits(); 4755 4756 if (!LHSUnsigned) { 4757 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 4758 // and large values. 4759 APFloat SMax(RHS.getSemantics()); 4760 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 4761 APFloat::rmNearestTiesToEven); 4762 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0 4763 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 4764 Pred == ICmpInst::ICMP_SLE) 4765 return replaceInstUsesWith(I, Builder.getTrue()); 4766 return replaceInstUsesWith(I, Builder.getFalse()); 4767 } 4768 } else { 4769 // If the RHS value is > UnsignedMax, fold the comparison. This handles 4770 // +INF and large values. 4771 APFloat UMax(RHS.getSemantics()); 4772 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 4773 APFloat::rmNearestTiesToEven); 4774 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0 4775 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 4776 Pred == ICmpInst::ICMP_ULE) 4777 return replaceInstUsesWith(I, Builder.getTrue()); 4778 return replaceInstUsesWith(I, Builder.getFalse()); 4779 } 4780 } 4781 4782 if (!LHSUnsigned) { 4783 // See if the RHS value is < SignedMin. 4784 APFloat SMin(RHS.getSemantics()); 4785 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 4786 APFloat::rmNearestTiesToEven); 4787 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0 4788 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 4789 Pred == ICmpInst::ICMP_SGE) 4790 return replaceInstUsesWith(I, Builder.getTrue()); 4791 return replaceInstUsesWith(I, Builder.getFalse()); 4792 } 4793 } else { 4794 // See if the RHS value is < UnsignedMin. 4795 APFloat SMin(RHS.getSemantics()); 4796 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true, 4797 APFloat::rmNearestTiesToEven); 4798 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0 4799 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 4800 Pred == ICmpInst::ICMP_UGE) 4801 return replaceInstUsesWith(I, Builder.getTrue()); 4802 return replaceInstUsesWith(I, Builder.getFalse()); 4803 } 4804 } 4805 4806 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 4807 // [0, UMAX], but it may still be fractional. See if it is fractional by 4808 // casting the FP value to the integer value and back, checking for equality. 4809 // Don't do this for zero, because -0.0 is not fractional. 4810 Constant *RHSInt = LHSUnsigned 4811 ? ConstantExpr::getFPToUI(RHSC, IntTy) 4812 : ConstantExpr::getFPToSI(RHSC, IntTy); 4813 if (!RHS.isZero()) { 4814 bool Equal = LHSUnsigned 4815 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 4816 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 4817 if (!Equal) { 4818 // If we had a comparison against a fractional value, we have to adjust 4819 // the compare predicate and sometimes the value. RHSC is rounded towards 4820 // zero at this point. 4821 switch (Pred) { 4822 default: llvm_unreachable("Unexpected integer comparison!"); 4823 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 4824 return replaceInstUsesWith(I, Builder.getTrue()); 4825 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 4826 return replaceInstUsesWith(I, Builder.getFalse()); 4827 case ICmpInst::ICMP_ULE: 4828 // (float)int <= 4.4 --> int <= 4 4829 // (float)int <= -4.4 --> false 4830 if (RHS.isNegative()) 4831 return replaceInstUsesWith(I, Builder.getFalse()); 4832 break; 4833 case ICmpInst::ICMP_SLE: 4834 // (float)int <= 4.4 --> int <= 4 4835 // (float)int <= -4.4 --> int < -4 4836 if (RHS.isNegative()) 4837 Pred = ICmpInst::ICMP_SLT; 4838 break; 4839 case ICmpInst::ICMP_ULT: 4840 // (float)int < -4.4 --> false 4841 // (float)int < 4.4 --> int <= 4 4842 if (RHS.isNegative()) 4843 return replaceInstUsesWith(I, Builder.getFalse()); 4844 Pred = ICmpInst::ICMP_ULE; 4845 break; 4846 case ICmpInst::ICMP_SLT: 4847 // (float)int < -4.4 --> int < -4 4848 // (float)int < 4.4 --> int <= 4 4849 if (!RHS.isNegative()) 4850 Pred = ICmpInst::ICMP_SLE; 4851 break; 4852 case ICmpInst::ICMP_UGT: 4853 // (float)int > 4.4 --> int > 4 4854 // (float)int > -4.4 --> true 4855 if (RHS.isNegative()) 4856 return replaceInstUsesWith(I, Builder.getTrue()); 4857 break; 4858 case ICmpInst::ICMP_SGT: 4859 // (float)int > 4.4 --> int > 4 4860 // (float)int > -4.4 --> int >= -4 4861 if (RHS.isNegative()) 4862 Pred = ICmpInst::ICMP_SGE; 4863 break; 4864 case ICmpInst::ICMP_UGE: 4865 // (float)int >= -4.4 --> true 4866 // (float)int >= 4.4 --> int > 4 4867 if (RHS.isNegative()) 4868 return replaceInstUsesWith(I, Builder.getTrue()); 4869 Pred = ICmpInst::ICMP_UGT; 4870 break; 4871 case ICmpInst::ICMP_SGE: 4872 // (float)int >= -4.4 --> int >= -4 4873 // (float)int >= 4.4 --> int > 4 4874 if (!RHS.isNegative()) 4875 Pred = ICmpInst::ICMP_SGT; 4876 break; 4877 } 4878 } 4879 } 4880 4881 // Lower this FP comparison into an appropriate integer version of the 4882 // comparison. 4883 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 4884 } 4885 4886 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 4887 bool Changed = false; 4888 4889 /// Orders the operands of the compare so that they are listed from most 4890 /// complex to least complex. This puts constants before unary operators, 4891 /// before binary operators. 4892 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 4893 I.swapOperands(); 4894 Changed = true; 4895 } 4896 4897 const CmpInst::Predicate Pred = I.getPredicate(); 4898 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4899 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 4900 SQ.getWithInstruction(&I))) 4901 return replaceInstUsesWith(I, V); 4902 4903 // Simplify 'fcmp pred X, X' 4904 if (Op0 == Op1) { 4905 switch (Pred) { 4906 default: break; 4907 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 4908 case FCmpInst::FCMP_ULT: // True if unordered or less than 4909 case FCmpInst::FCMP_UGT: // True if unordered or greater than 4910 case FCmpInst::FCMP_UNE: // True if unordered or not equal 4911 // Canonicalize these to be 'fcmp uno %X, 0.0'. 4912 I.setPredicate(FCmpInst::FCMP_UNO); 4913 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4914 return &I; 4915 4916 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 4917 case FCmpInst::FCMP_OEQ: // True if ordered and equal 4918 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 4919 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 4920 // Canonicalize these to be 'fcmp ord %X, 0.0'. 4921 I.setPredicate(FCmpInst::FCMP_ORD); 4922 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4923 return &I; 4924 } 4925 } 4926 4927 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 4928 // then canonicalize the operand to 0.0. 4929 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 4930 if (!match(Op0, m_Zero()) && isKnownNeverNaN(Op0)) { 4931 I.setOperand(0, ConstantFP::getNullValue(Op0->getType())); 4932 return &I; 4933 } 4934 if (!match(Op1, m_Zero()) && isKnownNeverNaN(Op1)) { 4935 I.setOperand(1, ConstantFP::getNullValue(Op0->getType())); 4936 return &I; 4937 } 4938 } 4939 4940 // Test if the FCmpInst instruction is used exclusively by a select as 4941 // part of a minimum or maximum operation. If so, refrain from doing 4942 // any other folding. This helps out other analyses which understand 4943 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4944 // and CodeGen. And in this case, at least one of the comparison 4945 // operands has at least one user besides the compare (the select), 4946 // which would often largely negate the benefit of folding anyway. 4947 if (I.hasOneUse()) 4948 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4949 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4950 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4951 return nullptr; 4952 4953 // Handle fcmp with constant RHS 4954 if (Constant *RHSC = dyn_cast<Constant>(Op1)) { 4955 if (Instruction *LHSI = dyn_cast<Instruction>(Op0)) 4956 switch (LHSI->getOpcode()) { 4957 case Instruction::FPExt: { 4958 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless 4959 FPExtInst *LHSExt = cast<FPExtInst>(LHSI); 4960 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC); 4961 if (!RHSF) 4962 break; 4963 4964 const fltSemantics *Sem; 4965 // FIXME: This shouldn't be here. 4966 if (LHSExt->getSrcTy()->isHalfTy()) 4967 Sem = &APFloat::IEEEhalf(); 4968 else if (LHSExt->getSrcTy()->isFloatTy()) 4969 Sem = &APFloat::IEEEsingle(); 4970 else if (LHSExt->getSrcTy()->isDoubleTy()) 4971 Sem = &APFloat::IEEEdouble(); 4972 else if (LHSExt->getSrcTy()->isFP128Ty()) 4973 Sem = &APFloat::IEEEquad(); 4974 else if (LHSExt->getSrcTy()->isX86_FP80Ty()) 4975 Sem = &APFloat::x87DoubleExtended(); 4976 else if (LHSExt->getSrcTy()->isPPC_FP128Ty()) 4977 Sem = &APFloat::PPCDoubleDouble(); 4978 else 4979 break; 4980 4981 bool Lossy; 4982 APFloat F = RHSF->getValueAPF(); 4983 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy); 4984 4985 // Avoid lossy conversions and denormals. Zero is a special case 4986 // that's OK to convert. 4987 APFloat Fabs = F; 4988 Fabs.clearSign(); 4989 if (!Lossy && 4990 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) != 4991 APFloat::cmpLessThan) || Fabs.isZero())) 4992 4993 return new FCmpInst(Pred, LHSExt->getOperand(0), 4994 ConstantFP::get(RHSC->getContext(), F)); 4995 break; 4996 } 4997 case Instruction::PHI: 4998 // Only fold fcmp into the PHI if the phi and fcmp are in the same 4999 // block. If in the same block, we're encouraging jump threading. If 5000 // not, we are just pessimizing the code by making an i1 phi. 5001 if (LHSI->getParent() == I.getParent()) 5002 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 5003 return NV; 5004 break; 5005 case Instruction::SIToFP: 5006 case Instruction::UIToFP: 5007 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 5008 return NV; 5009 break; 5010 case Instruction::FSub: { 5011 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C 5012 Value *Op; 5013 if (match(LHSI, m_FNeg(m_Value(Op)))) 5014 return new FCmpInst(I.getSwappedPredicate(), Op, 5015 ConstantExpr::getFNeg(RHSC)); 5016 break; 5017 } 5018 case Instruction::Load: 5019 if (GetElementPtrInst *GEP = 5020 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 5021 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 5022 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 5023 !cast<LoadInst>(LHSI)->isVolatile()) 5024 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 5025 return Res; 5026 } 5027 break; 5028 case Instruction::Call: { 5029 if (!RHSC->isNullValue()) 5030 break; 5031 5032 CallInst *CI = cast<CallInst>(LHSI); 5033 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI); 5034 if (IID != Intrinsic::fabs) 5035 break; 5036 5037 // Various optimization for fabs compared with zero. 5038 switch (Pred) { 5039 default: 5040 break; 5041 // fabs(x) < 0 --> false 5042 case FCmpInst::FCMP_OLT: 5043 llvm_unreachable("handled by SimplifyFCmpInst"); 5044 // fabs(x) > 0 --> x != 0 5045 case FCmpInst::FCMP_OGT: 5046 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC); 5047 // fabs(x) <= 0 --> x == 0 5048 case FCmpInst::FCMP_OLE: 5049 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC); 5050 // fabs(x) >= 0 --> !isnan(x) 5051 case FCmpInst::FCMP_OGE: 5052 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC); 5053 // fabs(x) == 0 --> x == 0 5054 // fabs(x) != 0 --> x != 0 5055 case FCmpInst::FCMP_OEQ: 5056 case FCmpInst::FCMP_UEQ: 5057 case FCmpInst::FCMP_ONE: 5058 case FCmpInst::FCMP_UNE: 5059 return new FCmpInst(Pred, CI->getArgOperand(0), RHSC); 5060 } 5061 } 5062 } 5063 } 5064 5065 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y 5066 Value *X, *Y; 5067 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 5068 return new FCmpInst(I.getSwappedPredicate(), X, Y); 5069 5070 // fcmp (fpext x), (fpext y) -> fcmp x, y 5071 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0)) 5072 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1)) 5073 if (LHSExt->getSrcTy() == RHSExt->getSrcTy()) 5074 return new FCmpInst(Pred, LHSExt->getOperand(0), RHSExt->getOperand(0)); 5075 5076 return Changed ? &I : nullptr; 5077 } 5078