1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/ConstantFolding.h" 18 #include "llvm/Analysis/InstructionSimplify.h" 19 #include "llvm/Analysis/TargetLibraryInfo.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/Debug.h" 26 #include "llvm/Support/KnownBits.h" 27 #include "llvm/Transforms/InstCombine/InstCombiner.h" 28 29 using namespace llvm; 30 using namespace PatternMatch; 31 32 #define DEBUG_TYPE "instcombine" 33 34 // How many times is a select replaced by one of its operands? 35 STATISTIC(NumSel, "Number of select opts"); 36 37 38 /// Compute Result = In1+In2, returning true if the result overflowed for this 39 /// type. 40 static bool addWithOverflow(APInt &Result, const APInt &In1, 41 const APInt &In2, bool IsSigned = false) { 42 bool Overflow; 43 if (IsSigned) 44 Result = In1.sadd_ov(In2, Overflow); 45 else 46 Result = In1.uadd_ov(In2, Overflow); 47 48 return Overflow; 49 } 50 51 /// Compute Result = In1-In2, returning true if the result overflowed for this 52 /// type. 53 static bool subWithOverflow(APInt &Result, const APInt &In1, 54 const APInt &In2, bool IsSigned = false) { 55 bool Overflow; 56 if (IsSigned) 57 Result = In1.ssub_ov(In2, Overflow); 58 else 59 Result = In1.usub_ov(In2, Overflow); 60 61 return Overflow; 62 } 63 64 /// Given an icmp instruction, return true if any use of this comparison is a 65 /// branch on sign bit comparison. 66 static bool hasBranchUse(ICmpInst &I) { 67 for (auto *U : I.users()) 68 if (isa<BranchInst>(U)) 69 return true; 70 return false; 71 } 72 73 /// Returns true if the exploded icmp can be expressed as a signed comparison 74 /// to zero and updates the predicate accordingly. 75 /// The signedness of the comparison is preserved. 76 /// TODO: Refactor with decomposeBitTestICmp()? 77 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 78 if (!ICmpInst::isSigned(Pred)) 79 return false; 80 81 if (C.isZero()) 82 return ICmpInst::isRelational(Pred); 83 84 if (C.isOne()) { 85 if (Pred == ICmpInst::ICMP_SLT) { 86 Pred = ICmpInst::ICMP_SLE; 87 return true; 88 } 89 } else if (C.isAllOnes()) { 90 if (Pred == ICmpInst::ICMP_SGT) { 91 Pred = ICmpInst::ICMP_SGE; 92 return true; 93 } 94 } 95 96 return false; 97 } 98 99 /// This is called when we see this pattern: 100 /// cmp pred (load (gep GV, ...)), cmpcst 101 /// where GV is a global variable with a constant initializer. Try to simplify 102 /// this into some simple computation that does not need the load. For example 103 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 104 /// 105 /// If AndCst is non-null, then the loaded value is masked with that constant 106 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 107 Instruction * 108 InstCombinerImpl::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 109 GlobalVariable *GV, CmpInst &ICI, 110 ConstantInt *AndCst) { 111 Constant *Init = GV->getInitializer(); 112 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 113 return nullptr; 114 115 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 116 // Don't blow up on huge arrays. 117 if (ArrayElementCount > MaxArraySizeForCombine) 118 return nullptr; 119 120 // There are many forms of this optimization we can handle, for now, just do 121 // the simple index into a single-dimensional array. 122 // 123 // Require: GEP GV, 0, i {{, constant indices}} 124 if (GEP->getNumOperands() < 3 || 125 !isa<ConstantInt>(GEP->getOperand(1)) || 126 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 127 isa<Constant>(GEP->getOperand(2))) 128 return nullptr; 129 130 // Check that indices after the variable are constants and in-range for the 131 // type they index. Collect the indices. This is typically for arrays of 132 // structs. 133 SmallVector<unsigned, 4> LaterIndices; 134 135 Type *EltTy = Init->getType()->getArrayElementType(); 136 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 137 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 138 if (!Idx) return nullptr; // Variable index. 139 140 uint64_t IdxVal = Idx->getZExtValue(); 141 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 142 143 if (StructType *STy = dyn_cast<StructType>(EltTy)) 144 EltTy = STy->getElementType(IdxVal); 145 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 146 if (IdxVal >= ATy->getNumElements()) return nullptr; 147 EltTy = ATy->getElementType(); 148 } else { 149 return nullptr; // Unknown type. 150 } 151 152 LaterIndices.push_back(IdxVal); 153 } 154 155 enum { Overdefined = -3, Undefined = -2 }; 156 157 // Variables for our state machines. 158 159 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 160 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 161 // and 87 is the second (and last) index. FirstTrueElement is -2 when 162 // undefined, otherwise set to the first true element. SecondTrueElement is 163 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 164 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 165 166 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 167 // form "i != 47 & i != 87". Same state transitions as for true elements. 168 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 169 170 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 171 /// define a state machine that triggers for ranges of values that the index 172 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 173 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 174 /// index in the range (inclusive). We use -2 for undefined here because we 175 /// use relative comparisons and don't want 0-1 to match -1. 176 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 177 178 // MagicBitvector - This is a magic bitvector where we set a bit if the 179 // comparison is true for element 'i'. If there are 64 elements or less in 180 // the array, this will fully represent all the comparison results. 181 uint64_t MagicBitvector = 0; 182 183 // Scan the array and see if one of our patterns matches. 184 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 185 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 186 Constant *Elt = Init->getAggregateElement(i); 187 if (!Elt) return nullptr; 188 189 // If this is indexing an array of structures, get the structure element. 190 if (!LaterIndices.empty()) 191 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 192 193 // If the element is masked, handle it. 194 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 195 196 // Find out if the comparison would be true or false for the i'th element. 197 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 198 CompareRHS, DL, &TLI); 199 // If the result is undef for this element, ignore it. 200 if (isa<UndefValue>(C)) { 201 // Extend range state machines to cover this element in case there is an 202 // undef in the middle of the range. 203 if (TrueRangeEnd == (int)i-1) 204 TrueRangeEnd = i; 205 if (FalseRangeEnd == (int)i-1) 206 FalseRangeEnd = i; 207 continue; 208 } 209 210 // If we can't compute the result for any of the elements, we have to give 211 // up evaluating the entire conditional. 212 if (!isa<ConstantInt>(C)) return nullptr; 213 214 // Otherwise, we know if the comparison is true or false for this element, 215 // update our state machines. 216 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 217 218 // State machine for single/double/range index comparison. 219 if (IsTrueForElt) { 220 // Update the TrueElement state machine. 221 if (FirstTrueElement == Undefined) 222 FirstTrueElement = TrueRangeEnd = i; // First true element. 223 else { 224 // Update double-compare state machine. 225 if (SecondTrueElement == Undefined) 226 SecondTrueElement = i; 227 else 228 SecondTrueElement = Overdefined; 229 230 // Update range state machine. 231 if (TrueRangeEnd == (int)i-1) 232 TrueRangeEnd = i; 233 else 234 TrueRangeEnd = Overdefined; 235 } 236 } else { 237 // Update the FalseElement state machine. 238 if (FirstFalseElement == Undefined) 239 FirstFalseElement = FalseRangeEnd = i; // First false element. 240 else { 241 // Update double-compare state machine. 242 if (SecondFalseElement == Undefined) 243 SecondFalseElement = i; 244 else 245 SecondFalseElement = Overdefined; 246 247 // Update range state machine. 248 if (FalseRangeEnd == (int)i-1) 249 FalseRangeEnd = i; 250 else 251 FalseRangeEnd = Overdefined; 252 } 253 } 254 255 // If this element is in range, update our magic bitvector. 256 if (i < 64 && IsTrueForElt) 257 MagicBitvector |= 1ULL << i; 258 259 // If all of our states become overdefined, bail out early. Since the 260 // predicate is expensive, only check it every 8 elements. This is only 261 // really useful for really huge arrays. 262 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 263 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 264 FalseRangeEnd == Overdefined) 265 return nullptr; 266 } 267 268 // Now that we've scanned the entire array, emit our new comparison(s). We 269 // order the state machines in complexity of the generated code. 270 Value *Idx = GEP->getOperand(2); 271 272 // If the index is larger than the pointer size of the target, truncate the 273 // index down like the GEP would do implicitly. We don't have to do this for 274 // an inbounds GEP because the index can't be out of range. 275 if (!GEP->isInBounds()) { 276 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 277 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 278 if (Idx->getType()->getPrimitiveSizeInBits().getFixedSize() > PtrSize) 279 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 280 } 281 282 // If inbounds keyword is not present, Idx * ElementSize can overflow. 283 // Let's assume that ElementSize is 2 and the wanted value is at offset 0. 284 // Then, there are two possible values for Idx to match offset 0: 285 // 0x00..00, 0x80..00. 286 // Emitting 'icmp eq Idx, 0' isn't correct in this case because the 287 // comparison is false if Idx was 0x80..00. 288 // We need to erase the highest countTrailingZeros(ElementSize) bits of Idx. 289 unsigned ElementSize = 290 DL.getTypeAllocSize(Init->getType()->getArrayElementType()); 291 auto MaskIdx = [&](Value* Idx){ 292 if (!GEP->isInBounds() && countTrailingZeros(ElementSize) != 0) { 293 Value *Mask = ConstantInt::get(Idx->getType(), -1); 294 Mask = Builder.CreateLShr(Mask, countTrailingZeros(ElementSize)); 295 Idx = Builder.CreateAnd(Idx, Mask); 296 } 297 return Idx; 298 }; 299 300 // If the comparison is only true for one or two elements, emit direct 301 // comparisons. 302 if (SecondTrueElement != Overdefined) { 303 Idx = MaskIdx(Idx); 304 // None true -> false. 305 if (FirstTrueElement == Undefined) 306 return replaceInstUsesWith(ICI, Builder.getFalse()); 307 308 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 309 310 // True for one element -> 'i == 47'. 311 if (SecondTrueElement == Undefined) 312 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 313 314 // True for two elements -> 'i == 47 | i == 72'. 315 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 316 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 317 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 318 return BinaryOperator::CreateOr(C1, C2); 319 } 320 321 // If the comparison is only false for one or two elements, emit direct 322 // comparisons. 323 if (SecondFalseElement != Overdefined) { 324 Idx = MaskIdx(Idx); 325 // None false -> true. 326 if (FirstFalseElement == Undefined) 327 return replaceInstUsesWith(ICI, Builder.getTrue()); 328 329 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 330 331 // False for one element -> 'i != 47'. 332 if (SecondFalseElement == Undefined) 333 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 334 335 // False for two elements -> 'i != 47 & i != 72'. 336 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 337 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 338 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 339 return BinaryOperator::CreateAnd(C1, C2); 340 } 341 342 // If the comparison can be replaced with a range comparison for the elements 343 // where it is true, emit the range check. 344 if (TrueRangeEnd != Overdefined) { 345 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 346 Idx = MaskIdx(Idx); 347 348 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 349 if (FirstTrueElement) { 350 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 351 Idx = Builder.CreateAdd(Idx, Offs); 352 } 353 354 Value *End = ConstantInt::get(Idx->getType(), 355 TrueRangeEnd-FirstTrueElement+1); 356 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 357 } 358 359 // False range check. 360 if (FalseRangeEnd != Overdefined) { 361 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 362 Idx = MaskIdx(Idx); 363 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 364 if (FirstFalseElement) { 365 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 366 Idx = Builder.CreateAdd(Idx, Offs); 367 } 368 369 Value *End = ConstantInt::get(Idx->getType(), 370 FalseRangeEnd-FirstFalseElement); 371 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 372 } 373 374 // If a magic bitvector captures the entire comparison state 375 // of this load, replace it with computation that does: 376 // ((magic_cst >> i) & 1) != 0 377 { 378 Type *Ty = nullptr; 379 380 // Look for an appropriate type: 381 // - The type of Idx if the magic fits 382 // - The smallest fitting legal type 383 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 384 Ty = Idx->getType(); 385 else 386 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 387 388 if (Ty) { 389 Idx = MaskIdx(Idx); 390 Value *V = Builder.CreateIntCast(Idx, Ty, false); 391 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 392 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 393 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 394 } 395 } 396 397 return nullptr; 398 } 399 400 /// Return a value that can be used to compare the *offset* implied by a GEP to 401 /// zero. For example, if we have &A[i], we want to return 'i' for 402 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 403 /// are involved. The above expression would also be legal to codegen as 404 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 405 /// This latter form is less amenable to optimization though, and we are allowed 406 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 407 /// 408 /// If we can't emit an optimized form for this expression, this returns null. 409 /// 410 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombinerImpl &IC, 411 const DataLayout &DL) { 412 gep_type_iterator GTI = gep_type_begin(GEP); 413 414 // Check to see if this gep only has a single variable index. If so, and if 415 // any constant indices are a multiple of its scale, then we can compute this 416 // in terms of the scale of the variable index. For example, if the GEP 417 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 418 // because the expression will cross zero at the same point. 419 unsigned i, e = GEP->getNumOperands(); 420 int64_t Offset = 0; 421 for (i = 1; i != e; ++i, ++GTI) { 422 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 423 // Compute the aggregate offset of constant indices. 424 if (CI->isZero()) continue; 425 426 // Handle a struct index, which adds its field offset to the pointer. 427 if (StructType *STy = GTI.getStructTypeOrNull()) { 428 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 429 } else { 430 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 431 Offset += Size*CI->getSExtValue(); 432 } 433 } else { 434 // Found our variable index. 435 break; 436 } 437 } 438 439 // If there are no variable indices, we must have a constant offset, just 440 // evaluate it the general way. 441 if (i == e) return nullptr; 442 443 Value *VariableIdx = GEP->getOperand(i); 444 // Determine the scale factor of the variable element. For example, this is 445 // 4 if the variable index is into an array of i32. 446 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 447 448 // Verify that there are no other variable indices. If so, emit the hard way. 449 for (++i, ++GTI; i != e; ++i, ++GTI) { 450 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 451 if (!CI) return nullptr; 452 453 // Compute the aggregate offset of constant indices. 454 if (CI->isZero()) continue; 455 456 // Handle a struct index, which adds its field offset to the pointer. 457 if (StructType *STy = GTI.getStructTypeOrNull()) { 458 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 459 } else { 460 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 461 Offset += Size*CI->getSExtValue(); 462 } 463 } 464 465 // Okay, we know we have a single variable index, which must be a 466 // pointer/array/vector index. If there is no offset, life is simple, return 467 // the index. 468 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 469 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 470 if (Offset == 0) { 471 // Cast to intptrty in case a truncation occurs. If an extension is needed, 472 // we don't need to bother extending: the extension won't affect where the 473 // computation crosses zero. 474 if (VariableIdx->getType()->getPrimitiveSizeInBits().getFixedSize() > 475 IntPtrWidth) { 476 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 477 } 478 return VariableIdx; 479 } 480 481 // Otherwise, there is an index. The computation we will do will be modulo 482 // the pointer size. 483 Offset = SignExtend64(Offset, IntPtrWidth); 484 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 485 486 // To do this transformation, any constant index must be a multiple of the 487 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 488 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 489 // multiple of the variable scale. 490 int64_t NewOffs = Offset / (int64_t)VariableScale; 491 if (Offset != NewOffs*(int64_t)VariableScale) 492 return nullptr; 493 494 // Okay, we can do this evaluation. Start by converting the index to intptr. 495 if (VariableIdx->getType() != IntPtrTy) 496 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 497 true /*Signed*/); 498 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 499 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 500 } 501 502 /// Returns true if we can rewrite Start as a GEP with pointer Base 503 /// and some integer offset. The nodes that need to be re-written 504 /// for this transformation will be added to Explored. 505 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 506 const DataLayout &DL, 507 SetVector<Value *> &Explored) { 508 SmallVector<Value *, 16> WorkList(1, Start); 509 Explored.insert(Base); 510 511 // The following traversal gives us an order which can be used 512 // when doing the final transformation. Since in the final 513 // transformation we create the PHI replacement instructions first, 514 // we don't have to get them in any particular order. 515 // 516 // However, for other instructions we will have to traverse the 517 // operands of an instruction first, which means that we have to 518 // do a post-order traversal. 519 while (!WorkList.empty()) { 520 SetVector<PHINode *> PHIs; 521 522 while (!WorkList.empty()) { 523 if (Explored.size() >= 100) 524 return false; 525 526 Value *V = WorkList.back(); 527 528 if (Explored.contains(V)) { 529 WorkList.pop_back(); 530 continue; 531 } 532 533 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 534 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 535 // We've found some value that we can't explore which is different from 536 // the base. Therefore we can't do this transformation. 537 return false; 538 539 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 540 auto *CI = cast<CastInst>(V); 541 if (!CI->isNoopCast(DL)) 542 return false; 543 544 if (!Explored.contains(CI->getOperand(0))) 545 WorkList.push_back(CI->getOperand(0)); 546 } 547 548 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 549 // We're limiting the GEP to having one index. This will preserve 550 // the original pointer type. We could handle more cases in the 551 // future. 552 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 553 GEP->getType() != Start->getType()) 554 return false; 555 556 if (!Explored.contains(GEP->getOperand(0))) 557 WorkList.push_back(GEP->getOperand(0)); 558 } 559 560 if (WorkList.back() == V) { 561 WorkList.pop_back(); 562 // We've finished visiting this node, mark it as such. 563 Explored.insert(V); 564 } 565 566 if (auto *PN = dyn_cast<PHINode>(V)) { 567 // We cannot transform PHIs on unsplittable basic blocks. 568 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 569 return false; 570 Explored.insert(PN); 571 PHIs.insert(PN); 572 } 573 } 574 575 // Explore the PHI nodes further. 576 for (auto *PN : PHIs) 577 for (Value *Op : PN->incoming_values()) 578 if (!Explored.contains(Op)) 579 WorkList.push_back(Op); 580 } 581 582 // Make sure that we can do this. Since we can't insert GEPs in a basic 583 // block before a PHI node, we can't easily do this transformation if 584 // we have PHI node users of transformed instructions. 585 for (Value *Val : Explored) { 586 for (Value *Use : Val->uses()) { 587 588 auto *PHI = dyn_cast<PHINode>(Use); 589 auto *Inst = dyn_cast<Instruction>(Val); 590 591 if (Inst == Base || Inst == PHI || !Inst || !PHI || 592 !Explored.contains(PHI)) 593 continue; 594 595 if (PHI->getParent() == Inst->getParent()) 596 return false; 597 } 598 } 599 return true; 600 } 601 602 // Sets the appropriate insert point on Builder where we can add 603 // a replacement Instruction for V (if that is possible). 604 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 605 bool Before = true) { 606 if (auto *PHI = dyn_cast<PHINode>(V)) { 607 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 608 return; 609 } 610 if (auto *I = dyn_cast<Instruction>(V)) { 611 if (!Before) 612 I = &*std::next(I->getIterator()); 613 Builder.SetInsertPoint(I); 614 return; 615 } 616 if (auto *A = dyn_cast<Argument>(V)) { 617 // Set the insertion point in the entry block. 618 BasicBlock &Entry = A->getParent()->getEntryBlock(); 619 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 620 return; 621 } 622 // Otherwise, this is a constant and we don't need to set a new 623 // insertion point. 624 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 625 } 626 627 /// Returns a re-written value of Start as an indexed GEP using Base as a 628 /// pointer. 629 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 630 const DataLayout &DL, 631 SetVector<Value *> &Explored) { 632 // Perform all the substitutions. This is a bit tricky because we can 633 // have cycles in our use-def chains. 634 // 1. Create the PHI nodes without any incoming values. 635 // 2. Create all the other values. 636 // 3. Add the edges for the PHI nodes. 637 // 4. Emit GEPs to get the original pointers. 638 // 5. Remove the original instructions. 639 Type *IndexType = IntegerType::get( 640 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 641 642 DenseMap<Value *, Value *> NewInsts; 643 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 644 645 // Create the new PHI nodes, without adding any incoming values. 646 for (Value *Val : Explored) { 647 if (Val == Base) 648 continue; 649 // Create empty phi nodes. This avoids cyclic dependencies when creating 650 // the remaining instructions. 651 if (auto *PHI = dyn_cast<PHINode>(Val)) 652 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 653 PHI->getName() + ".idx", PHI); 654 } 655 IRBuilder<> Builder(Base->getContext()); 656 657 // Create all the other instructions. 658 for (Value *Val : Explored) { 659 660 if (NewInsts.find(Val) != NewInsts.end()) 661 continue; 662 663 if (auto *CI = dyn_cast<CastInst>(Val)) { 664 // Don't get rid of the intermediate variable here; the store can grow 665 // the map which will invalidate the reference to the input value. 666 Value *V = NewInsts[CI->getOperand(0)]; 667 NewInsts[CI] = V; 668 continue; 669 } 670 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 671 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 672 : GEP->getOperand(1); 673 setInsertionPoint(Builder, GEP); 674 // Indices might need to be sign extended. GEPs will magically do 675 // this, but we need to do it ourselves here. 676 if (Index->getType()->getScalarSizeInBits() != 677 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 678 Index = Builder.CreateSExtOrTrunc( 679 Index, NewInsts[GEP->getOperand(0)]->getType(), 680 GEP->getOperand(0)->getName() + ".sext"); 681 } 682 683 auto *Op = NewInsts[GEP->getOperand(0)]; 684 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 685 NewInsts[GEP] = Index; 686 else 687 NewInsts[GEP] = Builder.CreateNSWAdd( 688 Op, Index, GEP->getOperand(0)->getName() + ".add"); 689 continue; 690 } 691 if (isa<PHINode>(Val)) 692 continue; 693 694 llvm_unreachable("Unexpected instruction type"); 695 } 696 697 // Add the incoming values to the PHI nodes. 698 for (Value *Val : Explored) { 699 if (Val == Base) 700 continue; 701 // All the instructions have been created, we can now add edges to the 702 // phi nodes. 703 if (auto *PHI = dyn_cast<PHINode>(Val)) { 704 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 705 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 706 Value *NewIncoming = PHI->getIncomingValue(I); 707 708 if (NewInsts.find(NewIncoming) != NewInsts.end()) 709 NewIncoming = NewInsts[NewIncoming]; 710 711 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 712 } 713 } 714 } 715 716 for (Value *Val : Explored) { 717 if (Val == Base) 718 continue; 719 720 // Depending on the type, for external users we have to emit 721 // a GEP or a GEP + ptrtoint. 722 setInsertionPoint(Builder, Val, false); 723 724 // If required, create an inttoptr instruction for Base. 725 Value *NewBase = Base; 726 if (!Base->getType()->isPointerTy()) 727 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 728 Start->getName() + "to.ptr"); 729 730 Value *GEP = Builder.CreateInBoundsGEP( 731 Start->getType()->getPointerElementType(), NewBase, 732 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 733 734 if (!Val->getType()->isPointerTy()) { 735 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 736 Val->getName() + ".conv"); 737 GEP = Cast; 738 } 739 Val->replaceAllUsesWith(GEP); 740 } 741 742 return NewInsts[Start]; 743 } 744 745 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 746 /// the input Value as a constant indexed GEP. Returns a pair containing 747 /// the GEPs Pointer and Index. 748 static std::pair<Value *, Value *> 749 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 750 Type *IndexType = IntegerType::get(V->getContext(), 751 DL.getIndexTypeSizeInBits(V->getType())); 752 753 Constant *Index = ConstantInt::getNullValue(IndexType); 754 while (true) { 755 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 756 // We accept only inbouds GEPs here to exclude the possibility of 757 // overflow. 758 if (!GEP->isInBounds()) 759 break; 760 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 761 GEP->getType() == V->getType()) { 762 V = GEP->getOperand(0); 763 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 764 Index = ConstantExpr::getAdd( 765 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 766 continue; 767 } 768 break; 769 } 770 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 771 if (!CI->isNoopCast(DL)) 772 break; 773 V = CI->getOperand(0); 774 continue; 775 } 776 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 777 if (!CI->isNoopCast(DL)) 778 break; 779 V = CI->getOperand(0); 780 continue; 781 } 782 break; 783 } 784 return {V, Index}; 785 } 786 787 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 788 /// We can look through PHIs, GEPs and casts in order to determine a common base 789 /// between GEPLHS and RHS. 790 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 791 ICmpInst::Predicate Cond, 792 const DataLayout &DL) { 793 // FIXME: Support vector of pointers. 794 if (GEPLHS->getType()->isVectorTy()) 795 return nullptr; 796 797 if (!GEPLHS->hasAllConstantIndices()) 798 return nullptr; 799 800 // Make sure the pointers have the same type. 801 if (GEPLHS->getType() != RHS->getType()) 802 return nullptr; 803 804 Value *PtrBase, *Index; 805 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 806 807 // The set of nodes that will take part in this transformation. 808 SetVector<Value *> Nodes; 809 810 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 811 return nullptr; 812 813 // We know we can re-write this as 814 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 815 // Since we've only looked through inbouds GEPs we know that we 816 // can't have overflow on either side. We can therefore re-write 817 // this as: 818 // OFFSET1 cmp OFFSET2 819 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 820 821 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 822 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 823 // offset. Since Index is the offset of LHS to the base pointer, we will now 824 // compare the offsets instead of comparing the pointers. 825 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 826 } 827 828 /// Fold comparisons between a GEP instruction and something else. At this point 829 /// we know that the GEP is on the LHS of the comparison. 830 Instruction *InstCombinerImpl::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 831 ICmpInst::Predicate Cond, 832 Instruction &I) { 833 // Don't transform signed compares of GEPs into index compares. Even if the 834 // GEP is inbounds, the final add of the base pointer can have signed overflow 835 // and would change the result of the icmp. 836 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 837 // the maximum signed value for the pointer type. 838 if (ICmpInst::isSigned(Cond)) 839 return nullptr; 840 841 // Look through bitcasts and addrspacecasts. We do not however want to remove 842 // 0 GEPs. 843 if (!isa<GetElementPtrInst>(RHS)) 844 RHS = RHS->stripPointerCasts(); 845 846 Value *PtrBase = GEPLHS->getOperand(0); 847 // FIXME: Support vector pointer GEPs. 848 if (PtrBase == RHS && GEPLHS->isInBounds() && 849 !GEPLHS->getType()->isVectorTy()) { 850 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 851 // This transformation (ignoring the base and scales) is valid because we 852 // know pointers can't overflow since the gep is inbounds. See if we can 853 // output an optimized form. 854 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 855 856 // If not, synthesize the offset the hard way. 857 if (!Offset) 858 Offset = EmitGEPOffset(GEPLHS); 859 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 860 Constant::getNullValue(Offset->getType())); 861 } 862 863 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 864 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 865 !NullPointerIsDefined(I.getFunction(), 866 RHS->getType()->getPointerAddressSpace())) { 867 // For most address spaces, an allocation can't be placed at null, but null 868 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 869 // the only valid inbounds address derived from null, is null itself. 870 // Thus, we have four cases to consider: 871 // 1) Base == nullptr, Offset == 0 -> inbounds, null 872 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 873 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 874 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 875 // 876 // (Note if we're indexing a type of size 0, that simply collapses into one 877 // of the buckets above.) 878 // 879 // In general, we're allowed to make values less poison (i.e. remove 880 // sources of full UB), so in this case, we just select between the two 881 // non-poison cases (1 and 4 above). 882 // 883 // For vectors, we apply the same reasoning on a per-lane basis. 884 auto *Base = GEPLHS->getPointerOperand(); 885 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 886 auto EC = cast<VectorType>(GEPLHS->getType())->getElementCount(); 887 Base = Builder.CreateVectorSplat(EC, Base); 888 } 889 return new ICmpInst(Cond, Base, 890 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 891 cast<Constant>(RHS), Base->getType())); 892 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 893 // If the base pointers are different, but the indices are the same, just 894 // compare the base pointer. 895 if (PtrBase != GEPRHS->getOperand(0)) { 896 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 897 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 898 GEPRHS->getOperand(0)->getType(); 899 if (IndicesTheSame) 900 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 901 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 902 IndicesTheSame = false; 903 break; 904 } 905 906 // If all indices are the same, just compare the base pointers. 907 Type *BaseType = GEPLHS->getOperand(0)->getType(); 908 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 909 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 910 911 // If we're comparing GEPs with two base pointers that only differ in type 912 // and both GEPs have only constant indices or just one use, then fold 913 // the compare with the adjusted indices. 914 // FIXME: Support vector of pointers. 915 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 916 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 917 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 918 PtrBase->stripPointerCasts() == 919 GEPRHS->getOperand(0)->stripPointerCasts() && 920 !GEPLHS->getType()->isVectorTy()) { 921 Value *LOffset = EmitGEPOffset(GEPLHS); 922 Value *ROffset = EmitGEPOffset(GEPRHS); 923 924 // If we looked through an addrspacecast between different sized address 925 // spaces, the LHS and RHS pointers are different sized 926 // integers. Truncate to the smaller one. 927 Type *LHSIndexTy = LOffset->getType(); 928 Type *RHSIndexTy = ROffset->getType(); 929 if (LHSIndexTy != RHSIndexTy) { 930 if (LHSIndexTy->getPrimitiveSizeInBits().getFixedSize() < 931 RHSIndexTy->getPrimitiveSizeInBits().getFixedSize()) { 932 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 933 } else 934 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 935 } 936 937 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 938 LOffset, ROffset); 939 return replaceInstUsesWith(I, Cmp); 940 } 941 942 // Otherwise, the base pointers are different and the indices are 943 // different. Try convert this to an indexed compare by looking through 944 // PHIs/casts. 945 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 946 } 947 948 // If one of the GEPs has all zero indices, recurse. 949 // FIXME: Handle vector of pointers. 950 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 951 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 952 ICmpInst::getSwappedPredicate(Cond), I); 953 954 // If the other GEP has all zero indices, recurse. 955 // FIXME: Handle vector of pointers. 956 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 957 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 958 959 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 960 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 961 // If the GEPs only differ by one index, compare it. 962 unsigned NumDifferences = 0; // Keep track of # differences. 963 unsigned DiffOperand = 0; // The operand that differs. 964 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 965 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 966 Type *LHSType = GEPLHS->getOperand(i)->getType(); 967 Type *RHSType = GEPRHS->getOperand(i)->getType(); 968 // FIXME: Better support for vector of pointers. 969 if (LHSType->getPrimitiveSizeInBits() != 970 RHSType->getPrimitiveSizeInBits() || 971 (GEPLHS->getType()->isVectorTy() && 972 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 973 // Irreconcilable differences. 974 NumDifferences = 2; 975 break; 976 } 977 978 if (NumDifferences++) break; 979 DiffOperand = i; 980 } 981 982 if (NumDifferences == 0) // SAME GEP? 983 return replaceInstUsesWith(I, // No comparison is needed here. 984 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 985 986 else if (NumDifferences == 1 && GEPsInBounds) { 987 Value *LHSV = GEPLHS->getOperand(DiffOperand); 988 Value *RHSV = GEPRHS->getOperand(DiffOperand); 989 // Make sure we do a signed comparison here. 990 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 991 } 992 } 993 994 // Only lower this if the icmp is the only user of the GEP or if we expect 995 // the result to fold to a constant! 996 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 997 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 998 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 999 Value *L = EmitGEPOffset(GEPLHS); 1000 Value *R = EmitGEPOffset(GEPRHS); 1001 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1002 } 1003 } 1004 1005 // Try convert this to an indexed compare by looking through PHIs/casts as a 1006 // last resort. 1007 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1008 } 1009 1010 Instruction *InstCombinerImpl::foldAllocaCmp(ICmpInst &ICI, 1011 const AllocaInst *Alloca, 1012 const Value *Other) { 1013 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1014 1015 // It would be tempting to fold away comparisons between allocas and any 1016 // pointer not based on that alloca (e.g. an argument). However, even 1017 // though such pointers cannot alias, they can still compare equal. 1018 // 1019 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1020 // doesn't escape we can argue that it's impossible to guess its value, and we 1021 // can therefore act as if any such guesses are wrong. 1022 // 1023 // The code below checks that the alloca doesn't escape, and that it's only 1024 // used in a comparison once (the current instruction). The 1025 // single-comparison-use condition ensures that we're trivially folding all 1026 // comparisons against the alloca consistently, and avoids the risk of 1027 // erroneously folding a comparison of the pointer with itself. 1028 1029 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1030 1031 SmallVector<const Use *, 32> Worklist; 1032 for (const Use &U : Alloca->uses()) { 1033 if (Worklist.size() >= MaxIter) 1034 return nullptr; 1035 Worklist.push_back(&U); 1036 } 1037 1038 unsigned NumCmps = 0; 1039 while (!Worklist.empty()) { 1040 assert(Worklist.size() <= MaxIter); 1041 const Use *U = Worklist.pop_back_val(); 1042 const Value *V = U->getUser(); 1043 --MaxIter; 1044 1045 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1046 isa<SelectInst>(V)) { 1047 // Track the uses. 1048 } else if (isa<LoadInst>(V)) { 1049 // Loading from the pointer doesn't escape it. 1050 continue; 1051 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1052 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1053 if (SI->getValueOperand() == U->get()) 1054 return nullptr; 1055 continue; 1056 } else if (isa<ICmpInst>(V)) { 1057 if (NumCmps++) 1058 return nullptr; // Found more than one cmp. 1059 continue; 1060 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1061 switch (Intrin->getIntrinsicID()) { 1062 // These intrinsics don't escape or compare the pointer. Memset is safe 1063 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1064 // we don't allow stores, so src cannot point to V. 1065 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1066 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1067 continue; 1068 default: 1069 return nullptr; 1070 } 1071 } else { 1072 return nullptr; 1073 } 1074 for (const Use &U : V->uses()) { 1075 if (Worklist.size() >= MaxIter) 1076 return nullptr; 1077 Worklist.push_back(&U); 1078 } 1079 } 1080 1081 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1082 return replaceInstUsesWith( 1083 ICI, 1084 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1085 } 1086 1087 /// Fold "icmp pred (X+C), X". 1088 Instruction *InstCombinerImpl::foldICmpAddOpConst(Value *X, const APInt &C, 1089 ICmpInst::Predicate Pred) { 1090 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1091 // so the values can never be equal. Similarly for all other "or equals" 1092 // operators. 1093 assert(!!C && "C should not be zero!"); 1094 1095 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1096 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1097 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1098 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1099 Constant *R = ConstantInt::get(X->getType(), 1100 APInt::getMaxValue(C.getBitWidth()) - C); 1101 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1102 } 1103 1104 // (X+1) >u X --> X <u (0-1) --> X != 255 1105 // (X+2) >u X --> X <u (0-2) --> X <u 254 1106 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1107 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1108 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1109 ConstantInt::get(X->getType(), -C)); 1110 1111 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1112 1113 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1114 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1115 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1116 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1117 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1118 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1119 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1120 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1121 ConstantInt::get(X->getType(), SMax - C)); 1122 1123 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1124 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1125 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1126 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1127 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1128 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1129 1130 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1131 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1132 ConstantInt::get(X->getType(), SMax - (C - 1))); 1133 } 1134 1135 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1136 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1137 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1138 Instruction *InstCombinerImpl::foldICmpShrConstConst(ICmpInst &I, Value *A, 1139 const APInt &AP1, 1140 const APInt &AP2) { 1141 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1142 1143 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1144 if (I.getPredicate() == I.ICMP_NE) 1145 Pred = CmpInst::getInversePredicate(Pred); 1146 return new ICmpInst(Pred, LHS, RHS); 1147 }; 1148 1149 // Don't bother doing any work for cases which InstSimplify handles. 1150 if (AP2.isZero()) 1151 return nullptr; 1152 1153 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1154 if (IsAShr) { 1155 if (AP2.isAllOnes()) 1156 return nullptr; 1157 if (AP2.isNegative() != AP1.isNegative()) 1158 return nullptr; 1159 if (AP2.sgt(AP1)) 1160 return nullptr; 1161 } 1162 1163 if (!AP1) 1164 // 'A' must be large enough to shift out the highest set bit. 1165 return getICmp(I.ICMP_UGT, A, 1166 ConstantInt::get(A->getType(), AP2.logBase2())); 1167 1168 if (AP1 == AP2) 1169 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1170 1171 int Shift; 1172 if (IsAShr && AP1.isNegative()) 1173 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1174 else 1175 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1176 1177 if (Shift > 0) { 1178 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1179 // There are multiple solutions if we are comparing against -1 and the LHS 1180 // of the ashr is not a power of two. 1181 if (AP1.isAllOnes() && !AP2.isPowerOf2()) 1182 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1183 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1184 } else if (AP1 == AP2.lshr(Shift)) { 1185 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1186 } 1187 } 1188 1189 // Shifting const2 will never be equal to const1. 1190 // FIXME: This should always be handled by InstSimplify? 1191 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1192 return replaceInstUsesWith(I, TorF); 1193 } 1194 1195 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1196 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1197 Instruction *InstCombinerImpl::foldICmpShlConstConst(ICmpInst &I, Value *A, 1198 const APInt &AP1, 1199 const APInt &AP2) { 1200 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1201 1202 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1203 if (I.getPredicate() == I.ICMP_NE) 1204 Pred = CmpInst::getInversePredicate(Pred); 1205 return new ICmpInst(Pred, LHS, RHS); 1206 }; 1207 1208 // Don't bother doing any work for cases which InstSimplify handles. 1209 if (AP2.isZero()) 1210 return nullptr; 1211 1212 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1213 1214 if (!AP1 && AP2TrailingZeros != 0) 1215 return getICmp( 1216 I.ICMP_UGE, A, 1217 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1218 1219 if (AP1 == AP2) 1220 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1221 1222 // Get the distance between the lowest bits that are set. 1223 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1224 1225 if (Shift > 0 && AP2.shl(Shift) == AP1) 1226 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1227 1228 // Shifting const2 will never be equal to const1. 1229 // FIXME: This should always be handled by InstSimplify? 1230 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1231 return replaceInstUsesWith(I, TorF); 1232 } 1233 1234 /// The caller has matched a pattern of the form: 1235 /// I = icmp ugt (add (add A, B), CI2), CI1 1236 /// If this is of the form: 1237 /// sum = a + b 1238 /// if (sum+128 >u 255) 1239 /// Then replace it with llvm.sadd.with.overflow.i8. 1240 /// 1241 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1242 ConstantInt *CI2, ConstantInt *CI1, 1243 InstCombinerImpl &IC) { 1244 // The transformation we're trying to do here is to transform this into an 1245 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1246 // with a narrower add, and discard the add-with-constant that is part of the 1247 // range check (if we can't eliminate it, this isn't profitable). 1248 1249 // In order to eliminate the add-with-constant, the compare can be its only 1250 // use. 1251 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1252 if (!AddWithCst->hasOneUse()) 1253 return nullptr; 1254 1255 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1256 if (!CI2->getValue().isPowerOf2()) 1257 return nullptr; 1258 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1259 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1260 return nullptr; 1261 1262 // The width of the new add formed is 1 more than the bias. 1263 ++NewWidth; 1264 1265 // Check to see that CI1 is an all-ones value with NewWidth bits. 1266 if (CI1->getBitWidth() == NewWidth || 1267 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1268 return nullptr; 1269 1270 // This is only really a signed overflow check if the inputs have been 1271 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1272 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1273 if (IC.ComputeMinSignedBits(A, 0, &I) > NewWidth || 1274 IC.ComputeMinSignedBits(B, 0, &I) > NewWidth) 1275 return nullptr; 1276 1277 // In order to replace the original add with a narrower 1278 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1279 // and truncates that discard the high bits of the add. Verify that this is 1280 // the case. 1281 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1282 for (User *U : OrigAdd->users()) { 1283 if (U == AddWithCst) 1284 continue; 1285 1286 // Only accept truncates for now. We would really like a nice recursive 1287 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1288 // chain to see which bits of a value are actually demanded. If the 1289 // original add had another add which was then immediately truncated, we 1290 // could still do the transformation. 1291 TruncInst *TI = dyn_cast<TruncInst>(U); 1292 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1293 return nullptr; 1294 } 1295 1296 // If the pattern matches, truncate the inputs to the narrower type and 1297 // use the sadd_with_overflow intrinsic to efficiently compute both the 1298 // result and the overflow bit. 1299 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1300 Function *F = Intrinsic::getDeclaration( 1301 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1302 1303 InstCombiner::BuilderTy &Builder = IC.Builder; 1304 1305 // Put the new code above the original add, in case there are any uses of the 1306 // add between the add and the compare. 1307 Builder.SetInsertPoint(OrigAdd); 1308 1309 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1310 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1311 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1312 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1313 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1314 1315 // The inner add was the result of the narrow add, zero extended to the 1316 // wider type. Replace it with the result computed by the intrinsic. 1317 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1318 IC.eraseInstFromFunction(*OrigAdd); 1319 1320 // The original icmp gets replaced with the overflow value. 1321 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1322 } 1323 1324 /// If we have: 1325 /// icmp eq/ne (urem/srem %x, %y), 0 1326 /// iff %y is a power-of-two, we can replace this with a bit test: 1327 /// icmp eq/ne (and %x, (add %y, -1)), 0 1328 Instruction *InstCombinerImpl::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1329 // This fold is only valid for equality predicates. 1330 if (!I.isEquality()) 1331 return nullptr; 1332 ICmpInst::Predicate Pred; 1333 Value *X, *Y, *Zero; 1334 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1335 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1336 return nullptr; 1337 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1338 return nullptr; 1339 // This may increase instruction count, we don't enforce that Y is a constant. 1340 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1341 Value *Masked = Builder.CreateAnd(X, Mask); 1342 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1343 } 1344 1345 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1346 /// by one-less-than-bitwidth into a sign test on the original value. 1347 Instruction *InstCombinerImpl::foldSignBitTest(ICmpInst &I) { 1348 Instruction *Val; 1349 ICmpInst::Predicate Pred; 1350 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1351 return nullptr; 1352 1353 Value *X; 1354 Type *XTy; 1355 1356 Constant *C; 1357 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1358 XTy = X->getType(); 1359 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1360 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1361 APInt(XBitWidth, XBitWidth - 1)))) 1362 return nullptr; 1363 } else if (isa<BinaryOperator>(Val) && 1364 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1365 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1366 /*AnalyzeForSignBitExtraction=*/true))) { 1367 XTy = X->getType(); 1368 } else 1369 return nullptr; 1370 1371 return ICmpInst::Create(Instruction::ICmp, 1372 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1373 : ICmpInst::ICMP_SLT, 1374 X, ConstantInt::getNullValue(XTy)); 1375 } 1376 1377 // Handle icmp pred X, 0 1378 Instruction *InstCombinerImpl::foldICmpWithZero(ICmpInst &Cmp) { 1379 CmpInst::Predicate Pred = Cmp.getPredicate(); 1380 if (!match(Cmp.getOperand(1), m_Zero())) 1381 return nullptr; 1382 1383 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1384 if (Pred == ICmpInst::ICMP_SGT) { 1385 Value *A, *B; 1386 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B); 1387 if (SPR.Flavor == SPF_SMIN) { 1388 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1389 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1390 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1391 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1392 } 1393 } 1394 1395 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1396 return New; 1397 1398 // Given: 1399 // icmp eq/ne (urem %x, %y), 0 1400 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1401 // icmp eq/ne %x, 0 1402 Value *X, *Y; 1403 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1404 ICmpInst::isEquality(Pred)) { 1405 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1406 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1407 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1408 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1409 } 1410 1411 return nullptr; 1412 } 1413 1414 /// Fold icmp Pred X, C. 1415 /// TODO: This code structure does not make sense. The saturating add fold 1416 /// should be moved to some other helper and extended as noted below (it is also 1417 /// possible that code has been made unnecessary - do we canonicalize IR to 1418 /// overflow/saturating intrinsics or not?). 1419 Instruction *InstCombinerImpl::foldICmpWithConstant(ICmpInst &Cmp) { 1420 // Match the following pattern, which is a common idiom when writing 1421 // overflow-safe integer arithmetic functions. The source performs an addition 1422 // in wider type and explicitly checks for overflow using comparisons against 1423 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1424 // 1425 // TODO: This could probably be generalized to handle other overflow-safe 1426 // operations if we worked out the formulas to compute the appropriate magic 1427 // constants. 1428 // 1429 // sum = a + b 1430 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1431 CmpInst::Predicate Pred = Cmp.getPredicate(); 1432 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1433 Value *A, *B; 1434 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1435 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1436 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1437 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1438 return Res; 1439 1440 // icmp(phi(C1, C2, ...), C) -> phi(icmp(C1, C), icmp(C2, C), ...). 1441 Constant *C = dyn_cast<Constant>(Op1); 1442 if (!C || C->canTrap()) 1443 return nullptr; 1444 1445 if (auto *Phi = dyn_cast<PHINode>(Op0)) 1446 if (all_of(Phi->operands(), [](Value *V) { return isa<Constant>(V); })) { 1447 Type *Ty = Cmp.getType(); 1448 Builder.SetInsertPoint(Phi); 1449 PHINode *NewPhi = 1450 Builder.CreatePHI(Ty, Phi->getNumOperands()); 1451 for (BasicBlock *Predecessor : predecessors(Phi->getParent())) { 1452 auto *Input = 1453 cast<Constant>(Phi->getIncomingValueForBlock(Predecessor)); 1454 auto *BoolInput = ConstantExpr::getCompare(Pred, Input, C); 1455 NewPhi->addIncoming(BoolInput, Predecessor); 1456 } 1457 NewPhi->takeName(&Cmp); 1458 return replaceInstUsesWith(Cmp, NewPhi); 1459 } 1460 1461 return nullptr; 1462 } 1463 1464 /// Canonicalize icmp instructions based on dominating conditions. 1465 Instruction *InstCombinerImpl::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1466 // This is a cheap/incomplete check for dominance - just match a single 1467 // predecessor with a conditional branch. 1468 BasicBlock *CmpBB = Cmp.getParent(); 1469 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1470 if (!DomBB) 1471 return nullptr; 1472 1473 Value *DomCond; 1474 BasicBlock *TrueBB, *FalseBB; 1475 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1476 return nullptr; 1477 1478 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1479 "Predecessor block does not point to successor?"); 1480 1481 // The branch should get simplified. Don't bother simplifying this condition. 1482 if (TrueBB == FalseBB) 1483 return nullptr; 1484 1485 // Try to simplify this compare to T/F based on the dominating condition. 1486 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1487 if (Imp) 1488 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1489 1490 CmpInst::Predicate Pred = Cmp.getPredicate(); 1491 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1492 ICmpInst::Predicate DomPred; 1493 const APInt *C, *DomC; 1494 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1495 match(Y, m_APInt(C))) { 1496 // We have 2 compares of a variable with constants. Calculate the constant 1497 // ranges of those compares to see if we can transform the 2nd compare: 1498 // DomBB: 1499 // DomCond = icmp DomPred X, DomC 1500 // br DomCond, CmpBB, FalseBB 1501 // CmpBB: 1502 // Cmp = icmp Pred X, C 1503 ConstantRange CR = ConstantRange::makeExactICmpRegion(Pred, *C); 1504 ConstantRange DominatingCR = 1505 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1506 : ConstantRange::makeExactICmpRegion( 1507 CmpInst::getInversePredicate(DomPred), *DomC); 1508 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1509 ConstantRange Difference = DominatingCR.difference(CR); 1510 if (Intersection.isEmptySet()) 1511 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1512 if (Difference.isEmptySet()) 1513 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1514 1515 // Canonicalizing a sign bit comparison that gets used in a branch, 1516 // pessimizes codegen by generating branch on zero instruction instead 1517 // of a test and branch. So we avoid canonicalizing in such situations 1518 // because test and branch instruction has better branch displacement 1519 // than compare and branch instruction. 1520 bool UnusedBit; 1521 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1522 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1523 return nullptr; 1524 1525 // Avoid an infinite loop with min/max canonicalization. 1526 // TODO: This will be unnecessary if we canonicalize to min/max intrinsics. 1527 if (Cmp.hasOneUse() && 1528 match(Cmp.user_back(), m_MaxOrMin(m_Value(), m_Value()))) 1529 return nullptr; 1530 1531 if (const APInt *EqC = Intersection.getSingleElement()) 1532 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1533 if (const APInt *NeC = Difference.getSingleElement()) 1534 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1535 } 1536 1537 return nullptr; 1538 } 1539 1540 /// Fold icmp (trunc X, Y), C. 1541 Instruction *InstCombinerImpl::foldICmpTruncConstant(ICmpInst &Cmp, 1542 TruncInst *Trunc, 1543 const APInt &C) { 1544 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1545 Value *X = Trunc->getOperand(0); 1546 if (C.isOne() && C.getBitWidth() > 1) { 1547 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1548 Value *V = nullptr; 1549 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1550 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1551 ConstantInt::get(V->getType(), 1)); 1552 } 1553 1554 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1555 SrcBits = X->getType()->getScalarSizeInBits(); 1556 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1557 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1558 // of the high bits truncated out of x are known. 1559 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1560 1561 // If all the high bits are known, we can do this xform. 1562 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1563 // Pull in the high bits from known-ones set. 1564 APInt NewRHS = C.zext(SrcBits); 1565 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1566 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1567 } 1568 } 1569 1570 // Look through truncated right-shift of the sign-bit for a sign-bit check: 1571 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] < 0 --> ShOp < 0 1572 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] > -1 --> ShOp > -1 1573 Value *ShOp; 1574 const APInt *ShAmtC; 1575 bool TrueIfSigned; 1576 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1577 match(X, m_Shr(m_Value(ShOp), m_APInt(ShAmtC))) && 1578 DstBits == SrcBits - ShAmtC->getZExtValue()) { 1579 return TrueIfSigned 1580 ? new ICmpInst(ICmpInst::ICMP_SLT, ShOp, 1581 ConstantInt::getNullValue(X->getType())) 1582 : new ICmpInst(ICmpInst::ICMP_SGT, ShOp, 1583 ConstantInt::getAllOnesValue(X->getType())); 1584 } 1585 1586 return nullptr; 1587 } 1588 1589 /// Fold icmp (xor X, Y), C. 1590 Instruction *InstCombinerImpl::foldICmpXorConstant(ICmpInst &Cmp, 1591 BinaryOperator *Xor, 1592 const APInt &C) { 1593 Value *X = Xor->getOperand(0); 1594 Value *Y = Xor->getOperand(1); 1595 const APInt *XorC; 1596 if (!match(Y, m_APInt(XorC))) 1597 return nullptr; 1598 1599 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1600 // fold the xor. 1601 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1602 bool TrueIfSigned = false; 1603 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1604 1605 // If the sign bit of the XorCst is not set, there is no change to 1606 // the operation, just stop using the Xor. 1607 if (!XorC->isNegative()) 1608 return replaceOperand(Cmp, 0, X); 1609 1610 // Emit the opposite comparison. 1611 if (TrueIfSigned) 1612 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1613 ConstantInt::getAllOnesValue(X->getType())); 1614 else 1615 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1616 ConstantInt::getNullValue(X->getType())); 1617 } 1618 1619 if (Xor->hasOneUse()) { 1620 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1621 if (!Cmp.isEquality() && XorC->isSignMask()) { 1622 Pred = Cmp.getFlippedSignednessPredicate(); 1623 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1624 } 1625 1626 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1627 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1628 Pred = Cmp.getFlippedSignednessPredicate(); 1629 Pred = Cmp.getSwappedPredicate(Pred); 1630 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1631 } 1632 } 1633 1634 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1635 if (Pred == ICmpInst::ICMP_UGT) { 1636 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1637 if (*XorC == ~C && (C + 1).isPowerOf2()) 1638 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1639 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1640 if (*XorC == C && (C + 1).isPowerOf2()) 1641 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1642 } 1643 if (Pred == ICmpInst::ICMP_ULT) { 1644 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1645 if (*XorC == -C && C.isPowerOf2()) 1646 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1647 ConstantInt::get(X->getType(), ~C)); 1648 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1649 if (*XorC == C && (-C).isPowerOf2()) 1650 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1651 ConstantInt::get(X->getType(), ~C)); 1652 } 1653 return nullptr; 1654 } 1655 1656 /// Fold icmp (and (sh X, Y), C2), C1. 1657 Instruction *InstCombinerImpl::foldICmpAndShift(ICmpInst &Cmp, 1658 BinaryOperator *And, 1659 const APInt &C1, 1660 const APInt &C2) { 1661 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1662 if (!Shift || !Shift->isShift()) 1663 return nullptr; 1664 1665 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1666 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1667 // code produced by the clang front-end, for bitfield access. 1668 // This seemingly simple opportunity to fold away a shift turns out to be 1669 // rather complicated. See PR17827 for details. 1670 unsigned ShiftOpcode = Shift->getOpcode(); 1671 bool IsShl = ShiftOpcode == Instruction::Shl; 1672 const APInt *C3; 1673 if (match(Shift->getOperand(1), m_APInt(C3))) { 1674 APInt NewAndCst, NewCmpCst; 1675 bool AnyCmpCstBitsShiftedOut; 1676 if (ShiftOpcode == Instruction::Shl) { 1677 // For a left shift, we can fold if the comparison is not signed. We can 1678 // also fold a signed comparison if the mask value and comparison value 1679 // are not negative. These constraints may not be obvious, but we can 1680 // prove that they are correct using an SMT solver. 1681 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1682 return nullptr; 1683 1684 NewCmpCst = C1.lshr(*C3); 1685 NewAndCst = C2.lshr(*C3); 1686 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1687 } else if (ShiftOpcode == Instruction::LShr) { 1688 // For a logical right shift, we can fold if the comparison is not signed. 1689 // We can also fold a signed comparison if the shifted mask value and the 1690 // shifted comparison value are not negative. These constraints may not be 1691 // obvious, but we can prove that they are correct using an SMT solver. 1692 NewCmpCst = C1.shl(*C3); 1693 NewAndCst = C2.shl(*C3); 1694 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1695 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1696 return nullptr; 1697 } else { 1698 // For an arithmetic shift, check that both constants don't use (in a 1699 // signed sense) the top bits being shifted out. 1700 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1701 NewCmpCst = C1.shl(*C3); 1702 NewAndCst = C2.shl(*C3); 1703 AnyCmpCstBitsShiftedOut = NewCmpCst.ashr(*C3) != C1; 1704 if (NewAndCst.ashr(*C3) != C2) 1705 return nullptr; 1706 } 1707 1708 if (AnyCmpCstBitsShiftedOut) { 1709 // If we shifted bits out, the fold is not going to work out. As a 1710 // special case, check to see if this means that the result is always 1711 // true or false now. 1712 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1713 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1714 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1715 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1716 } else { 1717 Value *NewAnd = Builder.CreateAnd( 1718 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1719 return new ICmpInst(Cmp.getPredicate(), 1720 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1721 } 1722 } 1723 1724 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1725 // preferable because it allows the C2 << Y expression to be hoisted out of a 1726 // loop if Y is invariant and X is not. 1727 if (Shift->hasOneUse() && C1.isZero() && Cmp.isEquality() && 1728 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1729 // Compute C2 << Y. 1730 Value *NewShift = 1731 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1732 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1733 1734 // Compute X & (C2 << Y). 1735 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1736 return replaceOperand(Cmp, 0, NewAnd); 1737 } 1738 1739 return nullptr; 1740 } 1741 1742 /// Fold icmp (and X, C2), C1. 1743 Instruction *InstCombinerImpl::foldICmpAndConstConst(ICmpInst &Cmp, 1744 BinaryOperator *And, 1745 const APInt &C1) { 1746 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1747 1748 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1749 // TODO: We canonicalize to the longer form for scalars because we have 1750 // better analysis/folds for icmp, and codegen may be better with icmp. 1751 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isZero() && 1752 match(And->getOperand(1), m_One())) 1753 return new TruncInst(And->getOperand(0), Cmp.getType()); 1754 1755 const APInt *C2; 1756 Value *X; 1757 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1758 return nullptr; 1759 1760 // Don't perform the following transforms if the AND has multiple uses 1761 if (!And->hasOneUse()) 1762 return nullptr; 1763 1764 if (Cmp.isEquality() && C1.isZero()) { 1765 // Restrict this fold to single-use 'and' (PR10267). 1766 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1767 if (C2->isSignMask()) { 1768 Constant *Zero = Constant::getNullValue(X->getType()); 1769 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1770 return new ICmpInst(NewPred, X, Zero); 1771 } 1772 1773 // Restrict this fold only for single-use 'and' (PR10267). 1774 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1775 if ((~(*C2) + 1).isPowerOf2()) { 1776 Constant *NegBOC = 1777 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1778 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1779 return new ICmpInst(NewPred, X, NegBOC); 1780 } 1781 } 1782 1783 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1784 // the input width without changing the value produced, eliminate the cast: 1785 // 1786 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1787 // 1788 // We can do this transformation if the constants do not have their sign bits 1789 // set or if it is an equality comparison. Extending a relational comparison 1790 // when we're checking the sign bit would not work. 1791 Value *W; 1792 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1793 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1794 // TODO: Is this a good transform for vectors? Wider types may reduce 1795 // throughput. Should this transform be limited (even for scalars) by using 1796 // shouldChangeType()? 1797 if (!Cmp.getType()->isVectorTy()) { 1798 Type *WideType = W->getType(); 1799 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1800 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1801 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1802 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1803 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1804 } 1805 } 1806 1807 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1808 return I; 1809 1810 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1811 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1812 // 1813 // iff pred isn't signed 1814 if (!Cmp.isSigned() && C1.isZero() && And->getOperand(0)->hasOneUse() && 1815 match(And->getOperand(1), m_One())) { 1816 Constant *One = cast<Constant>(And->getOperand(1)); 1817 Value *Or = And->getOperand(0); 1818 Value *A, *B, *LShr; 1819 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1820 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1821 unsigned UsesRemoved = 0; 1822 if (And->hasOneUse()) 1823 ++UsesRemoved; 1824 if (Or->hasOneUse()) 1825 ++UsesRemoved; 1826 if (LShr->hasOneUse()) 1827 ++UsesRemoved; 1828 1829 // Compute A & ((1 << B) | 1) 1830 Value *NewOr = nullptr; 1831 if (auto *C = dyn_cast<Constant>(B)) { 1832 if (UsesRemoved >= 1) 1833 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1834 } else { 1835 if (UsesRemoved >= 3) 1836 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1837 /*HasNUW=*/true), 1838 One, Or->getName()); 1839 } 1840 if (NewOr) { 1841 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1842 return replaceOperand(Cmp, 0, NewAnd); 1843 } 1844 } 1845 } 1846 1847 return nullptr; 1848 } 1849 1850 /// Fold icmp (and X, Y), C. 1851 Instruction *InstCombinerImpl::foldICmpAndConstant(ICmpInst &Cmp, 1852 BinaryOperator *And, 1853 const APInt &C) { 1854 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1855 return I; 1856 1857 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 1858 bool TrueIfNeg; 1859 if (isSignBitCheck(Pred, C, TrueIfNeg)) { 1860 // ((X - 1) & ~X) < 0 --> X == 0 1861 // ((X - 1) & ~X) >= 0 --> X != 0 1862 Value *X; 1863 if (match(And->getOperand(0), m_Add(m_Value(X), m_AllOnes())) && 1864 match(And->getOperand(1), m_Not(m_Specific(X)))) { 1865 auto NewPred = TrueIfNeg ? CmpInst::ICMP_EQ : CmpInst::ICMP_NE; 1866 return new ICmpInst(NewPred, X, ConstantInt::getNullValue(X->getType())); 1867 } 1868 } 1869 1870 // TODO: These all require that Y is constant too, so refactor with the above. 1871 1872 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1873 Value *X = And->getOperand(0); 1874 Value *Y = And->getOperand(1); 1875 if (auto *LI = dyn_cast<LoadInst>(X)) 1876 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1877 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1878 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1879 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1880 ConstantInt *C2 = cast<ConstantInt>(Y); 1881 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1882 return Res; 1883 } 1884 1885 if (!Cmp.isEquality()) 1886 return nullptr; 1887 1888 // X & -C == -C -> X > u ~C 1889 // X & -C != -C -> X <= u ~C 1890 // iff C is a power of 2 1891 if (Cmp.getOperand(1) == Y && C.isNegatedPowerOf2()) { 1892 auto NewPred = 1893 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT : CmpInst::ICMP_ULE; 1894 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1895 } 1896 1897 // (X & C2) == 0 -> (trunc X) >= 0 1898 // (X & C2) != 0 -> (trunc X) < 0 1899 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1900 const APInt *C2; 1901 if (And->hasOneUse() && C.isZero() && match(Y, m_APInt(C2))) { 1902 int32_t ExactLogBase2 = C2->exactLogBase2(); 1903 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1904 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1905 if (auto *AndVTy = dyn_cast<VectorType>(And->getType())) 1906 NTy = VectorType::get(NTy, AndVTy->getElementCount()); 1907 Value *Trunc = Builder.CreateTrunc(X, NTy); 1908 auto NewPred = 1909 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE : CmpInst::ICMP_SLT; 1910 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1911 } 1912 } 1913 1914 return nullptr; 1915 } 1916 1917 /// Fold icmp (or X, Y), C. 1918 Instruction *InstCombinerImpl::foldICmpOrConstant(ICmpInst &Cmp, 1919 BinaryOperator *Or, 1920 const APInt &C) { 1921 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1922 if (C.isOne()) { 1923 // icmp slt signum(V) 1 --> icmp slt V, 1 1924 Value *V = nullptr; 1925 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1926 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1927 ConstantInt::get(V->getType(), 1)); 1928 } 1929 1930 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1931 const APInt *MaskC; 1932 if (match(OrOp1, m_APInt(MaskC)) && Cmp.isEquality()) { 1933 if (*MaskC == C && (C + 1).isPowerOf2()) { 1934 // X | C == C --> X <=u C 1935 // X | C != C --> X >u C 1936 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1937 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1938 return new ICmpInst(Pred, OrOp0, OrOp1); 1939 } 1940 1941 // More general: canonicalize 'equality with set bits mask' to 1942 // 'equality with clear bits mask'. 1943 // (X | MaskC) == C --> (X & ~MaskC) == C ^ MaskC 1944 // (X | MaskC) != C --> (X & ~MaskC) != C ^ MaskC 1945 if (Or->hasOneUse()) { 1946 Value *And = Builder.CreateAnd(OrOp0, ~(*MaskC)); 1947 Constant *NewC = ConstantInt::get(Or->getType(), C ^ (*MaskC)); 1948 return new ICmpInst(Pred, And, NewC); 1949 } 1950 } 1951 1952 // (X | (X-1)) s< 0 --> X s< 1 1953 // (X | (X-1)) s> -1 --> X s> 0 1954 Value *X; 1955 bool TrueIfSigned; 1956 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1957 match(Or, m_c_Or(m_Add(m_Value(X), m_AllOnes()), m_Deferred(X)))) { 1958 auto NewPred = TrueIfSigned ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGT; 1959 Constant *NewC = ConstantInt::get(X->getType(), TrueIfSigned ? 1 : 0); 1960 return new ICmpInst(NewPred, X, NewC); 1961 } 1962 1963 if (!Cmp.isEquality() || !C.isZero() || !Or->hasOneUse()) 1964 return nullptr; 1965 1966 Value *P, *Q; 1967 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1968 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1969 // -> and (icmp eq P, null), (icmp eq Q, null). 1970 Value *CmpP = 1971 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1972 Value *CmpQ = 1973 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1974 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1975 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1976 } 1977 1978 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1979 // a shorter form that has more potential to be folded even further. 1980 Value *X1, *X2, *X3, *X4; 1981 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1982 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1983 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1984 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1985 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1986 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1987 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1988 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1989 } 1990 1991 return nullptr; 1992 } 1993 1994 /// Fold icmp (mul X, Y), C. 1995 Instruction *InstCombinerImpl::foldICmpMulConstant(ICmpInst &Cmp, 1996 BinaryOperator *Mul, 1997 const APInt &C) { 1998 const APInt *MulC; 1999 if (!match(Mul->getOperand(1), m_APInt(MulC))) 2000 return nullptr; 2001 2002 // If this is a test of the sign bit and the multiply is sign-preserving with 2003 // a constant operand, use the multiply LHS operand instead. 2004 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2005 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 2006 if (MulC->isNegative()) 2007 Pred = ICmpInst::getSwappedPredicate(Pred); 2008 return new ICmpInst(Pred, Mul->getOperand(0), 2009 Constant::getNullValue(Mul->getType())); 2010 } 2011 2012 // If the multiply does not wrap, try to divide the compare constant by the 2013 // multiplication factor. 2014 if (Cmp.isEquality() && !MulC->isZero()) { 2015 // (mul nsw X, MulC) == C --> X == C /s MulC 2016 if (Mul->hasNoSignedWrap() && C.srem(*MulC).isZero()) { 2017 Constant *NewC = ConstantInt::get(Mul->getType(), C.sdiv(*MulC)); 2018 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 2019 } 2020 // (mul nuw X, MulC) == C --> X == C /u MulC 2021 if (Mul->hasNoUnsignedWrap() && C.urem(*MulC).isZero()) { 2022 Constant *NewC = ConstantInt::get(Mul->getType(), C.udiv(*MulC)); 2023 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 2024 } 2025 } 2026 2027 return nullptr; 2028 } 2029 2030 /// Fold icmp (shl 1, Y), C. 2031 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 2032 const APInt &C) { 2033 Value *Y; 2034 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 2035 return nullptr; 2036 2037 Type *ShiftType = Shl->getType(); 2038 unsigned TypeBits = C.getBitWidth(); 2039 bool CIsPowerOf2 = C.isPowerOf2(); 2040 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2041 if (Cmp.isUnsigned()) { 2042 // (1 << Y) pred C -> Y pred Log2(C) 2043 if (!CIsPowerOf2) { 2044 // (1 << Y) < 30 -> Y <= 4 2045 // (1 << Y) <= 30 -> Y <= 4 2046 // (1 << Y) >= 30 -> Y > 4 2047 // (1 << Y) > 30 -> Y > 4 2048 if (Pred == ICmpInst::ICMP_ULT) 2049 Pred = ICmpInst::ICMP_ULE; 2050 else if (Pred == ICmpInst::ICMP_UGE) 2051 Pred = ICmpInst::ICMP_UGT; 2052 } 2053 2054 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 2055 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 2056 unsigned CLog2 = C.logBase2(); 2057 if (CLog2 == TypeBits - 1) { 2058 if (Pred == ICmpInst::ICMP_UGE) 2059 Pred = ICmpInst::ICMP_EQ; 2060 else if (Pred == ICmpInst::ICMP_ULT) 2061 Pred = ICmpInst::ICMP_NE; 2062 } 2063 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 2064 } else if (Cmp.isSigned()) { 2065 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 2066 if (C.isAllOnes()) { 2067 // (1 << Y) <= -1 -> Y == 31 2068 if (Pred == ICmpInst::ICMP_SLE) 2069 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2070 2071 // (1 << Y) > -1 -> Y != 31 2072 if (Pred == ICmpInst::ICMP_SGT) 2073 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2074 } else if (!C) { 2075 // (1 << Y) < 0 -> Y == 31 2076 // (1 << Y) <= 0 -> Y == 31 2077 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2078 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2079 2080 // (1 << Y) >= 0 -> Y != 31 2081 // (1 << Y) > 0 -> Y != 31 2082 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2083 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2084 } 2085 } else if (Cmp.isEquality() && CIsPowerOf2) { 2086 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2087 } 2088 2089 return nullptr; 2090 } 2091 2092 /// Fold icmp (shl X, Y), C. 2093 Instruction *InstCombinerImpl::foldICmpShlConstant(ICmpInst &Cmp, 2094 BinaryOperator *Shl, 2095 const APInt &C) { 2096 const APInt *ShiftVal; 2097 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2098 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2099 2100 const APInt *ShiftAmt; 2101 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2102 return foldICmpShlOne(Cmp, Shl, C); 2103 2104 // Check that the shift amount is in range. If not, don't perform undefined 2105 // shifts. When the shift is visited, it will be simplified. 2106 unsigned TypeBits = C.getBitWidth(); 2107 if (ShiftAmt->uge(TypeBits)) 2108 return nullptr; 2109 2110 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2111 Value *X = Shl->getOperand(0); 2112 Type *ShType = Shl->getType(); 2113 2114 // NSW guarantees that we are only shifting out sign bits from the high bits, 2115 // so we can ASHR the compare constant without needing a mask and eliminate 2116 // the shift. 2117 if (Shl->hasNoSignedWrap()) { 2118 if (Pred == ICmpInst::ICMP_SGT) { 2119 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2120 APInt ShiftedC = C.ashr(*ShiftAmt); 2121 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2122 } 2123 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2124 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2125 APInt ShiftedC = C.ashr(*ShiftAmt); 2126 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2127 } 2128 if (Pred == ICmpInst::ICMP_SLT) { 2129 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2130 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2131 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2132 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2133 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2134 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2135 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2136 } 2137 // If this is a signed comparison to 0 and the shift is sign preserving, 2138 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2139 // do that if we're sure to not continue on in this function. 2140 if (isSignTest(Pred, C)) 2141 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2142 } 2143 2144 // NUW guarantees that we are only shifting out zero bits from the high bits, 2145 // so we can LSHR the compare constant without needing a mask and eliminate 2146 // the shift. 2147 if (Shl->hasNoUnsignedWrap()) { 2148 if (Pred == ICmpInst::ICMP_UGT) { 2149 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2150 APInt ShiftedC = C.lshr(*ShiftAmt); 2151 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2152 } 2153 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2154 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2155 APInt ShiftedC = C.lshr(*ShiftAmt); 2156 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2157 } 2158 if (Pred == ICmpInst::ICMP_ULT) { 2159 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2160 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2161 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2162 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2163 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2164 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2165 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2166 } 2167 } 2168 2169 if (Cmp.isEquality() && Shl->hasOneUse()) { 2170 // Strength-reduce the shift into an 'and'. 2171 Constant *Mask = ConstantInt::get( 2172 ShType, 2173 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2174 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2175 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2176 return new ICmpInst(Pred, And, LShrC); 2177 } 2178 2179 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2180 bool TrueIfSigned = false; 2181 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2182 // (X << 31) <s 0 --> (X & 1) != 0 2183 Constant *Mask = ConstantInt::get( 2184 ShType, 2185 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2186 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2187 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2188 And, Constant::getNullValue(ShType)); 2189 } 2190 2191 // Simplify 'shl' inequality test into 'and' equality test. 2192 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2193 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2194 if ((C + 1).isPowerOf2() && 2195 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2196 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2197 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2198 : ICmpInst::ICMP_NE, 2199 And, Constant::getNullValue(ShType)); 2200 } 2201 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2202 if (C.isPowerOf2() && 2203 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2204 Value *And = 2205 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2206 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2207 : ICmpInst::ICMP_NE, 2208 And, Constant::getNullValue(ShType)); 2209 } 2210 } 2211 2212 // Transform (icmp pred iM (shl iM %v, N), C) 2213 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2214 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2215 // This enables us to get rid of the shift in favor of a trunc that may be 2216 // free on the target. It has the additional benefit of comparing to a 2217 // smaller constant that may be more target-friendly. 2218 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2219 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2220 DL.isLegalInteger(TypeBits - Amt)) { 2221 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2222 if (auto *ShVTy = dyn_cast<VectorType>(ShType)) 2223 TruncTy = VectorType::get(TruncTy, ShVTy->getElementCount()); 2224 Constant *NewC = 2225 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2226 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2227 } 2228 2229 return nullptr; 2230 } 2231 2232 /// Fold icmp ({al}shr X, Y), C. 2233 Instruction *InstCombinerImpl::foldICmpShrConstant(ICmpInst &Cmp, 2234 BinaryOperator *Shr, 2235 const APInt &C) { 2236 // An exact shr only shifts out zero bits, so: 2237 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2238 Value *X = Shr->getOperand(0); 2239 CmpInst::Predicate Pred = Cmp.getPredicate(); 2240 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && C.isZero()) 2241 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2242 2243 const APInt *ShiftVal; 2244 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2245 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2246 2247 const APInt *ShiftAmt; 2248 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2249 return nullptr; 2250 2251 // Check that the shift amount is in range. If not, don't perform undefined 2252 // shifts. When the shift is visited it will be simplified. 2253 unsigned TypeBits = C.getBitWidth(); 2254 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2255 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2256 return nullptr; 2257 2258 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2259 bool IsExact = Shr->isExact(); 2260 Type *ShrTy = Shr->getType(); 2261 // TODO: If we could guarantee that InstSimplify would handle all of the 2262 // constant-value-based preconditions in the folds below, then we could assert 2263 // those conditions rather than checking them. This is difficult because of 2264 // undef/poison (PR34838). 2265 if (IsAShr) { 2266 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2267 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2268 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2269 APInt ShiftedC = C.shl(ShAmtVal); 2270 if (ShiftedC.ashr(ShAmtVal) == C) 2271 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2272 } 2273 if (Pred == CmpInst::ICMP_SGT) { 2274 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2275 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2276 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2277 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2278 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2279 } 2280 2281 // If the compare constant has significant bits above the lowest sign-bit, 2282 // then convert an unsigned cmp to a test of the sign-bit: 2283 // (ashr X, ShiftC) u> C --> X s< 0 2284 // (ashr X, ShiftC) u< C --> X s> -1 2285 if (C.getBitWidth() > 2 && C.getNumSignBits() <= ShAmtVal) { 2286 if (Pred == CmpInst::ICMP_UGT) { 2287 return new ICmpInst(CmpInst::ICMP_SLT, X, 2288 ConstantInt::getNullValue(ShrTy)); 2289 } 2290 if (Pred == CmpInst::ICMP_ULT) { 2291 return new ICmpInst(CmpInst::ICMP_SGT, X, 2292 ConstantInt::getAllOnesValue(ShrTy)); 2293 } 2294 } 2295 } else { 2296 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2297 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2298 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2299 APInt ShiftedC = C.shl(ShAmtVal); 2300 if (ShiftedC.lshr(ShAmtVal) == C) 2301 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2302 } 2303 if (Pred == CmpInst::ICMP_UGT) { 2304 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2305 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2306 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2307 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2308 } 2309 } 2310 2311 if (!Cmp.isEquality()) 2312 return nullptr; 2313 2314 // Handle equality comparisons of shift-by-constant. 2315 2316 // If the comparison constant changes with the shift, the comparison cannot 2317 // succeed (bits of the comparison constant cannot match the shifted value). 2318 // This should be known by InstSimplify and already be folded to true/false. 2319 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2320 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2321 "Expected icmp+shr simplify did not occur."); 2322 2323 // If the bits shifted out are known zero, compare the unshifted value: 2324 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2325 if (Shr->isExact()) 2326 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2327 2328 if (C.isZero()) { 2329 // == 0 is u< 1. 2330 if (Pred == CmpInst::ICMP_EQ) 2331 return new ICmpInst(CmpInst::ICMP_ULT, X, 2332 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal))); 2333 else 2334 return new ICmpInst(CmpInst::ICMP_UGT, X, 2335 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal) - 1)); 2336 } 2337 2338 if (Shr->hasOneUse()) { 2339 // Canonicalize the shift into an 'and': 2340 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2341 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2342 Constant *Mask = ConstantInt::get(ShrTy, Val); 2343 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2344 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2345 } 2346 2347 return nullptr; 2348 } 2349 2350 Instruction *InstCombinerImpl::foldICmpSRemConstant(ICmpInst &Cmp, 2351 BinaryOperator *SRem, 2352 const APInt &C) { 2353 // Match an 'is positive' or 'is negative' comparison of remainder by a 2354 // constant power-of-2 value: 2355 // (X % pow2C) sgt/slt 0 2356 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2357 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT) 2358 return nullptr; 2359 2360 // TODO: The one-use check is standard because we do not typically want to 2361 // create longer instruction sequences, but this might be a special-case 2362 // because srem is not good for analysis or codegen. 2363 if (!SRem->hasOneUse()) 2364 return nullptr; 2365 2366 const APInt *DivisorC; 2367 if (!C.isZero() || !match(SRem->getOperand(1), m_Power2(DivisorC))) 2368 return nullptr; 2369 2370 // Mask off the sign bit and the modulo bits (low-bits). 2371 Type *Ty = SRem->getType(); 2372 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2373 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2374 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2375 2376 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2377 // bit is set. Example: 2378 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2379 if (Pred == ICmpInst::ICMP_SGT) 2380 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2381 2382 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2383 // bit is set. Example: 2384 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2385 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2386 } 2387 2388 /// Fold icmp (udiv X, Y), C. 2389 Instruction *InstCombinerImpl::foldICmpUDivConstant(ICmpInst &Cmp, 2390 BinaryOperator *UDiv, 2391 const APInt &C) { 2392 const APInt *C2; 2393 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2394 return nullptr; 2395 2396 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2397 2398 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2399 Value *Y = UDiv->getOperand(1); 2400 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2401 assert(!C.isMaxValue() && 2402 "icmp ugt X, UINT_MAX should have been simplified already."); 2403 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2404 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2405 } 2406 2407 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2408 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2409 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2410 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2411 ConstantInt::get(Y->getType(), C2->udiv(C))); 2412 } 2413 2414 return nullptr; 2415 } 2416 2417 /// Fold icmp ({su}div X, Y), C. 2418 Instruction *InstCombinerImpl::foldICmpDivConstant(ICmpInst &Cmp, 2419 BinaryOperator *Div, 2420 const APInt &C) { 2421 // Fold: icmp pred ([us]div X, C2), C -> range test 2422 // Fold this div into the comparison, producing a range check. 2423 // Determine, based on the divide type, what the range is being 2424 // checked. If there is an overflow on the low or high side, remember 2425 // it, otherwise compute the range [low, hi) bounding the new value. 2426 // See: InsertRangeTest above for the kinds of replacements possible. 2427 const APInt *C2; 2428 if (!match(Div->getOperand(1), m_APInt(C2))) 2429 return nullptr; 2430 2431 // FIXME: If the operand types don't match the type of the divide 2432 // then don't attempt this transform. The code below doesn't have the 2433 // logic to deal with a signed divide and an unsigned compare (and 2434 // vice versa). This is because (x /s C2) <s C produces different 2435 // results than (x /s C2) <u C or (x /u C2) <s C or even 2436 // (x /u C2) <u C. Simply casting the operands and result won't 2437 // work. :( The if statement below tests that condition and bails 2438 // if it finds it. 2439 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2440 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2441 return nullptr; 2442 2443 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2444 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2445 // division-by-constant cases should be present, we can not assert that they 2446 // have happened before we reach this icmp instruction. 2447 if (C2->isZero() || C2->isOne() || (DivIsSigned && C2->isAllOnes())) 2448 return nullptr; 2449 2450 // Compute Prod = C * C2. We are essentially solving an equation of 2451 // form X / C2 = C. We solve for X by multiplying C2 and C. 2452 // By solving for X, we can turn this into a range check instead of computing 2453 // a divide. 2454 APInt Prod = C * *C2; 2455 2456 // Determine if the product overflows by seeing if the product is not equal to 2457 // the divide. Make sure we do the same kind of divide as in the LHS 2458 // instruction that we're folding. 2459 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2460 2461 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2462 2463 // If the division is known to be exact, then there is no remainder from the 2464 // divide, so the covered range size is unit, otherwise it is the divisor. 2465 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2466 2467 // Figure out the interval that is being checked. For example, a comparison 2468 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2469 // Compute this interval based on the constants involved and the signedness of 2470 // the compare/divide. This computes a half-open interval, keeping track of 2471 // whether either value in the interval overflows. After analysis each 2472 // overflow variable is set to 0 if it's corresponding bound variable is valid 2473 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2474 int LoOverflow = 0, HiOverflow = 0; 2475 APInt LoBound, HiBound; 2476 2477 if (!DivIsSigned) { // udiv 2478 // e.g. X/5 op 3 --> [15, 20) 2479 LoBound = Prod; 2480 HiOverflow = LoOverflow = ProdOV; 2481 if (!HiOverflow) { 2482 // If this is not an exact divide, then many values in the range collapse 2483 // to the same result value. 2484 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2485 } 2486 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2487 if (C.isZero()) { // (X / pos) op 0 2488 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2489 LoBound = -(RangeSize - 1); 2490 HiBound = RangeSize; 2491 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2492 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2493 HiOverflow = LoOverflow = ProdOV; 2494 if (!HiOverflow) 2495 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2496 } else { // (X / pos) op neg 2497 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2498 HiBound = Prod + 1; 2499 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2500 if (!LoOverflow) { 2501 APInt DivNeg = -RangeSize; 2502 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2503 } 2504 } 2505 } else if (C2->isNegative()) { // Divisor is < 0. 2506 if (Div->isExact()) 2507 RangeSize.negate(); 2508 if (C.isZero()) { // (X / neg) op 0 2509 // e.g. X/-5 op 0 --> [-4, 5) 2510 LoBound = RangeSize + 1; 2511 HiBound = -RangeSize; 2512 if (HiBound == *C2) { // -INTMIN = INTMIN 2513 HiOverflow = 1; // [INTMIN+1, overflow) 2514 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2515 } 2516 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2517 // e.g. X/-5 op 3 --> [-19, -14) 2518 HiBound = Prod + 1; 2519 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2520 if (!LoOverflow) 2521 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2522 } else { // (X / neg) op neg 2523 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2524 LoOverflow = HiOverflow = ProdOV; 2525 if (!HiOverflow) 2526 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2527 } 2528 2529 // Dividing by a negative swaps the condition. LT <-> GT 2530 Pred = ICmpInst::getSwappedPredicate(Pred); 2531 } 2532 2533 Value *X = Div->getOperand(0); 2534 switch (Pred) { 2535 default: llvm_unreachable("Unhandled icmp opcode!"); 2536 case ICmpInst::ICMP_EQ: 2537 if (LoOverflow && HiOverflow) 2538 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2539 if (HiOverflow) 2540 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2541 ICmpInst::ICMP_UGE, X, 2542 ConstantInt::get(Div->getType(), LoBound)); 2543 if (LoOverflow) 2544 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2545 ICmpInst::ICMP_ULT, X, 2546 ConstantInt::get(Div->getType(), HiBound)); 2547 return replaceInstUsesWith( 2548 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2549 case ICmpInst::ICMP_NE: 2550 if (LoOverflow && HiOverflow) 2551 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2552 if (HiOverflow) 2553 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2554 ICmpInst::ICMP_ULT, X, 2555 ConstantInt::get(Div->getType(), LoBound)); 2556 if (LoOverflow) 2557 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2558 ICmpInst::ICMP_UGE, X, 2559 ConstantInt::get(Div->getType(), HiBound)); 2560 return replaceInstUsesWith(Cmp, 2561 insertRangeTest(X, LoBound, HiBound, 2562 DivIsSigned, false)); 2563 case ICmpInst::ICMP_ULT: 2564 case ICmpInst::ICMP_SLT: 2565 if (LoOverflow == +1) // Low bound is greater than input range. 2566 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2567 if (LoOverflow == -1) // Low bound is less than input range. 2568 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2569 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2570 case ICmpInst::ICMP_UGT: 2571 case ICmpInst::ICMP_SGT: 2572 if (HiOverflow == +1) // High bound greater than input range. 2573 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2574 if (HiOverflow == -1) // High bound less than input range. 2575 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2576 if (Pred == ICmpInst::ICMP_UGT) 2577 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2578 ConstantInt::get(Div->getType(), HiBound)); 2579 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2580 ConstantInt::get(Div->getType(), HiBound)); 2581 } 2582 2583 return nullptr; 2584 } 2585 2586 /// Fold icmp (sub X, Y), C. 2587 Instruction *InstCombinerImpl::foldICmpSubConstant(ICmpInst &Cmp, 2588 BinaryOperator *Sub, 2589 const APInt &C) { 2590 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2591 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2592 Type *Ty = Sub->getType(); 2593 2594 // (SubC - Y) == C) --> Y == (SubC - C) 2595 // (SubC - Y) != C) --> Y != (SubC - C) 2596 Constant *SubC; 2597 if (Cmp.isEquality() && match(X, m_ImmConstant(SubC))) { 2598 return new ICmpInst(Pred, Y, 2599 ConstantExpr::getSub(SubC, ConstantInt::get(Ty, C))); 2600 } 2601 2602 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2603 const APInt *C2; 2604 APInt SubResult; 2605 ICmpInst::Predicate SwappedPred = Cmp.getSwappedPredicate(); 2606 bool HasNSW = Sub->hasNoSignedWrap(); 2607 bool HasNUW = Sub->hasNoUnsignedWrap(); 2608 if (match(X, m_APInt(C2)) && 2609 ((Cmp.isUnsigned() && HasNUW) || (Cmp.isSigned() && HasNSW)) && 2610 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2611 return new ICmpInst(SwappedPred, Y, ConstantInt::get(Ty, SubResult)); 2612 2613 // The following transforms are only worth it if the only user of the subtract 2614 // is the icmp. 2615 // TODO: This is an artificial restriction for all of the transforms below 2616 // that only need a single replacement icmp. 2617 if (!Sub->hasOneUse()) 2618 return nullptr; 2619 2620 // X - Y == 0 --> X == Y. 2621 // X - Y != 0 --> X != Y. 2622 if (Cmp.isEquality() && C.isZero()) 2623 return new ICmpInst(Pred, X, Y); 2624 2625 if (Sub->hasNoSignedWrap()) { 2626 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2627 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnes()) 2628 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2629 2630 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2631 if (Pred == ICmpInst::ICMP_SGT && C.isZero()) 2632 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2633 2634 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2635 if (Pred == ICmpInst::ICMP_SLT && C.isZero()) 2636 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2637 2638 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2639 if (Pred == ICmpInst::ICMP_SLT && C.isOne()) 2640 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2641 } 2642 2643 if (!match(X, m_APInt(C2))) 2644 return nullptr; 2645 2646 // C2 - Y <u C -> (Y | (C - 1)) == C2 2647 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2648 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2649 (*C2 & (C - 1)) == (C - 1)) 2650 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2651 2652 // C2 - Y >u C -> (Y | C) != C2 2653 // iff C2 & C == C and C + 1 is a power of 2 2654 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2655 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2656 2657 // We have handled special cases that reduce. 2658 // Canonicalize any remaining sub to add as: 2659 // (C2 - Y) > C --> (Y + ~C2) < ~C 2660 Value *Add = Builder.CreateAdd(Y, ConstantInt::get(Ty, ~(*C2)), "notsub", 2661 HasNUW, HasNSW); 2662 return new ICmpInst(SwappedPred, Add, ConstantInt::get(Ty, ~C)); 2663 } 2664 2665 /// Fold icmp (add X, Y), C. 2666 Instruction *InstCombinerImpl::foldICmpAddConstant(ICmpInst &Cmp, 2667 BinaryOperator *Add, 2668 const APInt &C) { 2669 Value *Y = Add->getOperand(1); 2670 const APInt *C2; 2671 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2672 return nullptr; 2673 2674 // Fold icmp pred (add X, C2), C. 2675 Value *X = Add->getOperand(0); 2676 Type *Ty = Add->getType(); 2677 const CmpInst::Predicate Pred = Cmp.getPredicate(); 2678 2679 // If the add does not wrap, we can always adjust the compare by subtracting 2680 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2681 // are canonicalized to SGT/SLT/UGT/ULT. 2682 if ((Add->hasNoSignedWrap() && 2683 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2684 (Add->hasNoUnsignedWrap() && 2685 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2686 bool Overflow; 2687 APInt NewC = 2688 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2689 // If there is overflow, the result must be true or false. 2690 // TODO: Can we assert there is no overflow because InstSimplify always 2691 // handles those cases? 2692 if (!Overflow) 2693 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2694 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2695 } 2696 2697 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2698 const APInt &Upper = CR.getUpper(); 2699 const APInt &Lower = CR.getLower(); 2700 if (Cmp.isSigned()) { 2701 if (Lower.isSignMask()) 2702 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2703 if (Upper.isSignMask()) 2704 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2705 } else { 2706 if (Lower.isMinValue()) 2707 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2708 if (Upper.isMinValue()) 2709 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2710 } 2711 2712 // This set of folds is intentionally placed after folds that use no-wrapping 2713 // flags because those folds are likely better for later analysis/codegen. 2714 const APInt SMax = APInt::getSignedMaxValue(Ty->getScalarSizeInBits()); 2715 const APInt SMin = APInt::getSignedMinValue(Ty->getScalarSizeInBits()); 2716 2717 // Fold compare with offset to opposite sign compare if it eliminates offset: 2718 // (X + C2) >u C --> X <s -C2 (if C == C2 + SMAX) 2719 if (Pred == CmpInst::ICMP_UGT && C == *C2 + SMax) 2720 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, -(*C2))); 2721 2722 // (X + C2) <u C --> X >s ~C2 (if C == C2 + SMIN) 2723 if (Pred == CmpInst::ICMP_ULT && C == *C2 + SMin) 2724 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantInt::get(Ty, ~(*C2))); 2725 2726 // (X + C2) >s C --> X <u (SMAX - C) (if C == C2 - 1) 2727 if (Pred == CmpInst::ICMP_SGT && C == *C2 - 1) 2728 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, SMax - C)); 2729 2730 // (X + C2) <s C --> X >u (C ^ SMAX) (if C == C2) 2731 if (Pred == CmpInst::ICMP_SLT && C == *C2) 2732 return new ICmpInst(ICmpInst::ICMP_UGT, X, ConstantInt::get(Ty, C ^ SMax)); 2733 2734 if (!Add->hasOneUse()) 2735 return nullptr; 2736 2737 // X+C <u C2 -> (X & -C2) == C 2738 // iff C & (C2-1) == 0 2739 // C2 is a power of 2 2740 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2741 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2742 ConstantExpr::getNeg(cast<Constant>(Y))); 2743 2744 // X+C >u C2 -> (X & ~C2) != C 2745 // iff C & C2 == 0 2746 // C2+1 is a power of 2 2747 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2748 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2749 ConstantExpr::getNeg(cast<Constant>(Y))); 2750 2751 // The range test idiom can use either ult or ugt. Arbitrarily canonicalize 2752 // to the ult form. 2753 // X+C2 >u C -> X+(C2-C-1) <u ~C 2754 if (Pred == ICmpInst::ICMP_UGT) 2755 return new ICmpInst(ICmpInst::ICMP_ULT, 2756 Builder.CreateAdd(X, ConstantInt::get(Ty, *C2 - C - 1)), 2757 ConstantInt::get(Ty, ~C)); 2758 2759 return nullptr; 2760 } 2761 2762 bool InstCombinerImpl::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2763 Value *&RHS, ConstantInt *&Less, 2764 ConstantInt *&Equal, 2765 ConstantInt *&Greater) { 2766 // TODO: Generalize this to work with other comparison idioms or ensure 2767 // they get canonicalized into this form. 2768 2769 // select i1 (a == b), 2770 // i32 Equal, 2771 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2772 // where Equal, Less and Greater are placeholders for any three constants. 2773 ICmpInst::Predicate PredA; 2774 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2775 !ICmpInst::isEquality(PredA)) 2776 return false; 2777 Value *EqualVal = SI->getTrueValue(); 2778 Value *UnequalVal = SI->getFalseValue(); 2779 // We still can get non-canonical predicate here, so canonicalize. 2780 if (PredA == ICmpInst::ICMP_NE) 2781 std::swap(EqualVal, UnequalVal); 2782 if (!match(EqualVal, m_ConstantInt(Equal))) 2783 return false; 2784 ICmpInst::Predicate PredB; 2785 Value *LHS2, *RHS2; 2786 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2787 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2788 return false; 2789 // We can get predicate mismatch here, so canonicalize if possible: 2790 // First, ensure that 'LHS' match. 2791 if (LHS2 != LHS) { 2792 // x sgt y <--> y slt x 2793 std::swap(LHS2, RHS2); 2794 PredB = ICmpInst::getSwappedPredicate(PredB); 2795 } 2796 if (LHS2 != LHS) 2797 return false; 2798 // We also need to canonicalize 'RHS'. 2799 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2800 // x sgt C-1 <--> x sge C <--> not(x slt C) 2801 auto FlippedStrictness = 2802 InstCombiner::getFlippedStrictnessPredicateAndConstant( 2803 PredB, cast<Constant>(RHS2)); 2804 if (!FlippedStrictness) 2805 return false; 2806 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && 2807 "basic correctness failure"); 2808 RHS2 = FlippedStrictness->second; 2809 // And kind-of perform the result swap. 2810 std::swap(Less, Greater); 2811 PredB = ICmpInst::ICMP_SLT; 2812 } 2813 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2814 } 2815 2816 Instruction *InstCombinerImpl::foldICmpSelectConstant(ICmpInst &Cmp, 2817 SelectInst *Select, 2818 ConstantInt *C) { 2819 2820 assert(C && "Cmp RHS should be a constant int!"); 2821 // If we're testing a constant value against the result of a three way 2822 // comparison, the result can be expressed directly in terms of the 2823 // original values being compared. Note: We could possibly be more 2824 // aggressive here and remove the hasOneUse test. The original select is 2825 // really likely to simplify or sink when we remove a test of the result. 2826 Value *OrigLHS, *OrigRHS; 2827 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2828 if (Cmp.hasOneUse() && 2829 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2830 C3GreaterThan)) { 2831 assert(C1LessThan && C2Equal && C3GreaterThan); 2832 2833 bool TrueWhenLessThan = 2834 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2835 ->isAllOnesValue(); 2836 bool TrueWhenEqual = 2837 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2838 ->isAllOnesValue(); 2839 bool TrueWhenGreaterThan = 2840 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2841 ->isAllOnesValue(); 2842 2843 // This generates the new instruction that will replace the original Cmp 2844 // Instruction. Instead of enumerating the various combinations when 2845 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2846 // false, we rely on chaining of ORs and future passes of InstCombine to 2847 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2848 2849 // When none of the three constants satisfy the predicate for the RHS (C), 2850 // the entire original Cmp can be simplified to a false. 2851 Value *Cond = Builder.getFalse(); 2852 if (TrueWhenLessThan) 2853 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2854 OrigLHS, OrigRHS)); 2855 if (TrueWhenEqual) 2856 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2857 OrigLHS, OrigRHS)); 2858 if (TrueWhenGreaterThan) 2859 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2860 OrigLHS, OrigRHS)); 2861 2862 return replaceInstUsesWith(Cmp, Cond); 2863 } 2864 return nullptr; 2865 } 2866 2867 Instruction *InstCombinerImpl::foldICmpBitCast(ICmpInst &Cmp) { 2868 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2869 if (!Bitcast) 2870 return nullptr; 2871 2872 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2873 Value *Op1 = Cmp.getOperand(1); 2874 Value *BCSrcOp = Bitcast->getOperand(0); 2875 2876 // Make sure the bitcast doesn't change the number of vector elements. 2877 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2878 Bitcast->getDestTy()->getScalarSizeInBits()) { 2879 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2880 Value *X; 2881 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2882 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2883 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2884 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2885 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2886 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2887 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2888 match(Op1, m_Zero())) 2889 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2890 2891 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2892 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2893 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2894 2895 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2896 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2897 return new ICmpInst(Pred, X, 2898 ConstantInt::getAllOnesValue(X->getType())); 2899 } 2900 2901 // Zero-equality checks are preserved through unsigned floating-point casts: 2902 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2903 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2904 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2905 if (Cmp.isEquality() && match(Op1, m_Zero())) 2906 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2907 2908 // If this is a sign-bit test of a bitcast of a casted FP value, eliminate 2909 // the FP extend/truncate because that cast does not change the sign-bit. 2910 // This is true for all standard IEEE-754 types and the X86 80-bit type. 2911 // The sign-bit is always the most significant bit in those types. 2912 const APInt *C; 2913 bool TrueIfSigned; 2914 if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() && 2915 InstCombiner::isSignBitCheck(Pred, *C, TrueIfSigned)) { 2916 if (match(BCSrcOp, m_FPExt(m_Value(X))) || 2917 match(BCSrcOp, m_FPTrunc(m_Value(X)))) { 2918 // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0 2919 // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1 2920 Type *XType = X->getType(); 2921 2922 // We can't currently handle Power style floating point operations here. 2923 if (!(XType->isPPC_FP128Ty() || BCSrcOp->getType()->isPPC_FP128Ty())) { 2924 2925 Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits()); 2926 if (auto *XVTy = dyn_cast<VectorType>(XType)) 2927 NewType = VectorType::get(NewType, XVTy->getElementCount()); 2928 Value *NewBitcast = Builder.CreateBitCast(X, NewType); 2929 if (TrueIfSigned) 2930 return new ICmpInst(ICmpInst::ICMP_SLT, NewBitcast, 2931 ConstantInt::getNullValue(NewType)); 2932 else 2933 return new ICmpInst(ICmpInst::ICMP_SGT, NewBitcast, 2934 ConstantInt::getAllOnesValue(NewType)); 2935 } 2936 } 2937 } 2938 } 2939 2940 // Test to see if the operands of the icmp are casted versions of other 2941 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2942 if (Bitcast->getType()->isPointerTy() && 2943 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2944 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2945 // so eliminate it as well. 2946 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2947 Op1 = BC2->getOperand(0); 2948 2949 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2950 return new ICmpInst(Pred, BCSrcOp, Op1); 2951 } 2952 2953 const APInt *C; 2954 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2955 !Bitcast->getType()->isIntegerTy() || 2956 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2957 return nullptr; 2958 2959 // If this is checking if all elements of a vector compare are set or not, 2960 // invert the casted vector equality compare and test if all compare 2961 // elements are clear or not. Compare against zero is generally easier for 2962 // analysis and codegen. 2963 // icmp eq/ne (bitcast (not X) to iN), -1 --> icmp eq/ne (bitcast X to iN), 0 2964 // Example: are all elements equal? --> are zero elements not equal? 2965 // TODO: Try harder to reduce compare of 2 freely invertible operands? 2966 if (Cmp.isEquality() && C->isAllOnes() && Bitcast->hasOneUse() && 2967 isFreeToInvert(BCSrcOp, BCSrcOp->hasOneUse())) { 2968 Type *ScalarTy = Bitcast->getType(); 2969 Value *Cast = Builder.CreateBitCast(Builder.CreateNot(BCSrcOp), ScalarTy); 2970 return new ICmpInst(Pred, Cast, ConstantInt::getNullValue(ScalarTy)); 2971 } 2972 2973 // If this is checking if all elements of an extended vector are clear or not, 2974 // compare in a narrow type to eliminate the extend: 2975 // icmp eq/ne (bitcast (ext X) to iN), 0 --> icmp eq/ne (bitcast X to iM), 0 2976 Value *X; 2977 if (Cmp.isEquality() && C->isZero() && Bitcast->hasOneUse() && 2978 match(BCSrcOp, m_ZExtOrSExt(m_Value(X)))) { 2979 if (auto *VecTy = dyn_cast<FixedVectorType>(X->getType())) { 2980 Type *NewType = Builder.getIntNTy(VecTy->getPrimitiveSizeInBits()); 2981 Value *NewCast = Builder.CreateBitCast(X, NewType); 2982 return new ICmpInst(Pred, NewCast, ConstantInt::getNullValue(NewType)); 2983 } 2984 } 2985 2986 // Folding: icmp <pred> iN X, C 2987 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2988 // and C is a splat of a K-bit pattern 2989 // and SC is a constant vector = <C', C', C', ..., C'> 2990 // Into: 2991 // %E = extractelement <M x iK> %vec, i32 C' 2992 // icmp <pred> iK %E, trunc(C) 2993 Value *Vec; 2994 ArrayRef<int> Mask; 2995 if (match(BCSrcOp, m_Shuffle(m_Value(Vec), m_Undef(), m_Mask(Mask)))) { 2996 // Check whether every element of Mask is the same constant 2997 if (is_splat(Mask)) { 2998 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2999 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 3000 if (C->isSplat(EltTy->getBitWidth())) { 3001 // Fold the icmp based on the value of C 3002 // If C is M copies of an iK sized bit pattern, 3003 // then: 3004 // => %E = extractelement <N x iK> %vec, i32 Elem 3005 // icmp <pred> iK %SplatVal, <pattern> 3006 Value *Elem = Builder.getInt32(Mask[0]); 3007 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 3008 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 3009 return new ICmpInst(Pred, Extract, NewC); 3010 } 3011 } 3012 } 3013 return nullptr; 3014 } 3015 3016 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 3017 /// where X is some kind of instruction. 3018 Instruction *InstCombinerImpl::foldICmpInstWithConstant(ICmpInst &Cmp) { 3019 const APInt *C; 3020 if (!match(Cmp.getOperand(1), m_APInt(C))) 3021 return nullptr; 3022 3023 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 3024 switch (BO->getOpcode()) { 3025 case Instruction::Xor: 3026 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 3027 return I; 3028 break; 3029 case Instruction::And: 3030 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 3031 return I; 3032 break; 3033 case Instruction::Or: 3034 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 3035 return I; 3036 break; 3037 case Instruction::Mul: 3038 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 3039 return I; 3040 break; 3041 case Instruction::Shl: 3042 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 3043 return I; 3044 break; 3045 case Instruction::LShr: 3046 case Instruction::AShr: 3047 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 3048 return I; 3049 break; 3050 case Instruction::SRem: 3051 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, *C)) 3052 return I; 3053 break; 3054 case Instruction::UDiv: 3055 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 3056 return I; 3057 LLVM_FALLTHROUGH; 3058 case Instruction::SDiv: 3059 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 3060 return I; 3061 break; 3062 case Instruction::Sub: 3063 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 3064 return I; 3065 break; 3066 case Instruction::Add: 3067 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 3068 return I; 3069 break; 3070 default: 3071 break; 3072 } 3073 // TODO: These folds could be refactored to be part of the above calls. 3074 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 3075 return I; 3076 } 3077 3078 // Match against CmpInst LHS being instructions other than binary operators. 3079 3080 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 3081 // For now, we only support constant integers while folding the 3082 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 3083 // similar to the cases handled by binary ops above. 3084 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 3085 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 3086 return I; 3087 } 3088 3089 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 3090 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 3091 return I; 3092 } 3093 3094 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 3095 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 3096 return I; 3097 3098 return nullptr; 3099 } 3100 3101 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 3102 /// icmp eq/ne BO, C. 3103 Instruction *InstCombinerImpl::foldICmpBinOpEqualityWithConstant( 3104 ICmpInst &Cmp, BinaryOperator *BO, const APInt &C) { 3105 // TODO: Some of these folds could work with arbitrary constants, but this 3106 // function is limited to scalar and vector splat constants. 3107 if (!Cmp.isEquality()) 3108 return nullptr; 3109 3110 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3111 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 3112 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 3113 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 3114 3115 switch (BO->getOpcode()) { 3116 case Instruction::SRem: 3117 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 3118 if (C.isZero() && BO->hasOneUse()) { 3119 const APInt *BOC; 3120 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 3121 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 3122 return new ICmpInst(Pred, NewRem, 3123 Constant::getNullValue(BO->getType())); 3124 } 3125 } 3126 break; 3127 case Instruction::Add: { 3128 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 3129 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3130 if (BO->hasOneUse()) 3131 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 3132 } else if (C.isZero()) { 3133 // Replace ((add A, B) != 0) with (A != -B) if A or B is 3134 // efficiently invertible, or if the add has just this one use. 3135 if (Value *NegVal = dyn_castNegVal(BOp1)) 3136 return new ICmpInst(Pred, BOp0, NegVal); 3137 if (Value *NegVal = dyn_castNegVal(BOp0)) 3138 return new ICmpInst(Pred, NegVal, BOp1); 3139 if (BO->hasOneUse()) { 3140 Value *Neg = Builder.CreateNeg(BOp1); 3141 Neg->takeName(BO); 3142 return new ICmpInst(Pred, BOp0, Neg); 3143 } 3144 } 3145 break; 3146 } 3147 case Instruction::Xor: 3148 if (BO->hasOneUse()) { 3149 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3150 // For the xor case, we can xor two constants together, eliminating 3151 // the explicit xor. 3152 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 3153 } else if (C.isZero()) { 3154 // Replace ((xor A, B) != 0) with (A != B) 3155 return new ICmpInst(Pred, BOp0, BOp1); 3156 } 3157 } 3158 break; 3159 case Instruction::Or: { 3160 const APInt *BOC; 3161 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 3162 // Comparing if all bits outside of a constant mask are set? 3163 // Replace (X | C) == -1 with (X & ~C) == ~C. 3164 // This removes the -1 constant. 3165 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 3166 Value *And = Builder.CreateAnd(BOp0, NotBOC); 3167 return new ICmpInst(Pred, And, NotBOC); 3168 } 3169 break; 3170 } 3171 case Instruction::And: { 3172 const APInt *BOC; 3173 if (match(BOp1, m_APInt(BOC))) { 3174 // If we have ((X & C) == C), turn it into ((X & C) != 0). 3175 if (C == *BOC && C.isPowerOf2()) 3176 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 3177 BO, Constant::getNullValue(RHS->getType())); 3178 } 3179 break; 3180 } 3181 case Instruction::UDiv: 3182 if (C.isZero()) { 3183 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3184 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3185 return new ICmpInst(NewPred, BOp1, BOp0); 3186 } 3187 break; 3188 default: 3189 break; 3190 } 3191 return nullptr; 3192 } 3193 3194 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3195 Instruction *InstCombinerImpl::foldICmpEqIntrinsicWithConstant( 3196 ICmpInst &Cmp, IntrinsicInst *II, const APInt &C) { 3197 Type *Ty = II->getType(); 3198 unsigned BitWidth = C.getBitWidth(); 3199 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 3200 3201 switch (II->getIntrinsicID()) { 3202 case Intrinsic::abs: 3203 // abs(A) == 0 -> A == 0 3204 // abs(A) == INT_MIN -> A == INT_MIN 3205 if (C.isZero() || C.isMinSignedValue()) 3206 return new ICmpInst(Pred, II->getArgOperand(0), ConstantInt::get(Ty, C)); 3207 break; 3208 3209 case Intrinsic::bswap: 3210 // bswap(A) == C -> A == bswap(C) 3211 return new ICmpInst(Pred, II->getArgOperand(0), 3212 ConstantInt::get(Ty, C.byteSwap())); 3213 3214 case Intrinsic::ctlz: 3215 case Intrinsic::cttz: { 3216 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3217 if (C == BitWidth) 3218 return new ICmpInst(Pred, II->getArgOperand(0), 3219 ConstantInt::getNullValue(Ty)); 3220 3221 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3222 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3223 // Limit to one use to ensure we don't increase instruction count. 3224 unsigned Num = C.getLimitedValue(BitWidth); 3225 if (Num != BitWidth && II->hasOneUse()) { 3226 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3227 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3228 : APInt::getHighBitsSet(BitWidth, Num + 1); 3229 APInt Mask2 = IsTrailing 3230 ? APInt::getOneBitSet(BitWidth, Num) 3231 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3232 return new ICmpInst(Pred, Builder.CreateAnd(II->getArgOperand(0), Mask1), 3233 ConstantInt::get(Ty, Mask2)); 3234 } 3235 break; 3236 } 3237 3238 case Intrinsic::ctpop: { 3239 // popcount(A) == 0 -> A == 0 and likewise for != 3240 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3241 bool IsZero = C.isZero(); 3242 if (IsZero || C == BitWidth) 3243 return new ICmpInst(Pred, II->getArgOperand(0), 3244 IsZero ? Constant::getNullValue(Ty) 3245 : Constant::getAllOnesValue(Ty)); 3246 3247 break; 3248 } 3249 3250 case Intrinsic::fshl: 3251 case Intrinsic::fshr: 3252 if (II->getArgOperand(0) == II->getArgOperand(1)) { 3253 // (rot X, ?) == 0/-1 --> X == 0/-1 3254 // TODO: This transform is safe to re-use undef elts in a vector, but 3255 // the constant value passed in by the caller doesn't allow that. 3256 if (C.isZero() || C.isAllOnes()) 3257 return new ICmpInst(Pred, II->getArgOperand(0), Cmp.getOperand(1)); 3258 3259 const APInt *RotAmtC; 3260 // ror(X, RotAmtC) == C --> X == rol(C, RotAmtC) 3261 // rol(X, RotAmtC) == C --> X == ror(C, RotAmtC) 3262 if (match(II->getArgOperand(2), m_APInt(RotAmtC))) 3263 return new ICmpInst(Pred, II->getArgOperand(0), 3264 II->getIntrinsicID() == Intrinsic::fshl 3265 ? ConstantInt::get(Ty, C.rotr(*RotAmtC)) 3266 : ConstantInt::get(Ty, C.rotl(*RotAmtC))); 3267 } 3268 break; 3269 3270 case Intrinsic::uadd_sat: { 3271 // uadd.sat(a, b) == 0 -> (a | b) == 0 3272 if (C.isZero()) { 3273 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3274 return new ICmpInst(Pred, Or, Constant::getNullValue(Ty)); 3275 } 3276 break; 3277 } 3278 3279 case Intrinsic::usub_sat: { 3280 // usub.sat(a, b) == 0 -> a <= b 3281 if (C.isZero()) { 3282 ICmpInst::Predicate NewPred = 3283 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3284 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3285 } 3286 break; 3287 } 3288 default: 3289 break; 3290 } 3291 3292 return nullptr; 3293 } 3294 3295 /// Fold an icmp with LLVM intrinsics 3296 static Instruction *foldICmpIntrinsicWithIntrinsic(ICmpInst &Cmp) { 3297 assert(Cmp.isEquality()); 3298 3299 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3300 Value *Op0 = Cmp.getOperand(0); 3301 Value *Op1 = Cmp.getOperand(1); 3302 const auto *IIOp0 = dyn_cast<IntrinsicInst>(Op0); 3303 const auto *IIOp1 = dyn_cast<IntrinsicInst>(Op1); 3304 if (!IIOp0 || !IIOp1 || IIOp0->getIntrinsicID() != IIOp1->getIntrinsicID()) 3305 return nullptr; 3306 3307 switch (IIOp0->getIntrinsicID()) { 3308 case Intrinsic::bswap: 3309 case Intrinsic::bitreverse: 3310 // If both operands are byte-swapped or bit-reversed, just compare the 3311 // original values. 3312 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3313 case Intrinsic::fshl: 3314 case Intrinsic::fshr: 3315 // If both operands are rotated by same amount, just compare the 3316 // original values. 3317 if (IIOp0->getOperand(0) != IIOp0->getOperand(1)) 3318 break; 3319 if (IIOp1->getOperand(0) != IIOp1->getOperand(1)) 3320 break; 3321 if (IIOp0->getOperand(2) != IIOp1->getOperand(2)) 3322 break; 3323 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3324 default: 3325 break; 3326 } 3327 3328 return nullptr; 3329 } 3330 3331 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3332 Instruction *InstCombinerImpl::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3333 IntrinsicInst *II, 3334 const APInt &C) { 3335 if (Cmp.isEquality()) 3336 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3337 3338 Type *Ty = II->getType(); 3339 unsigned BitWidth = C.getBitWidth(); 3340 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3341 switch (II->getIntrinsicID()) { 3342 case Intrinsic::ctpop: { 3343 // (ctpop X > BitWidth - 1) --> X == -1 3344 Value *X = II->getArgOperand(0); 3345 if (C == BitWidth - 1 && Pred == ICmpInst::ICMP_UGT) 3346 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, X, 3347 ConstantInt::getAllOnesValue(Ty)); 3348 // (ctpop X < BitWidth) --> X != -1 3349 if (C == BitWidth && Pred == ICmpInst::ICMP_ULT) 3350 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, X, 3351 ConstantInt::getAllOnesValue(Ty)); 3352 break; 3353 } 3354 case Intrinsic::ctlz: { 3355 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3356 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3357 unsigned Num = C.getLimitedValue(); 3358 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3359 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3360 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3361 } 3362 3363 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3364 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3365 unsigned Num = C.getLimitedValue(); 3366 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3367 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3368 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3369 } 3370 break; 3371 } 3372 case Intrinsic::cttz: { 3373 // Limit to one use to ensure we don't increase instruction count. 3374 if (!II->hasOneUse()) 3375 return nullptr; 3376 3377 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3378 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3379 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3380 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3381 Builder.CreateAnd(II->getArgOperand(0), Mask), 3382 ConstantInt::getNullValue(Ty)); 3383 } 3384 3385 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3386 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3387 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3388 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3389 Builder.CreateAnd(II->getArgOperand(0), Mask), 3390 ConstantInt::getNullValue(Ty)); 3391 } 3392 break; 3393 } 3394 default: 3395 break; 3396 } 3397 3398 return nullptr; 3399 } 3400 3401 /// Handle icmp with constant (but not simple integer constant) RHS. 3402 Instruction *InstCombinerImpl::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3403 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3404 Constant *RHSC = dyn_cast<Constant>(Op1); 3405 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3406 if (!RHSC || !LHSI) 3407 return nullptr; 3408 3409 switch (LHSI->getOpcode()) { 3410 case Instruction::GetElementPtr: 3411 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3412 if (RHSC->isNullValue() && 3413 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3414 return new ICmpInst( 3415 I.getPredicate(), LHSI->getOperand(0), 3416 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3417 break; 3418 case Instruction::PHI: 3419 // Only fold icmp into the PHI if the phi and icmp are in the same 3420 // block. If in the same block, we're encouraging jump threading. If 3421 // not, we are just pessimizing the code by making an i1 phi. 3422 if (LHSI->getParent() == I.getParent()) 3423 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3424 return NV; 3425 break; 3426 case Instruction::Select: { 3427 // If either operand of the select is a constant, we can fold the 3428 // comparison into the select arms, which will cause one to be 3429 // constant folded and the select turned into a bitwise or. 3430 Value *Op1 = nullptr, *Op2 = nullptr; 3431 ConstantInt *CI = nullptr; 3432 3433 auto SimplifyOp = [&](Value *V) { 3434 Value *Op = nullptr; 3435 if (Constant *C = dyn_cast<Constant>(V)) { 3436 Op = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3437 } else if (RHSC->isNullValue()) { 3438 // If null is being compared, check if it can be further simplified. 3439 Op = SimplifyICmpInst(I.getPredicate(), V, RHSC, SQ); 3440 } 3441 return Op; 3442 }; 3443 Op1 = SimplifyOp(LHSI->getOperand(1)); 3444 if (Op1) 3445 CI = dyn_cast<ConstantInt>(Op1); 3446 3447 Op2 = SimplifyOp(LHSI->getOperand(2)); 3448 if (Op2) 3449 CI = dyn_cast<ConstantInt>(Op2); 3450 3451 // We only want to perform this transformation if it will not lead to 3452 // additional code. This is true if either both sides of the select 3453 // fold to a constant (in which case the icmp is replaced with a select 3454 // which will usually simplify) or this is the only user of the 3455 // select (in which case we are trading a select+icmp for a simpler 3456 // select+icmp) or all uses of the select can be replaced based on 3457 // dominance information ("Global cases"). 3458 bool Transform = false; 3459 if (Op1 && Op2) 3460 Transform = true; 3461 else if (Op1 || Op2) { 3462 // Local case 3463 if (LHSI->hasOneUse()) 3464 Transform = true; 3465 // Global cases 3466 else if (CI && !CI->isZero()) 3467 // When Op1 is constant try replacing select with second operand. 3468 // Otherwise Op2 is constant and try replacing select with first 3469 // operand. 3470 Transform = 3471 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 3472 } 3473 if (Transform) { 3474 if (!Op1) 3475 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 3476 I.getName()); 3477 if (!Op2) 3478 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 3479 I.getName()); 3480 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 3481 } 3482 break; 3483 } 3484 case Instruction::IntToPtr: 3485 // icmp pred inttoptr(X), null -> icmp pred X, 0 3486 if (RHSC->isNullValue() && 3487 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3488 return new ICmpInst( 3489 I.getPredicate(), LHSI->getOperand(0), 3490 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3491 break; 3492 3493 case Instruction::Load: 3494 // Try to optimize things like "A[i] > 4" to index computations. 3495 if (GetElementPtrInst *GEP = 3496 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 3497 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3498 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 3499 !cast<LoadInst>(LHSI)->isVolatile()) 3500 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 3501 return Res; 3502 } 3503 break; 3504 } 3505 3506 return nullptr; 3507 } 3508 3509 /// Some comparisons can be simplified. 3510 /// In this case, we are looking for comparisons that look like 3511 /// a check for a lossy truncation. 3512 /// Folds: 3513 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3514 /// Where Mask is some pattern that produces all-ones in low bits: 3515 /// (-1 >> y) 3516 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3517 /// ~(-1 << y) 3518 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3519 /// The Mask can be a constant, too. 3520 /// For some predicates, the operands are commutative. 3521 /// For others, x can only be on a specific side. 3522 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3523 InstCombiner::BuilderTy &Builder) { 3524 ICmpInst::Predicate SrcPred; 3525 Value *X, *M, *Y; 3526 auto m_VariableMask = m_CombineOr( 3527 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3528 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3529 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3530 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3531 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3532 if (!match(&I, m_c_ICmp(SrcPred, 3533 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3534 m_Deferred(X)))) 3535 return nullptr; 3536 3537 ICmpInst::Predicate DstPred; 3538 switch (SrcPred) { 3539 case ICmpInst::Predicate::ICMP_EQ: 3540 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3541 DstPred = ICmpInst::Predicate::ICMP_ULE; 3542 break; 3543 case ICmpInst::Predicate::ICMP_NE: 3544 // x & (-1 >> y) != x -> x u> (-1 >> y) 3545 DstPred = ICmpInst::Predicate::ICMP_UGT; 3546 break; 3547 case ICmpInst::Predicate::ICMP_ULT: 3548 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3549 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3550 DstPred = ICmpInst::Predicate::ICMP_UGT; 3551 break; 3552 case ICmpInst::Predicate::ICMP_UGE: 3553 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3554 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3555 DstPred = ICmpInst::Predicate::ICMP_ULE; 3556 break; 3557 case ICmpInst::Predicate::ICMP_SLT: 3558 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3559 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3560 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3561 return nullptr; 3562 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3563 return nullptr; 3564 DstPred = ICmpInst::Predicate::ICMP_SGT; 3565 break; 3566 case ICmpInst::Predicate::ICMP_SGE: 3567 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3568 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3569 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3570 return nullptr; 3571 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3572 return nullptr; 3573 DstPred = ICmpInst::Predicate::ICMP_SLE; 3574 break; 3575 case ICmpInst::Predicate::ICMP_SGT: 3576 case ICmpInst::Predicate::ICMP_SLE: 3577 return nullptr; 3578 case ICmpInst::Predicate::ICMP_UGT: 3579 case ICmpInst::Predicate::ICMP_ULE: 3580 llvm_unreachable("Instsimplify took care of commut. variant"); 3581 break; 3582 default: 3583 llvm_unreachable("All possible folds are handled."); 3584 } 3585 3586 // The mask value may be a vector constant that has undefined elements. But it 3587 // may not be safe to propagate those undefs into the new compare, so replace 3588 // those elements by copying an existing, defined, and safe scalar constant. 3589 Type *OpTy = M->getType(); 3590 auto *VecC = dyn_cast<Constant>(M); 3591 auto *OpVTy = dyn_cast<FixedVectorType>(OpTy); 3592 if (OpVTy && VecC && VecC->containsUndefOrPoisonElement()) { 3593 Constant *SafeReplacementConstant = nullptr; 3594 for (unsigned i = 0, e = OpVTy->getNumElements(); i != e; ++i) { 3595 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3596 SafeReplacementConstant = VecC->getAggregateElement(i); 3597 break; 3598 } 3599 } 3600 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3601 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3602 } 3603 3604 return Builder.CreateICmp(DstPred, X, M); 3605 } 3606 3607 /// Some comparisons can be simplified. 3608 /// In this case, we are looking for comparisons that look like 3609 /// a check for a lossy signed truncation. 3610 /// Folds: (MaskedBits is a constant.) 3611 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3612 /// Into: 3613 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3614 /// Where KeptBits = bitwidth(%x) - MaskedBits 3615 static Value * 3616 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3617 InstCombiner::BuilderTy &Builder) { 3618 ICmpInst::Predicate SrcPred; 3619 Value *X; 3620 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3621 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3622 if (!match(&I, m_c_ICmp(SrcPred, 3623 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3624 m_APInt(C1))), 3625 m_Deferred(X)))) 3626 return nullptr; 3627 3628 // Potential handling of non-splats: for each element: 3629 // * if both are undef, replace with constant 0. 3630 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3631 // * if both are not undef, and are different, bailout. 3632 // * else, only one is undef, then pick the non-undef one. 3633 3634 // The shift amount must be equal. 3635 if (*C0 != *C1) 3636 return nullptr; 3637 const APInt &MaskedBits = *C0; 3638 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3639 3640 ICmpInst::Predicate DstPred; 3641 switch (SrcPred) { 3642 case ICmpInst::Predicate::ICMP_EQ: 3643 // ((%x << MaskedBits) a>> MaskedBits) == %x 3644 // => 3645 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3646 DstPred = ICmpInst::Predicate::ICMP_ULT; 3647 break; 3648 case ICmpInst::Predicate::ICMP_NE: 3649 // ((%x << MaskedBits) a>> MaskedBits) != %x 3650 // => 3651 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3652 DstPred = ICmpInst::Predicate::ICMP_UGE; 3653 break; 3654 // FIXME: are more folds possible? 3655 default: 3656 return nullptr; 3657 } 3658 3659 auto *XType = X->getType(); 3660 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3661 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3662 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3663 3664 // KeptBits = bitwidth(%x) - MaskedBits 3665 const APInt KeptBits = BitWidth - MaskedBits; 3666 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3667 // ICmpCst = (1 << KeptBits) 3668 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3669 assert(ICmpCst.isPowerOf2()); 3670 // AddCst = (1 << (KeptBits-1)) 3671 const APInt AddCst = ICmpCst.lshr(1); 3672 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3673 3674 // T0 = add %x, AddCst 3675 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3676 // T1 = T0 DstPred ICmpCst 3677 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3678 3679 return T1; 3680 } 3681 3682 // Given pattern: 3683 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3684 // we should move shifts to the same hand of 'and', i.e. rewrite as 3685 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3686 // We are only interested in opposite logical shifts here. 3687 // One of the shifts can be truncated. 3688 // If we can, we want to end up creating 'lshr' shift. 3689 static Value * 3690 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3691 InstCombiner::BuilderTy &Builder) { 3692 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3693 !I.getOperand(0)->hasOneUse()) 3694 return nullptr; 3695 3696 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3697 3698 // Look for an 'and' of two logical shifts, one of which may be truncated. 3699 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3700 Instruction *XShift, *MaybeTruncation, *YShift; 3701 if (!match( 3702 I.getOperand(0), 3703 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3704 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3705 m_AnyLogicalShift, m_Instruction(YShift))), 3706 m_Instruction(MaybeTruncation))))) 3707 return nullptr; 3708 3709 // We potentially looked past 'trunc', but only when matching YShift, 3710 // therefore YShift must have the widest type. 3711 Instruction *WidestShift = YShift; 3712 // Therefore XShift must have the shallowest type. 3713 // Or they both have identical types if there was no truncation. 3714 Instruction *NarrowestShift = XShift; 3715 3716 Type *WidestTy = WidestShift->getType(); 3717 Type *NarrowestTy = NarrowestShift->getType(); 3718 assert(NarrowestTy == I.getOperand(0)->getType() && 3719 "We did not look past any shifts while matching XShift though."); 3720 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3721 3722 // If YShift is a 'lshr', swap the shifts around. 3723 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3724 std::swap(XShift, YShift); 3725 3726 // The shifts must be in opposite directions. 3727 auto XShiftOpcode = XShift->getOpcode(); 3728 if (XShiftOpcode == YShift->getOpcode()) 3729 return nullptr; // Do not care about same-direction shifts here. 3730 3731 Value *X, *XShAmt, *Y, *YShAmt; 3732 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3733 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3734 3735 // If one of the values being shifted is a constant, then we will end with 3736 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3737 // however, we will need to ensure that we won't increase instruction count. 3738 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3739 // At least one of the hands of the 'and' should be one-use shift. 3740 if (!match(I.getOperand(0), 3741 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3742 return nullptr; 3743 if (HadTrunc) { 3744 // Due to the 'trunc', we will need to widen X. For that either the old 3745 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3746 if (!MaybeTruncation->hasOneUse() && 3747 !NarrowestShift->getOperand(1)->hasOneUse()) 3748 return nullptr; 3749 } 3750 } 3751 3752 // We have two shift amounts from two different shifts. The types of those 3753 // shift amounts may not match. If that's the case let's bailout now. 3754 if (XShAmt->getType() != YShAmt->getType()) 3755 return nullptr; 3756 3757 // As input, we have the following pattern: 3758 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3759 // We want to rewrite that as: 3760 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3761 // While we know that originally (Q+K) would not overflow 3762 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 3763 // shift amounts. so it may now overflow in smaller bitwidth. 3764 // To ensure that does not happen, we need to ensure that the total maximal 3765 // shift amount is still representable in that smaller bit width. 3766 unsigned MaximalPossibleTotalShiftAmount = 3767 (WidestTy->getScalarSizeInBits() - 1) + 3768 (NarrowestTy->getScalarSizeInBits() - 1); 3769 APInt MaximalRepresentableShiftAmount = 3770 APInt::getAllOnes(XShAmt->getType()->getScalarSizeInBits()); 3771 if (MaximalRepresentableShiftAmount.ult(MaximalPossibleTotalShiftAmount)) 3772 return nullptr; 3773 3774 // Can we fold (XShAmt+YShAmt) ? 3775 auto *NewShAmt = dyn_cast_or_null<Constant>( 3776 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3777 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3778 if (!NewShAmt) 3779 return nullptr; 3780 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3781 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3782 3783 // Is the new shift amount smaller than the bit width? 3784 // FIXME: could also rely on ConstantRange. 3785 if (!match(NewShAmt, 3786 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3787 APInt(WidestBitWidth, WidestBitWidth)))) 3788 return nullptr; 3789 3790 // An extra legality check is needed if we had trunc-of-lshr. 3791 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3792 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3793 WidestShift]() { 3794 // It isn't obvious whether it's worth it to analyze non-constants here. 3795 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3796 // If *any* of these preconditions matches we can perform the fold. 3797 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3798 ? NewShAmt->getSplatValue() 3799 : NewShAmt; 3800 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3801 if (NewShAmtSplat && 3802 (NewShAmtSplat->isNullValue() || 3803 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3804 return true; 3805 // We consider *min* leading zeros so a single outlier 3806 // blocks the transform as opposed to allowing it. 3807 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3808 KnownBits Known = computeKnownBits(C, SQ.DL); 3809 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3810 // If the value being shifted has at most lowest bit set we can fold. 3811 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3812 if (MaxActiveBits <= 1) 3813 return true; 3814 // Precondition: NewShAmt u<= countLeadingZeros(C) 3815 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3816 return true; 3817 } 3818 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3819 KnownBits Known = computeKnownBits(C, SQ.DL); 3820 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3821 // If the value being shifted has at most lowest bit set we can fold. 3822 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3823 if (MaxActiveBits <= 1) 3824 return true; 3825 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3826 if (NewShAmtSplat) { 3827 APInt AdjNewShAmt = 3828 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3829 if (AdjNewShAmt.ule(MinLeadZero)) 3830 return true; 3831 } 3832 } 3833 return false; // Can't tell if it's ok. 3834 }; 3835 if (!CanFold()) 3836 return nullptr; 3837 } 3838 3839 // All good, we can do this fold. 3840 X = Builder.CreateZExt(X, WidestTy); 3841 Y = Builder.CreateZExt(Y, WidestTy); 3842 // The shift is the same that was for X. 3843 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3844 ? Builder.CreateLShr(X, NewShAmt) 3845 : Builder.CreateShl(X, NewShAmt); 3846 Value *T1 = Builder.CreateAnd(T0, Y); 3847 return Builder.CreateICmp(I.getPredicate(), T1, 3848 Constant::getNullValue(WidestTy)); 3849 } 3850 3851 /// Fold 3852 /// (-1 u/ x) u< y 3853 /// ((x * y) ?/ x) != y 3854 /// to 3855 /// @llvm.?mul.with.overflow(x, y) plus extraction of overflow bit 3856 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3857 /// will mean that we are looking for the opposite answer. 3858 Value *InstCombinerImpl::foldMultiplicationOverflowCheck(ICmpInst &I) { 3859 ICmpInst::Predicate Pred; 3860 Value *X, *Y; 3861 Instruction *Mul; 3862 Instruction *Div; 3863 bool NeedNegation; 3864 // Look for: (-1 u/ x) u</u>= y 3865 if (!I.isEquality() && 3866 match(&I, m_c_ICmp(Pred, 3867 m_CombineAnd(m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3868 m_Instruction(Div)), 3869 m_Value(Y)))) { 3870 Mul = nullptr; 3871 3872 // Are we checking that overflow does not happen, or does happen? 3873 switch (Pred) { 3874 case ICmpInst::Predicate::ICMP_ULT: 3875 NeedNegation = false; 3876 break; // OK 3877 case ICmpInst::Predicate::ICMP_UGE: 3878 NeedNegation = true; 3879 break; // OK 3880 default: 3881 return nullptr; // Wrong predicate. 3882 } 3883 } else // Look for: ((x * y) / x) !=/== y 3884 if (I.isEquality() && 3885 match(&I, 3886 m_c_ICmp(Pred, m_Value(Y), 3887 m_CombineAnd( 3888 m_OneUse(m_IDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3889 m_Value(X)), 3890 m_Instruction(Mul)), 3891 m_Deferred(X))), 3892 m_Instruction(Div))))) { 3893 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3894 } else 3895 return nullptr; 3896 3897 BuilderTy::InsertPointGuard Guard(Builder); 3898 // If the pattern included (x * y), we'll want to insert new instructions 3899 // right before that original multiplication so that we can replace it. 3900 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3901 if (MulHadOtherUses) 3902 Builder.SetInsertPoint(Mul); 3903 3904 Function *F = Intrinsic::getDeclaration(I.getModule(), 3905 Div->getOpcode() == Instruction::UDiv 3906 ? Intrinsic::umul_with_overflow 3907 : Intrinsic::smul_with_overflow, 3908 X->getType()); 3909 CallInst *Call = Builder.CreateCall(F, {X, Y}, "mul"); 3910 3911 // If the multiplication was used elsewhere, to ensure that we don't leave 3912 // "duplicate" instructions, replace uses of that original multiplication 3913 // with the multiplication result from the with.overflow intrinsic. 3914 if (MulHadOtherUses) 3915 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "mul.val")); 3916 3917 Value *Res = Builder.CreateExtractValue(Call, 1, "mul.ov"); 3918 if (NeedNegation) // This technically increases instruction count. 3919 Res = Builder.CreateNot(Res, "mul.not.ov"); 3920 3921 // If we replaced the mul, erase it. Do this after all uses of Builder, 3922 // as the mul is used as insertion point. 3923 if (MulHadOtherUses) 3924 eraseInstFromFunction(*Mul); 3925 3926 return Res; 3927 } 3928 3929 static Instruction *foldICmpXNegX(ICmpInst &I) { 3930 CmpInst::Predicate Pred; 3931 Value *X; 3932 if (!match(&I, m_c_ICmp(Pred, m_NSWNeg(m_Value(X)), m_Deferred(X)))) 3933 return nullptr; 3934 3935 if (ICmpInst::isSigned(Pred)) 3936 Pred = ICmpInst::getSwappedPredicate(Pred); 3937 else if (ICmpInst::isUnsigned(Pred)) 3938 Pred = ICmpInst::getSignedPredicate(Pred); 3939 // else for equality-comparisons just keep the predicate. 3940 3941 return ICmpInst::Create(Instruction::ICmp, Pred, X, 3942 Constant::getNullValue(X->getType()), I.getName()); 3943 } 3944 3945 /// Try to fold icmp (binop), X or icmp X, (binop). 3946 /// TODO: A large part of this logic is duplicated in InstSimplify's 3947 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3948 /// duplication. 3949 Instruction *InstCombinerImpl::foldICmpBinOp(ICmpInst &I, 3950 const SimplifyQuery &SQ) { 3951 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3952 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3953 3954 // Special logic for binary operators. 3955 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3956 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3957 if (!BO0 && !BO1) 3958 return nullptr; 3959 3960 if (Instruction *NewICmp = foldICmpXNegX(I)) 3961 return NewICmp; 3962 3963 const CmpInst::Predicate Pred = I.getPredicate(); 3964 Value *X; 3965 3966 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3967 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 3968 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3969 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3970 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3971 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 3972 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3973 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3974 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3975 3976 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 3977 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 3978 NoOp0WrapProblem = 3979 ICmpInst::isEquality(Pred) || 3980 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 3981 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 3982 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 3983 NoOp1WrapProblem = 3984 ICmpInst::isEquality(Pred) || 3985 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 3986 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 3987 3988 // Analyze the case when either Op0 or Op1 is an add instruction. 3989 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 3990 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 3991 if (BO0 && BO0->getOpcode() == Instruction::Add) { 3992 A = BO0->getOperand(0); 3993 B = BO0->getOperand(1); 3994 } 3995 if (BO1 && BO1->getOpcode() == Instruction::Add) { 3996 C = BO1->getOperand(0); 3997 D = BO1->getOperand(1); 3998 } 3999 4000 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 4001 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 4002 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 4003 return new ICmpInst(Pred, A == Op1 ? B : A, 4004 Constant::getNullValue(Op1->getType())); 4005 4006 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 4007 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 4008 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 4009 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 4010 C == Op0 ? D : C); 4011 4012 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 4013 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 4014 NoOp1WrapProblem) { 4015 // Determine Y and Z in the form icmp (X+Y), (X+Z). 4016 Value *Y, *Z; 4017 if (A == C) { 4018 // C + B == C + D -> B == D 4019 Y = B; 4020 Z = D; 4021 } else if (A == D) { 4022 // D + B == C + D -> B == C 4023 Y = B; 4024 Z = C; 4025 } else if (B == C) { 4026 // A + C == C + D -> A == D 4027 Y = A; 4028 Z = D; 4029 } else { 4030 assert(B == D); 4031 // A + D == C + D -> A == C 4032 Y = A; 4033 Z = C; 4034 } 4035 return new ICmpInst(Pred, Y, Z); 4036 } 4037 4038 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 4039 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 4040 match(B, m_AllOnes())) 4041 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 4042 4043 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 4044 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 4045 match(B, m_AllOnes())) 4046 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 4047 4048 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 4049 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 4050 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 4051 4052 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 4053 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 4054 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 4055 4056 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 4057 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 4058 match(D, m_AllOnes())) 4059 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 4060 4061 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 4062 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 4063 match(D, m_AllOnes())) 4064 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 4065 4066 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 4067 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 4068 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 4069 4070 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 4071 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 4072 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 4073 4074 // TODO: The subtraction-related identities shown below also hold, but 4075 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 4076 // wouldn't happen even if they were implemented. 4077 // 4078 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 4079 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 4080 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 4081 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 4082 4083 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 4084 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 4085 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 4086 4087 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 4088 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 4089 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 4090 4091 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 4092 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 4093 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 4094 4095 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 4096 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 4097 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 4098 4099 // if C1 has greater magnitude than C2: 4100 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 4101 // s.t. C3 = C1 - C2 4102 // 4103 // if C2 has greater magnitude than C1: 4104 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 4105 // s.t. C3 = C2 - C1 4106 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 4107 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 4108 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 4109 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 4110 const APInt &AP1 = C1->getValue(); 4111 const APInt &AP2 = C2->getValue(); 4112 if (AP1.isNegative() == AP2.isNegative()) { 4113 APInt AP1Abs = C1->getValue().abs(); 4114 APInt AP2Abs = C2->getValue().abs(); 4115 if (AP1Abs.uge(AP2Abs)) { 4116 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 4117 bool HasNUW = BO0->hasNoUnsignedWrap() && C3->getValue().ule(AP1); 4118 bool HasNSW = BO0->hasNoSignedWrap(); 4119 Value *NewAdd = Builder.CreateAdd(A, C3, "", HasNUW, HasNSW); 4120 return new ICmpInst(Pred, NewAdd, C); 4121 } else { 4122 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 4123 bool HasNUW = BO1->hasNoUnsignedWrap() && C3->getValue().ule(AP2); 4124 bool HasNSW = BO1->hasNoSignedWrap(); 4125 Value *NewAdd = Builder.CreateAdd(C, C3, "", HasNUW, HasNSW); 4126 return new ICmpInst(Pred, A, NewAdd); 4127 } 4128 } 4129 } 4130 4131 // Analyze the case when either Op0 or Op1 is a sub instruction. 4132 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 4133 A = nullptr; 4134 B = nullptr; 4135 C = nullptr; 4136 D = nullptr; 4137 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 4138 A = BO0->getOperand(0); 4139 B = BO0->getOperand(1); 4140 } 4141 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 4142 C = BO1->getOperand(0); 4143 D = BO1->getOperand(1); 4144 } 4145 4146 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 4147 if (A == Op1 && NoOp0WrapProblem) 4148 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 4149 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 4150 if (C == Op0 && NoOp1WrapProblem) 4151 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 4152 4153 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 4154 // (A - B) u>/u<= A --> B u>/u<= A 4155 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 4156 return new ICmpInst(Pred, B, A); 4157 // C u</u>= (C - D) --> C u</u>= D 4158 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 4159 return new ICmpInst(Pred, C, D); 4160 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 4161 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 4162 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4163 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 4164 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 4165 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 4166 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4167 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 4168 4169 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 4170 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 4171 return new ICmpInst(Pred, A, C); 4172 4173 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 4174 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 4175 return new ICmpInst(Pred, D, B); 4176 4177 // icmp (0-X) < cst --> x > -cst 4178 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 4179 Value *X; 4180 if (match(BO0, m_Neg(m_Value(X)))) 4181 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 4182 if (RHSC->isNotMinSignedValue()) 4183 return new ICmpInst(I.getSwappedPredicate(), X, 4184 ConstantExpr::getNeg(RHSC)); 4185 } 4186 4187 { 4188 // Try to remove shared constant multiplier from equality comparison: 4189 // X * C == Y * C (with no overflowing/aliasing) --> X == Y 4190 Value *X, *Y; 4191 const APInt *C; 4192 if (match(Op0, m_Mul(m_Value(X), m_APInt(C))) && *C != 0 && 4193 match(Op1, m_Mul(m_Value(Y), m_SpecificInt(*C))) && I.isEquality()) 4194 if (!C->countTrailingZeros() || 4195 (BO0 && BO1 && BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap()) || 4196 (BO0 && BO1 && BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap())) 4197 return new ICmpInst(Pred, X, Y); 4198 } 4199 4200 BinaryOperator *SRem = nullptr; 4201 // icmp (srem X, Y), Y 4202 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 4203 SRem = BO0; 4204 // icmp Y, (srem X, Y) 4205 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 4206 Op0 == BO1->getOperand(1)) 4207 SRem = BO1; 4208 if (SRem) { 4209 // We don't check hasOneUse to avoid increasing register pressure because 4210 // the value we use is the same value this instruction was already using. 4211 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 4212 default: 4213 break; 4214 case ICmpInst::ICMP_EQ: 4215 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4216 case ICmpInst::ICMP_NE: 4217 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4218 case ICmpInst::ICMP_SGT: 4219 case ICmpInst::ICMP_SGE: 4220 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 4221 Constant::getAllOnesValue(SRem->getType())); 4222 case ICmpInst::ICMP_SLT: 4223 case ICmpInst::ICMP_SLE: 4224 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 4225 Constant::getNullValue(SRem->getType())); 4226 } 4227 } 4228 4229 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 4230 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 4231 switch (BO0->getOpcode()) { 4232 default: 4233 break; 4234 case Instruction::Add: 4235 case Instruction::Sub: 4236 case Instruction::Xor: { 4237 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 4238 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4239 4240 const APInt *C; 4241 if (match(BO0->getOperand(1), m_APInt(C))) { 4242 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 4243 if (C->isSignMask()) { 4244 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4245 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4246 } 4247 4248 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 4249 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 4250 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4251 NewPred = I.getSwappedPredicate(NewPred); 4252 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4253 } 4254 } 4255 break; 4256 } 4257 case Instruction::Mul: { 4258 if (!I.isEquality()) 4259 break; 4260 4261 const APInt *C; 4262 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isZero() && 4263 !C->isOne()) { 4264 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 4265 // Mask = -1 >> count-trailing-zeros(C). 4266 if (unsigned TZs = C->countTrailingZeros()) { 4267 Constant *Mask = ConstantInt::get( 4268 BO0->getType(), 4269 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 4270 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 4271 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 4272 return new ICmpInst(Pred, And1, And2); 4273 } 4274 } 4275 break; 4276 } 4277 case Instruction::UDiv: 4278 case Instruction::LShr: 4279 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 4280 break; 4281 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4282 4283 case Instruction::SDiv: 4284 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 4285 break; 4286 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4287 4288 case Instruction::AShr: 4289 if (!BO0->isExact() || !BO1->isExact()) 4290 break; 4291 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4292 4293 case Instruction::Shl: { 4294 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 4295 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 4296 if (!NUW && !NSW) 4297 break; 4298 if (!NSW && I.isSigned()) 4299 break; 4300 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4301 } 4302 } 4303 } 4304 4305 if (BO0) { 4306 // Transform A & (L - 1) `ult` L --> L != 0 4307 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 4308 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 4309 4310 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 4311 auto *Zero = Constant::getNullValue(BO0->getType()); 4312 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 4313 } 4314 } 4315 4316 if (Value *V = foldMultiplicationOverflowCheck(I)) 4317 return replaceInstUsesWith(I, V); 4318 4319 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 4320 return replaceInstUsesWith(I, V); 4321 4322 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4323 return replaceInstUsesWith(I, V); 4324 4325 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4326 return replaceInstUsesWith(I, V); 4327 4328 return nullptr; 4329 } 4330 4331 /// Fold icmp Pred min|max(X, Y), X. 4332 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4333 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4334 Value *Op0 = Cmp.getOperand(0); 4335 Value *X = Cmp.getOperand(1); 4336 4337 // Canonicalize minimum or maximum operand to LHS of the icmp. 4338 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4339 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4340 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4341 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4342 std::swap(Op0, X); 4343 Pred = Cmp.getSwappedPredicate(); 4344 } 4345 4346 Value *Y; 4347 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4348 // smin(X, Y) == X --> X s<= Y 4349 // smin(X, Y) s>= X --> X s<= Y 4350 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4351 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4352 4353 // smin(X, Y) != X --> X s> Y 4354 // smin(X, Y) s< X --> X s> Y 4355 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4356 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4357 4358 // These cases should be handled in InstSimplify: 4359 // smin(X, Y) s<= X --> true 4360 // smin(X, Y) s> X --> false 4361 return nullptr; 4362 } 4363 4364 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4365 // smax(X, Y) == X --> X s>= Y 4366 // smax(X, Y) s<= X --> X s>= Y 4367 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4368 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4369 4370 // smax(X, Y) != X --> X s< Y 4371 // smax(X, Y) s> X --> X s< Y 4372 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4373 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4374 4375 // These cases should be handled in InstSimplify: 4376 // smax(X, Y) s>= X --> true 4377 // smax(X, Y) s< X --> false 4378 return nullptr; 4379 } 4380 4381 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4382 // umin(X, Y) == X --> X u<= Y 4383 // umin(X, Y) u>= X --> X u<= Y 4384 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4385 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4386 4387 // umin(X, Y) != X --> X u> Y 4388 // umin(X, Y) u< X --> X u> Y 4389 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4390 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4391 4392 // These cases should be handled in InstSimplify: 4393 // umin(X, Y) u<= X --> true 4394 // umin(X, Y) u> X --> false 4395 return nullptr; 4396 } 4397 4398 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4399 // umax(X, Y) == X --> X u>= Y 4400 // umax(X, Y) u<= X --> X u>= Y 4401 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4402 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4403 4404 // umax(X, Y) != X --> X u< Y 4405 // umax(X, Y) u> X --> X u< Y 4406 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4407 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4408 4409 // These cases should be handled in InstSimplify: 4410 // umax(X, Y) u>= X --> true 4411 // umax(X, Y) u< X --> false 4412 return nullptr; 4413 } 4414 4415 return nullptr; 4416 } 4417 4418 Instruction *InstCombinerImpl::foldICmpEquality(ICmpInst &I) { 4419 if (!I.isEquality()) 4420 return nullptr; 4421 4422 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4423 const CmpInst::Predicate Pred = I.getPredicate(); 4424 Value *A, *B, *C, *D; 4425 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4426 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4427 Value *OtherVal = A == Op1 ? B : A; 4428 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4429 } 4430 4431 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4432 // A^c1 == C^c2 --> A == C^(c1^c2) 4433 ConstantInt *C1, *C2; 4434 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4435 Op1->hasOneUse()) { 4436 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4437 Value *Xor = Builder.CreateXor(C, NC); 4438 return new ICmpInst(Pred, A, Xor); 4439 } 4440 4441 // A^B == A^D -> B == D 4442 if (A == C) 4443 return new ICmpInst(Pred, B, D); 4444 if (A == D) 4445 return new ICmpInst(Pred, B, C); 4446 if (B == C) 4447 return new ICmpInst(Pred, A, D); 4448 if (B == D) 4449 return new ICmpInst(Pred, A, C); 4450 } 4451 } 4452 4453 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4454 // A == (A^B) -> B == 0 4455 Value *OtherVal = A == Op0 ? B : A; 4456 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4457 } 4458 4459 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4460 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4461 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4462 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4463 4464 if (A == C) { 4465 X = B; 4466 Y = D; 4467 Z = A; 4468 } else if (A == D) { 4469 X = B; 4470 Y = C; 4471 Z = A; 4472 } else if (B == C) { 4473 X = A; 4474 Y = D; 4475 Z = B; 4476 } else if (B == D) { 4477 X = A; 4478 Y = C; 4479 Z = B; 4480 } 4481 4482 if (X) { // Build (X^Y) & Z 4483 Op1 = Builder.CreateXor(X, Y); 4484 Op1 = Builder.CreateAnd(Op1, Z); 4485 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4486 } 4487 } 4488 4489 { 4490 // Similar to above, but specialized for constant because invert is needed: 4491 // (X | C) == (Y | C) --> (X ^ Y) & ~C == 0 4492 Value *X, *Y; 4493 Constant *C; 4494 if (match(Op0, m_OneUse(m_Or(m_Value(X), m_Constant(C)))) && 4495 match(Op1, m_OneUse(m_Or(m_Value(Y), m_Specific(C))))) { 4496 Value *Xor = Builder.CreateXor(X, Y); 4497 Value *And = Builder.CreateAnd(Xor, ConstantExpr::getNot(C)); 4498 return new ICmpInst(Pred, And, Constant::getNullValue(And->getType())); 4499 } 4500 } 4501 4502 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4503 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4504 ConstantInt *Cst1; 4505 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4506 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4507 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4508 match(Op1, m_ZExt(m_Value(A))))) { 4509 APInt Pow2 = Cst1->getValue() + 1; 4510 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4511 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4512 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4513 } 4514 4515 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4516 // For lshr and ashr pairs. 4517 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4518 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4519 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4520 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4521 unsigned TypeBits = Cst1->getBitWidth(); 4522 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4523 if (ShAmt < TypeBits && ShAmt != 0) { 4524 ICmpInst::Predicate NewPred = 4525 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4526 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4527 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4528 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4529 } 4530 } 4531 4532 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4533 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4534 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4535 unsigned TypeBits = Cst1->getBitWidth(); 4536 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4537 if (ShAmt < TypeBits && ShAmt != 0) { 4538 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4539 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4540 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4541 I.getName() + ".mask"); 4542 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4543 } 4544 } 4545 4546 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4547 // "icmp (and X, mask), cst" 4548 uint64_t ShAmt = 0; 4549 if (Op0->hasOneUse() && 4550 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4551 match(Op1, m_ConstantInt(Cst1)) && 4552 // Only do this when A has multiple uses. This is most important to do 4553 // when it exposes other optimizations. 4554 !A->hasOneUse()) { 4555 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4556 4557 if (ShAmt < ASize) { 4558 APInt MaskV = 4559 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4560 MaskV <<= ShAmt; 4561 4562 APInt CmpV = Cst1->getValue().zext(ASize); 4563 CmpV <<= ShAmt; 4564 4565 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4566 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4567 } 4568 } 4569 4570 if (Instruction *ICmp = foldICmpIntrinsicWithIntrinsic(I)) 4571 return ICmp; 4572 4573 // Canonicalize checking for a power-of-2-or-zero value: 4574 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4575 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4576 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4577 m_Deferred(A)))) || 4578 !match(Op1, m_ZeroInt())) 4579 A = nullptr; 4580 4581 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4582 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4583 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4584 A = Op1; 4585 else if (match(Op1, 4586 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4587 A = Op0; 4588 4589 if (A) { 4590 Type *Ty = A->getType(); 4591 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4592 return Pred == ICmpInst::ICMP_EQ 4593 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4594 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4595 } 4596 4597 // Match icmp eq (trunc (lshr A, BW), (ashr (trunc A), BW-1)), which checks the 4598 // top BW/2 + 1 bits are all the same. Create "A >=s INT_MIN && A <=s INT_MAX", 4599 // which we generate as "icmp ult (add A, 2^(BW-1)), 2^BW" to skip a few steps 4600 // of instcombine. 4601 unsigned BitWidth = Op0->getType()->getScalarSizeInBits(); 4602 if (match(Op0, m_AShr(m_Trunc(m_Value(A)), m_SpecificInt(BitWidth - 1))) && 4603 match(Op1, m_Trunc(m_LShr(m_Specific(A), m_SpecificInt(BitWidth)))) && 4604 A->getType()->getScalarSizeInBits() == BitWidth * 2 && 4605 (I.getOperand(0)->hasOneUse() || I.getOperand(1)->hasOneUse())) { 4606 APInt C = APInt::getOneBitSet(BitWidth * 2, BitWidth - 1); 4607 Value *Add = Builder.CreateAdd(A, ConstantInt::get(A->getType(), C)); 4608 return new ICmpInst(Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULT 4609 : ICmpInst::ICMP_UGE, 4610 Add, ConstantInt::get(A->getType(), C.shl(1))); 4611 } 4612 4613 return nullptr; 4614 } 4615 4616 static Instruction *foldICmpWithTrunc(ICmpInst &ICmp, 4617 InstCombiner::BuilderTy &Builder) { 4618 const ICmpInst::Predicate Pred = ICmp.getPredicate(); 4619 Value *Op0 = ICmp.getOperand(0), *Op1 = ICmp.getOperand(1); 4620 4621 // Try to canonicalize trunc + compare-to-constant into a mask + cmp. 4622 // The trunc masks high bits while the compare may effectively mask low bits. 4623 Value *X; 4624 const APInt *C; 4625 if (!match(Op0, m_OneUse(m_Trunc(m_Value(X)))) || !match(Op1, m_APInt(C))) 4626 return nullptr; 4627 4628 unsigned SrcBits = X->getType()->getScalarSizeInBits(); 4629 if (Pred == ICmpInst::ICMP_ULT) { 4630 if (C->isPowerOf2()) { 4631 // If C is a power-of-2 (one set bit): 4632 // (trunc X) u< C --> (X & -C) == 0 (are all masked-high-bits clear?) 4633 Constant *MaskC = ConstantInt::get(X->getType(), (-*C).zext(SrcBits)); 4634 Value *And = Builder.CreateAnd(X, MaskC); 4635 Constant *Zero = ConstantInt::getNullValue(X->getType()); 4636 return new ICmpInst(ICmpInst::ICMP_EQ, And, Zero); 4637 } 4638 // If C is a negative power-of-2 (high-bit mask): 4639 // (trunc X) u< C --> (X & C) != C (are any masked-high-bits clear?) 4640 if (C->isNegatedPowerOf2()) { 4641 Constant *MaskC = ConstantInt::get(X->getType(), C->zext(SrcBits)); 4642 Value *And = Builder.CreateAnd(X, MaskC); 4643 return new ICmpInst(ICmpInst::ICMP_NE, And, MaskC); 4644 } 4645 } 4646 4647 if (Pred == ICmpInst::ICMP_UGT) { 4648 // If C is a low-bit-mask (C+1 is a power-of-2): 4649 // (trunc X) u> C --> (X & ~C) != 0 (are any masked-high-bits set?) 4650 if (C->isMask()) { 4651 Constant *MaskC = ConstantInt::get(X->getType(), (~*C).zext(SrcBits)); 4652 Value *And = Builder.CreateAnd(X, MaskC); 4653 Constant *Zero = ConstantInt::getNullValue(X->getType()); 4654 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero); 4655 } 4656 // If C is not-of-power-of-2 (one clear bit): 4657 // (trunc X) u> C --> (X & (C+1)) == C+1 (are all masked-high-bits set?) 4658 if ((~*C).isPowerOf2()) { 4659 Constant *MaskC = ConstantInt::get(X->getType(), (*C + 1).zext(SrcBits)); 4660 Value *And = Builder.CreateAnd(X, MaskC); 4661 return new ICmpInst(ICmpInst::ICMP_EQ, And, MaskC); 4662 } 4663 } 4664 4665 return nullptr; 4666 } 4667 4668 static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp, 4669 InstCombiner::BuilderTy &Builder) { 4670 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4671 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4672 Value *X; 4673 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4674 return nullptr; 4675 4676 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4677 bool IsSignedCmp = ICmp.isSigned(); 4678 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) { 4679 // If the signedness of the two casts doesn't agree (i.e. one is a sext 4680 // and the other is a zext), then we can't handle this. 4681 // TODO: This is too strict. We can handle some predicates (equality?). 4682 if (CastOp0->getOpcode() != CastOp1->getOpcode()) 4683 return nullptr; 4684 4685 // Not an extension from the same type? 4686 Value *Y = CastOp1->getOperand(0); 4687 Type *XTy = X->getType(), *YTy = Y->getType(); 4688 if (XTy != YTy) { 4689 // One of the casts must have one use because we are creating a new cast. 4690 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse()) 4691 return nullptr; 4692 // Extend the narrower operand to the type of the wider operand. 4693 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4694 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy); 4695 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4696 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy); 4697 else 4698 return nullptr; 4699 } 4700 4701 // (zext X) == (zext Y) --> X == Y 4702 // (sext X) == (sext Y) --> X == Y 4703 if (ICmp.isEquality()) 4704 return new ICmpInst(ICmp.getPredicate(), X, Y); 4705 4706 // A signed comparison of sign extended values simplifies into a 4707 // signed comparison. 4708 if (IsSignedCmp && IsSignedExt) 4709 return new ICmpInst(ICmp.getPredicate(), X, Y); 4710 4711 // The other three cases all fold into an unsigned comparison. 4712 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4713 } 4714 4715 // Below here, we are only folding a compare with constant. 4716 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4717 if (!C) 4718 return nullptr; 4719 4720 // Compute the constant that would happen if we truncated to SrcTy then 4721 // re-extended to DestTy. 4722 Type *SrcTy = CastOp0->getSrcTy(); 4723 Type *DestTy = CastOp0->getDestTy(); 4724 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4725 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4726 4727 // If the re-extended constant didn't change... 4728 if (Res2 == C) { 4729 if (ICmp.isEquality()) 4730 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4731 4732 // A signed comparison of sign extended values simplifies into a 4733 // signed comparison. 4734 if (IsSignedExt && IsSignedCmp) 4735 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4736 4737 // The other three cases all fold into an unsigned comparison. 4738 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4739 } 4740 4741 // The re-extended constant changed, partly changed (in the case of a vector), 4742 // or could not be determined to be equal (in the case of a constant 4743 // expression), so the constant cannot be represented in the shorter type. 4744 // All the cases that fold to true or false will have already been handled 4745 // by SimplifyICmpInst, so only deal with the tricky case. 4746 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4747 return nullptr; 4748 4749 // Is source op positive? 4750 // icmp ult (sext X), C --> icmp sgt X, -1 4751 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4752 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4753 4754 // Is source op negative? 4755 // icmp ugt (sext X), C --> icmp slt X, 0 4756 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4757 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4758 } 4759 4760 /// Handle icmp (cast x), (cast or constant). 4761 Instruction *InstCombinerImpl::foldICmpWithCastOp(ICmpInst &ICmp) { 4762 // If any operand of ICmp is a inttoptr roundtrip cast then remove it as 4763 // icmp compares only pointer's value. 4764 // icmp (inttoptr (ptrtoint p1)), p2 --> icmp p1, p2. 4765 Value *SimplifiedOp0 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(0)); 4766 Value *SimplifiedOp1 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(1)); 4767 if (SimplifiedOp0 || SimplifiedOp1) 4768 return new ICmpInst(ICmp.getPredicate(), 4769 SimplifiedOp0 ? SimplifiedOp0 : ICmp.getOperand(0), 4770 SimplifiedOp1 ? SimplifiedOp1 : ICmp.getOperand(1)); 4771 4772 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4773 if (!CastOp0) 4774 return nullptr; 4775 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4776 return nullptr; 4777 4778 Value *Op0Src = CastOp0->getOperand(0); 4779 Type *SrcTy = CastOp0->getSrcTy(); 4780 Type *DestTy = CastOp0->getDestTy(); 4781 4782 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4783 // integer type is the same size as the pointer type. 4784 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4785 if (isa<VectorType>(SrcTy)) { 4786 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4787 DestTy = cast<VectorType>(DestTy)->getElementType(); 4788 } 4789 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4790 }; 4791 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4792 CompatibleSizes(SrcTy, DestTy)) { 4793 Value *NewOp1 = nullptr; 4794 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4795 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4796 if (PtrSrc->getType()->getPointerAddressSpace() == 4797 Op0Src->getType()->getPointerAddressSpace()) { 4798 NewOp1 = PtrToIntOp1->getOperand(0); 4799 // If the pointer types don't match, insert a bitcast. 4800 if (Op0Src->getType() != NewOp1->getType()) 4801 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4802 } 4803 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4804 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4805 } 4806 4807 if (NewOp1) 4808 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4809 } 4810 4811 if (Instruction *R = foldICmpWithTrunc(ICmp, Builder)) 4812 return R; 4813 4814 return foldICmpWithZextOrSext(ICmp, Builder); 4815 } 4816 4817 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4818 switch (BinaryOp) { 4819 default: 4820 llvm_unreachable("Unsupported binary op"); 4821 case Instruction::Add: 4822 case Instruction::Sub: 4823 return match(RHS, m_Zero()); 4824 case Instruction::Mul: 4825 return match(RHS, m_One()); 4826 } 4827 } 4828 4829 OverflowResult 4830 InstCombinerImpl::computeOverflow(Instruction::BinaryOps BinaryOp, 4831 bool IsSigned, Value *LHS, Value *RHS, 4832 Instruction *CxtI) const { 4833 switch (BinaryOp) { 4834 default: 4835 llvm_unreachable("Unsupported binary op"); 4836 case Instruction::Add: 4837 if (IsSigned) 4838 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4839 else 4840 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4841 case Instruction::Sub: 4842 if (IsSigned) 4843 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4844 else 4845 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4846 case Instruction::Mul: 4847 if (IsSigned) 4848 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4849 else 4850 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4851 } 4852 } 4853 4854 bool InstCombinerImpl::OptimizeOverflowCheck(Instruction::BinaryOps BinaryOp, 4855 bool IsSigned, Value *LHS, 4856 Value *RHS, Instruction &OrigI, 4857 Value *&Result, 4858 Constant *&Overflow) { 4859 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4860 std::swap(LHS, RHS); 4861 4862 // If the overflow check was an add followed by a compare, the insertion point 4863 // may be pointing to the compare. We want to insert the new instructions 4864 // before the add in case there are uses of the add between the add and the 4865 // compare. 4866 Builder.SetInsertPoint(&OrigI); 4867 4868 Type *OverflowTy = Type::getInt1Ty(LHS->getContext()); 4869 if (auto *LHSTy = dyn_cast<VectorType>(LHS->getType())) 4870 OverflowTy = VectorType::get(OverflowTy, LHSTy->getElementCount()); 4871 4872 if (isNeutralValue(BinaryOp, RHS)) { 4873 Result = LHS; 4874 Overflow = ConstantInt::getFalse(OverflowTy); 4875 return true; 4876 } 4877 4878 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4879 case OverflowResult::MayOverflow: 4880 return false; 4881 case OverflowResult::AlwaysOverflowsLow: 4882 case OverflowResult::AlwaysOverflowsHigh: 4883 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4884 Result->takeName(&OrigI); 4885 Overflow = ConstantInt::getTrue(OverflowTy); 4886 return true; 4887 case OverflowResult::NeverOverflows: 4888 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4889 Result->takeName(&OrigI); 4890 Overflow = ConstantInt::getFalse(OverflowTy); 4891 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4892 if (IsSigned) 4893 Inst->setHasNoSignedWrap(); 4894 else 4895 Inst->setHasNoUnsignedWrap(); 4896 } 4897 return true; 4898 } 4899 4900 llvm_unreachable("Unexpected overflow result"); 4901 } 4902 4903 /// Recognize and process idiom involving test for multiplication 4904 /// overflow. 4905 /// 4906 /// The caller has matched a pattern of the form: 4907 /// I = cmp u (mul(zext A, zext B), V 4908 /// The function checks if this is a test for overflow and if so replaces 4909 /// multiplication with call to 'mul.with.overflow' intrinsic. 4910 /// 4911 /// \param I Compare instruction. 4912 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4913 /// the compare instruction. Must be of integer type. 4914 /// \param OtherVal The other argument of compare instruction. 4915 /// \returns Instruction which must replace the compare instruction, NULL if no 4916 /// replacement required. 4917 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4918 Value *OtherVal, 4919 InstCombinerImpl &IC) { 4920 // Don't bother doing this transformation for pointers, don't do it for 4921 // vectors. 4922 if (!isa<IntegerType>(MulVal->getType())) 4923 return nullptr; 4924 4925 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4926 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4927 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4928 if (!MulInstr) 4929 return nullptr; 4930 assert(MulInstr->getOpcode() == Instruction::Mul); 4931 4932 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4933 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4934 assert(LHS->getOpcode() == Instruction::ZExt); 4935 assert(RHS->getOpcode() == Instruction::ZExt); 4936 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4937 4938 // Calculate type and width of the result produced by mul.with.overflow. 4939 Type *TyA = A->getType(), *TyB = B->getType(); 4940 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4941 WidthB = TyB->getPrimitiveSizeInBits(); 4942 unsigned MulWidth; 4943 Type *MulType; 4944 if (WidthB > WidthA) { 4945 MulWidth = WidthB; 4946 MulType = TyB; 4947 } else { 4948 MulWidth = WidthA; 4949 MulType = TyA; 4950 } 4951 4952 // In order to replace the original mul with a narrower mul.with.overflow, 4953 // all uses must ignore upper bits of the product. The number of used low 4954 // bits must be not greater than the width of mul.with.overflow. 4955 if (MulVal->hasNUsesOrMore(2)) 4956 for (User *U : MulVal->users()) { 4957 if (U == &I) 4958 continue; 4959 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4960 // Check if truncation ignores bits above MulWidth. 4961 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 4962 if (TruncWidth > MulWidth) 4963 return nullptr; 4964 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4965 // Check if AND ignores bits above MulWidth. 4966 if (BO->getOpcode() != Instruction::And) 4967 return nullptr; 4968 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 4969 const APInt &CVal = CI->getValue(); 4970 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 4971 return nullptr; 4972 } else { 4973 // In this case we could have the operand of the binary operation 4974 // being defined in another block, and performing the replacement 4975 // could break the dominance relation. 4976 return nullptr; 4977 } 4978 } else { 4979 // Other uses prohibit this transformation. 4980 return nullptr; 4981 } 4982 } 4983 4984 // Recognize patterns 4985 switch (I.getPredicate()) { 4986 case ICmpInst::ICMP_EQ: 4987 case ICmpInst::ICMP_NE: 4988 // Recognize pattern: 4989 // mulval = mul(zext A, zext B) 4990 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 4991 ConstantInt *CI; 4992 Value *ValToMask; 4993 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 4994 if (ValToMask != MulVal) 4995 return nullptr; 4996 const APInt &CVal = CI->getValue() + 1; 4997 if (CVal.isPowerOf2()) { 4998 unsigned MaskWidth = CVal.logBase2(); 4999 if (MaskWidth == MulWidth) 5000 break; // Recognized 5001 } 5002 } 5003 return nullptr; 5004 5005 case ICmpInst::ICMP_UGT: 5006 // Recognize pattern: 5007 // mulval = mul(zext A, zext B) 5008 // cmp ugt mulval, max 5009 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5010 APInt MaxVal = APInt::getMaxValue(MulWidth); 5011 MaxVal = MaxVal.zext(CI->getBitWidth()); 5012 if (MaxVal.eq(CI->getValue())) 5013 break; // Recognized 5014 } 5015 return nullptr; 5016 5017 case ICmpInst::ICMP_UGE: 5018 // Recognize pattern: 5019 // mulval = mul(zext A, zext B) 5020 // cmp uge mulval, max+1 5021 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5022 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5023 if (MaxVal.eq(CI->getValue())) 5024 break; // Recognized 5025 } 5026 return nullptr; 5027 5028 case ICmpInst::ICMP_ULE: 5029 // Recognize pattern: 5030 // mulval = mul(zext A, zext B) 5031 // cmp ule mulval, max 5032 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5033 APInt MaxVal = APInt::getMaxValue(MulWidth); 5034 MaxVal = MaxVal.zext(CI->getBitWidth()); 5035 if (MaxVal.eq(CI->getValue())) 5036 break; // Recognized 5037 } 5038 return nullptr; 5039 5040 case ICmpInst::ICMP_ULT: 5041 // Recognize pattern: 5042 // mulval = mul(zext A, zext B) 5043 // cmp ule mulval, max + 1 5044 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5045 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5046 if (MaxVal.eq(CI->getValue())) 5047 break; // Recognized 5048 } 5049 return nullptr; 5050 5051 default: 5052 return nullptr; 5053 } 5054 5055 InstCombiner::BuilderTy &Builder = IC.Builder; 5056 Builder.SetInsertPoint(MulInstr); 5057 5058 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 5059 Value *MulA = A, *MulB = B; 5060 if (WidthA < MulWidth) 5061 MulA = Builder.CreateZExt(A, MulType); 5062 if (WidthB < MulWidth) 5063 MulB = Builder.CreateZExt(B, MulType); 5064 Function *F = Intrinsic::getDeclaration( 5065 I.getModule(), Intrinsic::umul_with_overflow, MulType); 5066 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 5067 IC.addToWorklist(MulInstr); 5068 5069 // If there are uses of mul result other than the comparison, we know that 5070 // they are truncation or binary AND. Change them to use result of 5071 // mul.with.overflow and adjust properly mask/size. 5072 if (MulVal->hasNUsesOrMore(2)) { 5073 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 5074 for (User *U : make_early_inc_range(MulVal->users())) { 5075 if (U == &I || U == OtherVal) 5076 continue; 5077 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 5078 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 5079 IC.replaceInstUsesWith(*TI, Mul); 5080 else 5081 TI->setOperand(0, Mul); 5082 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 5083 assert(BO->getOpcode() == Instruction::And); 5084 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 5085 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 5086 APInt ShortMask = CI->getValue().trunc(MulWidth); 5087 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 5088 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 5089 IC.replaceInstUsesWith(*BO, Zext); 5090 } else { 5091 llvm_unreachable("Unexpected Binary operation"); 5092 } 5093 IC.addToWorklist(cast<Instruction>(U)); 5094 } 5095 } 5096 if (isa<Instruction>(OtherVal)) 5097 IC.addToWorklist(cast<Instruction>(OtherVal)); 5098 5099 // The original icmp gets replaced with the overflow value, maybe inverted 5100 // depending on predicate. 5101 bool Inverse = false; 5102 switch (I.getPredicate()) { 5103 case ICmpInst::ICMP_NE: 5104 break; 5105 case ICmpInst::ICMP_EQ: 5106 Inverse = true; 5107 break; 5108 case ICmpInst::ICMP_UGT: 5109 case ICmpInst::ICMP_UGE: 5110 if (I.getOperand(0) == MulVal) 5111 break; 5112 Inverse = true; 5113 break; 5114 case ICmpInst::ICMP_ULT: 5115 case ICmpInst::ICMP_ULE: 5116 if (I.getOperand(1) == MulVal) 5117 break; 5118 Inverse = true; 5119 break; 5120 default: 5121 llvm_unreachable("Unexpected predicate"); 5122 } 5123 if (Inverse) { 5124 Value *Res = Builder.CreateExtractValue(Call, 1); 5125 return BinaryOperator::CreateNot(Res); 5126 } 5127 5128 return ExtractValueInst::Create(Call, 1); 5129 } 5130 5131 /// When performing a comparison against a constant, it is possible that not all 5132 /// the bits in the LHS are demanded. This helper method computes the mask that 5133 /// IS demanded. 5134 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 5135 const APInt *RHS; 5136 if (!match(I.getOperand(1), m_APInt(RHS))) 5137 return APInt::getAllOnes(BitWidth); 5138 5139 // If this is a normal comparison, it demands all bits. If it is a sign bit 5140 // comparison, it only demands the sign bit. 5141 bool UnusedBit; 5142 if (InstCombiner::isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 5143 return APInt::getSignMask(BitWidth); 5144 5145 switch (I.getPredicate()) { 5146 // For a UGT comparison, we don't care about any bits that 5147 // correspond to the trailing ones of the comparand. The value of these 5148 // bits doesn't impact the outcome of the comparison, because any value 5149 // greater than the RHS must differ in a bit higher than these due to carry. 5150 case ICmpInst::ICMP_UGT: 5151 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 5152 5153 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 5154 // Any value less than the RHS must differ in a higher bit because of carries. 5155 case ICmpInst::ICMP_ULT: 5156 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 5157 5158 default: 5159 return APInt::getAllOnes(BitWidth); 5160 } 5161 } 5162 5163 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 5164 /// should be swapped. 5165 /// The decision is based on how many times these two operands are reused 5166 /// as subtract operands and their positions in those instructions. 5167 /// The rationale is that several architectures use the same instruction for 5168 /// both subtract and cmp. Thus, it is better if the order of those operands 5169 /// match. 5170 /// \return true if Op0 and Op1 should be swapped. 5171 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 5172 // Filter out pointer values as those cannot appear directly in subtract. 5173 // FIXME: we may want to go through inttoptrs or bitcasts. 5174 if (Op0->getType()->isPointerTy()) 5175 return false; 5176 // If a subtract already has the same operands as a compare, swapping would be 5177 // bad. If a subtract has the same operands as a compare but in reverse order, 5178 // then swapping is good. 5179 int GoodToSwap = 0; 5180 for (const User *U : Op0->users()) { 5181 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 5182 GoodToSwap++; 5183 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 5184 GoodToSwap--; 5185 } 5186 return GoodToSwap > 0; 5187 } 5188 5189 /// Check that one use is in the same block as the definition and all 5190 /// other uses are in blocks dominated by a given block. 5191 /// 5192 /// \param DI Definition 5193 /// \param UI Use 5194 /// \param DB Block that must dominate all uses of \p DI outside 5195 /// the parent block 5196 /// \return true when \p UI is the only use of \p DI in the parent block 5197 /// and all other uses of \p DI are in blocks dominated by \p DB. 5198 /// 5199 bool InstCombinerImpl::dominatesAllUses(const Instruction *DI, 5200 const Instruction *UI, 5201 const BasicBlock *DB) const { 5202 assert(DI && UI && "Instruction not defined\n"); 5203 // Ignore incomplete definitions. 5204 if (!DI->getParent()) 5205 return false; 5206 // DI and UI must be in the same block. 5207 if (DI->getParent() != UI->getParent()) 5208 return false; 5209 // Protect from self-referencing blocks. 5210 if (DI->getParent() == DB) 5211 return false; 5212 for (const User *U : DI->users()) { 5213 auto *Usr = cast<Instruction>(U); 5214 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 5215 return false; 5216 } 5217 return true; 5218 } 5219 5220 /// Return true when the instruction sequence within a block is select-cmp-br. 5221 static bool isChainSelectCmpBranch(const SelectInst *SI) { 5222 const BasicBlock *BB = SI->getParent(); 5223 if (!BB) 5224 return false; 5225 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 5226 if (!BI || BI->getNumSuccessors() != 2) 5227 return false; 5228 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 5229 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 5230 return false; 5231 return true; 5232 } 5233 5234 /// True when a select result is replaced by one of its operands 5235 /// in select-icmp sequence. This will eventually result in the elimination 5236 /// of the select. 5237 /// 5238 /// \param SI Select instruction 5239 /// \param Icmp Compare instruction 5240 /// \param SIOpd Operand that replaces the select 5241 /// 5242 /// Notes: 5243 /// - The replacement is global and requires dominator information 5244 /// - The caller is responsible for the actual replacement 5245 /// 5246 /// Example: 5247 /// 5248 /// entry: 5249 /// %4 = select i1 %3, %C* %0, %C* null 5250 /// %5 = icmp eq %C* %4, null 5251 /// br i1 %5, label %9, label %7 5252 /// ... 5253 /// ; <label>:7 ; preds = %entry 5254 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 5255 /// ... 5256 /// 5257 /// can be transformed to 5258 /// 5259 /// %5 = icmp eq %C* %0, null 5260 /// %6 = select i1 %3, i1 %5, i1 true 5261 /// br i1 %6, label %9, label %7 5262 /// ... 5263 /// ; <label>:7 ; preds = %entry 5264 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 5265 /// 5266 /// Similar when the first operand of the select is a constant or/and 5267 /// the compare is for not equal rather than equal. 5268 /// 5269 /// NOTE: The function is only called when the select and compare constants 5270 /// are equal, the optimization can work only for EQ predicates. This is not a 5271 /// major restriction since a NE compare should be 'normalized' to an equal 5272 /// compare, which usually happens in the combiner and test case 5273 /// select-cmp-br.ll checks for it. 5274 bool InstCombinerImpl::replacedSelectWithOperand(SelectInst *SI, 5275 const ICmpInst *Icmp, 5276 const unsigned SIOpd) { 5277 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 5278 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 5279 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 5280 // The check for the single predecessor is not the best that can be 5281 // done. But it protects efficiently against cases like when SI's 5282 // home block has two successors, Succ and Succ1, and Succ1 predecessor 5283 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 5284 // replaced can be reached on either path. So the uniqueness check 5285 // guarantees that the path all uses of SI (outside SI's parent) are on 5286 // is disjoint from all other paths out of SI. But that information 5287 // is more expensive to compute, and the trade-off here is in favor 5288 // of compile-time. It should also be noticed that we check for a single 5289 // predecessor and not only uniqueness. This to handle the situation when 5290 // Succ and Succ1 points to the same basic block. 5291 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 5292 NumSel++; 5293 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 5294 return true; 5295 } 5296 } 5297 return false; 5298 } 5299 5300 /// Try to fold the comparison based on range information we can get by checking 5301 /// whether bits are known to be zero or one in the inputs. 5302 Instruction *InstCombinerImpl::foldICmpUsingKnownBits(ICmpInst &I) { 5303 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5304 Type *Ty = Op0->getType(); 5305 ICmpInst::Predicate Pred = I.getPredicate(); 5306 5307 // Get scalar or pointer size. 5308 unsigned BitWidth = Ty->isIntOrIntVectorTy() 5309 ? Ty->getScalarSizeInBits() 5310 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 5311 5312 if (!BitWidth) 5313 return nullptr; 5314 5315 KnownBits Op0Known(BitWidth); 5316 KnownBits Op1Known(BitWidth); 5317 5318 if (SimplifyDemandedBits(&I, 0, 5319 getDemandedBitsLHSMask(I, BitWidth), 5320 Op0Known, 0)) 5321 return &I; 5322 5323 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnes(BitWidth), Op1Known, 0)) 5324 return &I; 5325 5326 // Given the known and unknown bits, compute a range that the LHS could be 5327 // in. Compute the Min, Max and RHS values based on the known bits. For the 5328 // EQ and NE we use unsigned values. 5329 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 5330 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 5331 if (I.isSigned()) { 5332 Op0Min = Op0Known.getSignedMinValue(); 5333 Op0Max = Op0Known.getSignedMaxValue(); 5334 Op1Min = Op1Known.getSignedMinValue(); 5335 Op1Max = Op1Known.getSignedMaxValue(); 5336 } else { 5337 Op0Min = Op0Known.getMinValue(); 5338 Op0Max = Op0Known.getMaxValue(); 5339 Op1Min = Op1Known.getMinValue(); 5340 Op1Max = Op1Known.getMaxValue(); 5341 } 5342 5343 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 5344 // out that the LHS or RHS is a constant. Constant fold this now, so that 5345 // code below can assume that Min != Max. 5346 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 5347 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 5348 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 5349 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 5350 5351 // Don't break up a clamp pattern -- (min(max X, Y), Z) -- by replacing a 5352 // min/max canonical compare with some other compare. That could lead to 5353 // conflict with select canonicalization and infinite looping. 5354 // FIXME: This constraint may go away if min/max intrinsics are canonical. 5355 auto isMinMaxCmp = [&](Instruction &Cmp) { 5356 if (!Cmp.hasOneUse()) 5357 return false; 5358 Value *A, *B; 5359 SelectPatternFlavor SPF = matchSelectPattern(Cmp.user_back(), A, B).Flavor; 5360 if (!SelectPatternResult::isMinOrMax(SPF)) 5361 return false; 5362 return match(Op0, m_MaxOrMin(m_Value(), m_Value())) || 5363 match(Op1, m_MaxOrMin(m_Value(), m_Value())); 5364 }; 5365 if (!isMinMaxCmp(I)) { 5366 switch (Pred) { 5367 default: 5368 break; 5369 case ICmpInst::ICMP_ULT: { 5370 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5371 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5372 const APInt *CmpC; 5373 if (match(Op1, m_APInt(CmpC))) { 5374 // A <u C -> A == C-1 if min(A)+1 == C 5375 if (*CmpC == Op0Min + 1) 5376 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5377 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5378 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5379 // exceeds the log2 of C. 5380 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5381 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5382 Constant::getNullValue(Op1->getType())); 5383 } 5384 break; 5385 } 5386 case ICmpInst::ICMP_UGT: { 5387 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5388 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5389 const APInt *CmpC; 5390 if (match(Op1, m_APInt(CmpC))) { 5391 // A >u C -> A == C+1 if max(a)-1 == C 5392 if (*CmpC == Op0Max - 1) 5393 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5394 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5395 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5396 // exceeds the log2 of C. 5397 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5398 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5399 Constant::getNullValue(Op1->getType())); 5400 } 5401 break; 5402 } 5403 case ICmpInst::ICMP_SLT: { 5404 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5405 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5406 const APInt *CmpC; 5407 if (match(Op1, m_APInt(CmpC))) { 5408 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5409 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5410 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5411 } 5412 break; 5413 } 5414 case ICmpInst::ICMP_SGT: { 5415 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5416 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5417 const APInt *CmpC; 5418 if (match(Op1, m_APInt(CmpC))) { 5419 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5420 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5421 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5422 } 5423 break; 5424 } 5425 } 5426 } 5427 5428 // Based on the range information we know about the LHS, see if we can 5429 // simplify this comparison. For example, (x&4) < 8 is always true. 5430 switch (Pred) { 5431 default: 5432 llvm_unreachable("Unknown icmp opcode!"); 5433 case ICmpInst::ICMP_EQ: 5434 case ICmpInst::ICMP_NE: { 5435 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) 5436 return replaceInstUsesWith( 5437 I, ConstantInt::getBool(I.getType(), Pred == CmpInst::ICMP_NE)); 5438 5439 // If all bits are known zero except for one, then we know at most one bit 5440 // is set. If the comparison is against zero, then this is a check to see if 5441 // *that* bit is set. 5442 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 5443 if (Op1Known.isZero()) { 5444 // If the LHS is an AND with the same constant, look through it. 5445 Value *LHS = nullptr; 5446 const APInt *LHSC; 5447 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 5448 *LHSC != Op0KnownZeroInverted) 5449 LHS = Op0; 5450 5451 Value *X; 5452 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 5453 APInt ValToCheck = Op0KnownZeroInverted; 5454 Type *XTy = X->getType(); 5455 if (ValToCheck.isPowerOf2()) { 5456 // ((1 << X) & 8) == 0 -> X != 3 5457 // ((1 << X) & 8) != 0 -> X == 3 5458 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5459 auto NewPred = ICmpInst::getInversePredicate(Pred); 5460 return new ICmpInst(NewPred, X, CmpC); 5461 } else if ((++ValToCheck).isPowerOf2()) { 5462 // ((1 << X) & 7) == 0 -> X >= 3 5463 // ((1 << X) & 7) != 0 -> X < 3 5464 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5465 auto NewPred = 5466 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 5467 return new ICmpInst(NewPred, X, CmpC); 5468 } 5469 } 5470 5471 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 5472 const APInt *CI; 5473 if (Op0KnownZeroInverted.isOne() && 5474 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 5475 // ((8 >>u X) & 1) == 0 -> X != 3 5476 // ((8 >>u X) & 1) != 0 -> X == 3 5477 unsigned CmpVal = CI->countTrailingZeros(); 5478 auto NewPred = ICmpInst::getInversePredicate(Pred); 5479 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 5480 } 5481 } 5482 break; 5483 } 5484 case ICmpInst::ICMP_ULT: { 5485 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5486 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5487 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5488 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5489 break; 5490 } 5491 case ICmpInst::ICMP_UGT: { 5492 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5493 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5494 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5495 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5496 break; 5497 } 5498 case ICmpInst::ICMP_SLT: { 5499 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5500 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5501 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5502 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5503 break; 5504 } 5505 case ICmpInst::ICMP_SGT: { 5506 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5507 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5508 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5509 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5510 break; 5511 } 5512 case ICmpInst::ICMP_SGE: 5513 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5514 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5515 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5516 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5517 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5518 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5519 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5520 break; 5521 case ICmpInst::ICMP_SLE: 5522 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5523 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5524 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5525 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5526 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5527 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5528 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5529 break; 5530 case ICmpInst::ICMP_UGE: 5531 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5532 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5533 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5534 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5535 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5536 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5537 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5538 break; 5539 case ICmpInst::ICMP_ULE: 5540 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5541 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5542 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5543 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5544 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5545 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5546 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5547 break; 5548 } 5549 5550 // Turn a signed comparison into an unsigned one if both operands are known to 5551 // have the same sign. 5552 if (I.isSigned() && 5553 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5554 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5555 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5556 5557 return nullptr; 5558 } 5559 5560 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5561 InstCombiner::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5562 Constant *C) { 5563 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5564 "Only for relational integer predicates."); 5565 5566 Type *Type = C->getType(); 5567 bool IsSigned = ICmpInst::isSigned(Pred); 5568 5569 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5570 bool WillIncrement = 5571 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5572 5573 // Check if the constant operand can be safely incremented/decremented 5574 // without overflowing/underflowing. 5575 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5576 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5577 }; 5578 5579 Constant *SafeReplacementConstant = nullptr; 5580 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5581 // Bail out if the constant can't be safely incremented/decremented. 5582 if (!ConstantIsOk(CI)) 5583 return llvm::None; 5584 } else if (auto *FVTy = dyn_cast<FixedVectorType>(Type)) { 5585 unsigned NumElts = FVTy->getNumElements(); 5586 for (unsigned i = 0; i != NumElts; ++i) { 5587 Constant *Elt = C->getAggregateElement(i); 5588 if (!Elt) 5589 return llvm::None; 5590 5591 if (isa<UndefValue>(Elt)) 5592 continue; 5593 5594 // Bail out if we can't determine if this constant is min/max or if we 5595 // know that this constant is min/max. 5596 auto *CI = dyn_cast<ConstantInt>(Elt); 5597 if (!CI || !ConstantIsOk(CI)) 5598 return llvm::None; 5599 5600 if (!SafeReplacementConstant) 5601 SafeReplacementConstant = CI; 5602 } 5603 } else { 5604 // ConstantExpr? 5605 return llvm::None; 5606 } 5607 5608 // It may not be safe to change a compare predicate in the presence of 5609 // undefined elements, so replace those elements with the first safe constant 5610 // that we found. 5611 // TODO: in case of poison, it is safe; let's replace undefs only. 5612 if (C->containsUndefOrPoisonElement()) { 5613 assert(SafeReplacementConstant && "Replacement constant not set"); 5614 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5615 } 5616 5617 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5618 5619 // Increment or decrement the constant. 5620 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5621 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5622 5623 return std::make_pair(NewPred, NewC); 5624 } 5625 5626 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5627 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5628 /// allows them to be folded in visitICmpInst. 5629 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5630 ICmpInst::Predicate Pred = I.getPredicate(); 5631 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5632 InstCombiner::isCanonicalPredicate(Pred)) 5633 return nullptr; 5634 5635 Value *Op0 = I.getOperand(0); 5636 Value *Op1 = I.getOperand(1); 5637 auto *Op1C = dyn_cast<Constant>(Op1); 5638 if (!Op1C) 5639 return nullptr; 5640 5641 auto FlippedStrictness = 5642 InstCombiner::getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5643 if (!FlippedStrictness) 5644 return nullptr; 5645 5646 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5647 } 5648 5649 /// If we have a comparison with a non-canonical predicate, if we can update 5650 /// all the users, invert the predicate and adjust all the users. 5651 CmpInst *InstCombinerImpl::canonicalizeICmpPredicate(CmpInst &I) { 5652 // Is the predicate already canonical? 5653 CmpInst::Predicate Pred = I.getPredicate(); 5654 if (InstCombiner::isCanonicalPredicate(Pred)) 5655 return nullptr; 5656 5657 // Can all users be adjusted to predicate inversion? 5658 if (!InstCombiner::canFreelyInvertAllUsersOf(&I, /*IgnoredUser=*/nullptr)) 5659 return nullptr; 5660 5661 // Ok, we can canonicalize comparison! 5662 // Let's first invert the comparison's predicate. 5663 I.setPredicate(CmpInst::getInversePredicate(Pred)); 5664 I.setName(I.getName() + ".not"); 5665 5666 // And, adapt users. 5667 freelyInvertAllUsersOf(&I); 5668 5669 return &I; 5670 } 5671 5672 /// Integer compare with boolean values can always be turned into bitwise ops. 5673 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5674 InstCombiner::BuilderTy &Builder) { 5675 Value *A = I.getOperand(0), *B = I.getOperand(1); 5676 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5677 5678 // A boolean compared to true/false can be simplified to Op0/true/false in 5679 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5680 // Cases not handled by InstSimplify are always 'not' of Op0. 5681 if (match(B, m_Zero())) { 5682 switch (I.getPredicate()) { 5683 case CmpInst::ICMP_EQ: // A == 0 -> !A 5684 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5685 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5686 return BinaryOperator::CreateNot(A); 5687 default: 5688 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5689 } 5690 } else if (match(B, m_One())) { 5691 switch (I.getPredicate()) { 5692 case CmpInst::ICMP_NE: // A != 1 -> !A 5693 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5694 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5695 return BinaryOperator::CreateNot(A); 5696 default: 5697 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5698 } 5699 } 5700 5701 switch (I.getPredicate()) { 5702 default: 5703 llvm_unreachable("Invalid icmp instruction!"); 5704 case ICmpInst::ICMP_EQ: 5705 // icmp eq i1 A, B -> ~(A ^ B) 5706 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5707 5708 case ICmpInst::ICMP_NE: 5709 // icmp ne i1 A, B -> A ^ B 5710 return BinaryOperator::CreateXor(A, B); 5711 5712 case ICmpInst::ICMP_UGT: 5713 // icmp ugt -> icmp ult 5714 std::swap(A, B); 5715 LLVM_FALLTHROUGH; 5716 case ICmpInst::ICMP_ULT: 5717 // icmp ult i1 A, B -> ~A & B 5718 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5719 5720 case ICmpInst::ICMP_SGT: 5721 // icmp sgt -> icmp slt 5722 std::swap(A, B); 5723 LLVM_FALLTHROUGH; 5724 case ICmpInst::ICMP_SLT: 5725 // icmp slt i1 A, B -> A & ~B 5726 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5727 5728 case ICmpInst::ICMP_UGE: 5729 // icmp uge -> icmp ule 5730 std::swap(A, B); 5731 LLVM_FALLTHROUGH; 5732 case ICmpInst::ICMP_ULE: 5733 // icmp ule i1 A, B -> ~A | B 5734 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5735 5736 case ICmpInst::ICMP_SGE: 5737 // icmp sge -> icmp sle 5738 std::swap(A, B); 5739 LLVM_FALLTHROUGH; 5740 case ICmpInst::ICMP_SLE: 5741 // icmp sle i1 A, B -> A | ~B 5742 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5743 } 5744 } 5745 5746 // Transform pattern like: 5747 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5748 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5749 // Into: 5750 // (X l>> Y) != 0 5751 // (X l>> Y) == 0 5752 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5753 InstCombiner::BuilderTy &Builder) { 5754 ICmpInst::Predicate Pred, NewPred; 5755 Value *X, *Y; 5756 if (match(&Cmp, 5757 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5758 switch (Pred) { 5759 case ICmpInst::ICMP_ULE: 5760 NewPred = ICmpInst::ICMP_NE; 5761 break; 5762 case ICmpInst::ICMP_UGT: 5763 NewPred = ICmpInst::ICMP_EQ; 5764 break; 5765 default: 5766 return nullptr; 5767 } 5768 } else if (match(&Cmp, m_c_ICmp(Pred, 5769 m_OneUse(m_CombineOr( 5770 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5771 m_Add(m_Shl(m_One(), m_Value(Y)), 5772 m_AllOnes()))), 5773 m_Value(X)))) { 5774 // The variant with 'add' is not canonical, (the variant with 'not' is) 5775 // we only get it because it has extra uses, and can't be canonicalized, 5776 5777 switch (Pred) { 5778 case ICmpInst::ICMP_ULT: 5779 NewPred = ICmpInst::ICMP_NE; 5780 break; 5781 case ICmpInst::ICMP_UGE: 5782 NewPred = ICmpInst::ICMP_EQ; 5783 break; 5784 default: 5785 return nullptr; 5786 } 5787 } else 5788 return nullptr; 5789 5790 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5791 Constant *Zero = Constant::getNullValue(NewX->getType()); 5792 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5793 } 5794 5795 static Instruction *foldVectorCmp(CmpInst &Cmp, 5796 InstCombiner::BuilderTy &Builder) { 5797 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5798 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5799 Value *V1, *V2; 5800 ArrayRef<int> M; 5801 if (!match(LHS, m_Shuffle(m_Value(V1), m_Undef(), m_Mask(M)))) 5802 return nullptr; 5803 5804 // If both arguments of the cmp are shuffles that use the same mask and 5805 // shuffle within a single vector, move the shuffle after the cmp: 5806 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5807 Type *V1Ty = V1->getType(); 5808 if (match(RHS, m_Shuffle(m_Value(V2), m_Undef(), m_SpecificMask(M))) && 5809 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5810 Value *NewCmp = Builder.CreateCmp(Pred, V1, V2); 5811 return new ShuffleVectorInst(NewCmp, M); 5812 } 5813 5814 // Try to canonicalize compare with splatted operand and splat constant. 5815 // TODO: We could generalize this for more than splats. See/use the code in 5816 // InstCombiner::foldVectorBinop(). 5817 Constant *C; 5818 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5819 return nullptr; 5820 5821 // Length-changing splats are ok, so adjust the constants as needed: 5822 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5823 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5824 int MaskSplatIndex; 5825 if (ScalarC && match(M, m_SplatOrUndefMask(MaskSplatIndex))) { 5826 // We allow undefs in matching, but this transform removes those for safety. 5827 // Demanded elements analysis should be able to recover some/all of that. 5828 C = ConstantVector::getSplat(cast<VectorType>(V1Ty)->getElementCount(), 5829 ScalarC); 5830 SmallVector<int, 8> NewM(M.size(), MaskSplatIndex); 5831 Value *NewCmp = Builder.CreateCmp(Pred, V1, C); 5832 return new ShuffleVectorInst(NewCmp, NewM); 5833 } 5834 5835 return nullptr; 5836 } 5837 5838 // extract(uadd.with.overflow(A, B), 0) ult A 5839 // -> extract(uadd.with.overflow(A, B), 1) 5840 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5841 CmpInst::Predicate Pred = I.getPredicate(); 5842 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5843 5844 Value *UAddOv; 5845 Value *A, *B; 5846 auto UAddOvResultPat = m_ExtractValue<0>( 5847 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5848 if (match(Op0, UAddOvResultPat) && 5849 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5850 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5851 (match(A, m_One()) || match(B, m_One()))) || 5852 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5853 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5854 // extract(uadd.with.overflow(A, B), 0) < A 5855 // extract(uadd.with.overflow(A, 1), 0) == 0 5856 // extract(uadd.with.overflow(A, -1), 0) != -1 5857 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5858 else if (match(Op1, UAddOvResultPat) && 5859 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5860 // A > extract(uadd.with.overflow(A, B), 0) 5861 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5862 else 5863 return nullptr; 5864 5865 return ExtractValueInst::Create(UAddOv, 1); 5866 } 5867 5868 static Instruction *foldICmpInvariantGroup(ICmpInst &I) { 5869 if (!I.getOperand(0)->getType()->isPointerTy() || 5870 NullPointerIsDefined( 5871 I.getParent()->getParent(), 5872 I.getOperand(0)->getType()->getPointerAddressSpace())) { 5873 return nullptr; 5874 } 5875 Instruction *Op; 5876 if (match(I.getOperand(0), m_Instruction(Op)) && 5877 match(I.getOperand(1), m_Zero()) && 5878 Op->isLaunderOrStripInvariantGroup()) { 5879 return ICmpInst::Create(Instruction::ICmp, I.getPredicate(), 5880 Op->getOperand(0), I.getOperand(1)); 5881 } 5882 return nullptr; 5883 } 5884 5885 Instruction *InstCombinerImpl::visitICmpInst(ICmpInst &I) { 5886 bool Changed = false; 5887 const SimplifyQuery Q = SQ.getWithInstruction(&I); 5888 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5889 unsigned Op0Cplxity = getComplexity(Op0); 5890 unsigned Op1Cplxity = getComplexity(Op1); 5891 5892 /// Orders the operands of the compare so that they are listed from most 5893 /// complex to least complex. This puts constants before unary operators, 5894 /// before binary operators. 5895 if (Op0Cplxity < Op1Cplxity || 5896 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 5897 I.swapOperands(); 5898 std::swap(Op0, Op1); 5899 Changed = true; 5900 } 5901 5902 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 5903 return replaceInstUsesWith(I, V); 5904 5905 // Comparing -val or val with non-zero is the same as just comparing val 5906 // ie, abs(val) != 0 -> val != 0 5907 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 5908 Value *Cond, *SelectTrue, *SelectFalse; 5909 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 5910 m_Value(SelectFalse)))) { 5911 if (Value *V = dyn_castNegVal(SelectTrue)) { 5912 if (V == SelectFalse) 5913 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5914 } 5915 else if (Value *V = dyn_castNegVal(SelectFalse)) { 5916 if (V == SelectTrue) 5917 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5918 } 5919 } 5920 } 5921 5922 if (Op0->getType()->isIntOrIntVectorTy(1)) 5923 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 5924 return Res; 5925 5926 if (Instruction *Res = canonicalizeCmpWithConstant(I)) 5927 return Res; 5928 5929 if (Instruction *Res = canonicalizeICmpPredicate(I)) 5930 return Res; 5931 5932 if (Instruction *Res = foldICmpWithConstant(I)) 5933 return Res; 5934 5935 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 5936 return Res; 5937 5938 if (Instruction *Res = foldICmpUsingKnownBits(I)) 5939 return Res; 5940 5941 // Test if the ICmpInst instruction is used exclusively by a select as 5942 // part of a minimum or maximum operation. If so, refrain from doing 5943 // any other folding. This helps out other analyses which understand 5944 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5945 // and CodeGen. And in this case, at least one of the comparison 5946 // operands has at least one user besides the compare (the select), 5947 // which would often largely negate the benefit of folding anyway. 5948 // 5949 // Do the same for the other patterns recognized by matchSelectPattern. 5950 if (I.hasOneUse()) 5951 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5952 Value *A, *B; 5953 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5954 if (SPR.Flavor != SPF_UNKNOWN) 5955 return nullptr; 5956 } 5957 5958 // Do this after checking for min/max to prevent infinite looping. 5959 if (Instruction *Res = foldICmpWithZero(I)) 5960 return Res; 5961 5962 // FIXME: We only do this after checking for min/max to prevent infinite 5963 // looping caused by a reverse canonicalization of these patterns for min/max. 5964 // FIXME: The organization of folds is a mess. These would naturally go into 5965 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 5966 // down here after the min/max restriction. 5967 ICmpInst::Predicate Pred = I.getPredicate(); 5968 const APInt *C; 5969 if (match(Op1, m_APInt(C))) { 5970 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 5971 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 5972 Constant *Zero = Constant::getNullValue(Op0->getType()); 5973 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 5974 } 5975 5976 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 5977 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 5978 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 5979 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 5980 } 5981 } 5982 5983 // The folds in here may rely on wrapping flags and special constants, so 5984 // they can break up min/max idioms in some cases but not seemingly similar 5985 // patterns. 5986 // FIXME: It may be possible to enhance select folding to make this 5987 // unnecessary. It may also be moot if we canonicalize to min/max 5988 // intrinsics. 5989 if (Instruction *Res = foldICmpBinOp(I, Q)) 5990 return Res; 5991 5992 if (Instruction *Res = foldICmpInstWithConstant(I)) 5993 return Res; 5994 5995 // Try to match comparison as a sign bit test. Intentionally do this after 5996 // foldICmpInstWithConstant() to potentially let other folds to happen first. 5997 if (Instruction *New = foldSignBitTest(I)) 5998 return New; 5999 6000 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 6001 return Res; 6002 6003 // Try to optimize 'icmp GEP, P' or 'icmp P, GEP'. 6004 if (auto *GEP = dyn_cast<GEPOperator>(Op0)) 6005 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 6006 return NI; 6007 if (auto *GEP = dyn_cast<GEPOperator>(Op1)) 6008 if (Instruction *NI = foldGEPICmp(GEP, Op0, I.getSwappedPredicate(), I)) 6009 return NI; 6010 6011 // Try to optimize equality comparisons against alloca-based pointers. 6012 if (Op0->getType()->isPointerTy() && I.isEquality()) { 6013 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 6014 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op0))) 6015 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 6016 return New; 6017 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op1))) 6018 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 6019 return New; 6020 } 6021 6022 if (Instruction *Res = foldICmpBitCast(I)) 6023 return Res; 6024 6025 // TODO: Hoist this above the min/max bailout. 6026 if (Instruction *R = foldICmpWithCastOp(I)) 6027 return R; 6028 6029 if (Instruction *Res = foldICmpWithMinMax(I)) 6030 return Res; 6031 6032 { 6033 Value *A, *B; 6034 // Transform (A & ~B) == 0 --> (A & B) != 0 6035 // and (A & ~B) != 0 --> (A & B) == 0 6036 // if A is a power of 2. 6037 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 6038 match(Op1, m_Zero()) && 6039 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 6040 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 6041 Op1); 6042 6043 // ~X < ~Y --> Y < X 6044 // ~X < C --> X > ~C 6045 if (match(Op0, m_Not(m_Value(A)))) { 6046 if (match(Op1, m_Not(m_Value(B)))) 6047 return new ICmpInst(I.getPredicate(), B, A); 6048 6049 const APInt *C; 6050 if (match(Op1, m_APInt(C))) 6051 return new ICmpInst(I.getSwappedPredicate(), A, 6052 ConstantInt::get(Op1->getType(), ~(*C))); 6053 } 6054 6055 Instruction *AddI = nullptr; 6056 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 6057 m_Instruction(AddI))) && 6058 isa<IntegerType>(A->getType())) { 6059 Value *Result; 6060 Constant *Overflow; 6061 // m_UAddWithOverflow can match patterns that do not include an explicit 6062 // "add" instruction, so check the opcode of the matched op. 6063 if (AddI->getOpcode() == Instruction::Add && 6064 OptimizeOverflowCheck(Instruction::Add, /*Signed*/ false, A, B, *AddI, 6065 Result, Overflow)) { 6066 replaceInstUsesWith(*AddI, Result); 6067 eraseInstFromFunction(*AddI); 6068 return replaceInstUsesWith(I, Overflow); 6069 } 6070 } 6071 6072 // (zext a) * (zext b) --> llvm.umul.with.overflow. 6073 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6074 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 6075 return R; 6076 } 6077 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6078 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 6079 return R; 6080 } 6081 } 6082 6083 if (Instruction *Res = foldICmpEquality(I)) 6084 return Res; 6085 6086 if (Instruction *Res = foldICmpOfUAddOv(I)) 6087 return Res; 6088 6089 // The 'cmpxchg' instruction returns an aggregate containing the old value and 6090 // an i1 which indicates whether or not we successfully did the swap. 6091 // 6092 // Replace comparisons between the old value and the expected value with the 6093 // indicator that 'cmpxchg' returns. 6094 // 6095 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 6096 // spuriously fail. In those cases, the old value may equal the expected 6097 // value but it is possible for the swap to not occur. 6098 if (I.getPredicate() == ICmpInst::ICMP_EQ) 6099 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 6100 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 6101 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 6102 !ACXI->isWeak()) 6103 return ExtractValueInst::Create(ACXI, 1); 6104 6105 { 6106 Value *X; 6107 const APInt *C; 6108 // icmp X+Cst, X 6109 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 6110 return foldICmpAddOpConst(X, *C, I.getPredicate()); 6111 6112 // icmp X, X+Cst 6113 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 6114 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 6115 } 6116 6117 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 6118 return Res; 6119 6120 if (I.getType()->isVectorTy()) 6121 if (Instruction *Res = foldVectorCmp(I, Builder)) 6122 return Res; 6123 6124 if (Instruction *Res = foldICmpInvariantGroup(I)) 6125 return Res; 6126 6127 return Changed ? &I : nullptr; 6128 } 6129 6130 /// Fold fcmp ([us]itofp x, cst) if possible. 6131 Instruction *InstCombinerImpl::foldFCmpIntToFPConst(FCmpInst &I, 6132 Instruction *LHSI, 6133 Constant *RHSC) { 6134 if (!isa<ConstantFP>(RHSC)) return nullptr; 6135 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 6136 6137 // Get the width of the mantissa. We don't want to hack on conversions that 6138 // might lose information from the integer, e.g. "i64 -> float" 6139 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 6140 if (MantissaWidth == -1) return nullptr; // Unknown. 6141 6142 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 6143 6144 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 6145 6146 if (I.isEquality()) { 6147 FCmpInst::Predicate P = I.getPredicate(); 6148 bool IsExact = false; 6149 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 6150 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 6151 6152 // If the floating point constant isn't an integer value, we know if we will 6153 // ever compare equal / not equal to it. 6154 if (!IsExact) { 6155 // TODO: Can never be -0.0 and other non-representable values 6156 APFloat RHSRoundInt(RHS); 6157 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 6158 if (RHS != RHSRoundInt) { 6159 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 6160 return replaceInstUsesWith(I, Builder.getFalse()); 6161 6162 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 6163 return replaceInstUsesWith(I, Builder.getTrue()); 6164 } 6165 } 6166 6167 // TODO: If the constant is exactly representable, is it always OK to do 6168 // equality compares as integer? 6169 } 6170 6171 // Check to see that the input is converted from an integer type that is small 6172 // enough that preserves all bits. TODO: check here for "known" sign bits. 6173 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 6174 unsigned InputSize = IntTy->getScalarSizeInBits(); 6175 6176 // Following test does NOT adjust InputSize downwards for signed inputs, 6177 // because the most negative value still requires all the mantissa bits 6178 // to distinguish it from one less than that value. 6179 if ((int)InputSize > MantissaWidth) { 6180 // Conversion would lose accuracy. Check if loss can impact comparison. 6181 int Exp = ilogb(RHS); 6182 if (Exp == APFloat::IEK_Inf) { 6183 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 6184 if (MaxExponent < (int)InputSize - !LHSUnsigned) 6185 // Conversion could create infinity. 6186 return nullptr; 6187 } else { 6188 // Note that if RHS is zero or NaN, then Exp is negative 6189 // and first condition is trivially false. 6190 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 6191 // Conversion could affect comparison. 6192 return nullptr; 6193 } 6194 } 6195 6196 // Otherwise, we can potentially simplify the comparison. We know that it 6197 // will always come through as an integer value and we know the constant is 6198 // not a NAN (it would have been previously simplified). 6199 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 6200 6201 ICmpInst::Predicate Pred; 6202 switch (I.getPredicate()) { 6203 default: llvm_unreachable("Unexpected predicate!"); 6204 case FCmpInst::FCMP_UEQ: 6205 case FCmpInst::FCMP_OEQ: 6206 Pred = ICmpInst::ICMP_EQ; 6207 break; 6208 case FCmpInst::FCMP_UGT: 6209 case FCmpInst::FCMP_OGT: 6210 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 6211 break; 6212 case FCmpInst::FCMP_UGE: 6213 case FCmpInst::FCMP_OGE: 6214 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 6215 break; 6216 case FCmpInst::FCMP_ULT: 6217 case FCmpInst::FCMP_OLT: 6218 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 6219 break; 6220 case FCmpInst::FCMP_ULE: 6221 case FCmpInst::FCMP_OLE: 6222 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 6223 break; 6224 case FCmpInst::FCMP_UNE: 6225 case FCmpInst::FCMP_ONE: 6226 Pred = ICmpInst::ICMP_NE; 6227 break; 6228 case FCmpInst::FCMP_ORD: 6229 return replaceInstUsesWith(I, Builder.getTrue()); 6230 case FCmpInst::FCMP_UNO: 6231 return replaceInstUsesWith(I, Builder.getFalse()); 6232 } 6233 6234 // Now we know that the APFloat is a normal number, zero or inf. 6235 6236 // See if the FP constant is too large for the integer. For example, 6237 // comparing an i8 to 300.0. 6238 unsigned IntWidth = IntTy->getScalarSizeInBits(); 6239 6240 if (!LHSUnsigned) { 6241 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 6242 // and large values. 6243 APFloat SMax(RHS.getSemantics()); 6244 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 6245 APFloat::rmNearestTiesToEven); 6246 if (SMax < RHS) { // smax < 13123.0 6247 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 6248 Pred == ICmpInst::ICMP_SLE) 6249 return replaceInstUsesWith(I, Builder.getTrue()); 6250 return replaceInstUsesWith(I, Builder.getFalse()); 6251 } 6252 } else { 6253 // If the RHS value is > UnsignedMax, fold the comparison. This handles 6254 // +INF and large values. 6255 APFloat UMax(RHS.getSemantics()); 6256 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 6257 APFloat::rmNearestTiesToEven); 6258 if (UMax < RHS) { // umax < 13123.0 6259 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 6260 Pred == ICmpInst::ICMP_ULE) 6261 return replaceInstUsesWith(I, Builder.getTrue()); 6262 return replaceInstUsesWith(I, Builder.getFalse()); 6263 } 6264 } 6265 6266 if (!LHSUnsigned) { 6267 // See if the RHS value is < SignedMin. 6268 APFloat SMin(RHS.getSemantics()); 6269 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 6270 APFloat::rmNearestTiesToEven); 6271 if (SMin > RHS) { // smin > 12312.0 6272 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 6273 Pred == ICmpInst::ICMP_SGE) 6274 return replaceInstUsesWith(I, Builder.getTrue()); 6275 return replaceInstUsesWith(I, Builder.getFalse()); 6276 } 6277 } else { 6278 // See if the RHS value is < UnsignedMin. 6279 APFloat UMin(RHS.getSemantics()); 6280 UMin.convertFromAPInt(APInt::getMinValue(IntWidth), false, 6281 APFloat::rmNearestTiesToEven); 6282 if (UMin > RHS) { // umin > 12312.0 6283 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 6284 Pred == ICmpInst::ICMP_UGE) 6285 return replaceInstUsesWith(I, Builder.getTrue()); 6286 return replaceInstUsesWith(I, Builder.getFalse()); 6287 } 6288 } 6289 6290 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 6291 // [0, UMAX], but it may still be fractional. See if it is fractional by 6292 // casting the FP value to the integer value and back, checking for equality. 6293 // Don't do this for zero, because -0.0 is not fractional. 6294 Constant *RHSInt = LHSUnsigned 6295 ? ConstantExpr::getFPToUI(RHSC, IntTy) 6296 : ConstantExpr::getFPToSI(RHSC, IntTy); 6297 if (!RHS.isZero()) { 6298 bool Equal = LHSUnsigned 6299 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 6300 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 6301 if (!Equal) { 6302 // If we had a comparison against a fractional value, we have to adjust 6303 // the compare predicate and sometimes the value. RHSC is rounded towards 6304 // zero at this point. 6305 switch (Pred) { 6306 default: llvm_unreachable("Unexpected integer comparison!"); 6307 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 6308 return replaceInstUsesWith(I, Builder.getTrue()); 6309 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 6310 return replaceInstUsesWith(I, Builder.getFalse()); 6311 case ICmpInst::ICMP_ULE: 6312 // (float)int <= 4.4 --> int <= 4 6313 // (float)int <= -4.4 --> false 6314 if (RHS.isNegative()) 6315 return replaceInstUsesWith(I, Builder.getFalse()); 6316 break; 6317 case ICmpInst::ICMP_SLE: 6318 // (float)int <= 4.4 --> int <= 4 6319 // (float)int <= -4.4 --> int < -4 6320 if (RHS.isNegative()) 6321 Pred = ICmpInst::ICMP_SLT; 6322 break; 6323 case ICmpInst::ICMP_ULT: 6324 // (float)int < -4.4 --> false 6325 // (float)int < 4.4 --> int <= 4 6326 if (RHS.isNegative()) 6327 return replaceInstUsesWith(I, Builder.getFalse()); 6328 Pred = ICmpInst::ICMP_ULE; 6329 break; 6330 case ICmpInst::ICMP_SLT: 6331 // (float)int < -4.4 --> int < -4 6332 // (float)int < 4.4 --> int <= 4 6333 if (!RHS.isNegative()) 6334 Pred = ICmpInst::ICMP_SLE; 6335 break; 6336 case ICmpInst::ICMP_UGT: 6337 // (float)int > 4.4 --> int > 4 6338 // (float)int > -4.4 --> true 6339 if (RHS.isNegative()) 6340 return replaceInstUsesWith(I, Builder.getTrue()); 6341 break; 6342 case ICmpInst::ICMP_SGT: 6343 // (float)int > 4.4 --> int > 4 6344 // (float)int > -4.4 --> int >= -4 6345 if (RHS.isNegative()) 6346 Pred = ICmpInst::ICMP_SGE; 6347 break; 6348 case ICmpInst::ICMP_UGE: 6349 // (float)int >= -4.4 --> true 6350 // (float)int >= 4.4 --> int > 4 6351 if (RHS.isNegative()) 6352 return replaceInstUsesWith(I, Builder.getTrue()); 6353 Pred = ICmpInst::ICMP_UGT; 6354 break; 6355 case ICmpInst::ICMP_SGE: 6356 // (float)int >= -4.4 --> int >= -4 6357 // (float)int >= 4.4 --> int > 4 6358 if (!RHS.isNegative()) 6359 Pred = ICmpInst::ICMP_SGT; 6360 break; 6361 } 6362 } 6363 } 6364 6365 // Lower this FP comparison into an appropriate integer version of the 6366 // comparison. 6367 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 6368 } 6369 6370 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 6371 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 6372 Constant *RHSC) { 6373 // When C is not 0.0 and infinities are not allowed: 6374 // (C / X) < 0.0 is a sign-bit test of X 6375 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 6376 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 6377 // 6378 // Proof: 6379 // Multiply (C / X) < 0.0 by X * X / C. 6380 // - X is non zero, if it is the flag 'ninf' is violated. 6381 // - C defines the sign of X * X * C. Thus it also defines whether to swap 6382 // the predicate. C is also non zero by definition. 6383 // 6384 // Thus X * X / C is non zero and the transformation is valid. [qed] 6385 6386 FCmpInst::Predicate Pred = I.getPredicate(); 6387 6388 // Check that predicates are valid. 6389 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 6390 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 6391 return nullptr; 6392 6393 // Check that RHS operand is zero. 6394 if (!match(RHSC, m_AnyZeroFP())) 6395 return nullptr; 6396 6397 // Check fastmath flags ('ninf'). 6398 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 6399 return nullptr; 6400 6401 // Check the properties of the dividend. It must not be zero to avoid a 6402 // division by zero (see Proof). 6403 const APFloat *C; 6404 if (!match(LHSI->getOperand(0), m_APFloat(C))) 6405 return nullptr; 6406 6407 if (C->isZero()) 6408 return nullptr; 6409 6410 // Get swapped predicate if necessary. 6411 if (C->isNegative()) 6412 Pred = I.getSwappedPredicate(); 6413 6414 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 6415 } 6416 6417 /// Optimize fabs(X) compared with zero. 6418 static Instruction *foldFabsWithFcmpZero(FCmpInst &I, InstCombinerImpl &IC) { 6419 Value *X; 6420 if (!match(I.getOperand(0), m_FAbs(m_Value(X))) || 6421 !match(I.getOperand(1), m_PosZeroFP())) 6422 return nullptr; 6423 6424 auto replacePredAndOp0 = [&IC](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 6425 I->setPredicate(P); 6426 return IC.replaceOperand(*I, 0, X); 6427 }; 6428 6429 switch (I.getPredicate()) { 6430 case FCmpInst::FCMP_UGE: 6431 case FCmpInst::FCMP_OLT: 6432 // fabs(X) >= 0.0 --> true 6433 // fabs(X) < 0.0 --> false 6434 llvm_unreachable("fcmp should have simplified"); 6435 6436 case FCmpInst::FCMP_OGT: 6437 // fabs(X) > 0.0 --> X != 0.0 6438 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 6439 6440 case FCmpInst::FCMP_UGT: 6441 // fabs(X) u> 0.0 --> X u!= 0.0 6442 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 6443 6444 case FCmpInst::FCMP_OLE: 6445 // fabs(X) <= 0.0 --> X == 0.0 6446 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 6447 6448 case FCmpInst::FCMP_ULE: 6449 // fabs(X) u<= 0.0 --> X u== 0.0 6450 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 6451 6452 case FCmpInst::FCMP_OGE: 6453 // fabs(X) >= 0.0 --> !isnan(X) 6454 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6455 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 6456 6457 case FCmpInst::FCMP_ULT: 6458 // fabs(X) u< 0.0 --> isnan(X) 6459 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6460 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 6461 6462 case FCmpInst::FCMP_OEQ: 6463 case FCmpInst::FCMP_UEQ: 6464 case FCmpInst::FCMP_ONE: 6465 case FCmpInst::FCMP_UNE: 6466 case FCmpInst::FCMP_ORD: 6467 case FCmpInst::FCMP_UNO: 6468 // Look through the fabs() because it doesn't change anything but the sign. 6469 // fabs(X) == 0.0 --> X == 0.0, 6470 // fabs(X) != 0.0 --> X != 0.0 6471 // isnan(fabs(X)) --> isnan(X) 6472 // !isnan(fabs(X) --> !isnan(X) 6473 return replacePredAndOp0(&I, I.getPredicate(), X); 6474 6475 default: 6476 return nullptr; 6477 } 6478 } 6479 6480 Instruction *InstCombinerImpl::visitFCmpInst(FCmpInst &I) { 6481 bool Changed = false; 6482 6483 /// Orders the operands of the compare so that they are listed from most 6484 /// complex to least complex. This puts constants before unary operators, 6485 /// before binary operators. 6486 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 6487 I.swapOperands(); 6488 Changed = true; 6489 } 6490 6491 const CmpInst::Predicate Pred = I.getPredicate(); 6492 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6493 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6494 SQ.getWithInstruction(&I))) 6495 return replaceInstUsesWith(I, V); 6496 6497 // Simplify 'fcmp pred X, X' 6498 Type *OpType = Op0->getType(); 6499 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6500 if (Op0 == Op1) { 6501 switch (Pred) { 6502 default: break; 6503 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6504 case FCmpInst::FCMP_ULT: // True if unordered or less than 6505 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6506 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6507 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6508 I.setPredicate(FCmpInst::FCMP_UNO); 6509 I.setOperand(1, Constant::getNullValue(OpType)); 6510 return &I; 6511 6512 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6513 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6514 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6515 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6516 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6517 I.setPredicate(FCmpInst::FCMP_ORD); 6518 I.setOperand(1, Constant::getNullValue(OpType)); 6519 return &I; 6520 } 6521 } 6522 6523 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6524 // then canonicalize the operand to 0.0. 6525 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6526 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6527 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6528 6529 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6530 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6531 } 6532 6533 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6534 Value *X, *Y; 6535 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6536 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6537 6538 // Test if the FCmpInst instruction is used exclusively by a select as 6539 // part of a minimum or maximum operation. If so, refrain from doing 6540 // any other folding. This helps out other analyses which understand 6541 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6542 // and CodeGen. And in this case, at least one of the comparison 6543 // operands has at least one user besides the compare (the select), 6544 // which would often largely negate the benefit of folding anyway. 6545 if (I.hasOneUse()) 6546 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6547 Value *A, *B; 6548 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6549 if (SPR.Flavor != SPF_UNKNOWN) 6550 return nullptr; 6551 } 6552 6553 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6554 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6555 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6556 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6557 6558 // Handle fcmp with instruction LHS and constant RHS. 6559 Instruction *LHSI; 6560 Constant *RHSC; 6561 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6562 switch (LHSI->getOpcode()) { 6563 case Instruction::PHI: 6564 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6565 // block. If in the same block, we're encouraging jump threading. If 6566 // not, we are just pessimizing the code by making an i1 phi. 6567 if (LHSI->getParent() == I.getParent()) 6568 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6569 return NV; 6570 break; 6571 case Instruction::SIToFP: 6572 case Instruction::UIToFP: 6573 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6574 return NV; 6575 break; 6576 case Instruction::FDiv: 6577 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6578 return NV; 6579 break; 6580 case Instruction::Load: 6581 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6582 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6583 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 6584 !cast<LoadInst>(LHSI)->isVolatile()) 6585 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 6586 return Res; 6587 break; 6588 } 6589 } 6590 6591 if (Instruction *R = foldFabsWithFcmpZero(I, *this)) 6592 return R; 6593 6594 if (match(Op0, m_FNeg(m_Value(X)))) { 6595 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6596 Constant *C; 6597 if (match(Op1, m_Constant(C))) { 6598 Constant *NegC = ConstantExpr::getFNeg(C); 6599 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6600 } 6601 } 6602 6603 if (match(Op0, m_FPExt(m_Value(X)))) { 6604 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6605 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6606 return new FCmpInst(Pred, X, Y, "", &I); 6607 6608 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6609 const APFloat *C; 6610 if (match(Op1, m_APFloat(C))) { 6611 const fltSemantics &FPSem = 6612 X->getType()->getScalarType()->getFltSemantics(); 6613 bool Lossy; 6614 APFloat TruncC = *C; 6615 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6616 6617 // Avoid lossy conversions and denormals. 6618 // Zero is a special case that's OK to convert. 6619 APFloat Fabs = TruncC; 6620 Fabs.clearSign(); 6621 if (!Lossy && 6622 (!(Fabs < APFloat::getSmallestNormalized(FPSem)) || Fabs.isZero())) { 6623 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6624 return new FCmpInst(Pred, X, NewC, "", &I); 6625 } 6626 } 6627 } 6628 6629 // Convert a sign-bit test of an FP value into a cast and integer compare. 6630 // TODO: Simplify if the copysign constant is 0.0 or NaN. 6631 // TODO: Handle non-zero compare constants. 6632 // TODO: Handle other predicates. 6633 const APFloat *C; 6634 if (match(Op0, m_OneUse(m_Intrinsic<Intrinsic::copysign>(m_APFloat(C), 6635 m_Value(X)))) && 6636 match(Op1, m_AnyZeroFP()) && !C->isZero() && !C->isNaN()) { 6637 Type *IntType = Builder.getIntNTy(X->getType()->getScalarSizeInBits()); 6638 if (auto *VecTy = dyn_cast<VectorType>(OpType)) 6639 IntType = VectorType::get(IntType, VecTy->getElementCount()); 6640 6641 // copysign(non-zero constant, X) < 0.0 --> (bitcast X) < 0 6642 if (Pred == FCmpInst::FCMP_OLT) { 6643 Value *IntX = Builder.CreateBitCast(X, IntType); 6644 return new ICmpInst(ICmpInst::ICMP_SLT, IntX, 6645 ConstantInt::getNullValue(IntType)); 6646 } 6647 } 6648 6649 if (I.getType()->isVectorTy()) 6650 if (Instruction *Res = foldVectorCmp(I, Builder)) 6651 return Res; 6652 6653 return Changed ? &I : nullptr; 6654 } 6655