1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/ConstantFolding.h" 18 #include "llvm/Analysis/InstructionSimplify.h" 19 #include "llvm/Analysis/TargetLibraryInfo.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/Debug.h" 26 #include "llvm/Support/KnownBits.h" 27 28 using namespace llvm; 29 using namespace PatternMatch; 30 31 #define DEBUG_TYPE "instcombine" 32 33 // How many times is a select replaced by one of its operands? 34 STATISTIC(NumSel, "Number of select opts"); 35 36 37 /// Compute Result = In1+In2, returning true if the result overflowed for this 38 /// type. 39 static bool addWithOverflow(APInt &Result, const APInt &In1, 40 const APInt &In2, bool IsSigned = false) { 41 bool Overflow; 42 if (IsSigned) 43 Result = In1.sadd_ov(In2, Overflow); 44 else 45 Result = In1.uadd_ov(In2, Overflow); 46 47 return Overflow; 48 } 49 50 /// Compute Result = In1-In2, returning true if the result overflowed for this 51 /// type. 52 static bool subWithOverflow(APInt &Result, const APInt &In1, 53 const APInt &In2, bool IsSigned = false) { 54 bool Overflow; 55 if (IsSigned) 56 Result = In1.ssub_ov(In2, Overflow); 57 else 58 Result = In1.usub_ov(In2, Overflow); 59 60 return Overflow; 61 } 62 63 /// Given an icmp instruction, return true if any use of this comparison is a 64 /// branch on sign bit comparison. 65 static bool hasBranchUse(ICmpInst &I) { 66 for (auto *U : I.users()) 67 if (isa<BranchInst>(U)) 68 return true; 69 return false; 70 } 71 72 /// Returns true if the exploded icmp can be expressed as a signed comparison 73 /// to zero and updates the predicate accordingly. 74 /// The signedness of the comparison is preserved. 75 /// TODO: Refactor with decomposeBitTestICmp()? 76 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 77 if (!ICmpInst::isSigned(Pred)) 78 return false; 79 80 if (C.isNullValue()) 81 return ICmpInst::isRelational(Pred); 82 83 if (C.isOneValue()) { 84 if (Pred == ICmpInst::ICMP_SLT) { 85 Pred = ICmpInst::ICMP_SLE; 86 return true; 87 } 88 } else if (C.isAllOnesValue()) { 89 if (Pred == ICmpInst::ICMP_SGT) { 90 Pred = ICmpInst::ICMP_SGE; 91 return true; 92 } 93 } 94 95 return false; 96 } 97 98 /// Given a signed integer type and a set of known zero and one bits, compute 99 /// the maximum and minimum values that could have the specified known zero and 100 /// known one bits, returning them in Min/Max. 101 /// TODO: Move to method on KnownBits struct? 102 static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known, 103 APInt &Min, APInt &Max) { 104 assert(Known.getBitWidth() == Min.getBitWidth() && 105 Known.getBitWidth() == Max.getBitWidth() && 106 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 107 APInt UnknownBits = ~(Known.Zero|Known.One); 108 109 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 110 // bit if it is unknown. 111 Min = Known.One; 112 Max = Known.One|UnknownBits; 113 114 if (UnknownBits.isNegative()) { // Sign bit is unknown 115 Min.setSignBit(); 116 Max.clearSignBit(); 117 } 118 } 119 120 /// Given an unsigned integer type and a set of known zero and one bits, compute 121 /// the maximum and minimum values that could have the specified known zero and 122 /// known one bits, returning them in Min/Max. 123 /// TODO: Move to method on KnownBits struct? 124 static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known, 125 APInt &Min, APInt &Max) { 126 assert(Known.getBitWidth() == Min.getBitWidth() && 127 Known.getBitWidth() == Max.getBitWidth() && 128 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 129 APInt UnknownBits = ~(Known.Zero|Known.One); 130 131 // The minimum value is when the unknown bits are all zeros. 132 Min = Known.One; 133 // The maximum value is when the unknown bits are all ones. 134 Max = Known.One|UnknownBits; 135 } 136 137 /// This is called when we see this pattern: 138 /// cmp pred (load (gep GV, ...)), cmpcst 139 /// where GV is a global variable with a constant initializer. Try to simplify 140 /// this into some simple computation that does not need the load. For example 141 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 142 /// 143 /// If AndCst is non-null, then the loaded value is masked with that constant 144 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 145 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 146 GlobalVariable *GV, 147 CmpInst &ICI, 148 ConstantInt *AndCst) { 149 Constant *Init = GV->getInitializer(); 150 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 151 return nullptr; 152 153 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 154 // Don't blow up on huge arrays. 155 if (ArrayElementCount > MaxArraySizeForCombine) 156 return nullptr; 157 158 // There are many forms of this optimization we can handle, for now, just do 159 // the simple index into a single-dimensional array. 160 // 161 // Require: GEP GV, 0, i {{, constant indices}} 162 if (GEP->getNumOperands() < 3 || 163 !isa<ConstantInt>(GEP->getOperand(1)) || 164 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 165 isa<Constant>(GEP->getOperand(2))) 166 return nullptr; 167 168 // Check that indices after the variable are constants and in-range for the 169 // type they index. Collect the indices. This is typically for arrays of 170 // structs. 171 SmallVector<unsigned, 4> LaterIndices; 172 173 Type *EltTy = Init->getType()->getArrayElementType(); 174 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 175 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 176 if (!Idx) return nullptr; // Variable index. 177 178 uint64_t IdxVal = Idx->getZExtValue(); 179 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 180 181 if (StructType *STy = dyn_cast<StructType>(EltTy)) 182 EltTy = STy->getElementType(IdxVal); 183 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 184 if (IdxVal >= ATy->getNumElements()) return nullptr; 185 EltTy = ATy->getElementType(); 186 } else { 187 return nullptr; // Unknown type. 188 } 189 190 LaterIndices.push_back(IdxVal); 191 } 192 193 enum { Overdefined = -3, Undefined = -2 }; 194 195 // Variables for our state machines. 196 197 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 198 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 199 // and 87 is the second (and last) index. FirstTrueElement is -2 when 200 // undefined, otherwise set to the first true element. SecondTrueElement is 201 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 202 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 203 204 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 205 // form "i != 47 & i != 87". Same state transitions as for true elements. 206 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 207 208 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 209 /// define a state machine that triggers for ranges of values that the index 210 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 211 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 212 /// index in the range (inclusive). We use -2 for undefined here because we 213 /// use relative comparisons and don't want 0-1 to match -1. 214 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 215 216 // MagicBitvector - This is a magic bitvector where we set a bit if the 217 // comparison is true for element 'i'. If there are 64 elements or less in 218 // the array, this will fully represent all the comparison results. 219 uint64_t MagicBitvector = 0; 220 221 // Scan the array and see if one of our patterns matches. 222 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 223 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 224 Constant *Elt = Init->getAggregateElement(i); 225 if (!Elt) return nullptr; 226 227 // If this is indexing an array of structures, get the structure element. 228 if (!LaterIndices.empty()) 229 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 230 231 // If the element is masked, handle it. 232 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 233 234 // Find out if the comparison would be true or false for the i'th element. 235 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 236 CompareRHS, DL, &TLI); 237 // If the result is undef for this element, ignore it. 238 if (isa<UndefValue>(C)) { 239 // Extend range state machines to cover this element in case there is an 240 // undef in the middle of the range. 241 if (TrueRangeEnd == (int)i-1) 242 TrueRangeEnd = i; 243 if (FalseRangeEnd == (int)i-1) 244 FalseRangeEnd = i; 245 continue; 246 } 247 248 // If we can't compute the result for any of the elements, we have to give 249 // up evaluating the entire conditional. 250 if (!isa<ConstantInt>(C)) return nullptr; 251 252 // Otherwise, we know if the comparison is true or false for this element, 253 // update our state machines. 254 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 255 256 // State machine for single/double/range index comparison. 257 if (IsTrueForElt) { 258 // Update the TrueElement state machine. 259 if (FirstTrueElement == Undefined) 260 FirstTrueElement = TrueRangeEnd = i; // First true element. 261 else { 262 // Update double-compare state machine. 263 if (SecondTrueElement == Undefined) 264 SecondTrueElement = i; 265 else 266 SecondTrueElement = Overdefined; 267 268 // Update range state machine. 269 if (TrueRangeEnd == (int)i-1) 270 TrueRangeEnd = i; 271 else 272 TrueRangeEnd = Overdefined; 273 } 274 } else { 275 // Update the FalseElement state machine. 276 if (FirstFalseElement == Undefined) 277 FirstFalseElement = FalseRangeEnd = i; // First false element. 278 else { 279 // Update double-compare state machine. 280 if (SecondFalseElement == Undefined) 281 SecondFalseElement = i; 282 else 283 SecondFalseElement = Overdefined; 284 285 // Update range state machine. 286 if (FalseRangeEnd == (int)i-1) 287 FalseRangeEnd = i; 288 else 289 FalseRangeEnd = Overdefined; 290 } 291 } 292 293 // If this element is in range, update our magic bitvector. 294 if (i < 64 && IsTrueForElt) 295 MagicBitvector |= 1ULL << i; 296 297 // If all of our states become overdefined, bail out early. Since the 298 // predicate is expensive, only check it every 8 elements. This is only 299 // really useful for really huge arrays. 300 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 301 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 302 FalseRangeEnd == Overdefined) 303 return nullptr; 304 } 305 306 // Now that we've scanned the entire array, emit our new comparison(s). We 307 // order the state machines in complexity of the generated code. 308 Value *Idx = GEP->getOperand(2); 309 310 // If the index is larger than the pointer size of the target, truncate the 311 // index down like the GEP would do implicitly. We don't have to do this for 312 // an inbounds GEP because the index can't be out of range. 313 if (!GEP->isInBounds()) { 314 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 315 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 316 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 317 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 318 } 319 320 // If the comparison is only true for one or two elements, emit direct 321 // comparisons. 322 if (SecondTrueElement != Overdefined) { 323 // None true -> false. 324 if (FirstTrueElement == Undefined) 325 return replaceInstUsesWith(ICI, Builder.getFalse()); 326 327 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 328 329 // True for one element -> 'i == 47'. 330 if (SecondTrueElement == Undefined) 331 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 332 333 // True for two elements -> 'i == 47 | i == 72'. 334 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 335 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 336 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 337 return BinaryOperator::CreateOr(C1, C2); 338 } 339 340 // If the comparison is only false for one or two elements, emit direct 341 // comparisons. 342 if (SecondFalseElement != Overdefined) { 343 // None false -> true. 344 if (FirstFalseElement == Undefined) 345 return replaceInstUsesWith(ICI, Builder.getTrue()); 346 347 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 348 349 // False for one element -> 'i != 47'. 350 if (SecondFalseElement == Undefined) 351 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 352 353 // False for two elements -> 'i != 47 & i != 72'. 354 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 355 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 356 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 357 return BinaryOperator::CreateAnd(C1, C2); 358 } 359 360 // If the comparison can be replaced with a range comparison for the elements 361 // where it is true, emit the range check. 362 if (TrueRangeEnd != Overdefined) { 363 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 364 365 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 366 if (FirstTrueElement) { 367 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 368 Idx = Builder.CreateAdd(Idx, Offs); 369 } 370 371 Value *End = ConstantInt::get(Idx->getType(), 372 TrueRangeEnd-FirstTrueElement+1); 373 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 374 } 375 376 // False range check. 377 if (FalseRangeEnd != Overdefined) { 378 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 379 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 380 if (FirstFalseElement) { 381 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 382 Idx = Builder.CreateAdd(Idx, Offs); 383 } 384 385 Value *End = ConstantInt::get(Idx->getType(), 386 FalseRangeEnd-FirstFalseElement); 387 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 388 } 389 390 // If a magic bitvector captures the entire comparison state 391 // of this load, replace it with computation that does: 392 // ((magic_cst >> i) & 1) != 0 393 { 394 Type *Ty = nullptr; 395 396 // Look for an appropriate type: 397 // - The type of Idx if the magic fits 398 // - The smallest fitting legal type 399 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 400 Ty = Idx->getType(); 401 else 402 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 403 404 if (Ty) { 405 Value *V = Builder.CreateIntCast(Idx, Ty, false); 406 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 407 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 408 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 409 } 410 } 411 412 return nullptr; 413 } 414 415 /// Return a value that can be used to compare the *offset* implied by a GEP to 416 /// zero. For example, if we have &A[i], we want to return 'i' for 417 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 418 /// are involved. The above expression would also be legal to codegen as 419 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 420 /// This latter form is less amenable to optimization though, and we are allowed 421 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 422 /// 423 /// If we can't emit an optimized form for this expression, this returns null. 424 /// 425 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 426 const DataLayout &DL) { 427 gep_type_iterator GTI = gep_type_begin(GEP); 428 429 // Check to see if this gep only has a single variable index. If so, and if 430 // any constant indices are a multiple of its scale, then we can compute this 431 // in terms of the scale of the variable index. For example, if the GEP 432 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 433 // because the expression will cross zero at the same point. 434 unsigned i, e = GEP->getNumOperands(); 435 int64_t Offset = 0; 436 for (i = 1; i != e; ++i, ++GTI) { 437 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 438 // Compute the aggregate offset of constant indices. 439 if (CI->isZero()) continue; 440 441 // Handle a struct index, which adds its field offset to the pointer. 442 if (StructType *STy = GTI.getStructTypeOrNull()) { 443 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 444 } else { 445 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 446 Offset += Size*CI->getSExtValue(); 447 } 448 } else { 449 // Found our variable index. 450 break; 451 } 452 } 453 454 // If there are no variable indices, we must have a constant offset, just 455 // evaluate it the general way. 456 if (i == e) return nullptr; 457 458 Value *VariableIdx = GEP->getOperand(i); 459 // Determine the scale factor of the variable element. For example, this is 460 // 4 if the variable index is into an array of i32. 461 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 462 463 // Verify that there are no other variable indices. If so, emit the hard way. 464 for (++i, ++GTI; i != e; ++i, ++GTI) { 465 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 466 if (!CI) return nullptr; 467 468 // Compute the aggregate offset of constant indices. 469 if (CI->isZero()) continue; 470 471 // Handle a struct index, which adds its field offset to the pointer. 472 if (StructType *STy = GTI.getStructTypeOrNull()) { 473 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 474 } else { 475 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 476 Offset += Size*CI->getSExtValue(); 477 } 478 } 479 480 // Okay, we know we have a single variable index, which must be a 481 // pointer/array/vector index. If there is no offset, life is simple, return 482 // the index. 483 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 484 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 485 if (Offset == 0) { 486 // Cast to intptrty in case a truncation occurs. If an extension is needed, 487 // we don't need to bother extending: the extension won't affect where the 488 // computation crosses zero. 489 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 490 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 491 } 492 return VariableIdx; 493 } 494 495 // Otherwise, there is an index. The computation we will do will be modulo 496 // the pointer size. 497 Offset = SignExtend64(Offset, IntPtrWidth); 498 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 499 500 // To do this transformation, any constant index must be a multiple of the 501 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 502 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 503 // multiple of the variable scale. 504 int64_t NewOffs = Offset / (int64_t)VariableScale; 505 if (Offset != NewOffs*(int64_t)VariableScale) 506 return nullptr; 507 508 // Okay, we can do this evaluation. Start by converting the index to intptr. 509 if (VariableIdx->getType() != IntPtrTy) 510 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 511 true /*Signed*/); 512 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 513 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 514 } 515 516 /// Returns true if we can rewrite Start as a GEP with pointer Base 517 /// and some integer offset. The nodes that need to be re-written 518 /// for this transformation will be added to Explored. 519 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 520 const DataLayout &DL, 521 SetVector<Value *> &Explored) { 522 SmallVector<Value *, 16> WorkList(1, Start); 523 Explored.insert(Base); 524 525 // The following traversal gives us an order which can be used 526 // when doing the final transformation. Since in the final 527 // transformation we create the PHI replacement instructions first, 528 // we don't have to get them in any particular order. 529 // 530 // However, for other instructions we will have to traverse the 531 // operands of an instruction first, which means that we have to 532 // do a post-order traversal. 533 while (!WorkList.empty()) { 534 SetVector<PHINode *> PHIs; 535 536 while (!WorkList.empty()) { 537 if (Explored.size() >= 100) 538 return false; 539 540 Value *V = WorkList.back(); 541 542 if (Explored.count(V) != 0) { 543 WorkList.pop_back(); 544 continue; 545 } 546 547 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 548 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 549 // We've found some value that we can't explore which is different from 550 // the base. Therefore we can't do this transformation. 551 return false; 552 553 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 554 auto *CI = dyn_cast<CastInst>(V); 555 if (!CI->isNoopCast(DL)) 556 return false; 557 558 if (Explored.count(CI->getOperand(0)) == 0) 559 WorkList.push_back(CI->getOperand(0)); 560 } 561 562 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 563 // We're limiting the GEP to having one index. This will preserve 564 // the original pointer type. We could handle more cases in the 565 // future. 566 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 567 GEP->getType() != Start->getType()) 568 return false; 569 570 if (Explored.count(GEP->getOperand(0)) == 0) 571 WorkList.push_back(GEP->getOperand(0)); 572 } 573 574 if (WorkList.back() == V) { 575 WorkList.pop_back(); 576 // We've finished visiting this node, mark it as such. 577 Explored.insert(V); 578 } 579 580 if (auto *PN = dyn_cast<PHINode>(V)) { 581 // We cannot transform PHIs on unsplittable basic blocks. 582 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 583 return false; 584 Explored.insert(PN); 585 PHIs.insert(PN); 586 } 587 } 588 589 // Explore the PHI nodes further. 590 for (auto *PN : PHIs) 591 for (Value *Op : PN->incoming_values()) 592 if (Explored.count(Op) == 0) 593 WorkList.push_back(Op); 594 } 595 596 // Make sure that we can do this. Since we can't insert GEPs in a basic 597 // block before a PHI node, we can't easily do this transformation if 598 // we have PHI node users of transformed instructions. 599 for (Value *Val : Explored) { 600 for (Value *Use : Val->uses()) { 601 602 auto *PHI = dyn_cast<PHINode>(Use); 603 auto *Inst = dyn_cast<Instruction>(Val); 604 605 if (Inst == Base || Inst == PHI || !Inst || !PHI || 606 Explored.count(PHI) == 0) 607 continue; 608 609 if (PHI->getParent() == Inst->getParent()) 610 return false; 611 } 612 } 613 return true; 614 } 615 616 // Sets the appropriate insert point on Builder where we can add 617 // a replacement Instruction for V (if that is possible). 618 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 619 bool Before = true) { 620 if (auto *PHI = dyn_cast<PHINode>(V)) { 621 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 622 return; 623 } 624 if (auto *I = dyn_cast<Instruction>(V)) { 625 if (!Before) 626 I = &*std::next(I->getIterator()); 627 Builder.SetInsertPoint(I); 628 return; 629 } 630 if (auto *A = dyn_cast<Argument>(V)) { 631 // Set the insertion point in the entry block. 632 BasicBlock &Entry = A->getParent()->getEntryBlock(); 633 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 634 return; 635 } 636 // Otherwise, this is a constant and we don't need to set a new 637 // insertion point. 638 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 639 } 640 641 /// Returns a re-written value of Start as an indexed GEP using Base as a 642 /// pointer. 643 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 644 const DataLayout &DL, 645 SetVector<Value *> &Explored) { 646 // Perform all the substitutions. This is a bit tricky because we can 647 // have cycles in our use-def chains. 648 // 1. Create the PHI nodes without any incoming values. 649 // 2. Create all the other values. 650 // 3. Add the edges for the PHI nodes. 651 // 4. Emit GEPs to get the original pointers. 652 // 5. Remove the original instructions. 653 Type *IndexType = IntegerType::get( 654 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 655 656 DenseMap<Value *, Value *> NewInsts; 657 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 658 659 // Create the new PHI nodes, without adding any incoming values. 660 for (Value *Val : Explored) { 661 if (Val == Base) 662 continue; 663 // Create empty phi nodes. This avoids cyclic dependencies when creating 664 // the remaining instructions. 665 if (auto *PHI = dyn_cast<PHINode>(Val)) 666 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 667 PHI->getName() + ".idx", PHI); 668 } 669 IRBuilder<> Builder(Base->getContext()); 670 671 // Create all the other instructions. 672 for (Value *Val : Explored) { 673 674 if (NewInsts.find(Val) != NewInsts.end()) 675 continue; 676 677 if (auto *CI = dyn_cast<CastInst>(Val)) { 678 // Don't get rid of the intermediate variable here; the store can grow 679 // the map which will invalidate the reference to the input value. 680 Value *V = NewInsts[CI->getOperand(0)]; 681 NewInsts[CI] = V; 682 continue; 683 } 684 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 685 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 686 : GEP->getOperand(1); 687 setInsertionPoint(Builder, GEP); 688 // Indices might need to be sign extended. GEPs will magically do 689 // this, but we need to do it ourselves here. 690 if (Index->getType()->getScalarSizeInBits() != 691 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 692 Index = Builder.CreateSExtOrTrunc( 693 Index, NewInsts[GEP->getOperand(0)]->getType(), 694 GEP->getOperand(0)->getName() + ".sext"); 695 } 696 697 auto *Op = NewInsts[GEP->getOperand(0)]; 698 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 699 NewInsts[GEP] = Index; 700 else 701 NewInsts[GEP] = Builder.CreateNSWAdd( 702 Op, Index, GEP->getOperand(0)->getName() + ".add"); 703 continue; 704 } 705 if (isa<PHINode>(Val)) 706 continue; 707 708 llvm_unreachable("Unexpected instruction type"); 709 } 710 711 // Add the incoming values to the PHI nodes. 712 for (Value *Val : Explored) { 713 if (Val == Base) 714 continue; 715 // All the instructions have been created, we can now add edges to the 716 // phi nodes. 717 if (auto *PHI = dyn_cast<PHINode>(Val)) { 718 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 719 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 720 Value *NewIncoming = PHI->getIncomingValue(I); 721 722 if (NewInsts.find(NewIncoming) != NewInsts.end()) 723 NewIncoming = NewInsts[NewIncoming]; 724 725 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 726 } 727 } 728 } 729 730 for (Value *Val : Explored) { 731 if (Val == Base) 732 continue; 733 734 // Depending on the type, for external users we have to emit 735 // a GEP or a GEP + ptrtoint. 736 setInsertionPoint(Builder, Val, false); 737 738 // If required, create an inttoptr instruction for Base. 739 Value *NewBase = Base; 740 if (!Base->getType()->isPointerTy()) 741 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 742 Start->getName() + "to.ptr"); 743 744 Value *GEP = Builder.CreateInBoundsGEP( 745 Start->getType()->getPointerElementType(), NewBase, 746 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 747 748 if (!Val->getType()->isPointerTy()) { 749 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 750 Val->getName() + ".conv"); 751 GEP = Cast; 752 } 753 Val->replaceAllUsesWith(GEP); 754 } 755 756 return NewInsts[Start]; 757 } 758 759 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 760 /// the input Value as a constant indexed GEP. Returns a pair containing 761 /// the GEPs Pointer and Index. 762 static std::pair<Value *, Value *> 763 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 764 Type *IndexType = IntegerType::get(V->getContext(), 765 DL.getIndexTypeSizeInBits(V->getType())); 766 767 Constant *Index = ConstantInt::getNullValue(IndexType); 768 while (true) { 769 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 770 // We accept only inbouds GEPs here to exclude the possibility of 771 // overflow. 772 if (!GEP->isInBounds()) 773 break; 774 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 775 GEP->getType() == V->getType()) { 776 V = GEP->getOperand(0); 777 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 778 Index = ConstantExpr::getAdd( 779 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 780 continue; 781 } 782 break; 783 } 784 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 785 if (!CI->isNoopCast(DL)) 786 break; 787 V = CI->getOperand(0); 788 continue; 789 } 790 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 791 if (!CI->isNoopCast(DL)) 792 break; 793 V = CI->getOperand(0); 794 continue; 795 } 796 break; 797 } 798 return {V, Index}; 799 } 800 801 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 802 /// We can look through PHIs, GEPs and casts in order to determine a common base 803 /// between GEPLHS and RHS. 804 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 805 ICmpInst::Predicate Cond, 806 const DataLayout &DL) { 807 // FIXME: Support vector of pointers. 808 if (GEPLHS->getType()->isVectorTy()) 809 return nullptr; 810 811 if (!GEPLHS->hasAllConstantIndices()) 812 return nullptr; 813 814 // Make sure the pointers have the same type. 815 if (GEPLHS->getType() != RHS->getType()) 816 return nullptr; 817 818 Value *PtrBase, *Index; 819 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 820 821 // The set of nodes that will take part in this transformation. 822 SetVector<Value *> Nodes; 823 824 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 825 return nullptr; 826 827 // We know we can re-write this as 828 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 829 // Since we've only looked through inbouds GEPs we know that we 830 // can't have overflow on either side. We can therefore re-write 831 // this as: 832 // OFFSET1 cmp OFFSET2 833 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 834 835 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 836 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 837 // offset. Since Index is the offset of LHS to the base pointer, we will now 838 // compare the offsets instead of comparing the pointers. 839 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 840 } 841 842 /// Fold comparisons between a GEP instruction and something else. At this point 843 /// we know that the GEP is on the LHS of the comparison. 844 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 845 ICmpInst::Predicate Cond, 846 Instruction &I) { 847 // Don't transform signed compares of GEPs into index compares. Even if the 848 // GEP is inbounds, the final add of the base pointer can have signed overflow 849 // and would change the result of the icmp. 850 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 851 // the maximum signed value for the pointer type. 852 if (ICmpInst::isSigned(Cond)) 853 return nullptr; 854 855 // Look through bitcasts and addrspacecasts. We do not however want to remove 856 // 0 GEPs. 857 if (!isa<GetElementPtrInst>(RHS)) 858 RHS = RHS->stripPointerCasts(); 859 860 Value *PtrBase = GEPLHS->getOperand(0); 861 // FIXME: Support vector pointer GEPs. 862 if (PtrBase == RHS && GEPLHS->isInBounds() && 863 !GEPLHS->getType()->isVectorTy()) { 864 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 865 // This transformation (ignoring the base and scales) is valid because we 866 // know pointers can't overflow since the gep is inbounds. See if we can 867 // output an optimized form. 868 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 869 870 // If not, synthesize the offset the hard way. 871 if (!Offset) 872 Offset = EmitGEPOffset(GEPLHS); 873 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 874 Constant::getNullValue(Offset->getType())); 875 } 876 877 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 878 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 879 !NullPointerIsDefined(I.getFunction(), 880 RHS->getType()->getPointerAddressSpace())) { 881 // For most address spaces, an allocation can't be placed at null, but null 882 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 883 // the only valid inbounds address derived from null, is null itself. 884 // Thus, we have four cases to consider: 885 // 1) Base == nullptr, Offset == 0 -> inbounds, null 886 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 887 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 888 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 889 // 890 // (Note if we're indexing a type of size 0, that simply collapses into one 891 // of the buckets above.) 892 // 893 // In general, we're allowed to make values less poison (i.e. remove 894 // sources of full UB), so in this case, we just select between the two 895 // non-poison cases (1 and 4 above). 896 // 897 // For vectors, we apply the same reasoning on a per-lane basis. 898 auto *Base = GEPLHS->getPointerOperand(); 899 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 900 int NumElts = GEPLHS->getType()->getVectorNumElements(); 901 Base = Builder.CreateVectorSplat(NumElts, Base); 902 } 903 return new ICmpInst(Cond, Base, 904 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 905 cast<Constant>(RHS), Base->getType())); 906 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 907 // If the base pointers are different, but the indices are the same, just 908 // compare the base pointer. 909 if (PtrBase != GEPRHS->getOperand(0)) { 910 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 911 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 912 GEPRHS->getOperand(0)->getType(); 913 if (IndicesTheSame) 914 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 915 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 916 IndicesTheSame = false; 917 break; 918 } 919 920 // If all indices are the same, just compare the base pointers. 921 Type *BaseType = GEPLHS->getOperand(0)->getType(); 922 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 923 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 924 925 // If we're comparing GEPs with two base pointers that only differ in type 926 // and both GEPs have only constant indices or just one use, then fold 927 // the compare with the adjusted indices. 928 // FIXME: Support vector of pointers. 929 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 930 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 931 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 932 PtrBase->stripPointerCasts() == 933 GEPRHS->getOperand(0)->stripPointerCasts() && 934 !GEPLHS->getType()->isVectorTy()) { 935 Value *LOffset = EmitGEPOffset(GEPLHS); 936 Value *ROffset = EmitGEPOffset(GEPRHS); 937 938 // If we looked through an addrspacecast between different sized address 939 // spaces, the LHS and RHS pointers are different sized 940 // integers. Truncate to the smaller one. 941 Type *LHSIndexTy = LOffset->getType(); 942 Type *RHSIndexTy = ROffset->getType(); 943 if (LHSIndexTy != RHSIndexTy) { 944 if (LHSIndexTy->getPrimitiveSizeInBits() < 945 RHSIndexTy->getPrimitiveSizeInBits()) { 946 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 947 } else 948 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 949 } 950 951 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 952 LOffset, ROffset); 953 return replaceInstUsesWith(I, Cmp); 954 } 955 956 // Otherwise, the base pointers are different and the indices are 957 // different. Try convert this to an indexed compare by looking through 958 // PHIs/casts. 959 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 960 } 961 962 // If one of the GEPs has all zero indices, recurse. 963 // FIXME: Handle vector of pointers. 964 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 965 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 966 ICmpInst::getSwappedPredicate(Cond), I); 967 968 // If the other GEP has all zero indices, recurse. 969 // FIXME: Handle vector of pointers. 970 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 971 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 972 973 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 974 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 975 // If the GEPs only differ by one index, compare it. 976 unsigned NumDifferences = 0; // Keep track of # differences. 977 unsigned DiffOperand = 0; // The operand that differs. 978 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 979 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 980 Type *LHSType = GEPLHS->getOperand(i)->getType(); 981 Type *RHSType = GEPRHS->getOperand(i)->getType(); 982 // FIXME: Better support for vector of pointers. 983 if (LHSType->getPrimitiveSizeInBits() != 984 RHSType->getPrimitiveSizeInBits() || 985 (GEPLHS->getType()->isVectorTy() && 986 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 987 // Irreconcilable differences. 988 NumDifferences = 2; 989 break; 990 } 991 992 if (NumDifferences++) break; 993 DiffOperand = i; 994 } 995 996 if (NumDifferences == 0) // SAME GEP? 997 return replaceInstUsesWith(I, // No comparison is needed here. 998 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 999 1000 else if (NumDifferences == 1 && GEPsInBounds) { 1001 Value *LHSV = GEPLHS->getOperand(DiffOperand); 1002 Value *RHSV = GEPRHS->getOperand(DiffOperand); 1003 // Make sure we do a signed comparison here. 1004 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 1005 } 1006 } 1007 1008 // Only lower this if the icmp is the only user of the GEP or if we expect 1009 // the result to fold to a constant! 1010 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 1011 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 1012 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 1013 Value *L = EmitGEPOffset(GEPLHS); 1014 Value *R = EmitGEPOffset(GEPRHS); 1015 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1016 } 1017 } 1018 1019 // Try convert this to an indexed compare by looking through PHIs/casts as a 1020 // last resort. 1021 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1022 } 1023 1024 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1025 const AllocaInst *Alloca, 1026 const Value *Other) { 1027 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1028 1029 // It would be tempting to fold away comparisons between allocas and any 1030 // pointer not based on that alloca (e.g. an argument). However, even 1031 // though such pointers cannot alias, they can still compare equal. 1032 // 1033 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1034 // doesn't escape we can argue that it's impossible to guess its value, and we 1035 // can therefore act as if any such guesses are wrong. 1036 // 1037 // The code below checks that the alloca doesn't escape, and that it's only 1038 // used in a comparison once (the current instruction). The 1039 // single-comparison-use condition ensures that we're trivially folding all 1040 // comparisons against the alloca consistently, and avoids the risk of 1041 // erroneously folding a comparison of the pointer with itself. 1042 1043 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1044 1045 SmallVector<const Use *, 32> Worklist; 1046 for (const Use &U : Alloca->uses()) { 1047 if (Worklist.size() >= MaxIter) 1048 return nullptr; 1049 Worklist.push_back(&U); 1050 } 1051 1052 unsigned NumCmps = 0; 1053 while (!Worklist.empty()) { 1054 assert(Worklist.size() <= MaxIter); 1055 const Use *U = Worklist.pop_back_val(); 1056 const Value *V = U->getUser(); 1057 --MaxIter; 1058 1059 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1060 isa<SelectInst>(V)) { 1061 // Track the uses. 1062 } else if (isa<LoadInst>(V)) { 1063 // Loading from the pointer doesn't escape it. 1064 continue; 1065 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1066 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1067 if (SI->getValueOperand() == U->get()) 1068 return nullptr; 1069 continue; 1070 } else if (isa<ICmpInst>(V)) { 1071 if (NumCmps++) 1072 return nullptr; // Found more than one cmp. 1073 continue; 1074 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1075 switch (Intrin->getIntrinsicID()) { 1076 // These intrinsics don't escape or compare the pointer. Memset is safe 1077 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1078 // we don't allow stores, so src cannot point to V. 1079 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1080 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1081 continue; 1082 default: 1083 return nullptr; 1084 } 1085 } else { 1086 return nullptr; 1087 } 1088 for (const Use &U : V->uses()) { 1089 if (Worklist.size() >= MaxIter) 1090 return nullptr; 1091 Worklist.push_back(&U); 1092 } 1093 } 1094 1095 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1096 return replaceInstUsesWith( 1097 ICI, 1098 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1099 } 1100 1101 /// Fold "icmp pred (X+C), X". 1102 Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C, 1103 ICmpInst::Predicate Pred) { 1104 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1105 // so the values can never be equal. Similarly for all other "or equals" 1106 // operators. 1107 assert(!!C && "C should not be zero!"); 1108 1109 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1110 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1111 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1112 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1113 Constant *R = ConstantInt::get(X->getType(), 1114 APInt::getMaxValue(C.getBitWidth()) - C); 1115 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1116 } 1117 1118 // (X+1) >u X --> X <u (0-1) --> X != 255 1119 // (X+2) >u X --> X <u (0-2) --> X <u 254 1120 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1121 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1122 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1123 ConstantInt::get(X->getType(), -C)); 1124 1125 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1126 1127 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1128 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1129 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1130 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1131 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1132 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1133 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1134 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1135 ConstantInt::get(X->getType(), SMax - C)); 1136 1137 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1138 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1139 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1140 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1141 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1142 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1143 1144 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1145 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1146 ConstantInt::get(X->getType(), SMax - (C - 1))); 1147 } 1148 1149 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1150 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1151 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1152 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1153 const APInt &AP1, 1154 const APInt &AP2) { 1155 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1156 1157 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1158 if (I.getPredicate() == I.ICMP_NE) 1159 Pred = CmpInst::getInversePredicate(Pred); 1160 return new ICmpInst(Pred, LHS, RHS); 1161 }; 1162 1163 // Don't bother doing any work for cases which InstSimplify handles. 1164 if (AP2.isNullValue()) 1165 return nullptr; 1166 1167 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1168 if (IsAShr) { 1169 if (AP2.isAllOnesValue()) 1170 return nullptr; 1171 if (AP2.isNegative() != AP1.isNegative()) 1172 return nullptr; 1173 if (AP2.sgt(AP1)) 1174 return nullptr; 1175 } 1176 1177 if (!AP1) 1178 // 'A' must be large enough to shift out the highest set bit. 1179 return getICmp(I.ICMP_UGT, A, 1180 ConstantInt::get(A->getType(), AP2.logBase2())); 1181 1182 if (AP1 == AP2) 1183 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1184 1185 int Shift; 1186 if (IsAShr && AP1.isNegative()) 1187 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1188 else 1189 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1190 1191 if (Shift > 0) { 1192 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1193 // There are multiple solutions if we are comparing against -1 and the LHS 1194 // of the ashr is not a power of two. 1195 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1196 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1197 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1198 } else if (AP1 == AP2.lshr(Shift)) { 1199 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1200 } 1201 } 1202 1203 // Shifting const2 will never be equal to const1. 1204 // FIXME: This should always be handled by InstSimplify? 1205 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1206 return replaceInstUsesWith(I, TorF); 1207 } 1208 1209 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1210 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1211 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1212 const APInt &AP1, 1213 const APInt &AP2) { 1214 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1215 1216 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1217 if (I.getPredicate() == I.ICMP_NE) 1218 Pred = CmpInst::getInversePredicate(Pred); 1219 return new ICmpInst(Pred, LHS, RHS); 1220 }; 1221 1222 // Don't bother doing any work for cases which InstSimplify handles. 1223 if (AP2.isNullValue()) 1224 return nullptr; 1225 1226 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1227 1228 if (!AP1 && AP2TrailingZeros != 0) 1229 return getICmp( 1230 I.ICMP_UGE, A, 1231 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1232 1233 if (AP1 == AP2) 1234 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1235 1236 // Get the distance between the lowest bits that are set. 1237 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1238 1239 if (Shift > 0 && AP2.shl(Shift) == AP1) 1240 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1241 1242 // Shifting const2 will never be equal to const1. 1243 // FIXME: This should always be handled by InstSimplify? 1244 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1245 return replaceInstUsesWith(I, TorF); 1246 } 1247 1248 /// The caller has matched a pattern of the form: 1249 /// I = icmp ugt (add (add A, B), CI2), CI1 1250 /// If this is of the form: 1251 /// sum = a + b 1252 /// if (sum+128 >u 255) 1253 /// Then replace it with llvm.sadd.with.overflow.i8. 1254 /// 1255 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1256 ConstantInt *CI2, ConstantInt *CI1, 1257 InstCombiner &IC) { 1258 // The transformation we're trying to do here is to transform this into an 1259 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1260 // with a narrower add, and discard the add-with-constant that is part of the 1261 // range check (if we can't eliminate it, this isn't profitable). 1262 1263 // In order to eliminate the add-with-constant, the compare can be its only 1264 // use. 1265 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1266 if (!AddWithCst->hasOneUse()) 1267 return nullptr; 1268 1269 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1270 if (!CI2->getValue().isPowerOf2()) 1271 return nullptr; 1272 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1273 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1274 return nullptr; 1275 1276 // The width of the new add formed is 1 more than the bias. 1277 ++NewWidth; 1278 1279 // Check to see that CI1 is an all-ones value with NewWidth bits. 1280 if (CI1->getBitWidth() == NewWidth || 1281 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1282 return nullptr; 1283 1284 // This is only really a signed overflow check if the inputs have been 1285 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1286 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1287 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1288 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1289 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1290 return nullptr; 1291 1292 // In order to replace the original add with a narrower 1293 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1294 // and truncates that discard the high bits of the add. Verify that this is 1295 // the case. 1296 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1297 for (User *U : OrigAdd->users()) { 1298 if (U == AddWithCst) 1299 continue; 1300 1301 // Only accept truncates for now. We would really like a nice recursive 1302 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1303 // chain to see which bits of a value are actually demanded. If the 1304 // original add had another add which was then immediately truncated, we 1305 // could still do the transformation. 1306 TruncInst *TI = dyn_cast<TruncInst>(U); 1307 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1308 return nullptr; 1309 } 1310 1311 // If the pattern matches, truncate the inputs to the narrower type and 1312 // use the sadd_with_overflow intrinsic to efficiently compute both the 1313 // result and the overflow bit. 1314 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1315 Function *F = Intrinsic::getDeclaration( 1316 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1317 1318 InstCombiner::BuilderTy &Builder = IC.Builder; 1319 1320 // Put the new code above the original add, in case there are any uses of the 1321 // add between the add and the compare. 1322 Builder.SetInsertPoint(OrigAdd); 1323 1324 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1325 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1326 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1327 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1328 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1329 1330 // The inner add was the result of the narrow add, zero extended to the 1331 // wider type. Replace it with the result computed by the intrinsic. 1332 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1333 1334 // The original icmp gets replaced with the overflow value. 1335 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1336 } 1337 1338 /// If we have: 1339 /// icmp eq/ne (urem/srem %x, %y), 0 1340 /// iff %y is a power-of-two, we can replace this with a bit test: 1341 /// icmp eq/ne (and %x, (add %y, -1)), 0 1342 Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1343 // This fold is only valid for equality predicates. 1344 if (!I.isEquality()) 1345 return nullptr; 1346 ICmpInst::Predicate Pred; 1347 Value *X, *Y, *Zero; 1348 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1349 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1350 return nullptr; 1351 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1352 return nullptr; 1353 // This may increase instruction count, we don't enforce that Y is a constant. 1354 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1355 Value *Masked = Builder.CreateAnd(X, Mask); 1356 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1357 } 1358 1359 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1360 /// by one-less-than-bitwidth into a sign test on the original value. 1361 Instruction *InstCombiner::foldSignBitTest(ICmpInst &I) { 1362 Instruction *Val; 1363 ICmpInst::Predicate Pred; 1364 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1365 return nullptr; 1366 1367 Value *X; 1368 Type *XTy; 1369 1370 Constant *C; 1371 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1372 XTy = X->getType(); 1373 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1374 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1375 APInt(XBitWidth, XBitWidth - 1)))) 1376 return nullptr; 1377 } else if (isa<BinaryOperator>(Val) && 1378 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1379 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1380 /*AnalyzeForSignBitExtraction=*/true))) { 1381 XTy = X->getType(); 1382 } else 1383 return nullptr; 1384 1385 return ICmpInst::Create(Instruction::ICmp, 1386 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1387 : ICmpInst::ICMP_SLT, 1388 X, ConstantInt::getNullValue(XTy)); 1389 } 1390 1391 // Handle icmp pred X, 0 1392 Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) { 1393 CmpInst::Predicate Pred = Cmp.getPredicate(); 1394 if (!match(Cmp.getOperand(1), m_Zero())) 1395 return nullptr; 1396 1397 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1398 if (Pred == ICmpInst::ICMP_SGT) { 1399 Value *A, *B; 1400 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B); 1401 if (SPR.Flavor == SPF_SMIN) { 1402 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1403 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1404 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1405 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1406 } 1407 } 1408 1409 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1410 return New; 1411 1412 // Given: 1413 // icmp eq/ne (urem %x, %y), 0 1414 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1415 // icmp eq/ne %x, 0 1416 Value *X, *Y; 1417 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1418 ICmpInst::isEquality(Pred)) { 1419 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1420 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1421 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1422 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1423 } 1424 1425 return nullptr; 1426 } 1427 1428 /// Fold icmp Pred X, C. 1429 /// TODO: This code structure does not make sense. The saturating add fold 1430 /// should be moved to some other helper and extended as noted below (it is also 1431 /// possible that code has been made unnecessary - do we canonicalize IR to 1432 /// overflow/saturating intrinsics or not?). 1433 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1434 // Match the following pattern, which is a common idiom when writing 1435 // overflow-safe integer arithmetic functions. The source performs an addition 1436 // in wider type and explicitly checks for overflow using comparisons against 1437 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1438 // 1439 // TODO: This could probably be generalized to handle other overflow-safe 1440 // operations if we worked out the formulas to compute the appropriate magic 1441 // constants. 1442 // 1443 // sum = a + b 1444 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1445 CmpInst::Predicate Pred = Cmp.getPredicate(); 1446 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1447 Value *A, *B; 1448 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1449 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1450 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1451 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1452 return Res; 1453 1454 return nullptr; 1455 } 1456 1457 /// Canonicalize icmp instructions based on dominating conditions. 1458 Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1459 // This is a cheap/incomplete check for dominance - just match a single 1460 // predecessor with a conditional branch. 1461 BasicBlock *CmpBB = Cmp.getParent(); 1462 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1463 if (!DomBB) 1464 return nullptr; 1465 1466 Value *DomCond; 1467 BasicBlock *TrueBB, *FalseBB; 1468 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1469 return nullptr; 1470 1471 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1472 "Predecessor block does not point to successor?"); 1473 1474 // The branch should get simplified. Don't bother simplifying this condition. 1475 if (TrueBB == FalseBB) 1476 return nullptr; 1477 1478 // Try to simplify this compare to T/F based on the dominating condition. 1479 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1480 if (Imp) 1481 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1482 1483 CmpInst::Predicate Pred = Cmp.getPredicate(); 1484 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1485 ICmpInst::Predicate DomPred; 1486 const APInt *C, *DomC; 1487 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1488 match(Y, m_APInt(C))) { 1489 // We have 2 compares of a variable with constants. Calculate the constant 1490 // ranges of those compares to see if we can transform the 2nd compare: 1491 // DomBB: 1492 // DomCond = icmp DomPred X, DomC 1493 // br DomCond, CmpBB, FalseBB 1494 // CmpBB: 1495 // Cmp = icmp Pred X, C 1496 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C); 1497 ConstantRange DominatingCR = 1498 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1499 : ConstantRange::makeExactICmpRegion( 1500 CmpInst::getInversePredicate(DomPred), *DomC); 1501 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1502 ConstantRange Difference = DominatingCR.difference(CR); 1503 if (Intersection.isEmptySet()) 1504 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1505 if (Difference.isEmptySet()) 1506 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1507 1508 // Canonicalizing a sign bit comparison that gets used in a branch, 1509 // pessimizes codegen by generating branch on zero instruction instead 1510 // of a test and branch. So we avoid canonicalizing in such situations 1511 // because test and branch instruction has better branch displacement 1512 // than compare and branch instruction. 1513 bool UnusedBit; 1514 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1515 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1516 return nullptr; 1517 1518 if (const APInt *EqC = Intersection.getSingleElement()) 1519 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1520 if (const APInt *NeC = Difference.getSingleElement()) 1521 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1522 } 1523 1524 return nullptr; 1525 } 1526 1527 /// Fold icmp (trunc X, Y), C. 1528 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1529 TruncInst *Trunc, 1530 const APInt &C) { 1531 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1532 Value *X = Trunc->getOperand(0); 1533 if (C.isOneValue() && C.getBitWidth() > 1) { 1534 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1535 Value *V = nullptr; 1536 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1537 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1538 ConstantInt::get(V->getType(), 1)); 1539 } 1540 1541 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1542 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1543 // of the high bits truncated out of x are known. 1544 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1545 SrcBits = X->getType()->getScalarSizeInBits(); 1546 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1547 1548 // If all the high bits are known, we can do this xform. 1549 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1550 // Pull in the high bits from known-ones set. 1551 APInt NewRHS = C.zext(SrcBits); 1552 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1553 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1554 } 1555 } 1556 1557 return nullptr; 1558 } 1559 1560 /// Fold icmp (xor X, Y), C. 1561 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1562 BinaryOperator *Xor, 1563 const APInt &C) { 1564 Value *X = Xor->getOperand(0); 1565 Value *Y = Xor->getOperand(1); 1566 const APInt *XorC; 1567 if (!match(Y, m_APInt(XorC))) 1568 return nullptr; 1569 1570 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1571 // fold the xor. 1572 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1573 bool TrueIfSigned = false; 1574 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1575 1576 // If the sign bit of the XorCst is not set, there is no change to 1577 // the operation, just stop using the Xor. 1578 if (!XorC->isNegative()) 1579 return replaceOperand(Cmp, 0, X); 1580 1581 // Emit the opposite comparison. 1582 if (TrueIfSigned) 1583 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1584 ConstantInt::getAllOnesValue(X->getType())); 1585 else 1586 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1587 ConstantInt::getNullValue(X->getType())); 1588 } 1589 1590 if (Xor->hasOneUse()) { 1591 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1592 if (!Cmp.isEquality() && XorC->isSignMask()) { 1593 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1594 : Cmp.getSignedPredicate(); 1595 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1596 } 1597 1598 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1599 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1600 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1601 : Cmp.getSignedPredicate(); 1602 Pred = Cmp.getSwappedPredicate(Pred); 1603 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1604 } 1605 } 1606 1607 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1608 if (Pred == ICmpInst::ICMP_UGT) { 1609 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1610 if (*XorC == ~C && (C + 1).isPowerOf2()) 1611 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1612 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1613 if (*XorC == C && (C + 1).isPowerOf2()) 1614 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1615 } 1616 if (Pred == ICmpInst::ICMP_ULT) { 1617 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1618 if (*XorC == -C && C.isPowerOf2()) 1619 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1620 ConstantInt::get(X->getType(), ~C)); 1621 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1622 if (*XorC == C && (-C).isPowerOf2()) 1623 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1624 ConstantInt::get(X->getType(), ~C)); 1625 } 1626 return nullptr; 1627 } 1628 1629 /// Fold icmp (and (sh X, Y), C2), C1. 1630 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1631 const APInt &C1, const APInt &C2) { 1632 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1633 if (!Shift || !Shift->isShift()) 1634 return nullptr; 1635 1636 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1637 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1638 // code produced by the clang front-end, for bitfield access. 1639 // This seemingly simple opportunity to fold away a shift turns out to be 1640 // rather complicated. See PR17827 for details. 1641 unsigned ShiftOpcode = Shift->getOpcode(); 1642 bool IsShl = ShiftOpcode == Instruction::Shl; 1643 const APInt *C3; 1644 if (match(Shift->getOperand(1), m_APInt(C3))) { 1645 APInt NewAndCst, NewCmpCst; 1646 bool AnyCmpCstBitsShiftedOut; 1647 if (ShiftOpcode == Instruction::Shl) { 1648 // For a left shift, we can fold if the comparison is not signed. We can 1649 // also fold a signed comparison if the mask value and comparison value 1650 // are not negative. These constraints may not be obvious, but we can 1651 // prove that they are correct using an SMT solver. 1652 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1653 return nullptr; 1654 1655 NewCmpCst = C1.lshr(*C3); 1656 NewAndCst = C2.lshr(*C3); 1657 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1658 } else if (ShiftOpcode == Instruction::LShr) { 1659 // For a logical right shift, we can fold if the comparison is not signed. 1660 // We can also fold a signed comparison if the shifted mask value and the 1661 // shifted comparison value are not negative. These constraints may not be 1662 // obvious, but we can prove that they are correct using an SMT solver. 1663 NewCmpCst = C1.shl(*C3); 1664 NewAndCst = C2.shl(*C3); 1665 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1666 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1667 return nullptr; 1668 } else { 1669 // For an arithmetic shift right we can do the same, if we ensure 1670 // the And doesn't use any bits being shifted in. Normally these would 1671 // be turned into lshr by SimplifyDemandedBits, but not if there is an 1672 // additional user. 1673 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1674 NewCmpCst = C1.shl(*C3); 1675 NewAndCst = C2.shl(*C3); 1676 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1677 if (NewAndCst.lshr(*C3) != C2) 1678 return nullptr; 1679 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1680 return nullptr; 1681 } 1682 1683 if (AnyCmpCstBitsShiftedOut) { 1684 // If we shifted bits out, the fold is not going to work out. As a 1685 // special case, check to see if this means that the result is always 1686 // true or false now. 1687 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1688 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1689 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1690 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1691 } else { 1692 Value *NewAnd = Builder.CreateAnd( 1693 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1694 return new ICmpInst(Cmp.getPredicate(), 1695 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1696 } 1697 } 1698 1699 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1700 // preferable because it allows the C2 << Y expression to be hoisted out of a 1701 // loop if Y is invariant and X is not. 1702 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() && 1703 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1704 // Compute C2 << Y. 1705 Value *NewShift = 1706 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1707 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1708 1709 // Compute X & (C2 << Y). 1710 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1711 return replaceOperand(Cmp, 0, NewAnd); 1712 } 1713 1714 return nullptr; 1715 } 1716 1717 /// Fold icmp (and X, C2), C1. 1718 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1719 BinaryOperator *And, 1720 const APInt &C1) { 1721 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1722 1723 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1724 // TODO: We canonicalize to the longer form for scalars because we have 1725 // better analysis/folds for icmp, and codegen may be better with icmp. 1726 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() && 1727 match(And->getOperand(1), m_One())) 1728 return new TruncInst(And->getOperand(0), Cmp.getType()); 1729 1730 const APInt *C2; 1731 Value *X; 1732 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1733 return nullptr; 1734 1735 // Don't perform the following transforms if the AND has multiple uses 1736 if (!And->hasOneUse()) 1737 return nullptr; 1738 1739 if (Cmp.isEquality() && C1.isNullValue()) { 1740 // Restrict this fold to single-use 'and' (PR10267). 1741 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1742 if (C2->isSignMask()) { 1743 Constant *Zero = Constant::getNullValue(X->getType()); 1744 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1745 return new ICmpInst(NewPred, X, Zero); 1746 } 1747 1748 // Restrict this fold only for single-use 'and' (PR10267). 1749 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1750 if ((~(*C2) + 1).isPowerOf2()) { 1751 Constant *NegBOC = 1752 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1753 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1754 return new ICmpInst(NewPred, X, NegBOC); 1755 } 1756 } 1757 1758 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1759 // the input width without changing the value produced, eliminate the cast: 1760 // 1761 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1762 // 1763 // We can do this transformation if the constants do not have their sign bits 1764 // set or if it is an equality comparison. Extending a relational comparison 1765 // when we're checking the sign bit would not work. 1766 Value *W; 1767 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1768 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1769 // TODO: Is this a good transform for vectors? Wider types may reduce 1770 // throughput. Should this transform be limited (even for scalars) by using 1771 // shouldChangeType()? 1772 if (!Cmp.getType()->isVectorTy()) { 1773 Type *WideType = W->getType(); 1774 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1775 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1776 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1777 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1778 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1779 } 1780 } 1781 1782 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1783 return I; 1784 1785 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1786 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1787 // 1788 // iff pred isn't signed 1789 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() && 1790 match(And->getOperand(1), m_One())) { 1791 Constant *One = cast<Constant>(And->getOperand(1)); 1792 Value *Or = And->getOperand(0); 1793 Value *A, *B, *LShr; 1794 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1795 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1796 unsigned UsesRemoved = 0; 1797 if (And->hasOneUse()) 1798 ++UsesRemoved; 1799 if (Or->hasOneUse()) 1800 ++UsesRemoved; 1801 if (LShr->hasOneUse()) 1802 ++UsesRemoved; 1803 1804 // Compute A & ((1 << B) | 1) 1805 Value *NewOr = nullptr; 1806 if (auto *C = dyn_cast<Constant>(B)) { 1807 if (UsesRemoved >= 1) 1808 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1809 } else { 1810 if (UsesRemoved >= 3) 1811 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1812 /*HasNUW=*/true), 1813 One, Or->getName()); 1814 } 1815 if (NewOr) { 1816 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1817 return replaceOperand(Cmp, 0, NewAnd); 1818 } 1819 } 1820 } 1821 1822 return nullptr; 1823 } 1824 1825 /// Fold icmp (and X, Y), C. 1826 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1827 BinaryOperator *And, 1828 const APInt &C) { 1829 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1830 return I; 1831 1832 // TODO: These all require that Y is constant too, so refactor with the above. 1833 1834 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1835 Value *X = And->getOperand(0); 1836 Value *Y = And->getOperand(1); 1837 if (auto *LI = dyn_cast<LoadInst>(X)) 1838 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1839 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1840 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1841 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1842 ConstantInt *C2 = cast<ConstantInt>(Y); 1843 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1844 return Res; 1845 } 1846 1847 if (!Cmp.isEquality()) 1848 return nullptr; 1849 1850 // X & -C == -C -> X > u ~C 1851 // X & -C != -C -> X <= u ~C 1852 // iff C is a power of 2 1853 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) { 1854 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1855 : CmpInst::ICMP_ULE; 1856 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1857 } 1858 1859 // (X & C2) == 0 -> (trunc X) >= 0 1860 // (X & C2) != 0 -> (trunc X) < 0 1861 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1862 const APInt *C2; 1863 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) { 1864 int32_t ExactLogBase2 = C2->exactLogBase2(); 1865 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1866 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1867 if (And->getType()->isVectorTy()) 1868 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements()); 1869 Value *Trunc = Builder.CreateTrunc(X, NTy); 1870 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1871 : CmpInst::ICMP_SLT; 1872 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1873 } 1874 } 1875 1876 return nullptr; 1877 } 1878 1879 /// Fold icmp (or X, Y), C. 1880 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1881 const APInt &C) { 1882 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1883 if (C.isOneValue()) { 1884 // icmp slt signum(V) 1 --> icmp slt V, 1 1885 Value *V = nullptr; 1886 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1887 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1888 ConstantInt::get(V->getType(), 1)); 1889 } 1890 1891 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1892 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) { 1893 // X | C == C --> X <=u C 1894 // X | C != C --> X >u C 1895 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1896 if ((C + 1).isPowerOf2()) { 1897 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1898 return new ICmpInst(Pred, OrOp0, OrOp1); 1899 } 1900 // More general: are all bits outside of a mask constant set or not set? 1901 // X | C == C --> (X & ~C) == 0 1902 // X | C != C --> (X & ~C) != 0 1903 if (Or->hasOneUse()) { 1904 Value *A = Builder.CreateAnd(OrOp0, ~C); 1905 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType())); 1906 } 1907 } 1908 1909 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse()) 1910 return nullptr; 1911 1912 Value *P, *Q; 1913 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1914 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1915 // -> and (icmp eq P, null), (icmp eq Q, null). 1916 Value *CmpP = 1917 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1918 Value *CmpQ = 1919 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1920 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1921 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1922 } 1923 1924 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1925 // a shorter form that has more potential to be folded even further. 1926 Value *X1, *X2, *X3, *X4; 1927 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1928 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1929 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1930 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1931 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1932 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1933 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1934 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1935 } 1936 1937 return nullptr; 1938 } 1939 1940 /// Fold icmp (mul X, Y), C. 1941 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1942 BinaryOperator *Mul, 1943 const APInt &C) { 1944 const APInt *MulC; 1945 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1946 return nullptr; 1947 1948 // If this is a test of the sign bit and the multiply is sign-preserving with 1949 // a constant operand, use the multiply LHS operand instead. 1950 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1951 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1952 if (MulC->isNegative()) 1953 Pred = ICmpInst::getSwappedPredicate(Pred); 1954 return new ICmpInst(Pred, Mul->getOperand(0), 1955 Constant::getNullValue(Mul->getType())); 1956 } 1957 1958 return nullptr; 1959 } 1960 1961 /// Fold icmp (shl 1, Y), C. 1962 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1963 const APInt &C) { 1964 Value *Y; 1965 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1966 return nullptr; 1967 1968 Type *ShiftType = Shl->getType(); 1969 unsigned TypeBits = C.getBitWidth(); 1970 bool CIsPowerOf2 = C.isPowerOf2(); 1971 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1972 if (Cmp.isUnsigned()) { 1973 // (1 << Y) pred C -> Y pred Log2(C) 1974 if (!CIsPowerOf2) { 1975 // (1 << Y) < 30 -> Y <= 4 1976 // (1 << Y) <= 30 -> Y <= 4 1977 // (1 << Y) >= 30 -> Y > 4 1978 // (1 << Y) > 30 -> Y > 4 1979 if (Pred == ICmpInst::ICMP_ULT) 1980 Pred = ICmpInst::ICMP_ULE; 1981 else if (Pred == ICmpInst::ICMP_UGE) 1982 Pred = ICmpInst::ICMP_UGT; 1983 } 1984 1985 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1986 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1987 unsigned CLog2 = C.logBase2(); 1988 if (CLog2 == TypeBits - 1) { 1989 if (Pred == ICmpInst::ICMP_UGE) 1990 Pred = ICmpInst::ICMP_EQ; 1991 else if (Pred == ICmpInst::ICMP_ULT) 1992 Pred = ICmpInst::ICMP_NE; 1993 } 1994 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1995 } else if (Cmp.isSigned()) { 1996 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1997 if (C.isAllOnesValue()) { 1998 // (1 << Y) <= -1 -> Y == 31 1999 if (Pred == ICmpInst::ICMP_SLE) 2000 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2001 2002 // (1 << Y) > -1 -> Y != 31 2003 if (Pred == ICmpInst::ICMP_SGT) 2004 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2005 } else if (!C) { 2006 // (1 << Y) < 0 -> Y == 31 2007 // (1 << Y) <= 0 -> Y == 31 2008 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2009 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2010 2011 // (1 << Y) >= 0 -> Y != 31 2012 // (1 << Y) > 0 -> Y != 31 2013 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2014 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2015 } 2016 } else if (Cmp.isEquality() && CIsPowerOf2) { 2017 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2018 } 2019 2020 return nullptr; 2021 } 2022 2023 /// Fold icmp (shl X, Y), C. 2024 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 2025 BinaryOperator *Shl, 2026 const APInt &C) { 2027 const APInt *ShiftVal; 2028 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2029 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2030 2031 const APInt *ShiftAmt; 2032 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2033 return foldICmpShlOne(Cmp, Shl, C); 2034 2035 // Check that the shift amount is in range. If not, don't perform undefined 2036 // shifts. When the shift is visited, it will be simplified. 2037 unsigned TypeBits = C.getBitWidth(); 2038 if (ShiftAmt->uge(TypeBits)) 2039 return nullptr; 2040 2041 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2042 Value *X = Shl->getOperand(0); 2043 Type *ShType = Shl->getType(); 2044 2045 // NSW guarantees that we are only shifting out sign bits from the high bits, 2046 // so we can ASHR the compare constant without needing a mask and eliminate 2047 // the shift. 2048 if (Shl->hasNoSignedWrap()) { 2049 if (Pred == ICmpInst::ICMP_SGT) { 2050 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2051 APInt ShiftedC = C.ashr(*ShiftAmt); 2052 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2053 } 2054 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2055 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2056 APInt ShiftedC = C.ashr(*ShiftAmt); 2057 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2058 } 2059 if (Pred == ICmpInst::ICMP_SLT) { 2060 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2061 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2062 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2063 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2064 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2065 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2066 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2067 } 2068 // If this is a signed comparison to 0 and the shift is sign preserving, 2069 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2070 // do that if we're sure to not continue on in this function. 2071 if (isSignTest(Pred, C)) 2072 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2073 } 2074 2075 // NUW guarantees that we are only shifting out zero bits from the high bits, 2076 // so we can LSHR the compare constant without needing a mask and eliminate 2077 // the shift. 2078 if (Shl->hasNoUnsignedWrap()) { 2079 if (Pred == ICmpInst::ICMP_UGT) { 2080 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2081 APInt ShiftedC = C.lshr(*ShiftAmt); 2082 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2083 } 2084 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2085 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2086 APInt ShiftedC = C.lshr(*ShiftAmt); 2087 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2088 } 2089 if (Pred == ICmpInst::ICMP_ULT) { 2090 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2091 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2092 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2093 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2094 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2095 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2096 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2097 } 2098 } 2099 2100 if (Cmp.isEquality() && Shl->hasOneUse()) { 2101 // Strength-reduce the shift into an 'and'. 2102 Constant *Mask = ConstantInt::get( 2103 ShType, 2104 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2105 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2106 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2107 return new ICmpInst(Pred, And, LShrC); 2108 } 2109 2110 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2111 bool TrueIfSigned = false; 2112 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2113 // (X << 31) <s 0 --> (X & 1) != 0 2114 Constant *Mask = ConstantInt::get( 2115 ShType, 2116 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2117 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2118 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2119 And, Constant::getNullValue(ShType)); 2120 } 2121 2122 // Simplify 'shl' inequality test into 'and' equality test. 2123 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2124 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2125 if ((C + 1).isPowerOf2() && 2126 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2127 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2128 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2129 : ICmpInst::ICMP_NE, 2130 And, Constant::getNullValue(ShType)); 2131 } 2132 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2133 if (C.isPowerOf2() && 2134 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2135 Value *And = 2136 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2137 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2138 : ICmpInst::ICMP_NE, 2139 And, Constant::getNullValue(ShType)); 2140 } 2141 } 2142 2143 // Transform (icmp pred iM (shl iM %v, N), C) 2144 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2145 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2146 // This enables us to get rid of the shift in favor of a trunc that may be 2147 // free on the target. It has the additional benefit of comparing to a 2148 // smaller constant that may be more target-friendly. 2149 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2150 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2151 DL.isLegalInteger(TypeBits - Amt)) { 2152 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2153 if (ShType->isVectorTy()) 2154 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements()); 2155 Constant *NewC = 2156 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2157 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2158 } 2159 2160 return nullptr; 2161 } 2162 2163 /// Fold icmp ({al}shr X, Y), C. 2164 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 2165 BinaryOperator *Shr, 2166 const APInt &C) { 2167 // An exact shr only shifts out zero bits, so: 2168 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2169 Value *X = Shr->getOperand(0); 2170 CmpInst::Predicate Pred = Cmp.getPredicate(); 2171 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && 2172 C.isNullValue()) 2173 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2174 2175 const APInt *ShiftVal; 2176 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2177 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2178 2179 const APInt *ShiftAmt; 2180 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2181 return nullptr; 2182 2183 // Check that the shift amount is in range. If not, don't perform undefined 2184 // shifts. When the shift is visited it will be simplified. 2185 unsigned TypeBits = C.getBitWidth(); 2186 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2187 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2188 return nullptr; 2189 2190 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2191 bool IsExact = Shr->isExact(); 2192 Type *ShrTy = Shr->getType(); 2193 // TODO: If we could guarantee that InstSimplify would handle all of the 2194 // constant-value-based preconditions in the folds below, then we could assert 2195 // those conditions rather than checking them. This is difficult because of 2196 // undef/poison (PR34838). 2197 if (IsAShr) { 2198 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2199 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2200 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2201 APInt ShiftedC = C.shl(ShAmtVal); 2202 if (ShiftedC.ashr(ShAmtVal) == C) 2203 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2204 } 2205 if (Pred == CmpInst::ICMP_SGT) { 2206 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2207 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2208 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2209 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2210 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2211 } 2212 } else { 2213 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2214 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2215 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2216 APInt ShiftedC = C.shl(ShAmtVal); 2217 if (ShiftedC.lshr(ShAmtVal) == C) 2218 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2219 } 2220 if (Pred == CmpInst::ICMP_UGT) { 2221 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2222 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2223 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2224 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2225 } 2226 } 2227 2228 if (!Cmp.isEquality()) 2229 return nullptr; 2230 2231 // Handle equality comparisons of shift-by-constant. 2232 2233 // If the comparison constant changes with the shift, the comparison cannot 2234 // succeed (bits of the comparison constant cannot match the shifted value). 2235 // This should be known by InstSimplify and already be folded to true/false. 2236 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2237 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2238 "Expected icmp+shr simplify did not occur."); 2239 2240 // If the bits shifted out are known zero, compare the unshifted value: 2241 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2242 if (Shr->isExact()) 2243 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2244 2245 if (Shr->hasOneUse()) { 2246 // Canonicalize the shift into an 'and': 2247 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2248 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2249 Constant *Mask = ConstantInt::get(ShrTy, Val); 2250 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2251 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2252 } 2253 2254 return nullptr; 2255 } 2256 2257 Instruction *InstCombiner::foldICmpSRemConstant(ICmpInst &Cmp, 2258 BinaryOperator *SRem, 2259 const APInt &C) { 2260 // Match an 'is positive' or 'is negative' comparison of remainder by a 2261 // constant power-of-2 value: 2262 // (X % pow2C) sgt/slt 0 2263 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2264 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT) 2265 return nullptr; 2266 2267 // TODO: The one-use check is standard because we do not typically want to 2268 // create longer instruction sequences, but this might be a special-case 2269 // because srem is not good for analysis or codegen. 2270 if (!SRem->hasOneUse()) 2271 return nullptr; 2272 2273 const APInt *DivisorC; 2274 if (!C.isNullValue() || !match(SRem->getOperand(1), m_Power2(DivisorC))) 2275 return nullptr; 2276 2277 // Mask off the sign bit and the modulo bits (low-bits). 2278 Type *Ty = SRem->getType(); 2279 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2280 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2281 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2282 2283 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2284 // bit is set. Example: 2285 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2286 if (Pred == ICmpInst::ICMP_SGT) 2287 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2288 2289 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2290 // bit is set. Example: 2291 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2292 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2293 } 2294 2295 /// Fold icmp (udiv X, Y), C. 2296 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2297 BinaryOperator *UDiv, 2298 const APInt &C) { 2299 const APInt *C2; 2300 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2301 return nullptr; 2302 2303 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2304 2305 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2306 Value *Y = UDiv->getOperand(1); 2307 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2308 assert(!C.isMaxValue() && 2309 "icmp ugt X, UINT_MAX should have been simplified already."); 2310 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2311 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2312 } 2313 2314 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2315 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2316 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2317 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2318 ConstantInt::get(Y->getType(), C2->udiv(C))); 2319 } 2320 2321 return nullptr; 2322 } 2323 2324 /// Fold icmp ({su}div X, Y), C. 2325 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2326 BinaryOperator *Div, 2327 const APInt &C) { 2328 // Fold: icmp pred ([us]div X, C2), C -> range test 2329 // Fold this div into the comparison, producing a range check. 2330 // Determine, based on the divide type, what the range is being 2331 // checked. If there is an overflow on the low or high side, remember 2332 // it, otherwise compute the range [low, hi) bounding the new value. 2333 // See: InsertRangeTest above for the kinds of replacements possible. 2334 const APInt *C2; 2335 if (!match(Div->getOperand(1), m_APInt(C2))) 2336 return nullptr; 2337 2338 // FIXME: If the operand types don't match the type of the divide 2339 // then don't attempt this transform. The code below doesn't have the 2340 // logic to deal with a signed divide and an unsigned compare (and 2341 // vice versa). This is because (x /s C2) <s C produces different 2342 // results than (x /s C2) <u C or (x /u C2) <s C or even 2343 // (x /u C2) <u C. Simply casting the operands and result won't 2344 // work. :( The if statement below tests that condition and bails 2345 // if it finds it. 2346 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2347 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2348 return nullptr; 2349 2350 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2351 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2352 // division-by-constant cases should be present, we can not assert that they 2353 // have happened before we reach this icmp instruction. 2354 if (C2->isNullValue() || C2->isOneValue() || 2355 (DivIsSigned && C2->isAllOnesValue())) 2356 return nullptr; 2357 2358 // Compute Prod = C * C2. We are essentially solving an equation of 2359 // form X / C2 = C. We solve for X by multiplying C2 and C. 2360 // By solving for X, we can turn this into a range check instead of computing 2361 // a divide. 2362 APInt Prod = C * *C2; 2363 2364 // Determine if the product overflows by seeing if the product is not equal to 2365 // the divide. Make sure we do the same kind of divide as in the LHS 2366 // instruction that we're folding. 2367 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2368 2369 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2370 2371 // If the division is known to be exact, then there is no remainder from the 2372 // divide, so the covered range size is unit, otherwise it is the divisor. 2373 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2374 2375 // Figure out the interval that is being checked. For example, a comparison 2376 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2377 // Compute this interval based on the constants involved and the signedness of 2378 // the compare/divide. This computes a half-open interval, keeping track of 2379 // whether either value in the interval overflows. After analysis each 2380 // overflow variable is set to 0 if it's corresponding bound variable is valid 2381 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2382 int LoOverflow = 0, HiOverflow = 0; 2383 APInt LoBound, HiBound; 2384 2385 if (!DivIsSigned) { // udiv 2386 // e.g. X/5 op 3 --> [15, 20) 2387 LoBound = Prod; 2388 HiOverflow = LoOverflow = ProdOV; 2389 if (!HiOverflow) { 2390 // If this is not an exact divide, then many values in the range collapse 2391 // to the same result value. 2392 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2393 } 2394 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2395 if (C.isNullValue()) { // (X / pos) op 0 2396 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2397 LoBound = -(RangeSize - 1); 2398 HiBound = RangeSize; 2399 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2400 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2401 HiOverflow = LoOverflow = ProdOV; 2402 if (!HiOverflow) 2403 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2404 } else { // (X / pos) op neg 2405 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2406 HiBound = Prod + 1; 2407 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2408 if (!LoOverflow) { 2409 APInt DivNeg = -RangeSize; 2410 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2411 } 2412 } 2413 } else if (C2->isNegative()) { // Divisor is < 0. 2414 if (Div->isExact()) 2415 RangeSize.negate(); 2416 if (C.isNullValue()) { // (X / neg) op 0 2417 // e.g. X/-5 op 0 --> [-4, 5) 2418 LoBound = RangeSize + 1; 2419 HiBound = -RangeSize; 2420 if (HiBound == *C2) { // -INTMIN = INTMIN 2421 HiOverflow = 1; // [INTMIN+1, overflow) 2422 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2423 } 2424 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2425 // e.g. X/-5 op 3 --> [-19, -14) 2426 HiBound = Prod + 1; 2427 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2428 if (!LoOverflow) 2429 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2430 } else { // (X / neg) op neg 2431 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2432 LoOverflow = HiOverflow = ProdOV; 2433 if (!HiOverflow) 2434 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2435 } 2436 2437 // Dividing by a negative swaps the condition. LT <-> GT 2438 Pred = ICmpInst::getSwappedPredicate(Pred); 2439 } 2440 2441 Value *X = Div->getOperand(0); 2442 switch (Pred) { 2443 default: llvm_unreachable("Unhandled icmp opcode!"); 2444 case ICmpInst::ICMP_EQ: 2445 if (LoOverflow && HiOverflow) 2446 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2447 if (HiOverflow) 2448 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2449 ICmpInst::ICMP_UGE, X, 2450 ConstantInt::get(Div->getType(), LoBound)); 2451 if (LoOverflow) 2452 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2453 ICmpInst::ICMP_ULT, X, 2454 ConstantInt::get(Div->getType(), HiBound)); 2455 return replaceInstUsesWith( 2456 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2457 case ICmpInst::ICMP_NE: 2458 if (LoOverflow && HiOverflow) 2459 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2460 if (HiOverflow) 2461 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2462 ICmpInst::ICMP_ULT, X, 2463 ConstantInt::get(Div->getType(), LoBound)); 2464 if (LoOverflow) 2465 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2466 ICmpInst::ICMP_UGE, X, 2467 ConstantInt::get(Div->getType(), HiBound)); 2468 return replaceInstUsesWith(Cmp, 2469 insertRangeTest(X, LoBound, HiBound, 2470 DivIsSigned, false)); 2471 case ICmpInst::ICMP_ULT: 2472 case ICmpInst::ICMP_SLT: 2473 if (LoOverflow == +1) // Low bound is greater than input range. 2474 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2475 if (LoOverflow == -1) // Low bound is less than input range. 2476 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2477 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2478 case ICmpInst::ICMP_UGT: 2479 case ICmpInst::ICMP_SGT: 2480 if (HiOverflow == +1) // High bound greater than input range. 2481 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2482 if (HiOverflow == -1) // High bound less than input range. 2483 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2484 if (Pred == ICmpInst::ICMP_UGT) 2485 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2486 ConstantInt::get(Div->getType(), HiBound)); 2487 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2488 ConstantInt::get(Div->getType(), HiBound)); 2489 } 2490 2491 return nullptr; 2492 } 2493 2494 /// Fold icmp (sub X, Y), C. 2495 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2496 BinaryOperator *Sub, 2497 const APInt &C) { 2498 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2499 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2500 const APInt *C2; 2501 APInt SubResult; 2502 2503 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0 2504 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality()) 2505 return new ICmpInst(Cmp.getPredicate(), Y, 2506 ConstantInt::get(Y->getType(), 0)); 2507 2508 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2509 if (match(X, m_APInt(C2)) && 2510 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) || 2511 (Cmp.isSigned() && Sub->hasNoSignedWrap())) && 2512 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2513 return new ICmpInst(Cmp.getSwappedPredicate(), Y, 2514 ConstantInt::get(Y->getType(), SubResult)); 2515 2516 // The following transforms are only worth it if the only user of the subtract 2517 // is the icmp. 2518 if (!Sub->hasOneUse()) 2519 return nullptr; 2520 2521 if (Sub->hasNoSignedWrap()) { 2522 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2523 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue()) 2524 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2525 2526 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2527 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue()) 2528 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2529 2530 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2531 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue()) 2532 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2533 2534 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2535 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue()) 2536 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2537 } 2538 2539 if (!match(X, m_APInt(C2))) 2540 return nullptr; 2541 2542 // C2 - Y <u C -> (Y | (C - 1)) == C2 2543 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2544 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2545 (*C2 & (C - 1)) == (C - 1)) 2546 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2547 2548 // C2 - Y >u C -> (Y | C) != C2 2549 // iff C2 & C == C and C + 1 is a power of 2 2550 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2551 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2552 2553 return nullptr; 2554 } 2555 2556 /// Fold icmp (add X, Y), C. 2557 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2558 BinaryOperator *Add, 2559 const APInt &C) { 2560 Value *Y = Add->getOperand(1); 2561 const APInt *C2; 2562 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2563 return nullptr; 2564 2565 // Fold icmp pred (add X, C2), C. 2566 Value *X = Add->getOperand(0); 2567 Type *Ty = Add->getType(); 2568 CmpInst::Predicate Pred = Cmp.getPredicate(); 2569 2570 // If the add does not wrap, we can always adjust the compare by subtracting 2571 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2572 // are canonicalized to SGT/SLT/UGT/ULT. 2573 if ((Add->hasNoSignedWrap() && 2574 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2575 (Add->hasNoUnsignedWrap() && 2576 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2577 bool Overflow; 2578 APInt NewC = 2579 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2580 // If there is overflow, the result must be true or false. 2581 // TODO: Can we assert there is no overflow because InstSimplify always 2582 // handles those cases? 2583 if (!Overflow) 2584 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2585 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2586 } 2587 2588 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2589 const APInt &Upper = CR.getUpper(); 2590 const APInt &Lower = CR.getLower(); 2591 if (Cmp.isSigned()) { 2592 if (Lower.isSignMask()) 2593 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2594 if (Upper.isSignMask()) 2595 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2596 } else { 2597 if (Lower.isMinValue()) 2598 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2599 if (Upper.isMinValue()) 2600 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2601 } 2602 2603 if (!Add->hasOneUse()) 2604 return nullptr; 2605 2606 // X+C <u C2 -> (X & -C2) == C 2607 // iff C & (C2-1) == 0 2608 // C2 is a power of 2 2609 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2610 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2611 ConstantExpr::getNeg(cast<Constant>(Y))); 2612 2613 // X+C >u C2 -> (X & ~C2) != C 2614 // iff C & C2 == 0 2615 // C2+1 is a power of 2 2616 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2617 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2618 ConstantExpr::getNeg(cast<Constant>(Y))); 2619 2620 return nullptr; 2621 } 2622 2623 bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2624 Value *&RHS, ConstantInt *&Less, 2625 ConstantInt *&Equal, 2626 ConstantInt *&Greater) { 2627 // TODO: Generalize this to work with other comparison idioms or ensure 2628 // they get canonicalized into this form. 2629 2630 // select i1 (a == b), 2631 // i32 Equal, 2632 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2633 // where Equal, Less and Greater are placeholders for any three constants. 2634 ICmpInst::Predicate PredA; 2635 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2636 !ICmpInst::isEquality(PredA)) 2637 return false; 2638 Value *EqualVal = SI->getTrueValue(); 2639 Value *UnequalVal = SI->getFalseValue(); 2640 // We still can get non-canonical predicate here, so canonicalize. 2641 if (PredA == ICmpInst::ICMP_NE) 2642 std::swap(EqualVal, UnequalVal); 2643 if (!match(EqualVal, m_ConstantInt(Equal))) 2644 return false; 2645 ICmpInst::Predicate PredB; 2646 Value *LHS2, *RHS2; 2647 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2648 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2649 return false; 2650 // We can get predicate mismatch here, so canonicalize if possible: 2651 // First, ensure that 'LHS' match. 2652 if (LHS2 != LHS) { 2653 // x sgt y <--> y slt x 2654 std::swap(LHS2, RHS2); 2655 PredB = ICmpInst::getSwappedPredicate(PredB); 2656 } 2657 if (LHS2 != LHS) 2658 return false; 2659 // We also need to canonicalize 'RHS'. 2660 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2661 // x sgt C-1 <--> x sge C <--> not(x slt C) 2662 auto FlippedStrictness = 2663 getFlippedStrictnessPredicateAndConstant(PredB, cast<Constant>(RHS2)); 2664 if (!FlippedStrictness) 2665 return false; 2666 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check"); 2667 RHS2 = FlippedStrictness->second; 2668 // And kind-of perform the result swap. 2669 std::swap(Less, Greater); 2670 PredB = ICmpInst::ICMP_SLT; 2671 } 2672 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2673 } 2674 2675 Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp, 2676 SelectInst *Select, 2677 ConstantInt *C) { 2678 2679 assert(C && "Cmp RHS should be a constant int!"); 2680 // If we're testing a constant value against the result of a three way 2681 // comparison, the result can be expressed directly in terms of the 2682 // original values being compared. Note: We could possibly be more 2683 // aggressive here and remove the hasOneUse test. The original select is 2684 // really likely to simplify or sink when we remove a test of the result. 2685 Value *OrigLHS, *OrigRHS; 2686 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2687 if (Cmp.hasOneUse() && 2688 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2689 C3GreaterThan)) { 2690 assert(C1LessThan && C2Equal && C3GreaterThan); 2691 2692 bool TrueWhenLessThan = 2693 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2694 ->isAllOnesValue(); 2695 bool TrueWhenEqual = 2696 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2697 ->isAllOnesValue(); 2698 bool TrueWhenGreaterThan = 2699 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2700 ->isAllOnesValue(); 2701 2702 // This generates the new instruction that will replace the original Cmp 2703 // Instruction. Instead of enumerating the various combinations when 2704 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2705 // false, we rely on chaining of ORs and future passes of InstCombine to 2706 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2707 2708 // When none of the three constants satisfy the predicate for the RHS (C), 2709 // the entire original Cmp can be simplified to a false. 2710 Value *Cond = Builder.getFalse(); 2711 if (TrueWhenLessThan) 2712 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2713 OrigLHS, OrigRHS)); 2714 if (TrueWhenEqual) 2715 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2716 OrigLHS, OrigRHS)); 2717 if (TrueWhenGreaterThan) 2718 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2719 OrigLHS, OrigRHS)); 2720 2721 return replaceInstUsesWith(Cmp, Cond); 2722 } 2723 return nullptr; 2724 } 2725 2726 static Instruction *foldICmpBitCast(ICmpInst &Cmp, 2727 InstCombiner::BuilderTy &Builder) { 2728 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2729 if (!Bitcast) 2730 return nullptr; 2731 2732 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2733 Value *Op1 = Cmp.getOperand(1); 2734 Value *BCSrcOp = Bitcast->getOperand(0); 2735 2736 // Make sure the bitcast doesn't change the number of vector elements. 2737 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2738 Bitcast->getDestTy()->getScalarSizeInBits()) { 2739 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2740 Value *X; 2741 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2742 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2743 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2744 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2745 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2746 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2747 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2748 match(Op1, m_Zero())) 2749 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2750 2751 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2752 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2753 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2754 2755 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2756 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2757 return new ICmpInst(Pred, X, 2758 ConstantInt::getAllOnesValue(X->getType())); 2759 } 2760 2761 // Zero-equality checks are preserved through unsigned floating-point casts: 2762 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2763 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2764 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2765 if (Cmp.isEquality() && match(Op1, m_Zero())) 2766 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2767 } 2768 2769 // Test to see if the operands of the icmp are casted versions of other 2770 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2771 if (Bitcast->getType()->isPointerTy() && 2772 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2773 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2774 // so eliminate it as well. 2775 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2776 Op1 = BC2->getOperand(0); 2777 2778 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2779 return new ICmpInst(Pred, BCSrcOp, Op1); 2780 } 2781 2782 // Folding: icmp <pred> iN X, C 2783 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2784 // and C is a splat of a K-bit pattern 2785 // and SC is a constant vector = <C', C', C', ..., C'> 2786 // Into: 2787 // %E = extractelement <M x iK> %vec, i32 C' 2788 // icmp <pred> iK %E, trunc(C) 2789 const APInt *C; 2790 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2791 !Bitcast->getType()->isIntegerTy() || 2792 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2793 return nullptr; 2794 2795 Value *Vec; 2796 Constant *Mask; 2797 if (match(BCSrcOp, 2798 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) { 2799 // Check whether every element of Mask is the same constant 2800 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) { 2801 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2802 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 2803 if (C->isSplat(EltTy->getBitWidth())) { 2804 // Fold the icmp based on the value of C 2805 // If C is M copies of an iK sized bit pattern, 2806 // then: 2807 // => %E = extractelement <N x iK> %vec, i32 Elem 2808 // icmp <pred> iK %SplatVal, <pattern> 2809 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 2810 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 2811 return new ICmpInst(Pred, Extract, NewC); 2812 } 2813 } 2814 } 2815 return nullptr; 2816 } 2817 2818 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2819 /// where X is some kind of instruction. 2820 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2821 const APInt *C; 2822 if (!match(Cmp.getOperand(1), m_APInt(C))) 2823 return nullptr; 2824 2825 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 2826 switch (BO->getOpcode()) { 2827 case Instruction::Xor: 2828 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 2829 return I; 2830 break; 2831 case Instruction::And: 2832 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 2833 return I; 2834 break; 2835 case Instruction::Or: 2836 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 2837 return I; 2838 break; 2839 case Instruction::Mul: 2840 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 2841 return I; 2842 break; 2843 case Instruction::Shl: 2844 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 2845 return I; 2846 break; 2847 case Instruction::LShr: 2848 case Instruction::AShr: 2849 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 2850 return I; 2851 break; 2852 case Instruction::SRem: 2853 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, *C)) 2854 return I; 2855 break; 2856 case Instruction::UDiv: 2857 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 2858 return I; 2859 LLVM_FALLTHROUGH; 2860 case Instruction::SDiv: 2861 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 2862 return I; 2863 break; 2864 case Instruction::Sub: 2865 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 2866 return I; 2867 break; 2868 case Instruction::Add: 2869 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 2870 return I; 2871 break; 2872 default: 2873 break; 2874 } 2875 // TODO: These folds could be refactored to be part of the above calls. 2876 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 2877 return I; 2878 } 2879 2880 // Match against CmpInst LHS being instructions other than binary operators. 2881 2882 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 2883 // For now, we only support constant integers while folding the 2884 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 2885 // similar to the cases handled by binary ops above. 2886 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 2887 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 2888 return I; 2889 } 2890 2891 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 2892 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 2893 return I; 2894 } 2895 2896 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 2897 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 2898 return I; 2899 2900 return nullptr; 2901 } 2902 2903 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2904 /// icmp eq/ne BO, C. 2905 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2906 BinaryOperator *BO, 2907 const APInt &C) { 2908 // TODO: Some of these folds could work with arbitrary constants, but this 2909 // function is limited to scalar and vector splat constants. 2910 if (!Cmp.isEquality()) 2911 return nullptr; 2912 2913 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2914 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2915 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2916 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2917 2918 switch (BO->getOpcode()) { 2919 case Instruction::SRem: 2920 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2921 if (C.isNullValue() && BO->hasOneUse()) { 2922 const APInt *BOC; 2923 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2924 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 2925 return new ICmpInst(Pred, NewRem, 2926 Constant::getNullValue(BO->getType())); 2927 } 2928 } 2929 break; 2930 case Instruction::Add: { 2931 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2932 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2933 if (BO->hasOneUse()) 2934 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 2935 } else if (C.isNullValue()) { 2936 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2937 // efficiently invertible, or if the add has just this one use. 2938 if (Value *NegVal = dyn_castNegVal(BOp1)) 2939 return new ICmpInst(Pred, BOp0, NegVal); 2940 if (Value *NegVal = dyn_castNegVal(BOp0)) 2941 return new ICmpInst(Pred, NegVal, BOp1); 2942 if (BO->hasOneUse()) { 2943 Value *Neg = Builder.CreateNeg(BOp1); 2944 Neg->takeName(BO); 2945 return new ICmpInst(Pred, BOp0, Neg); 2946 } 2947 } 2948 break; 2949 } 2950 case Instruction::Xor: 2951 if (BO->hasOneUse()) { 2952 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2953 // For the xor case, we can xor two constants together, eliminating 2954 // the explicit xor. 2955 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2956 } else if (C.isNullValue()) { 2957 // Replace ((xor A, B) != 0) with (A != B) 2958 return new ICmpInst(Pred, BOp0, BOp1); 2959 } 2960 } 2961 break; 2962 case Instruction::Sub: 2963 if (BO->hasOneUse()) { 2964 // Only check for constant LHS here, as constant RHS will be canonicalized 2965 // to add and use the fold above. 2966 if (Constant *BOC = dyn_cast<Constant>(BOp0)) { 2967 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2968 return new ICmpInst(Pred, BOp1, ConstantExpr::getSub(BOC, RHS)); 2969 } else if (C.isNullValue()) { 2970 // Replace ((sub A, B) != 0) with (A != B). 2971 return new ICmpInst(Pred, BOp0, BOp1); 2972 } 2973 } 2974 break; 2975 case Instruction::Or: { 2976 const APInt *BOC; 2977 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 2978 // Comparing if all bits outside of a constant mask are set? 2979 // Replace (X | C) == -1 with (X & ~C) == ~C. 2980 // This removes the -1 constant. 2981 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 2982 Value *And = Builder.CreateAnd(BOp0, NotBOC); 2983 return new ICmpInst(Pred, And, NotBOC); 2984 } 2985 break; 2986 } 2987 case Instruction::And: { 2988 const APInt *BOC; 2989 if (match(BOp1, m_APInt(BOC))) { 2990 // If we have ((X & C) == C), turn it into ((X & C) != 0). 2991 if (C == *BOC && C.isPowerOf2()) 2992 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 2993 BO, Constant::getNullValue(RHS->getType())); 2994 } 2995 break; 2996 } 2997 case Instruction::Mul: 2998 if (C.isNullValue() && BO->hasNoSignedWrap()) { 2999 const APInt *BOC; 3000 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) { 3001 // The trivial case (mul X, 0) is handled by InstSimplify. 3002 // General case : (mul X, C) != 0 iff X != 0 3003 // (mul X, C) == 0 iff X == 0 3004 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 3005 } 3006 } 3007 break; 3008 case Instruction::UDiv: 3009 if (C.isNullValue()) { 3010 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3011 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3012 return new ICmpInst(NewPred, BOp1, BOp0); 3013 } 3014 break; 3015 default: 3016 break; 3017 } 3018 return nullptr; 3019 } 3020 3021 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3022 Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp, 3023 IntrinsicInst *II, 3024 const APInt &C) { 3025 Type *Ty = II->getType(); 3026 unsigned BitWidth = C.getBitWidth(); 3027 switch (II->getIntrinsicID()) { 3028 case Intrinsic::bswap: 3029 // bswap(A) == C -> A == bswap(C) 3030 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3031 ConstantInt::get(Ty, C.byteSwap())); 3032 3033 case Intrinsic::ctlz: 3034 case Intrinsic::cttz: { 3035 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3036 if (C == BitWidth) 3037 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3038 ConstantInt::getNullValue(Ty)); 3039 3040 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3041 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3042 // Limit to one use to ensure we don't increase instruction count. 3043 unsigned Num = C.getLimitedValue(BitWidth); 3044 if (Num != BitWidth && II->hasOneUse()) { 3045 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3046 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3047 : APInt::getHighBitsSet(BitWidth, Num + 1); 3048 APInt Mask2 = IsTrailing 3049 ? APInt::getOneBitSet(BitWidth, Num) 3050 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3051 return new ICmpInst(Cmp.getPredicate(), 3052 Builder.CreateAnd(II->getArgOperand(0), Mask1), 3053 ConstantInt::get(Ty, Mask2)); 3054 } 3055 break; 3056 } 3057 3058 case Intrinsic::ctpop: { 3059 // popcount(A) == 0 -> A == 0 and likewise for != 3060 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3061 bool IsZero = C.isNullValue(); 3062 if (IsZero || C == BitWidth) 3063 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3064 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty)); 3065 3066 break; 3067 } 3068 3069 case Intrinsic::uadd_sat: { 3070 // uadd.sat(a, b) == 0 -> (a | b) == 0 3071 if (C.isNullValue()) { 3072 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3073 return new ICmpInst(Cmp.getPredicate(), Or, Constant::getNullValue(Ty)); 3074 } 3075 break; 3076 } 3077 3078 case Intrinsic::usub_sat: { 3079 // usub.sat(a, b) == 0 -> a <= b 3080 if (C.isNullValue()) { 3081 ICmpInst::Predicate NewPred = Cmp.getPredicate() == ICmpInst::ICMP_EQ 3082 ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3083 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3084 } 3085 break; 3086 } 3087 default: 3088 break; 3089 } 3090 3091 return nullptr; 3092 } 3093 3094 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3095 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3096 IntrinsicInst *II, 3097 const APInt &C) { 3098 if (Cmp.isEquality()) 3099 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3100 3101 Type *Ty = II->getType(); 3102 unsigned BitWidth = C.getBitWidth(); 3103 switch (II->getIntrinsicID()) { 3104 case Intrinsic::ctlz: { 3105 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3106 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3107 unsigned Num = C.getLimitedValue(); 3108 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3109 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3110 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3111 } 3112 3113 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3114 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 3115 C.uge(1) && C.ule(BitWidth)) { 3116 unsigned Num = C.getLimitedValue(); 3117 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3118 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3119 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3120 } 3121 break; 3122 } 3123 case Intrinsic::cttz: { 3124 // Limit to one use to ensure we don't increase instruction count. 3125 if (!II->hasOneUse()) 3126 return nullptr; 3127 3128 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3129 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3130 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3131 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3132 Builder.CreateAnd(II->getArgOperand(0), Mask), 3133 ConstantInt::getNullValue(Ty)); 3134 } 3135 3136 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3137 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 3138 C.uge(1) && C.ule(BitWidth)) { 3139 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3140 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3141 Builder.CreateAnd(II->getArgOperand(0), Mask), 3142 ConstantInt::getNullValue(Ty)); 3143 } 3144 break; 3145 } 3146 default: 3147 break; 3148 } 3149 3150 return nullptr; 3151 } 3152 3153 /// Handle icmp with constant (but not simple integer constant) RHS. 3154 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3155 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3156 Constant *RHSC = dyn_cast<Constant>(Op1); 3157 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3158 if (!RHSC || !LHSI) 3159 return nullptr; 3160 3161 switch (LHSI->getOpcode()) { 3162 case Instruction::GetElementPtr: 3163 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3164 if (RHSC->isNullValue() && 3165 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3166 return new ICmpInst( 3167 I.getPredicate(), LHSI->getOperand(0), 3168 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3169 break; 3170 case Instruction::PHI: 3171 // Only fold icmp into the PHI if the phi and icmp are in the same 3172 // block. If in the same block, we're encouraging jump threading. If 3173 // not, we are just pessimizing the code by making an i1 phi. 3174 if (LHSI->getParent() == I.getParent()) 3175 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3176 return NV; 3177 break; 3178 case Instruction::Select: { 3179 // If either operand of the select is a constant, we can fold the 3180 // comparison into the select arms, which will cause one to be 3181 // constant folded and the select turned into a bitwise or. 3182 Value *Op1 = nullptr, *Op2 = nullptr; 3183 ConstantInt *CI = nullptr; 3184 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 3185 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3186 CI = dyn_cast<ConstantInt>(Op1); 3187 } 3188 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 3189 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3190 CI = dyn_cast<ConstantInt>(Op2); 3191 } 3192 3193 // We only want to perform this transformation if it will not lead to 3194 // additional code. This is true if either both sides of the select 3195 // fold to a constant (in which case the icmp is replaced with a select 3196 // which will usually simplify) or this is the only user of the 3197 // select (in which case we are trading a select+icmp for a simpler 3198 // select+icmp) or all uses of the select can be replaced based on 3199 // dominance information ("Global cases"). 3200 bool Transform = false; 3201 if (Op1 && Op2) 3202 Transform = true; 3203 else if (Op1 || Op2) { 3204 // Local case 3205 if (LHSI->hasOneUse()) 3206 Transform = true; 3207 // Global cases 3208 else if (CI && !CI->isZero()) 3209 // When Op1 is constant try replacing select with second operand. 3210 // Otherwise Op2 is constant and try replacing select with first 3211 // operand. 3212 Transform = 3213 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 3214 } 3215 if (Transform) { 3216 if (!Op1) 3217 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 3218 I.getName()); 3219 if (!Op2) 3220 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 3221 I.getName()); 3222 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 3223 } 3224 break; 3225 } 3226 case Instruction::IntToPtr: 3227 // icmp pred inttoptr(X), null -> icmp pred X, 0 3228 if (RHSC->isNullValue() && 3229 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3230 return new ICmpInst( 3231 I.getPredicate(), LHSI->getOperand(0), 3232 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3233 break; 3234 3235 case Instruction::Load: 3236 // Try to optimize things like "A[i] > 4" to index computations. 3237 if (GetElementPtrInst *GEP = 3238 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 3239 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3240 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 3241 !cast<LoadInst>(LHSI)->isVolatile()) 3242 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 3243 return Res; 3244 } 3245 break; 3246 } 3247 3248 return nullptr; 3249 } 3250 3251 /// Some comparisons can be simplified. 3252 /// In this case, we are looking for comparisons that look like 3253 /// a check for a lossy truncation. 3254 /// Folds: 3255 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3256 /// Where Mask is some pattern that produces all-ones in low bits: 3257 /// (-1 >> y) 3258 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3259 /// ~(-1 << y) 3260 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3261 /// The Mask can be a constant, too. 3262 /// For some predicates, the operands are commutative. 3263 /// For others, x can only be on a specific side. 3264 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3265 InstCombiner::BuilderTy &Builder) { 3266 ICmpInst::Predicate SrcPred; 3267 Value *X, *M, *Y; 3268 auto m_VariableMask = m_CombineOr( 3269 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3270 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3271 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3272 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3273 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3274 if (!match(&I, m_c_ICmp(SrcPred, 3275 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3276 m_Deferred(X)))) 3277 return nullptr; 3278 3279 ICmpInst::Predicate DstPred; 3280 switch (SrcPred) { 3281 case ICmpInst::Predicate::ICMP_EQ: 3282 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3283 DstPred = ICmpInst::Predicate::ICMP_ULE; 3284 break; 3285 case ICmpInst::Predicate::ICMP_NE: 3286 // x & (-1 >> y) != x -> x u> (-1 >> y) 3287 DstPred = ICmpInst::Predicate::ICMP_UGT; 3288 break; 3289 case ICmpInst::Predicate::ICMP_ULT: 3290 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3291 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3292 DstPred = ICmpInst::Predicate::ICMP_UGT; 3293 break; 3294 case ICmpInst::Predicate::ICMP_UGE: 3295 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3296 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3297 DstPred = ICmpInst::Predicate::ICMP_ULE; 3298 break; 3299 case ICmpInst::Predicate::ICMP_SLT: 3300 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3301 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3302 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3303 return nullptr; 3304 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3305 return nullptr; 3306 DstPred = ICmpInst::Predicate::ICMP_SGT; 3307 break; 3308 case ICmpInst::Predicate::ICMP_SGE: 3309 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3310 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3311 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3312 return nullptr; 3313 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3314 return nullptr; 3315 DstPred = ICmpInst::Predicate::ICMP_SLE; 3316 break; 3317 case ICmpInst::Predicate::ICMP_SGT: 3318 case ICmpInst::Predicate::ICMP_SLE: 3319 return nullptr; 3320 case ICmpInst::Predicate::ICMP_UGT: 3321 case ICmpInst::Predicate::ICMP_ULE: 3322 llvm_unreachable("Instsimplify took care of commut. variant"); 3323 break; 3324 default: 3325 llvm_unreachable("All possible folds are handled."); 3326 } 3327 3328 // The mask value may be a vector constant that has undefined elements. But it 3329 // may not be safe to propagate those undefs into the new compare, so replace 3330 // those elements by copying an existing, defined, and safe scalar constant. 3331 Type *OpTy = M->getType(); 3332 auto *VecC = dyn_cast<Constant>(M); 3333 if (OpTy->isVectorTy() && VecC && VecC->containsUndefElement()) { 3334 Constant *SafeReplacementConstant = nullptr; 3335 for (unsigned i = 0, e = OpTy->getVectorNumElements(); i != e; ++i) { 3336 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3337 SafeReplacementConstant = VecC->getAggregateElement(i); 3338 break; 3339 } 3340 } 3341 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3342 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3343 } 3344 3345 return Builder.CreateICmp(DstPred, X, M); 3346 } 3347 3348 /// Some comparisons can be simplified. 3349 /// In this case, we are looking for comparisons that look like 3350 /// a check for a lossy signed truncation. 3351 /// Folds: (MaskedBits is a constant.) 3352 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3353 /// Into: 3354 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3355 /// Where KeptBits = bitwidth(%x) - MaskedBits 3356 static Value * 3357 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3358 InstCombiner::BuilderTy &Builder) { 3359 ICmpInst::Predicate SrcPred; 3360 Value *X; 3361 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3362 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3363 if (!match(&I, m_c_ICmp(SrcPred, 3364 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3365 m_APInt(C1))), 3366 m_Deferred(X)))) 3367 return nullptr; 3368 3369 // Potential handling of non-splats: for each element: 3370 // * if both are undef, replace with constant 0. 3371 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3372 // * if both are not undef, and are different, bailout. 3373 // * else, only one is undef, then pick the non-undef one. 3374 3375 // The shift amount must be equal. 3376 if (*C0 != *C1) 3377 return nullptr; 3378 const APInt &MaskedBits = *C0; 3379 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3380 3381 ICmpInst::Predicate DstPred; 3382 switch (SrcPred) { 3383 case ICmpInst::Predicate::ICMP_EQ: 3384 // ((%x << MaskedBits) a>> MaskedBits) == %x 3385 // => 3386 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3387 DstPred = ICmpInst::Predicate::ICMP_ULT; 3388 break; 3389 case ICmpInst::Predicate::ICMP_NE: 3390 // ((%x << MaskedBits) a>> MaskedBits) != %x 3391 // => 3392 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3393 DstPred = ICmpInst::Predicate::ICMP_UGE; 3394 break; 3395 // FIXME: are more folds possible? 3396 default: 3397 return nullptr; 3398 } 3399 3400 auto *XType = X->getType(); 3401 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3402 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3403 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3404 3405 // KeptBits = bitwidth(%x) - MaskedBits 3406 const APInt KeptBits = BitWidth - MaskedBits; 3407 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3408 // ICmpCst = (1 << KeptBits) 3409 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3410 assert(ICmpCst.isPowerOf2()); 3411 // AddCst = (1 << (KeptBits-1)) 3412 const APInt AddCst = ICmpCst.lshr(1); 3413 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3414 3415 // T0 = add %x, AddCst 3416 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3417 // T1 = T0 DstPred ICmpCst 3418 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3419 3420 return T1; 3421 } 3422 3423 // Given pattern: 3424 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3425 // we should move shifts to the same hand of 'and', i.e. rewrite as 3426 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3427 // We are only interested in opposite logical shifts here. 3428 // One of the shifts can be truncated. 3429 // If we can, we want to end up creating 'lshr' shift. 3430 static Value * 3431 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3432 InstCombiner::BuilderTy &Builder) { 3433 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3434 !I.getOperand(0)->hasOneUse()) 3435 return nullptr; 3436 3437 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3438 3439 // Look for an 'and' of two logical shifts, one of which may be truncated. 3440 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3441 Instruction *XShift, *MaybeTruncation, *YShift; 3442 if (!match( 3443 I.getOperand(0), 3444 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3445 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3446 m_AnyLogicalShift, m_Instruction(YShift))), 3447 m_Instruction(MaybeTruncation))))) 3448 return nullptr; 3449 3450 // We potentially looked past 'trunc', but only when matching YShift, 3451 // therefore YShift must have the widest type. 3452 Instruction *WidestShift = YShift; 3453 // Therefore XShift must have the shallowest type. 3454 // Or they both have identical types if there was no truncation. 3455 Instruction *NarrowestShift = XShift; 3456 3457 Type *WidestTy = WidestShift->getType(); 3458 assert(NarrowestShift->getType() == I.getOperand(0)->getType() && 3459 "We did not look past any shifts while matching XShift though."); 3460 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3461 3462 // If YShift is a 'lshr', swap the shifts around. 3463 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3464 std::swap(XShift, YShift); 3465 3466 // The shifts must be in opposite directions. 3467 auto XShiftOpcode = XShift->getOpcode(); 3468 if (XShiftOpcode == YShift->getOpcode()) 3469 return nullptr; // Do not care about same-direction shifts here. 3470 3471 Value *X, *XShAmt, *Y, *YShAmt; 3472 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3473 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3474 3475 // If one of the values being shifted is a constant, then we will end with 3476 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3477 // however, we will need to ensure that we won't increase instruction count. 3478 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3479 // At least one of the hands of the 'and' should be one-use shift. 3480 if (!match(I.getOperand(0), 3481 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3482 return nullptr; 3483 if (HadTrunc) { 3484 // Due to the 'trunc', we will need to widen X. For that either the old 3485 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3486 if (!MaybeTruncation->hasOneUse() && 3487 !NarrowestShift->getOperand(1)->hasOneUse()) 3488 return nullptr; 3489 } 3490 } 3491 3492 // We have two shift amounts from two different shifts. The types of those 3493 // shift amounts may not match. If that's the case let's bailout now. 3494 if (XShAmt->getType() != YShAmt->getType()) 3495 return nullptr; 3496 3497 // Can we fold (XShAmt+YShAmt) ? 3498 auto *NewShAmt = dyn_cast_or_null<Constant>( 3499 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3500 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3501 if (!NewShAmt) 3502 return nullptr; 3503 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3504 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3505 3506 // Is the new shift amount smaller than the bit width? 3507 // FIXME: could also rely on ConstantRange. 3508 if (!match(NewShAmt, 3509 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3510 APInt(WidestBitWidth, WidestBitWidth)))) 3511 return nullptr; 3512 3513 // An extra legality check is needed if we had trunc-of-lshr. 3514 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3515 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3516 WidestShift]() { 3517 // It isn't obvious whether it's worth it to analyze non-constants here. 3518 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3519 // If *any* of these preconditions matches we can perform the fold. 3520 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3521 ? NewShAmt->getSplatValue() 3522 : NewShAmt; 3523 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3524 if (NewShAmtSplat && 3525 (NewShAmtSplat->isNullValue() || 3526 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3527 return true; 3528 // We consider *min* leading zeros so a single outlier 3529 // blocks the transform as opposed to allowing it. 3530 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3531 KnownBits Known = computeKnownBits(C, SQ.DL); 3532 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3533 // If the value being shifted has at most lowest bit set we can fold. 3534 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3535 if (MaxActiveBits <= 1) 3536 return true; 3537 // Precondition: NewShAmt u<= countLeadingZeros(C) 3538 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3539 return true; 3540 } 3541 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3542 KnownBits Known = computeKnownBits(C, SQ.DL); 3543 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3544 // If the value being shifted has at most lowest bit set we can fold. 3545 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3546 if (MaxActiveBits <= 1) 3547 return true; 3548 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3549 if (NewShAmtSplat) { 3550 APInt AdjNewShAmt = 3551 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3552 if (AdjNewShAmt.ule(MinLeadZero)) 3553 return true; 3554 } 3555 } 3556 return false; // Can't tell if it's ok. 3557 }; 3558 if (!CanFold()) 3559 return nullptr; 3560 } 3561 3562 // All good, we can do this fold. 3563 X = Builder.CreateZExt(X, WidestTy); 3564 Y = Builder.CreateZExt(Y, WidestTy); 3565 // The shift is the same that was for X. 3566 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3567 ? Builder.CreateLShr(X, NewShAmt) 3568 : Builder.CreateShl(X, NewShAmt); 3569 Value *T1 = Builder.CreateAnd(T0, Y); 3570 return Builder.CreateICmp(I.getPredicate(), T1, 3571 Constant::getNullValue(WidestTy)); 3572 } 3573 3574 /// Fold 3575 /// (-1 u/ x) u< y 3576 /// ((x * y) u/ x) != y 3577 /// to 3578 /// @llvm.umul.with.overflow(x, y) plus extraction of overflow bit 3579 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3580 /// will mean that we are looking for the opposite answer. 3581 Value *InstCombiner::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) { 3582 ICmpInst::Predicate Pred; 3583 Value *X, *Y; 3584 Instruction *Mul; 3585 bool NeedNegation; 3586 // Look for: (-1 u/ x) u</u>= y 3587 if (!I.isEquality() && 3588 match(&I, m_c_ICmp(Pred, m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3589 m_Value(Y)))) { 3590 Mul = nullptr; 3591 3592 // Are we checking that overflow does not happen, or does happen? 3593 switch (Pred) { 3594 case ICmpInst::Predicate::ICMP_ULT: 3595 NeedNegation = false; 3596 break; // OK 3597 case ICmpInst::Predicate::ICMP_UGE: 3598 NeedNegation = true; 3599 break; // OK 3600 default: 3601 return nullptr; // Wrong predicate. 3602 } 3603 } else // Look for: ((x * y) u/ x) !=/== y 3604 if (I.isEquality() && 3605 match(&I, m_c_ICmp(Pred, m_Value(Y), 3606 m_OneUse(m_UDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3607 m_Value(X)), 3608 m_Instruction(Mul)), 3609 m_Deferred(X)))))) { 3610 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3611 } else 3612 return nullptr; 3613 3614 BuilderTy::InsertPointGuard Guard(Builder); 3615 // If the pattern included (x * y), we'll want to insert new instructions 3616 // right before that original multiplication so that we can replace it. 3617 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3618 if (MulHadOtherUses) 3619 Builder.SetInsertPoint(Mul); 3620 3621 Function *F = Intrinsic::getDeclaration( 3622 I.getModule(), Intrinsic::umul_with_overflow, X->getType()); 3623 CallInst *Call = Builder.CreateCall(F, {X, Y}, "umul"); 3624 3625 // If the multiplication was used elsewhere, to ensure that we don't leave 3626 // "duplicate" instructions, replace uses of that original multiplication 3627 // with the multiplication result from the with.overflow intrinsic. 3628 if (MulHadOtherUses) 3629 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "umul.val")); 3630 3631 Value *Res = Builder.CreateExtractValue(Call, 1, "umul.ov"); 3632 if (NeedNegation) // This technically increases instruction count. 3633 Res = Builder.CreateNot(Res, "umul.not.ov"); 3634 3635 return Res; 3636 } 3637 3638 /// Try to fold icmp (binop), X or icmp X, (binop). 3639 /// TODO: A large part of this logic is duplicated in InstSimplify's 3640 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3641 /// duplication. 3642 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I, const SimplifyQuery &SQ) { 3643 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3644 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3645 3646 // Special logic for binary operators. 3647 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3648 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3649 if (!BO0 && !BO1) 3650 return nullptr; 3651 3652 const CmpInst::Predicate Pred = I.getPredicate(); 3653 Value *X; 3654 3655 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3656 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 3657 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3658 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3659 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3660 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 3661 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3662 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3663 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3664 3665 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 3666 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 3667 NoOp0WrapProblem = 3668 ICmpInst::isEquality(Pred) || 3669 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 3670 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 3671 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 3672 NoOp1WrapProblem = 3673 ICmpInst::isEquality(Pred) || 3674 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 3675 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 3676 3677 // Analyze the case when either Op0 or Op1 is an add instruction. 3678 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 3679 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 3680 if (BO0 && BO0->getOpcode() == Instruction::Add) { 3681 A = BO0->getOperand(0); 3682 B = BO0->getOperand(1); 3683 } 3684 if (BO1 && BO1->getOpcode() == Instruction::Add) { 3685 C = BO1->getOperand(0); 3686 D = BO1->getOperand(1); 3687 } 3688 3689 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 3690 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 3691 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 3692 return new ICmpInst(Pred, A == Op1 ? B : A, 3693 Constant::getNullValue(Op1->getType())); 3694 3695 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 3696 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 3697 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 3698 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 3699 C == Op0 ? D : C); 3700 3701 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 3702 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 3703 NoOp1WrapProblem) { 3704 // Determine Y and Z in the form icmp (X+Y), (X+Z). 3705 Value *Y, *Z; 3706 if (A == C) { 3707 // C + B == C + D -> B == D 3708 Y = B; 3709 Z = D; 3710 } else if (A == D) { 3711 // D + B == C + D -> B == C 3712 Y = B; 3713 Z = C; 3714 } else if (B == C) { 3715 // A + C == C + D -> A == D 3716 Y = A; 3717 Z = D; 3718 } else { 3719 assert(B == D); 3720 // A + D == C + D -> A == C 3721 Y = A; 3722 Z = C; 3723 } 3724 return new ICmpInst(Pred, Y, Z); 3725 } 3726 3727 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 3728 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 3729 match(B, m_AllOnes())) 3730 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 3731 3732 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 3733 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 3734 match(B, m_AllOnes())) 3735 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 3736 3737 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 3738 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 3739 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 3740 3741 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 3742 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 3743 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 3744 3745 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 3746 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 3747 match(D, m_AllOnes())) 3748 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 3749 3750 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 3751 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 3752 match(D, m_AllOnes())) 3753 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 3754 3755 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 3756 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 3757 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 3758 3759 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 3760 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 3761 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 3762 3763 // TODO: The subtraction-related identities shown below also hold, but 3764 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 3765 // wouldn't happen even if they were implemented. 3766 // 3767 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 3768 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 3769 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 3770 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 3771 3772 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 3773 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 3774 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 3775 3776 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 3777 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 3778 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 3779 3780 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 3781 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 3782 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 3783 3784 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 3785 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 3786 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 3787 3788 // if C1 has greater magnitude than C2: 3789 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 3790 // s.t. C3 = C1 - C2 3791 // 3792 // if C2 has greater magnitude than C1: 3793 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 3794 // s.t. C3 = C2 - C1 3795 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 3796 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 3797 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 3798 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 3799 const APInt &AP1 = C1->getValue(); 3800 const APInt &AP2 = C2->getValue(); 3801 if (AP1.isNegative() == AP2.isNegative()) { 3802 APInt AP1Abs = C1->getValue().abs(); 3803 APInt AP2Abs = C2->getValue().abs(); 3804 if (AP1Abs.uge(AP2Abs)) { 3805 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 3806 Value *NewAdd = Builder.CreateNSWAdd(A, C3); 3807 return new ICmpInst(Pred, NewAdd, C); 3808 } else { 3809 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 3810 Value *NewAdd = Builder.CreateNSWAdd(C, C3); 3811 return new ICmpInst(Pred, A, NewAdd); 3812 } 3813 } 3814 } 3815 3816 // Analyze the case when either Op0 or Op1 is a sub instruction. 3817 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 3818 A = nullptr; 3819 B = nullptr; 3820 C = nullptr; 3821 D = nullptr; 3822 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 3823 A = BO0->getOperand(0); 3824 B = BO0->getOperand(1); 3825 } 3826 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 3827 C = BO1->getOperand(0); 3828 D = BO1->getOperand(1); 3829 } 3830 3831 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 3832 if (A == Op1 && NoOp0WrapProblem) 3833 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 3834 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 3835 if (C == Op0 && NoOp1WrapProblem) 3836 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 3837 3838 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 3839 // (A - B) u>/u<= A --> B u>/u<= A 3840 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3841 return new ICmpInst(Pred, B, A); 3842 // C u</u>= (C - D) --> C u</u>= D 3843 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3844 return new ICmpInst(Pred, C, D); 3845 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 3846 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 3847 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 3848 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 3849 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 3850 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 3851 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 3852 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 3853 3854 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 3855 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 3856 return new ICmpInst(Pred, A, C); 3857 3858 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 3859 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 3860 return new ICmpInst(Pred, D, B); 3861 3862 // icmp (0-X) < cst --> x > -cst 3863 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 3864 Value *X; 3865 if (match(BO0, m_Neg(m_Value(X)))) 3866 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 3867 if (RHSC->isNotMinSignedValue()) 3868 return new ICmpInst(I.getSwappedPredicate(), X, 3869 ConstantExpr::getNeg(RHSC)); 3870 } 3871 3872 BinaryOperator *SRem = nullptr; 3873 // icmp (srem X, Y), Y 3874 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 3875 SRem = BO0; 3876 // icmp Y, (srem X, Y) 3877 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 3878 Op0 == BO1->getOperand(1)) 3879 SRem = BO1; 3880 if (SRem) { 3881 // We don't check hasOneUse to avoid increasing register pressure because 3882 // the value we use is the same value this instruction was already using. 3883 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 3884 default: 3885 break; 3886 case ICmpInst::ICMP_EQ: 3887 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3888 case ICmpInst::ICMP_NE: 3889 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3890 case ICmpInst::ICMP_SGT: 3891 case ICmpInst::ICMP_SGE: 3892 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 3893 Constant::getAllOnesValue(SRem->getType())); 3894 case ICmpInst::ICMP_SLT: 3895 case ICmpInst::ICMP_SLE: 3896 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 3897 Constant::getNullValue(SRem->getType())); 3898 } 3899 } 3900 3901 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 3902 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 3903 switch (BO0->getOpcode()) { 3904 default: 3905 break; 3906 case Instruction::Add: 3907 case Instruction::Sub: 3908 case Instruction::Xor: { 3909 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 3910 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3911 3912 const APInt *C; 3913 if (match(BO0->getOperand(1), m_APInt(C))) { 3914 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 3915 if (C->isSignMask()) { 3916 ICmpInst::Predicate NewPred = 3917 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3918 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3919 } 3920 3921 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 3922 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 3923 ICmpInst::Predicate NewPred = 3924 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3925 NewPred = I.getSwappedPredicate(NewPred); 3926 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3927 } 3928 } 3929 break; 3930 } 3931 case Instruction::Mul: { 3932 if (!I.isEquality()) 3933 break; 3934 3935 const APInt *C; 3936 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() && 3937 !C->isOneValue()) { 3938 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 3939 // Mask = -1 >> count-trailing-zeros(C). 3940 if (unsigned TZs = C->countTrailingZeros()) { 3941 Constant *Mask = ConstantInt::get( 3942 BO0->getType(), 3943 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 3944 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 3945 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 3946 return new ICmpInst(Pred, And1, And2); 3947 } 3948 // If there are no trailing zeros in the multiplier, just eliminate 3949 // the multiplies (no masking is needed): 3950 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y 3951 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3952 } 3953 break; 3954 } 3955 case Instruction::UDiv: 3956 case Instruction::LShr: 3957 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 3958 break; 3959 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3960 3961 case Instruction::SDiv: 3962 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 3963 break; 3964 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3965 3966 case Instruction::AShr: 3967 if (!BO0->isExact() || !BO1->isExact()) 3968 break; 3969 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3970 3971 case Instruction::Shl: { 3972 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 3973 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 3974 if (!NUW && !NSW) 3975 break; 3976 if (!NSW && I.isSigned()) 3977 break; 3978 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3979 } 3980 } 3981 } 3982 3983 if (BO0) { 3984 // Transform A & (L - 1) `ult` L --> L != 0 3985 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 3986 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 3987 3988 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 3989 auto *Zero = Constant::getNullValue(BO0->getType()); 3990 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 3991 } 3992 } 3993 3994 if (Value *V = foldUnsignedMultiplicationOverflowCheck(I)) 3995 return replaceInstUsesWith(I, V); 3996 3997 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 3998 return replaceInstUsesWith(I, V); 3999 4000 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4001 return replaceInstUsesWith(I, V); 4002 4003 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4004 return replaceInstUsesWith(I, V); 4005 4006 return nullptr; 4007 } 4008 4009 /// Fold icmp Pred min|max(X, Y), X. 4010 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4011 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4012 Value *Op0 = Cmp.getOperand(0); 4013 Value *X = Cmp.getOperand(1); 4014 4015 // Canonicalize minimum or maximum operand to LHS of the icmp. 4016 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4017 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4018 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4019 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4020 std::swap(Op0, X); 4021 Pred = Cmp.getSwappedPredicate(); 4022 } 4023 4024 Value *Y; 4025 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4026 // smin(X, Y) == X --> X s<= Y 4027 // smin(X, Y) s>= X --> X s<= Y 4028 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4029 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4030 4031 // smin(X, Y) != X --> X s> Y 4032 // smin(X, Y) s< X --> X s> Y 4033 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4034 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4035 4036 // These cases should be handled in InstSimplify: 4037 // smin(X, Y) s<= X --> true 4038 // smin(X, Y) s> X --> false 4039 return nullptr; 4040 } 4041 4042 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4043 // smax(X, Y) == X --> X s>= Y 4044 // smax(X, Y) s<= X --> X s>= Y 4045 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4046 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4047 4048 // smax(X, Y) != X --> X s< Y 4049 // smax(X, Y) s> X --> X s< Y 4050 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4051 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4052 4053 // These cases should be handled in InstSimplify: 4054 // smax(X, Y) s>= X --> true 4055 // smax(X, Y) s< X --> false 4056 return nullptr; 4057 } 4058 4059 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4060 // umin(X, Y) == X --> X u<= Y 4061 // umin(X, Y) u>= X --> X u<= Y 4062 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4063 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4064 4065 // umin(X, Y) != X --> X u> Y 4066 // umin(X, Y) u< X --> X u> Y 4067 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4068 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4069 4070 // These cases should be handled in InstSimplify: 4071 // umin(X, Y) u<= X --> true 4072 // umin(X, Y) u> X --> false 4073 return nullptr; 4074 } 4075 4076 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4077 // umax(X, Y) == X --> X u>= Y 4078 // umax(X, Y) u<= X --> X u>= Y 4079 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4080 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4081 4082 // umax(X, Y) != X --> X u< Y 4083 // umax(X, Y) u> X --> X u< Y 4084 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4085 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4086 4087 // These cases should be handled in InstSimplify: 4088 // umax(X, Y) u>= X --> true 4089 // umax(X, Y) u< X --> false 4090 return nullptr; 4091 } 4092 4093 return nullptr; 4094 } 4095 4096 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 4097 if (!I.isEquality()) 4098 return nullptr; 4099 4100 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4101 const CmpInst::Predicate Pred = I.getPredicate(); 4102 Value *A, *B, *C, *D; 4103 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4104 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4105 Value *OtherVal = A == Op1 ? B : A; 4106 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4107 } 4108 4109 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4110 // A^c1 == C^c2 --> A == C^(c1^c2) 4111 ConstantInt *C1, *C2; 4112 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4113 Op1->hasOneUse()) { 4114 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4115 Value *Xor = Builder.CreateXor(C, NC); 4116 return new ICmpInst(Pred, A, Xor); 4117 } 4118 4119 // A^B == A^D -> B == D 4120 if (A == C) 4121 return new ICmpInst(Pred, B, D); 4122 if (A == D) 4123 return new ICmpInst(Pred, B, C); 4124 if (B == C) 4125 return new ICmpInst(Pred, A, D); 4126 if (B == D) 4127 return new ICmpInst(Pred, A, C); 4128 } 4129 } 4130 4131 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4132 // A == (A^B) -> B == 0 4133 Value *OtherVal = A == Op0 ? B : A; 4134 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4135 } 4136 4137 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4138 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4139 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4140 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4141 4142 if (A == C) { 4143 X = B; 4144 Y = D; 4145 Z = A; 4146 } else if (A == D) { 4147 X = B; 4148 Y = C; 4149 Z = A; 4150 } else if (B == C) { 4151 X = A; 4152 Y = D; 4153 Z = B; 4154 } else if (B == D) { 4155 X = A; 4156 Y = C; 4157 Z = B; 4158 } 4159 4160 if (X) { // Build (X^Y) & Z 4161 Op1 = Builder.CreateXor(X, Y); 4162 Op1 = Builder.CreateAnd(Op1, Z); 4163 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4164 } 4165 } 4166 4167 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4168 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4169 ConstantInt *Cst1; 4170 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4171 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4172 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4173 match(Op1, m_ZExt(m_Value(A))))) { 4174 APInt Pow2 = Cst1->getValue() + 1; 4175 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4176 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4177 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4178 } 4179 4180 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4181 // For lshr and ashr pairs. 4182 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4183 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4184 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4185 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4186 unsigned TypeBits = Cst1->getBitWidth(); 4187 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4188 if (ShAmt < TypeBits && ShAmt != 0) { 4189 ICmpInst::Predicate NewPred = 4190 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4191 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4192 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4193 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4194 } 4195 } 4196 4197 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4198 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4199 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4200 unsigned TypeBits = Cst1->getBitWidth(); 4201 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4202 if (ShAmt < TypeBits && ShAmt != 0) { 4203 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4204 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4205 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4206 I.getName() + ".mask"); 4207 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4208 } 4209 } 4210 4211 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4212 // "icmp (and X, mask), cst" 4213 uint64_t ShAmt = 0; 4214 if (Op0->hasOneUse() && 4215 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4216 match(Op1, m_ConstantInt(Cst1)) && 4217 // Only do this when A has multiple uses. This is most important to do 4218 // when it exposes other optimizations. 4219 !A->hasOneUse()) { 4220 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4221 4222 if (ShAmt < ASize) { 4223 APInt MaskV = 4224 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4225 MaskV <<= ShAmt; 4226 4227 APInt CmpV = Cst1->getValue().zext(ASize); 4228 CmpV <<= ShAmt; 4229 4230 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4231 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4232 } 4233 } 4234 4235 // If both operands are byte-swapped or bit-reversed, just compare the 4236 // original values. 4237 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant() 4238 // and handle more intrinsics. 4239 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) || 4240 (match(Op0, m_BitReverse(m_Value(A))) && 4241 match(Op1, m_BitReverse(m_Value(B))))) 4242 return new ICmpInst(Pred, A, B); 4243 4244 // Canonicalize checking for a power-of-2-or-zero value: 4245 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4246 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4247 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4248 m_Deferred(A)))) || 4249 !match(Op1, m_ZeroInt())) 4250 A = nullptr; 4251 4252 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4253 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4254 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4255 A = Op1; 4256 else if (match(Op1, 4257 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4258 A = Op0; 4259 4260 if (A) { 4261 Type *Ty = A->getType(); 4262 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4263 return Pred == ICmpInst::ICMP_EQ 4264 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4265 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4266 } 4267 4268 return nullptr; 4269 } 4270 4271 static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp, 4272 InstCombiner::BuilderTy &Builder) { 4273 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4274 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4275 Value *X; 4276 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4277 return nullptr; 4278 4279 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4280 bool IsSignedCmp = ICmp.isSigned(); 4281 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) { 4282 // If the signedness of the two casts doesn't agree (i.e. one is a sext 4283 // and the other is a zext), then we can't handle this. 4284 // TODO: This is too strict. We can handle some predicates (equality?). 4285 if (CastOp0->getOpcode() != CastOp1->getOpcode()) 4286 return nullptr; 4287 4288 // Not an extension from the same type? 4289 Value *Y = CastOp1->getOperand(0); 4290 Type *XTy = X->getType(), *YTy = Y->getType(); 4291 if (XTy != YTy) { 4292 // One of the casts must have one use because we are creating a new cast. 4293 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse()) 4294 return nullptr; 4295 // Extend the narrower operand to the type of the wider operand. 4296 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4297 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy); 4298 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4299 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy); 4300 else 4301 return nullptr; 4302 } 4303 4304 // (zext X) == (zext Y) --> X == Y 4305 // (sext X) == (sext Y) --> X == Y 4306 if (ICmp.isEquality()) 4307 return new ICmpInst(ICmp.getPredicate(), X, Y); 4308 4309 // A signed comparison of sign extended values simplifies into a 4310 // signed comparison. 4311 if (IsSignedCmp && IsSignedExt) 4312 return new ICmpInst(ICmp.getPredicate(), X, Y); 4313 4314 // The other three cases all fold into an unsigned comparison. 4315 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4316 } 4317 4318 // Below here, we are only folding a compare with constant. 4319 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4320 if (!C) 4321 return nullptr; 4322 4323 // Compute the constant that would happen if we truncated to SrcTy then 4324 // re-extended to DestTy. 4325 Type *SrcTy = CastOp0->getSrcTy(); 4326 Type *DestTy = CastOp0->getDestTy(); 4327 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4328 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4329 4330 // If the re-extended constant didn't change... 4331 if (Res2 == C) { 4332 if (ICmp.isEquality()) 4333 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4334 4335 // A signed comparison of sign extended values simplifies into a 4336 // signed comparison. 4337 if (IsSignedExt && IsSignedCmp) 4338 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4339 4340 // The other three cases all fold into an unsigned comparison. 4341 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4342 } 4343 4344 // The re-extended constant changed, partly changed (in the case of a vector), 4345 // or could not be determined to be equal (in the case of a constant 4346 // expression), so the constant cannot be represented in the shorter type. 4347 // All the cases that fold to true or false will have already been handled 4348 // by SimplifyICmpInst, so only deal with the tricky case. 4349 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4350 return nullptr; 4351 4352 // Is source op positive? 4353 // icmp ult (sext X), C --> icmp sgt X, -1 4354 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4355 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4356 4357 // Is source op negative? 4358 // icmp ugt (sext X), C --> icmp slt X, 0 4359 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4360 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4361 } 4362 4363 /// Handle icmp (cast x), (cast or constant). 4364 Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) { 4365 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4366 if (!CastOp0) 4367 return nullptr; 4368 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4369 return nullptr; 4370 4371 Value *Op0Src = CastOp0->getOperand(0); 4372 Type *SrcTy = CastOp0->getSrcTy(); 4373 Type *DestTy = CastOp0->getDestTy(); 4374 4375 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4376 // integer type is the same size as the pointer type. 4377 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4378 if (isa<VectorType>(SrcTy)) { 4379 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4380 DestTy = cast<VectorType>(DestTy)->getElementType(); 4381 } 4382 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4383 }; 4384 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4385 CompatibleSizes(SrcTy, DestTy)) { 4386 Value *NewOp1 = nullptr; 4387 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4388 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4389 if (PtrSrc->getType()->getPointerAddressSpace() == 4390 Op0Src->getType()->getPointerAddressSpace()) { 4391 NewOp1 = PtrToIntOp1->getOperand(0); 4392 // If the pointer types don't match, insert a bitcast. 4393 if (Op0Src->getType() != NewOp1->getType()) 4394 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4395 } 4396 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4397 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4398 } 4399 4400 if (NewOp1) 4401 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4402 } 4403 4404 return foldICmpWithZextOrSext(ICmp, Builder); 4405 } 4406 4407 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4408 switch (BinaryOp) { 4409 default: 4410 llvm_unreachable("Unsupported binary op"); 4411 case Instruction::Add: 4412 case Instruction::Sub: 4413 return match(RHS, m_Zero()); 4414 case Instruction::Mul: 4415 return match(RHS, m_One()); 4416 } 4417 } 4418 4419 OverflowResult InstCombiner::computeOverflow( 4420 Instruction::BinaryOps BinaryOp, bool IsSigned, 4421 Value *LHS, Value *RHS, Instruction *CxtI) const { 4422 switch (BinaryOp) { 4423 default: 4424 llvm_unreachable("Unsupported binary op"); 4425 case Instruction::Add: 4426 if (IsSigned) 4427 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4428 else 4429 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4430 case Instruction::Sub: 4431 if (IsSigned) 4432 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4433 else 4434 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4435 case Instruction::Mul: 4436 if (IsSigned) 4437 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4438 else 4439 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4440 } 4441 } 4442 4443 bool InstCombiner::OptimizeOverflowCheck( 4444 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS, 4445 Instruction &OrigI, Value *&Result, Constant *&Overflow) { 4446 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4447 std::swap(LHS, RHS); 4448 4449 // If the overflow check was an add followed by a compare, the insertion point 4450 // may be pointing to the compare. We want to insert the new instructions 4451 // before the add in case there are uses of the add between the add and the 4452 // compare. 4453 Builder.SetInsertPoint(&OrigI); 4454 4455 if (isNeutralValue(BinaryOp, RHS)) { 4456 Result = LHS; 4457 Overflow = Builder.getFalse(); 4458 return true; 4459 } 4460 4461 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4462 case OverflowResult::MayOverflow: 4463 return false; 4464 case OverflowResult::AlwaysOverflowsLow: 4465 case OverflowResult::AlwaysOverflowsHigh: 4466 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4467 Result->takeName(&OrigI); 4468 Overflow = Builder.getTrue(); 4469 return true; 4470 case OverflowResult::NeverOverflows: 4471 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4472 Result->takeName(&OrigI); 4473 Overflow = Builder.getFalse(); 4474 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4475 if (IsSigned) 4476 Inst->setHasNoSignedWrap(); 4477 else 4478 Inst->setHasNoUnsignedWrap(); 4479 } 4480 return true; 4481 } 4482 4483 llvm_unreachable("Unexpected overflow result"); 4484 } 4485 4486 /// Recognize and process idiom involving test for multiplication 4487 /// overflow. 4488 /// 4489 /// The caller has matched a pattern of the form: 4490 /// I = cmp u (mul(zext A, zext B), V 4491 /// The function checks if this is a test for overflow and if so replaces 4492 /// multiplication with call to 'mul.with.overflow' intrinsic. 4493 /// 4494 /// \param I Compare instruction. 4495 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4496 /// the compare instruction. Must be of integer type. 4497 /// \param OtherVal The other argument of compare instruction. 4498 /// \returns Instruction which must replace the compare instruction, NULL if no 4499 /// replacement required. 4500 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4501 Value *OtherVal, InstCombiner &IC) { 4502 // Don't bother doing this transformation for pointers, don't do it for 4503 // vectors. 4504 if (!isa<IntegerType>(MulVal->getType())) 4505 return nullptr; 4506 4507 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4508 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4509 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4510 if (!MulInstr) 4511 return nullptr; 4512 assert(MulInstr->getOpcode() == Instruction::Mul); 4513 4514 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4515 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4516 assert(LHS->getOpcode() == Instruction::ZExt); 4517 assert(RHS->getOpcode() == Instruction::ZExt); 4518 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4519 4520 // Calculate type and width of the result produced by mul.with.overflow. 4521 Type *TyA = A->getType(), *TyB = B->getType(); 4522 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4523 WidthB = TyB->getPrimitiveSizeInBits(); 4524 unsigned MulWidth; 4525 Type *MulType; 4526 if (WidthB > WidthA) { 4527 MulWidth = WidthB; 4528 MulType = TyB; 4529 } else { 4530 MulWidth = WidthA; 4531 MulType = TyA; 4532 } 4533 4534 // In order to replace the original mul with a narrower mul.with.overflow, 4535 // all uses must ignore upper bits of the product. The number of used low 4536 // bits must be not greater than the width of mul.with.overflow. 4537 if (MulVal->hasNUsesOrMore(2)) 4538 for (User *U : MulVal->users()) { 4539 if (U == &I) 4540 continue; 4541 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4542 // Check if truncation ignores bits above MulWidth. 4543 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 4544 if (TruncWidth > MulWidth) 4545 return nullptr; 4546 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4547 // Check if AND ignores bits above MulWidth. 4548 if (BO->getOpcode() != Instruction::And) 4549 return nullptr; 4550 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 4551 const APInt &CVal = CI->getValue(); 4552 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 4553 return nullptr; 4554 } else { 4555 // In this case we could have the operand of the binary operation 4556 // being defined in another block, and performing the replacement 4557 // could break the dominance relation. 4558 return nullptr; 4559 } 4560 } else { 4561 // Other uses prohibit this transformation. 4562 return nullptr; 4563 } 4564 } 4565 4566 // Recognize patterns 4567 switch (I.getPredicate()) { 4568 case ICmpInst::ICMP_EQ: 4569 case ICmpInst::ICMP_NE: 4570 // Recognize pattern: 4571 // mulval = mul(zext A, zext B) 4572 // cmp eq/neq mulval, zext trunc mulval 4573 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 4574 if (Zext->hasOneUse()) { 4575 Value *ZextArg = Zext->getOperand(0); 4576 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 4577 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 4578 break; //Recognized 4579 } 4580 4581 // Recognize pattern: 4582 // mulval = mul(zext A, zext B) 4583 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 4584 ConstantInt *CI; 4585 Value *ValToMask; 4586 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 4587 if (ValToMask != MulVal) 4588 return nullptr; 4589 const APInt &CVal = CI->getValue() + 1; 4590 if (CVal.isPowerOf2()) { 4591 unsigned MaskWidth = CVal.logBase2(); 4592 if (MaskWidth == MulWidth) 4593 break; // Recognized 4594 } 4595 } 4596 return nullptr; 4597 4598 case ICmpInst::ICMP_UGT: 4599 // Recognize pattern: 4600 // mulval = mul(zext A, zext B) 4601 // cmp ugt mulval, max 4602 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4603 APInt MaxVal = APInt::getMaxValue(MulWidth); 4604 MaxVal = MaxVal.zext(CI->getBitWidth()); 4605 if (MaxVal.eq(CI->getValue())) 4606 break; // Recognized 4607 } 4608 return nullptr; 4609 4610 case ICmpInst::ICMP_UGE: 4611 // Recognize pattern: 4612 // mulval = mul(zext A, zext B) 4613 // cmp uge mulval, max+1 4614 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4615 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4616 if (MaxVal.eq(CI->getValue())) 4617 break; // Recognized 4618 } 4619 return nullptr; 4620 4621 case ICmpInst::ICMP_ULE: 4622 // Recognize pattern: 4623 // mulval = mul(zext A, zext B) 4624 // cmp ule mulval, max 4625 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4626 APInt MaxVal = APInt::getMaxValue(MulWidth); 4627 MaxVal = MaxVal.zext(CI->getBitWidth()); 4628 if (MaxVal.eq(CI->getValue())) 4629 break; // Recognized 4630 } 4631 return nullptr; 4632 4633 case ICmpInst::ICMP_ULT: 4634 // Recognize pattern: 4635 // mulval = mul(zext A, zext B) 4636 // cmp ule mulval, max + 1 4637 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4638 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4639 if (MaxVal.eq(CI->getValue())) 4640 break; // Recognized 4641 } 4642 return nullptr; 4643 4644 default: 4645 return nullptr; 4646 } 4647 4648 InstCombiner::BuilderTy &Builder = IC.Builder; 4649 Builder.SetInsertPoint(MulInstr); 4650 4651 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 4652 Value *MulA = A, *MulB = B; 4653 if (WidthA < MulWidth) 4654 MulA = Builder.CreateZExt(A, MulType); 4655 if (WidthB < MulWidth) 4656 MulB = Builder.CreateZExt(B, MulType); 4657 Function *F = Intrinsic::getDeclaration( 4658 I.getModule(), Intrinsic::umul_with_overflow, MulType); 4659 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 4660 IC.Worklist.push(MulInstr); 4661 4662 // If there are uses of mul result other than the comparison, we know that 4663 // they are truncation or binary AND. Change them to use result of 4664 // mul.with.overflow and adjust properly mask/size. 4665 if (MulVal->hasNUsesOrMore(2)) { 4666 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 4667 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) { 4668 User *U = *UI++; 4669 if (U == &I || U == OtherVal) 4670 continue; 4671 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4672 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 4673 IC.replaceInstUsesWith(*TI, Mul); 4674 else 4675 TI->setOperand(0, Mul); 4676 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4677 assert(BO->getOpcode() == Instruction::And); 4678 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 4679 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 4680 APInt ShortMask = CI->getValue().trunc(MulWidth); 4681 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 4682 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 4683 IC.replaceInstUsesWith(*BO, Zext); 4684 } else { 4685 llvm_unreachable("Unexpected Binary operation"); 4686 } 4687 IC.Worklist.push(cast<Instruction>(U)); 4688 } 4689 } 4690 if (isa<Instruction>(OtherVal)) 4691 IC.Worklist.push(cast<Instruction>(OtherVal)); 4692 4693 // The original icmp gets replaced with the overflow value, maybe inverted 4694 // depending on predicate. 4695 bool Inverse = false; 4696 switch (I.getPredicate()) { 4697 case ICmpInst::ICMP_NE: 4698 break; 4699 case ICmpInst::ICMP_EQ: 4700 Inverse = true; 4701 break; 4702 case ICmpInst::ICMP_UGT: 4703 case ICmpInst::ICMP_UGE: 4704 if (I.getOperand(0) == MulVal) 4705 break; 4706 Inverse = true; 4707 break; 4708 case ICmpInst::ICMP_ULT: 4709 case ICmpInst::ICMP_ULE: 4710 if (I.getOperand(1) == MulVal) 4711 break; 4712 Inverse = true; 4713 break; 4714 default: 4715 llvm_unreachable("Unexpected predicate"); 4716 } 4717 if (Inverse) { 4718 Value *Res = Builder.CreateExtractValue(Call, 1); 4719 return BinaryOperator::CreateNot(Res); 4720 } 4721 4722 return ExtractValueInst::Create(Call, 1); 4723 } 4724 4725 /// When performing a comparison against a constant, it is possible that not all 4726 /// the bits in the LHS are demanded. This helper method computes the mask that 4727 /// IS demanded. 4728 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 4729 const APInt *RHS; 4730 if (!match(I.getOperand(1), m_APInt(RHS))) 4731 return APInt::getAllOnesValue(BitWidth); 4732 4733 // If this is a normal comparison, it demands all bits. If it is a sign bit 4734 // comparison, it only demands the sign bit. 4735 bool UnusedBit; 4736 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 4737 return APInt::getSignMask(BitWidth); 4738 4739 switch (I.getPredicate()) { 4740 // For a UGT comparison, we don't care about any bits that 4741 // correspond to the trailing ones of the comparand. The value of these 4742 // bits doesn't impact the outcome of the comparison, because any value 4743 // greater than the RHS must differ in a bit higher than these due to carry. 4744 case ICmpInst::ICMP_UGT: 4745 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 4746 4747 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 4748 // Any value less than the RHS must differ in a higher bit because of carries. 4749 case ICmpInst::ICMP_ULT: 4750 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 4751 4752 default: 4753 return APInt::getAllOnesValue(BitWidth); 4754 } 4755 } 4756 4757 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 4758 /// should be swapped. 4759 /// The decision is based on how many times these two operands are reused 4760 /// as subtract operands and their positions in those instructions. 4761 /// The rationale is that several architectures use the same instruction for 4762 /// both subtract and cmp. Thus, it is better if the order of those operands 4763 /// match. 4764 /// \return true if Op0 and Op1 should be swapped. 4765 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 4766 // Filter out pointer values as those cannot appear directly in subtract. 4767 // FIXME: we may want to go through inttoptrs or bitcasts. 4768 if (Op0->getType()->isPointerTy()) 4769 return false; 4770 // If a subtract already has the same operands as a compare, swapping would be 4771 // bad. If a subtract has the same operands as a compare but in reverse order, 4772 // then swapping is good. 4773 int GoodToSwap = 0; 4774 for (const User *U : Op0->users()) { 4775 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 4776 GoodToSwap++; 4777 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 4778 GoodToSwap--; 4779 } 4780 return GoodToSwap > 0; 4781 } 4782 4783 /// Check that one use is in the same block as the definition and all 4784 /// other uses are in blocks dominated by a given block. 4785 /// 4786 /// \param DI Definition 4787 /// \param UI Use 4788 /// \param DB Block that must dominate all uses of \p DI outside 4789 /// the parent block 4790 /// \return true when \p UI is the only use of \p DI in the parent block 4791 /// and all other uses of \p DI are in blocks dominated by \p DB. 4792 /// 4793 bool InstCombiner::dominatesAllUses(const Instruction *DI, 4794 const Instruction *UI, 4795 const BasicBlock *DB) const { 4796 assert(DI && UI && "Instruction not defined\n"); 4797 // Ignore incomplete definitions. 4798 if (!DI->getParent()) 4799 return false; 4800 // DI and UI must be in the same block. 4801 if (DI->getParent() != UI->getParent()) 4802 return false; 4803 // Protect from self-referencing blocks. 4804 if (DI->getParent() == DB) 4805 return false; 4806 for (const User *U : DI->users()) { 4807 auto *Usr = cast<Instruction>(U); 4808 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 4809 return false; 4810 } 4811 return true; 4812 } 4813 4814 /// Return true when the instruction sequence within a block is select-cmp-br. 4815 static bool isChainSelectCmpBranch(const SelectInst *SI) { 4816 const BasicBlock *BB = SI->getParent(); 4817 if (!BB) 4818 return false; 4819 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 4820 if (!BI || BI->getNumSuccessors() != 2) 4821 return false; 4822 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 4823 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 4824 return false; 4825 return true; 4826 } 4827 4828 /// True when a select result is replaced by one of its operands 4829 /// in select-icmp sequence. This will eventually result in the elimination 4830 /// of the select. 4831 /// 4832 /// \param SI Select instruction 4833 /// \param Icmp Compare instruction 4834 /// \param SIOpd Operand that replaces the select 4835 /// 4836 /// Notes: 4837 /// - The replacement is global and requires dominator information 4838 /// - The caller is responsible for the actual replacement 4839 /// 4840 /// Example: 4841 /// 4842 /// entry: 4843 /// %4 = select i1 %3, %C* %0, %C* null 4844 /// %5 = icmp eq %C* %4, null 4845 /// br i1 %5, label %9, label %7 4846 /// ... 4847 /// ; <label>:7 ; preds = %entry 4848 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 4849 /// ... 4850 /// 4851 /// can be transformed to 4852 /// 4853 /// %5 = icmp eq %C* %0, null 4854 /// %6 = select i1 %3, i1 %5, i1 true 4855 /// br i1 %6, label %9, label %7 4856 /// ... 4857 /// ; <label>:7 ; preds = %entry 4858 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 4859 /// 4860 /// Similar when the first operand of the select is a constant or/and 4861 /// the compare is for not equal rather than equal. 4862 /// 4863 /// NOTE: The function is only called when the select and compare constants 4864 /// are equal, the optimization can work only for EQ predicates. This is not a 4865 /// major restriction since a NE compare should be 'normalized' to an equal 4866 /// compare, which usually happens in the combiner and test case 4867 /// select-cmp-br.ll checks for it. 4868 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 4869 const ICmpInst *Icmp, 4870 const unsigned SIOpd) { 4871 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 4872 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 4873 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 4874 // The check for the single predecessor is not the best that can be 4875 // done. But it protects efficiently against cases like when SI's 4876 // home block has two successors, Succ and Succ1, and Succ1 predecessor 4877 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 4878 // replaced can be reached on either path. So the uniqueness check 4879 // guarantees that the path all uses of SI (outside SI's parent) are on 4880 // is disjoint from all other paths out of SI. But that information 4881 // is more expensive to compute, and the trade-off here is in favor 4882 // of compile-time. It should also be noticed that we check for a single 4883 // predecessor and not only uniqueness. This to handle the situation when 4884 // Succ and Succ1 points to the same basic block. 4885 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 4886 NumSel++; 4887 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 4888 return true; 4889 } 4890 } 4891 return false; 4892 } 4893 4894 /// Try to fold the comparison based on range information we can get by checking 4895 /// whether bits are known to be zero or one in the inputs. 4896 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 4897 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4898 Type *Ty = Op0->getType(); 4899 ICmpInst::Predicate Pred = I.getPredicate(); 4900 4901 // Get scalar or pointer size. 4902 unsigned BitWidth = Ty->isIntOrIntVectorTy() 4903 ? Ty->getScalarSizeInBits() 4904 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 4905 4906 if (!BitWidth) 4907 return nullptr; 4908 4909 KnownBits Op0Known(BitWidth); 4910 KnownBits Op1Known(BitWidth); 4911 4912 if (SimplifyDemandedBits(&I, 0, 4913 getDemandedBitsLHSMask(I, BitWidth), 4914 Op0Known, 0)) 4915 return &I; 4916 4917 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth), 4918 Op1Known, 0)) 4919 return &I; 4920 4921 // Given the known and unknown bits, compute a range that the LHS could be 4922 // in. Compute the Min, Max and RHS values based on the known bits. For the 4923 // EQ and NE we use unsigned values. 4924 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 4925 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 4926 if (I.isSigned()) { 4927 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4928 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4929 } else { 4930 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4931 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4932 } 4933 4934 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 4935 // out that the LHS or RHS is a constant. Constant fold this now, so that 4936 // code below can assume that Min != Max. 4937 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 4938 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 4939 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 4940 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 4941 4942 // Based on the range information we know about the LHS, see if we can 4943 // simplify this comparison. For example, (x&4) < 8 is always true. 4944 switch (Pred) { 4945 default: 4946 llvm_unreachable("Unknown icmp opcode!"); 4947 case ICmpInst::ICMP_EQ: 4948 case ICmpInst::ICMP_NE: { 4949 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 4950 return Pred == CmpInst::ICMP_EQ 4951 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 4952 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4953 } 4954 4955 // If all bits are known zero except for one, then we know at most one bit 4956 // is set. If the comparison is against zero, then this is a check to see if 4957 // *that* bit is set. 4958 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 4959 if (Op1Known.isZero()) { 4960 // If the LHS is an AND with the same constant, look through it. 4961 Value *LHS = nullptr; 4962 const APInt *LHSC; 4963 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 4964 *LHSC != Op0KnownZeroInverted) 4965 LHS = Op0; 4966 4967 Value *X; 4968 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 4969 APInt ValToCheck = Op0KnownZeroInverted; 4970 Type *XTy = X->getType(); 4971 if (ValToCheck.isPowerOf2()) { 4972 // ((1 << X) & 8) == 0 -> X != 3 4973 // ((1 << X) & 8) != 0 -> X == 3 4974 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4975 auto NewPred = ICmpInst::getInversePredicate(Pred); 4976 return new ICmpInst(NewPred, X, CmpC); 4977 } else if ((++ValToCheck).isPowerOf2()) { 4978 // ((1 << X) & 7) == 0 -> X >= 3 4979 // ((1 << X) & 7) != 0 -> X < 3 4980 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4981 auto NewPred = 4982 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 4983 return new ICmpInst(NewPred, X, CmpC); 4984 } 4985 } 4986 4987 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 4988 const APInt *CI; 4989 if (Op0KnownZeroInverted.isOneValue() && 4990 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 4991 // ((8 >>u X) & 1) == 0 -> X != 3 4992 // ((8 >>u X) & 1) != 0 -> X == 3 4993 unsigned CmpVal = CI->countTrailingZeros(); 4994 auto NewPred = ICmpInst::getInversePredicate(Pred); 4995 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 4996 } 4997 } 4998 break; 4999 } 5000 case ICmpInst::ICMP_ULT: { 5001 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5002 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5003 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5004 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5005 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5006 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5007 5008 const APInt *CmpC; 5009 if (match(Op1, m_APInt(CmpC))) { 5010 // A <u C -> A == C-1 if min(A)+1 == C 5011 if (*CmpC == Op0Min + 1) 5012 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5013 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5014 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5015 // exceeds the log2 of C. 5016 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5017 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5018 Constant::getNullValue(Op1->getType())); 5019 } 5020 break; 5021 } 5022 case ICmpInst::ICMP_UGT: { 5023 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5024 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5025 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5026 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5027 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5028 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5029 5030 const APInt *CmpC; 5031 if (match(Op1, m_APInt(CmpC))) { 5032 // A >u C -> A == C+1 if max(a)-1 == C 5033 if (*CmpC == Op0Max - 1) 5034 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5035 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5036 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5037 // exceeds the log2 of C. 5038 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5039 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5040 Constant::getNullValue(Op1->getType())); 5041 } 5042 break; 5043 } 5044 case ICmpInst::ICMP_SLT: { 5045 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5046 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5047 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5048 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5049 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5050 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5051 const APInt *CmpC; 5052 if (match(Op1, m_APInt(CmpC))) { 5053 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5054 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5055 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5056 } 5057 break; 5058 } 5059 case ICmpInst::ICMP_SGT: { 5060 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5061 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5062 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5063 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5064 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5065 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5066 const APInt *CmpC; 5067 if (match(Op1, m_APInt(CmpC))) { 5068 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5069 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5070 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5071 } 5072 break; 5073 } 5074 case ICmpInst::ICMP_SGE: 5075 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5076 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5077 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5078 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5079 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5080 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5081 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5082 break; 5083 case ICmpInst::ICMP_SLE: 5084 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5085 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5086 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5087 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5088 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5089 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5090 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5091 break; 5092 case ICmpInst::ICMP_UGE: 5093 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5094 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5095 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5096 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5097 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5098 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5099 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5100 break; 5101 case ICmpInst::ICMP_ULE: 5102 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5103 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5104 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5105 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5106 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5107 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5108 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5109 break; 5110 } 5111 5112 // Turn a signed comparison into an unsigned one if both operands are known to 5113 // have the same sign. 5114 if (I.isSigned() && 5115 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5116 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5117 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5118 5119 return nullptr; 5120 } 5121 5122 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5123 llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5124 Constant *C) { 5125 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5126 "Only for relational integer predicates."); 5127 5128 Type *Type = C->getType(); 5129 bool IsSigned = ICmpInst::isSigned(Pred); 5130 5131 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5132 bool WillIncrement = 5133 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5134 5135 // Check if the constant operand can be safely incremented/decremented 5136 // without overflowing/underflowing. 5137 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5138 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5139 }; 5140 5141 Constant *SafeReplacementConstant = nullptr; 5142 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5143 // Bail out if the constant can't be safely incremented/decremented. 5144 if (!ConstantIsOk(CI)) 5145 return llvm::None; 5146 } else if (Type->isVectorTy()) { 5147 unsigned NumElts = Type->getVectorNumElements(); 5148 for (unsigned i = 0; i != NumElts; ++i) { 5149 Constant *Elt = C->getAggregateElement(i); 5150 if (!Elt) 5151 return llvm::None; 5152 5153 if (isa<UndefValue>(Elt)) 5154 continue; 5155 5156 // Bail out if we can't determine if this constant is min/max or if we 5157 // know that this constant is min/max. 5158 auto *CI = dyn_cast<ConstantInt>(Elt); 5159 if (!CI || !ConstantIsOk(CI)) 5160 return llvm::None; 5161 5162 if (!SafeReplacementConstant) 5163 SafeReplacementConstant = CI; 5164 } 5165 } else { 5166 // ConstantExpr? 5167 return llvm::None; 5168 } 5169 5170 // It may not be safe to change a compare predicate in the presence of 5171 // undefined elements, so replace those elements with the first safe constant 5172 // that we found. 5173 if (C->containsUndefElement()) { 5174 assert(SafeReplacementConstant && "Replacement constant not set"); 5175 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5176 } 5177 5178 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5179 5180 // Increment or decrement the constant. 5181 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5182 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5183 5184 return std::make_pair(NewPred, NewC); 5185 } 5186 5187 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5188 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5189 /// allows them to be folded in visitICmpInst. 5190 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5191 ICmpInst::Predicate Pred = I.getPredicate(); 5192 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5193 isCanonicalPredicate(Pred)) 5194 return nullptr; 5195 5196 Value *Op0 = I.getOperand(0); 5197 Value *Op1 = I.getOperand(1); 5198 auto *Op1C = dyn_cast<Constant>(Op1); 5199 if (!Op1C) 5200 return nullptr; 5201 5202 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5203 if (!FlippedStrictness) 5204 return nullptr; 5205 5206 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5207 } 5208 5209 /// Integer compare with boolean values can always be turned into bitwise ops. 5210 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5211 InstCombiner::BuilderTy &Builder) { 5212 Value *A = I.getOperand(0), *B = I.getOperand(1); 5213 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5214 5215 // A boolean compared to true/false can be simplified to Op0/true/false in 5216 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5217 // Cases not handled by InstSimplify are always 'not' of Op0. 5218 if (match(B, m_Zero())) { 5219 switch (I.getPredicate()) { 5220 case CmpInst::ICMP_EQ: // A == 0 -> !A 5221 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5222 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5223 return BinaryOperator::CreateNot(A); 5224 default: 5225 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5226 } 5227 } else if (match(B, m_One())) { 5228 switch (I.getPredicate()) { 5229 case CmpInst::ICMP_NE: // A != 1 -> !A 5230 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5231 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5232 return BinaryOperator::CreateNot(A); 5233 default: 5234 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5235 } 5236 } 5237 5238 switch (I.getPredicate()) { 5239 default: 5240 llvm_unreachable("Invalid icmp instruction!"); 5241 case ICmpInst::ICMP_EQ: 5242 // icmp eq i1 A, B -> ~(A ^ B) 5243 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5244 5245 case ICmpInst::ICMP_NE: 5246 // icmp ne i1 A, B -> A ^ B 5247 return BinaryOperator::CreateXor(A, B); 5248 5249 case ICmpInst::ICMP_UGT: 5250 // icmp ugt -> icmp ult 5251 std::swap(A, B); 5252 LLVM_FALLTHROUGH; 5253 case ICmpInst::ICMP_ULT: 5254 // icmp ult i1 A, B -> ~A & B 5255 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5256 5257 case ICmpInst::ICMP_SGT: 5258 // icmp sgt -> icmp slt 5259 std::swap(A, B); 5260 LLVM_FALLTHROUGH; 5261 case ICmpInst::ICMP_SLT: 5262 // icmp slt i1 A, B -> A & ~B 5263 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5264 5265 case ICmpInst::ICMP_UGE: 5266 // icmp uge -> icmp ule 5267 std::swap(A, B); 5268 LLVM_FALLTHROUGH; 5269 case ICmpInst::ICMP_ULE: 5270 // icmp ule i1 A, B -> ~A | B 5271 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5272 5273 case ICmpInst::ICMP_SGE: 5274 // icmp sge -> icmp sle 5275 std::swap(A, B); 5276 LLVM_FALLTHROUGH; 5277 case ICmpInst::ICMP_SLE: 5278 // icmp sle i1 A, B -> A | ~B 5279 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5280 } 5281 } 5282 5283 // Transform pattern like: 5284 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5285 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5286 // Into: 5287 // (X l>> Y) != 0 5288 // (X l>> Y) == 0 5289 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5290 InstCombiner::BuilderTy &Builder) { 5291 ICmpInst::Predicate Pred, NewPred; 5292 Value *X, *Y; 5293 if (match(&Cmp, 5294 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5295 switch (Pred) { 5296 case ICmpInst::ICMP_ULE: 5297 NewPred = ICmpInst::ICMP_NE; 5298 break; 5299 case ICmpInst::ICMP_UGT: 5300 NewPred = ICmpInst::ICMP_EQ; 5301 break; 5302 default: 5303 return nullptr; 5304 } 5305 } else if (match(&Cmp, m_c_ICmp(Pred, 5306 m_OneUse(m_CombineOr( 5307 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5308 m_Add(m_Shl(m_One(), m_Value(Y)), 5309 m_AllOnes()))), 5310 m_Value(X)))) { 5311 // The variant with 'add' is not canonical, (the variant with 'not' is) 5312 // we only get it because it has extra uses, and can't be canonicalized, 5313 5314 switch (Pred) { 5315 case ICmpInst::ICMP_ULT: 5316 NewPred = ICmpInst::ICMP_NE; 5317 break; 5318 case ICmpInst::ICMP_UGE: 5319 NewPred = ICmpInst::ICMP_EQ; 5320 break; 5321 default: 5322 return nullptr; 5323 } 5324 } else 5325 return nullptr; 5326 5327 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5328 Constant *Zero = Constant::getNullValue(NewX->getType()); 5329 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5330 } 5331 5332 static Instruction *foldVectorCmp(CmpInst &Cmp, 5333 InstCombiner::BuilderTy &Builder) { 5334 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5335 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5336 bool IsFP = isa<FCmpInst>(Cmp); 5337 5338 Value *V1, *V2; 5339 Constant *M; 5340 if (!match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M)))) 5341 return nullptr; 5342 5343 // If both arguments of the cmp are shuffles that use the same mask and 5344 // shuffle within a single vector, move the shuffle after the cmp: 5345 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5346 Type *V1Ty = V1->getType(); 5347 if (match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) && 5348 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5349 Value *NewCmp = IsFP ? Builder.CreateFCmp(Pred, V1, V2) 5350 : Builder.CreateICmp(Pred, V1, V2); 5351 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M); 5352 } 5353 5354 // Try to canonicalize compare with splatted operand and splat constant. 5355 // TODO: We could generalize this for more than splats. See/use the code in 5356 // InstCombiner::foldVectorBinop(). 5357 Constant *C; 5358 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5359 return nullptr; 5360 5361 // Length-changing splats are ok, so adjust the constants as needed: 5362 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5363 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5364 Constant *ScalarM = M->getSplatValue(/* AllowUndefs */ true); 5365 if (ScalarC && ScalarM) { 5366 // We allow undefs in matching, but this transform removes those for safety. 5367 // Demanded elements analysis should be able to recover some/all of that. 5368 C = ConstantVector::getSplat(V1Ty->getVectorNumElements(), ScalarC); 5369 M = ConstantVector::getSplat(M->getType()->getVectorNumElements(), ScalarM); 5370 Value *NewCmp = IsFP ? Builder.CreateFCmp(Pred, V1, C) 5371 : Builder.CreateICmp(Pred, V1, C); 5372 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M); 5373 } 5374 5375 return nullptr; 5376 } 5377 5378 // extract(uadd.with.overflow(A, B), 0) ult A 5379 // -> extract(uadd.with.overflow(A, B), 1) 5380 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5381 CmpInst::Predicate Pred = I.getPredicate(); 5382 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5383 5384 Value *UAddOv; 5385 Value *A, *B; 5386 auto UAddOvResultPat = m_ExtractValue<0>( 5387 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5388 if (match(Op0, UAddOvResultPat) && 5389 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5390 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5391 (match(A, m_One()) || match(B, m_One()))) || 5392 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5393 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5394 // extract(uadd.with.overflow(A, B), 0) < A 5395 // extract(uadd.with.overflow(A, 1), 0) == 0 5396 // extract(uadd.with.overflow(A, -1), 0) != -1 5397 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5398 else if (match(Op1, UAddOvResultPat) && 5399 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5400 // A > extract(uadd.with.overflow(A, B), 0) 5401 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5402 else 5403 return nullptr; 5404 5405 return ExtractValueInst::Create(UAddOv, 1); 5406 } 5407 5408 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 5409 bool Changed = false; 5410 const SimplifyQuery Q = SQ.getWithInstruction(&I); 5411 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5412 unsigned Op0Cplxity = getComplexity(Op0); 5413 unsigned Op1Cplxity = getComplexity(Op1); 5414 5415 /// Orders the operands of the compare so that they are listed from most 5416 /// complex to least complex. This puts constants before unary operators, 5417 /// before binary operators. 5418 if (Op0Cplxity < Op1Cplxity || 5419 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 5420 I.swapOperands(); 5421 std::swap(Op0, Op1); 5422 Changed = true; 5423 } 5424 5425 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 5426 return replaceInstUsesWith(I, V); 5427 5428 // Comparing -val or val with non-zero is the same as just comparing val 5429 // ie, abs(val) != 0 -> val != 0 5430 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 5431 Value *Cond, *SelectTrue, *SelectFalse; 5432 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 5433 m_Value(SelectFalse)))) { 5434 if (Value *V = dyn_castNegVal(SelectTrue)) { 5435 if (V == SelectFalse) 5436 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5437 } 5438 else if (Value *V = dyn_castNegVal(SelectFalse)) { 5439 if (V == SelectTrue) 5440 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5441 } 5442 } 5443 } 5444 5445 if (Op0->getType()->isIntOrIntVectorTy(1)) 5446 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 5447 return Res; 5448 5449 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 5450 return NewICmp; 5451 5452 if (Instruction *Res = foldICmpWithConstant(I)) 5453 return Res; 5454 5455 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 5456 return Res; 5457 5458 if (Instruction *Res = foldICmpBinOp(I, Q)) 5459 return Res; 5460 5461 if (Instruction *Res = foldICmpUsingKnownBits(I)) 5462 return Res; 5463 5464 // Test if the ICmpInst instruction is used exclusively by a select as 5465 // part of a minimum or maximum operation. If so, refrain from doing 5466 // any other folding. This helps out other analyses which understand 5467 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5468 // and CodeGen. And in this case, at least one of the comparison 5469 // operands has at least one user besides the compare (the select), 5470 // which would often largely negate the benefit of folding anyway. 5471 // 5472 // Do the same for the other patterns recognized by matchSelectPattern. 5473 if (I.hasOneUse()) 5474 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5475 Value *A, *B; 5476 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5477 if (SPR.Flavor != SPF_UNKNOWN) 5478 return nullptr; 5479 } 5480 5481 // Do this after checking for min/max to prevent infinite looping. 5482 if (Instruction *Res = foldICmpWithZero(I)) 5483 return Res; 5484 5485 // FIXME: We only do this after checking for min/max to prevent infinite 5486 // looping caused by a reverse canonicalization of these patterns for min/max. 5487 // FIXME: The organization of folds is a mess. These would naturally go into 5488 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 5489 // down here after the min/max restriction. 5490 ICmpInst::Predicate Pred = I.getPredicate(); 5491 const APInt *C; 5492 if (match(Op1, m_APInt(C))) { 5493 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 5494 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 5495 Constant *Zero = Constant::getNullValue(Op0->getType()); 5496 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 5497 } 5498 5499 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 5500 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 5501 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 5502 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 5503 } 5504 } 5505 5506 if (Instruction *Res = foldICmpInstWithConstant(I)) 5507 return Res; 5508 5509 // Try to match comparison as a sign bit test. Intentionally do this after 5510 // foldICmpInstWithConstant() to potentially let other folds to happen first. 5511 if (Instruction *New = foldSignBitTest(I)) 5512 return New; 5513 5514 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 5515 return Res; 5516 5517 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 5518 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 5519 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 5520 return NI; 5521 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 5522 if (Instruction *NI = foldGEPICmp(GEP, Op0, 5523 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 5524 return NI; 5525 5526 // Try to optimize equality comparisons against alloca-based pointers. 5527 if (Op0->getType()->isPointerTy() && I.isEquality()) { 5528 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 5529 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 5530 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 5531 return New; 5532 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 5533 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 5534 return New; 5535 } 5536 5537 if (Instruction *Res = foldICmpBitCast(I, Builder)) 5538 return Res; 5539 5540 if (Instruction *R = foldICmpWithCastOp(I)) 5541 return R; 5542 5543 if (Instruction *Res = foldICmpWithMinMax(I)) 5544 return Res; 5545 5546 { 5547 Value *A, *B; 5548 // Transform (A & ~B) == 0 --> (A & B) != 0 5549 // and (A & ~B) != 0 --> (A & B) == 0 5550 // if A is a power of 2. 5551 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 5552 match(Op1, m_Zero()) && 5553 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 5554 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 5555 Op1); 5556 5557 // ~X < ~Y --> Y < X 5558 // ~X < C --> X > ~C 5559 if (match(Op0, m_Not(m_Value(A)))) { 5560 if (match(Op1, m_Not(m_Value(B)))) 5561 return new ICmpInst(I.getPredicate(), B, A); 5562 5563 const APInt *C; 5564 if (match(Op1, m_APInt(C))) 5565 return new ICmpInst(I.getSwappedPredicate(), A, 5566 ConstantInt::get(Op1->getType(), ~(*C))); 5567 } 5568 5569 Instruction *AddI = nullptr; 5570 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 5571 m_Instruction(AddI))) && 5572 isa<IntegerType>(A->getType())) { 5573 Value *Result; 5574 Constant *Overflow; 5575 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B, 5576 *AddI, Result, Overflow)) { 5577 replaceInstUsesWith(*AddI, Result); 5578 return replaceInstUsesWith(I, Overflow); 5579 } 5580 } 5581 5582 // (zext a) * (zext b) --> llvm.umul.with.overflow. 5583 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5584 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 5585 return R; 5586 } 5587 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5588 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 5589 return R; 5590 } 5591 } 5592 5593 if (Instruction *Res = foldICmpEquality(I)) 5594 return Res; 5595 5596 if (Instruction *Res = foldICmpOfUAddOv(I)) 5597 return Res; 5598 5599 // The 'cmpxchg' instruction returns an aggregate containing the old value and 5600 // an i1 which indicates whether or not we successfully did the swap. 5601 // 5602 // Replace comparisons between the old value and the expected value with the 5603 // indicator that 'cmpxchg' returns. 5604 // 5605 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 5606 // spuriously fail. In those cases, the old value may equal the expected 5607 // value but it is possible for the swap to not occur. 5608 if (I.getPredicate() == ICmpInst::ICMP_EQ) 5609 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 5610 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 5611 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 5612 !ACXI->isWeak()) 5613 return ExtractValueInst::Create(ACXI, 1); 5614 5615 { 5616 Value *X; 5617 const APInt *C; 5618 // icmp X+Cst, X 5619 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 5620 return foldICmpAddOpConst(X, *C, I.getPredicate()); 5621 5622 // icmp X, X+Cst 5623 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 5624 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 5625 } 5626 5627 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 5628 return Res; 5629 5630 if (I.getType()->isVectorTy()) 5631 if (Instruction *Res = foldVectorCmp(I, Builder)) 5632 return Res; 5633 5634 return Changed ? &I : nullptr; 5635 } 5636 5637 /// Fold fcmp ([us]itofp x, cst) if possible. 5638 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 5639 Constant *RHSC) { 5640 if (!isa<ConstantFP>(RHSC)) return nullptr; 5641 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 5642 5643 // Get the width of the mantissa. We don't want to hack on conversions that 5644 // might lose information from the integer, e.g. "i64 -> float" 5645 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 5646 if (MantissaWidth == -1) return nullptr; // Unknown. 5647 5648 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 5649 5650 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 5651 5652 if (I.isEquality()) { 5653 FCmpInst::Predicate P = I.getPredicate(); 5654 bool IsExact = false; 5655 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 5656 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 5657 5658 // If the floating point constant isn't an integer value, we know if we will 5659 // ever compare equal / not equal to it. 5660 if (!IsExact) { 5661 // TODO: Can never be -0.0 and other non-representable values 5662 APFloat RHSRoundInt(RHS); 5663 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 5664 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) { 5665 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 5666 return replaceInstUsesWith(I, Builder.getFalse()); 5667 5668 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 5669 return replaceInstUsesWith(I, Builder.getTrue()); 5670 } 5671 } 5672 5673 // TODO: If the constant is exactly representable, is it always OK to do 5674 // equality compares as integer? 5675 } 5676 5677 // Check to see that the input is converted from an integer type that is small 5678 // enough that preserves all bits. TODO: check here for "known" sign bits. 5679 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 5680 unsigned InputSize = IntTy->getScalarSizeInBits(); 5681 5682 // Following test does NOT adjust InputSize downwards for signed inputs, 5683 // because the most negative value still requires all the mantissa bits 5684 // to distinguish it from one less than that value. 5685 if ((int)InputSize > MantissaWidth) { 5686 // Conversion would lose accuracy. Check if loss can impact comparison. 5687 int Exp = ilogb(RHS); 5688 if (Exp == APFloat::IEK_Inf) { 5689 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 5690 if (MaxExponent < (int)InputSize - !LHSUnsigned) 5691 // Conversion could create infinity. 5692 return nullptr; 5693 } else { 5694 // Note that if RHS is zero or NaN, then Exp is negative 5695 // and first condition is trivially false. 5696 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 5697 // Conversion could affect comparison. 5698 return nullptr; 5699 } 5700 } 5701 5702 // Otherwise, we can potentially simplify the comparison. We know that it 5703 // will always come through as an integer value and we know the constant is 5704 // not a NAN (it would have been previously simplified). 5705 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 5706 5707 ICmpInst::Predicate Pred; 5708 switch (I.getPredicate()) { 5709 default: llvm_unreachable("Unexpected predicate!"); 5710 case FCmpInst::FCMP_UEQ: 5711 case FCmpInst::FCMP_OEQ: 5712 Pred = ICmpInst::ICMP_EQ; 5713 break; 5714 case FCmpInst::FCMP_UGT: 5715 case FCmpInst::FCMP_OGT: 5716 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 5717 break; 5718 case FCmpInst::FCMP_UGE: 5719 case FCmpInst::FCMP_OGE: 5720 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 5721 break; 5722 case FCmpInst::FCMP_ULT: 5723 case FCmpInst::FCMP_OLT: 5724 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 5725 break; 5726 case FCmpInst::FCMP_ULE: 5727 case FCmpInst::FCMP_OLE: 5728 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 5729 break; 5730 case FCmpInst::FCMP_UNE: 5731 case FCmpInst::FCMP_ONE: 5732 Pred = ICmpInst::ICMP_NE; 5733 break; 5734 case FCmpInst::FCMP_ORD: 5735 return replaceInstUsesWith(I, Builder.getTrue()); 5736 case FCmpInst::FCMP_UNO: 5737 return replaceInstUsesWith(I, Builder.getFalse()); 5738 } 5739 5740 // Now we know that the APFloat is a normal number, zero or inf. 5741 5742 // See if the FP constant is too large for the integer. For example, 5743 // comparing an i8 to 300.0. 5744 unsigned IntWidth = IntTy->getScalarSizeInBits(); 5745 5746 if (!LHSUnsigned) { 5747 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 5748 // and large values. 5749 APFloat SMax(RHS.getSemantics()); 5750 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 5751 APFloat::rmNearestTiesToEven); 5752 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0 5753 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 5754 Pred == ICmpInst::ICMP_SLE) 5755 return replaceInstUsesWith(I, Builder.getTrue()); 5756 return replaceInstUsesWith(I, Builder.getFalse()); 5757 } 5758 } else { 5759 // If the RHS value is > UnsignedMax, fold the comparison. This handles 5760 // +INF and large values. 5761 APFloat UMax(RHS.getSemantics()); 5762 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 5763 APFloat::rmNearestTiesToEven); 5764 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0 5765 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 5766 Pred == ICmpInst::ICMP_ULE) 5767 return replaceInstUsesWith(I, Builder.getTrue()); 5768 return replaceInstUsesWith(I, Builder.getFalse()); 5769 } 5770 } 5771 5772 if (!LHSUnsigned) { 5773 // See if the RHS value is < SignedMin. 5774 APFloat SMin(RHS.getSemantics()); 5775 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 5776 APFloat::rmNearestTiesToEven); 5777 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0 5778 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 5779 Pred == ICmpInst::ICMP_SGE) 5780 return replaceInstUsesWith(I, Builder.getTrue()); 5781 return replaceInstUsesWith(I, Builder.getFalse()); 5782 } 5783 } else { 5784 // See if the RHS value is < UnsignedMin. 5785 APFloat SMin(RHS.getSemantics()); 5786 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true, 5787 APFloat::rmNearestTiesToEven); 5788 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0 5789 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 5790 Pred == ICmpInst::ICMP_UGE) 5791 return replaceInstUsesWith(I, Builder.getTrue()); 5792 return replaceInstUsesWith(I, Builder.getFalse()); 5793 } 5794 } 5795 5796 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 5797 // [0, UMAX], but it may still be fractional. See if it is fractional by 5798 // casting the FP value to the integer value and back, checking for equality. 5799 // Don't do this for zero, because -0.0 is not fractional. 5800 Constant *RHSInt = LHSUnsigned 5801 ? ConstantExpr::getFPToUI(RHSC, IntTy) 5802 : ConstantExpr::getFPToSI(RHSC, IntTy); 5803 if (!RHS.isZero()) { 5804 bool Equal = LHSUnsigned 5805 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 5806 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 5807 if (!Equal) { 5808 // If we had a comparison against a fractional value, we have to adjust 5809 // the compare predicate and sometimes the value. RHSC is rounded towards 5810 // zero at this point. 5811 switch (Pred) { 5812 default: llvm_unreachable("Unexpected integer comparison!"); 5813 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 5814 return replaceInstUsesWith(I, Builder.getTrue()); 5815 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 5816 return replaceInstUsesWith(I, Builder.getFalse()); 5817 case ICmpInst::ICMP_ULE: 5818 // (float)int <= 4.4 --> int <= 4 5819 // (float)int <= -4.4 --> false 5820 if (RHS.isNegative()) 5821 return replaceInstUsesWith(I, Builder.getFalse()); 5822 break; 5823 case ICmpInst::ICMP_SLE: 5824 // (float)int <= 4.4 --> int <= 4 5825 // (float)int <= -4.4 --> int < -4 5826 if (RHS.isNegative()) 5827 Pred = ICmpInst::ICMP_SLT; 5828 break; 5829 case ICmpInst::ICMP_ULT: 5830 // (float)int < -4.4 --> false 5831 // (float)int < 4.4 --> int <= 4 5832 if (RHS.isNegative()) 5833 return replaceInstUsesWith(I, Builder.getFalse()); 5834 Pred = ICmpInst::ICMP_ULE; 5835 break; 5836 case ICmpInst::ICMP_SLT: 5837 // (float)int < -4.4 --> int < -4 5838 // (float)int < 4.4 --> int <= 4 5839 if (!RHS.isNegative()) 5840 Pred = ICmpInst::ICMP_SLE; 5841 break; 5842 case ICmpInst::ICMP_UGT: 5843 // (float)int > 4.4 --> int > 4 5844 // (float)int > -4.4 --> true 5845 if (RHS.isNegative()) 5846 return replaceInstUsesWith(I, Builder.getTrue()); 5847 break; 5848 case ICmpInst::ICMP_SGT: 5849 // (float)int > 4.4 --> int > 4 5850 // (float)int > -4.4 --> int >= -4 5851 if (RHS.isNegative()) 5852 Pred = ICmpInst::ICMP_SGE; 5853 break; 5854 case ICmpInst::ICMP_UGE: 5855 // (float)int >= -4.4 --> true 5856 // (float)int >= 4.4 --> int > 4 5857 if (RHS.isNegative()) 5858 return replaceInstUsesWith(I, Builder.getTrue()); 5859 Pred = ICmpInst::ICMP_UGT; 5860 break; 5861 case ICmpInst::ICMP_SGE: 5862 // (float)int >= -4.4 --> int >= -4 5863 // (float)int >= 4.4 --> int > 4 5864 if (!RHS.isNegative()) 5865 Pred = ICmpInst::ICMP_SGT; 5866 break; 5867 } 5868 } 5869 } 5870 5871 // Lower this FP comparison into an appropriate integer version of the 5872 // comparison. 5873 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 5874 } 5875 5876 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 5877 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 5878 Constant *RHSC) { 5879 // When C is not 0.0 and infinities are not allowed: 5880 // (C / X) < 0.0 is a sign-bit test of X 5881 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 5882 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 5883 // 5884 // Proof: 5885 // Multiply (C / X) < 0.0 by X * X / C. 5886 // - X is non zero, if it is the flag 'ninf' is violated. 5887 // - C defines the sign of X * X * C. Thus it also defines whether to swap 5888 // the predicate. C is also non zero by definition. 5889 // 5890 // Thus X * X / C is non zero and the transformation is valid. [qed] 5891 5892 FCmpInst::Predicate Pred = I.getPredicate(); 5893 5894 // Check that predicates are valid. 5895 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 5896 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 5897 return nullptr; 5898 5899 // Check that RHS operand is zero. 5900 if (!match(RHSC, m_AnyZeroFP())) 5901 return nullptr; 5902 5903 // Check fastmath flags ('ninf'). 5904 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 5905 return nullptr; 5906 5907 // Check the properties of the dividend. It must not be zero to avoid a 5908 // division by zero (see Proof). 5909 const APFloat *C; 5910 if (!match(LHSI->getOperand(0), m_APFloat(C))) 5911 return nullptr; 5912 5913 if (C->isZero()) 5914 return nullptr; 5915 5916 // Get swapped predicate if necessary. 5917 if (C->isNegative()) 5918 Pred = I.getSwappedPredicate(); 5919 5920 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 5921 } 5922 5923 /// Optimize fabs(X) compared with zero. 5924 static Instruction *foldFabsWithFcmpZero(FCmpInst &I) { 5925 Value *X; 5926 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) || 5927 !match(I.getOperand(1), m_PosZeroFP())) 5928 return nullptr; 5929 5930 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 5931 I->setPredicate(P); 5932 I->setOperand(0, X); 5933 return I; 5934 }; 5935 5936 switch (I.getPredicate()) { 5937 case FCmpInst::FCMP_UGE: 5938 case FCmpInst::FCMP_OLT: 5939 // fabs(X) >= 0.0 --> true 5940 // fabs(X) < 0.0 --> false 5941 llvm_unreachable("fcmp should have simplified"); 5942 5943 case FCmpInst::FCMP_OGT: 5944 // fabs(X) > 0.0 --> X != 0.0 5945 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 5946 5947 case FCmpInst::FCMP_UGT: 5948 // fabs(X) u> 0.0 --> X u!= 0.0 5949 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 5950 5951 case FCmpInst::FCMP_OLE: 5952 // fabs(X) <= 0.0 --> X == 0.0 5953 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 5954 5955 case FCmpInst::FCMP_ULE: 5956 // fabs(X) u<= 0.0 --> X u== 0.0 5957 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 5958 5959 case FCmpInst::FCMP_OGE: 5960 // fabs(X) >= 0.0 --> !isnan(X) 5961 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 5962 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 5963 5964 case FCmpInst::FCMP_ULT: 5965 // fabs(X) u< 0.0 --> isnan(X) 5966 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 5967 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 5968 5969 case FCmpInst::FCMP_OEQ: 5970 case FCmpInst::FCMP_UEQ: 5971 case FCmpInst::FCMP_ONE: 5972 case FCmpInst::FCMP_UNE: 5973 case FCmpInst::FCMP_ORD: 5974 case FCmpInst::FCMP_UNO: 5975 // Look through the fabs() because it doesn't change anything but the sign. 5976 // fabs(X) == 0.0 --> X == 0.0, 5977 // fabs(X) != 0.0 --> X != 0.0 5978 // isnan(fabs(X)) --> isnan(X) 5979 // !isnan(fabs(X) --> !isnan(X) 5980 return replacePredAndOp0(&I, I.getPredicate(), X); 5981 5982 default: 5983 return nullptr; 5984 } 5985 } 5986 5987 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 5988 bool Changed = false; 5989 5990 /// Orders the operands of the compare so that they are listed from most 5991 /// complex to least complex. This puts constants before unary operators, 5992 /// before binary operators. 5993 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 5994 I.swapOperands(); 5995 Changed = true; 5996 } 5997 5998 const CmpInst::Predicate Pred = I.getPredicate(); 5999 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6000 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6001 SQ.getWithInstruction(&I))) 6002 return replaceInstUsesWith(I, V); 6003 6004 // Simplify 'fcmp pred X, X' 6005 Type *OpType = Op0->getType(); 6006 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6007 if (Op0 == Op1) { 6008 switch (Pred) { 6009 default: break; 6010 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6011 case FCmpInst::FCMP_ULT: // True if unordered or less than 6012 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6013 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6014 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6015 I.setPredicate(FCmpInst::FCMP_UNO); 6016 I.setOperand(1, Constant::getNullValue(OpType)); 6017 return &I; 6018 6019 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6020 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6021 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6022 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6023 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6024 I.setPredicate(FCmpInst::FCMP_ORD); 6025 I.setOperand(1, Constant::getNullValue(OpType)); 6026 return &I; 6027 } 6028 } 6029 6030 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6031 // then canonicalize the operand to 0.0. 6032 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6033 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6034 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6035 6036 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6037 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6038 } 6039 6040 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6041 Value *X, *Y; 6042 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6043 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6044 6045 // Test if the FCmpInst instruction is used exclusively by a select as 6046 // part of a minimum or maximum operation. If so, refrain from doing 6047 // any other folding. This helps out other analyses which understand 6048 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6049 // and CodeGen. And in this case, at least one of the comparison 6050 // operands has at least one user besides the compare (the select), 6051 // which would often largely negate the benefit of folding anyway. 6052 if (I.hasOneUse()) 6053 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6054 Value *A, *B; 6055 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6056 if (SPR.Flavor != SPF_UNKNOWN) 6057 return nullptr; 6058 } 6059 6060 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6061 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6062 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6063 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6064 6065 // Handle fcmp with instruction LHS and constant RHS. 6066 Instruction *LHSI; 6067 Constant *RHSC; 6068 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6069 switch (LHSI->getOpcode()) { 6070 case Instruction::PHI: 6071 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6072 // block. If in the same block, we're encouraging jump threading. If 6073 // not, we are just pessimizing the code by making an i1 phi. 6074 if (LHSI->getParent() == I.getParent()) 6075 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6076 return NV; 6077 break; 6078 case Instruction::SIToFP: 6079 case Instruction::UIToFP: 6080 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6081 return NV; 6082 break; 6083 case Instruction::FDiv: 6084 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6085 return NV; 6086 break; 6087 case Instruction::Load: 6088 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6089 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6090 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 6091 !cast<LoadInst>(LHSI)->isVolatile()) 6092 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 6093 return Res; 6094 break; 6095 } 6096 } 6097 6098 if (Instruction *R = foldFabsWithFcmpZero(I)) 6099 return R; 6100 6101 if (match(Op0, m_FNeg(m_Value(X)))) { 6102 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6103 Constant *C; 6104 if (match(Op1, m_Constant(C))) { 6105 Constant *NegC = ConstantExpr::getFNeg(C); 6106 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6107 } 6108 } 6109 6110 if (match(Op0, m_FPExt(m_Value(X)))) { 6111 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6112 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6113 return new FCmpInst(Pred, X, Y, "", &I); 6114 6115 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6116 const APFloat *C; 6117 if (match(Op1, m_APFloat(C))) { 6118 const fltSemantics &FPSem = 6119 X->getType()->getScalarType()->getFltSemantics(); 6120 bool Lossy; 6121 APFloat TruncC = *C; 6122 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6123 6124 // Avoid lossy conversions and denormals. 6125 // Zero is a special case that's OK to convert. 6126 APFloat Fabs = TruncC; 6127 Fabs.clearSign(); 6128 if (!Lossy && 6129 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) != 6130 APFloat::cmpLessThan) || Fabs.isZero())) { 6131 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6132 return new FCmpInst(Pred, X, NewC, "", &I); 6133 } 6134 } 6135 } 6136 6137 if (I.getType()->isVectorTy()) 6138 if (Instruction *Res = foldVectorCmp(I, Builder)) 6139 return Res; 6140 6141 return Changed ? &I : nullptr; 6142 } 6143