1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements the visitICmp and visitFCmp functions. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "InstCombineInternal.h" 15 #include "llvm/ADT/APSInt.h" 16 #include "llvm/ADT/SetVector.h" 17 #include "llvm/ADT/Statistic.h" 18 #include "llvm/Analysis/ConstantFolding.h" 19 #include "llvm/Analysis/InstructionSimplify.h" 20 #include "llvm/Analysis/MemoryBuiltins.h" 21 #include "llvm/Analysis/TargetLibraryInfo.h" 22 #include "llvm/Analysis/VectorUtils.h" 23 #include "llvm/IR/ConstantRange.h" 24 #include "llvm/IR/DataLayout.h" 25 #include "llvm/IR/GetElementPtrTypeIterator.h" 26 #include "llvm/IR/IntrinsicInst.h" 27 #include "llvm/IR/PatternMatch.h" 28 #include "llvm/Support/Debug.h" 29 30 using namespace llvm; 31 using namespace PatternMatch; 32 33 #define DEBUG_TYPE "instcombine" 34 35 // How many times is a select replaced by one of its operands? 36 STATISTIC(NumSel, "Number of select opts"); 37 38 39 static ConstantInt *extractElement(Constant *V, Constant *Idx) { 40 return cast<ConstantInt>(ConstantExpr::getExtractElement(V, Idx)); 41 } 42 43 static bool hasAddOverflow(ConstantInt *Result, 44 ConstantInt *In1, ConstantInt *In2, 45 bool IsSigned) { 46 if (!IsSigned) 47 return Result->getValue().ult(In1->getValue()); 48 49 if (In2->isNegative()) 50 return Result->getValue().sgt(In1->getValue()); 51 return Result->getValue().slt(In1->getValue()); 52 } 53 54 /// Compute Result = In1+In2, returning true if the result overflowed for this 55 /// type. 56 static bool addWithOverflow(Constant *&Result, Constant *In1, 57 Constant *In2, bool IsSigned = false) { 58 Result = ConstantExpr::getAdd(In1, In2); 59 60 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) { 61 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) { 62 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i); 63 if (hasAddOverflow(extractElement(Result, Idx), 64 extractElement(In1, Idx), 65 extractElement(In2, Idx), 66 IsSigned)) 67 return true; 68 } 69 return false; 70 } 71 72 return hasAddOverflow(cast<ConstantInt>(Result), 73 cast<ConstantInt>(In1), cast<ConstantInt>(In2), 74 IsSigned); 75 } 76 77 static bool hasSubOverflow(ConstantInt *Result, 78 ConstantInt *In1, ConstantInt *In2, 79 bool IsSigned) { 80 if (!IsSigned) 81 return Result->getValue().ugt(In1->getValue()); 82 83 if (In2->isNegative()) 84 return Result->getValue().slt(In1->getValue()); 85 86 return Result->getValue().sgt(In1->getValue()); 87 } 88 89 /// Compute Result = In1-In2, returning true if the result overflowed for this 90 /// type. 91 static bool subWithOverflow(Constant *&Result, Constant *In1, 92 Constant *In2, bool IsSigned = false) { 93 Result = ConstantExpr::getSub(In1, In2); 94 95 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) { 96 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) { 97 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i); 98 if (hasSubOverflow(extractElement(Result, Idx), 99 extractElement(In1, Idx), 100 extractElement(In2, Idx), 101 IsSigned)) 102 return true; 103 } 104 return false; 105 } 106 107 return hasSubOverflow(cast<ConstantInt>(Result), 108 cast<ConstantInt>(In1), cast<ConstantInt>(In2), 109 IsSigned); 110 } 111 112 /// Given an icmp instruction, return true if any use of this comparison is a 113 /// branch on sign bit comparison. 114 static bool isBranchOnSignBitCheck(ICmpInst &I, bool isSignBit) { 115 for (auto *U : I.users()) 116 if (isa<BranchInst>(U)) 117 return isSignBit; 118 return false; 119 } 120 121 /// Given an exploded icmp instruction, return true if the comparison only 122 /// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the 123 /// result of the comparison is true when the input value is signed. 124 static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS, 125 bool &TrueIfSigned) { 126 switch (Pred) { 127 case ICmpInst::ICMP_SLT: // True if LHS s< 0 128 TrueIfSigned = true; 129 return RHS == 0; 130 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1 131 TrueIfSigned = true; 132 return RHS.isAllOnesValue(); 133 case ICmpInst::ICMP_SGT: // True if LHS s> -1 134 TrueIfSigned = false; 135 return RHS.isAllOnesValue(); 136 case ICmpInst::ICMP_UGT: 137 // True if LHS u> RHS and RHS == high-bit-mask - 1 138 TrueIfSigned = true; 139 return RHS.isMaxSignedValue(); 140 case ICmpInst::ICMP_UGE: 141 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc) 142 TrueIfSigned = true; 143 return RHS.isSignBit(); 144 default: 145 return false; 146 } 147 } 148 149 /// Returns true if the exploded icmp can be expressed as a signed comparison 150 /// to zero and updates the predicate accordingly. 151 /// The signedness of the comparison is preserved. 152 /// TODO: Refactor with decomposeBitTestICmp()? 153 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 154 if (!ICmpInst::isSigned(Pred)) 155 return false; 156 157 if (C == 0) 158 return ICmpInst::isRelational(Pred); 159 160 if (C == 1) { 161 if (Pred == ICmpInst::ICMP_SLT) { 162 Pred = ICmpInst::ICMP_SLE; 163 return true; 164 } 165 } else if (C.isAllOnesValue()) { 166 if (Pred == ICmpInst::ICMP_SGT) { 167 Pred = ICmpInst::ICMP_SGE; 168 return true; 169 } 170 } 171 172 return false; 173 } 174 175 /// Given a signed integer type and a set of known zero and one bits, compute 176 /// the maximum and minimum values that could have the specified known zero and 177 /// known one bits, returning them in Min/Max. 178 static void computeSignedMinMaxValuesFromKnownBits(const APInt &KnownZero, 179 const APInt &KnownOne, 180 APInt &Min, APInt &Max) { 181 assert(KnownZero.getBitWidth() == KnownOne.getBitWidth() && 182 KnownZero.getBitWidth() == Min.getBitWidth() && 183 KnownZero.getBitWidth() == Max.getBitWidth() && 184 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 185 APInt UnknownBits = ~(KnownZero|KnownOne); 186 187 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 188 // bit if it is unknown. 189 Min = KnownOne; 190 Max = KnownOne|UnknownBits; 191 192 if (UnknownBits.isNegative()) { // Sign bit is unknown 193 Min.setBit(Min.getBitWidth()-1); 194 Max.clearBit(Max.getBitWidth()-1); 195 } 196 } 197 198 /// Given an unsigned integer type and a set of known zero and one bits, compute 199 /// the maximum and minimum values that could have the specified known zero and 200 /// known one bits, returning them in Min/Max. 201 static void computeUnsignedMinMaxValuesFromKnownBits(const APInt &KnownZero, 202 const APInt &KnownOne, 203 APInt &Min, APInt &Max) { 204 assert(KnownZero.getBitWidth() == KnownOne.getBitWidth() && 205 KnownZero.getBitWidth() == Min.getBitWidth() && 206 KnownZero.getBitWidth() == Max.getBitWidth() && 207 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 208 APInt UnknownBits = ~(KnownZero|KnownOne); 209 210 // The minimum value is when the unknown bits are all zeros. 211 Min = KnownOne; 212 // The maximum value is when the unknown bits are all ones. 213 Max = KnownOne|UnknownBits; 214 } 215 216 /// This is called when we see this pattern: 217 /// cmp pred (load (gep GV, ...)), cmpcst 218 /// where GV is a global variable with a constant initializer. Try to simplify 219 /// this into some simple computation that does not need the load. For example 220 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 221 /// 222 /// If AndCst is non-null, then the loaded value is masked with that constant 223 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 224 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 225 GlobalVariable *GV, 226 CmpInst &ICI, 227 ConstantInt *AndCst) { 228 Constant *Init = GV->getInitializer(); 229 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 230 return nullptr; 231 232 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 233 if (ArrayElementCount > 1024) return nullptr; // Don't blow up on huge arrays. 234 235 // There are many forms of this optimization we can handle, for now, just do 236 // the simple index into a single-dimensional array. 237 // 238 // Require: GEP GV, 0, i {{, constant indices}} 239 if (GEP->getNumOperands() < 3 || 240 !isa<ConstantInt>(GEP->getOperand(1)) || 241 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 242 isa<Constant>(GEP->getOperand(2))) 243 return nullptr; 244 245 // Check that indices after the variable are constants and in-range for the 246 // type they index. Collect the indices. This is typically for arrays of 247 // structs. 248 SmallVector<unsigned, 4> LaterIndices; 249 250 Type *EltTy = Init->getType()->getArrayElementType(); 251 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 252 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 253 if (!Idx) return nullptr; // Variable index. 254 255 uint64_t IdxVal = Idx->getZExtValue(); 256 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 257 258 if (StructType *STy = dyn_cast<StructType>(EltTy)) 259 EltTy = STy->getElementType(IdxVal); 260 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 261 if (IdxVal >= ATy->getNumElements()) return nullptr; 262 EltTy = ATy->getElementType(); 263 } else { 264 return nullptr; // Unknown type. 265 } 266 267 LaterIndices.push_back(IdxVal); 268 } 269 270 enum { Overdefined = -3, Undefined = -2 }; 271 272 // Variables for our state machines. 273 274 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 275 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 276 // and 87 is the second (and last) index. FirstTrueElement is -2 when 277 // undefined, otherwise set to the first true element. SecondTrueElement is 278 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 279 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 280 281 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 282 // form "i != 47 & i != 87". Same state transitions as for true elements. 283 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 284 285 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 286 /// define a state machine that triggers for ranges of values that the index 287 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 288 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 289 /// index in the range (inclusive). We use -2 for undefined here because we 290 /// use relative comparisons and don't want 0-1 to match -1. 291 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 292 293 // MagicBitvector - This is a magic bitvector where we set a bit if the 294 // comparison is true for element 'i'. If there are 64 elements or less in 295 // the array, this will fully represent all the comparison results. 296 uint64_t MagicBitvector = 0; 297 298 // Scan the array and see if one of our patterns matches. 299 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 300 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 301 Constant *Elt = Init->getAggregateElement(i); 302 if (!Elt) return nullptr; 303 304 // If this is indexing an array of structures, get the structure element. 305 if (!LaterIndices.empty()) 306 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 307 308 // If the element is masked, handle it. 309 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 310 311 // Find out if the comparison would be true or false for the i'th element. 312 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 313 CompareRHS, DL, &TLI); 314 // If the result is undef for this element, ignore it. 315 if (isa<UndefValue>(C)) { 316 // Extend range state machines to cover this element in case there is an 317 // undef in the middle of the range. 318 if (TrueRangeEnd == (int)i-1) 319 TrueRangeEnd = i; 320 if (FalseRangeEnd == (int)i-1) 321 FalseRangeEnd = i; 322 continue; 323 } 324 325 // If we can't compute the result for any of the elements, we have to give 326 // up evaluating the entire conditional. 327 if (!isa<ConstantInt>(C)) return nullptr; 328 329 // Otherwise, we know if the comparison is true or false for this element, 330 // update our state machines. 331 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 332 333 // State machine for single/double/range index comparison. 334 if (IsTrueForElt) { 335 // Update the TrueElement state machine. 336 if (FirstTrueElement == Undefined) 337 FirstTrueElement = TrueRangeEnd = i; // First true element. 338 else { 339 // Update double-compare state machine. 340 if (SecondTrueElement == Undefined) 341 SecondTrueElement = i; 342 else 343 SecondTrueElement = Overdefined; 344 345 // Update range state machine. 346 if (TrueRangeEnd == (int)i-1) 347 TrueRangeEnd = i; 348 else 349 TrueRangeEnd = Overdefined; 350 } 351 } else { 352 // Update the FalseElement state machine. 353 if (FirstFalseElement == Undefined) 354 FirstFalseElement = FalseRangeEnd = i; // First false element. 355 else { 356 // Update double-compare state machine. 357 if (SecondFalseElement == Undefined) 358 SecondFalseElement = i; 359 else 360 SecondFalseElement = Overdefined; 361 362 // Update range state machine. 363 if (FalseRangeEnd == (int)i-1) 364 FalseRangeEnd = i; 365 else 366 FalseRangeEnd = Overdefined; 367 } 368 } 369 370 // If this element is in range, update our magic bitvector. 371 if (i < 64 && IsTrueForElt) 372 MagicBitvector |= 1ULL << i; 373 374 // If all of our states become overdefined, bail out early. Since the 375 // predicate is expensive, only check it every 8 elements. This is only 376 // really useful for really huge arrays. 377 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 378 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 379 FalseRangeEnd == Overdefined) 380 return nullptr; 381 } 382 383 // Now that we've scanned the entire array, emit our new comparison(s). We 384 // order the state machines in complexity of the generated code. 385 Value *Idx = GEP->getOperand(2); 386 387 // If the index is larger than the pointer size of the target, truncate the 388 // index down like the GEP would do implicitly. We don't have to do this for 389 // an inbounds GEP because the index can't be out of range. 390 if (!GEP->isInBounds()) { 391 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 392 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 393 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 394 Idx = Builder->CreateTrunc(Idx, IntPtrTy); 395 } 396 397 // If the comparison is only true for one or two elements, emit direct 398 // comparisons. 399 if (SecondTrueElement != Overdefined) { 400 // None true -> false. 401 if (FirstTrueElement == Undefined) 402 return replaceInstUsesWith(ICI, Builder->getFalse()); 403 404 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 405 406 // True for one element -> 'i == 47'. 407 if (SecondTrueElement == Undefined) 408 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 409 410 // True for two elements -> 'i == 47 | i == 72'. 411 Value *C1 = Builder->CreateICmpEQ(Idx, FirstTrueIdx); 412 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 413 Value *C2 = Builder->CreateICmpEQ(Idx, SecondTrueIdx); 414 return BinaryOperator::CreateOr(C1, C2); 415 } 416 417 // If the comparison is only false for one or two elements, emit direct 418 // comparisons. 419 if (SecondFalseElement != Overdefined) { 420 // None false -> true. 421 if (FirstFalseElement == Undefined) 422 return replaceInstUsesWith(ICI, Builder->getTrue()); 423 424 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 425 426 // False for one element -> 'i != 47'. 427 if (SecondFalseElement == Undefined) 428 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 429 430 // False for two elements -> 'i != 47 & i != 72'. 431 Value *C1 = Builder->CreateICmpNE(Idx, FirstFalseIdx); 432 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 433 Value *C2 = Builder->CreateICmpNE(Idx, SecondFalseIdx); 434 return BinaryOperator::CreateAnd(C1, C2); 435 } 436 437 // If the comparison can be replaced with a range comparison for the elements 438 // where it is true, emit the range check. 439 if (TrueRangeEnd != Overdefined) { 440 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 441 442 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 443 if (FirstTrueElement) { 444 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 445 Idx = Builder->CreateAdd(Idx, Offs); 446 } 447 448 Value *End = ConstantInt::get(Idx->getType(), 449 TrueRangeEnd-FirstTrueElement+1); 450 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 451 } 452 453 // False range check. 454 if (FalseRangeEnd != Overdefined) { 455 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 456 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 457 if (FirstFalseElement) { 458 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 459 Idx = Builder->CreateAdd(Idx, Offs); 460 } 461 462 Value *End = ConstantInt::get(Idx->getType(), 463 FalseRangeEnd-FirstFalseElement); 464 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 465 } 466 467 // If a magic bitvector captures the entire comparison state 468 // of this load, replace it with computation that does: 469 // ((magic_cst >> i) & 1) != 0 470 { 471 Type *Ty = nullptr; 472 473 // Look for an appropriate type: 474 // - The type of Idx if the magic fits 475 // - The smallest fitting legal type if we have a DataLayout 476 // - Default to i32 477 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 478 Ty = Idx->getType(); 479 else 480 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 481 482 if (Ty) { 483 Value *V = Builder->CreateIntCast(Idx, Ty, false); 484 V = Builder->CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 485 V = Builder->CreateAnd(ConstantInt::get(Ty, 1), V); 486 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 487 } 488 } 489 490 return nullptr; 491 } 492 493 /// Return a value that can be used to compare the *offset* implied by a GEP to 494 /// zero. For example, if we have &A[i], we want to return 'i' for 495 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 496 /// are involved. The above expression would also be legal to codegen as 497 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 498 /// This latter form is less amenable to optimization though, and we are allowed 499 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 500 /// 501 /// If we can't emit an optimized form for this expression, this returns null. 502 /// 503 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 504 const DataLayout &DL) { 505 gep_type_iterator GTI = gep_type_begin(GEP); 506 507 // Check to see if this gep only has a single variable index. If so, and if 508 // any constant indices are a multiple of its scale, then we can compute this 509 // in terms of the scale of the variable index. For example, if the GEP 510 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 511 // because the expression will cross zero at the same point. 512 unsigned i, e = GEP->getNumOperands(); 513 int64_t Offset = 0; 514 for (i = 1; i != e; ++i, ++GTI) { 515 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 516 // Compute the aggregate offset of constant indices. 517 if (CI->isZero()) continue; 518 519 // Handle a struct index, which adds its field offset to the pointer. 520 if (StructType *STy = GTI.getStructTypeOrNull()) { 521 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 522 } else { 523 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 524 Offset += Size*CI->getSExtValue(); 525 } 526 } else { 527 // Found our variable index. 528 break; 529 } 530 } 531 532 // If there are no variable indices, we must have a constant offset, just 533 // evaluate it the general way. 534 if (i == e) return nullptr; 535 536 Value *VariableIdx = GEP->getOperand(i); 537 // Determine the scale factor of the variable element. For example, this is 538 // 4 if the variable index is into an array of i32. 539 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 540 541 // Verify that there are no other variable indices. If so, emit the hard way. 542 for (++i, ++GTI; i != e; ++i, ++GTI) { 543 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 544 if (!CI) return nullptr; 545 546 // Compute the aggregate offset of constant indices. 547 if (CI->isZero()) continue; 548 549 // Handle a struct index, which adds its field offset to the pointer. 550 if (StructType *STy = GTI.getStructTypeOrNull()) { 551 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 552 } else { 553 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 554 Offset += Size*CI->getSExtValue(); 555 } 556 } 557 558 // Okay, we know we have a single variable index, which must be a 559 // pointer/array/vector index. If there is no offset, life is simple, return 560 // the index. 561 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 562 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 563 if (Offset == 0) { 564 // Cast to intptrty in case a truncation occurs. If an extension is needed, 565 // we don't need to bother extending: the extension won't affect where the 566 // computation crosses zero. 567 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 568 VariableIdx = IC.Builder->CreateTrunc(VariableIdx, IntPtrTy); 569 } 570 return VariableIdx; 571 } 572 573 // Otherwise, there is an index. The computation we will do will be modulo 574 // the pointer size, so get it. 575 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth); 576 577 Offset &= PtrSizeMask; 578 VariableScale &= PtrSizeMask; 579 580 // To do this transformation, any constant index must be a multiple of the 581 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 582 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 583 // multiple of the variable scale. 584 int64_t NewOffs = Offset / (int64_t)VariableScale; 585 if (Offset != NewOffs*(int64_t)VariableScale) 586 return nullptr; 587 588 // Okay, we can do this evaluation. Start by converting the index to intptr. 589 if (VariableIdx->getType() != IntPtrTy) 590 VariableIdx = IC.Builder->CreateIntCast(VariableIdx, IntPtrTy, 591 true /*Signed*/); 592 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 593 return IC.Builder->CreateAdd(VariableIdx, OffsetVal, "offset"); 594 } 595 596 /// Returns true if we can rewrite Start as a GEP with pointer Base 597 /// and some integer offset. The nodes that need to be re-written 598 /// for this transformation will be added to Explored. 599 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 600 const DataLayout &DL, 601 SetVector<Value *> &Explored) { 602 SmallVector<Value *, 16> WorkList(1, Start); 603 Explored.insert(Base); 604 605 // The following traversal gives us an order which can be used 606 // when doing the final transformation. Since in the final 607 // transformation we create the PHI replacement instructions first, 608 // we don't have to get them in any particular order. 609 // 610 // However, for other instructions we will have to traverse the 611 // operands of an instruction first, which means that we have to 612 // do a post-order traversal. 613 while (!WorkList.empty()) { 614 SetVector<PHINode *> PHIs; 615 616 while (!WorkList.empty()) { 617 if (Explored.size() >= 100) 618 return false; 619 620 Value *V = WorkList.back(); 621 622 if (Explored.count(V) != 0) { 623 WorkList.pop_back(); 624 continue; 625 } 626 627 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 628 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 629 // We've found some value that we can't explore which is different from 630 // the base. Therefore we can't do this transformation. 631 return false; 632 633 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 634 auto *CI = dyn_cast<CastInst>(V); 635 if (!CI->isNoopCast(DL)) 636 return false; 637 638 if (Explored.count(CI->getOperand(0)) == 0) 639 WorkList.push_back(CI->getOperand(0)); 640 } 641 642 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 643 // We're limiting the GEP to having one index. This will preserve 644 // the original pointer type. We could handle more cases in the 645 // future. 646 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 647 GEP->getType() != Start->getType()) 648 return false; 649 650 if (Explored.count(GEP->getOperand(0)) == 0) 651 WorkList.push_back(GEP->getOperand(0)); 652 } 653 654 if (WorkList.back() == V) { 655 WorkList.pop_back(); 656 // We've finished visiting this node, mark it as such. 657 Explored.insert(V); 658 } 659 660 if (auto *PN = dyn_cast<PHINode>(V)) { 661 // We cannot transform PHIs on unsplittable basic blocks. 662 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 663 return false; 664 Explored.insert(PN); 665 PHIs.insert(PN); 666 } 667 } 668 669 // Explore the PHI nodes further. 670 for (auto *PN : PHIs) 671 for (Value *Op : PN->incoming_values()) 672 if (Explored.count(Op) == 0) 673 WorkList.push_back(Op); 674 } 675 676 // Make sure that we can do this. Since we can't insert GEPs in a basic 677 // block before a PHI node, we can't easily do this transformation if 678 // we have PHI node users of transformed instructions. 679 for (Value *Val : Explored) { 680 for (Value *Use : Val->uses()) { 681 682 auto *PHI = dyn_cast<PHINode>(Use); 683 auto *Inst = dyn_cast<Instruction>(Val); 684 685 if (Inst == Base || Inst == PHI || !Inst || !PHI || 686 Explored.count(PHI) == 0) 687 continue; 688 689 if (PHI->getParent() == Inst->getParent()) 690 return false; 691 } 692 } 693 return true; 694 } 695 696 // Sets the appropriate insert point on Builder where we can add 697 // a replacement Instruction for V (if that is possible). 698 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 699 bool Before = true) { 700 if (auto *PHI = dyn_cast<PHINode>(V)) { 701 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 702 return; 703 } 704 if (auto *I = dyn_cast<Instruction>(V)) { 705 if (!Before) 706 I = &*std::next(I->getIterator()); 707 Builder.SetInsertPoint(I); 708 return; 709 } 710 if (auto *A = dyn_cast<Argument>(V)) { 711 // Set the insertion point in the entry block. 712 BasicBlock &Entry = A->getParent()->getEntryBlock(); 713 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 714 return; 715 } 716 // Otherwise, this is a constant and we don't need to set a new 717 // insertion point. 718 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 719 } 720 721 /// Returns a re-written value of Start as an indexed GEP using Base as a 722 /// pointer. 723 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 724 const DataLayout &DL, 725 SetVector<Value *> &Explored) { 726 // Perform all the substitutions. This is a bit tricky because we can 727 // have cycles in our use-def chains. 728 // 1. Create the PHI nodes without any incoming values. 729 // 2. Create all the other values. 730 // 3. Add the edges for the PHI nodes. 731 // 4. Emit GEPs to get the original pointers. 732 // 5. Remove the original instructions. 733 Type *IndexType = IntegerType::get( 734 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType())); 735 736 DenseMap<Value *, Value *> NewInsts; 737 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 738 739 // Create the new PHI nodes, without adding any incoming values. 740 for (Value *Val : Explored) { 741 if (Val == Base) 742 continue; 743 // Create empty phi nodes. This avoids cyclic dependencies when creating 744 // the remaining instructions. 745 if (auto *PHI = dyn_cast<PHINode>(Val)) 746 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 747 PHI->getName() + ".idx", PHI); 748 } 749 IRBuilder<> Builder(Base->getContext()); 750 751 // Create all the other instructions. 752 for (Value *Val : Explored) { 753 754 if (NewInsts.find(Val) != NewInsts.end()) 755 continue; 756 757 if (auto *CI = dyn_cast<CastInst>(Val)) { 758 NewInsts[CI] = NewInsts[CI->getOperand(0)]; 759 continue; 760 } 761 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 762 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 763 : GEP->getOperand(1); 764 setInsertionPoint(Builder, GEP); 765 // Indices might need to be sign extended. GEPs will magically do 766 // this, but we need to do it ourselves here. 767 if (Index->getType()->getScalarSizeInBits() != 768 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 769 Index = Builder.CreateSExtOrTrunc( 770 Index, NewInsts[GEP->getOperand(0)]->getType(), 771 GEP->getOperand(0)->getName() + ".sext"); 772 } 773 774 auto *Op = NewInsts[GEP->getOperand(0)]; 775 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero()) 776 NewInsts[GEP] = Index; 777 else 778 NewInsts[GEP] = Builder.CreateNSWAdd( 779 Op, Index, GEP->getOperand(0)->getName() + ".add"); 780 continue; 781 } 782 if (isa<PHINode>(Val)) 783 continue; 784 785 llvm_unreachable("Unexpected instruction type"); 786 } 787 788 // Add the incoming values to the PHI nodes. 789 for (Value *Val : Explored) { 790 if (Val == Base) 791 continue; 792 // All the instructions have been created, we can now add edges to the 793 // phi nodes. 794 if (auto *PHI = dyn_cast<PHINode>(Val)) { 795 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 796 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 797 Value *NewIncoming = PHI->getIncomingValue(I); 798 799 if (NewInsts.find(NewIncoming) != NewInsts.end()) 800 NewIncoming = NewInsts[NewIncoming]; 801 802 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 803 } 804 } 805 } 806 807 for (Value *Val : Explored) { 808 if (Val == Base) 809 continue; 810 811 // Depending on the type, for external users we have to emit 812 // a GEP or a GEP + ptrtoint. 813 setInsertionPoint(Builder, Val, false); 814 815 // If required, create an inttoptr instruction for Base. 816 Value *NewBase = Base; 817 if (!Base->getType()->isPointerTy()) 818 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 819 Start->getName() + "to.ptr"); 820 821 Value *GEP = Builder.CreateInBoundsGEP( 822 Start->getType()->getPointerElementType(), NewBase, 823 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 824 825 if (!Val->getType()->isPointerTy()) { 826 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 827 Val->getName() + ".conv"); 828 GEP = Cast; 829 } 830 Val->replaceAllUsesWith(GEP); 831 } 832 833 return NewInsts[Start]; 834 } 835 836 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 837 /// the input Value as a constant indexed GEP. Returns a pair containing 838 /// the GEPs Pointer and Index. 839 static std::pair<Value *, Value *> 840 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 841 Type *IndexType = IntegerType::get(V->getContext(), 842 DL.getPointerTypeSizeInBits(V->getType())); 843 844 Constant *Index = ConstantInt::getNullValue(IndexType); 845 while (true) { 846 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 847 // We accept only inbouds GEPs here to exclude the possibility of 848 // overflow. 849 if (!GEP->isInBounds()) 850 break; 851 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 852 GEP->getType() == V->getType()) { 853 V = GEP->getOperand(0); 854 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 855 Index = ConstantExpr::getAdd( 856 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 857 continue; 858 } 859 break; 860 } 861 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 862 if (!CI->isNoopCast(DL)) 863 break; 864 V = CI->getOperand(0); 865 continue; 866 } 867 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 868 if (!CI->isNoopCast(DL)) 869 break; 870 V = CI->getOperand(0); 871 continue; 872 } 873 break; 874 } 875 return {V, Index}; 876 } 877 878 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 879 /// We can look through PHIs, GEPs and casts in order to determine a common base 880 /// between GEPLHS and RHS. 881 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 882 ICmpInst::Predicate Cond, 883 const DataLayout &DL) { 884 if (!GEPLHS->hasAllConstantIndices()) 885 return nullptr; 886 887 Value *PtrBase, *Index; 888 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 889 890 // The set of nodes that will take part in this transformation. 891 SetVector<Value *> Nodes; 892 893 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 894 return nullptr; 895 896 // We know we can re-write this as 897 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 898 // Since we've only looked through inbouds GEPs we know that we 899 // can't have overflow on either side. We can therefore re-write 900 // this as: 901 // OFFSET1 cmp OFFSET2 902 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 903 904 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 905 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 906 // offset. Since Index is the offset of LHS to the base pointer, we will now 907 // compare the offsets instead of comparing the pointers. 908 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 909 } 910 911 /// Fold comparisons between a GEP instruction and something else. At this point 912 /// we know that the GEP is on the LHS of the comparison. 913 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 914 ICmpInst::Predicate Cond, 915 Instruction &I) { 916 // Don't transform signed compares of GEPs into index compares. Even if the 917 // GEP is inbounds, the final add of the base pointer can have signed overflow 918 // and would change the result of the icmp. 919 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 920 // the maximum signed value for the pointer type. 921 if (ICmpInst::isSigned(Cond)) 922 return nullptr; 923 924 // Look through bitcasts and addrspacecasts. We do not however want to remove 925 // 0 GEPs. 926 if (!isa<GetElementPtrInst>(RHS)) 927 RHS = RHS->stripPointerCasts(); 928 929 Value *PtrBase = GEPLHS->getOperand(0); 930 if (PtrBase == RHS && GEPLHS->isInBounds()) { 931 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 932 // This transformation (ignoring the base and scales) is valid because we 933 // know pointers can't overflow since the gep is inbounds. See if we can 934 // output an optimized form. 935 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 936 937 // If not, synthesize the offset the hard way. 938 if (!Offset) 939 Offset = EmitGEPOffset(GEPLHS); 940 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 941 Constant::getNullValue(Offset->getType())); 942 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 943 // If the base pointers are different, but the indices are the same, just 944 // compare the base pointer. 945 if (PtrBase != GEPRHS->getOperand(0)) { 946 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 947 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 948 GEPRHS->getOperand(0)->getType(); 949 if (IndicesTheSame) 950 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 951 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 952 IndicesTheSame = false; 953 break; 954 } 955 956 // If all indices are the same, just compare the base pointers. 957 if (IndicesTheSame) 958 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 959 960 // If we're comparing GEPs with two base pointers that only differ in type 961 // and both GEPs have only constant indices or just one use, then fold 962 // the compare with the adjusted indices. 963 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 964 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 965 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 966 PtrBase->stripPointerCasts() == 967 GEPRHS->getOperand(0)->stripPointerCasts()) { 968 Value *LOffset = EmitGEPOffset(GEPLHS); 969 Value *ROffset = EmitGEPOffset(GEPRHS); 970 971 // If we looked through an addrspacecast between different sized address 972 // spaces, the LHS and RHS pointers are different sized 973 // integers. Truncate to the smaller one. 974 Type *LHSIndexTy = LOffset->getType(); 975 Type *RHSIndexTy = ROffset->getType(); 976 if (LHSIndexTy != RHSIndexTy) { 977 if (LHSIndexTy->getPrimitiveSizeInBits() < 978 RHSIndexTy->getPrimitiveSizeInBits()) { 979 ROffset = Builder->CreateTrunc(ROffset, LHSIndexTy); 980 } else 981 LOffset = Builder->CreateTrunc(LOffset, RHSIndexTy); 982 } 983 984 Value *Cmp = Builder->CreateICmp(ICmpInst::getSignedPredicate(Cond), 985 LOffset, ROffset); 986 return replaceInstUsesWith(I, Cmp); 987 } 988 989 // Otherwise, the base pointers are different and the indices are 990 // different. Try convert this to an indexed compare by looking through 991 // PHIs/casts. 992 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 993 } 994 995 // If one of the GEPs has all zero indices, recurse. 996 if (GEPLHS->hasAllZeroIndices()) 997 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 998 ICmpInst::getSwappedPredicate(Cond), I); 999 1000 // If the other GEP has all zero indices, recurse. 1001 if (GEPRHS->hasAllZeroIndices()) 1002 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 1003 1004 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 1005 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 1006 // If the GEPs only differ by one index, compare it. 1007 unsigned NumDifferences = 0; // Keep track of # differences. 1008 unsigned DiffOperand = 0; // The operand that differs. 1009 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 1010 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 1011 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() != 1012 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) { 1013 // Irreconcilable differences. 1014 NumDifferences = 2; 1015 break; 1016 } else { 1017 if (NumDifferences++) break; 1018 DiffOperand = i; 1019 } 1020 } 1021 1022 if (NumDifferences == 0) // SAME GEP? 1023 return replaceInstUsesWith(I, // No comparison is needed here. 1024 Builder->getInt1(ICmpInst::isTrueWhenEqual(Cond))); 1025 1026 else if (NumDifferences == 1 && GEPsInBounds) { 1027 Value *LHSV = GEPLHS->getOperand(DiffOperand); 1028 Value *RHSV = GEPRHS->getOperand(DiffOperand); 1029 // Make sure we do a signed comparison here. 1030 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 1031 } 1032 } 1033 1034 // Only lower this if the icmp is the only user of the GEP or if we expect 1035 // the result to fold to a constant! 1036 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 1037 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 1038 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 1039 Value *L = EmitGEPOffset(GEPLHS); 1040 Value *R = EmitGEPOffset(GEPRHS); 1041 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1042 } 1043 } 1044 1045 // Try convert this to an indexed compare by looking through PHIs/casts as a 1046 // last resort. 1047 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1048 } 1049 1050 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1051 const AllocaInst *Alloca, 1052 const Value *Other) { 1053 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1054 1055 // It would be tempting to fold away comparisons between allocas and any 1056 // pointer not based on that alloca (e.g. an argument). However, even 1057 // though such pointers cannot alias, they can still compare equal. 1058 // 1059 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1060 // doesn't escape we can argue that it's impossible to guess its value, and we 1061 // can therefore act as if any such guesses are wrong. 1062 // 1063 // The code below checks that the alloca doesn't escape, and that it's only 1064 // used in a comparison once (the current instruction). The 1065 // single-comparison-use condition ensures that we're trivially folding all 1066 // comparisons against the alloca consistently, and avoids the risk of 1067 // erroneously folding a comparison of the pointer with itself. 1068 1069 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1070 1071 SmallVector<const Use *, 32> Worklist; 1072 for (const Use &U : Alloca->uses()) { 1073 if (Worklist.size() >= MaxIter) 1074 return nullptr; 1075 Worklist.push_back(&U); 1076 } 1077 1078 unsigned NumCmps = 0; 1079 while (!Worklist.empty()) { 1080 assert(Worklist.size() <= MaxIter); 1081 const Use *U = Worklist.pop_back_val(); 1082 const Value *V = U->getUser(); 1083 --MaxIter; 1084 1085 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1086 isa<SelectInst>(V)) { 1087 // Track the uses. 1088 } else if (isa<LoadInst>(V)) { 1089 // Loading from the pointer doesn't escape it. 1090 continue; 1091 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1092 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1093 if (SI->getValueOperand() == U->get()) 1094 return nullptr; 1095 continue; 1096 } else if (isa<ICmpInst>(V)) { 1097 if (NumCmps++) 1098 return nullptr; // Found more than one cmp. 1099 continue; 1100 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1101 switch (Intrin->getIntrinsicID()) { 1102 // These intrinsics don't escape or compare the pointer. Memset is safe 1103 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1104 // we don't allow stores, so src cannot point to V. 1105 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1106 case Intrinsic::dbg_declare: case Intrinsic::dbg_value: 1107 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1108 continue; 1109 default: 1110 return nullptr; 1111 } 1112 } else { 1113 return nullptr; 1114 } 1115 for (const Use &U : V->uses()) { 1116 if (Worklist.size() >= MaxIter) 1117 return nullptr; 1118 Worklist.push_back(&U); 1119 } 1120 } 1121 1122 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1123 return replaceInstUsesWith( 1124 ICI, 1125 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1126 } 1127 1128 /// Fold "icmp pred (X+CI), X". 1129 Instruction *InstCombiner::foldICmpAddOpConst(Instruction &ICI, 1130 Value *X, ConstantInt *CI, 1131 ICmpInst::Predicate Pred) { 1132 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1133 // so the values can never be equal. Similarly for all other "or equals" 1134 // operators. 1135 1136 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1137 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1138 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1139 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1140 Value *R = 1141 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI); 1142 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1143 } 1144 1145 // (X+1) >u X --> X <u (0-1) --> X != 255 1146 // (X+2) >u X --> X <u (0-2) --> X <u 254 1147 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1148 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1149 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI)); 1150 1151 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits(); 1152 ConstantInt *SMax = ConstantInt::get(X->getContext(), 1153 APInt::getSignedMaxValue(BitWidth)); 1154 1155 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1156 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1157 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1158 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1159 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1160 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1161 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1162 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI)); 1163 1164 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1165 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1166 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1167 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1168 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1169 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1170 1171 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1172 Constant *C = Builder->getInt(CI->getValue()-1); 1173 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C)); 1174 } 1175 1176 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1177 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1178 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1179 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1180 const APInt &AP1, 1181 const APInt &AP2) { 1182 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1183 1184 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1185 if (I.getPredicate() == I.ICMP_NE) 1186 Pred = CmpInst::getInversePredicate(Pred); 1187 return new ICmpInst(Pred, LHS, RHS); 1188 }; 1189 1190 // Don't bother doing any work for cases which InstSimplify handles. 1191 if (AP2 == 0) 1192 return nullptr; 1193 1194 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1195 if (IsAShr) { 1196 if (AP2.isAllOnesValue()) 1197 return nullptr; 1198 if (AP2.isNegative() != AP1.isNegative()) 1199 return nullptr; 1200 if (AP2.sgt(AP1)) 1201 return nullptr; 1202 } 1203 1204 if (!AP1) 1205 // 'A' must be large enough to shift out the highest set bit. 1206 return getICmp(I.ICMP_UGT, A, 1207 ConstantInt::get(A->getType(), AP2.logBase2())); 1208 1209 if (AP1 == AP2) 1210 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1211 1212 int Shift; 1213 if (IsAShr && AP1.isNegative()) 1214 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1215 else 1216 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1217 1218 if (Shift > 0) { 1219 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1220 // There are multiple solutions if we are comparing against -1 and the LHS 1221 // of the ashr is not a power of two. 1222 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1223 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1224 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1225 } else if (AP1 == AP2.lshr(Shift)) { 1226 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1227 } 1228 } 1229 1230 // Shifting const2 will never be equal to const1. 1231 // FIXME: This should always be handled by InstSimplify? 1232 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1233 return replaceInstUsesWith(I, TorF); 1234 } 1235 1236 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1237 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1238 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1239 const APInt &AP1, 1240 const APInt &AP2) { 1241 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1242 1243 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1244 if (I.getPredicate() == I.ICMP_NE) 1245 Pred = CmpInst::getInversePredicate(Pred); 1246 return new ICmpInst(Pred, LHS, RHS); 1247 }; 1248 1249 // Don't bother doing any work for cases which InstSimplify handles. 1250 if (AP2 == 0) 1251 return nullptr; 1252 1253 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1254 1255 if (!AP1 && AP2TrailingZeros != 0) 1256 return getICmp( 1257 I.ICMP_UGE, A, 1258 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1259 1260 if (AP1 == AP2) 1261 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1262 1263 // Get the distance between the lowest bits that are set. 1264 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1265 1266 if (Shift > 0 && AP2.shl(Shift) == AP1) 1267 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1268 1269 // Shifting const2 will never be equal to const1. 1270 // FIXME: This should always be handled by InstSimplify? 1271 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1272 return replaceInstUsesWith(I, TorF); 1273 } 1274 1275 /// The caller has matched a pattern of the form: 1276 /// I = icmp ugt (add (add A, B), CI2), CI1 1277 /// If this is of the form: 1278 /// sum = a + b 1279 /// if (sum+128 >u 255) 1280 /// Then replace it with llvm.sadd.with.overflow.i8. 1281 /// 1282 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1283 ConstantInt *CI2, ConstantInt *CI1, 1284 InstCombiner &IC) { 1285 // The transformation we're trying to do here is to transform this into an 1286 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1287 // with a narrower add, and discard the add-with-constant that is part of the 1288 // range check (if we can't eliminate it, this isn't profitable). 1289 1290 // In order to eliminate the add-with-constant, the compare can be its only 1291 // use. 1292 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1293 if (!AddWithCst->hasOneUse()) 1294 return nullptr; 1295 1296 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1297 if (!CI2->getValue().isPowerOf2()) 1298 return nullptr; 1299 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1300 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1301 return nullptr; 1302 1303 // The width of the new add formed is 1 more than the bias. 1304 ++NewWidth; 1305 1306 // Check to see that CI1 is an all-ones value with NewWidth bits. 1307 if (CI1->getBitWidth() == NewWidth || 1308 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1309 return nullptr; 1310 1311 // This is only really a signed overflow check if the inputs have been 1312 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1313 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1314 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1315 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1316 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1317 return nullptr; 1318 1319 // In order to replace the original add with a narrower 1320 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1321 // and truncates that discard the high bits of the add. Verify that this is 1322 // the case. 1323 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1324 for (User *U : OrigAdd->users()) { 1325 if (U == AddWithCst) 1326 continue; 1327 1328 // Only accept truncates for now. We would really like a nice recursive 1329 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1330 // chain to see which bits of a value are actually demanded. If the 1331 // original add had another add which was then immediately truncated, we 1332 // could still do the transformation. 1333 TruncInst *TI = dyn_cast<TruncInst>(U); 1334 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1335 return nullptr; 1336 } 1337 1338 // If the pattern matches, truncate the inputs to the narrower type and 1339 // use the sadd_with_overflow intrinsic to efficiently compute both the 1340 // result and the overflow bit. 1341 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1342 Value *F = Intrinsic::getDeclaration(I.getModule(), 1343 Intrinsic::sadd_with_overflow, NewType); 1344 1345 InstCombiner::BuilderTy *Builder = IC.Builder; 1346 1347 // Put the new code above the original add, in case there are any uses of the 1348 // add between the add and the compare. 1349 Builder->SetInsertPoint(OrigAdd); 1350 1351 Value *TruncA = Builder->CreateTrunc(A, NewType, A->getName() + ".trunc"); 1352 Value *TruncB = Builder->CreateTrunc(B, NewType, B->getName() + ".trunc"); 1353 CallInst *Call = Builder->CreateCall(F, {TruncA, TruncB}, "sadd"); 1354 Value *Add = Builder->CreateExtractValue(Call, 0, "sadd.result"); 1355 Value *ZExt = Builder->CreateZExt(Add, OrigAdd->getType()); 1356 1357 // The inner add was the result of the narrow add, zero extended to the 1358 // wider type. Replace it with the result computed by the intrinsic. 1359 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1360 1361 // The original icmp gets replaced with the overflow value. 1362 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1363 } 1364 1365 // Fold icmp Pred X, C. 1366 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1367 CmpInst::Predicate Pred = Cmp.getPredicate(); 1368 Value *X = Cmp.getOperand(0); 1369 1370 const APInt *C; 1371 if (!match(Cmp.getOperand(1), m_APInt(C))) 1372 return nullptr; 1373 1374 Value *A = nullptr, *B = nullptr; 1375 1376 // Match the following pattern, which is a common idiom when writing 1377 // overflow-safe integer arithmetic functions. The source performs an addition 1378 // in wider type and explicitly checks for overflow using comparisons against 1379 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1380 // 1381 // TODO: This could probably be generalized to handle other overflow-safe 1382 // operations if we worked out the formulas to compute the appropriate magic 1383 // constants. 1384 // 1385 // sum = a + b 1386 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1387 { 1388 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1389 if (Pred == ICmpInst::ICMP_UGT && 1390 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1391 if (Instruction *Res = processUGT_ADDCST_ADD( 1392 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this)) 1393 return Res; 1394 } 1395 1396 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1397 if (*C == 0 && Pred == ICmpInst::ICMP_SGT) { 1398 SelectPatternResult SPR = matchSelectPattern(X, A, B); 1399 if (SPR.Flavor == SPF_SMIN) { 1400 if (isKnownPositive(A, DL)) 1401 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1402 if (isKnownPositive(B, DL)) 1403 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1404 } 1405 } 1406 1407 // FIXME: Use m_APInt to allow folds for splat constants. 1408 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1)); 1409 if (!CI) 1410 return nullptr; 1411 1412 // Canonicalize icmp instructions based on dominating conditions. 1413 BasicBlock *Parent = Cmp.getParent(); 1414 BasicBlock *Dom = Parent->getSinglePredecessor(); 1415 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr; 1416 ICmpInst::Predicate Pred2; 1417 BasicBlock *TrueBB, *FalseBB; 1418 ConstantInt *CI2; 1419 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)), 1420 TrueBB, FalseBB)) && 1421 TrueBB != FalseBB) { 1422 ConstantRange CR = 1423 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue()); 1424 ConstantRange DominatingCR = 1425 (Parent == TrueBB) 1426 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue()) 1427 : ConstantRange::makeExactICmpRegion( 1428 CmpInst::getInversePredicate(Pred2), CI2->getValue()); 1429 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1430 ConstantRange Difference = DominatingCR.difference(CR); 1431 if (Intersection.isEmptySet()) 1432 return replaceInstUsesWith(Cmp, Builder->getFalse()); 1433 if (Difference.isEmptySet()) 1434 return replaceInstUsesWith(Cmp, Builder->getTrue()); 1435 1436 // If this is a normal comparison, it demands all bits. If it is a sign 1437 // bit comparison, it only demands the sign bit. 1438 bool UnusedBit; 1439 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit); 1440 1441 // Canonicalizing a sign bit comparison that gets used in a branch, 1442 // pessimizes codegen by generating branch on zero instruction instead 1443 // of a test and branch. So we avoid canonicalizing in such situations 1444 // because test and branch instruction has better branch displacement 1445 // than compare and branch instruction. 1446 if (!isBranchOnSignBitCheck(Cmp, IsSignBit) && !Cmp.isEquality()) { 1447 if (auto *AI = Intersection.getSingleElement()) 1448 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder->getInt(*AI)); 1449 if (auto *AD = Difference.getSingleElement()) 1450 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder->getInt(*AD)); 1451 } 1452 } 1453 1454 return nullptr; 1455 } 1456 1457 /// Fold icmp (trunc X, Y), C. 1458 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1459 Instruction *Trunc, 1460 const APInt *C) { 1461 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1462 Value *X = Trunc->getOperand(0); 1463 if (*C == 1 && C->getBitWidth() > 1) { 1464 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1465 Value *V = nullptr; 1466 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1467 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1468 ConstantInt::get(V->getType(), 1)); 1469 } 1470 1471 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1472 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1473 // of the high bits truncated out of x are known. 1474 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1475 SrcBits = X->getType()->getScalarSizeInBits(); 1476 APInt KnownZero(SrcBits, 0), KnownOne(SrcBits, 0); 1477 computeKnownBits(X, KnownZero, KnownOne, 0, &Cmp); 1478 1479 // If all the high bits are known, we can do this xform. 1480 if ((KnownZero | KnownOne).countLeadingOnes() >= SrcBits - DstBits) { 1481 // Pull in the high bits from known-ones set. 1482 APInt NewRHS = C->zext(SrcBits); 1483 NewRHS |= KnownOne & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1484 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1485 } 1486 } 1487 1488 return nullptr; 1489 } 1490 1491 /// Fold icmp (xor X, Y), C. 1492 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1493 BinaryOperator *Xor, 1494 const APInt *C) { 1495 Value *X = Xor->getOperand(0); 1496 Value *Y = Xor->getOperand(1); 1497 const APInt *XorC; 1498 if (!match(Y, m_APInt(XorC))) 1499 return nullptr; 1500 1501 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1502 // fold the xor. 1503 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1504 if ((Pred == ICmpInst::ICMP_SLT && *C == 0) || 1505 (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())) { 1506 1507 // If the sign bit of the XorCst is not set, there is no change to 1508 // the operation, just stop using the Xor. 1509 if (!XorC->isNegative()) { 1510 Cmp.setOperand(0, X); 1511 Worklist.Add(Xor); 1512 return &Cmp; 1513 } 1514 1515 // Was the old condition true if the operand is positive? 1516 bool isTrueIfPositive = Pred == ICmpInst::ICMP_SGT; 1517 1518 // If so, the new one isn't. 1519 isTrueIfPositive ^= true; 1520 1521 Constant *CmpConstant = cast<Constant>(Cmp.getOperand(1)); 1522 if (isTrueIfPositive) 1523 return new ICmpInst(ICmpInst::ICMP_SGT, X, SubOne(CmpConstant)); 1524 else 1525 return new ICmpInst(ICmpInst::ICMP_SLT, X, AddOne(CmpConstant)); 1526 } 1527 1528 if (Xor->hasOneUse()) { 1529 // (icmp u/s (xor X SignBit), C) -> (icmp s/u X, (xor C SignBit)) 1530 if (!Cmp.isEquality() && XorC->isSignBit()) { 1531 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1532 : Cmp.getSignedPredicate(); 1533 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC)); 1534 } 1535 1536 // (icmp u/s (xor X ~SignBit), C) -> (icmp s/u X, (xor C ~SignBit)) 1537 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1538 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1539 : Cmp.getSignedPredicate(); 1540 Pred = Cmp.getSwappedPredicate(Pred); 1541 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC)); 1542 } 1543 } 1544 1545 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C) 1546 // iff -C is a power of 2 1547 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~(*C) && (*C + 1).isPowerOf2()) 1548 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1549 1550 // (icmp ult (xor X, C), -C) -> (icmp uge X, C) 1551 // iff -C is a power of 2 1552 if (Pred == ICmpInst::ICMP_ULT && *XorC == -(*C) && C->isPowerOf2()) 1553 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 1554 1555 return nullptr; 1556 } 1557 1558 /// Fold icmp (and (sh X, Y), C2), C1. 1559 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1560 const APInt *C1, const APInt *C2) { 1561 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1562 if (!Shift || !Shift->isShift()) 1563 return nullptr; 1564 1565 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1566 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1567 // code produced by the clang front-end, for bitfield access. 1568 // This seemingly simple opportunity to fold away a shift turns out to be 1569 // rather complicated. See PR17827 for details. 1570 unsigned ShiftOpcode = Shift->getOpcode(); 1571 bool IsShl = ShiftOpcode == Instruction::Shl; 1572 const APInt *C3; 1573 if (match(Shift->getOperand(1), m_APInt(C3))) { 1574 bool CanFold = false; 1575 if (ShiftOpcode == Instruction::AShr) { 1576 // There may be some constraints that make this possible, but nothing 1577 // simple has been discovered yet. 1578 CanFold = false; 1579 } else if (ShiftOpcode == Instruction::Shl) { 1580 // For a left shift, we can fold if the comparison is not signed. We can 1581 // also fold a signed comparison if the mask value and comparison value 1582 // are not negative. These constraints may not be obvious, but we can 1583 // prove that they are correct using an SMT solver. 1584 if (!Cmp.isSigned() || (!C2->isNegative() && !C1->isNegative())) 1585 CanFold = true; 1586 } else if (ShiftOpcode == Instruction::LShr) { 1587 // For a logical right shift, we can fold if the comparison is not signed. 1588 // We can also fold a signed comparison if the shifted mask value and the 1589 // shifted comparison value are not negative. These constraints may not be 1590 // obvious, but we can prove that they are correct using an SMT solver. 1591 if (!Cmp.isSigned() || 1592 (!C2->shl(*C3).isNegative() && !C1->shl(*C3).isNegative())) 1593 CanFold = true; 1594 } 1595 1596 if (CanFold) { 1597 APInt NewCst = IsShl ? C1->lshr(*C3) : C1->shl(*C3); 1598 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3); 1599 // Check to see if we are shifting out any of the bits being compared. 1600 if (SameAsC1 != *C1) { 1601 // If we shifted bits out, the fold is not going to work out. As a 1602 // special case, check to see if this means that the result is always 1603 // true or false now. 1604 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1605 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1606 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1607 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1608 } else { 1609 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst)); 1610 APInt NewAndCst = IsShl ? C2->lshr(*C3) : C2->shl(*C3); 1611 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst)); 1612 And->setOperand(0, Shift->getOperand(0)); 1613 Worklist.Add(Shift); // Shift is dead. 1614 return &Cmp; 1615 } 1616 } 1617 } 1618 1619 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1620 // preferable because it allows the C2 << Y expression to be hoisted out of a 1621 // loop if Y is invariant and X is not. 1622 if (Shift->hasOneUse() && *C1 == 0 && Cmp.isEquality() && 1623 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1624 // Compute C2 << Y. 1625 Value *NewShift = 1626 IsShl ? Builder->CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1627 : Builder->CreateShl(And->getOperand(1), Shift->getOperand(1)); 1628 1629 // Compute X & (C2 << Y). 1630 Value *NewAnd = Builder->CreateAnd(Shift->getOperand(0), NewShift); 1631 Cmp.setOperand(0, NewAnd); 1632 return &Cmp; 1633 } 1634 1635 return nullptr; 1636 } 1637 1638 /// Fold icmp (and X, C2), C1. 1639 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1640 BinaryOperator *And, 1641 const APInt *C1) { 1642 const APInt *C2; 1643 if (!match(And->getOperand(1), m_APInt(C2))) 1644 return nullptr; 1645 1646 if (!And->hasOneUse() || !And->getOperand(0)->hasOneUse()) 1647 return nullptr; 1648 1649 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1650 // the input width without changing the value produced, eliminate the cast: 1651 // 1652 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1653 // 1654 // We can do this transformation if the constants do not have their sign bits 1655 // set or if it is an equality comparison. Extending a relational comparison 1656 // when we're checking the sign bit would not work. 1657 Value *W; 1658 if (match(And->getOperand(0), m_Trunc(m_Value(W))) && 1659 (Cmp.isEquality() || (!C1->isNegative() && !C2->isNegative()))) { 1660 // TODO: Is this a good transform for vectors? Wider types may reduce 1661 // throughput. Should this transform be limited (even for scalars) by using 1662 // ShouldChangeType()? 1663 if (!Cmp.getType()->isVectorTy()) { 1664 Type *WideType = W->getType(); 1665 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1666 Constant *ZextC1 = ConstantInt::get(WideType, C1->zext(WideScalarBits)); 1667 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1668 Value *NewAnd = Builder->CreateAnd(W, ZextC2, And->getName()); 1669 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1670 } 1671 } 1672 1673 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, C2)) 1674 return I; 1675 1676 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1677 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1678 // 1679 // iff pred isn't signed 1680 if (!Cmp.isSigned() && *C1 == 0 && match(And->getOperand(1), m_One())) { 1681 Constant *One = cast<Constant>(And->getOperand(1)); 1682 Value *Or = And->getOperand(0); 1683 Value *A, *B, *LShr; 1684 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1685 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1686 unsigned UsesRemoved = 0; 1687 if (And->hasOneUse()) 1688 ++UsesRemoved; 1689 if (Or->hasOneUse()) 1690 ++UsesRemoved; 1691 if (LShr->hasOneUse()) 1692 ++UsesRemoved; 1693 1694 // Compute A & ((1 << B) | 1) 1695 Value *NewOr = nullptr; 1696 if (auto *C = dyn_cast<Constant>(B)) { 1697 if (UsesRemoved >= 1) 1698 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1699 } else { 1700 if (UsesRemoved >= 3) 1701 NewOr = Builder->CreateOr(Builder->CreateShl(One, B, LShr->getName(), 1702 /*HasNUW=*/true), 1703 One, Or->getName()); 1704 } 1705 if (NewOr) { 1706 Value *NewAnd = Builder->CreateAnd(A, NewOr, And->getName()); 1707 Cmp.setOperand(0, NewAnd); 1708 return &Cmp; 1709 } 1710 } 1711 } 1712 1713 // (X & C2) > C1 --> (X & C2) != 0, if any bit set in (X & C2) will produce a 1714 // result greater than C1. 1715 unsigned NumTZ = C2->countTrailingZeros(); 1716 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && NumTZ < C2->getBitWidth() && 1717 APInt::getOneBitSet(C2->getBitWidth(), NumTZ).ugt(*C1)) { 1718 Constant *Zero = Constant::getNullValue(And->getType()); 1719 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero); 1720 } 1721 1722 return nullptr; 1723 } 1724 1725 /// Fold icmp (and X, Y), C. 1726 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1727 BinaryOperator *And, 1728 const APInt *C) { 1729 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1730 return I; 1731 1732 // TODO: These all require that Y is constant too, so refactor with the above. 1733 1734 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1735 Value *X = And->getOperand(0); 1736 Value *Y = And->getOperand(1); 1737 if (auto *LI = dyn_cast<LoadInst>(X)) 1738 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1739 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1740 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1741 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1742 ConstantInt *C2 = cast<ConstantInt>(Y); 1743 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1744 return Res; 1745 } 1746 1747 if (!Cmp.isEquality()) 1748 return nullptr; 1749 1750 // X & -C == -C -> X > u ~C 1751 // X & -C != -C -> X <= u ~C 1752 // iff C is a power of 2 1753 if (Cmp.getOperand(1) == Y && (-(*C)).isPowerOf2()) { 1754 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1755 : CmpInst::ICMP_ULE; 1756 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1757 } 1758 1759 // (X & C2) == 0 -> (trunc X) >= 0 1760 // (X & C2) != 0 -> (trunc X) < 0 1761 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1762 const APInt *C2; 1763 if (And->hasOneUse() && *C == 0 && match(Y, m_APInt(C2))) { 1764 int32_t ExactLogBase2 = C2->exactLogBase2(); 1765 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1766 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1767 if (And->getType()->isVectorTy()) 1768 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements()); 1769 Value *Trunc = Builder->CreateTrunc(X, NTy); 1770 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1771 : CmpInst::ICMP_SLT; 1772 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1773 } 1774 } 1775 1776 return nullptr; 1777 } 1778 1779 /// Fold icmp (or X, Y), C. 1780 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1781 const APInt *C) { 1782 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1783 if (*C == 1) { 1784 // icmp slt signum(V) 1 --> icmp slt V, 1 1785 Value *V = nullptr; 1786 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1787 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1788 ConstantInt::get(V->getType(), 1)); 1789 } 1790 1791 if (!Cmp.isEquality() || *C != 0 || !Or->hasOneUse()) 1792 return nullptr; 1793 1794 Value *P, *Q; 1795 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1796 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1797 // -> and (icmp eq P, null), (icmp eq Q, null). 1798 Value *CmpP = 1799 Builder->CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1800 Value *CmpQ = 1801 Builder->CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1802 auto LogicOpc = Pred == ICmpInst::Predicate::ICMP_EQ ? Instruction::And 1803 : Instruction::Or; 1804 return BinaryOperator::Create(LogicOpc, CmpP, CmpQ); 1805 } 1806 1807 return nullptr; 1808 } 1809 1810 /// Fold icmp (mul X, Y), C. 1811 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1812 BinaryOperator *Mul, 1813 const APInt *C) { 1814 const APInt *MulC; 1815 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1816 return nullptr; 1817 1818 // If this is a test of the sign bit and the multiply is sign-preserving with 1819 // a constant operand, use the multiply LHS operand instead. 1820 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1821 if (isSignTest(Pred, *C) && Mul->hasNoSignedWrap()) { 1822 if (MulC->isNegative()) 1823 Pred = ICmpInst::getSwappedPredicate(Pred); 1824 return new ICmpInst(Pred, Mul->getOperand(0), 1825 Constant::getNullValue(Mul->getType())); 1826 } 1827 1828 return nullptr; 1829 } 1830 1831 /// Fold icmp (shl 1, Y), C. 1832 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1833 const APInt *C) { 1834 Value *Y; 1835 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1836 return nullptr; 1837 1838 Type *ShiftType = Shl->getType(); 1839 uint32_t TypeBits = C->getBitWidth(); 1840 bool CIsPowerOf2 = C->isPowerOf2(); 1841 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1842 if (Cmp.isUnsigned()) { 1843 // (1 << Y) pred C -> Y pred Log2(C) 1844 if (!CIsPowerOf2) { 1845 // (1 << Y) < 30 -> Y <= 4 1846 // (1 << Y) <= 30 -> Y <= 4 1847 // (1 << Y) >= 30 -> Y > 4 1848 // (1 << Y) > 30 -> Y > 4 1849 if (Pred == ICmpInst::ICMP_ULT) 1850 Pred = ICmpInst::ICMP_ULE; 1851 else if (Pred == ICmpInst::ICMP_UGE) 1852 Pred = ICmpInst::ICMP_UGT; 1853 } 1854 1855 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1856 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1857 unsigned CLog2 = C->logBase2(); 1858 if (CLog2 == TypeBits - 1) { 1859 if (Pred == ICmpInst::ICMP_UGE) 1860 Pred = ICmpInst::ICMP_EQ; 1861 else if (Pred == ICmpInst::ICMP_ULT) 1862 Pred = ICmpInst::ICMP_NE; 1863 } 1864 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1865 } else if (Cmp.isSigned()) { 1866 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1867 if (C->isAllOnesValue()) { 1868 // (1 << Y) <= -1 -> Y == 31 1869 if (Pred == ICmpInst::ICMP_SLE) 1870 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1871 1872 // (1 << Y) > -1 -> Y != 31 1873 if (Pred == ICmpInst::ICMP_SGT) 1874 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1875 } else if (!(*C)) { 1876 // (1 << Y) < 0 -> Y == 31 1877 // (1 << Y) <= 0 -> Y == 31 1878 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1879 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1880 1881 // (1 << Y) >= 0 -> Y != 31 1882 // (1 << Y) > 0 -> Y != 31 1883 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 1884 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1885 } 1886 } else if (Cmp.isEquality() && CIsPowerOf2) { 1887 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C->logBase2())); 1888 } 1889 1890 return nullptr; 1891 } 1892 1893 /// Fold icmp (shl X, Y), C. 1894 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 1895 BinaryOperator *Shl, 1896 const APInt *C) { 1897 const APInt *ShiftVal; 1898 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 1899 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), *C, *ShiftVal); 1900 1901 const APInt *ShiftAmt; 1902 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 1903 return foldICmpShlOne(Cmp, Shl, C); 1904 1905 // Check that the shift amount is in range. If not, don't perform undefined 1906 // shifts. When the shift is visited it will be simplified. 1907 unsigned TypeBits = C->getBitWidth(); 1908 if (ShiftAmt->uge(TypeBits)) 1909 return nullptr; 1910 1911 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1912 Value *X = Shl->getOperand(0); 1913 if (Cmp.isEquality()) { 1914 // If the shift is NUW, then it is just shifting out zeros, no need for an 1915 // AND. 1916 Constant *LShrC = ConstantInt::get(Shl->getType(), C->lshr(*ShiftAmt)); 1917 if (Shl->hasNoUnsignedWrap()) 1918 return new ICmpInst(Pred, X, LShrC); 1919 1920 // If the shift is NSW and we compare to 0, then it is just shifting out 1921 // sign bits, no need for an AND either. 1922 if (Shl->hasNoSignedWrap() && *C == 0) 1923 return new ICmpInst(Pred, X, LShrC); 1924 1925 if (Shl->hasOneUse()) { 1926 // Otherwise strength reduce the shift into an and. 1927 Constant *Mask = ConstantInt::get(Shl->getType(), 1928 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 1929 1930 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask"); 1931 return new ICmpInst(Pred, And, LShrC); 1932 } 1933 } 1934 1935 // If this is a signed comparison to 0 and the shift is sign preserving, 1936 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 1937 // do that if we're sure to not continue on in this function. 1938 if (Shl->hasNoSignedWrap() && isSignTest(Pred, *C)) 1939 return new ICmpInst(Pred, X, Constant::getNullValue(X->getType())); 1940 1941 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 1942 bool TrueIfSigned = false; 1943 if (Shl->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) { 1944 // (X << 31) <s 0 --> (X & 1) != 0 1945 Constant *Mask = ConstantInt::get( 1946 X->getType(), 1947 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 1948 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask"); 1949 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 1950 And, Constant::getNullValue(And->getType())); 1951 } 1952 1953 // When the shift is nuw and pred is >u or <=u, comparison only really happens 1954 // in the pre-shifted bits. Since InstSimplify canoncalizes <=u into <u, the 1955 // <=u case can be further converted to match <u (see below). 1956 if (Shl->hasNoUnsignedWrap() && 1957 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT)) { 1958 // Derivation for the ult case: 1959 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 1960 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 1961 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 1962 assert((Pred != ICmpInst::ICMP_ULT || C->ugt(0)) && 1963 "Encountered `ult 0` that should have been eliminated by " 1964 "InstSimplify."); 1965 APInt ShiftedC = Pred == ICmpInst::ICMP_ULT ? (*C - 1).lshr(*ShiftAmt) + 1 1966 : C->lshr(*ShiftAmt); 1967 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), ShiftedC)); 1968 } 1969 1970 // Transform (icmp pred iM (shl iM %v, N), C) 1971 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 1972 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 1973 // This enables us to get rid of the shift in favor of a trunc which can be 1974 // free on the target. It has the additional benefit of comparing to a 1975 // smaller constant, which will be target friendly. 1976 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 1977 if (Shl->hasOneUse() && Amt != 0 && C->countTrailingZeros() >= Amt && 1978 DL.isLegalInteger(TypeBits - Amt)) { 1979 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 1980 if (X->getType()->isVectorTy()) 1981 TruncTy = VectorType::get(TruncTy, X->getType()->getVectorNumElements()); 1982 Constant *NewC = 1983 ConstantInt::get(TruncTy, C->ashr(*ShiftAmt).trunc(TypeBits - Amt)); 1984 return new ICmpInst(Pred, Builder->CreateTrunc(X, TruncTy), NewC); 1985 } 1986 1987 return nullptr; 1988 } 1989 1990 /// Fold icmp ({al}shr X, Y), C. 1991 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 1992 BinaryOperator *Shr, 1993 const APInt *C) { 1994 // An exact shr only shifts out zero bits, so: 1995 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 1996 Value *X = Shr->getOperand(0); 1997 CmpInst::Predicate Pred = Cmp.getPredicate(); 1998 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && *C == 0) 1999 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2000 2001 const APInt *ShiftVal; 2002 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2003 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), *C, *ShiftVal); 2004 2005 const APInt *ShiftAmt; 2006 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2007 return nullptr; 2008 2009 // Check that the shift amount is in range. If not, don't perform undefined 2010 // shifts. When the shift is visited it will be simplified. 2011 unsigned TypeBits = C->getBitWidth(); 2012 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2013 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2014 return nullptr; 2015 2016 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2017 if (!Cmp.isEquality()) { 2018 // If we have an unsigned comparison and an ashr, we can't simplify this. 2019 // Similarly for signed comparisons with lshr. 2020 if (Cmp.isSigned() != IsAShr) 2021 return nullptr; 2022 2023 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv 2024 // by a power of 2. Since we already have logic to simplify these, 2025 // transform to div and then simplify the resultant comparison. 2026 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1)) 2027 return nullptr; 2028 2029 // Revisit the shift (to delete it). 2030 Worklist.Add(Shr); 2031 2032 Constant *DivCst = ConstantInt::get( 2033 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal)); 2034 2035 Value *Tmp = IsAShr ? Builder->CreateSDiv(X, DivCst, "", Shr->isExact()) 2036 : Builder->CreateUDiv(X, DivCst, "", Shr->isExact()); 2037 2038 Cmp.setOperand(0, Tmp); 2039 2040 // If the builder folded the binop, just return it. 2041 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp); 2042 if (!TheDiv) 2043 return &Cmp; 2044 2045 // Otherwise, fold this div/compare. 2046 assert(TheDiv->getOpcode() == Instruction::SDiv || 2047 TheDiv->getOpcode() == Instruction::UDiv); 2048 2049 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C); 2050 assert(Res && "This div/cst should have folded!"); 2051 return Res; 2052 } 2053 2054 // Handle equality comparisons of shift-by-constant. 2055 2056 // If the comparison constant changes with the shift, the comparison cannot 2057 // succeed (bits of the comparison constant cannot match the shifted value). 2058 // This should be known by InstSimplify and already be folded to true/false. 2059 assert(((IsAShr && C->shl(ShAmtVal).ashr(ShAmtVal) == *C) || 2060 (!IsAShr && C->shl(ShAmtVal).lshr(ShAmtVal) == *C)) && 2061 "Expected icmp+shr simplify did not occur."); 2062 2063 // Check if the bits shifted out are known to be zero. If so, we can compare 2064 // against the unshifted value: 2065 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2066 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), *C << ShAmtVal); 2067 if (Shr->hasOneUse()) { 2068 if (Shr->isExact()) 2069 return new ICmpInst(Pred, X, ShiftedCmpRHS); 2070 2071 // Otherwise strength reduce the shift into an 'and'. 2072 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2073 Constant *Mask = ConstantInt::get(Shr->getType(), Val); 2074 Value *And = Builder->CreateAnd(X, Mask, Shr->getName() + ".mask"); 2075 return new ICmpInst(Pred, And, ShiftedCmpRHS); 2076 } 2077 2078 return nullptr; 2079 } 2080 2081 /// Fold icmp (udiv X, Y), C. 2082 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2083 BinaryOperator *UDiv, 2084 const APInt *C) { 2085 const APInt *C2; 2086 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2087 return nullptr; 2088 2089 assert(C2 != 0 && "udiv 0, X should have been simplified already."); 2090 2091 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2092 Value *Y = UDiv->getOperand(1); 2093 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2094 assert(!C->isMaxValue() && 2095 "icmp ugt X, UINT_MAX should have been simplified already."); 2096 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2097 ConstantInt::get(Y->getType(), C2->udiv(*C + 1))); 2098 } 2099 2100 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2101 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2102 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2103 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2104 ConstantInt::get(Y->getType(), C2->udiv(*C))); 2105 } 2106 2107 return nullptr; 2108 } 2109 2110 /// Fold icmp ({su}div X, Y), C. 2111 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2112 BinaryOperator *Div, 2113 const APInt *C) { 2114 // Fold: icmp pred ([us]div X, C2), C -> range test 2115 // Fold this div into the comparison, producing a range check. 2116 // Determine, based on the divide type, what the range is being 2117 // checked. If there is an overflow on the low or high side, remember 2118 // it, otherwise compute the range [low, hi) bounding the new value. 2119 // See: InsertRangeTest above for the kinds of replacements possible. 2120 const APInt *C2; 2121 if (!match(Div->getOperand(1), m_APInt(C2))) 2122 return nullptr; 2123 2124 // FIXME: If the operand types don't match the type of the divide 2125 // then don't attempt this transform. The code below doesn't have the 2126 // logic to deal with a signed divide and an unsigned compare (and 2127 // vice versa). This is because (x /s C2) <s C produces different 2128 // results than (x /s C2) <u C or (x /u C2) <s C or even 2129 // (x /u C2) <u C. Simply casting the operands and result won't 2130 // work. :( The if statement below tests that condition and bails 2131 // if it finds it. 2132 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2133 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2134 return nullptr; 2135 2136 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2137 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2138 // division-by-constant cases should be present, we can not assert that they 2139 // have happened before we reach this icmp instruction. 2140 if (*C2 == 0 || *C2 == 1 || (DivIsSigned && C2->isAllOnesValue())) 2141 return nullptr; 2142 2143 // TODO: We could do all of the computations below using APInt. 2144 Constant *CmpRHS = cast<Constant>(Cmp.getOperand(1)); 2145 Constant *DivRHS = cast<Constant>(Div->getOperand(1)); 2146 2147 // Compute Prod = CmpRHS * DivRHS. We are essentially solving an equation of 2148 // form X / C2 = C. We solve for X by multiplying C2 (DivRHS) and C (CmpRHS). 2149 // By solving for X, we can turn this into a range check instead of computing 2150 // a divide. 2151 Constant *Prod = ConstantExpr::getMul(CmpRHS, DivRHS); 2152 2153 // Determine if the product overflows by seeing if the product is not equal to 2154 // the divide. Make sure we do the same kind of divide as in the LHS 2155 // instruction that we're folding. 2156 bool ProdOV = (DivIsSigned ? ConstantExpr::getSDiv(Prod, DivRHS) 2157 : ConstantExpr::getUDiv(Prod, DivRHS)) != CmpRHS; 2158 2159 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2160 2161 // If the division is known to be exact, then there is no remainder from the 2162 // divide, so the covered range size is unit, otherwise it is the divisor. 2163 Constant *RangeSize = 2164 Div->isExact() ? ConstantInt::get(Div->getType(), 1) : DivRHS; 2165 2166 // Figure out the interval that is being checked. For example, a comparison 2167 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2168 // Compute this interval based on the constants involved and the signedness of 2169 // the compare/divide. This computes a half-open interval, keeping track of 2170 // whether either value in the interval overflows. After analysis each 2171 // overflow variable is set to 0 if it's corresponding bound variable is valid 2172 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2173 int LoOverflow = 0, HiOverflow = 0; 2174 Constant *LoBound = nullptr, *HiBound = nullptr; 2175 2176 if (!DivIsSigned) { // udiv 2177 // e.g. X/5 op 3 --> [15, 20) 2178 LoBound = Prod; 2179 HiOverflow = LoOverflow = ProdOV; 2180 if (!HiOverflow) { 2181 // If this is not an exact divide, then many values in the range collapse 2182 // to the same result value. 2183 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2184 } 2185 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2186 if (*C == 0) { // (X / pos) op 0 2187 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2188 LoBound = ConstantExpr::getNeg(SubOne(RangeSize)); 2189 HiBound = RangeSize; 2190 } else if (C->isStrictlyPositive()) { // (X / pos) op pos 2191 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2192 HiOverflow = LoOverflow = ProdOV; 2193 if (!HiOverflow) 2194 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2195 } else { // (X / pos) op neg 2196 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2197 HiBound = AddOne(Prod); 2198 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2199 if (!LoOverflow) { 2200 Constant *DivNeg = ConstantExpr::getNeg(RangeSize); 2201 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2202 } 2203 } 2204 } else if (C2->isNegative()) { // Divisor is < 0. 2205 if (Div->isExact()) 2206 RangeSize = ConstantExpr::getNeg(RangeSize); 2207 if (*C == 0) { // (X / neg) op 0 2208 // e.g. X/-5 op 0 --> [-4, 5) 2209 LoBound = AddOne(RangeSize); 2210 HiBound = ConstantExpr::getNeg(RangeSize); 2211 if (HiBound == DivRHS) { // -INTMIN = INTMIN 2212 HiOverflow = 1; // [INTMIN+1, overflow) 2213 HiBound = nullptr; // e.g. X/INTMIN = 0 --> X > INTMIN 2214 } 2215 } else if (C->isStrictlyPositive()) { // (X / neg) op pos 2216 // e.g. X/-5 op 3 --> [-19, -14) 2217 HiBound = AddOne(Prod); 2218 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2219 if (!LoOverflow) 2220 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2221 } else { // (X / neg) op neg 2222 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2223 LoOverflow = HiOverflow = ProdOV; 2224 if (!HiOverflow) 2225 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2226 } 2227 2228 // Dividing by a negative swaps the condition. LT <-> GT 2229 Pred = ICmpInst::getSwappedPredicate(Pred); 2230 } 2231 2232 Value *X = Div->getOperand(0); 2233 switch (Pred) { 2234 default: llvm_unreachable("Unhandled icmp opcode!"); 2235 case ICmpInst::ICMP_EQ: 2236 if (LoOverflow && HiOverflow) 2237 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2238 if (HiOverflow) 2239 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2240 ICmpInst::ICMP_UGE, X, LoBound); 2241 if (LoOverflow) 2242 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2243 ICmpInst::ICMP_ULT, X, HiBound); 2244 return replaceInstUsesWith( 2245 Cmp, insertRangeTest(X, LoBound->getUniqueInteger(), 2246 HiBound->getUniqueInteger(), DivIsSigned, true)); 2247 case ICmpInst::ICMP_NE: 2248 if (LoOverflow && HiOverflow) 2249 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2250 if (HiOverflow) 2251 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2252 ICmpInst::ICMP_ULT, X, LoBound); 2253 if (LoOverflow) 2254 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2255 ICmpInst::ICMP_UGE, X, HiBound); 2256 return replaceInstUsesWith(Cmp, 2257 insertRangeTest(X, LoBound->getUniqueInteger(), 2258 HiBound->getUniqueInteger(), 2259 DivIsSigned, false)); 2260 case ICmpInst::ICMP_ULT: 2261 case ICmpInst::ICMP_SLT: 2262 if (LoOverflow == +1) // Low bound is greater than input range. 2263 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2264 if (LoOverflow == -1) // Low bound is less than input range. 2265 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2266 return new ICmpInst(Pred, X, LoBound); 2267 case ICmpInst::ICMP_UGT: 2268 case ICmpInst::ICMP_SGT: 2269 if (HiOverflow == +1) // High bound greater than input range. 2270 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2271 if (HiOverflow == -1) // High bound less than input range. 2272 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2273 if (Pred == ICmpInst::ICMP_UGT) 2274 return new ICmpInst(ICmpInst::ICMP_UGE, X, HiBound); 2275 return new ICmpInst(ICmpInst::ICMP_SGE, X, HiBound); 2276 } 2277 2278 return nullptr; 2279 } 2280 2281 /// Fold icmp (sub X, Y), C. 2282 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2283 BinaryOperator *Sub, 2284 const APInt *C) { 2285 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2286 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2287 2288 // The following transforms are only worth it if the only user of the subtract 2289 // is the icmp. 2290 if (!Sub->hasOneUse()) 2291 return nullptr; 2292 2293 if (Sub->hasNoSignedWrap()) { 2294 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2295 if (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue()) 2296 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2297 2298 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2299 if (Pred == ICmpInst::ICMP_SGT && *C == 0) 2300 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2301 2302 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2303 if (Pred == ICmpInst::ICMP_SLT && *C == 0) 2304 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2305 2306 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2307 if (Pred == ICmpInst::ICMP_SLT && *C == 1) 2308 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2309 } 2310 2311 const APInt *C2; 2312 if (!match(X, m_APInt(C2))) 2313 return nullptr; 2314 2315 // C2 - Y <u C -> (Y | (C - 1)) == C2 2316 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2317 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() && 2318 (*C2 & (*C - 1)) == (*C - 1)) 2319 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateOr(Y, *C - 1), X); 2320 2321 // C2 - Y >u C -> (Y | C) != C2 2322 // iff C2 & C == C and C + 1 is a power of 2 2323 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == *C) 2324 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateOr(Y, *C), X); 2325 2326 return nullptr; 2327 } 2328 2329 /// Fold icmp (add X, Y), C. 2330 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2331 BinaryOperator *Add, 2332 const APInt *C) { 2333 Value *Y = Add->getOperand(1); 2334 const APInt *C2; 2335 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2336 return nullptr; 2337 2338 // Fold icmp pred (add X, C2), C. 2339 Value *X = Add->getOperand(0); 2340 Type *Ty = Add->getType(); 2341 auto CR = 2342 ConstantRange::makeExactICmpRegion(Cmp.getPredicate(), *C).subtract(*C2); 2343 const APInt &Upper = CR.getUpper(); 2344 const APInt &Lower = CR.getLower(); 2345 if (Cmp.isSigned()) { 2346 if (Lower.isSignBit()) 2347 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2348 if (Upper.isSignBit()) 2349 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2350 } else { 2351 if (Lower.isMinValue()) 2352 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2353 if (Upper.isMinValue()) 2354 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2355 } 2356 2357 if (!Add->hasOneUse()) 2358 return nullptr; 2359 2360 // X+C <u C2 -> (X & -C2) == C 2361 // iff C & (C2-1) == 0 2362 // C2 is a power of 2 2363 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && C->isPowerOf2() && 2364 (*C2 & (*C - 1)) == 0) 2365 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateAnd(X, -(*C)), 2366 ConstantExpr::getNeg(cast<Constant>(Y))); 2367 2368 // X+C >u C2 -> (X & ~C2) != C 2369 // iff C & C2 == 0 2370 // C2+1 is a power of 2 2371 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && 2372 (*C2 & *C) == 0) 2373 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateAnd(X, ~(*C)), 2374 ConstantExpr::getNeg(cast<Constant>(Y))); 2375 2376 return nullptr; 2377 } 2378 2379 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2380 /// where X is some kind of instruction. 2381 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2382 const APInt *C; 2383 if (!match(Cmp.getOperand(1), m_APInt(C))) 2384 return nullptr; 2385 2386 BinaryOperator *BO; 2387 if (match(Cmp.getOperand(0), m_BinOp(BO))) { 2388 switch (BO->getOpcode()) { 2389 case Instruction::Xor: 2390 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C)) 2391 return I; 2392 break; 2393 case Instruction::And: 2394 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C)) 2395 return I; 2396 break; 2397 case Instruction::Or: 2398 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C)) 2399 return I; 2400 break; 2401 case Instruction::Mul: 2402 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C)) 2403 return I; 2404 break; 2405 case Instruction::Shl: 2406 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C)) 2407 return I; 2408 break; 2409 case Instruction::LShr: 2410 case Instruction::AShr: 2411 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C)) 2412 return I; 2413 break; 2414 case Instruction::UDiv: 2415 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C)) 2416 return I; 2417 LLVM_FALLTHROUGH; 2418 case Instruction::SDiv: 2419 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C)) 2420 return I; 2421 break; 2422 case Instruction::Sub: 2423 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C)) 2424 return I; 2425 break; 2426 case Instruction::Add: 2427 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C)) 2428 return I; 2429 break; 2430 default: 2431 break; 2432 } 2433 // TODO: These folds could be refactored to be part of the above calls. 2434 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, C)) 2435 return I; 2436 } 2437 2438 Instruction *LHSI; 2439 if (match(Cmp.getOperand(0), m_Instruction(LHSI)) && 2440 LHSI->getOpcode() == Instruction::Trunc) 2441 if (Instruction *I = foldICmpTruncConstant(Cmp, LHSI, C)) 2442 return I; 2443 2444 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, C)) 2445 return I; 2446 2447 return nullptr; 2448 } 2449 2450 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2451 /// icmp eq/ne BO, C. 2452 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2453 BinaryOperator *BO, 2454 const APInt *C) { 2455 // TODO: Some of these folds could work with arbitrary constants, but this 2456 // function is limited to scalar and vector splat constants. 2457 if (!Cmp.isEquality()) 2458 return nullptr; 2459 2460 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2461 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2462 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2463 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2464 2465 switch (BO->getOpcode()) { 2466 case Instruction::SRem: 2467 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2468 if (*C == 0 && BO->hasOneUse()) { 2469 const APInt *BOC; 2470 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2471 Value *NewRem = Builder->CreateURem(BOp0, BOp1, BO->getName()); 2472 return new ICmpInst(Pred, NewRem, 2473 Constant::getNullValue(BO->getType())); 2474 } 2475 } 2476 break; 2477 case Instruction::Add: { 2478 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2479 const APInt *BOC; 2480 if (match(BOp1, m_APInt(BOC))) { 2481 if (BO->hasOneUse()) { 2482 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1)); 2483 return new ICmpInst(Pred, BOp0, SubC); 2484 } 2485 } else if (*C == 0) { 2486 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2487 // efficiently invertible, or if the add has just this one use. 2488 if (Value *NegVal = dyn_castNegVal(BOp1)) 2489 return new ICmpInst(Pred, BOp0, NegVal); 2490 if (Value *NegVal = dyn_castNegVal(BOp0)) 2491 return new ICmpInst(Pred, NegVal, BOp1); 2492 if (BO->hasOneUse()) { 2493 Value *Neg = Builder->CreateNeg(BOp1); 2494 Neg->takeName(BO); 2495 return new ICmpInst(Pred, BOp0, Neg); 2496 } 2497 } 2498 break; 2499 } 2500 case Instruction::Xor: 2501 if (BO->hasOneUse()) { 2502 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2503 // For the xor case, we can xor two constants together, eliminating 2504 // the explicit xor. 2505 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2506 } else if (*C == 0) { 2507 // Replace ((xor A, B) != 0) with (A != B) 2508 return new ICmpInst(Pred, BOp0, BOp1); 2509 } 2510 } 2511 break; 2512 case Instruction::Sub: 2513 if (BO->hasOneUse()) { 2514 const APInt *BOC; 2515 if (match(BOp0, m_APInt(BOC))) { 2516 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2517 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS); 2518 return new ICmpInst(Pred, BOp1, SubC); 2519 } else if (*C == 0) { 2520 // Replace ((sub A, B) != 0) with (A != B). 2521 return new ICmpInst(Pred, BOp0, BOp1); 2522 } 2523 } 2524 break; 2525 case Instruction::Or: { 2526 const APInt *BOC; 2527 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 2528 // Comparing if all bits outside of a constant mask are set? 2529 // Replace (X | C) == -1 with (X & ~C) == ~C. 2530 // This removes the -1 constant. 2531 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 2532 Value *And = Builder->CreateAnd(BOp0, NotBOC); 2533 return new ICmpInst(Pred, And, NotBOC); 2534 } 2535 break; 2536 } 2537 case Instruction::And: { 2538 const APInt *BOC; 2539 if (match(BOp1, m_APInt(BOC))) { 2540 // If we have ((X & C) == C), turn it into ((X & C) != 0). 2541 if (C == BOC && C->isPowerOf2()) 2542 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 2543 BO, Constant::getNullValue(RHS->getType())); 2544 2545 // Don't perform the following transforms if the AND has multiple uses 2546 if (!BO->hasOneUse()) 2547 break; 2548 2549 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0 2550 if (BOC->isSignBit()) { 2551 Constant *Zero = Constant::getNullValue(BOp0->getType()); 2552 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 2553 return new ICmpInst(NewPred, BOp0, Zero); 2554 } 2555 2556 // ((X & ~7) == 0) --> X < 8 2557 if (*C == 0 && (~(*BOC) + 1).isPowerOf2()) { 2558 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1)); 2559 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 2560 return new ICmpInst(NewPred, BOp0, NegBOC); 2561 } 2562 } 2563 break; 2564 } 2565 case Instruction::Mul: 2566 if (*C == 0 && BO->hasNoSignedWrap()) { 2567 const APInt *BOC; 2568 if (match(BOp1, m_APInt(BOC)) && *BOC != 0) { 2569 // The trivial case (mul X, 0) is handled by InstSimplify. 2570 // General case : (mul X, C) != 0 iff X != 0 2571 // (mul X, C) == 0 iff X == 0 2572 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 2573 } 2574 } 2575 break; 2576 case Instruction::UDiv: 2577 if (*C == 0) { 2578 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 2579 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 2580 return new ICmpInst(NewPred, BOp1, BOp0); 2581 } 2582 break; 2583 default: 2584 break; 2585 } 2586 return nullptr; 2587 } 2588 2589 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 2590 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 2591 const APInt *C) { 2592 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)); 2593 if (!II || !Cmp.isEquality()) 2594 return nullptr; 2595 2596 // Handle icmp {eq|ne} <intrinsic>, intcst. 2597 switch (II->getIntrinsicID()) { 2598 case Intrinsic::bswap: 2599 Worklist.Add(II); 2600 Cmp.setOperand(0, II->getArgOperand(0)); 2601 Cmp.setOperand(1, Builder->getInt(C->byteSwap())); 2602 return &Cmp; 2603 case Intrinsic::ctlz: 2604 case Intrinsic::cttz: 2605 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 2606 if (*C == C->getBitWidth()) { 2607 Worklist.Add(II); 2608 Cmp.setOperand(0, II->getArgOperand(0)); 2609 Cmp.setOperand(1, ConstantInt::getNullValue(II->getType())); 2610 return &Cmp; 2611 } 2612 break; 2613 case Intrinsic::ctpop: { 2614 // popcount(A) == 0 -> A == 0 and likewise for != 2615 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 2616 bool IsZero = *C == 0; 2617 if (IsZero || *C == C->getBitWidth()) { 2618 Worklist.Add(II); 2619 Cmp.setOperand(0, II->getArgOperand(0)); 2620 auto *NewOp = IsZero ? Constant::getNullValue(II->getType()) 2621 : Constant::getAllOnesValue(II->getType()); 2622 Cmp.setOperand(1, NewOp); 2623 return &Cmp; 2624 } 2625 break; 2626 } 2627 default: 2628 break; 2629 } 2630 return nullptr; 2631 } 2632 2633 /// Handle icmp with constant (but not simple integer constant) RHS. 2634 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 2635 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2636 Constant *RHSC = dyn_cast<Constant>(Op1); 2637 Instruction *LHSI = dyn_cast<Instruction>(Op0); 2638 if (!RHSC || !LHSI) 2639 return nullptr; 2640 2641 switch (LHSI->getOpcode()) { 2642 case Instruction::GetElementPtr: 2643 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 2644 if (RHSC->isNullValue() && 2645 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 2646 return new ICmpInst( 2647 I.getPredicate(), LHSI->getOperand(0), 2648 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2649 break; 2650 case Instruction::PHI: 2651 // Only fold icmp into the PHI if the phi and icmp are in the same 2652 // block. If in the same block, we're encouraging jump threading. If 2653 // not, we are just pessimizing the code by making an i1 phi. 2654 if (LHSI->getParent() == I.getParent()) 2655 if (Instruction *NV = FoldOpIntoPhi(I)) 2656 return NV; 2657 break; 2658 case Instruction::Select: { 2659 // If either operand of the select is a constant, we can fold the 2660 // comparison into the select arms, which will cause one to be 2661 // constant folded and the select turned into a bitwise or. 2662 Value *Op1 = nullptr, *Op2 = nullptr; 2663 ConstantInt *CI = nullptr; 2664 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 2665 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2666 CI = dyn_cast<ConstantInt>(Op1); 2667 } 2668 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 2669 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2670 CI = dyn_cast<ConstantInt>(Op2); 2671 } 2672 2673 // We only want to perform this transformation if it will not lead to 2674 // additional code. This is true if either both sides of the select 2675 // fold to a constant (in which case the icmp is replaced with a select 2676 // which will usually simplify) or this is the only user of the 2677 // select (in which case we are trading a select+icmp for a simpler 2678 // select+icmp) or all uses of the select can be replaced based on 2679 // dominance information ("Global cases"). 2680 bool Transform = false; 2681 if (Op1 && Op2) 2682 Transform = true; 2683 else if (Op1 || Op2) { 2684 // Local case 2685 if (LHSI->hasOneUse()) 2686 Transform = true; 2687 // Global cases 2688 else if (CI && !CI->isZero()) 2689 // When Op1 is constant try replacing select with second operand. 2690 // Otherwise Op2 is constant and try replacing select with first 2691 // operand. 2692 Transform = 2693 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 2694 } 2695 if (Transform) { 2696 if (!Op1) 2697 Op1 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 2698 I.getName()); 2699 if (!Op2) 2700 Op2 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 2701 I.getName()); 2702 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 2703 } 2704 break; 2705 } 2706 case Instruction::IntToPtr: 2707 // icmp pred inttoptr(X), null -> icmp pred X, 0 2708 if (RHSC->isNullValue() && 2709 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 2710 return new ICmpInst( 2711 I.getPredicate(), LHSI->getOperand(0), 2712 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2713 break; 2714 2715 case Instruction::Load: 2716 // Try to optimize things like "A[i] > 4" to index computations. 2717 if (GetElementPtrInst *GEP = 2718 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 2719 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 2720 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 2721 !cast<LoadInst>(LHSI)->isVolatile()) 2722 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 2723 return Res; 2724 } 2725 break; 2726 } 2727 2728 return nullptr; 2729 } 2730 2731 /// Try to fold icmp (binop), X or icmp X, (binop). 2732 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) { 2733 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2734 2735 // Special logic for binary operators. 2736 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 2737 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 2738 if (!BO0 && !BO1) 2739 return nullptr; 2740 2741 CmpInst::Predicate Pred = I.getPredicate(); 2742 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 2743 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 2744 NoOp0WrapProblem = 2745 ICmpInst::isEquality(Pred) || 2746 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 2747 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 2748 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 2749 NoOp1WrapProblem = 2750 ICmpInst::isEquality(Pred) || 2751 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 2752 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 2753 2754 // Analyze the case when either Op0 or Op1 is an add instruction. 2755 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 2756 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 2757 if (BO0 && BO0->getOpcode() == Instruction::Add) { 2758 A = BO0->getOperand(0); 2759 B = BO0->getOperand(1); 2760 } 2761 if (BO1 && BO1->getOpcode() == Instruction::Add) { 2762 C = BO1->getOperand(0); 2763 D = BO1->getOperand(1); 2764 } 2765 2766 // icmp (X+cst) < 0 --> X < -cst 2767 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred) && match(Op1, m_Zero())) 2768 if (ConstantInt *RHSC = dyn_cast_or_null<ConstantInt>(B)) 2769 if (!RHSC->isMinValue(/*isSigned=*/true)) 2770 return new ICmpInst(Pred, A, ConstantExpr::getNeg(RHSC)); 2771 2772 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow. 2773 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 2774 return new ICmpInst(Pred, A == Op1 ? B : A, 2775 Constant::getNullValue(Op1->getType())); 2776 2777 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow. 2778 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 2779 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 2780 C == Op0 ? D : C); 2781 2782 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow. 2783 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 2784 NoOp1WrapProblem && 2785 // Try not to increase register pressure. 2786 BO0->hasOneUse() && BO1->hasOneUse()) { 2787 // Determine Y and Z in the form icmp (X+Y), (X+Z). 2788 Value *Y, *Z; 2789 if (A == C) { 2790 // C + B == C + D -> B == D 2791 Y = B; 2792 Z = D; 2793 } else if (A == D) { 2794 // D + B == C + D -> B == C 2795 Y = B; 2796 Z = C; 2797 } else if (B == C) { 2798 // A + C == C + D -> A == D 2799 Y = A; 2800 Z = D; 2801 } else { 2802 assert(B == D); 2803 // A + D == C + D -> A == C 2804 Y = A; 2805 Z = C; 2806 } 2807 return new ICmpInst(Pred, Y, Z); 2808 } 2809 2810 // icmp slt (X + -1), Y -> icmp sle X, Y 2811 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 2812 match(B, m_AllOnes())) 2813 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 2814 2815 // icmp sge (X + -1), Y -> icmp sgt X, Y 2816 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 2817 match(B, m_AllOnes())) 2818 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 2819 2820 // icmp sle (X + 1), Y -> icmp slt X, Y 2821 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 2822 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 2823 2824 // icmp sgt (X + 1), Y -> icmp sge X, Y 2825 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 2826 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 2827 2828 // icmp sgt X, (Y + -1) -> icmp sge X, Y 2829 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 2830 match(D, m_AllOnes())) 2831 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 2832 2833 // icmp sle X, (Y + -1) -> icmp slt X, Y 2834 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 2835 match(D, m_AllOnes())) 2836 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 2837 2838 // icmp sge X, (Y + 1) -> icmp sgt X, Y 2839 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 2840 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 2841 2842 // icmp slt X, (Y + 1) -> icmp sle X, Y 2843 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 2844 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 2845 2846 // if C1 has greater magnitude than C2: 2847 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y 2848 // s.t. C3 = C1 - C2 2849 // 2850 // if C2 has greater magnitude than C1: 2851 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3) 2852 // s.t. C3 = C2 - C1 2853 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 2854 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 2855 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 2856 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 2857 const APInt &AP1 = C1->getValue(); 2858 const APInt &AP2 = C2->getValue(); 2859 if (AP1.isNegative() == AP2.isNegative()) { 2860 APInt AP1Abs = C1->getValue().abs(); 2861 APInt AP2Abs = C2->getValue().abs(); 2862 if (AP1Abs.uge(AP2Abs)) { 2863 ConstantInt *C3 = Builder->getInt(AP1 - AP2); 2864 Value *NewAdd = Builder->CreateNSWAdd(A, C3); 2865 return new ICmpInst(Pred, NewAdd, C); 2866 } else { 2867 ConstantInt *C3 = Builder->getInt(AP2 - AP1); 2868 Value *NewAdd = Builder->CreateNSWAdd(C, C3); 2869 return new ICmpInst(Pred, A, NewAdd); 2870 } 2871 } 2872 } 2873 2874 // Analyze the case when either Op0 or Op1 is a sub instruction. 2875 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 2876 A = nullptr; 2877 B = nullptr; 2878 C = nullptr; 2879 D = nullptr; 2880 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 2881 A = BO0->getOperand(0); 2882 B = BO0->getOperand(1); 2883 } 2884 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 2885 C = BO1->getOperand(0); 2886 D = BO1->getOperand(1); 2887 } 2888 2889 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow. 2890 if (A == Op1 && NoOp0WrapProblem) 2891 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 2892 2893 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow. 2894 if (C == Op0 && NoOp1WrapProblem) 2895 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 2896 2897 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow. 2898 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem && 2899 // Try not to increase register pressure. 2900 BO0->hasOneUse() && BO1->hasOneUse()) 2901 return new ICmpInst(Pred, A, C); 2902 2903 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow. 2904 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem && 2905 // Try not to increase register pressure. 2906 BO0->hasOneUse() && BO1->hasOneUse()) 2907 return new ICmpInst(Pred, D, B); 2908 2909 // icmp (0-X) < cst --> x > -cst 2910 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 2911 Value *X; 2912 if (match(BO0, m_Neg(m_Value(X)))) 2913 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1)) 2914 if (!RHSC->isMinValue(/*isSigned=*/true)) 2915 return new ICmpInst(I.getSwappedPredicate(), X, 2916 ConstantExpr::getNeg(RHSC)); 2917 } 2918 2919 BinaryOperator *SRem = nullptr; 2920 // icmp (srem X, Y), Y 2921 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 2922 SRem = BO0; 2923 // icmp Y, (srem X, Y) 2924 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 2925 Op0 == BO1->getOperand(1)) 2926 SRem = BO1; 2927 if (SRem) { 2928 // We don't check hasOneUse to avoid increasing register pressure because 2929 // the value we use is the same value this instruction was already using. 2930 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 2931 default: 2932 break; 2933 case ICmpInst::ICMP_EQ: 2934 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 2935 case ICmpInst::ICMP_NE: 2936 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 2937 case ICmpInst::ICMP_SGT: 2938 case ICmpInst::ICMP_SGE: 2939 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 2940 Constant::getAllOnesValue(SRem->getType())); 2941 case ICmpInst::ICMP_SLT: 2942 case ICmpInst::ICMP_SLE: 2943 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 2944 Constant::getNullValue(SRem->getType())); 2945 } 2946 } 2947 2948 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 2949 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 2950 switch (BO0->getOpcode()) { 2951 default: 2952 break; 2953 case Instruction::Add: 2954 case Instruction::Sub: 2955 case Instruction::Xor: 2956 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 2957 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 2958 BO1->getOperand(0)); 2959 // icmp u/s (a ^ signbit), (b ^ signbit) --> icmp s/u a, b 2960 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) { 2961 if (CI->getValue().isSignBit()) { 2962 ICmpInst::Predicate Pred = 2963 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 2964 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 2965 } 2966 2967 if (BO0->getOpcode() == Instruction::Xor && CI->isMaxValue(true)) { 2968 ICmpInst::Predicate Pred = 2969 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 2970 Pred = I.getSwappedPredicate(Pred); 2971 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 2972 } 2973 } 2974 break; 2975 case Instruction::Mul: 2976 if (!I.isEquality()) 2977 break; 2978 2979 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) { 2980 // a * Cst icmp eq/ne b * Cst --> a & Mask icmp b & Mask 2981 // Mask = -1 >> count-trailing-zeros(Cst). 2982 if (!CI->isZero() && !CI->isOne()) { 2983 const APInt &AP = CI->getValue(); 2984 ConstantInt *Mask = ConstantInt::get( 2985 I.getContext(), 2986 APInt::getLowBitsSet(AP.getBitWidth(), 2987 AP.getBitWidth() - AP.countTrailingZeros())); 2988 Value *And1 = Builder->CreateAnd(BO0->getOperand(0), Mask); 2989 Value *And2 = Builder->CreateAnd(BO1->getOperand(0), Mask); 2990 return new ICmpInst(I.getPredicate(), And1, And2); 2991 } 2992 } 2993 break; 2994 case Instruction::UDiv: 2995 case Instruction::LShr: 2996 if (I.isSigned()) 2997 break; 2998 LLVM_FALLTHROUGH; 2999 case Instruction::SDiv: 3000 case Instruction::AShr: 3001 if (!BO0->isExact() || !BO1->isExact()) 3002 break; 3003 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 3004 BO1->getOperand(0)); 3005 case Instruction::Shl: { 3006 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 3007 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 3008 if (!NUW && !NSW) 3009 break; 3010 if (!NSW && I.isSigned()) 3011 break; 3012 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 3013 BO1->getOperand(0)); 3014 } 3015 } 3016 } 3017 3018 if (BO0) { 3019 // Transform A & (L - 1) `ult` L --> L != 0 3020 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 3021 auto BitwiseAnd = 3022 m_CombineOr(m_And(m_Value(), LSubOne), m_And(LSubOne, m_Value())); 3023 3024 if (match(BO0, BitwiseAnd) && I.getPredicate() == ICmpInst::ICMP_ULT) { 3025 auto *Zero = Constant::getNullValue(BO0->getType()); 3026 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 3027 } 3028 } 3029 3030 return nullptr; 3031 } 3032 3033 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 3034 if (!I.isEquality()) 3035 return nullptr; 3036 3037 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3038 Value *A, *B, *C, *D; 3039 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 3040 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 3041 Value *OtherVal = A == Op1 ? B : A; 3042 return new ICmpInst(I.getPredicate(), OtherVal, 3043 Constant::getNullValue(A->getType())); 3044 } 3045 3046 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 3047 // A^c1 == C^c2 --> A == C^(c1^c2) 3048 ConstantInt *C1, *C2; 3049 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 3050 Op1->hasOneUse()) { 3051 Constant *NC = Builder->getInt(C1->getValue() ^ C2->getValue()); 3052 Value *Xor = Builder->CreateXor(C, NC); 3053 return new ICmpInst(I.getPredicate(), A, Xor); 3054 } 3055 3056 // A^B == A^D -> B == D 3057 if (A == C) 3058 return new ICmpInst(I.getPredicate(), B, D); 3059 if (A == D) 3060 return new ICmpInst(I.getPredicate(), B, C); 3061 if (B == C) 3062 return new ICmpInst(I.getPredicate(), A, D); 3063 if (B == D) 3064 return new ICmpInst(I.getPredicate(), A, C); 3065 } 3066 } 3067 3068 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 3069 // A == (A^B) -> B == 0 3070 Value *OtherVal = A == Op0 ? B : A; 3071 return new ICmpInst(I.getPredicate(), OtherVal, 3072 Constant::getNullValue(A->getType())); 3073 } 3074 3075 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 3076 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 3077 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 3078 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 3079 3080 if (A == C) { 3081 X = B; 3082 Y = D; 3083 Z = A; 3084 } else if (A == D) { 3085 X = B; 3086 Y = C; 3087 Z = A; 3088 } else if (B == C) { 3089 X = A; 3090 Y = D; 3091 Z = B; 3092 } else if (B == D) { 3093 X = A; 3094 Y = C; 3095 Z = B; 3096 } 3097 3098 if (X) { // Build (X^Y) & Z 3099 Op1 = Builder->CreateXor(X, Y); 3100 Op1 = Builder->CreateAnd(Op1, Z); 3101 I.setOperand(0, Op1); 3102 I.setOperand(1, Constant::getNullValue(Op1->getType())); 3103 return &I; 3104 } 3105 } 3106 3107 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 3108 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 3109 ConstantInt *Cst1; 3110 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 3111 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 3112 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 3113 match(Op1, m_ZExt(m_Value(A))))) { 3114 APInt Pow2 = Cst1->getValue() + 1; 3115 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 3116 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 3117 return new ICmpInst(I.getPredicate(), A, 3118 Builder->CreateTrunc(B, A->getType())); 3119 } 3120 3121 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 3122 // For lshr and ashr pairs. 3123 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 3124 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 3125 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 3126 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 3127 unsigned TypeBits = Cst1->getBitWidth(); 3128 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3129 if (ShAmt < TypeBits && ShAmt != 0) { 3130 ICmpInst::Predicate Pred = I.getPredicate() == ICmpInst::ICMP_NE 3131 ? ICmpInst::ICMP_UGE 3132 : ICmpInst::ICMP_ULT; 3133 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted"); 3134 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 3135 return new ICmpInst(Pred, Xor, Builder->getInt(CmpVal)); 3136 } 3137 } 3138 3139 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 3140 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 3141 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 3142 unsigned TypeBits = Cst1->getBitWidth(); 3143 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3144 if (ShAmt < TypeBits && ShAmt != 0) { 3145 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted"); 3146 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 3147 Value *And = Builder->CreateAnd(Xor, Builder->getInt(AndVal), 3148 I.getName() + ".mask"); 3149 return new ICmpInst(I.getPredicate(), And, 3150 Constant::getNullValue(Cst1->getType())); 3151 } 3152 } 3153 3154 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 3155 // "icmp (and X, mask), cst" 3156 uint64_t ShAmt = 0; 3157 if (Op0->hasOneUse() && 3158 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 3159 match(Op1, m_ConstantInt(Cst1)) && 3160 // Only do this when A has multiple uses. This is most important to do 3161 // when it exposes other optimizations. 3162 !A->hasOneUse()) { 3163 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 3164 3165 if (ShAmt < ASize) { 3166 APInt MaskV = 3167 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 3168 MaskV <<= ShAmt; 3169 3170 APInt CmpV = Cst1->getValue().zext(ASize); 3171 CmpV <<= ShAmt; 3172 3173 Value *Mask = Builder->CreateAnd(A, Builder->getInt(MaskV)); 3174 return new ICmpInst(I.getPredicate(), Mask, Builder->getInt(CmpV)); 3175 } 3176 } 3177 3178 return nullptr; 3179 } 3180 3181 /// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so 3182 /// far. 3183 Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) { 3184 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0)); 3185 Value *LHSCIOp = LHSCI->getOperand(0); 3186 Type *SrcTy = LHSCIOp->getType(); 3187 Type *DestTy = LHSCI->getType(); 3188 Value *RHSCIOp; 3189 3190 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 3191 // integer type is the same size as the pointer type. 3192 if (LHSCI->getOpcode() == Instruction::PtrToInt && 3193 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) { 3194 Value *RHSOp = nullptr; 3195 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 3196 Value *RHSCIOp = RHSC->getOperand(0); 3197 if (RHSCIOp->getType()->getPointerAddressSpace() == 3198 LHSCIOp->getType()->getPointerAddressSpace()) { 3199 RHSOp = RHSC->getOperand(0); 3200 // If the pointer types don't match, insert a bitcast. 3201 if (LHSCIOp->getType() != RHSOp->getType()) 3202 RHSOp = Builder->CreateBitCast(RHSOp, LHSCIOp->getType()); 3203 } 3204 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 3205 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy); 3206 } 3207 3208 if (RHSOp) 3209 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp); 3210 } 3211 3212 // The code below only handles extension cast instructions, so far. 3213 // Enforce this. 3214 if (LHSCI->getOpcode() != Instruction::ZExt && 3215 LHSCI->getOpcode() != Instruction::SExt) 3216 return nullptr; 3217 3218 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt; 3219 bool isSignedCmp = ICmp.isSigned(); 3220 3221 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) { 3222 // Not an extension from the same type? 3223 RHSCIOp = CI->getOperand(0); 3224 if (RHSCIOp->getType() != LHSCIOp->getType()) 3225 return nullptr; 3226 3227 // If the signedness of the two casts doesn't agree (i.e. one is a sext 3228 // and the other is a zext), then we can't handle this. 3229 if (CI->getOpcode() != LHSCI->getOpcode()) 3230 return nullptr; 3231 3232 // Deal with equality cases early. 3233 if (ICmp.isEquality()) 3234 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3235 3236 // A signed comparison of sign extended values simplifies into a 3237 // signed comparison. 3238 if (isSignedCmp && isSignedExt) 3239 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3240 3241 // The other three cases all fold into an unsigned comparison. 3242 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp); 3243 } 3244 3245 // If we aren't dealing with a constant on the RHS, exit early. 3246 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 3247 if (!C) 3248 return nullptr; 3249 3250 // Compute the constant that would happen if we truncated to SrcTy then 3251 // re-extended to DestTy. 3252 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 3253 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy); 3254 3255 // If the re-extended constant didn't change... 3256 if (Res2 == C) { 3257 // Deal with equality cases early. 3258 if (ICmp.isEquality()) 3259 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3260 3261 // A signed comparison of sign extended values simplifies into a 3262 // signed comparison. 3263 if (isSignedExt && isSignedCmp) 3264 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3265 3266 // The other three cases all fold into an unsigned comparison. 3267 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1); 3268 } 3269 3270 // The re-extended constant changed, partly changed (in the case of a vector), 3271 // or could not be determined to be equal (in the case of a constant 3272 // expression), so the constant cannot be represented in the shorter type. 3273 // Consequently, we cannot emit a simple comparison. 3274 // All the cases that fold to true or false will have already been handled 3275 // by SimplifyICmpInst, so only deal with the tricky case. 3276 3277 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C)) 3278 return nullptr; 3279 3280 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases 3281 // should have been folded away previously and not enter in here. 3282 3283 // We're performing an unsigned comp with a sign extended value. 3284 // This is true if the input is >= 0. [aka >s -1] 3285 Constant *NegOne = Constant::getAllOnesValue(SrcTy); 3286 Value *Result = Builder->CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName()); 3287 3288 // Finally, return the value computed. 3289 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 3290 return replaceInstUsesWith(ICmp, Result); 3291 3292 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 3293 return BinaryOperator::CreateNot(Result); 3294 } 3295 3296 bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS, 3297 Value *RHS, Instruction &OrigI, 3298 Value *&Result, Constant *&Overflow) { 3299 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 3300 std::swap(LHS, RHS); 3301 3302 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) { 3303 Result = OpResult; 3304 Overflow = OverflowVal; 3305 if (ReuseName) 3306 Result->takeName(&OrigI); 3307 return true; 3308 }; 3309 3310 // If the overflow check was an add followed by a compare, the insertion point 3311 // may be pointing to the compare. We want to insert the new instructions 3312 // before the add in case there are uses of the add between the add and the 3313 // compare. 3314 Builder->SetInsertPoint(&OrigI); 3315 3316 switch (OCF) { 3317 case OCF_INVALID: 3318 llvm_unreachable("bad overflow check kind!"); 3319 3320 case OCF_UNSIGNED_ADD: { 3321 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI); 3322 if (OR == OverflowResult::NeverOverflows) 3323 return SetResult(Builder->CreateNUWAdd(LHS, RHS), Builder->getFalse(), 3324 true); 3325 3326 if (OR == OverflowResult::AlwaysOverflows) 3327 return SetResult(Builder->CreateAdd(LHS, RHS), Builder->getTrue(), true); 3328 3329 // Fall through uadd into sadd 3330 LLVM_FALLTHROUGH; 3331 } 3332 case OCF_SIGNED_ADD: { 3333 // X + 0 -> {X, false} 3334 if (match(RHS, m_Zero())) 3335 return SetResult(LHS, Builder->getFalse(), false); 3336 3337 // We can strength reduce this signed add into a regular add if we can prove 3338 // that it will never overflow. 3339 if (OCF == OCF_SIGNED_ADD) 3340 if (WillNotOverflowSignedAdd(LHS, RHS, OrigI)) 3341 return SetResult(Builder->CreateNSWAdd(LHS, RHS), Builder->getFalse(), 3342 true); 3343 break; 3344 } 3345 3346 case OCF_UNSIGNED_SUB: 3347 case OCF_SIGNED_SUB: { 3348 // X - 0 -> {X, false} 3349 if (match(RHS, m_Zero())) 3350 return SetResult(LHS, Builder->getFalse(), false); 3351 3352 if (OCF == OCF_SIGNED_SUB) { 3353 if (WillNotOverflowSignedSub(LHS, RHS, OrigI)) 3354 return SetResult(Builder->CreateNSWSub(LHS, RHS), Builder->getFalse(), 3355 true); 3356 } else { 3357 if (WillNotOverflowUnsignedSub(LHS, RHS, OrigI)) 3358 return SetResult(Builder->CreateNUWSub(LHS, RHS), Builder->getFalse(), 3359 true); 3360 } 3361 break; 3362 } 3363 3364 case OCF_UNSIGNED_MUL: { 3365 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI); 3366 if (OR == OverflowResult::NeverOverflows) 3367 return SetResult(Builder->CreateNUWMul(LHS, RHS), Builder->getFalse(), 3368 true); 3369 if (OR == OverflowResult::AlwaysOverflows) 3370 return SetResult(Builder->CreateMul(LHS, RHS), Builder->getTrue(), true); 3371 LLVM_FALLTHROUGH; 3372 } 3373 case OCF_SIGNED_MUL: 3374 // X * undef -> undef 3375 if (isa<UndefValue>(RHS)) 3376 return SetResult(RHS, UndefValue::get(Builder->getInt1Ty()), false); 3377 3378 // X * 0 -> {0, false} 3379 if (match(RHS, m_Zero())) 3380 return SetResult(RHS, Builder->getFalse(), false); 3381 3382 // X * 1 -> {X, false} 3383 if (match(RHS, m_One())) 3384 return SetResult(LHS, Builder->getFalse(), false); 3385 3386 if (OCF == OCF_SIGNED_MUL) 3387 if (WillNotOverflowSignedMul(LHS, RHS, OrigI)) 3388 return SetResult(Builder->CreateNSWMul(LHS, RHS), Builder->getFalse(), 3389 true); 3390 break; 3391 } 3392 3393 return false; 3394 } 3395 3396 /// \brief Recognize and process idiom involving test for multiplication 3397 /// overflow. 3398 /// 3399 /// The caller has matched a pattern of the form: 3400 /// I = cmp u (mul(zext A, zext B), V 3401 /// The function checks if this is a test for overflow and if so replaces 3402 /// multiplication with call to 'mul.with.overflow' intrinsic. 3403 /// 3404 /// \param I Compare instruction. 3405 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 3406 /// the compare instruction. Must be of integer type. 3407 /// \param OtherVal The other argument of compare instruction. 3408 /// \returns Instruction which must replace the compare instruction, NULL if no 3409 /// replacement required. 3410 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 3411 Value *OtherVal, InstCombiner &IC) { 3412 // Don't bother doing this transformation for pointers, don't do it for 3413 // vectors. 3414 if (!isa<IntegerType>(MulVal->getType())) 3415 return nullptr; 3416 3417 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 3418 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 3419 auto *MulInstr = dyn_cast<Instruction>(MulVal); 3420 if (!MulInstr) 3421 return nullptr; 3422 assert(MulInstr->getOpcode() == Instruction::Mul); 3423 3424 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 3425 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 3426 assert(LHS->getOpcode() == Instruction::ZExt); 3427 assert(RHS->getOpcode() == Instruction::ZExt); 3428 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 3429 3430 // Calculate type and width of the result produced by mul.with.overflow. 3431 Type *TyA = A->getType(), *TyB = B->getType(); 3432 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 3433 WidthB = TyB->getPrimitiveSizeInBits(); 3434 unsigned MulWidth; 3435 Type *MulType; 3436 if (WidthB > WidthA) { 3437 MulWidth = WidthB; 3438 MulType = TyB; 3439 } else { 3440 MulWidth = WidthA; 3441 MulType = TyA; 3442 } 3443 3444 // In order to replace the original mul with a narrower mul.with.overflow, 3445 // all uses must ignore upper bits of the product. The number of used low 3446 // bits must be not greater than the width of mul.with.overflow. 3447 if (MulVal->hasNUsesOrMore(2)) 3448 for (User *U : MulVal->users()) { 3449 if (U == &I) 3450 continue; 3451 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3452 // Check if truncation ignores bits above MulWidth. 3453 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 3454 if (TruncWidth > MulWidth) 3455 return nullptr; 3456 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3457 // Check if AND ignores bits above MulWidth. 3458 if (BO->getOpcode() != Instruction::And) 3459 return nullptr; 3460 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 3461 const APInt &CVal = CI->getValue(); 3462 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 3463 return nullptr; 3464 } 3465 } else { 3466 // Other uses prohibit this transformation. 3467 return nullptr; 3468 } 3469 } 3470 3471 // Recognize patterns 3472 switch (I.getPredicate()) { 3473 case ICmpInst::ICMP_EQ: 3474 case ICmpInst::ICMP_NE: 3475 // Recognize pattern: 3476 // mulval = mul(zext A, zext B) 3477 // cmp eq/neq mulval, zext trunc mulval 3478 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 3479 if (Zext->hasOneUse()) { 3480 Value *ZextArg = Zext->getOperand(0); 3481 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 3482 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 3483 break; //Recognized 3484 } 3485 3486 // Recognize pattern: 3487 // mulval = mul(zext A, zext B) 3488 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 3489 ConstantInt *CI; 3490 Value *ValToMask; 3491 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 3492 if (ValToMask != MulVal) 3493 return nullptr; 3494 const APInt &CVal = CI->getValue() + 1; 3495 if (CVal.isPowerOf2()) { 3496 unsigned MaskWidth = CVal.logBase2(); 3497 if (MaskWidth == MulWidth) 3498 break; // Recognized 3499 } 3500 } 3501 return nullptr; 3502 3503 case ICmpInst::ICMP_UGT: 3504 // Recognize pattern: 3505 // mulval = mul(zext A, zext B) 3506 // cmp ugt mulval, max 3507 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3508 APInt MaxVal = APInt::getMaxValue(MulWidth); 3509 MaxVal = MaxVal.zext(CI->getBitWidth()); 3510 if (MaxVal.eq(CI->getValue())) 3511 break; // Recognized 3512 } 3513 return nullptr; 3514 3515 case ICmpInst::ICMP_UGE: 3516 // Recognize pattern: 3517 // mulval = mul(zext A, zext B) 3518 // cmp uge mulval, max+1 3519 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3520 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3521 if (MaxVal.eq(CI->getValue())) 3522 break; // Recognized 3523 } 3524 return nullptr; 3525 3526 case ICmpInst::ICMP_ULE: 3527 // Recognize pattern: 3528 // mulval = mul(zext A, zext B) 3529 // cmp ule mulval, max 3530 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3531 APInt MaxVal = APInt::getMaxValue(MulWidth); 3532 MaxVal = MaxVal.zext(CI->getBitWidth()); 3533 if (MaxVal.eq(CI->getValue())) 3534 break; // Recognized 3535 } 3536 return nullptr; 3537 3538 case ICmpInst::ICMP_ULT: 3539 // Recognize pattern: 3540 // mulval = mul(zext A, zext B) 3541 // cmp ule mulval, max + 1 3542 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3543 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3544 if (MaxVal.eq(CI->getValue())) 3545 break; // Recognized 3546 } 3547 return nullptr; 3548 3549 default: 3550 return nullptr; 3551 } 3552 3553 InstCombiner::BuilderTy *Builder = IC.Builder; 3554 Builder->SetInsertPoint(MulInstr); 3555 3556 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 3557 Value *MulA = A, *MulB = B; 3558 if (WidthA < MulWidth) 3559 MulA = Builder->CreateZExt(A, MulType); 3560 if (WidthB < MulWidth) 3561 MulB = Builder->CreateZExt(B, MulType); 3562 Value *F = Intrinsic::getDeclaration(I.getModule(), 3563 Intrinsic::umul_with_overflow, MulType); 3564 CallInst *Call = Builder->CreateCall(F, {MulA, MulB}, "umul"); 3565 IC.Worklist.Add(MulInstr); 3566 3567 // If there are uses of mul result other than the comparison, we know that 3568 // they are truncation or binary AND. Change them to use result of 3569 // mul.with.overflow and adjust properly mask/size. 3570 if (MulVal->hasNUsesOrMore(2)) { 3571 Value *Mul = Builder->CreateExtractValue(Call, 0, "umul.value"); 3572 for (User *U : MulVal->users()) { 3573 if (U == &I || U == OtherVal) 3574 continue; 3575 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3576 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 3577 IC.replaceInstUsesWith(*TI, Mul); 3578 else 3579 TI->setOperand(0, Mul); 3580 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3581 assert(BO->getOpcode() == Instruction::And); 3582 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 3583 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 3584 APInt ShortMask = CI->getValue().trunc(MulWidth); 3585 Value *ShortAnd = Builder->CreateAnd(Mul, ShortMask); 3586 Instruction *Zext = 3587 cast<Instruction>(Builder->CreateZExt(ShortAnd, BO->getType())); 3588 IC.Worklist.Add(Zext); 3589 IC.replaceInstUsesWith(*BO, Zext); 3590 } else { 3591 llvm_unreachable("Unexpected Binary operation"); 3592 } 3593 IC.Worklist.Add(cast<Instruction>(U)); 3594 } 3595 } 3596 if (isa<Instruction>(OtherVal)) 3597 IC.Worklist.Add(cast<Instruction>(OtherVal)); 3598 3599 // The original icmp gets replaced with the overflow value, maybe inverted 3600 // depending on predicate. 3601 bool Inverse = false; 3602 switch (I.getPredicate()) { 3603 case ICmpInst::ICMP_NE: 3604 break; 3605 case ICmpInst::ICMP_EQ: 3606 Inverse = true; 3607 break; 3608 case ICmpInst::ICMP_UGT: 3609 case ICmpInst::ICMP_UGE: 3610 if (I.getOperand(0) == MulVal) 3611 break; 3612 Inverse = true; 3613 break; 3614 case ICmpInst::ICMP_ULT: 3615 case ICmpInst::ICMP_ULE: 3616 if (I.getOperand(1) == MulVal) 3617 break; 3618 Inverse = true; 3619 break; 3620 default: 3621 llvm_unreachable("Unexpected predicate"); 3622 } 3623 if (Inverse) { 3624 Value *Res = Builder->CreateExtractValue(Call, 1); 3625 return BinaryOperator::CreateNot(Res); 3626 } 3627 3628 return ExtractValueInst::Create(Call, 1); 3629 } 3630 3631 /// When performing a comparison against a constant, it is possible that not all 3632 /// the bits in the LHS are demanded. This helper method computes the mask that 3633 /// IS demanded. 3634 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth, 3635 bool isSignCheck) { 3636 if (isSignCheck) 3637 return APInt::getSignBit(BitWidth); 3638 3639 ConstantInt *CI = dyn_cast<ConstantInt>(I.getOperand(1)); 3640 if (!CI) return APInt::getAllOnesValue(BitWidth); 3641 const APInt &RHS = CI->getValue(); 3642 3643 switch (I.getPredicate()) { 3644 // For a UGT comparison, we don't care about any bits that 3645 // correspond to the trailing ones of the comparand. The value of these 3646 // bits doesn't impact the outcome of the comparison, because any value 3647 // greater than the RHS must differ in a bit higher than these due to carry. 3648 case ICmpInst::ICMP_UGT: { 3649 unsigned trailingOnes = RHS.countTrailingOnes(); 3650 APInt lowBitsSet = APInt::getLowBitsSet(BitWidth, trailingOnes); 3651 return ~lowBitsSet; 3652 } 3653 3654 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 3655 // Any value less than the RHS must differ in a higher bit because of carries. 3656 case ICmpInst::ICMP_ULT: { 3657 unsigned trailingZeros = RHS.countTrailingZeros(); 3658 APInt lowBitsSet = APInt::getLowBitsSet(BitWidth, trailingZeros); 3659 return ~lowBitsSet; 3660 } 3661 3662 default: 3663 return APInt::getAllOnesValue(BitWidth); 3664 } 3665 } 3666 3667 /// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst 3668 /// should be swapped. 3669 /// The decision is based on how many times these two operands are reused 3670 /// as subtract operands and their positions in those instructions. 3671 /// The rational is that several architectures use the same instruction for 3672 /// both subtract and cmp, thus it is better if the order of those operands 3673 /// match. 3674 /// \return true if Op0 and Op1 should be swapped. 3675 static bool swapMayExposeCSEOpportunities(const Value * Op0, 3676 const Value * Op1) { 3677 // Filter out pointer value as those cannot appears directly in subtract. 3678 // FIXME: we may want to go through inttoptrs or bitcasts. 3679 if (Op0->getType()->isPointerTy()) 3680 return false; 3681 // Count every uses of both Op0 and Op1 in a subtract. 3682 // Each time Op0 is the first operand, count -1: swapping is bad, the 3683 // subtract has already the same layout as the compare. 3684 // Each time Op0 is the second operand, count +1: swapping is good, the 3685 // subtract has a different layout as the compare. 3686 // At the end, if the benefit is greater than 0, Op0 should come second to 3687 // expose more CSE opportunities. 3688 int GlobalSwapBenefits = 0; 3689 for (const User *U : Op0->users()) { 3690 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U); 3691 if (!BinOp || BinOp->getOpcode() != Instruction::Sub) 3692 continue; 3693 // If Op0 is the first argument, this is not beneficial to swap the 3694 // arguments. 3695 int LocalSwapBenefits = -1; 3696 unsigned Op1Idx = 1; 3697 if (BinOp->getOperand(Op1Idx) == Op0) { 3698 Op1Idx = 0; 3699 LocalSwapBenefits = 1; 3700 } 3701 if (BinOp->getOperand(Op1Idx) != Op1) 3702 continue; 3703 GlobalSwapBenefits += LocalSwapBenefits; 3704 } 3705 return GlobalSwapBenefits > 0; 3706 } 3707 3708 /// \brief Check that one use is in the same block as the definition and all 3709 /// other uses are in blocks dominated by a given block. 3710 /// 3711 /// \param DI Definition 3712 /// \param UI Use 3713 /// \param DB Block that must dominate all uses of \p DI outside 3714 /// the parent block 3715 /// \return true when \p UI is the only use of \p DI in the parent block 3716 /// and all other uses of \p DI are in blocks dominated by \p DB. 3717 /// 3718 bool InstCombiner::dominatesAllUses(const Instruction *DI, 3719 const Instruction *UI, 3720 const BasicBlock *DB) const { 3721 assert(DI && UI && "Instruction not defined\n"); 3722 // Ignore incomplete definitions. 3723 if (!DI->getParent()) 3724 return false; 3725 // DI and UI must be in the same block. 3726 if (DI->getParent() != UI->getParent()) 3727 return false; 3728 // Protect from self-referencing blocks. 3729 if (DI->getParent() == DB) 3730 return false; 3731 for (const User *U : DI->users()) { 3732 auto *Usr = cast<Instruction>(U); 3733 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 3734 return false; 3735 } 3736 return true; 3737 } 3738 3739 /// Return true when the instruction sequence within a block is select-cmp-br. 3740 static bool isChainSelectCmpBranch(const SelectInst *SI) { 3741 const BasicBlock *BB = SI->getParent(); 3742 if (!BB) 3743 return false; 3744 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 3745 if (!BI || BI->getNumSuccessors() != 2) 3746 return false; 3747 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 3748 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 3749 return false; 3750 return true; 3751 } 3752 3753 /// \brief True when a select result is replaced by one of its operands 3754 /// in select-icmp sequence. This will eventually result in the elimination 3755 /// of the select. 3756 /// 3757 /// \param SI Select instruction 3758 /// \param Icmp Compare instruction 3759 /// \param SIOpd Operand that replaces the select 3760 /// 3761 /// Notes: 3762 /// - The replacement is global and requires dominator information 3763 /// - The caller is responsible for the actual replacement 3764 /// 3765 /// Example: 3766 /// 3767 /// entry: 3768 /// %4 = select i1 %3, %C* %0, %C* null 3769 /// %5 = icmp eq %C* %4, null 3770 /// br i1 %5, label %9, label %7 3771 /// ... 3772 /// ; <label>:7 ; preds = %entry 3773 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 3774 /// ... 3775 /// 3776 /// can be transformed to 3777 /// 3778 /// %5 = icmp eq %C* %0, null 3779 /// %6 = select i1 %3, i1 %5, i1 true 3780 /// br i1 %6, label %9, label %7 3781 /// ... 3782 /// ; <label>:7 ; preds = %entry 3783 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 3784 /// 3785 /// Similar when the first operand of the select is a constant or/and 3786 /// the compare is for not equal rather than equal. 3787 /// 3788 /// NOTE: The function is only called when the select and compare constants 3789 /// are equal, the optimization can work only for EQ predicates. This is not a 3790 /// major restriction since a NE compare should be 'normalized' to an equal 3791 /// compare, which usually happens in the combiner and test case 3792 /// select-cmp-br.ll checks for it. 3793 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 3794 const ICmpInst *Icmp, 3795 const unsigned SIOpd) { 3796 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 3797 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 3798 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 3799 // The check for the unique predecessor is not the best that can be 3800 // done. But it protects efficiently against cases like when SI's 3801 // home block has two successors, Succ and Succ1, and Succ1 predecessor 3802 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 3803 // replaced can be reached on either path. So the uniqueness check 3804 // guarantees that the path all uses of SI (outside SI's parent) are on 3805 // is disjoint from all other paths out of SI. But that information 3806 // is more expensive to compute, and the trade-off here is in favor 3807 // of compile-time. 3808 if (Succ->getUniquePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 3809 NumSel++; 3810 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 3811 return true; 3812 } 3813 } 3814 return false; 3815 } 3816 3817 /// Try to fold the comparison based on range information we can get by checking 3818 /// whether bits are known to be zero or one in the inputs. 3819 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 3820 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3821 Type *Ty = Op0->getType(); 3822 ICmpInst::Predicate Pred = I.getPredicate(); 3823 3824 // Get scalar or pointer size. 3825 unsigned BitWidth = Ty->isIntOrIntVectorTy() 3826 ? Ty->getScalarSizeInBits() 3827 : DL.getTypeSizeInBits(Ty->getScalarType()); 3828 3829 if (!BitWidth) 3830 return nullptr; 3831 3832 // If this is a normal comparison, it demands all bits. If it is a sign bit 3833 // comparison, it only demands the sign bit. 3834 bool IsSignBit = false; 3835 const APInt *CmpC; 3836 if (match(Op1, m_APInt(CmpC))) { 3837 bool UnusedBit; 3838 IsSignBit = isSignBitCheck(Pred, *CmpC, UnusedBit); 3839 } 3840 3841 APInt Op0KnownZero(BitWidth, 0), Op0KnownOne(BitWidth, 0); 3842 APInt Op1KnownZero(BitWidth, 0), Op1KnownOne(BitWidth, 0); 3843 3844 if (SimplifyDemandedBits(I.getOperandUse(0), 3845 getDemandedBitsLHSMask(I, BitWidth, IsSignBit), 3846 Op0KnownZero, Op0KnownOne, 0)) 3847 return &I; 3848 3849 if (SimplifyDemandedBits(I.getOperandUse(1), APInt::getAllOnesValue(BitWidth), 3850 Op1KnownZero, Op1KnownOne, 0)) 3851 return &I; 3852 3853 // Given the known and unknown bits, compute a range that the LHS could be 3854 // in. Compute the Min, Max and RHS values based on the known bits. For the 3855 // EQ and NE we use unsigned values. 3856 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 3857 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 3858 if (I.isSigned()) { 3859 computeSignedMinMaxValuesFromKnownBits(Op0KnownZero, Op0KnownOne, Op0Min, 3860 Op0Max); 3861 computeSignedMinMaxValuesFromKnownBits(Op1KnownZero, Op1KnownOne, Op1Min, 3862 Op1Max); 3863 } else { 3864 computeUnsignedMinMaxValuesFromKnownBits(Op0KnownZero, Op0KnownOne, Op0Min, 3865 Op0Max); 3866 computeUnsignedMinMaxValuesFromKnownBits(Op1KnownZero, Op1KnownOne, Op1Min, 3867 Op1Max); 3868 } 3869 3870 // If Min and Max are known to be the same, then SimplifyDemandedBits 3871 // figured out that the LHS is a constant. Constant fold this now, so that 3872 // code below can assume that Min != Max. 3873 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 3874 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1); 3875 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 3876 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min)); 3877 3878 // Based on the range information we know about the LHS, see if we can 3879 // simplify this comparison. For example, (x&4) < 8 is always true. 3880 switch (Pred) { 3881 default: 3882 llvm_unreachable("Unknown icmp opcode!"); 3883 case ICmpInst::ICMP_EQ: 3884 case ICmpInst::ICMP_NE: { 3885 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 3886 return Pred == CmpInst::ICMP_EQ 3887 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 3888 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3889 } 3890 3891 // If all bits are known zero except for one, then we know at most one bit 3892 // is set. If the comparison is against zero, then this is a check to see if 3893 // *that* bit is set. 3894 APInt Op0KnownZeroInverted = ~Op0KnownZero; 3895 if (~Op1KnownZero == 0) { 3896 // If the LHS is an AND with the same constant, look through it. 3897 Value *LHS = nullptr; 3898 const APInt *LHSC; 3899 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 3900 *LHSC != Op0KnownZeroInverted) 3901 LHS = Op0; 3902 3903 Value *X; 3904 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 3905 APInt ValToCheck = Op0KnownZeroInverted; 3906 Type *XTy = X->getType(); 3907 if (ValToCheck.isPowerOf2()) { 3908 // ((1 << X) & 8) == 0 -> X != 3 3909 // ((1 << X) & 8) != 0 -> X == 3 3910 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 3911 auto NewPred = ICmpInst::getInversePredicate(Pred); 3912 return new ICmpInst(NewPred, X, CmpC); 3913 } else if ((++ValToCheck).isPowerOf2()) { 3914 // ((1 << X) & 7) == 0 -> X >= 3 3915 // ((1 << X) & 7) != 0 -> X < 3 3916 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 3917 auto NewPred = 3918 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 3919 return new ICmpInst(NewPred, X, CmpC); 3920 } 3921 } 3922 3923 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 3924 const APInt *CI; 3925 if (Op0KnownZeroInverted == 1 && 3926 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 3927 // ((8 >>u X) & 1) == 0 -> X != 3 3928 // ((8 >>u X) & 1) != 0 -> X == 3 3929 unsigned CmpVal = CI->countTrailingZeros(); 3930 auto NewPred = ICmpInst::getInversePredicate(Pred); 3931 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 3932 } 3933 } 3934 break; 3935 } 3936 case ICmpInst::ICMP_ULT: { 3937 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 3938 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3939 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 3940 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3941 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 3942 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 3943 3944 const APInt *CmpC; 3945 if (match(Op1, m_APInt(CmpC))) { 3946 // A <u C -> A == C-1 if min(A)+1 == C 3947 if (Op1Max == Op0Min + 1) { 3948 Constant *CMinus1 = ConstantInt::get(Op0->getType(), *CmpC - 1); 3949 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, CMinus1); 3950 } 3951 // (x <u 2147483648) -> (x >s -1) -> true if sign bit clear 3952 if (CmpC->isMinSignedValue()) { 3953 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 3954 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 3955 } 3956 } 3957 break; 3958 } 3959 case ICmpInst::ICMP_UGT: { 3960 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 3961 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3962 3963 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 3964 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3965 3966 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 3967 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 3968 3969 const APInt *CmpC; 3970 if (match(Op1, m_APInt(CmpC))) { 3971 // A >u C -> A == C+1 if max(a)-1 == C 3972 if (*CmpC == Op0Max - 1) 3973 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 3974 ConstantInt::get(Op1->getType(), *CmpC + 1)); 3975 3976 // (x >u 2147483647) -> (x <s 0) -> true if sign bit set 3977 if (CmpC->isMaxSignedValue()) 3978 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, 3979 Constant::getNullValue(Op0->getType())); 3980 } 3981 break; 3982 } 3983 case ICmpInst::ICMP_SLT: 3984 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 3985 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3986 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 3987 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3988 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 3989 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 3990 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) { 3991 if (Op1Max == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 3992 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 3993 Builder->getInt(CI->getValue() - 1)); 3994 } 3995 break; 3996 case ICmpInst::ICMP_SGT: 3997 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 3998 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3999 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 4000 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4001 4002 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 4003 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4004 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) { 4005 if (Op1Min == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 4006 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4007 Builder->getInt(CI->getValue() + 1)); 4008 } 4009 break; 4010 case ICmpInst::ICMP_SGE: 4011 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 4012 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 4013 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4014 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 4015 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4016 break; 4017 case ICmpInst::ICMP_SLE: 4018 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 4019 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 4020 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4021 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 4022 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4023 break; 4024 case ICmpInst::ICMP_UGE: 4025 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 4026 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 4027 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4028 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 4029 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4030 break; 4031 case ICmpInst::ICMP_ULE: 4032 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 4033 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 4034 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4035 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 4036 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4037 break; 4038 } 4039 4040 // Turn a signed comparison into an unsigned one if both operands are known to 4041 // have the same sign. 4042 if (I.isSigned() && 4043 ((Op0KnownZero.isNegative() && Op1KnownZero.isNegative()) || 4044 (Op0KnownOne.isNegative() && Op1KnownOne.isNegative()))) 4045 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 4046 4047 return nullptr; 4048 } 4049 4050 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 4051 /// it into the appropriate icmp lt or icmp gt instruction. This transform 4052 /// allows them to be folded in visitICmpInst. 4053 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 4054 ICmpInst::Predicate Pred = I.getPredicate(); 4055 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE && 4056 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE) 4057 return nullptr; 4058 4059 Value *Op0 = I.getOperand(0); 4060 Value *Op1 = I.getOperand(1); 4061 auto *Op1C = dyn_cast<Constant>(Op1); 4062 if (!Op1C) 4063 return nullptr; 4064 4065 // Check if the constant operand can be safely incremented/decremented without 4066 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled 4067 // the edge cases for us, so we just assert on them. For vectors, we must 4068 // handle the edge cases. 4069 Type *Op1Type = Op1->getType(); 4070 bool IsSigned = I.isSigned(); 4071 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE); 4072 auto *CI = dyn_cast<ConstantInt>(Op1C); 4073 if (CI) { 4074 // A <= MAX -> TRUE ; A >= MIN -> TRUE 4075 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned)); 4076 } else if (Op1Type->isVectorTy()) { 4077 // TODO? If the edge cases for vectors were guaranteed to be handled as they 4078 // are for scalar, we could remove the min/max checks. However, to do that, 4079 // we would have to use insertelement/shufflevector to replace edge values. 4080 unsigned NumElts = Op1Type->getVectorNumElements(); 4081 for (unsigned i = 0; i != NumElts; ++i) { 4082 Constant *Elt = Op1C->getAggregateElement(i); 4083 if (!Elt) 4084 return nullptr; 4085 4086 if (isa<UndefValue>(Elt)) 4087 continue; 4088 4089 // Bail out if we can't determine if this constant is min/max or if we 4090 // know that this constant is min/max. 4091 auto *CI = dyn_cast<ConstantInt>(Elt); 4092 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned))) 4093 return nullptr; 4094 } 4095 } else { 4096 // ConstantExpr? 4097 return nullptr; 4098 } 4099 4100 // Increment or decrement the constant and set the new comparison predicate: 4101 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT 4102 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true); 4103 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT; 4104 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred; 4105 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne)); 4106 } 4107 4108 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 4109 bool Changed = false; 4110 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4111 unsigned Op0Cplxity = getComplexity(Op0); 4112 unsigned Op1Cplxity = getComplexity(Op1); 4113 4114 /// Orders the operands of the compare so that they are listed from most 4115 /// complex to least complex. This puts constants before unary operators, 4116 /// before binary operators. 4117 if (Op0Cplxity < Op1Cplxity || 4118 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 4119 I.swapOperands(); 4120 std::swap(Op0, Op1); 4121 Changed = true; 4122 } 4123 4124 if (Value *V = 4125 SimplifyICmpInst(I.getPredicate(), Op0, Op1, DL, &TLI, &DT, &AC, &I)) 4126 return replaceInstUsesWith(I, V); 4127 4128 // comparing -val or val with non-zero is the same as just comparing val 4129 // ie, abs(val) != 0 -> val != 0 4130 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 4131 Value *Cond, *SelectTrue, *SelectFalse; 4132 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 4133 m_Value(SelectFalse)))) { 4134 if (Value *V = dyn_castNegVal(SelectTrue)) { 4135 if (V == SelectFalse) 4136 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4137 } 4138 else if (Value *V = dyn_castNegVal(SelectFalse)) { 4139 if (V == SelectTrue) 4140 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4141 } 4142 } 4143 } 4144 4145 Type *Ty = Op0->getType(); 4146 4147 // icmp's with boolean values can always be turned into bitwise operations 4148 if (Ty->getScalarType()->isIntegerTy(1)) { 4149 switch (I.getPredicate()) { 4150 default: llvm_unreachable("Invalid icmp instruction!"); 4151 case ICmpInst::ICMP_EQ: { // icmp eq i1 A, B -> ~(A^B) 4152 Value *Xor = Builder->CreateXor(Op0, Op1, I.getName() + "tmp"); 4153 return BinaryOperator::CreateNot(Xor); 4154 } 4155 case ICmpInst::ICMP_NE: // icmp ne i1 A, B -> A^B 4156 return BinaryOperator::CreateXor(Op0, Op1); 4157 4158 case ICmpInst::ICMP_UGT: 4159 std::swap(Op0, Op1); // Change icmp ugt -> icmp ult 4160 LLVM_FALLTHROUGH; 4161 case ICmpInst::ICMP_ULT:{ // icmp ult i1 A, B -> ~A & B 4162 Value *Not = Builder->CreateNot(Op0, I.getName() + "tmp"); 4163 return BinaryOperator::CreateAnd(Not, Op1); 4164 } 4165 case ICmpInst::ICMP_SGT: 4166 std::swap(Op0, Op1); // Change icmp sgt -> icmp slt 4167 LLVM_FALLTHROUGH; 4168 case ICmpInst::ICMP_SLT: { // icmp slt i1 A, B -> A & ~B 4169 Value *Not = Builder->CreateNot(Op1, I.getName() + "tmp"); 4170 return BinaryOperator::CreateAnd(Not, Op0); 4171 } 4172 case ICmpInst::ICMP_UGE: 4173 std::swap(Op0, Op1); // Change icmp uge -> icmp ule 4174 LLVM_FALLTHROUGH; 4175 case ICmpInst::ICMP_ULE: { // icmp ule i1 A, B -> ~A | B 4176 Value *Not = Builder->CreateNot(Op0, I.getName() + "tmp"); 4177 return BinaryOperator::CreateOr(Not, Op1); 4178 } 4179 case ICmpInst::ICMP_SGE: 4180 std::swap(Op0, Op1); // Change icmp sge -> icmp sle 4181 LLVM_FALLTHROUGH; 4182 case ICmpInst::ICMP_SLE: { // icmp sle i1 A, B -> A | ~B 4183 Value *Not = Builder->CreateNot(Op1, I.getName() + "tmp"); 4184 return BinaryOperator::CreateOr(Not, Op0); 4185 } 4186 } 4187 } 4188 4189 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 4190 return NewICmp; 4191 4192 if (Instruction *Res = foldICmpWithConstant(I)) 4193 return Res; 4194 4195 if (Instruction *Res = foldICmpUsingKnownBits(I)) 4196 return Res; 4197 4198 // Test if the ICmpInst instruction is used exclusively by a select as 4199 // part of a minimum or maximum operation. If so, refrain from doing 4200 // any other folding. This helps out other analyses which understand 4201 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4202 // and CodeGen. And in this case, at least one of the comparison 4203 // operands has at least one user besides the compare (the select), 4204 // which would often largely negate the benefit of folding anyway. 4205 if (I.hasOneUse()) 4206 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4207 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4208 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4209 return nullptr; 4210 4211 if (Instruction *Res = foldICmpInstWithConstant(I)) 4212 return Res; 4213 4214 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 4215 return Res; 4216 4217 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 4218 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 4219 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 4220 return NI; 4221 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 4222 if (Instruction *NI = foldGEPICmp(GEP, Op0, 4223 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 4224 return NI; 4225 4226 // Try to optimize equality comparisons against alloca-based pointers. 4227 if (Op0->getType()->isPointerTy() && I.isEquality()) { 4228 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 4229 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 4230 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 4231 return New; 4232 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 4233 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 4234 return New; 4235 } 4236 4237 // Test to see if the operands of the icmp are casted versions of other 4238 // values. If the ptr->ptr cast can be stripped off both arguments, we do so 4239 // now. 4240 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) { 4241 if (Op0->getType()->isPointerTy() && 4242 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 4243 // We keep moving the cast from the left operand over to the right 4244 // operand, where it can often be eliminated completely. 4245 Op0 = CI->getOperand(0); 4246 4247 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 4248 // so eliminate it as well. 4249 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1)) 4250 Op1 = CI2->getOperand(0); 4251 4252 // If Op1 is a constant, we can fold the cast into the constant. 4253 if (Op0->getType() != Op1->getType()) { 4254 if (Constant *Op1C = dyn_cast<Constant>(Op1)) { 4255 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType()); 4256 } else { 4257 // Otherwise, cast the RHS right before the icmp 4258 Op1 = Builder->CreateBitCast(Op1, Op0->getType()); 4259 } 4260 } 4261 return new ICmpInst(I.getPredicate(), Op0, Op1); 4262 } 4263 } 4264 4265 if (isa<CastInst>(Op0)) { 4266 // Handle the special case of: icmp (cast bool to X), <cst> 4267 // This comes up when you have code like 4268 // int X = A < B; 4269 // if (X) ... 4270 // For generality, we handle any zero-extension of any operand comparison 4271 // with a constant or another cast from the same type. 4272 if (isa<Constant>(Op1) || isa<CastInst>(Op1)) 4273 if (Instruction *R = foldICmpWithCastAndCast(I)) 4274 return R; 4275 } 4276 4277 if (Instruction *Res = foldICmpBinOp(I)) 4278 return Res; 4279 4280 { 4281 Value *A, *B; 4282 // Transform (A & ~B) == 0 --> (A & B) != 0 4283 // and (A & ~B) != 0 --> (A & B) == 0 4284 // if A is a power of 2. 4285 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 4286 match(Op1, m_Zero()) && 4287 isKnownToBeAPowerOfTwo(A, DL, false, 0, &AC, &I, &DT) && I.isEquality()) 4288 return new ICmpInst(I.getInversePredicate(), 4289 Builder->CreateAnd(A, B), 4290 Op1); 4291 4292 // ~x < ~y --> y < x 4293 // ~x < cst --> ~cst < x 4294 if (match(Op0, m_Not(m_Value(A)))) { 4295 if (match(Op1, m_Not(m_Value(B)))) 4296 return new ICmpInst(I.getPredicate(), B, A); 4297 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1)) 4298 return new ICmpInst(I.getPredicate(), ConstantExpr::getNot(RHSC), A); 4299 } 4300 4301 Instruction *AddI = nullptr; 4302 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 4303 m_Instruction(AddI))) && 4304 isa<IntegerType>(A->getType())) { 4305 Value *Result; 4306 Constant *Overflow; 4307 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result, 4308 Overflow)) { 4309 replaceInstUsesWith(*AddI, Result); 4310 return replaceInstUsesWith(I, Overflow); 4311 } 4312 } 4313 4314 // (zext a) * (zext b) --> llvm.umul.with.overflow. 4315 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4316 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 4317 return R; 4318 } 4319 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4320 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 4321 return R; 4322 } 4323 } 4324 4325 if (Instruction *Res = foldICmpEquality(I)) 4326 return Res; 4327 4328 // The 'cmpxchg' instruction returns an aggregate containing the old value and 4329 // an i1 which indicates whether or not we successfully did the swap. 4330 // 4331 // Replace comparisons between the old value and the expected value with the 4332 // indicator that 'cmpxchg' returns. 4333 // 4334 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 4335 // spuriously fail. In those cases, the old value may equal the expected 4336 // value but it is possible for the swap to not occur. 4337 if (I.getPredicate() == ICmpInst::ICMP_EQ) 4338 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 4339 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 4340 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 4341 !ACXI->isWeak()) 4342 return ExtractValueInst::Create(ACXI, 1); 4343 4344 { 4345 Value *X; ConstantInt *Cst; 4346 // icmp X+Cst, X 4347 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X) 4348 return foldICmpAddOpConst(I, X, Cst, I.getPredicate()); 4349 4350 // icmp X, X+Cst 4351 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X) 4352 return foldICmpAddOpConst(I, X, Cst, I.getSwappedPredicate()); 4353 } 4354 return Changed ? &I : nullptr; 4355 } 4356 4357 /// Fold fcmp ([us]itofp x, cst) if possible. 4358 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 4359 Constant *RHSC) { 4360 if (!isa<ConstantFP>(RHSC)) return nullptr; 4361 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 4362 4363 // Get the width of the mantissa. We don't want to hack on conversions that 4364 // might lose information from the integer, e.g. "i64 -> float" 4365 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 4366 if (MantissaWidth == -1) return nullptr; // Unknown. 4367 4368 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 4369 4370 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 4371 4372 if (I.isEquality()) { 4373 FCmpInst::Predicate P = I.getPredicate(); 4374 bool IsExact = false; 4375 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 4376 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 4377 4378 // If the floating point constant isn't an integer value, we know if we will 4379 // ever compare equal / not equal to it. 4380 if (!IsExact) { 4381 // TODO: Can never be -0.0 and other non-representable values 4382 APFloat RHSRoundInt(RHS); 4383 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 4384 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) { 4385 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 4386 return replaceInstUsesWith(I, Builder->getFalse()); 4387 4388 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 4389 return replaceInstUsesWith(I, Builder->getTrue()); 4390 } 4391 } 4392 4393 // TODO: If the constant is exactly representable, is it always OK to do 4394 // equality compares as integer? 4395 } 4396 4397 // Check to see that the input is converted from an integer type that is small 4398 // enough that preserves all bits. TODO: check here for "known" sign bits. 4399 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 4400 unsigned InputSize = IntTy->getScalarSizeInBits(); 4401 4402 // Following test does NOT adjust InputSize downwards for signed inputs, 4403 // because the most negative value still requires all the mantissa bits 4404 // to distinguish it from one less than that value. 4405 if ((int)InputSize > MantissaWidth) { 4406 // Conversion would lose accuracy. Check if loss can impact comparison. 4407 int Exp = ilogb(RHS); 4408 if (Exp == APFloat::IEK_Inf) { 4409 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 4410 if (MaxExponent < (int)InputSize - !LHSUnsigned) 4411 // Conversion could create infinity. 4412 return nullptr; 4413 } else { 4414 // Note that if RHS is zero or NaN, then Exp is negative 4415 // and first condition is trivially false. 4416 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 4417 // Conversion could affect comparison. 4418 return nullptr; 4419 } 4420 } 4421 4422 // Otherwise, we can potentially simplify the comparison. We know that it 4423 // will always come through as an integer value and we know the constant is 4424 // not a NAN (it would have been previously simplified). 4425 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 4426 4427 ICmpInst::Predicate Pred; 4428 switch (I.getPredicate()) { 4429 default: llvm_unreachable("Unexpected predicate!"); 4430 case FCmpInst::FCMP_UEQ: 4431 case FCmpInst::FCMP_OEQ: 4432 Pred = ICmpInst::ICMP_EQ; 4433 break; 4434 case FCmpInst::FCMP_UGT: 4435 case FCmpInst::FCMP_OGT: 4436 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 4437 break; 4438 case FCmpInst::FCMP_UGE: 4439 case FCmpInst::FCMP_OGE: 4440 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 4441 break; 4442 case FCmpInst::FCMP_ULT: 4443 case FCmpInst::FCMP_OLT: 4444 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 4445 break; 4446 case FCmpInst::FCMP_ULE: 4447 case FCmpInst::FCMP_OLE: 4448 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 4449 break; 4450 case FCmpInst::FCMP_UNE: 4451 case FCmpInst::FCMP_ONE: 4452 Pred = ICmpInst::ICMP_NE; 4453 break; 4454 case FCmpInst::FCMP_ORD: 4455 return replaceInstUsesWith(I, Builder->getTrue()); 4456 case FCmpInst::FCMP_UNO: 4457 return replaceInstUsesWith(I, Builder->getFalse()); 4458 } 4459 4460 // Now we know that the APFloat is a normal number, zero or inf. 4461 4462 // See if the FP constant is too large for the integer. For example, 4463 // comparing an i8 to 300.0. 4464 unsigned IntWidth = IntTy->getScalarSizeInBits(); 4465 4466 if (!LHSUnsigned) { 4467 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 4468 // and large values. 4469 APFloat SMax(RHS.getSemantics()); 4470 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 4471 APFloat::rmNearestTiesToEven); 4472 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0 4473 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 4474 Pred == ICmpInst::ICMP_SLE) 4475 return replaceInstUsesWith(I, Builder->getTrue()); 4476 return replaceInstUsesWith(I, Builder->getFalse()); 4477 } 4478 } else { 4479 // If the RHS value is > UnsignedMax, fold the comparison. This handles 4480 // +INF and large values. 4481 APFloat UMax(RHS.getSemantics()); 4482 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 4483 APFloat::rmNearestTiesToEven); 4484 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0 4485 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 4486 Pred == ICmpInst::ICMP_ULE) 4487 return replaceInstUsesWith(I, Builder->getTrue()); 4488 return replaceInstUsesWith(I, Builder->getFalse()); 4489 } 4490 } 4491 4492 if (!LHSUnsigned) { 4493 // See if the RHS value is < SignedMin. 4494 APFloat SMin(RHS.getSemantics()); 4495 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 4496 APFloat::rmNearestTiesToEven); 4497 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0 4498 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 4499 Pred == ICmpInst::ICMP_SGE) 4500 return replaceInstUsesWith(I, Builder->getTrue()); 4501 return replaceInstUsesWith(I, Builder->getFalse()); 4502 } 4503 } else { 4504 // See if the RHS value is < UnsignedMin. 4505 APFloat SMin(RHS.getSemantics()); 4506 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true, 4507 APFloat::rmNearestTiesToEven); 4508 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0 4509 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 4510 Pred == ICmpInst::ICMP_UGE) 4511 return replaceInstUsesWith(I, Builder->getTrue()); 4512 return replaceInstUsesWith(I, Builder->getFalse()); 4513 } 4514 } 4515 4516 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 4517 // [0, UMAX], but it may still be fractional. See if it is fractional by 4518 // casting the FP value to the integer value and back, checking for equality. 4519 // Don't do this for zero, because -0.0 is not fractional. 4520 Constant *RHSInt = LHSUnsigned 4521 ? ConstantExpr::getFPToUI(RHSC, IntTy) 4522 : ConstantExpr::getFPToSI(RHSC, IntTy); 4523 if (!RHS.isZero()) { 4524 bool Equal = LHSUnsigned 4525 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 4526 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 4527 if (!Equal) { 4528 // If we had a comparison against a fractional value, we have to adjust 4529 // the compare predicate and sometimes the value. RHSC is rounded towards 4530 // zero at this point. 4531 switch (Pred) { 4532 default: llvm_unreachable("Unexpected integer comparison!"); 4533 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 4534 return replaceInstUsesWith(I, Builder->getTrue()); 4535 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 4536 return replaceInstUsesWith(I, Builder->getFalse()); 4537 case ICmpInst::ICMP_ULE: 4538 // (float)int <= 4.4 --> int <= 4 4539 // (float)int <= -4.4 --> false 4540 if (RHS.isNegative()) 4541 return replaceInstUsesWith(I, Builder->getFalse()); 4542 break; 4543 case ICmpInst::ICMP_SLE: 4544 // (float)int <= 4.4 --> int <= 4 4545 // (float)int <= -4.4 --> int < -4 4546 if (RHS.isNegative()) 4547 Pred = ICmpInst::ICMP_SLT; 4548 break; 4549 case ICmpInst::ICMP_ULT: 4550 // (float)int < -4.4 --> false 4551 // (float)int < 4.4 --> int <= 4 4552 if (RHS.isNegative()) 4553 return replaceInstUsesWith(I, Builder->getFalse()); 4554 Pred = ICmpInst::ICMP_ULE; 4555 break; 4556 case ICmpInst::ICMP_SLT: 4557 // (float)int < -4.4 --> int < -4 4558 // (float)int < 4.4 --> int <= 4 4559 if (!RHS.isNegative()) 4560 Pred = ICmpInst::ICMP_SLE; 4561 break; 4562 case ICmpInst::ICMP_UGT: 4563 // (float)int > 4.4 --> int > 4 4564 // (float)int > -4.4 --> true 4565 if (RHS.isNegative()) 4566 return replaceInstUsesWith(I, Builder->getTrue()); 4567 break; 4568 case ICmpInst::ICMP_SGT: 4569 // (float)int > 4.4 --> int > 4 4570 // (float)int > -4.4 --> int >= -4 4571 if (RHS.isNegative()) 4572 Pred = ICmpInst::ICMP_SGE; 4573 break; 4574 case ICmpInst::ICMP_UGE: 4575 // (float)int >= -4.4 --> true 4576 // (float)int >= 4.4 --> int > 4 4577 if (RHS.isNegative()) 4578 return replaceInstUsesWith(I, Builder->getTrue()); 4579 Pred = ICmpInst::ICMP_UGT; 4580 break; 4581 case ICmpInst::ICMP_SGE: 4582 // (float)int >= -4.4 --> int >= -4 4583 // (float)int >= 4.4 --> int > 4 4584 if (!RHS.isNegative()) 4585 Pred = ICmpInst::ICMP_SGT; 4586 break; 4587 } 4588 } 4589 } 4590 4591 // Lower this FP comparison into an appropriate integer version of the 4592 // comparison. 4593 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 4594 } 4595 4596 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 4597 bool Changed = false; 4598 4599 /// Orders the operands of the compare so that they are listed from most 4600 /// complex to least complex. This puts constants before unary operators, 4601 /// before binary operators. 4602 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 4603 I.swapOperands(); 4604 Changed = true; 4605 } 4606 4607 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4608 4609 if (Value *V = SimplifyFCmpInst(I.getPredicate(), Op0, Op1, 4610 I.getFastMathFlags(), DL, &TLI, &DT, &AC, &I)) 4611 return replaceInstUsesWith(I, V); 4612 4613 // Simplify 'fcmp pred X, X' 4614 if (Op0 == Op1) { 4615 switch (I.getPredicate()) { 4616 default: llvm_unreachable("Unknown predicate!"); 4617 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 4618 case FCmpInst::FCMP_ULT: // True if unordered or less than 4619 case FCmpInst::FCMP_UGT: // True if unordered or greater than 4620 case FCmpInst::FCMP_UNE: // True if unordered or not equal 4621 // Canonicalize these to be 'fcmp uno %X, 0.0'. 4622 I.setPredicate(FCmpInst::FCMP_UNO); 4623 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4624 return &I; 4625 4626 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 4627 case FCmpInst::FCMP_OEQ: // True if ordered and equal 4628 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 4629 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 4630 // Canonicalize these to be 'fcmp ord %X, 0.0'. 4631 I.setPredicate(FCmpInst::FCMP_ORD); 4632 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4633 return &I; 4634 } 4635 } 4636 4637 // Test if the FCmpInst instruction is used exclusively by a select as 4638 // part of a minimum or maximum operation. If so, refrain from doing 4639 // any other folding. This helps out other analyses which understand 4640 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4641 // and CodeGen. And in this case, at least one of the comparison 4642 // operands has at least one user besides the compare (the select), 4643 // which would often largely negate the benefit of folding anyway. 4644 if (I.hasOneUse()) 4645 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4646 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4647 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4648 return nullptr; 4649 4650 // Handle fcmp with constant RHS 4651 if (Constant *RHSC = dyn_cast<Constant>(Op1)) { 4652 if (Instruction *LHSI = dyn_cast<Instruction>(Op0)) 4653 switch (LHSI->getOpcode()) { 4654 case Instruction::FPExt: { 4655 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless 4656 FPExtInst *LHSExt = cast<FPExtInst>(LHSI); 4657 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC); 4658 if (!RHSF) 4659 break; 4660 4661 const fltSemantics *Sem; 4662 // FIXME: This shouldn't be here. 4663 if (LHSExt->getSrcTy()->isHalfTy()) 4664 Sem = &APFloat::IEEEhalf; 4665 else if (LHSExt->getSrcTy()->isFloatTy()) 4666 Sem = &APFloat::IEEEsingle; 4667 else if (LHSExt->getSrcTy()->isDoubleTy()) 4668 Sem = &APFloat::IEEEdouble; 4669 else if (LHSExt->getSrcTy()->isFP128Ty()) 4670 Sem = &APFloat::IEEEquad; 4671 else if (LHSExt->getSrcTy()->isX86_FP80Ty()) 4672 Sem = &APFloat::x87DoubleExtended; 4673 else if (LHSExt->getSrcTy()->isPPC_FP128Ty()) 4674 Sem = &APFloat::PPCDoubleDouble; 4675 else 4676 break; 4677 4678 bool Lossy; 4679 APFloat F = RHSF->getValueAPF(); 4680 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy); 4681 4682 // Avoid lossy conversions and denormals. Zero is a special case 4683 // that's OK to convert. 4684 APFloat Fabs = F; 4685 Fabs.clearSign(); 4686 if (!Lossy && 4687 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) != 4688 APFloat::cmpLessThan) || Fabs.isZero())) 4689 4690 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0), 4691 ConstantFP::get(RHSC->getContext(), F)); 4692 break; 4693 } 4694 case Instruction::PHI: 4695 // Only fold fcmp into the PHI if the phi and fcmp are in the same 4696 // block. If in the same block, we're encouraging jump threading. If 4697 // not, we are just pessimizing the code by making an i1 phi. 4698 if (LHSI->getParent() == I.getParent()) 4699 if (Instruction *NV = FoldOpIntoPhi(I)) 4700 return NV; 4701 break; 4702 case Instruction::SIToFP: 4703 case Instruction::UIToFP: 4704 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 4705 return NV; 4706 break; 4707 case Instruction::FSub: { 4708 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C 4709 Value *Op; 4710 if (match(LHSI, m_FNeg(m_Value(Op)))) 4711 return new FCmpInst(I.getSwappedPredicate(), Op, 4712 ConstantExpr::getFNeg(RHSC)); 4713 break; 4714 } 4715 case Instruction::Load: 4716 if (GetElementPtrInst *GEP = 4717 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 4718 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 4719 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 4720 !cast<LoadInst>(LHSI)->isVolatile()) 4721 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 4722 return Res; 4723 } 4724 break; 4725 case Instruction::Call: { 4726 if (!RHSC->isNullValue()) 4727 break; 4728 4729 CallInst *CI = cast<CallInst>(LHSI); 4730 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI); 4731 if (IID != Intrinsic::fabs) 4732 break; 4733 4734 // Various optimization for fabs compared with zero. 4735 switch (I.getPredicate()) { 4736 default: 4737 break; 4738 // fabs(x) < 0 --> false 4739 case FCmpInst::FCMP_OLT: 4740 llvm_unreachable("handled by SimplifyFCmpInst"); 4741 // fabs(x) > 0 --> x != 0 4742 case FCmpInst::FCMP_OGT: 4743 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC); 4744 // fabs(x) <= 0 --> x == 0 4745 case FCmpInst::FCMP_OLE: 4746 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC); 4747 // fabs(x) >= 0 --> !isnan(x) 4748 case FCmpInst::FCMP_OGE: 4749 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC); 4750 // fabs(x) == 0 --> x == 0 4751 // fabs(x) != 0 --> x != 0 4752 case FCmpInst::FCMP_OEQ: 4753 case FCmpInst::FCMP_UEQ: 4754 case FCmpInst::FCMP_ONE: 4755 case FCmpInst::FCMP_UNE: 4756 return new FCmpInst(I.getPredicate(), CI->getArgOperand(0), RHSC); 4757 } 4758 } 4759 } 4760 } 4761 4762 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y 4763 Value *X, *Y; 4764 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 4765 return new FCmpInst(I.getSwappedPredicate(), X, Y); 4766 4767 // fcmp (fpext x), (fpext y) -> fcmp x, y 4768 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0)) 4769 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1)) 4770 if (LHSExt->getSrcTy() == RHSExt->getSrcTy()) 4771 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0), 4772 RHSExt->getOperand(0)); 4773 4774 return Changed ? &I : nullptr; 4775 } 4776